* [PATCH v3 0/4] Staging: rtl8188eu: Remove NULL comparision.
@ 2016-03-19 10:41 Sandhya Bankar
2016-03-19 10:44 ` [PATCH v3 1/4] Staging: rtl8188eu: Hal8188ERateAdaptive: Use x instead of x != NULL Sandhya Bankar
` (3 more replies)
0 siblings, 4 replies; 5+ messages in thread
From: Sandhya Bankar @ 2016-03-19 10:41 UTC (permalink / raw)
To: outreachy-kernel
Remove NULL comparision.This issues is detected by checkpatch.pl script.
changes in v3:
*correcting the heading.
Sandhya Bankar (4):
Staging: rtl8188eu: Hal8188ERateAdaptive: Use x instead of x != NULL.
Staging: rtl8188eu: hal_intf: Use x instead of x != NULL.
Staging: rtl8188eu: rtl8188e_rxdesc: Use !x instead of x == NULL.
Staging: rtl8188eu: usb_halinit: Use !x instead of x == NULL.
drivers/staging/rtl8188eu/hal/Hal8188ERateAdaptive.c | 2 +-
drivers/staging/rtl8188eu/hal/hal_intf.c | 2 +-
drivers/staging/rtl8188eu/hal/rtl8188e_rxdesc.c | 2 +-
drivers/staging/rtl8188eu/hal/usb_halinit.c | 2 +-
4 files changed, 4 insertions(+), 4 deletions(-)
--
1.8.3.4
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH v3 1/4] Staging: rtl8188eu: Hal8188ERateAdaptive: Use x instead of x != NULL.
2016-03-19 10:41 [PATCH v3 0/4] Staging: rtl8188eu: Remove NULL comparision Sandhya Bankar
@ 2016-03-19 10:44 ` Sandhya Bankar
2016-03-19 10:46 ` [PATCH v3 2/4] Staging: rtl8188eu: hal_intf: " Sandhya Bankar
` (2 subsequent siblings)
3 siblings, 0 replies; 5+ messages in thread
From: Sandhya Bankar @ 2016-03-19 10:44 UTC (permalink / raw)
To: outreachy-kernel
Use x instead of x != NULL.
Signed-off-by: Sandhya Bankar <bankarsandhya512@gmail.com>
---
drivers/staging/rtl8188eu/hal/Hal8188ERateAdaptive.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/rtl8188eu/hal/Hal8188ERateAdaptive.c b/drivers/staging/rtl8188eu/hal/Hal8188ERateAdaptive.c
index a108e80..201c15b 100644
--- a/drivers/staging/rtl8188eu/hal/Hal8188ERateAdaptive.c
+++ b/drivers/staging/rtl8188eu/hal/Hal8188ERateAdaptive.c
@@ -557,7 +557,7 @@ int ODM_RAInfo_Init(struct odm_dm_struct *dm_odm, u8 macid)
u8 WirelessMode = 0xFF; /* invalid value */
u8 max_rate_idx = 0x13; /* MCS7 */
- if (dm_odm->pWirelessMode != NULL)
+ if (dm_odm->pWirelessMode)
WirelessMode = *(dm_odm->pWirelessMode);
if (WirelessMode != 0xFF) {
--
1.8.3.4
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [PATCH v3 2/4] Staging: rtl8188eu: hal_intf: Use x instead of x != NULL.
2016-03-19 10:41 [PATCH v3 0/4] Staging: rtl8188eu: Remove NULL comparision Sandhya Bankar
2016-03-19 10:44 ` [PATCH v3 1/4] Staging: rtl8188eu: Hal8188ERateAdaptive: Use x instead of x != NULL Sandhya Bankar
@ 2016-03-19 10:46 ` Sandhya Bankar
2016-03-19 10:48 ` [PATCH v3 3/4] Staging: rtl8188eu: rtl8188e_rxdesc: Use !x instead of x == NULL Sandhya Bankar
2016-03-19 10:50 ` [PATCH v3 4/4] Staging: rtl8188eu: usb_halinit: " Sandhya Bankar
3 siblings, 0 replies; 5+ messages in thread
From: Sandhya Bankar @ 2016-03-19 10:46 UTC (permalink / raw)
To: outreachy-kernel
Use x instead of x != NULL.
Signed-off-by: Sandhya Bankar <bankarsandhya512@gmail.com>
---
drivers/staging/rtl8188eu/hal/hal_intf.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/rtl8188eu/hal/hal_intf.c b/drivers/staging/rtl8188eu/hal/hal_intf.c
index 85c17ef..fb7bacb 100644
--- a/drivers/staging/rtl8188eu/hal/hal_intf.c
+++ b/drivers/staging/rtl8188eu/hal/hal_intf.c
@@ -186,7 +186,7 @@ s32 rtw_hal_mgnt_xmit(struct adapter *adapt, struct xmit_frame *pmgntframe)
s32 rtw_hal_init_xmit_priv(struct adapter *adapt)
{
- if (adapt->HalFunc.init_xmit_priv != NULL)
+ if (adapt->HalFunc.init_xmit_priv)
return adapt->HalFunc.init_xmit_priv(adapt);
return _FAIL;
}
--
1.8.3.4
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [PATCH v3 3/4] Staging: rtl8188eu: rtl8188e_rxdesc: Use !x instead of x == NULL.
2016-03-19 10:41 [PATCH v3 0/4] Staging: rtl8188eu: Remove NULL comparision Sandhya Bankar
2016-03-19 10:44 ` [PATCH v3 1/4] Staging: rtl8188eu: Hal8188ERateAdaptive: Use x instead of x != NULL Sandhya Bankar
2016-03-19 10:46 ` [PATCH v3 2/4] Staging: rtl8188eu: hal_intf: " Sandhya Bankar
@ 2016-03-19 10:48 ` Sandhya Bankar
2016-03-19 10:50 ` [PATCH v3 4/4] Staging: rtl8188eu: usb_halinit: " Sandhya Bankar
3 siblings, 0 replies; 5+ messages in thread
From: Sandhya Bankar @ 2016-03-19 10:48 UTC (permalink / raw)
To: outreachy-kernel
Use !x instead of x == NULL.
Signed-off-by: Sandhya Bankar <bankarsandhya512@gmail.com>
---
drivers/staging/rtl8188eu/hal/rtl8188e_rxdesc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/rtl8188eu/hal/rtl8188e_rxdesc.c b/drivers/staging/rtl8188eu/hal/rtl8188e_rxdesc.c
index 53cf3ba..c7e48f1 100644
--- a/drivers/staging/rtl8188eu/hal/rtl8188e_rxdesc.c
+++ b/drivers/staging/rtl8188eu/hal/rtl8188e_rxdesc.c
@@ -45,7 +45,7 @@ static void process_link_qual(struct adapter *padapter,
struct rx_pkt_attrib *pattrib;
struct signal_stat *signal_stat;
- if (prframe == NULL || padapter == NULL)
+ if (!prframe || !padapter)
return;
pattrib = &prframe->attrib;
--
1.8.3.4
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [PATCH v3 4/4] Staging: rtl8188eu: usb_halinit: Use !x instead of x == NULL.
2016-03-19 10:41 [PATCH v3 0/4] Staging: rtl8188eu: Remove NULL comparision Sandhya Bankar
` (2 preceding siblings ...)
2016-03-19 10:48 ` [PATCH v3 3/4] Staging: rtl8188eu: rtl8188e_rxdesc: Use !x instead of x == NULL Sandhya Bankar
@ 2016-03-19 10:50 ` Sandhya Bankar
3 siblings, 0 replies; 5+ messages in thread
From: Sandhya Bankar @ 2016-03-19 10:50 UTC (permalink / raw)
To: outreachy-kernel
Use !x instead of x == NULL.
Signed-off-by: Sandhya Bankar <bankarsandhya512@gmail.com>
---
drivers/staging/rtl8188eu/hal/usb_halinit.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/rtl8188eu/hal/usb_halinit.c b/drivers/staging/rtl8188eu/hal/usb_halinit.c
index 07a61b8..e25c38b 100644
--- a/drivers/staging/rtl8188eu/hal/usb_halinit.c
+++ b/drivers/staging/rtl8188eu/hal/usb_halinit.c
@@ -2083,7 +2083,7 @@ void rtl8188eu_set_hal_ops(struct adapter *adapt)
adapt->HalData = kzalloc(sizeof(struct hal_data_8188e), GFP_KERNEL);
- if (adapt->HalData == NULL)
+ if (!adapt->HalData)
DBG_88E("cant not alloc memory for HAL DATA\n");
halfunc->hal_power_on = rtl8188eu_InitPowerOn;
--
1.8.3.4
^ permalink raw reply related [flat|nested] 5+ messages in thread
end of thread, other threads:[~2016-03-19 17:49 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-03-19 10:41 [PATCH v3 0/4] Staging: rtl8188eu: Remove NULL comparision Sandhya Bankar
2016-03-19 10:44 ` [PATCH v3 1/4] Staging: rtl8188eu: Hal8188ERateAdaptive: Use x instead of x != NULL Sandhya Bankar
2016-03-19 10:46 ` [PATCH v3 2/4] Staging: rtl8188eu: hal_intf: " Sandhya Bankar
2016-03-19 10:48 ` [PATCH v3 3/4] Staging: rtl8188eu: rtl8188e_rxdesc: Use !x instead of x == NULL Sandhya Bankar
2016-03-19 10:50 ` [PATCH v3 4/4] Staging: rtl8188eu: usb_halinit: " Sandhya Bankar
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.