* [PATCH][scsi-next] scsi: core: remove redundant assignment to shost->use_blk_mq
@ 2018-03-28 16:41 ` Colin King
0 siblings, 0 replies; 6+ messages in thread
From: Colin King @ 2018-03-28 16:41 UTC (permalink / raw)
To: James E . J . Bottomley, Martin K . Petersen, linux-scsi
Cc: kernel-janitors, linux-kernel
From: Colin Ian King <colin.king@canonical.com>
The first assignment to shost->use_blk_mq is redundant as it is
overwritten by the following statement. Remove this redundant code.
Detected by CoverityScan, CID#1466993 ("Unused value")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
drivers/scsi/hosts.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/scsi/hosts.c b/drivers/scsi/hosts.c
index 7649d63a1b8d..3771e59a9fae 100644
--- a/drivers/scsi/hosts.c
+++ b/drivers/scsi/hosts.c
@@ -472,7 +472,6 @@ struct Scsi_Host *scsi_host_alloc(struct scsi_host_template *sht, int privsize)
else
shost->dma_boundary = 0xffffffff;
- shost->use_blk_mq = scsi_use_blk_mq;
shost->use_blk_mq = scsi_use_blk_mq || shost->hostt->force_blk_mq;
device_initialize(&shost->shost_gendev);
--
2.15.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH][scsi-next] scsi: core: remove redundant assignment to shost->use_blk_mq
@ 2018-03-28 16:41 ` Colin King
0 siblings, 0 replies; 6+ messages in thread
From: Colin King @ 2018-03-28 16:41 UTC (permalink / raw)
To: James E . J . Bottomley, Martin K . Petersen, linux-scsi
Cc: kernel-janitors, linux-kernel
From: Colin Ian King <colin.king@canonical.com>
The first assignment to shost->use_blk_mq is redundant as it is
overwritten by the following statement. Remove this redundant code.
Detected by CoverityScan, CID#1466993 ("Unused value")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
drivers/scsi/hosts.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/scsi/hosts.c b/drivers/scsi/hosts.c
index 7649d63a1b8d..3771e59a9fae 100644
--- a/drivers/scsi/hosts.c
+++ b/drivers/scsi/hosts.c
@@ -472,7 +472,6 @@ struct Scsi_Host *scsi_host_alloc(struct scsi_host_template *sht, int privsize)
else
shost->dma_boundary = 0xffffffff;
- shost->use_blk_mq = scsi_use_blk_mq;
shost->use_blk_mq = scsi_use_blk_mq || shost->hostt->force_blk_mq;
device_initialize(&shost->shost_gendev);
--
2.15.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH][scsi-next] scsi: core: remove redundant assignment to shost->use_blk_mq
2018-03-28 16:41 ` Colin King
@ 2018-03-28 16:49 ` Bart Van Assche
-1 siblings, 0 replies; 6+ messages in thread
From: Bart Van Assche @ 2018-03-28 16:49 UTC (permalink / raw)
To: jejb, colin.king, linux-scsi, martin.petersen
Cc: linux-kernel, kernel-janitors, ming.lei
On Wed, 2018-03-28 at 17:41 +0100, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> The first assignment to shost->use_blk_mq is redundant as it is
> overwritten by the following statement. Remove this redundant code.
>
> Detected by CoverityScan, CID#1466993 ("Unused value")
Reviewed-by: Bart Van Assche <bart.vanassche@wdc.com>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH][scsi-next] scsi: core: remove redundant assignment to shost->use_blk_mq
@ 2018-03-28 16:49 ` Bart Van Assche
0 siblings, 0 replies; 6+ messages in thread
From: Bart Van Assche @ 2018-03-28 16:49 UTC (permalink / raw)
To: jejb, colin.king, linux-scsi, martin.petersen
Cc: linux-kernel, kernel-janitors, ming.lei
T24gV2VkLCAyMDE4LTAzLTI4IGF0IDE3OjQxICswMTAwLCBDb2xpbiBLaW5nIHdyb3RlOg0KPiBG
cm9tOiBDb2xpbiBJYW4gS2luZyA8Y29saW4ua2luZ0BjYW5vbmljYWwuY29tPg0KPiANCj4gVGhl
IGZpcnN0IGFzc2lnbm1lbnQgdG8gc2hvc3QtPnVzZV9ibGtfbXEgaXMgcmVkdW5kYW50IGFzIGl0
IGlzDQo+IG92ZXJ3cml0dGVuIGJ5IHRoZSBmb2xsb3dpbmcgc3RhdGVtZW50LiBSZW1vdmUgdGhp
cyByZWR1bmRhbnQgY29kZS4NCj4gDQo+IERldGVjdGVkIGJ5IENvdmVyaXR5U2NhbiwgQ0lEIzE0
NjY5OTMgKCJVbnVzZWQgdmFsdWUiKQ0KDQpSZXZpZXdlZC1ieTogQmFydCBWYW4gQXNzY2hlIDxi
YXJ0LnZhbmFzc2NoZUB3ZGMuY29tPg0KDQoNCg0KDQo
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH][scsi-next] scsi: core: remove redundant assignment to shost->use_blk_mq
2018-03-28 16:41 ` Colin King
@ 2018-03-28 22:10 ` Martin K. Petersen
-1 siblings, 0 replies; 6+ messages in thread
From: Martin K. Petersen @ 2018-03-28 22:10 UTC (permalink / raw)
To: Colin King
Cc: James E . J . Bottomley, Martin K . Petersen, linux-scsi,
kernel-janitors, linux-kernel
Colin,
> The first assignment to shost->use_blk_mq is redundant as it is
> overwritten by the following statement. Remove this redundant code.
Applied to 4.16/scsi-fixes. Thank you!
--
Martin K. Petersen Oracle Linux Engineering
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH][scsi-next] scsi: core: remove redundant assignment to shost->use_blk_mq
@ 2018-03-28 22:10 ` Martin K. Petersen
0 siblings, 0 replies; 6+ messages in thread
From: Martin K. Petersen @ 2018-03-28 22:10 UTC (permalink / raw)
To: Colin King
Cc: James E . J . Bottomley, Martin K . Petersen, linux-scsi,
kernel-janitors, linux-kernel
Colin,
> The first assignment to shost->use_blk_mq is redundant as it is
> overwritten by the following statement. Remove this redundant code.
Applied to 4.16/scsi-fixes. Thank you!
--
Martin K. Petersen Oracle Linux Engineering
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2018-03-28 22:10 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-03-28 16:41 [PATCH][scsi-next] scsi: core: remove redundant assignment to shost->use_blk_mq Colin King
2018-03-28 16:41 ` Colin King
2018-03-28 16:49 ` Bart Van Assche
2018-03-28 16:49 ` Bart Van Assche
2018-03-28 22:10 ` Martin K. Petersen
2018-03-28 22:10 ` Martin K. Petersen
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.