* [PATCH v1 0/6] clear riscv dtbs_check errors
@ 2022-06-05 13:32 ` mail
0 siblings, 0 replies; 34+ messages in thread
From: mail @ 2022-06-05 13:32 UTC (permalink / raw)
To: Rob Herring, Krzysztof Kozlowski, Andrew Lunn,
Support Opensource, Lee Jones, Ulf Hansson, Palmer Dabbelt,
Paul Walmsley, Albert Ou, Steve Twiss
Cc: Conor Dooley, linux-i2c, devicetree, linux-kernel, linux-mmc,
linux-riscv, Atul Khare
From: Conor Dooley <conor.dooley@microchip.com>
Hey,
Couple conversions from txt to yaml here with the intent of fixing the
the dtbs_check warnings for riscv. Atul Khare already sent patches for
the gpio-line-names & cache-sets (which went awol) and will clear the
remaining two errors.
Rob/Krzysztof:
Have I correctly expressed the mutually exclusive properties?
I had a look around, but wasn't able to find an obvious binding to ape.
Wasn't sure if a txt -> yaml conversion's MAINTAINERS update was meant
to be in the same patch or not, so feel free to squash.
Thanks,
Conor.
Conor Dooley (6):
dt-bindings: mmc: convert mmc-spi-slot to yaml
dt-bindings: i2c: convert ocores binding to yaml
MAINTAINERS: convert ocores i2c dt-binding to yaml
dt-bindings: mfd: convert da9063 to yaml
MAINTAINERS: convert da9063 to yaml
riscv: dts: sifive: "fix" pmic watchdog node name
.../devicetree/bindings/i2c/i2c-ocores.txt | 78 -----------
.../devicetree/bindings/i2c/i2c-ocores.yaml | 132 ++++++++++++++++++
.../devicetree/bindings/mfd/da9063.txt | 111 ---------------
.../devicetree/bindings/mfd/da9063.yaml | 123 ++++++++++++++++
.../devicetree/bindings/mmc/mmc-spi-slot.txt | 29 ----
.../devicetree/bindings/mmc/mmc-spi-slot.yaml | 76 ++++++++++
.../devicetree/bindings/trivial-devices.yaml | 2 -
MAINTAINERS | 3 +-
.../boot/dts/sifive/hifive-unmatched-a00.dts | 2 +-
9 files changed, 334 insertions(+), 222 deletions(-)
delete mode 100644 Documentation/devicetree/bindings/i2c/i2c-ocores.txt
create mode 100644 Documentation/devicetree/bindings/i2c/i2c-ocores.yaml
delete mode 100644 Documentation/devicetree/bindings/mfd/da9063.txt
create mode 100644 Documentation/devicetree/bindings/mfd/da9063.yaml
delete mode 100644 Documentation/devicetree/bindings/mmc/mmc-spi-slot.txt
create mode 100644 Documentation/devicetree/bindings/mmc/mmc-spi-slot.yaml
--
2.36.1
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
^ permalink raw reply [flat|nested] 34+ messages in thread
* [PATCH v1 1/6] dt-bindings: mmc: convert mmc-spi-slot to yaml
2022-06-05 13:32 ` mail
@ 2022-06-05 13:32 ` mail
-1 siblings, 0 replies; 34+ messages in thread
From: mail @ 2022-06-05 13:32 UTC (permalink / raw)
To: Rob Herring, Krzysztof Kozlowski, Andrew Lunn,
Support Opensource, Lee Jones, Ulf Hansson, Palmer Dabbelt,
Paul Walmsley, Albert Ou, Steve Twiss
Cc: Conor Dooley, linux-i2c, devicetree, linux-kernel, linux-mmc,
linux-riscv, Atul Khare
From: Conor Dooley <conor.dooley@microchip.com>
Convert the mmc-spi-slot text based binding doc to yaml,
with the side effect of cleaning up some of the riscv
dtbs_check warnings.
Signed-off-by: Conor Dooley <conor.dooley@microchip.com>
---
.../devicetree/bindings/mmc/mmc-spi-slot.txt | 29 -------
.../devicetree/bindings/mmc/mmc-spi-slot.yaml | 76 +++++++++++++++++++
2 files changed, 76 insertions(+), 29 deletions(-)
delete mode 100644 Documentation/devicetree/bindings/mmc/mmc-spi-slot.txt
create mode 100644 Documentation/devicetree/bindings/mmc/mmc-spi-slot.yaml
diff --git a/Documentation/devicetree/bindings/mmc/mmc-spi-slot.txt b/Documentation/devicetree/bindings/mmc/mmc-spi-slot.txt
deleted file mode 100644
index 5e74db69f581..000000000000
--- a/Documentation/devicetree/bindings/mmc/mmc-spi-slot.txt
+++ /dev/null
@@ -1,29 +0,0 @@
-MMC/SD/SDIO slot directly connected to a SPI bus
-
-This file documents differences between the core properties described
-by mmc.txt and the properties used by the mmc_spi driver.
-
-Required properties:
-- spi-max-frequency : maximum frequency for this device (Hz).
-
-Optional properties:
-- voltage-ranges : two cells are required, first cell specifies minimum
- slot voltage (mV), second cell specifies maximum slot voltage (mV).
- Several ranges could be specified. If not provided, 3.2v..3.4v is assumed.
-- gpios : may specify GPIOs in this order: Card-Detect GPIO,
- Write-Protect GPIO. Note that this does not follow the
- binding from mmc.txt, for historical reasons.
-
-Example:
-
- mmc-slot@0 {
- compatible = "fsl,mpc8323rdb-mmc-slot",
- "mmc-spi-slot";
- reg = <0>;
- gpios = <&qe_pio_d 14 1
- &qe_pio_d 15 0>;
- voltage-ranges = <3300 3300>;
- spi-max-frequency = <50000000>;
- interrupts = <42>;
- interrupt-parent = <&PIC>;
- };
diff --git a/Documentation/devicetree/bindings/mmc/mmc-spi-slot.yaml b/Documentation/devicetree/bindings/mmc/mmc-spi-slot.yaml
new file mode 100644
index 000000000000..a5fd723140c9
--- /dev/null
+++ b/Documentation/devicetree/bindings/mmc/mmc-spi-slot.yaml
@@ -0,0 +1,76 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/mmc/mmc-spi-slot.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: MMC/SD/SDIO slot directly connected to a SPI bus
+
+maintainers:
+ - Ulf Hansson <ulf.hansson@linaro.org>
+
+allOf:
+ - $ref: "mmc-controller.yaml"
+
+description: |
+ The extra properties used by an mmc connected via spi.
+
+properties:
+ compatible:
+ const: "mmc-spi-slot"
+
+ reg:
+ maxItems: 1
+
+ spi-max-frequency: true
+
+ interrupts:
+ maxItems: 1
+
+ voltage-ranges:
+ $ref: '/schemas/types.yaml#/definitions/uint32-matrix'
+ description: |
+ Two cells are required, first cell specifies minimum slot voltage (mV),
+ second cell specifies maximum slot voltage (mV).
+ items:
+ items:
+ - description: |
+ value for minimum slot voltage
+ default: 3200
+ - description: |
+ value for maximum slot voltage
+ default: 3400
+ maxItems: 1
+
+ gpios:
+ description: |
+ For historical reasons, this does not follow the generic mmc-controller binding.
+ minItems: 1
+ items:
+ - description: Card-Detect GPIO
+ - description: Write-Protect GPIO
+
+required:
+ - compatible
+ - reg
+ - spi-max-frequency
+
+unevaluatedProperties: false
+
+examples:
+ - |
+ spi {
+ #address-cells = <1>;
+ #size-cells = <0>;
+ mmc@0 {
+ compatible = "mmc-spi-slot";
+ reg = <0>;
+ gpios = <&qe_pio_d 14 1>, <&qe_pio_d 15 0>;
+ voltage-ranges = <3300 3300>;
+ spi-max-frequency = <50000000>;
+ interrupts = <42>;
+ interrupt-parent = <&PIC>;
+ };
+ };
+
+...
--
2.36.1
^ permalink raw reply related [flat|nested] 34+ messages in thread* [PATCH v1 1/6] dt-bindings: mmc: convert mmc-spi-slot to yaml
@ 2022-06-05 13:32 ` mail
0 siblings, 0 replies; 34+ messages in thread
From: mail @ 2022-06-05 13:32 UTC (permalink / raw)
To: Rob Herring, Krzysztof Kozlowski, Andrew Lunn,
Support Opensource, Lee Jones, Ulf Hansson, Palmer Dabbelt,
Paul Walmsley, Albert Ou, Steve Twiss
Cc: Conor Dooley, linux-i2c, devicetree, linux-kernel, linux-mmc,
linux-riscv, Atul Khare
From: Conor Dooley <conor.dooley@microchip.com>
Convert the mmc-spi-slot text based binding doc to yaml,
with the side effect of cleaning up some of the riscv
dtbs_check warnings.
Signed-off-by: Conor Dooley <conor.dooley@microchip.com>
---
.../devicetree/bindings/mmc/mmc-spi-slot.txt | 29 -------
.../devicetree/bindings/mmc/mmc-spi-slot.yaml | 76 +++++++++++++++++++
2 files changed, 76 insertions(+), 29 deletions(-)
delete mode 100644 Documentation/devicetree/bindings/mmc/mmc-spi-slot.txt
create mode 100644 Documentation/devicetree/bindings/mmc/mmc-spi-slot.yaml
diff --git a/Documentation/devicetree/bindings/mmc/mmc-spi-slot.txt b/Documentation/devicetree/bindings/mmc/mmc-spi-slot.txt
deleted file mode 100644
index 5e74db69f581..000000000000
--- a/Documentation/devicetree/bindings/mmc/mmc-spi-slot.txt
+++ /dev/null
@@ -1,29 +0,0 @@
-MMC/SD/SDIO slot directly connected to a SPI bus
-
-This file documents differences between the core properties described
-by mmc.txt and the properties used by the mmc_spi driver.
-
-Required properties:
-- spi-max-frequency : maximum frequency for this device (Hz).
-
-Optional properties:
-- voltage-ranges : two cells are required, first cell specifies minimum
- slot voltage (mV), second cell specifies maximum slot voltage (mV).
- Several ranges could be specified. If not provided, 3.2v..3.4v is assumed.
-- gpios : may specify GPIOs in this order: Card-Detect GPIO,
- Write-Protect GPIO. Note that this does not follow the
- binding from mmc.txt, for historical reasons.
-
-Example:
-
- mmc-slot@0 {
- compatible = "fsl,mpc8323rdb-mmc-slot",
- "mmc-spi-slot";
- reg = <0>;
- gpios = <&qe_pio_d 14 1
- &qe_pio_d 15 0>;
- voltage-ranges = <3300 3300>;
- spi-max-frequency = <50000000>;
- interrupts = <42>;
- interrupt-parent = <&PIC>;
- };
diff --git a/Documentation/devicetree/bindings/mmc/mmc-spi-slot.yaml b/Documentation/devicetree/bindings/mmc/mmc-spi-slot.yaml
new file mode 100644
index 000000000000..a5fd723140c9
--- /dev/null
+++ b/Documentation/devicetree/bindings/mmc/mmc-spi-slot.yaml
@@ -0,0 +1,76 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/mmc/mmc-spi-slot.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: MMC/SD/SDIO slot directly connected to a SPI bus
+
+maintainers:
+ - Ulf Hansson <ulf.hansson@linaro.org>
+
+allOf:
+ - $ref: "mmc-controller.yaml"
+
+description: |
+ The extra properties used by an mmc connected via spi.
+
+properties:
+ compatible:
+ const: "mmc-spi-slot"
+
+ reg:
+ maxItems: 1
+
+ spi-max-frequency: true
+
+ interrupts:
+ maxItems: 1
+
+ voltage-ranges:
+ $ref: '/schemas/types.yaml#/definitions/uint32-matrix'
+ description: |
+ Two cells are required, first cell specifies minimum slot voltage (mV),
+ second cell specifies maximum slot voltage (mV).
+ items:
+ items:
+ - description: |
+ value for minimum slot voltage
+ default: 3200
+ - description: |
+ value for maximum slot voltage
+ default: 3400
+ maxItems: 1
+
+ gpios:
+ description: |
+ For historical reasons, this does not follow the generic mmc-controller binding.
+ minItems: 1
+ items:
+ - description: Card-Detect GPIO
+ - description: Write-Protect GPIO
+
+required:
+ - compatible
+ - reg
+ - spi-max-frequency
+
+unevaluatedProperties: false
+
+examples:
+ - |
+ spi {
+ #address-cells = <1>;
+ #size-cells = <0>;
+ mmc@0 {
+ compatible = "mmc-spi-slot";
+ reg = <0>;
+ gpios = <&qe_pio_d 14 1>, <&qe_pio_d 15 0>;
+ voltage-ranges = <3300 3300>;
+ spi-max-frequency = <50000000>;
+ interrupts = <42>;
+ interrupt-parent = <&PIC>;
+ };
+ };
+
+...
--
2.36.1
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
^ permalink raw reply related [flat|nested] 34+ messages in thread* Re: [PATCH v1 1/6] dt-bindings: mmc: convert mmc-spi-slot to yaml
2022-06-05 13:32 ` mail
@ 2022-06-06 7:34 ` Krzysztof Kozlowski
-1 siblings, 0 replies; 34+ messages in thread
From: Krzysztof Kozlowski @ 2022-06-06 7:34 UTC (permalink / raw)
To: mail, Rob Herring, Krzysztof Kozlowski, Andrew Lunn,
Support Opensource, Lee Jones, Ulf Hansson, Palmer Dabbelt,
Paul Walmsley, Albert Ou, Steve Twiss
Cc: Conor Dooley, linux-i2c, devicetree, linux-kernel, linux-mmc,
linux-riscv, Atul Khare
On 05/06/2022 15:32, mail@conchuod.ie wrote:
> From: Conor Dooley <conor.dooley@microchip.com>
>
> Convert the mmc-spi-slot text based binding doc to yaml,
> with the side effect of cleaning up some of the riscv
> dtbs_check warnings.
>
> Signed-off-by: Conor Dooley <conor.dooley@microchip.com>
> ---
> .../devicetree/bindings/mmc/mmc-spi-slot.txt | 29 -------
> .../devicetree/bindings/mmc/mmc-spi-slot.yaml | 76 +++++++++++++++++++
> 2 files changed, 76 insertions(+), 29 deletions(-)
> delete mode 100644 Documentation/devicetree/bindings/mmc/mmc-spi-slot.txt
> create mode 100644 Documentation/devicetree/bindings/mmc/mmc-spi-slot.yaml
>
> diff --git a/Documentation/devicetree/bindings/mmc/mmc-spi-slot.txt b/Documentation/devicetree/bindings/mmc/mmc-spi-slot.txt
> deleted file mode 100644
> index 5e74db69f581..000000000000
> --- a/Documentation/devicetree/bindings/mmc/mmc-spi-slot.txt
> +++ /dev/null
> @@ -1,29 +0,0 @@
> -MMC/SD/SDIO slot directly connected to a SPI bus
> -
> -This file documents differences between the core properties described
> -by mmc.txt and the properties used by the mmc_spi driver.
> -
> -Required properties:
> -- spi-max-frequency : maximum frequency for this device (Hz).
> -
> -Optional properties:
> -- voltage-ranges : two cells are required, first cell specifies minimum
> - slot voltage (mV), second cell specifies maximum slot voltage (mV).
> - Several ranges could be specified. If not provided, 3.2v..3.4v is assumed.
> -- gpios : may specify GPIOs in this order: Card-Detect GPIO,
> - Write-Protect GPIO. Note that this does not follow the
> - binding from mmc.txt, for historical reasons.
> -
> -Example:
> -
> - mmc-slot@0 {
> - compatible = "fsl,mpc8323rdb-mmc-slot",
> - "mmc-spi-slot";
> - reg = <0>;
> - gpios = <&qe_pio_d 14 1
> - &qe_pio_d 15 0>;
> - voltage-ranges = <3300 3300>;
> - spi-max-frequency = <50000000>;
> - interrupts = <42>;
> - interrupt-parent = <&PIC>;
> - };
> diff --git a/Documentation/devicetree/bindings/mmc/mmc-spi-slot.yaml b/Documentation/devicetree/bindings/mmc/mmc-spi-slot.yaml
> new file mode 100644
> index 000000000000..a5fd723140c9
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/mmc/mmc-spi-slot.yaml
> @@ -0,0 +1,76 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/mmc/mmc-spi-slot.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: MMC/SD/SDIO slot directly connected to a SPI bus
> +
> +maintainers:
> + - Ulf Hansson <ulf.hansson@linaro.org>
> +
> +allOf:
> + - $ref: "mmc-controller.yaml"
> +
> +description: |
> + The extra properties used by an mmc connected via spi.
s/spi/SPI/
> +
> +properties:
> + compatible:
> + const: "mmc-spi-slot"
No quotes, please.
> +
> + reg:
> + maxItems: 1
> +
> + spi-max-frequency: true
I think instead you should reference:
/schemas/spi/spi-peripheral-props.yaml
(because also other properties might be needed for different SPI
controllers)
> +
> + interrupts:
> + maxItems: 1
> +
> + voltage-ranges:
> + $ref: '/schemas/types.yaml#/definitions/uint32-matrix'
Here as well - quotes are not needed. Some schemas have it, some not,
but I guess shorter is preferred :)
> + description: |
> + Two cells are required, first cell specifies minimum slot voltage (mV),
> + second cell specifies maximum slot voltage (mV).
> + items:
> + items:
> + - description: |
> + value for minimum slot voltage
> + default: 3200
> + - description: |
> + value for maximum slot voltage
> + default: 3400
> + maxItems: 1
> +
> + gpios:
> + description: |
> + For historical reasons, this does not follow the generic mmc-controller binding.
> + minItems: 1
> + items:
> + - description: Card-Detect GPIO
> + - description: Write-Protect GPIO
> +
> +required:
> + - compatible
> + - reg
> + - spi-max-frequency
> +
> +unevaluatedProperties: false
> +
> +examples:
> + - |
> + spi {
> + #address-cells = <1>;
> + #size-cells = <0>;
> + mmc@0 {
> + compatible = "mmc-spi-slot";
> + reg = <0>;
> + gpios = <&qe_pio_d 14 1>, <&qe_pio_d 15 0>;
The GPIO flags should be common defines instead.
> + voltage-ranges = <3300 3300>;
> + spi-max-frequency = <50000000>;
> + interrupts = <42>;
> + interrupt-parent = <&PIC>;
> + };
> + };
> +
> +...
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 34+ messages in thread* Re: [PATCH v1 1/6] dt-bindings: mmc: convert mmc-spi-slot to yaml
@ 2022-06-06 7:34 ` Krzysztof Kozlowski
0 siblings, 0 replies; 34+ messages in thread
From: Krzysztof Kozlowski @ 2022-06-06 7:34 UTC (permalink / raw)
To: mail, Rob Herring, Krzysztof Kozlowski, Andrew Lunn,
Support Opensource, Lee Jones, Ulf Hansson, Palmer Dabbelt,
Paul Walmsley, Albert Ou, Steve Twiss
Cc: Conor Dooley, linux-i2c, devicetree, linux-kernel, linux-mmc,
linux-riscv, Atul Khare
On 05/06/2022 15:32, mail@conchuod.ie wrote:
> From: Conor Dooley <conor.dooley@microchip.com>
>
> Convert the mmc-spi-slot text based binding doc to yaml,
> with the side effect of cleaning up some of the riscv
> dtbs_check warnings.
>
> Signed-off-by: Conor Dooley <conor.dooley@microchip.com>
> ---
> .../devicetree/bindings/mmc/mmc-spi-slot.txt | 29 -------
> .../devicetree/bindings/mmc/mmc-spi-slot.yaml | 76 +++++++++++++++++++
> 2 files changed, 76 insertions(+), 29 deletions(-)
> delete mode 100644 Documentation/devicetree/bindings/mmc/mmc-spi-slot.txt
> create mode 100644 Documentation/devicetree/bindings/mmc/mmc-spi-slot.yaml
>
> diff --git a/Documentation/devicetree/bindings/mmc/mmc-spi-slot.txt b/Documentation/devicetree/bindings/mmc/mmc-spi-slot.txt
> deleted file mode 100644
> index 5e74db69f581..000000000000
> --- a/Documentation/devicetree/bindings/mmc/mmc-spi-slot.txt
> +++ /dev/null
> @@ -1,29 +0,0 @@
> -MMC/SD/SDIO slot directly connected to a SPI bus
> -
> -This file documents differences between the core properties described
> -by mmc.txt and the properties used by the mmc_spi driver.
> -
> -Required properties:
> -- spi-max-frequency : maximum frequency for this device (Hz).
> -
> -Optional properties:
> -- voltage-ranges : two cells are required, first cell specifies minimum
> - slot voltage (mV), second cell specifies maximum slot voltage (mV).
> - Several ranges could be specified. If not provided, 3.2v..3.4v is assumed.
> -- gpios : may specify GPIOs in this order: Card-Detect GPIO,
> - Write-Protect GPIO. Note that this does not follow the
> - binding from mmc.txt, for historical reasons.
> -
> -Example:
> -
> - mmc-slot@0 {
> - compatible = "fsl,mpc8323rdb-mmc-slot",
> - "mmc-spi-slot";
> - reg = <0>;
> - gpios = <&qe_pio_d 14 1
> - &qe_pio_d 15 0>;
> - voltage-ranges = <3300 3300>;
> - spi-max-frequency = <50000000>;
> - interrupts = <42>;
> - interrupt-parent = <&PIC>;
> - };
> diff --git a/Documentation/devicetree/bindings/mmc/mmc-spi-slot.yaml b/Documentation/devicetree/bindings/mmc/mmc-spi-slot.yaml
> new file mode 100644
> index 000000000000..a5fd723140c9
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/mmc/mmc-spi-slot.yaml
> @@ -0,0 +1,76 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/mmc/mmc-spi-slot.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: MMC/SD/SDIO slot directly connected to a SPI bus
> +
> +maintainers:
> + - Ulf Hansson <ulf.hansson@linaro.org>
> +
> +allOf:
> + - $ref: "mmc-controller.yaml"
> +
> +description: |
> + The extra properties used by an mmc connected via spi.
s/spi/SPI/
> +
> +properties:
> + compatible:
> + const: "mmc-spi-slot"
No quotes, please.
> +
> + reg:
> + maxItems: 1
> +
> + spi-max-frequency: true
I think instead you should reference:
/schemas/spi/spi-peripheral-props.yaml
(because also other properties might be needed for different SPI
controllers)
> +
> + interrupts:
> + maxItems: 1
> +
> + voltage-ranges:
> + $ref: '/schemas/types.yaml#/definitions/uint32-matrix'
Here as well - quotes are not needed. Some schemas have it, some not,
but I guess shorter is preferred :)
> + description: |
> + Two cells are required, first cell specifies minimum slot voltage (mV),
> + second cell specifies maximum slot voltage (mV).
> + items:
> + items:
> + - description: |
> + value for minimum slot voltage
> + default: 3200
> + - description: |
> + value for maximum slot voltage
> + default: 3400
> + maxItems: 1
> +
> + gpios:
> + description: |
> + For historical reasons, this does not follow the generic mmc-controller binding.
> + minItems: 1
> + items:
> + - description: Card-Detect GPIO
> + - description: Write-Protect GPIO
> +
> +required:
> + - compatible
> + - reg
> + - spi-max-frequency
> +
> +unevaluatedProperties: false
> +
> +examples:
> + - |
> + spi {
> + #address-cells = <1>;
> + #size-cells = <0>;
> + mmc@0 {
> + compatible = "mmc-spi-slot";
> + reg = <0>;
> + gpios = <&qe_pio_d 14 1>, <&qe_pio_d 15 0>;
The GPIO flags should be common defines instead.
> + voltage-ranges = <3300 3300>;
> + spi-max-frequency = <50000000>;
> + interrupts = <42>;
> + interrupt-parent = <&PIC>;
> + };
> + };
> +
> +...
Best regards,
Krzysztof
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
^ permalink raw reply [flat|nested] 34+ messages in thread
* [PATCH v1 2/6] dt-bindings: i2c: convert ocores binding to yaml
2022-06-05 13:32 ` mail
@ 2022-06-05 13:32 ` mail
-1 siblings, 0 replies; 34+ messages in thread
From: mail @ 2022-06-05 13:32 UTC (permalink / raw)
To: Rob Herring, Krzysztof Kozlowski, Andrew Lunn,
Support Opensource, Lee Jones, Ulf Hansson, Palmer Dabbelt,
Paul Walmsley, Albert Ou, Steve Twiss
Cc: Conor Dooley, linux-i2c, devicetree, linux-kernel, linux-mmc,
linux-riscv, Atul Khare
From: Conor Dooley <conor.dooley@microchip.com>
Convert the open cores i2c controller binding from text to yaml.
Signed-off-by: Conor Dooley <conor.dooley@microchip.com>
---
.../devicetree/bindings/i2c/i2c-ocores.txt | 78 -----------
.../devicetree/bindings/i2c/i2c-ocores.yaml | 132 ++++++++++++++++++
2 files changed, 132 insertions(+), 78 deletions(-)
delete mode 100644 Documentation/devicetree/bindings/i2c/i2c-ocores.txt
create mode 100644 Documentation/devicetree/bindings/i2c/i2c-ocores.yaml
diff --git a/Documentation/devicetree/bindings/i2c/i2c-ocores.txt b/Documentation/devicetree/bindings/i2c/i2c-ocores.txt
deleted file mode 100644
index a37c9455b244..000000000000
--- a/Documentation/devicetree/bindings/i2c/i2c-ocores.txt
+++ /dev/null
@@ -1,78 +0,0 @@
-Device tree configuration for i2c-ocores
-
-Required properties:
-- compatible : "opencores,i2c-ocores"
- "aeroflexgaisler,i2cmst"
- "sifive,fu540-c000-i2c", "sifive,i2c0"
- For Opencore based I2C IP block reimplemented in
- FU540-C000 SoC.
- "sifive,fu740-c000-i2c", "sifive,i2c0"
- For Opencore based I2C IP block reimplemented in
- FU740-C000 SoC.
- Please refer to sifive-blocks-ip-versioning.txt for
- additional details.
-- reg : bus address start and address range size of device
-- clocks : handle to the controller clock; see the note below.
- Mutually exclusive with opencores,ip-clock-frequency
-- opencores,ip-clock-frequency: frequency of the controller clock in Hz;
- see the note below. Mutually exclusive with clocks
-- #address-cells : should be <1>
-- #size-cells : should be <0>
-
-Optional properties:
-- interrupts : interrupt number.
-- clock-frequency : frequency of bus clock in Hz; see the note below.
- Defaults to 100 KHz when the property is not specified
-- reg-shift : device register offsets are shifted by this value
-- reg-io-width : io register width in bytes (1, 2 or 4)
-- regstep : deprecated, use reg-shift above
-
-Note
-clock-frequency property is meant to control the bus frequency for i2c bus
-drivers, but it was incorrectly used to specify i2c controller input clock
-frequency. So the following rules are set to fix this situation:
-- if clock-frequency is present and neither opencores,ip-clock-frequency nor
- clocks are, then clock-frequency specifies i2c controller clock frequency.
- This is to keep backwards compatibility with setups using old DTB. i2c bus
- frequency is fixed at 100 KHz.
-- if clocks is present it specifies i2c controller clock. clock-frequency
- property specifies i2c bus frequency.
-- if opencores,ip-clock-frequency is present it specifies i2c controller
- clock frequency. clock-frequency property specifies i2c bus frequency.
-
-Examples:
-
- i2c0: ocores@a0000000 {
- #address-cells = <1>;
- #size-cells = <0>;
- compatible = "opencores,i2c-ocores";
- reg = <0xa0000000 0x8>;
- interrupts = <10>;
- opencores,ip-clock-frequency = <20000000>;
-
- reg-shift = <0>; /* 8 bit registers */
- reg-io-width = <1>; /* 8 bit read/write */
-
- dummy@60 {
- compatible = "dummy";
- reg = <0x60>;
- };
- };
-or
- i2c0: ocores@a0000000 {
- #address-cells = <1>;
- #size-cells = <0>;
- compatible = "opencores,i2c-ocores";
- reg = <0xa0000000 0x8>;
- interrupts = <10>;
- clocks = <&osc>;
- clock-frequency = <400000>; /* i2c bus frequency 400 KHz */
-
- reg-shift = <0>; /* 8 bit registers */
- reg-io-width = <1>; /* 8 bit read/write */
-
- dummy@60 {
- compatible = "dummy";
- reg = <0x60>;
- };
- };
diff --git a/Documentation/devicetree/bindings/i2c/i2c-ocores.yaml b/Documentation/devicetree/bindings/i2c/i2c-ocores.yaml
new file mode 100644
index 000000000000..1693ffffbe31
--- /dev/null
+++ b/Documentation/devicetree/bindings/i2c/i2c-ocores.yaml
@@ -0,0 +1,132 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/i2c/i2c-ocores.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: OpenCores I2C controller
+
+maintainers:
+ - Peter Korsgaard <peter@korsgaard.com>
+ - Andrew Lunn <andrew@lunn.ch>
+
+allOf:
+ - $ref: /schemas/i2c/i2c-controller.yaml#
+
+properties:
+ compatible:
+ oneOf:
+ - items:
+ - enum:
+ - sifive,fu740-c000-i2c # Opencore based IP block FU740-C000 SoC
+ - sifive,fu540-c000-i2c # Opencore based IP block FU540-C000 SoC
+ - const: sifive,i2c0
+ - const: opencores,i2c-ocores
+ - const: aeroflexgaisler,i2cmst
+
+ reg:
+ maxItems: 1
+
+ interrupts:
+ maxItems: 1
+
+ clocks:
+ maxItems: 1
+
+ "#address-cells":
+ const: 1
+
+ "#size-cells":
+ const: 0
+
+ clock-frequency:
+ description: |
+ Desired I2C bus clock frequency in Hz. As only Standard and Fast
+ modes are supported, possible values are 100000 and 400000.
+ Note:
+ clock-frequency property is meant to control the bus frequency for i2c bus
+ drivers, but it was incorrectly used to specify i2c controller input clock
+ frequency. So the following rules are set to fix this situation:
+ - if clock-frequency is present and neither opencores,ip-clock-frequency nor
+ clocks are, then clock-frequency specifies i2c controller clock frequency.
+ This is to keep backwards compatibility with setups using old DTB. i2c bus
+ frequency is fixed at 100 KHz.
+ - if clocks is present it specifies i2c controller clock. clock-frequency
+ property specifies i2c bus frequency.
+ - if opencores,ip-clock-frequency is present it specifies i2c controller
+ clock frequency. clock-frequency property specifies i2c bus frequency.
+ default: 100000
+
+ reg-io-width:
+ $ref: /schemas/types.yaml#/definitions/uint32
+ description: |
+ io register width in bytes
+ enum: [1, 2, 4]
+
+ reg-shift:
+ $ref: /schemas/types.yaml#/definitions/uint32
+ description: |
+ device register offsets are shifted by this value
+
+ regstep:
+ description: |
+ deprecated, use reg-shift above
+ deprecated: true
+
+ opencores,ip-clock-frequency:
+ $ref: /schemas/types.yaml#/definitions/uint32
+ description: |
+ Frequency of the controller clock in Hz. Mutually exclusive with clocks.
+ See the note above.
+
+required:
+ - compatible
+ - reg
+ - "#address-cells"
+ - "#size-cells"
+
+oneOf:
+ - required:
+ - opencores,ip-clock-frequency
+ - required:
+ - clocks
+
+unevaluatedProperties: false
+
+examples:
+ - |
+ i2c@a0000000 {
+ #address-cells = <1>;
+ #size-cells = <0>;
+ compatible = "opencores,i2c-ocores";
+ reg = <0xa0000000 0x8>;
+ interrupts = <10>;
+ opencores,ip-clock-frequency = <20000000>;
+
+ reg-shift = <0>; /* 8 bit registers */
+ reg-io-width = <1>; /* 8 bit read/write */
+
+ dummy@60 {
+ compatible = "dummy";
+ reg = <0x60>;
+ };
+ };
+
+ i2c@b0000000 {
+ #address-cells = <1>;
+ #size-cells = <0>;
+ compatible = "opencores,i2c-ocores";
+ reg = <0xa0000000 0x8>;
+ interrupts = <10>;
+ clocks = <&osc>;
+ clock-frequency = <400000>; /* i2c bus frequency 400 KHz */
+
+ reg-shift = <0>; /* 8 bit registers */
+ reg-io-width = <1>; /* 8 bit read/write */
+
+ dummy@60 {
+ compatible = "dummy";
+ reg = <0x60>;
+ };
+ };
+...
--
2.36.1
^ permalink raw reply related [flat|nested] 34+ messages in thread* [PATCH v1 2/6] dt-bindings: i2c: convert ocores binding to yaml
@ 2022-06-05 13:32 ` mail
0 siblings, 0 replies; 34+ messages in thread
From: mail @ 2022-06-05 13:32 UTC (permalink / raw)
To: Rob Herring, Krzysztof Kozlowski, Andrew Lunn,
Support Opensource, Lee Jones, Ulf Hansson, Palmer Dabbelt,
Paul Walmsley, Albert Ou, Steve Twiss
Cc: Conor Dooley, linux-i2c, devicetree, linux-kernel, linux-mmc,
linux-riscv, Atul Khare
From: Conor Dooley <conor.dooley@microchip.com>
Convert the open cores i2c controller binding from text to yaml.
Signed-off-by: Conor Dooley <conor.dooley@microchip.com>
---
.../devicetree/bindings/i2c/i2c-ocores.txt | 78 -----------
.../devicetree/bindings/i2c/i2c-ocores.yaml | 132 ++++++++++++++++++
2 files changed, 132 insertions(+), 78 deletions(-)
delete mode 100644 Documentation/devicetree/bindings/i2c/i2c-ocores.txt
create mode 100644 Documentation/devicetree/bindings/i2c/i2c-ocores.yaml
diff --git a/Documentation/devicetree/bindings/i2c/i2c-ocores.txt b/Documentation/devicetree/bindings/i2c/i2c-ocores.txt
deleted file mode 100644
index a37c9455b244..000000000000
--- a/Documentation/devicetree/bindings/i2c/i2c-ocores.txt
+++ /dev/null
@@ -1,78 +0,0 @@
-Device tree configuration for i2c-ocores
-
-Required properties:
-- compatible : "opencores,i2c-ocores"
- "aeroflexgaisler,i2cmst"
- "sifive,fu540-c000-i2c", "sifive,i2c0"
- For Opencore based I2C IP block reimplemented in
- FU540-C000 SoC.
- "sifive,fu740-c000-i2c", "sifive,i2c0"
- For Opencore based I2C IP block reimplemented in
- FU740-C000 SoC.
- Please refer to sifive-blocks-ip-versioning.txt for
- additional details.
-- reg : bus address start and address range size of device
-- clocks : handle to the controller clock; see the note below.
- Mutually exclusive with opencores,ip-clock-frequency
-- opencores,ip-clock-frequency: frequency of the controller clock in Hz;
- see the note below. Mutually exclusive with clocks
-- #address-cells : should be <1>
-- #size-cells : should be <0>
-
-Optional properties:
-- interrupts : interrupt number.
-- clock-frequency : frequency of bus clock in Hz; see the note below.
- Defaults to 100 KHz when the property is not specified
-- reg-shift : device register offsets are shifted by this value
-- reg-io-width : io register width in bytes (1, 2 or 4)
-- regstep : deprecated, use reg-shift above
-
-Note
-clock-frequency property is meant to control the bus frequency for i2c bus
-drivers, but it was incorrectly used to specify i2c controller input clock
-frequency. So the following rules are set to fix this situation:
-- if clock-frequency is present and neither opencores,ip-clock-frequency nor
- clocks are, then clock-frequency specifies i2c controller clock frequency.
- This is to keep backwards compatibility with setups using old DTB. i2c bus
- frequency is fixed at 100 KHz.
-- if clocks is present it specifies i2c controller clock. clock-frequency
- property specifies i2c bus frequency.
-- if opencores,ip-clock-frequency is present it specifies i2c controller
- clock frequency. clock-frequency property specifies i2c bus frequency.
-
-Examples:
-
- i2c0: ocores@a0000000 {
- #address-cells = <1>;
- #size-cells = <0>;
- compatible = "opencores,i2c-ocores";
- reg = <0xa0000000 0x8>;
- interrupts = <10>;
- opencores,ip-clock-frequency = <20000000>;
-
- reg-shift = <0>; /* 8 bit registers */
- reg-io-width = <1>; /* 8 bit read/write */
-
- dummy@60 {
- compatible = "dummy";
- reg = <0x60>;
- };
- };
-or
- i2c0: ocores@a0000000 {
- #address-cells = <1>;
- #size-cells = <0>;
- compatible = "opencores,i2c-ocores";
- reg = <0xa0000000 0x8>;
- interrupts = <10>;
- clocks = <&osc>;
- clock-frequency = <400000>; /* i2c bus frequency 400 KHz */
-
- reg-shift = <0>; /* 8 bit registers */
- reg-io-width = <1>; /* 8 bit read/write */
-
- dummy@60 {
- compatible = "dummy";
- reg = <0x60>;
- };
- };
diff --git a/Documentation/devicetree/bindings/i2c/i2c-ocores.yaml b/Documentation/devicetree/bindings/i2c/i2c-ocores.yaml
new file mode 100644
index 000000000000..1693ffffbe31
--- /dev/null
+++ b/Documentation/devicetree/bindings/i2c/i2c-ocores.yaml
@@ -0,0 +1,132 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/i2c/i2c-ocores.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: OpenCores I2C controller
+
+maintainers:
+ - Peter Korsgaard <peter@korsgaard.com>
+ - Andrew Lunn <andrew@lunn.ch>
+
+allOf:
+ - $ref: /schemas/i2c/i2c-controller.yaml#
+
+properties:
+ compatible:
+ oneOf:
+ - items:
+ - enum:
+ - sifive,fu740-c000-i2c # Opencore based IP block FU740-C000 SoC
+ - sifive,fu540-c000-i2c # Opencore based IP block FU540-C000 SoC
+ - const: sifive,i2c0
+ - const: opencores,i2c-ocores
+ - const: aeroflexgaisler,i2cmst
+
+ reg:
+ maxItems: 1
+
+ interrupts:
+ maxItems: 1
+
+ clocks:
+ maxItems: 1
+
+ "#address-cells":
+ const: 1
+
+ "#size-cells":
+ const: 0
+
+ clock-frequency:
+ description: |
+ Desired I2C bus clock frequency in Hz. As only Standard and Fast
+ modes are supported, possible values are 100000 and 400000.
+ Note:
+ clock-frequency property is meant to control the bus frequency for i2c bus
+ drivers, but it was incorrectly used to specify i2c controller input clock
+ frequency. So the following rules are set to fix this situation:
+ - if clock-frequency is present and neither opencores,ip-clock-frequency nor
+ clocks are, then clock-frequency specifies i2c controller clock frequency.
+ This is to keep backwards compatibility with setups using old DTB. i2c bus
+ frequency is fixed at 100 KHz.
+ - if clocks is present it specifies i2c controller clock. clock-frequency
+ property specifies i2c bus frequency.
+ - if opencores,ip-clock-frequency is present it specifies i2c controller
+ clock frequency. clock-frequency property specifies i2c bus frequency.
+ default: 100000
+
+ reg-io-width:
+ $ref: /schemas/types.yaml#/definitions/uint32
+ description: |
+ io register width in bytes
+ enum: [1, 2, 4]
+
+ reg-shift:
+ $ref: /schemas/types.yaml#/definitions/uint32
+ description: |
+ device register offsets are shifted by this value
+
+ regstep:
+ description: |
+ deprecated, use reg-shift above
+ deprecated: true
+
+ opencores,ip-clock-frequency:
+ $ref: /schemas/types.yaml#/definitions/uint32
+ description: |
+ Frequency of the controller clock in Hz. Mutually exclusive with clocks.
+ See the note above.
+
+required:
+ - compatible
+ - reg
+ - "#address-cells"
+ - "#size-cells"
+
+oneOf:
+ - required:
+ - opencores,ip-clock-frequency
+ - required:
+ - clocks
+
+unevaluatedProperties: false
+
+examples:
+ - |
+ i2c@a0000000 {
+ #address-cells = <1>;
+ #size-cells = <0>;
+ compatible = "opencores,i2c-ocores";
+ reg = <0xa0000000 0x8>;
+ interrupts = <10>;
+ opencores,ip-clock-frequency = <20000000>;
+
+ reg-shift = <0>; /* 8 bit registers */
+ reg-io-width = <1>; /* 8 bit read/write */
+
+ dummy@60 {
+ compatible = "dummy";
+ reg = <0x60>;
+ };
+ };
+
+ i2c@b0000000 {
+ #address-cells = <1>;
+ #size-cells = <0>;
+ compatible = "opencores,i2c-ocores";
+ reg = <0xa0000000 0x8>;
+ interrupts = <10>;
+ clocks = <&osc>;
+ clock-frequency = <400000>; /* i2c bus frequency 400 KHz */
+
+ reg-shift = <0>; /* 8 bit registers */
+ reg-io-width = <1>; /* 8 bit read/write */
+
+ dummy@60 {
+ compatible = "dummy";
+ reg = <0x60>;
+ };
+ };
+...
--
2.36.1
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
^ permalink raw reply related [flat|nested] 34+ messages in thread* Re: [PATCH v1 2/6] dt-bindings: i2c: convert ocores binding to yaml
2022-06-05 13:32 ` mail
@ 2022-06-06 8:02 ` Krzysztof Kozlowski
-1 siblings, 0 replies; 34+ messages in thread
From: Krzysztof Kozlowski @ 2022-06-06 8:02 UTC (permalink / raw)
To: mail, Rob Herring, Krzysztof Kozlowski, Andrew Lunn,
Support Opensource, Lee Jones, Ulf Hansson, Palmer Dabbelt,
Paul Walmsley, Albert Ou, Steve Twiss
Cc: Conor Dooley, linux-i2c, devicetree, linux-kernel, linux-mmc,
linux-riscv, Atul Khare
On 05/06/2022 15:32, mail@conchuod.ie wrote:
> From: Conor Dooley <conor.dooley@microchip.com>
>
> Convert the open cores i2c controller binding from text to yaml.
>
> Signed-off-by: Conor Dooley <conor.dooley@microchip.com>
> ---
> .../devicetree/bindings/i2c/i2c-ocores.txt | 78 -----------
> .../devicetree/bindings/i2c/i2c-ocores.yaml | 132 ++++++++++++++++++
> 2 files changed, 132 insertions(+), 78 deletions(-)
> delete mode 100644 Documentation/devicetree/bindings/i2c/i2c-ocores.txt
> create mode 100644 Documentation/devicetree/bindings/i2c/i2c-ocores.yaml
>
> diff --git a/Documentation/devicetree/bindings/i2c/i2c-ocores.txt b/Documentation/devicetree/bindings/i2c/i2c-ocores.txt
> deleted file mode 100644
> index a37c9455b244..000000000000
> --- a/Documentation/devicetree/bindings/i2c/i2c-ocores.txt
> +++ /dev/null
> @@ -1,78 +0,0 @@
> -Device tree configuration for i2c-ocores
> -
> -Required properties:
> -- compatible : "opencores,i2c-ocores"
> - "aeroflexgaisler,i2cmst"
> - "sifive,fu540-c000-i2c", "sifive,i2c0"
> - For Opencore based I2C IP block reimplemented in
> - FU540-C000 SoC.
> - "sifive,fu740-c000-i2c", "sifive,i2c0"
> - For Opencore based I2C IP block reimplemented in
> - FU740-C000 SoC.
> - Please refer to sifive-blocks-ip-versioning.txt for
> - additional details.
> -- reg : bus address start and address range size of device
> -- clocks : handle to the controller clock; see the note below.
> - Mutually exclusive with opencores,ip-clock-frequency
> -- opencores,ip-clock-frequency: frequency of the controller clock in Hz;
> - see the note below. Mutually exclusive with clocks
> -- #address-cells : should be <1>
> -- #size-cells : should be <0>
> -
> -Optional properties:
> -- interrupts : interrupt number.
> -- clock-frequency : frequency of bus clock in Hz; see the note below.
> - Defaults to 100 KHz when the property is not specified
> -- reg-shift : device register offsets are shifted by this value
> -- reg-io-width : io register width in bytes (1, 2 or 4)
> -- regstep : deprecated, use reg-shift above
> -
> -Note
> -clock-frequency property is meant to control the bus frequency for i2c bus
> -drivers, but it was incorrectly used to specify i2c controller input clock
> -frequency. So the following rules are set to fix this situation:
> -- if clock-frequency is present and neither opencores,ip-clock-frequency nor
> - clocks are, then clock-frequency specifies i2c controller clock frequency.
> - This is to keep backwards compatibility with setups using old DTB. i2c bus
> - frequency is fixed at 100 KHz.
> -- if clocks is present it specifies i2c controller clock. clock-frequency
> - property specifies i2c bus frequency.
> -- if opencores,ip-clock-frequency is present it specifies i2c controller
> - clock frequency. clock-frequency property specifies i2c bus frequency.
> -
> -Examples:
> -
> - i2c0: ocores@a0000000 {
> - #address-cells = <1>;
> - #size-cells = <0>;
> - compatible = "opencores,i2c-ocores";
> - reg = <0xa0000000 0x8>;
> - interrupts = <10>;
> - opencores,ip-clock-frequency = <20000000>;
> -
> - reg-shift = <0>; /* 8 bit registers */
> - reg-io-width = <1>; /* 8 bit read/write */
> -
> - dummy@60 {
> - compatible = "dummy";
> - reg = <0x60>;
> - };
> - };
> -or
> - i2c0: ocores@a0000000 {
> - #address-cells = <1>;
> - #size-cells = <0>;
> - compatible = "opencores,i2c-ocores";
> - reg = <0xa0000000 0x8>;
> - interrupts = <10>;
> - clocks = <&osc>;
> - clock-frequency = <400000>; /* i2c bus frequency 400 KHz */
> -
> - reg-shift = <0>; /* 8 bit registers */
> - reg-io-width = <1>; /* 8 bit read/write */
> -
> - dummy@60 {
> - compatible = "dummy";
> - reg = <0x60>;
> - };
> - };
> diff --git a/Documentation/devicetree/bindings/i2c/i2c-ocores.yaml b/Documentation/devicetree/bindings/i2c/i2c-ocores.yaml
> new file mode 100644
> index 000000000000..1693ffffbe31
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/i2c/i2c-ocores.yaml
> @@ -0,0 +1,132 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/i2c/i2c-ocores.yaml#
This should be rather named with vendor prefix, so:
opencores,i2c-ocores.yaml
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: OpenCores I2C controller
> +
> +maintainers:
> + - Peter Korsgaard <peter@korsgaard.com>
> + - Andrew Lunn <andrew@lunn.ch>
> +
> +allOf:
> + - $ref: /schemas/i2c/i2c-controller.yaml#
> +
> +properties:
> + compatible:
> + oneOf:
> + - items:
> + - enum:
> + - sifive,fu740-c000-i2c # Opencore based IP block FU740-C000 SoC
> + - sifive,fu540-c000-i2c # Opencore based IP block FU540-C000 SoC
> + - const: sifive,i2c0
> + - const: opencores,i2c-ocores
> + - const: aeroflexgaisler,i2cmst
The last two are just enum
> +
> + reg:
> + maxItems: 1
> +
> + interrupts:
> + maxItems: 1
> +
> + clocks:
> + maxItems: 1
> +
> + "#address-cells":
> + const: 1
> +
> + "#size-cells":
> + const: 0
> +
> + clock-frequency:
> + description: |
> + Desired I2C bus clock frequency in Hz. As only Standard and Fast
> + modes are supported, possible values are 100000 and 400000.
Add enum with the two values.
> + Note:
> + clock-frequency property is meant to control the bus frequency for i2c bus
> + drivers, but it was incorrectly used to specify i2c controller input clock
> + frequency. So the following rules are set to fix this situation:
> + - if clock-frequency is present and neither opencores,ip-clock-frequency nor
> + clocks are, then clock-frequency specifies i2c controller clock frequency.
> + This is to keep backwards compatibility with setups using old DTB. i2c bus
> + frequency is fixed at 100 KHz.
> + - if clocks is present it specifies i2c controller clock. clock-frequency
> + property specifies i2c bus frequency.
> + - if opencores,ip-clock-frequency is present it specifies i2c controller
> + clock frequency. clock-frequency property specifies i2c bus frequency.
> + default: 100000
> +
> + reg-io-width:
> + $ref: /schemas/types.yaml#/definitions/uint32
No need for ref, it is coming from the dtschema.
> + description: |
> + io register width in bytes
> + enum: [1, 2, 4]
> +
> + reg-shift:
> + $ref: /schemas/types.yaml#/definitions/uint32
No need for ref, it is coming from the dtschema.
> + description: |
> + device register offsets are shifted by this value
I guess 0 is default?
> +
> + regstep:
> + description: |
> + deprecated, use reg-shift above
> + deprecated: true
> +
> + opencores,ip-clock-frequency:
> + $ref: /schemas/types.yaml#/definitions/uint32
> + description: |
> + Frequency of the controller clock in Hz. Mutually exclusive with clocks.
> + See the note above.
> +
> +required:
> + - compatible
> + - reg
> + - "#address-cells"
> + - "#size-cells"
> +
> +oneOf:
> + - required:
> + - opencores,ip-clock-frequency
> + - required:
> + - clocks
This is correct if your intention was to require one of these
properties, which seems to match the old bindings.
> +
> +unevaluatedProperties: false
> +
> +examples:
> + - |
> + i2c@a0000000 {
> + #address-cells = <1>;
> + #size-cells = <0>;
> + compatible = "opencores,i2c-ocores";
> + reg = <0xa0000000 0x8>;
Reorder the properties in the node so first goes compatible then reg,
then the rest.
> + interrupts = <10>;
> + opencores,ip-clock-frequency = <20000000>;
> +
> + reg-shift = <0>; /* 8 bit registers */
> + reg-io-width = <1>; /* 8 bit read/write */
> +
> + dummy@60 {
> + compatible = "dummy";
> + reg = <0x60>;
> + };
> + };
> +
> + i2c@b0000000 {
> + #address-cells = <1>;
> + #size-cells = <0>;
> + compatible = "opencores,i2c-ocores";
> + reg = <0xa0000000 0x8>;
> + interrupts = <10>;
> + clocks = <&osc>;
> + clock-frequency = <400000>; /* i2c bus frequency 400 KHz */
> +
> + reg-shift = <0>; /* 8 bit registers */
> + reg-io-width = <1>; /* 8 bit read/write */
> +
> + dummy@60 {
> + compatible = "dummy";
> + reg = <0x60>;
> + };
> + };
> +...
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 34+ messages in thread* Re: [PATCH v1 2/6] dt-bindings: i2c: convert ocores binding to yaml
@ 2022-06-06 8:02 ` Krzysztof Kozlowski
0 siblings, 0 replies; 34+ messages in thread
From: Krzysztof Kozlowski @ 2022-06-06 8:02 UTC (permalink / raw)
To: mail, Rob Herring, Krzysztof Kozlowski, Andrew Lunn,
Support Opensource, Lee Jones, Ulf Hansson, Palmer Dabbelt,
Paul Walmsley, Albert Ou, Steve Twiss
Cc: Conor Dooley, linux-i2c, devicetree, linux-kernel, linux-mmc,
linux-riscv, Atul Khare
On 05/06/2022 15:32, mail@conchuod.ie wrote:
> From: Conor Dooley <conor.dooley@microchip.com>
>
> Convert the open cores i2c controller binding from text to yaml.
>
> Signed-off-by: Conor Dooley <conor.dooley@microchip.com>
> ---
> .../devicetree/bindings/i2c/i2c-ocores.txt | 78 -----------
> .../devicetree/bindings/i2c/i2c-ocores.yaml | 132 ++++++++++++++++++
> 2 files changed, 132 insertions(+), 78 deletions(-)
> delete mode 100644 Documentation/devicetree/bindings/i2c/i2c-ocores.txt
> create mode 100644 Documentation/devicetree/bindings/i2c/i2c-ocores.yaml
>
> diff --git a/Documentation/devicetree/bindings/i2c/i2c-ocores.txt b/Documentation/devicetree/bindings/i2c/i2c-ocores.txt
> deleted file mode 100644
> index a37c9455b244..000000000000
> --- a/Documentation/devicetree/bindings/i2c/i2c-ocores.txt
> +++ /dev/null
> @@ -1,78 +0,0 @@
> -Device tree configuration for i2c-ocores
> -
> -Required properties:
> -- compatible : "opencores,i2c-ocores"
> - "aeroflexgaisler,i2cmst"
> - "sifive,fu540-c000-i2c", "sifive,i2c0"
> - For Opencore based I2C IP block reimplemented in
> - FU540-C000 SoC.
> - "sifive,fu740-c000-i2c", "sifive,i2c0"
> - For Opencore based I2C IP block reimplemented in
> - FU740-C000 SoC.
> - Please refer to sifive-blocks-ip-versioning.txt for
> - additional details.
> -- reg : bus address start and address range size of device
> -- clocks : handle to the controller clock; see the note below.
> - Mutually exclusive with opencores,ip-clock-frequency
> -- opencores,ip-clock-frequency: frequency of the controller clock in Hz;
> - see the note below. Mutually exclusive with clocks
> -- #address-cells : should be <1>
> -- #size-cells : should be <0>
> -
> -Optional properties:
> -- interrupts : interrupt number.
> -- clock-frequency : frequency of bus clock in Hz; see the note below.
> - Defaults to 100 KHz when the property is not specified
> -- reg-shift : device register offsets are shifted by this value
> -- reg-io-width : io register width in bytes (1, 2 or 4)
> -- regstep : deprecated, use reg-shift above
> -
> -Note
> -clock-frequency property is meant to control the bus frequency for i2c bus
> -drivers, but it was incorrectly used to specify i2c controller input clock
> -frequency. So the following rules are set to fix this situation:
> -- if clock-frequency is present and neither opencores,ip-clock-frequency nor
> - clocks are, then clock-frequency specifies i2c controller clock frequency.
> - This is to keep backwards compatibility with setups using old DTB. i2c bus
> - frequency is fixed at 100 KHz.
> -- if clocks is present it specifies i2c controller clock. clock-frequency
> - property specifies i2c bus frequency.
> -- if opencores,ip-clock-frequency is present it specifies i2c controller
> - clock frequency. clock-frequency property specifies i2c bus frequency.
> -
> -Examples:
> -
> - i2c0: ocores@a0000000 {
> - #address-cells = <1>;
> - #size-cells = <0>;
> - compatible = "opencores,i2c-ocores";
> - reg = <0xa0000000 0x8>;
> - interrupts = <10>;
> - opencores,ip-clock-frequency = <20000000>;
> -
> - reg-shift = <0>; /* 8 bit registers */
> - reg-io-width = <1>; /* 8 bit read/write */
> -
> - dummy@60 {
> - compatible = "dummy";
> - reg = <0x60>;
> - };
> - };
> -or
> - i2c0: ocores@a0000000 {
> - #address-cells = <1>;
> - #size-cells = <0>;
> - compatible = "opencores,i2c-ocores";
> - reg = <0xa0000000 0x8>;
> - interrupts = <10>;
> - clocks = <&osc>;
> - clock-frequency = <400000>; /* i2c bus frequency 400 KHz */
> -
> - reg-shift = <0>; /* 8 bit registers */
> - reg-io-width = <1>; /* 8 bit read/write */
> -
> - dummy@60 {
> - compatible = "dummy";
> - reg = <0x60>;
> - };
> - };
> diff --git a/Documentation/devicetree/bindings/i2c/i2c-ocores.yaml b/Documentation/devicetree/bindings/i2c/i2c-ocores.yaml
> new file mode 100644
> index 000000000000..1693ffffbe31
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/i2c/i2c-ocores.yaml
> @@ -0,0 +1,132 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/i2c/i2c-ocores.yaml#
This should be rather named with vendor prefix, so:
opencores,i2c-ocores.yaml
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: OpenCores I2C controller
> +
> +maintainers:
> + - Peter Korsgaard <peter@korsgaard.com>
> + - Andrew Lunn <andrew@lunn.ch>
> +
> +allOf:
> + - $ref: /schemas/i2c/i2c-controller.yaml#
> +
> +properties:
> + compatible:
> + oneOf:
> + - items:
> + - enum:
> + - sifive,fu740-c000-i2c # Opencore based IP block FU740-C000 SoC
> + - sifive,fu540-c000-i2c # Opencore based IP block FU540-C000 SoC
> + - const: sifive,i2c0
> + - const: opencores,i2c-ocores
> + - const: aeroflexgaisler,i2cmst
The last two are just enum
> +
> + reg:
> + maxItems: 1
> +
> + interrupts:
> + maxItems: 1
> +
> + clocks:
> + maxItems: 1
> +
> + "#address-cells":
> + const: 1
> +
> + "#size-cells":
> + const: 0
> +
> + clock-frequency:
> + description: |
> + Desired I2C bus clock frequency in Hz. As only Standard and Fast
> + modes are supported, possible values are 100000 and 400000.
Add enum with the two values.
> + Note:
> + clock-frequency property is meant to control the bus frequency for i2c bus
> + drivers, but it was incorrectly used to specify i2c controller input clock
> + frequency. So the following rules are set to fix this situation:
> + - if clock-frequency is present and neither opencores,ip-clock-frequency nor
> + clocks are, then clock-frequency specifies i2c controller clock frequency.
> + This is to keep backwards compatibility with setups using old DTB. i2c bus
> + frequency is fixed at 100 KHz.
> + - if clocks is present it specifies i2c controller clock. clock-frequency
> + property specifies i2c bus frequency.
> + - if opencores,ip-clock-frequency is present it specifies i2c controller
> + clock frequency. clock-frequency property specifies i2c bus frequency.
> + default: 100000
> +
> + reg-io-width:
> + $ref: /schemas/types.yaml#/definitions/uint32
No need for ref, it is coming from the dtschema.
> + description: |
> + io register width in bytes
> + enum: [1, 2, 4]
> +
> + reg-shift:
> + $ref: /schemas/types.yaml#/definitions/uint32
No need for ref, it is coming from the dtschema.
> + description: |
> + device register offsets are shifted by this value
I guess 0 is default?
> +
> + regstep:
> + description: |
> + deprecated, use reg-shift above
> + deprecated: true
> +
> + opencores,ip-clock-frequency:
> + $ref: /schemas/types.yaml#/definitions/uint32
> + description: |
> + Frequency of the controller clock in Hz. Mutually exclusive with clocks.
> + See the note above.
> +
> +required:
> + - compatible
> + - reg
> + - "#address-cells"
> + - "#size-cells"
> +
> +oneOf:
> + - required:
> + - opencores,ip-clock-frequency
> + - required:
> + - clocks
This is correct if your intention was to require one of these
properties, which seems to match the old bindings.
> +
> +unevaluatedProperties: false
> +
> +examples:
> + - |
> + i2c@a0000000 {
> + #address-cells = <1>;
> + #size-cells = <0>;
> + compatible = "opencores,i2c-ocores";
> + reg = <0xa0000000 0x8>;
Reorder the properties in the node so first goes compatible then reg,
then the rest.
> + interrupts = <10>;
> + opencores,ip-clock-frequency = <20000000>;
> +
> + reg-shift = <0>; /* 8 bit registers */
> + reg-io-width = <1>; /* 8 bit read/write */
> +
> + dummy@60 {
> + compatible = "dummy";
> + reg = <0x60>;
> + };
> + };
> +
> + i2c@b0000000 {
> + #address-cells = <1>;
> + #size-cells = <0>;
> + compatible = "opencores,i2c-ocores";
> + reg = <0xa0000000 0x8>;
> + interrupts = <10>;
> + clocks = <&osc>;
> + clock-frequency = <400000>; /* i2c bus frequency 400 KHz */
> +
> + reg-shift = <0>; /* 8 bit registers */
> + reg-io-width = <1>; /* 8 bit read/write */
> +
> + dummy@60 {
> + compatible = "dummy";
> + reg = <0x60>;
> + };
> + };
> +...
Best regards,
Krzysztof
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
^ permalink raw reply [flat|nested] 34+ messages in thread* Re: [PATCH v1 2/6] dt-bindings: i2c: convert ocores binding to yaml
2022-06-06 8:02 ` Krzysztof Kozlowski
@ 2022-06-06 14:41 ` Conor.Dooley
-1 siblings, 0 replies; 34+ messages in thread
From: Conor.Dooley @ 2022-06-06 14:41 UTC (permalink / raw)
To: krzysztof.kozlowski, mail, robh+dt, krzysztof.kozlowski+dt,
andrew, support.opensource, lee.jones, ulf.hansson, palmer,
paul.walmsley, aou, stwiss.opensource
Cc: linux-i2c, devicetree, linux-kernel, linux-mmc, linux-riscv, atulkhare
On 06/06/2022 09:02, Krzysztof Kozlowski wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
>
> On 05/06/2022 15:32, mail@conchuod.ie wrote:
>> From: Conor Dooley <conor.dooley@microchip.com>
>>
>> Convert the open cores i2c controller binding from text to yaml.
>>
>> Signed-off-by: Conor Dooley <conor.dooley@microchip.com>
>> ---
>> .../devicetree/bindings/i2c/i2c-ocores.txt | 78 -----------
>> .../devicetree/bindings/i2c/i2c-ocores.yaml | 132 ++++++++++++++++++
>> 2 files changed, 132 insertions(+), 78 deletions(-)
>> delete mode 100644 Documentation/devicetree/bindings/i2c/i2c-ocores.txt
>> create mode 100644 Documentation/devicetree/bindings/i2c/i2c-ocores.yaml
>>
---8<---
>> + reg-shift:
>> + $ref: /schemas/types.yaml#/definitions/uint32
>
> No need for ref, it is coming from the dtschema.
>
>> + description: |
>> + device register offsets are shifted by this value
>
> I guess 0 is default?
>
I had a look around:
sifive and the users of opencores,i2c-ocores use 2
aeroflexgaisler,i2cmst does not exist in a devicetree
From the driver, it looks like if neither this nor regstep
is present it just carries on without setting a value.
So yeah, I guess it is zero.
>
>> +
>> + regstep:
>> + description: |
>> + deprecated, use reg-shift above
>> + deprecated: true
>> +
>> + opencores,ip-clock-frequency:
>> + $ref: /schemas/types.yaml#/definitions/uint32
>> + description: |
>> + Frequency of the controller clock in Hz. Mutually exclusive with clocks.
>> + See the note above.
>> +
>> +required:
>> + - compatible
>> + - reg
>> + - "#address-cells"
>> + - "#size-cells"
>> +
>> +oneOf:
>> + - required:
>> + - opencores,ip-clock-frequency
>> + - required:
>> + - clocks
>
> This is correct if your intention was to require one of these
> properties, which seems to match the old bindings.
Cool, thanks! I did test adding both and got a wall-of-text error
from dt_binding_check, so it seemed about right.
Thanks,
Conor.
^ permalink raw reply [flat|nested] 34+ messages in thread
* Re: [PATCH v1 2/6] dt-bindings: i2c: convert ocores binding to yaml
@ 2022-06-06 14:41 ` Conor.Dooley
0 siblings, 0 replies; 34+ messages in thread
From: Conor.Dooley @ 2022-06-06 14:41 UTC (permalink / raw)
To: krzysztof.kozlowski, mail, robh+dt, krzysztof.kozlowski+dt,
andrew, support.opensource, lee.jones, ulf.hansson, palmer,
paul.walmsley, aou, stwiss.opensource
Cc: linux-i2c, devicetree, linux-kernel, linux-mmc, linux-riscv, atulkhare
On 06/06/2022 09:02, Krzysztof Kozlowski wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
>
> On 05/06/2022 15:32, mail@conchuod.ie wrote:
>> From: Conor Dooley <conor.dooley@microchip.com>
>>
>> Convert the open cores i2c controller binding from text to yaml.
>>
>> Signed-off-by: Conor Dooley <conor.dooley@microchip.com>
>> ---
>> .../devicetree/bindings/i2c/i2c-ocores.txt | 78 -----------
>> .../devicetree/bindings/i2c/i2c-ocores.yaml | 132 ++++++++++++++++++
>> 2 files changed, 132 insertions(+), 78 deletions(-)
>> delete mode 100644 Documentation/devicetree/bindings/i2c/i2c-ocores.txt
>> create mode 100644 Documentation/devicetree/bindings/i2c/i2c-ocores.yaml
>>
---8<---
>> + reg-shift:
>> + $ref: /schemas/types.yaml#/definitions/uint32
>
> No need for ref, it is coming from the dtschema.
>
>> + description: |
>> + device register offsets are shifted by this value
>
> I guess 0 is default?
>
I had a look around:
sifive and the users of opencores,i2c-ocores use 2
aeroflexgaisler,i2cmst does not exist in a devicetree
From the driver, it looks like if neither this nor regstep
is present it just carries on without setting a value.
So yeah, I guess it is zero.
>
>> +
>> + regstep:
>> + description: |
>> + deprecated, use reg-shift above
>> + deprecated: true
>> +
>> + opencores,ip-clock-frequency:
>> + $ref: /schemas/types.yaml#/definitions/uint32
>> + description: |
>> + Frequency of the controller clock in Hz. Mutually exclusive with clocks.
>> + See the note above.
>> +
>> +required:
>> + - compatible
>> + - reg
>> + - "#address-cells"
>> + - "#size-cells"
>> +
>> +oneOf:
>> + - required:
>> + - opencores,ip-clock-frequency
>> + - required:
>> + - clocks
>
> This is correct if your intention was to require one of these
> properties, which seems to match the old bindings.
Cool, thanks! I did test adding both and got a wall-of-text error
from dt_binding_check, so it seemed about right.
Thanks,
Conor.
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
^ permalink raw reply [flat|nested] 34+ messages in thread
* Re: [PATCH v1 2/6] dt-bindings: i2c: convert ocores binding to yaml
2022-06-05 13:32 ` mail
@ 2022-06-06 12:53 ` Rob Herring
-1 siblings, 0 replies; 34+ messages in thread
From: Rob Herring @ 2022-06-06 12:53 UTC (permalink / raw)
To: mail
Cc: Steve Twiss, Paul Walmsley, linux-riscv, Andrew Lunn, linux-i2c,
Support Opensource, Albert Ou, Palmer Dabbelt, Ulf Hansson,
linux-mmc, Rob Herring, linux-kernel, Lee Jones, devicetree,
Conor Dooley, Atul Khare, Krzysztof Kozlowski
On Sun, 05 Jun 2022 14:32:57 +0100, mail@conchuod.ie wrote:
> From: Conor Dooley <conor.dooley@microchip.com>
>
> Convert the open cores i2c controller binding from text to yaml.
>
> Signed-off-by: Conor Dooley <conor.dooley@microchip.com>
> ---
> .../devicetree/bindings/i2c/i2c-ocores.txt | 78 -----------
> .../devicetree/bindings/i2c/i2c-ocores.yaml | 132 ++++++++++++++++++
> 2 files changed, 132 insertions(+), 78 deletions(-)
> delete mode 100644 Documentation/devicetree/bindings/i2c/i2c-ocores.txt
> create mode 100644 Documentation/devicetree/bindings/i2c/i2c-ocores.yaml
>
My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
on your patch (DT_CHECKER_FLAGS is new in v5.13):
yamllint warnings/errors:
dtschema/dtc warnings/errors:
Documentation/devicetree/bindings/i2c/i2c-ocores.example.dtb:0:0: /example-0/i2c@a0000000/dummy@60: failed to match any schema with compatible: ['dummy']
Documentation/devicetree/bindings/i2c/i2c-ocores.example.dtb:0:0: /example-0/i2c@b0000000/dummy@60: failed to match any schema with compatible: ['dummy']
doc reference errors (make refcheckdocs):
Warning: MAINTAINERS references a file that doesn't exist: Documentation/devicetree/bindings/i2c/i2c-ocores.txt
MAINTAINERS: Documentation/devicetree/bindings/i2c/i2c-ocores.txt
See https://patchwork.ozlabs.org/patch/
This check can fail if there are any dependencies. The base for a patch
series is generally the most recent rc1.
If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:
pip3 install dtschema --upgrade
Please check and re-submit.
^ permalink raw reply [flat|nested] 34+ messages in thread
* Re: [PATCH v1 2/6] dt-bindings: i2c: convert ocores binding to yaml
@ 2022-06-06 12:53 ` Rob Herring
0 siblings, 0 replies; 34+ messages in thread
From: Rob Herring @ 2022-06-06 12:53 UTC (permalink / raw)
To: mail
Cc: Steve Twiss, Paul Walmsley, linux-riscv, Andrew Lunn, linux-i2c,
Support Opensource, Albert Ou, Palmer Dabbelt, Ulf Hansson,
linux-mmc, Rob Herring, linux-kernel, Lee Jones, devicetree,
Conor Dooley, Atul Khare, Krzysztof Kozlowski
On Sun, 05 Jun 2022 14:32:57 +0100, mail@conchuod.ie wrote:
> From: Conor Dooley <conor.dooley@microchip.com>
>
> Convert the open cores i2c controller binding from text to yaml.
>
> Signed-off-by: Conor Dooley <conor.dooley@microchip.com>
> ---
> .../devicetree/bindings/i2c/i2c-ocores.txt | 78 -----------
> .../devicetree/bindings/i2c/i2c-ocores.yaml | 132 ++++++++++++++++++
> 2 files changed, 132 insertions(+), 78 deletions(-)
> delete mode 100644 Documentation/devicetree/bindings/i2c/i2c-ocores.txt
> create mode 100644 Documentation/devicetree/bindings/i2c/i2c-ocores.yaml
>
My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
on your patch (DT_CHECKER_FLAGS is new in v5.13):
yamllint warnings/errors:
dtschema/dtc warnings/errors:
Documentation/devicetree/bindings/i2c/i2c-ocores.example.dtb:0:0: /example-0/i2c@a0000000/dummy@60: failed to match any schema with compatible: ['dummy']
Documentation/devicetree/bindings/i2c/i2c-ocores.example.dtb:0:0: /example-0/i2c@b0000000/dummy@60: failed to match any schema with compatible: ['dummy']
doc reference errors (make refcheckdocs):
Warning: MAINTAINERS references a file that doesn't exist: Documentation/devicetree/bindings/i2c/i2c-ocores.txt
MAINTAINERS: Documentation/devicetree/bindings/i2c/i2c-ocores.txt
See https://patchwork.ozlabs.org/patch/
This check can fail if there are any dependencies. The base for a patch
series is generally the most recent rc1.
If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:
pip3 install dtschema --upgrade
Please check and re-submit.
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
^ permalink raw reply [flat|nested] 34+ messages in thread
* [PATCH v1 3/6] MAINTAINERS: convert ocores i2c dt-binding to yaml
2022-06-05 13:32 ` mail
@ 2022-06-05 13:32 ` mail
-1 siblings, 0 replies; 34+ messages in thread
From: mail @ 2022-06-05 13:32 UTC (permalink / raw)
To: Rob Herring, Krzysztof Kozlowski, Andrew Lunn,
Support Opensource, Lee Jones, Ulf Hansson, Palmer Dabbelt,
Paul Walmsley, Albert Ou, Steve Twiss
Cc: Conor Dooley, linux-i2c, devicetree, linux-kernel, linux-mmc,
linux-riscv, Atul Khare
From: Conor Dooley <conor.dooley@microchip.com>
As the ocores i2c dt-binding has been converted to yaml, update the
maintainers entry.
Signed-off-by: Conor Dooley <conor.dooley@microchip.com>
---
MAINTAINERS | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/MAINTAINERS b/MAINTAINERS
index f1b4b77daa5f..f799cf34ea52 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -14826,7 +14826,7 @@ M: Peter Korsgaard <peter@korsgaard.com>
M: Andrew Lunn <andrew@lunn.ch>
L: linux-i2c@vger.kernel.org
S: Maintained
-F: Documentation/devicetree/bindings/i2c/i2c-ocores.txt
+F: Documentation/devicetree/bindings/i2c/i2c-ocores.yaml
F: Documentation/i2c/busses/i2c-ocores.rst
F: drivers/i2c/busses/i2c-ocores.c
F: include/linux/platform_data/i2c-ocores.h
--
2.36.1
^ permalink raw reply related [flat|nested] 34+ messages in thread
* [PATCH v1 3/6] MAINTAINERS: convert ocores i2c dt-binding to yaml
@ 2022-06-05 13:32 ` mail
0 siblings, 0 replies; 34+ messages in thread
From: mail @ 2022-06-05 13:32 UTC (permalink / raw)
To: Rob Herring, Krzysztof Kozlowski, Andrew Lunn,
Support Opensource, Lee Jones, Ulf Hansson, Palmer Dabbelt,
Paul Walmsley, Albert Ou, Steve Twiss
Cc: Conor Dooley, linux-i2c, devicetree, linux-kernel, linux-mmc,
linux-riscv, Atul Khare
From: Conor Dooley <conor.dooley@microchip.com>
As the ocores i2c dt-binding has been converted to yaml, update the
maintainers entry.
Signed-off-by: Conor Dooley <conor.dooley@microchip.com>
---
MAINTAINERS | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/MAINTAINERS b/MAINTAINERS
index f1b4b77daa5f..f799cf34ea52 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -14826,7 +14826,7 @@ M: Peter Korsgaard <peter@korsgaard.com>
M: Andrew Lunn <andrew@lunn.ch>
L: linux-i2c@vger.kernel.org
S: Maintained
-F: Documentation/devicetree/bindings/i2c/i2c-ocores.txt
+F: Documentation/devicetree/bindings/i2c/i2c-ocores.yaml
F: Documentation/i2c/busses/i2c-ocores.rst
F: drivers/i2c/busses/i2c-ocores.c
F: include/linux/platform_data/i2c-ocores.h
--
2.36.1
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
^ permalink raw reply related [flat|nested] 34+ messages in thread
* [PATCH v1 4/6] dt-bindings: mfd: convert da9063 to yaml
2022-06-05 13:32 ` mail
@ 2022-06-05 13:32 ` mail
-1 siblings, 0 replies; 34+ messages in thread
From: mail @ 2022-06-05 13:32 UTC (permalink / raw)
To: Rob Herring, Krzysztof Kozlowski, Andrew Lunn,
Support Opensource, Lee Jones, Ulf Hansson, Palmer Dabbelt,
Paul Walmsley, Albert Ou, Steve Twiss
Cc: Conor Dooley, linux-i2c, devicetree, linux-kernel, linux-mmc,
linux-riscv, Atul Khare
From: Conor Dooley <conor.dooley@microchip.com>
Convert the dt binding for the da9063/da9063l to yaml.
Signed-off-by: Conor Dooley <conor.dooley@microchip.com>
---
.../devicetree/bindings/mfd/da9063.txt | 111 ----------------
.../devicetree/bindings/mfd/da9063.yaml | 123 ++++++++++++++++++
.../devicetree/bindings/trivial-devices.yaml | 2 -
3 files changed, 123 insertions(+), 113 deletions(-)
delete mode 100644 Documentation/devicetree/bindings/mfd/da9063.txt
create mode 100644 Documentation/devicetree/bindings/mfd/da9063.yaml
diff --git a/Documentation/devicetree/bindings/mfd/da9063.txt b/Documentation/devicetree/bindings/mfd/da9063.txt
deleted file mode 100644
index 91b79a21d403..000000000000
--- a/Documentation/devicetree/bindings/mfd/da9063.txt
+++ /dev/null
@@ -1,111 +0,0 @@
-* Dialog DA9063/DA9063L Power Management Integrated Circuit (PMIC)
-
-DA9063 consists of a large and varied group of sub-devices (I2C Only):
-
-Device Supply Names Description
------- ------------ -----------
-da9063-regulator : : LDOs & BUCKs
-da9063-onkey : : On Key
-da9063-rtc : : Real-Time Clock (DA9063 only)
-da9063-watchdog : : Watchdog
-
-======
-
-Required properties:
-
-- compatible : Should be "dlg,da9063" or "dlg,da9063l"
-- reg : Specifies the I2C slave address (this defaults to 0x58 but it can be
- modified to match the chip's OTP settings).
-- interrupts : IRQ line information.
-- interrupt-controller
-
-Sub-nodes:
-
-- regulators : This node defines the settings for the LDOs and BUCKs.
- The DA9063(L) regulators are bound using their names listed below:
-
- bcore1 : BUCK CORE1
- bcore2 : BUCK CORE2
- bpro : BUCK PRO
- bmem : BUCK MEM
- bio : BUCK IO
- bperi : BUCK PERI
- ldo1 : LDO_1 (DA9063 only)
- ldo2 : LDO_2 (DA9063 only)
- ldo3 : LDO_3
- ldo4 : LDO_4 (DA9063 only)
- ldo5 : LDO_5 (DA9063 only)
- ldo6 : LDO_6 (DA9063 only)
- ldo7 : LDO_7
- ldo8 : LDO_8
- ldo9 : LDO_9
- ldo10 : LDO_10 (DA9063 only)
- ldo11 : LDO_11
-
- The component follows the standard regulator framework and the bindings
- details of individual regulator device can be found in:
- Documentation/devicetree/bindings/regulator/regulator.txt
-
-- rtc : This node defines settings for the Real-Time Clock associated with
- the DA9063 only. The RTC is not present in DA9063L. There are currently
- no entries in this binding, however compatible = "dlg,da9063-rtc" should
- be added if a node is created.
-
-- onkey : This node defines the OnKey settings for controlling the key
- functionality of the device. The node should contain the compatible property
- with the value "dlg,da9063-onkey".
-
- Optional onkey properties:
-
- - dlg,disable-key-power : Disable power-down using a long key-press. If this
- entry exists the OnKey driver will remove support for the KEY_POWER key
- press. If this entry does not exist then by default the key-press
- triggered power down is enabled and the OnKey will support both KEY_POWER
- and KEY_SLEEP.
-
-- watchdog : This node defines settings for the Watchdog timer associated
- with the DA9063 and DA9063L. There are currently no entries in this
- binding, however compatible = "dlg,da9063-watchdog" should be added
- if a node is created.
-
-
-Example:
-
- pmic0: da9063@58 {
- compatible = "dlg,da9063"
- reg = <0x58>;
- interrupt-parent = <&gpio6>;
- interrupts = <11 IRQ_TYPE_LEVEL_LOW>;
- interrupt-controller;
-
- rtc {
- compatible = "dlg,da9063-rtc";
- };
-
- wdt {
- compatible = "dlg,da9063-watchdog";
- };
-
- onkey {
- compatible = "dlg,da9063-onkey";
- dlg,disable-key-power;
- };
-
- regulators {
- DA9063_BCORE1: bcore1 {
- regulator-name = "BCORE1";
- regulator-min-microvolt = <300000>;
- regulator-max-microvolt = <1570000>;
- regulator-min-microamp = <500000>;
- regulator-max-microamp = <2000000>;
- regulator-boot-on;
- };
- DA9063_LDO11: ldo11 {
- regulator-name = "LDO_11";
- regulator-min-microvolt = <900000>;
- regulator-max-microvolt = <3600000>;
- regulator-boot-on;
- };
- };
- };
-
diff --git a/Documentation/devicetree/bindings/mfd/da9063.yaml b/Documentation/devicetree/bindings/mfd/da9063.yaml
new file mode 100644
index 000000000000..376880061f42
--- /dev/null
+++ b/Documentation/devicetree/bindings/mfd/da9063.yaml
@@ -0,0 +1,123 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/mfd/da9063.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Dialog DA9063/DA9063L Power Management Integrated Circuit (PMIC)
+
+maintainers:
+ - Steve Twiss <stwiss.opensource@diasemi.com>
+
+description: |
+ For device-tree bindings of other sub-modules refer to the binding documents
+ under the respective sub-system directories.
+
+properties:
+ compatible:
+ enum:
+ - dlg,da9063
+ - dlg,da9063l
+
+ reg:
+ description:
+ I2C device address.
+ maxItems: 1
+
+ interrupts:
+ maxItems: 1
+
+ interrupt-controller: true
+
+ "#interrupt-cells":
+ const: 2
+
+ watchdog:
+ type: object
+ $ref: ../watchdog/watchdog.yaml#
+ properties:
+ compatible:
+ const: dlg,da9063-watchdog
+
+ rtc:
+ type: object
+ $ref: ../rtc/rtc.yaml#
+ properties:
+ compatible:
+ const: dlg,da9063-rtc
+
+ onkey:
+ type: object
+ $ref: ../input/input.yaml#
+ properties:
+ compatible:
+ const: dlg,da9063-onkey
+
+ dlg,disable-key-power:
+ type: boolean
+ description: |
+ Disable power-down using a long key-press.
+ If this entry does not exist then by default the key-press triggered
+ power down is enabled and the OnKey will support both KEY_POWER and
+ KEY_SLEEP.
+
+ regulators:
+ type: object
+ patternProperties:
+ "^(ldo[1-11]|bcore[1-2]|bpro|bmem|bio|bperi)$":
+ $ref: ../regulator/regulator.yaml
+
+required:
+ - compatible
+ - reg
+ - interrupts
+ - interrupt-controller
+
+additionalProperties: false
+
+examples:
+ - |
+ #include <dt-bindings/interrupt-controller/irq.h>
+ i2c {
+ #address-cells = <1>;
+ #size-cells = <0>;
+ pmic@58 {
+ compatible = "dlg,da9063";
+ reg = <0x58>;
+ #interrupt-cells = <2>;
+ interrupt-parent = <&gpio6>;
+ interrupts = <11 IRQ_TYPE_LEVEL_LOW>;
+ interrupt-controller;
+
+ rtc {
+ compatible = "dlg,da9063-rtc";
+ };
+
+ watchdog {
+ compatible = "dlg,da9063-watchdog";
+ };
+
+ onkey {
+ compatible = "dlg,da9063-onkey";
+ dlg,disable-key-power;
+ };
+
+ regulators {
+ regulator-bcore1 {
+ regulator-name = "BCORE1";
+ regulator-min-microvolt = <300000>;
+ regulator-max-microvolt = <1570000>;
+ regulator-min-microamp = <500000>;
+ regulator-max-microamp = <2000000>;
+ regulator-boot-on;
+ };
+ regulator-ldo11 {
+ regulator-name = "LDO_11";
+ regulator-min-microvolt = <900000>;
+ regulator-max-microvolt = <3600000>;
+ regulator-boot-on;
+ };
+ };
+ };
+ };
+...
diff --git a/Documentation/devicetree/bindings/trivial-devices.yaml b/Documentation/devicetree/bindings/trivial-devices.yaml
index 6aafa71806a3..00acb9078cc0 100644
--- a/Documentation/devicetree/bindings/trivial-devices.yaml
+++ b/Documentation/devicetree/bindings/trivial-devices.yaml
@@ -93,8 +93,6 @@ properties:
- dh,dhcom-board
# DA9053: flexible system level PMIC with multicore support
- dlg,da9053
- # DA9063: system PMIC for quad-core application processors
- - dlg,da9063
# DMARD05: 3-axis I2C Accelerometer
- domintech,dmard05
# DMARD06: 3-axis I2C Accelerometer
--
2.36.1
^ permalink raw reply related [flat|nested] 34+ messages in thread* [PATCH v1 4/6] dt-bindings: mfd: convert da9063 to yaml
@ 2022-06-05 13:32 ` mail
0 siblings, 0 replies; 34+ messages in thread
From: mail @ 2022-06-05 13:32 UTC (permalink / raw)
To: Rob Herring, Krzysztof Kozlowski, Andrew Lunn,
Support Opensource, Lee Jones, Ulf Hansson, Palmer Dabbelt,
Paul Walmsley, Albert Ou, Steve Twiss
Cc: Conor Dooley, linux-i2c, devicetree, linux-kernel, linux-mmc,
linux-riscv, Atul Khare
From: Conor Dooley <conor.dooley@microchip.com>
Convert the dt binding for the da9063/da9063l to yaml.
Signed-off-by: Conor Dooley <conor.dooley@microchip.com>
---
.../devicetree/bindings/mfd/da9063.txt | 111 ----------------
.../devicetree/bindings/mfd/da9063.yaml | 123 ++++++++++++++++++
.../devicetree/bindings/trivial-devices.yaml | 2 -
3 files changed, 123 insertions(+), 113 deletions(-)
delete mode 100644 Documentation/devicetree/bindings/mfd/da9063.txt
create mode 100644 Documentation/devicetree/bindings/mfd/da9063.yaml
diff --git a/Documentation/devicetree/bindings/mfd/da9063.txt b/Documentation/devicetree/bindings/mfd/da9063.txt
deleted file mode 100644
index 91b79a21d403..000000000000
--- a/Documentation/devicetree/bindings/mfd/da9063.txt
+++ /dev/null
@@ -1,111 +0,0 @@
-* Dialog DA9063/DA9063L Power Management Integrated Circuit (PMIC)
-
-DA9063 consists of a large and varied group of sub-devices (I2C Only):
-
-Device Supply Names Description
------- ------------ -----------
-da9063-regulator : : LDOs & BUCKs
-da9063-onkey : : On Key
-da9063-rtc : : Real-Time Clock (DA9063 only)
-da9063-watchdog : : Watchdog
-
-======
-
-Required properties:
-
-- compatible : Should be "dlg,da9063" or "dlg,da9063l"
-- reg : Specifies the I2C slave address (this defaults to 0x58 but it can be
- modified to match the chip's OTP settings).
-- interrupts : IRQ line information.
-- interrupt-controller
-
-Sub-nodes:
-
-- regulators : This node defines the settings for the LDOs and BUCKs.
- The DA9063(L) regulators are bound using their names listed below:
-
- bcore1 : BUCK CORE1
- bcore2 : BUCK CORE2
- bpro : BUCK PRO
- bmem : BUCK MEM
- bio : BUCK IO
- bperi : BUCK PERI
- ldo1 : LDO_1 (DA9063 only)
- ldo2 : LDO_2 (DA9063 only)
- ldo3 : LDO_3
- ldo4 : LDO_4 (DA9063 only)
- ldo5 : LDO_5 (DA9063 only)
- ldo6 : LDO_6 (DA9063 only)
- ldo7 : LDO_7
- ldo8 : LDO_8
- ldo9 : LDO_9
- ldo10 : LDO_10 (DA9063 only)
- ldo11 : LDO_11
-
- The component follows the standard regulator framework and the bindings
- details of individual regulator device can be found in:
- Documentation/devicetree/bindings/regulator/regulator.txt
-
-- rtc : This node defines settings for the Real-Time Clock associated with
- the DA9063 only. The RTC is not present in DA9063L. There are currently
- no entries in this binding, however compatible = "dlg,da9063-rtc" should
- be added if a node is created.
-
-- onkey : This node defines the OnKey settings for controlling the key
- functionality of the device. The node should contain the compatible property
- with the value "dlg,da9063-onkey".
-
- Optional onkey properties:
-
- - dlg,disable-key-power : Disable power-down using a long key-press. If this
- entry exists the OnKey driver will remove support for the KEY_POWER key
- press. If this entry does not exist then by default the key-press
- triggered power down is enabled and the OnKey will support both KEY_POWER
- and KEY_SLEEP.
-
-- watchdog : This node defines settings for the Watchdog timer associated
- with the DA9063 and DA9063L. There are currently no entries in this
- binding, however compatible = "dlg,da9063-watchdog" should be added
- if a node is created.
-
-
-Example:
-
- pmic0: da9063@58 {
- compatible = "dlg,da9063"
- reg = <0x58>;
- interrupt-parent = <&gpio6>;
- interrupts = <11 IRQ_TYPE_LEVEL_LOW>;
- interrupt-controller;
-
- rtc {
- compatible = "dlg,da9063-rtc";
- };
-
- wdt {
- compatible = "dlg,da9063-watchdog";
- };
-
- onkey {
- compatible = "dlg,da9063-onkey";
- dlg,disable-key-power;
- };
-
- regulators {
- DA9063_BCORE1: bcore1 {
- regulator-name = "BCORE1";
- regulator-min-microvolt = <300000>;
- regulator-max-microvolt = <1570000>;
- regulator-min-microamp = <500000>;
- regulator-max-microamp = <2000000>;
- regulator-boot-on;
- };
- DA9063_LDO11: ldo11 {
- regulator-name = "LDO_11";
- regulator-min-microvolt = <900000>;
- regulator-max-microvolt = <3600000>;
- regulator-boot-on;
- };
- };
- };
-
diff --git a/Documentation/devicetree/bindings/mfd/da9063.yaml b/Documentation/devicetree/bindings/mfd/da9063.yaml
new file mode 100644
index 000000000000..376880061f42
--- /dev/null
+++ b/Documentation/devicetree/bindings/mfd/da9063.yaml
@@ -0,0 +1,123 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/mfd/da9063.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Dialog DA9063/DA9063L Power Management Integrated Circuit (PMIC)
+
+maintainers:
+ - Steve Twiss <stwiss.opensource@diasemi.com>
+
+description: |
+ For device-tree bindings of other sub-modules refer to the binding documents
+ under the respective sub-system directories.
+
+properties:
+ compatible:
+ enum:
+ - dlg,da9063
+ - dlg,da9063l
+
+ reg:
+ description:
+ I2C device address.
+ maxItems: 1
+
+ interrupts:
+ maxItems: 1
+
+ interrupt-controller: true
+
+ "#interrupt-cells":
+ const: 2
+
+ watchdog:
+ type: object
+ $ref: ../watchdog/watchdog.yaml#
+ properties:
+ compatible:
+ const: dlg,da9063-watchdog
+
+ rtc:
+ type: object
+ $ref: ../rtc/rtc.yaml#
+ properties:
+ compatible:
+ const: dlg,da9063-rtc
+
+ onkey:
+ type: object
+ $ref: ../input/input.yaml#
+ properties:
+ compatible:
+ const: dlg,da9063-onkey
+
+ dlg,disable-key-power:
+ type: boolean
+ description: |
+ Disable power-down using a long key-press.
+ If this entry does not exist then by default the key-press triggered
+ power down is enabled and the OnKey will support both KEY_POWER and
+ KEY_SLEEP.
+
+ regulators:
+ type: object
+ patternProperties:
+ "^(ldo[1-11]|bcore[1-2]|bpro|bmem|bio|bperi)$":
+ $ref: ../regulator/regulator.yaml
+
+required:
+ - compatible
+ - reg
+ - interrupts
+ - interrupt-controller
+
+additionalProperties: false
+
+examples:
+ - |
+ #include <dt-bindings/interrupt-controller/irq.h>
+ i2c {
+ #address-cells = <1>;
+ #size-cells = <0>;
+ pmic@58 {
+ compatible = "dlg,da9063";
+ reg = <0x58>;
+ #interrupt-cells = <2>;
+ interrupt-parent = <&gpio6>;
+ interrupts = <11 IRQ_TYPE_LEVEL_LOW>;
+ interrupt-controller;
+
+ rtc {
+ compatible = "dlg,da9063-rtc";
+ };
+
+ watchdog {
+ compatible = "dlg,da9063-watchdog";
+ };
+
+ onkey {
+ compatible = "dlg,da9063-onkey";
+ dlg,disable-key-power;
+ };
+
+ regulators {
+ regulator-bcore1 {
+ regulator-name = "BCORE1";
+ regulator-min-microvolt = <300000>;
+ regulator-max-microvolt = <1570000>;
+ regulator-min-microamp = <500000>;
+ regulator-max-microamp = <2000000>;
+ regulator-boot-on;
+ };
+ regulator-ldo11 {
+ regulator-name = "LDO_11";
+ regulator-min-microvolt = <900000>;
+ regulator-max-microvolt = <3600000>;
+ regulator-boot-on;
+ };
+ };
+ };
+ };
+...
diff --git a/Documentation/devicetree/bindings/trivial-devices.yaml b/Documentation/devicetree/bindings/trivial-devices.yaml
index 6aafa71806a3..00acb9078cc0 100644
--- a/Documentation/devicetree/bindings/trivial-devices.yaml
+++ b/Documentation/devicetree/bindings/trivial-devices.yaml
@@ -93,8 +93,6 @@ properties:
- dh,dhcom-board
# DA9053: flexible system level PMIC with multicore support
- dlg,da9053
- # DA9063: system PMIC for quad-core application processors
- - dlg,da9063
# DMARD05: 3-axis I2C Accelerometer
- domintech,dmard05
# DMARD06: 3-axis I2C Accelerometer
--
2.36.1
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
^ permalink raw reply related [flat|nested] 34+ messages in thread* Re: [PATCH v1 4/6] dt-bindings: mfd: convert da9063 to yaml
2022-06-05 13:32 ` mail
@ 2022-06-06 13:11 ` Krzysztof Kozlowski
-1 siblings, 0 replies; 34+ messages in thread
From: Krzysztof Kozlowski @ 2022-06-06 13:11 UTC (permalink / raw)
To: mail, Rob Herring, Krzysztof Kozlowski, Andrew Lunn,
Support Opensource, Lee Jones, Ulf Hansson, Palmer Dabbelt,
Paul Walmsley, Albert Ou, Steve Twiss
Cc: Conor Dooley, linux-i2c, devicetree, linux-kernel, linux-mmc,
linux-riscv, Atul Khare
On 05/06/2022 15:32, mail@conchuod.ie wrote:
> From: Conor Dooley <conor.dooley@microchip.com>
>
> Convert the dt binding for the da9063/da9063l to yaml.
>
> Signed-off-by: Conor Dooley <conor.dooley@microchip.com>
> ---
> .../devicetree/bindings/mfd/da9063.txt | 111 ----------------
> .../devicetree/bindings/mfd/da9063.yaml | 123 ++++++++++++++++++
> .../devicetree/bindings/trivial-devices.yaml | 2 -
> 3 files changed, 123 insertions(+), 113 deletions(-)
> delete mode 100644 Documentation/devicetree/bindings/mfd/da9063.txt
> create mode 100644 Documentation/devicetree/bindings/mfd/da9063.yaml
>
> diff --git a/Documentation/devicetree/bindings/mfd/da9063.txt b/Documentation/devicetree/bindings/mfd/da9063.txt
> deleted file mode 100644
> index 91b79a21d403..000000000000
> --- a/Documentation/devicetree/bindings/mfd/da9063.txt
> +++ /dev/null
> @@ -1,111 +0,0 @@
> -* Dialog DA9063/DA9063L Power Management Integrated Circuit (PMIC)
> -
> -DA9063 consists of a large and varied group of sub-devices (I2C Only):
> -
> -Device Supply Names Description
> ------- ------------ -----------
> -da9063-regulator : : LDOs & BUCKs
> -da9063-onkey : : On Key
> -da9063-rtc : : Real-Time Clock (DA9063 only)
> -da9063-watchdog : : Watchdog
> -
> -======
> -
> -Required properties:
> -
> -- compatible : Should be "dlg,da9063" or "dlg,da9063l"
> -- reg : Specifies the I2C slave address (this defaults to 0x58 but it can be
> - modified to match the chip's OTP settings).
> -- interrupts : IRQ line information.
> -- interrupt-controller
> -
> -Sub-nodes:
> -
> -- regulators : This node defines the settings for the LDOs and BUCKs.
> - The DA9063(L) regulators are bound using their names listed below:
> -
> - bcore1 : BUCK CORE1
> - bcore2 : BUCK CORE2
> - bpro : BUCK PRO
> - bmem : BUCK MEM
> - bio : BUCK IO
> - bperi : BUCK PERI
> - ldo1 : LDO_1 (DA9063 only)
> - ldo2 : LDO_2 (DA9063 only)
> - ldo3 : LDO_3
> - ldo4 : LDO_4 (DA9063 only)
> - ldo5 : LDO_5 (DA9063 only)
> - ldo6 : LDO_6 (DA9063 only)
> - ldo7 : LDO_7
> - ldo8 : LDO_8
> - ldo9 : LDO_9
> - ldo10 : LDO_10 (DA9063 only)
> - ldo11 : LDO_11
> -
> - The component follows the standard regulator framework and the bindings
> - details of individual regulator device can be found in:
> - Documentation/devicetree/bindings/regulator/regulator.txt
> -
> -- rtc : This node defines settings for the Real-Time Clock associated with
> - the DA9063 only. The RTC is not present in DA9063L. There are currently
> - no entries in this binding, however compatible = "dlg,da9063-rtc" should
> - be added if a node is created.
> -
> -- onkey : This node defines the OnKey settings for controlling the key
> - functionality of the device. The node should contain the compatible property
> - with the value "dlg,da9063-onkey".
> -
> - Optional onkey properties:
> -
> - - dlg,disable-key-power : Disable power-down using a long key-press. If this
> - entry exists the OnKey driver will remove support for the KEY_POWER key
> - press. If this entry does not exist then by default the key-press
> - triggered power down is enabled and the OnKey will support both KEY_POWER
> - and KEY_SLEEP.
> -
> -- watchdog : This node defines settings for the Watchdog timer associated
> - with the DA9063 and DA9063L. There are currently no entries in this
> - binding, however compatible = "dlg,da9063-watchdog" should be added
> - if a node is created.
> -
> -
> -Example:
> -
> - pmic0: da9063@58 {
> - compatible = "dlg,da9063"
> - reg = <0x58>;
> - interrupt-parent = <&gpio6>;
> - interrupts = <11 IRQ_TYPE_LEVEL_LOW>;
> - interrupt-controller;
> -
> - rtc {
> - compatible = "dlg,da9063-rtc";
> - };
> -
> - wdt {
> - compatible = "dlg,da9063-watchdog";
> - };
> -
> - onkey {
> - compatible = "dlg,da9063-onkey";
> - dlg,disable-key-power;
> - };
> -
> - regulators {
> - DA9063_BCORE1: bcore1 {
> - regulator-name = "BCORE1";
> - regulator-min-microvolt = <300000>;
> - regulator-max-microvolt = <1570000>;
> - regulator-min-microamp = <500000>;
> - regulator-max-microamp = <2000000>;
> - regulator-boot-on;
> - };
> - DA9063_LDO11: ldo11 {
> - regulator-name = "LDO_11";
> - regulator-min-microvolt = <900000>;
> - regulator-max-microvolt = <3600000>;
> - regulator-boot-on;
> - };
> - };
> - };
> -
> diff --git a/Documentation/devicetree/bindings/mfd/da9063.yaml b/Documentation/devicetree/bindings/mfd/da9063.yaml
> new file mode 100644
> index 000000000000..376880061f42
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/mfd/da9063.yaml
dlg,da9063.yaml
> @@ -0,0 +1,123 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/mfd/da9063.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Dialog DA9063/DA9063L Power Management Integrated Circuit (PMIC)
> +
> +maintainers:
> + - Steve Twiss <stwiss.opensource@diasemi.com>
> +
> +description: |
> + For device-tree bindings of other sub-modules refer to the binding documents
> + under the respective sub-system directories.
> +
> +properties:
> + compatible:
> + enum:
> + - dlg,da9063
> + - dlg,da9063l
> +
> + reg:
> + description:
> + I2C device address.
Skip description.
> + maxItems: 1
> +
> + interrupts:
> + maxItems: 1
> +
> + interrupt-controller: true
> +
> + "#interrupt-cells":
> + const: 2
> +
> + watchdog:
> + type: object
> + $ref: ../watchdog/watchdog.yaml#
1. full reference, so /schemas/watchdog/....
2. unevaluatedProperties:false
> + properties:
> + compatible:
> + const: dlg,da9063-watchdog
> +
> + rtc:
> + type: object
> + $ref: ../rtc/rtc.yaml#
Ditto
> + properties:
> + compatible:
> + const: dlg,da9063-rtc
> +
> + onkey:
> + type: object
> + $ref: ../input/input.yaml#
Ditto
> + properties:
> + compatible:
> + const: dlg,da9063-onkey
> +
> + dlg,disable-key-power:
> + type: boolean
> + description: |
> + Disable power-down using a long key-press.
> + If this entry does not exist then by default the key-press triggered
> + power down is enabled and the OnKey will support both KEY_POWER and
> + KEY_SLEEP.
> +
> + regulators:
> + type: object
> + patternProperties:
> + "^(ldo[1-11]|bcore[1-2]|bpro|bmem|bio|bperi)$":
> + $ref: ../regulator/regulator.yaml
Ditto
> +
> +required:
> + - compatible
> + - reg
> + - interrupts
> + - interrupt-controller
> +
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 34+ messages in thread* Re: [PATCH v1 4/6] dt-bindings: mfd: convert da9063 to yaml
@ 2022-06-06 13:11 ` Krzysztof Kozlowski
0 siblings, 0 replies; 34+ messages in thread
From: Krzysztof Kozlowski @ 2022-06-06 13:11 UTC (permalink / raw)
To: mail, Rob Herring, Krzysztof Kozlowski, Andrew Lunn,
Support Opensource, Lee Jones, Ulf Hansson, Palmer Dabbelt,
Paul Walmsley, Albert Ou, Steve Twiss
Cc: Conor Dooley, linux-i2c, devicetree, linux-kernel, linux-mmc,
linux-riscv, Atul Khare
On 05/06/2022 15:32, mail@conchuod.ie wrote:
> From: Conor Dooley <conor.dooley@microchip.com>
>
> Convert the dt binding for the da9063/da9063l to yaml.
>
> Signed-off-by: Conor Dooley <conor.dooley@microchip.com>
> ---
> .../devicetree/bindings/mfd/da9063.txt | 111 ----------------
> .../devicetree/bindings/mfd/da9063.yaml | 123 ++++++++++++++++++
> .../devicetree/bindings/trivial-devices.yaml | 2 -
> 3 files changed, 123 insertions(+), 113 deletions(-)
> delete mode 100644 Documentation/devicetree/bindings/mfd/da9063.txt
> create mode 100644 Documentation/devicetree/bindings/mfd/da9063.yaml
>
> diff --git a/Documentation/devicetree/bindings/mfd/da9063.txt b/Documentation/devicetree/bindings/mfd/da9063.txt
> deleted file mode 100644
> index 91b79a21d403..000000000000
> --- a/Documentation/devicetree/bindings/mfd/da9063.txt
> +++ /dev/null
> @@ -1,111 +0,0 @@
> -* Dialog DA9063/DA9063L Power Management Integrated Circuit (PMIC)
> -
> -DA9063 consists of a large and varied group of sub-devices (I2C Only):
> -
> -Device Supply Names Description
> ------- ------------ -----------
> -da9063-regulator : : LDOs & BUCKs
> -da9063-onkey : : On Key
> -da9063-rtc : : Real-Time Clock (DA9063 only)
> -da9063-watchdog : : Watchdog
> -
> -======
> -
> -Required properties:
> -
> -- compatible : Should be "dlg,da9063" or "dlg,da9063l"
> -- reg : Specifies the I2C slave address (this defaults to 0x58 but it can be
> - modified to match the chip's OTP settings).
> -- interrupts : IRQ line information.
> -- interrupt-controller
> -
> -Sub-nodes:
> -
> -- regulators : This node defines the settings for the LDOs and BUCKs.
> - The DA9063(L) regulators are bound using their names listed below:
> -
> - bcore1 : BUCK CORE1
> - bcore2 : BUCK CORE2
> - bpro : BUCK PRO
> - bmem : BUCK MEM
> - bio : BUCK IO
> - bperi : BUCK PERI
> - ldo1 : LDO_1 (DA9063 only)
> - ldo2 : LDO_2 (DA9063 only)
> - ldo3 : LDO_3
> - ldo4 : LDO_4 (DA9063 only)
> - ldo5 : LDO_5 (DA9063 only)
> - ldo6 : LDO_6 (DA9063 only)
> - ldo7 : LDO_7
> - ldo8 : LDO_8
> - ldo9 : LDO_9
> - ldo10 : LDO_10 (DA9063 only)
> - ldo11 : LDO_11
> -
> - The component follows the standard regulator framework and the bindings
> - details of individual regulator device can be found in:
> - Documentation/devicetree/bindings/regulator/regulator.txt
> -
> -- rtc : This node defines settings for the Real-Time Clock associated with
> - the DA9063 only. The RTC is not present in DA9063L. There are currently
> - no entries in this binding, however compatible = "dlg,da9063-rtc" should
> - be added if a node is created.
> -
> -- onkey : This node defines the OnKey settings for controlling the key
> - functionality of the device. The node should contain the compatible property
> - with the value "dlg,da9063-onkey".
> -
> - Optional onkey properties:
> -
> - - dlg,disable-key-power : Disable power-down using a long key-press. If this
> - entry exists the OnKey driver will remove support for the KEY_POWER key
> - press. If this entry does not exist then by default the key-press
> - triggered power down is enabled and the OnKey will support both KEY_POWER
> - and KEY_SLEEP.
> -
> -- watchdog : This node defines settings for the Watchdog timer associated
> - with the DA9063 and DA9063L. There are currently no entries in this
> - binding, however compatible = "dlg,da9063-watchdog" should be added
> - if a node is created.
> -
> -
> -Example:
> -
> - pmic0: da9063@58 {
> - compatible = "dlg,da9063"
> - reg = <0x58>;
> - interrupt-parent = <&gpio6>;
> - interrupts = <11 IRQ_TYPE_LEVEL_LOW>;
> - interrupt-controller;
> -
> - rtc {
> - compatible = "dlg,da9063-rtc";
> - };
> -
> - wdt {
> - compatible = "dlg,da9063-watchdog";
> - };
> -
> - onkey {
> - compatible = "dlg,da9063-onkey";
> - dlg,disable-key-power;
> - };
> -
> - regulators {
> - DA9063_BCORE1: bcore1 {
> - regulator-name = "BCORE1";
> - regulator-min-microvolt = <300000>;
> - regulator-max-microvolt = <1570000>;
> - regulator-min-microamp = <500000>;
> - regulator-max-microamp = <2000000>;
> - regulator-boot-on;
> - };
> - DA9063_LDO11: ldo11 {
> - regulator-name = "LDO_11";
> - regulator-min-microvolt = <900000>;
> - regulator-max-microvolt = <3600000>;
> - regulator-boot-on;
> - };
> - };
> - };
> -
> diff --git a/Documentation/devicetree/bindings/mfd/da9063.yaml b/Documentation/devicetree/bindings/mfd/da9063.yaml
> new file mode 100644
> index 000000000000..376880061f42
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/mfd/da9063.yaml
dlg,da9063.yaml
> @@ -0,0 +1,123 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/mfd/da9063.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Dialog DA9063/DA9063L Power Management Integrated Circuit (PMIC)
> +
> +maintainers:
> + - Steve Twiss <stwiss.opensource@diasemi.com>
> +
> +description: |
> + For device-tree bindings of other sub-modules refer to the binding documents
> + under the respective sub-system directories.
> +
> +properties:
> + compatible:
> + enum:
> + - dlg,da9063
> + - dlg,da9063l
> +
> + reg:
> + description:
> + I2C device address.
Skip description.
> + maxItems: 1
> +
> + interrupts:
> + maxItems: 1
> +
> + interrupt-controller: true
> +
> + "#interrupt-cells":
> + const: 2
> +
> + watchdog:
> + type: object
> + $ref: ../watchdog/watchdog.yaml#
1. full reference, so /schemas/watchdog/....
2. unevaluatedProperties:false
> + properties:
> + compatible:
> + const: dlg,da9063-watchdog
> +
> + rtc:
> + type: object
> + $ref: ../rtc/rtc.yaml#
Ditto
> + properties:
> + compatible:
> + const: dlg,da9063-rtc
> +
> + onkey:
> + type: object
> + $ref: ../input/input.yaml#
Ditto
> + properties:
> + compatible:
> + const: dlg,da9063-onkey
> +
> + dlg,disable-key-power:
> + type: boolean
> + description: |
> + Disable power-down using a long key-press.
> + If this entry does not exist then by default the key-press triggered
> + power down is enabled and the OnKey will support both KEY_POWER and
> + KEY_SLEEP.
> +
> + regulators:
> + type: object
> + patternProperties:
> + "^(ldo[1-11]|bcore[1-2]|bpro|bmem|bio|bperi)$":
> + $ref: ../regulator/regulator.yaml
Ditto
> +
> +required:
> + - compatible
> + - reg
> + - interrupts
> + - interrupt-controller
> +
Best regards,
Krzysztof
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
^ permalink raw reply [flat|nested] 34+ messages in thread
* [PATCH v1 5/6] MAINTAINERS: convert da9063 to yaml
2022-06-05 13:32 ` mail
@ 2022-06-05 13:33 ` mail
-1 siblings, 0 replies; 34+ messages in thread
From: mail @ 2022-06-05 13:33 UTC (permalink / raw)
To: Rob Herring, Krzysztof Kozlowski, Andrew Lunn,
Support Opensource, Lee Jones, Ulf Hansson, Palmer Dabbelt,
Paul Walmsley, Albert Ou, Steve Twiss
Cc: Conor Dooley, linux-i2c, devicetree, linux-kernel, linux-mmc,
linux-riscv, Atul Khare
From: Conor Dooley <conor.dooley@microchip.com>
As the da9063 dt-binding has been converted to yaml, update the
maintainers entry for it.
Signed-off-by: Conor Dooley <conor.dooley@microchip.com>
---
MAINTAINERS | 1 +
1 file changed, 1 insertion(+)
diff --git a/MAINTAINERS b/MAINTAINERS
index f799cf34ea52..8e51bc154584 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -5805,6 +5805,7 @@ W: http://www.dialog-semiconductor.com/products
F: Documentation/devicetree/bindings/input/da90??-onkey.txt
F: Documentation/devicetree/bindings/input/dlg,da72??.txt
F: Documentation/devicetree/bindings/mfd/da90*.txt
+F: Documentation/devicetree/bindings/mfd/da90*.yaml
F: Documentation/devicetree/bindings/regulator/dlg,da9*.yaml
F: Documentation/devicetree/bindings/regulator/da92*.txt
F: Documentation/devicetree/bindings/regulator/slg51000.txt
--
2.36.1
^ permalink raw reply related [flat|nested] 34+ messages in thread
* [PATCH v1 5/6] MAINTAINERS: convert da9063 to yaml
@ 2022-06-05 13:33 ` mail
0 siblings, 0 replies; 34+ messages in thread
From: mail @ 2022-06-05 13:33 UTC (permalink / raw)
To: Rob Herring, Krzysztof Kozlowski, Andrew Lunn,
Support Opensource, Lee Jones, Ulf Hansson, Palmer Dabbelt,
Paul Walmsley, Albert Ou, Steve Twiss
Cc: Conor Dooley, linux-i2c, devicetree, linux-kernel, linux-mmc,
linux-riscv, Atul Khare
From: Conor Dooley <conor.dooley@microchip.com>
As the da9063 dt-binding has been converted to yaml, update the
maintainers entry for it.
Signed-off-by: Conor Dooley <conor.dooley@microchip.com>
---
MAINTAINERS | 1 +
1 file changed, 1 insertion(+)
diff --git a/MAINTAINERS b/MAINTAINERS
index f799cf34ea52..8e51bc154584 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -5805,6 +5805,7 @@ W: http://www.dialog-semiconductor.com/products
F: Documentation/devicetree/bindings/input/da90??-onkey.txt
F: Documentation/devicetree/bindings/input/dlg,da72??.txt
F: Documentation/devicetree/bindings/mfd/da90*.txt
+F: Documentation/devicetree/bindings/mfd/da90*.yaml
F: Documentation/devicetree/bindings/regulator/dlg,da9*.yaml
F: Documentation/devicetree/bindings/regulator/da92*.txt
F: Documentation/devicetree/bindings/regulator/slg51000.txt
--
2.36.1
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
^ permalink raw reply related [flat|nested] 34+ messages in thread
* [PATCH v1 6/6] riscv: dts: sifive: "fix" pmic watchdog node name
2022-06-05 13:32 ` mail
@ 2022-06-05 13:33 ` mail
-1 siblings, 0 replies; 34+ messages in thread
From: mail @ 2022-06-05 13:33 UTC (permalink / raw)
To: Rob Herring, Krzysztof Kozlowski, Andrew Lunn,
Support Opensource, Lee Jones, Ulf Hansson, Palmer Dabbelt,
Paul Walmsley, Albert Ou, Steve Twiss
Cc: Conor Dooley, linux-i2c, devicetree, linux-kernel, linux-mmc,
linux-riscv, Atul Khare
From: Conor Dooley <conor.dooley@microchip.com>
After converting the pmic watchdog binding to yaml, dtbs_check complains
that the node name doesn't match the binding. "Fix" it.
Signed-off-by: Conor Dooley <conor.dooley@microchip.com>
---
arch/riscv/boot/dts/sifive/hifive-unmatched-a00.dts | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/riscv/boot/dts/sifive/hifive-unmatched-a00.dts b/arch/riscv/boot/dts/sifive/hifive-unmatched-a00.dts
index c4ed9efdff03..1f386b07a832 100644
--- a/arch/riscv/boot/dts/sifive/hifive-unmatched-a00.dts
+++ b/arch/riscv/boot/dts/sifive/hifive-unmatched-a00.dts
@@ -90,7 +90,7 @@ rtc {
compatible = "dlg,da9063-rtc";
};
- wdt {
+ watchdog {
compatible = "dlg,da9063-watchdog";
};
--
2.36.1
^ permalink raw reply related [flat|nested] 34+ messages in thread* [PATCH v1 6/6] riscv: dts: sifive: "fix" pmic watchdog node name
@ 2022-06-05 13:33 ` mail
0 siblings, 0 replies; 34+ messages in thread
From: mail @ 2022-06-05 13:33 UTC (permalink / raw)
To: Rob Herring, Krzysztof Kozlowski, Andrew Lunn,
Support Opensource, Lee Jones, Ulf Hansson, Palmer Dabbelt,
Paul Walmsley, Albert Ou, Steve Twiss
Cc: Conor Dooley, linux-i2c, devicetree, linux-kernel, linux-mmc,
linux-riscv, Atul Khare
From: Conor Dooley <conor.dooley@microchip.com>
After converting the pmic watchdog binding to yaml, dtbs_check complains
that the node name doesn't match the binding. "Fix" it.
Signed-off-by: Conor Dooley <conor.dooley@microchip.com>
---
arch/riscv/boot/dts/sifive/hifive-unmatched-a00.dts | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/riscv/boot/dts/sifive/hifive-unmatched-a00.dts b/arch/riscv/boot/dts/sifive/hifive-unmatched-a00.dts
index c4ed9efdff03..1f386b07a832 100644
--- a/arch/riscv/boot/dts/sifive/hifive-unmatched-a00.dts
+++ b/arch/riscv/boot/dts/sifive/hifive-unmatched-a00.dts
@@ -90,7 +90,7 @@ rtc {
compatible = "dlg,da9063-rtc";
};
- wdt {
+ watchdog {
compatible = "dlg,da9063-watchdog";
};
--
2.36.1
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
^ permalink raw reply related [flat|nested] 34+ messages in thread* Re: [PATCH v1 6/6] riscv: dts: sifive: "fix" pmic watchdog node name
2022-06-05 13:33 ` mail
@ 2022-06-06 8:07 ` Krzysztof Kozlowski
-1 siblings, 0 replies; 34+ messages in thread
From: Krzysztof Kozlowski @ 2022-06-06 8:07 UTC (permalink / raw)
To: mail, Rob Herring, Krzysztof Kozlowski, Andrew Lunn,
Support Opensource, Lee Jones, Ulf Hansson, Palmer Dabbelt,
Paul Walmsley, Albert Ou, Steve Twiss
Cc: Conor Dooley, linux-i2c, devicetree, linux-kernel, linux-mmc,
linux-riscv, Atul Khare
On 05/06/2022 15:33, mail@conchuod.ie wrote:
> From: Conor Dooley <conor.dooley@microchip.com>
>
> After converting the pmic watchdog binding to yaml, dtbs_check complains
> that the node name doesn't match the binding. "Fix" it.
>
> Signed-off-by: Conor Dooley <conor.dooley@microchip.com>
> ---
> arch/riscv/boot/dts/sifive/hifive-unmatched-a00.dts | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 34+ messages in thread
* Re: [PATCH v1 6/6] riscv: dts: sifive: "fix" pmic watchdog node name
@ 2022-06-06 8:07 ` Krzysztof Kozlowski
0 siblings, 0 replies; 34+ messages in thread
From: Krzysztof Kozlowski @ 2022-06-06 8:07 UTC (permalink / raw)
To: mail, Rob Herring, Krzysztof Kozlowski, Andrew Lunn,
Support Opensource, Lee Jones, Ulf Hansson, Palmer Dabbelt,
Paul Walmsley, Albert Ou, Steve Twiss
Cc: Conor Dooley, linux-i2c, devicetree, linux-kernel, linux-mmc,
linux-riscv, Atul Khare
On 05/06/2022 15:33, mail@conchuod.ie wrote:
> From: Conor Dooley <conor.dooley@microchip.com>
>
> After converting the pmic watchdog binding to yaml, dtbs_check complains
> that the node name doesn't match the binding. "Fix" it.
>
> Signed-off-by: Conor Dooley <conor.dooley@microchip.com>
> ---
> arch/riscv/boot/dts/sifive/hifive-unmatched-a00.dts | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Best regards,
Krzysztof
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
^ permalink raw reply [flat|nested] 34+ messages in thread
* Re: [PATCH v1 0/6] clear riscv dtbs_check errors
2022-06-05 13:32 ` mail
@ 2022-06-06 7:34 ` Krzysztof Kozlowski
-1 siblings, 0 replies; 34+ messages in thread
From: Krzysztof Kozlowski @ 2022-06-06 7:34 UTC (permalink / raw)
To: mail, Rob Herring, Krzysztof Kozlowski, Andrew Lunn,
Support Opensource, Lee Jones, Ulf Hansson, Palmer Dabbelt,
Paul Walmsley, Albert Ou, Steve Twiss
Cc: Conor Dooley, linux-i2c, devicetree, linux-kernel, linux-mmc,
linux-riscv, Atul Khare
On 05/06/2022 15:32, mail@conchuod.ie wrote:
> From: Conor Dooley <conor.dooley@microchip.com>
>
> Hey,
> Couple conversions from txt to yaml here with the intent of fixing the
> the dtbs_check warnings for riscv. Atul Khare already sent patches for
> the gpio-line-names & cache-sets (which went awol) and will clear the
> remaining two errors.
>
> Rob/Krzysztof:
> Have I correctly expressed the mutually exclusive properties?
> I had a look around, but wasn't able to find an obvious binding to ape.
I'll take a look.
>
> Wasn't sure if a txt -> yaml conversion's MAINTAINERS update was meant
> to be in the same patch or not, so feel free to squash.
It's the same patch, so please squash with next release.
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 34+ messages in thread
* Re: [PATCH v1 0/6] clear riscv dtbs_check errors
@ 2022-06-06 7:34 ` Krzysztof Kozlowski
0 siblings, 0 replies; 34+ messages in thread
From: Krzysztof Kozlowski @ 2022-06-06 7:34 UTC (permalink / raw)
To: mail, Rob Herring, Krzysztof Kozlowski, Andrew Lunn,
Support Opensource, Lee Jones, Ulf Hansson, Palmer Dabbelt,
Paul Walmsley, Albert Ou, Steve Twiss
Cc: Conor Dooley, linux-i2c, devicetree, linux-kernel, linux-mmc,
linux-riscv, Atul Khare
On 05/06/2022 15:32, mail@conchuod.ie wrote:
> From: Conor Dooley <conor.dooley@microchip.com>
>
> Hey,
> Couple conversions from txt to yaml here with the intent of fixing the
> the dtbs_check warnings for riscv. Atul Khare already sent patches for
> the gpio-line-names & cache-sets (which went awol) and will clear the
> remaining two errors.
>
> Rob/Krzysztof:
> Have I correctly expressed the mutually exclusive properties?
> I had a look around, but wasn't able to find an obvious binding to ape.
I'll take a look.
>
> Wasn't sure if a txt -> yaml conversion's MAINTAINERS update was meant
> to be in the same patch or not, so feel free to squash.
It's the same patch, so please squash with next release.
Best regards,
Krzysztof
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
^ permalink raw reply [flat|nested] 34+ messages in thread
* Re: [PATCH v1 0/6] clear riscv dtbs_check errors
2022-06-06 7:34 ` Krzysztof Kozlowski
@ 2022-06-06 8:56 ` Conor.Dooley
-1 siblings, 0 replies; 34+ messages in thread
From: Conor.Dooley @ 2022-06-06 8:56 UTC (permalink / raw)
To: krzysztof.kozlowski, mail, robh+dt, krzysztof.kozlowski+dt,
andrew, support.opensource, lee.jones, ulf.hansson, palmer,
paul.walmsley, aou, stwiss.opensource
Cc: linux-i2c, devicetree, linux-kernel, linux-mmc, linux-riscv, atulkhare
On 06/06/2022 08:34, Krzysztof Kozlowski wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
>
> On 05/06/2022 15:32, mail@conchuod.ie wrote:
>> From: Conor Dooley <conor.dooley@microchip.com>
>>
>> Hey,
>> Couple conversions from txt to yaml here with the intent of fixing the
>> the dtbs_check warnings for riscv. Atul Khare already sent patches for
>> the gpio-line-names & cache-sets (which went awol) and will clear the
>> remaining two errors.
>>
>> Rob/Krzysztof:
>> Have I correctly expressed the mutually exclusive properties?
>> I had a look around, but wasn't able to find an obvious binding to ape.
>
> I'll take a look.
As always, thanks for your feedback Krzysztof.
>
>>
>> Wasn't sure if a txt -> yaml conversion's MAINTAINERS update was meant
>> to be in the same patch or not, so feel free to squash.
>
> It's the same patch, so please squash with next release.
Sure, willdo for v2.
Thanks,
Conor.
^ permalink raw reply [flat|nested] 34+ messages in thread
* Re: [PATCH v1 0/6] clear riscv dtbs_check errors
@ 2022-06-06 8:56 ` Conor.Dooley
0 siblings, 0 replies; 34+ messages in thread
From: Conor.Dooley @ 2022-06-06 8:56 UTC (permalink / raw)
To: krzysztof.kozlowski, mail, robh+dt, krzysztof.kozlowski+dt,
andrew, support.opensource, lee.jones, ulf.hansson, palmer,
paul.walmsley, aou, stwiss.opensource
Cc: linux-i2c, devicetree, linux-kernel, linux-mmc, linux-riscv, atulkhare
On 06/06/2022 08:34, Krzysztof Kozlowski wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
>
> On 05/06/2022 15:32, mail@conchuod.ie wrote:
>> From: Conor Dooley <conor.dooley@microchip.com>
>>
>> Hey,
>> Couple conversions from txt to yaml here with the intent of fixing the
>> the dtbs_check warnings for riscv. Atul Khare already sent patches for
>> the gpio-line-names & cache-sets (which went awol) and will clear the
>> remaining two errors.
>>
>> Rob/Krzysztof:
>> Have I correctly expressed the mutually exclusive properties?
>> I had a look around, but wasn't able to find an obvious binding to ape.
>
> I'll take a look.
As always, thanks for your feedback Krzysztof.
>
>>
>> Wasn't sure if a txt -> yaml conversion's MAINTAINERS update was meant
>> to be in the same patch or not, so feel free to squash.
>
> It's the same patch, so please squash with next release.
Sure, willdo for v2.
Thanks,
Conor.
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
^ permalink raw reply [flat|nested] 34+ messages in thread
* Re: [PATCH v1 0/6] clear riscv dtbs_check errors
2022-06-05 13:32 ` mail
@ 2022-06-08 22:27 ` Atul Khare
-1 siblings, 0 replies; 34+ messages in thread
From: Atul Khare @ 2022-06-08 22:27 UTC (permalink / raw)
To: mail
Cc: Rob Herring, Krzysztof Kozlowski, Andrew Lunn,
Support Opensource, Lee Jones, Ulf Hansson, Palmer Dabbelt,
Paul Walmsley, Albert Ou, Steve Twiss, Conor Dooley, linux-i2c,
devicetree, linux-kernel, linux-mmc, linux-riscv
Conor,
Thanks for the feedback. I will rebase and send out a v2 series
shortly (it appears that the 1024 hart context patch is redundant as
well).
On Sun, Jun 5, 2022 at 6:33 AM <mail@conchuod.ie> wrote:
>
> From: Conor Dooley <conor.dooley@microchip.com>
>
> Hey,
> Couple conversions from txt to yaml here with the intent of fixing the
> the dtbs_check warnings for riscv. Atul Khare already sent patches for
> the gpio-line-names & cache-sets (which went awol) and will clear the
> remaining two errors.
>
> Rob/Krzysztof:
> Have I correctly expressed the mutually exclusive properties?
> I had a look around, but wasn't able to find an obvious binding to ape.
>
> Wasn't sure if a txt -> yaml conversion's MAINTAINERS update was meant
> to be in the same patch or not, so feel free to squash.
> Thanks,
> Conor.
>
> Conor Dooley (6):
> dt-bindings: mmc: convert mmc-spi-slot to yaml
> dt-bindings: i2c: convert ocores binding to yaml
> MAINTAINERS: convert ocores i2c dt-binding to yaml
> dt-bindings: mfd: convert da9063 to yaml
> MAINTAINERS: convert da9063 to yaml
> riscv: dts: sifive: "fix" pmic watchdog node name
>
> .../devicetree/bindings/i2c/i2c-ocores.txt | 78 -----------
> .../devicetree/bindings/i2c/i2c-ocores.yaml | 132 ++++++++++++++++++
> .../devicetree/bindings/mfd/da9063.txt | 111 ---------------
> .../devicetree/bindings/mfd/da9063.yaml | 123 ++++++++++++++++
> .../devicetree/bindings/mmc/mmc-spi-slot.txt | 29 ----
> .../devicetree/bindings/mmc/mmc-spi-slot.yaml | 76 ++++++++++
> .../devicetree/bindings/trivial-devices.yaml | 2 -
> MAINTAINERS | 3 +-
> .../boot/dts/sifive/hifive-unmatched-a00.dts | 2 +-
> 9 files changed, 334 insertions(+), 222 deletions(-)
> delete mode 100644 Documentation/devicetree/bindings/i2c/i2c-ocores.txt
> create mode 100644 Documentation/devicetree/bindings/i2c/i2c-ocores.yaml
> delete mode 100644 Documentation/devicetree/bindings/mfd/da9063.txt
> create mode 100644 Documentation/devicetree/bindings/mfd/da9063.yaml
> delete mode 100644 Documentation/devicetree/bindings/mmc/mmc-spi-slot.txt
> create mode 100644 Documentation/devicetree/bindings/mmc/mmc-spi-slot.yaml
>
> --
> 2.36.1
>
^ permalink raw reply [flat|nested] 34+ messages in thread
* Re: [PATCH v1 0/6] clear riscv dtbs_check errors
@ 2022-06-08 22:27 ` Atul Khare
0 siblings, 0 replies; 34+ messages in thread
From: Atul Khare @ 2022-06-08 22:27 UTC (permalink / raw)
To: mail
Cc: Rob Herring, Krzysztof Kozlowski, Andrew Lunn,
Support Opensource, Lee Jones, Ulf Hansson, Palmer Dabbelt,
Paul Walmsley, Albert Ou, Steve Twiss, Conor Dooley, linux-i2c,
devicetree, linux-kernel, linux-mmc, linux-riscv
Conor,
Thanks for the feedback. I will rebase and send out a v2 series
shortly (it appears that the 1024 hart context patch is redundant as
well).
On Sun, Jun 5, 2022 at 6:33 AM <mail@conchuod.ie> wrote:
>
> From: Conor Dooley <conor.dooley@microchip.com>
>
> Hey,
> Couple conversions from txt to yaml here with the intent of fixing the
> the dtbs_check warnings for riscv. Atul Khare already sent patches for
> the gpio-line-names & cache-sets (which went awol) and will clear the
> remaining two errors.
>
> Rob/Krzysztof:
> Have I correctly expressed the mutually exclusive properties?
> I had a look around, but wasn't able to find an obvious binding to ape.
>
> Wasn't sure if a txt -> yaml conversion's MAINTAINERS update was meant
> to be in the same patch or not, so feel free to squash.
> Thanks,
> Conor.
>
> Conor Dooley (6):
> dt-bindings: mmc: convert mmc-spi-slot to yaml
> dt-bindings: i2c: convert ocores binding to yaml
> MAINTAINERS: convert ocores i2c dt-binding to yaml
> dt-bindings: mfd: convert da9063 to yaml
> MAINTAINERS: convert da9063 to yaml
> riscv: dts: sifive: "fix" pmic watchdog node name
>
> .../devicetree/bindings/i2c/i2c-ocores.txt | 78 -----------
> .../devicetree/bindings/i2c/i2c-ocores.yaml | 132 ++++++++++++++++++
> .../devicetree/bindings/mfd/da9063.txt | 111 ---------------
> .../devicetree/bindings/mfd/da9063.yaml | 123 ++++++++++++++++
> .../devicetree/bindings/mmc/mmc-spi-slot.txt | 29 ----
> .../devicetree/bindings/mmc/mmc-spi-slot.yaml | 76 ++++++++++
> .../devicetree/bindings/trivial-devices.yaml | 2 -
> MAINTAINERS | 3 +-
> .../boot/dts/sifive/hifive-unmatched-a00.dts | 2 +-
> 9 files changed, 334 insertions(+), 222 deletions(-)
> delete mode 100644 Documentation/devicetree/bindings/i2c/i2c-ocores.txt
> create mode 100644 Documentation/devicetree/bindings/i2c/i2c-ocores.yaml
> delete mode 100644 Documentation/devicetree/bindings/mfd/da9063.txt
> create mode 100644 Documentation/devicetree/bindings/mfd/da9063.yaml
> delete mode 100644 Documentation/devicetree/bindings/mmc/mmc-spi-slot.txt
> create mode 100644 Documentation/devicetree/bindings/mmc/mmc-spi-slot.yaml
>
> --
> 2.36.1
>
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
^ permalink raw reply [flat|nested] 34+ messages in thread
* Re: [PATCH v1 0/6] clear riscv dtbs_check errors
2022-06-08 22:27 ` Atul Khare
@ 2022-06-08 22:42 ` Conor Dooley
-1 siblings, 0 replies; 34+ messages in thread
From: Conor Dooley @ 2022-06-08 22:42 UTC (permalink / raw)
To: Atul Khare
Cc: Rob Herring, Krzysztof Kozlowski, Andrew Lunn,
Support Opensource, Lee Jones, Ulf Hansson, Palmer Dabbelt,
Paul Walmsley, Albert Ou, Steve Twiss, Conor Dooley, linux-i2c,
devicetree, linux-kernel, linux-mmc, linux-riscv
On 08/06/2022 23:27, Atul Khare wrote:
> Conor,
>
> Thanks for the feedback. I will rebase and send out a v2 series
> shortly (it appears that the 1024 hart context patch is redundant as
> well).
Great, will be nice to get down to zero warnings :)
>
> On Sun, Jun 5, 2022 at 6:33 AM <mail@conchuod.ie> wrote:
>>
>> From: Conor Dooley <conor.dooley@microchip.com>
>>
>> Hey,
>> Couple conversions from txt to yaml here with the intent of fixing the
>> the dtbs_check warnings for riscv. Atul Khare already sent patches for
>> the gpio-line-names & cache-sets (which went awol) and will clear the
>> remaining two errors.
>>
>> Rob/Krzysztof:
>> Have I correctly expressed the mutually exclusive properties?
>> I had a look around, but wasn't able to find an obvious binding to ape.
>>
>> Wasn't sure if a txt -> yaml conversion's MAINTAINERS update was meant
>> to be in the same patch or not, so feel free to squash.
>> Thanks,
>> Conor.
>>
>> Conor Dooley (6):
>> dt-bindings: mmc: convert mmc-spi-slot to yaml
>> dt-bindings: i2c: convert ocores binding to yaml
>> MAINTAINERS: convert ocores i2c dt-binding to yaml
>> dt-bindings: mfd: convert da9063 to yaml
>> MAINTAINERS: convert da9063 to yaml
>> riscv: dts: sifive: "fix" pmic watchdog node name
>>
>> .../devicetree/bindings/i2c/i2c-ocores.txt | 78 -----------
>> .../devicetree/bindings/i2c/i2c-ocores.yaml | 132 ++++++++++++++++++
>> .../devicetree/bindings/mfd/da9063.txt | 111 ---------------
>> .../devicetree/bindings/mfd/da9063.yaml | 123 ++++++++++++++++
>> .../devicetree/bindings/mmc/mmc-spi-slot.txt | 29 ----
>> .../devicetree/bindings/mmc/mmc-spi-slot.yaml | 76 ++++++++++
>> .../devicetree/bindings/trivial-devices.yaml | 2 -
>> MAINTAINERS | 3 +-
>> .../boot/dts/sifive/hifive-unmatched-a00.dts | 2 +-
>> 9 files changed, 334 insertions(+), 222 deletions(-)
>> delete mode 100644 Documentation/devicetree/bindings/i2c/i2c-ocores.txt
>> create mode 100644 Documentation/devicetree/bindings/i2c/i2c-ocores.yaml
>> delete mode 100644 Documentation/devicetree/bindings/mfd/da9063.txt
>> create mode 100644 Documentation/devicetree/bindings/mfd/da9063.yaml
>> delete mode 100644 Documentation/devicetree/bindings/mmc/mmc-spi-slot.txt
>> create mode 100644 Documentation/devicetree/bindings/mmc/mmc-spi-slot.yaml
>>
>> --
>> 2.36.1
>>
^ permalink raw reply [flat|nested] 34+ messages in thread
* Re: [PATCH v1 0/6] clear riscv dtbs_check errors
@ 2022-06-08 22:42 ` Conor Dooley
0 siblings, 0 replies; 34+ messages in thread
From: Conor Dooley @ 2022-06-08 22:42 UTC (permalink / raw)
To: Atul Khare
Cc: Rob Herring, Krzysztof Kozlowski, Andrew Lunn,
Support Opensource, Lee Jones, Ulf Hansson, Palmer Dabbelt,
Paul Walmsley, Albert Ou, Steve Twiss, Conor Dooley, linux-i2c,
devicetree, linux-kernel, linux-mmc, linux-riscv
On 08/06/2022 23:27, Atul Khare wrote:
> Conor,
>
> Thanks for the feedback. I will rebase and send out a v2 series
> shortly (it appears that the 1024 hart context patch is redundant as
> well).
Great, will be nice to get down to zero warnings :)
>
> On Sun, Jun 5, 2022 at 6:33 AM <mail@conchuod.ie> wrote:
>>
>> From: Conor Dooley <conor.dooley@microchip.com>
>>
>> Hey,
>> Couple conversions from txt to yaml here with the intent of fixing the
>> the dtbs_check warnings for riscv. Atul Khare already sent patches for
>> the gpio-line-names & cache-sets (which went awol) and will clear the
>> remaining two errors.
>>
>> Rob/Krzysztof:
>> Have I correctly expressed the mutually exclusive properties?
>> I had a look around, but wasn't able to find an obvious binding to ape.
>>
>> Wasn't sure if a txt -> yaml conversion's MAINTAINERS update was meant
>> to be in the same patch or not, so feel free to squash.
>> Thanks,
>> Conor.
>>
>> Conor Dooley (6):
>> dt-bindings: mmc: convert mmc-spi-slot to yaml
>> dt-bindings: i2c: convert ocores binding to yaml
>> MAINTAINERS: convert ocores i2c dt-binding to yaml
>> dt-bindings: mfd: convert da9063 to yaml
>> MAINTAINERS: convert da9063 to yaml
>> riscv: dts: sifive: "fix" pmic watchdog node name
>>
>> .../devicetree/bindings/i2c/i2c-ocores.txt | 78 -----------
>> .../devicetree/bindings/i2c/i2c-ocores.yaml | 132 ++++++++++++++++++
>> .../devicetree/bindings/mfd/da9063.txt | 111 ---------------
>> .../devicetree/bindings/mfd/da9063.yaml | 123 ++++++++++++++++
>> .../devicetree/bindings/mmc/mmc-spi-slot.txt | 29 ----
>> .../devicetree/bindings/mmc/mmc-spi-slot.yaml | 76 ++++++++++
>> .../devicetree/bindings/trivial-devices.yaml | 2 -
>> MAINTAINERS | 3 +-
>> .../boot/dts/sifive/hifive-unmatched-a00.dts | 2 +-
>> 9 files changed, 334 insertions(+), 222 deletions(-)
>> delete mode 100644 Documentation/devicetree/bindings/i2c/i2c-ocores.txt
>> create mode 100644 Documentation/devicetree/bindings/i2c/i2c-ocores.yaml
>> delete mode 100644 Documentation/devicetree/bindings/mfd/da9063.txt
>> create mode 100644 Documentation/devicetree/bindings/mfd/da9063.yaml
>> delete mode 100644 Documentation/devicetree/bindings/mmc/mmc-spi-slot.txt
>> create mode 100644 Documentation/devicetree/bindings/mmc/mmc-spi-slot.yaml
>>
>> --
>> 2.36.1
>>
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
^ permalink raw reply [flat|nested] 34+ messages in thread