[Intel-gfx] [PATCH 1/2] drm/i915/display: Group DC9 mask set

[Intel-gfx] [PATCH 1/2] drm/i915/display: Group DC9 mask set

[José Roberto de Souza]

DC9 has a separate HW flow from the rest of the DC states and it is
available in GEN9 LP platforms and on GEN11 and newer, so here
moving the assignment of the mask to a single conditional block to
simplifly code.

Cc: Lucas De Marchi <lucas.demarchi@intel.com>
Cc: Anusha Srivatsa <anusha.srivatsa@intel.com>
Signed-off-by: José Roberto de Souza <jose.souza@intel.com>
---
 .../gpu/drm/i915/display/intel_display_power.c | 18 ++++++++----------
 1 file changed, 8 insertions(+), 10 deletions(-)

diff --git a/drivers/gpu/drm/i915/display/intel_display_power.c b/drivers/gpu/drm/i915/display/intel_display_power.c
index 689922480661..48d41a43fbb2 100644
--- a/drivers/gpu/drm/i915/display/intel_display_power.c
+++ b/drivers/gpu/drm/i915/display/intel_display_power.c
@@ -4497,26 +4497,24 @@ static u32 get_allowed_dc_mask(const struct drm_i915_private *dev_priv,
 			max_dc = 3;
 		else
 			max_dc = 4;
-		/*
-		 * DC9 has a separate HW flow from the rest of the DC states,
-		 * not depending on the DMC firmware. It's needed by system
-		 * suspend/resume, so allow it unconditionally.
-		 */
-		mask = DC_STATE_EN_DC9;
 	} else if (IS_GEN(dev_priv, 11)) {
 		max_dc = 2;
-		mask = DC_STATE_EN_DC9;
 	} else if (IS_GEN(dev_priv, 10) || IS_GEN9_BC(dev_priv)) {
 		max_dc = 2;
-		mask = 0;
 	} else if (IS_GEN9_LP(dev_priv)) {
 		max_dc = 1;
-		mask = DC_STATE_EN_DC9;
 	} else {
 		max_dc = 0;
-		mask = 0;
 	}
 
+	/*
+	 * DC9 has a separate HW flow from the rest of the DC states,
+	 * not depending on the DMC firmware. It's needed by system
+	 * suspend/resume, so allow it unconditionally.
+	 */
+	mask = IS_GEN9_LP(dev_priv) || INTEL_GEN(dev_priv) >= 11 ?
+	       DC_STATE_EN_DC9 : 0;
+
 	if (!dev_priv->params.disable_power_well)
 		max_dc = 0;
 
-- 
2.29.2

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

[Intel-gfx] [PATCH 2/2] drm/i915/display: Make get_allowed_dc_mask().max_dc set a chain of if and elses

[José Roberto de Souza]

Just following what we do in many other places, DG1 is a exception so
move it to the top instead of add it inside of INTEL_GEN(dev_priv) >= 12.

Cc: Lucas De Marchi <lucas.demarchi@intel.com>
Cc: Anusha Srivatsa <anusha.srivatsa@intel.com>
Signed-off-by: José Roberto de Souza <jose.souza@intel.com>
---
 .../gpu/drm/i915/display/intel_display_power.c | 18 +++++++-----------
 1 file changed, 7 insertions(+), 11 deletions(-)

diff --git a/drivers/gpu/drm/i915/display/intel_display_power.c b/drivers/gpu/drm/i915/display/intel_display_power.c
index 48d41a43fbb2..31cb9ac5c489 100644
--- a/drivers/gpu/drm/i915/display/intel_display_power.c
+++ b/drivers/gpu/drm/i915/display/intel_display_power.c
@@ -4492,20 +4492,16 @@ static u32 get_allowed_dc_mask(const struct drm_i915_private *dev_priv,
 	int requested_dc;
 	int max_dc;
 
-	if (INTEL_GEN(dev_priv) >= 12) {
-		if (IS_DG1(dev_priv))
-			max_dc = 3;
-		else
-			max_dc = 4;
-	} else if (IS_GEN(dev_priv, 11)) {
+	if (IS_DG1(dev_priv))
+		max_dc = 3;
+	else if (INTEL_GEN(dev_priv) >= 12)
+		max_dc = 4;
+	else if (INTEL_GEN(dev_priv) >= 10 || IS_GEN9_BC(dev_priv))
 		max_dc = 2;
-	} else if (IS_GEN(dev_priv, 10) || IS_GEN9_BC(dev_priv)) {
-		max_dc = 2;
-	} else if (IS_GEN9_LP(dev_priv)) {
+	else if (IS_GEN9_LP(dev_priv))
 		max_dc = 1;
-	} else {
+	else
 		max_dc = 0;
-	}
 
 	/*
 	 * DC9 has a separate HW flow from the rest of the DC states,
-- 
2.29.2

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [1/2] drm/i915/display: Group DC9 mask set

[Patchwork]

[-- Attachment #1.1: Type: text/plain, Size: 5777 bytes --]

== Series Details ==

Series: series starting with [1/2] drm/i915/display: Group DC9 mask set
URL   : https://patchwork.freedesktop.org/series/83739/
State : success

== Summary ==

CI Bug Log - changes from CI_DRM_9309 -> Patchwork_18888
====================================================

Summary
-------

  **SUCCESS**

  No regressions found.

  External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18888/index.html

New tests
---------

  New tests have been introduced between CI_DRM_9309 and Patchwork_18888:

### New CI tests (1) ###

  * boot:
    - Statuses : 40 pass(s)
    - Exec time: [0.0] s

  

Known issues
------------

  Here are the changes found in Patchwork_18888 that come from known issues:

### IGT changes ###

#### Issues hit ####

  * igt@core_hotunplug@unbind-rebind:
    - fi-tgl-u2:          [PASS][1] -> [DMESG-WARN][2] ([i915#1982])
   [1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9309/fi-tgl-u2/igt@core_hotunplug@unbind-rebind.html
   [2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18888/fi-tgl-u2/igt@core_hotunplug@unbind-rebind.html

  * igt@gem_flink_basic@flink-lifetime:
    - fi-tgl-y:           [PASS][3] -> [DMESG-WARN][4] ([i915#402]) +2 similar issues
   [3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9309/fi-tgl-y/igt@gem_flink_basic@flink-lifetime.html
   [4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18888/fi-tgl-y/igt@gem_flink_basic@flink-lifetime.html

  * igt@kms_busy@basic@flip:
    - fi-kbl-soraka:      [PASS][5] -> [DMESG-WARN][6] ([i915#1982])
   [5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9309/fi-kbl-soraka/igt@kms_busy@basic@flip.html
   [6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18888/fi-kbl-soraka/igt@kms_busy@basic@flip.html

  
#### Possible fixes ####

  * igt@kms_busy@basic@flip:
    - {fi-tgl-dsi}:       [DMESG-WARN][7] ([i915#1982]) -> [PASS][8]
   [7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9309/fi-tgl-dsi/igt@kms_busy@basic@flip.html
   [8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18888/fi-tgl-dsi/igt@kms_busy@basic@flip.html

  * igt@kms_chamelium@dp-crc-fast:
    - fi-kbl-7500u:       [FAIL][9] ([i915#1161] / [i915#262]) -> [PASS][10]
   [9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9309/fi-kbl-7500u/igt@kms_chamelium@dp-crc-fast.html
   [10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18888/fi-kbl-7500u/igt@kms_chamelium@dp-crc-fast.html

  * igt@kms_cursor_legacy@basic-busy-flip-before-cursor-atomic:
    - fi-byt-j1900:       [DMESG-WARN][11] ([i915#1982]) -> [PASS][12]
   [11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9309/fi-byt-j1900/igt@kms_cursor_legacy@basic-busy-flip-before-cursor-atomic.html
   [12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18888/fi-byt-j1900/igt@kms_cursor_legacy@basic-busy-flip-before-cursor-atomic.html

  * igt@kms_pipe_crc_basic@compare-crc-sanitycheck-pipe-a:
    - fi-tgl-y:           [DMESG-WARN][13] ([i915#1982]) -> [PASS][14]
   [13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9309/fi-tgl-y/igt@kms_pipe_crc_basic@compare-crc-sanitycheck-pipe-a.html
   [14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18888/fi-tgl-y/igt@kms_pipe_crc_basic@compare-crc-sanitycheck-pipe-a.html

  * igt@kms_pipe_crc_basic@compare-crc-sanitycheck-pipe-b:
    - fi-cfl-8109u:       [DMESG-WARN][15] ([i915#165]) -> [PASS][16] +15 similar issues
   [15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9309/fi-cfl-8109u/igt@kms_pipe_crc_basic@compare-crc-sanitycheck-pipe-b.html
   [16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18888/fi-cfl-8109u/igt@kms_pipe_crc_basic@compare-crc-sanitycheck-pipe-b.html

  * igt@vgem_basic@create:
    - fi-tgl-y:           [DMESG-WARN][17] ([i915#402]) -> [PASS][18] +2 similar issues
   [17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9309/fi-tgl-y/igt@vgem_basic@create.html
   [18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18888/fi-tgl-y/igt@vgem_basic@create.html

  
#### Warnings ####

  * igt@i915_pm_rpm@module-reload:
    - fi-tgl-y:           [DMESG-WARN][19] ([i915#1982] / [i915#2411]) -> [DMESG-WARN][20] ([i915#2411]) +1 similar issue
   [19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9309/fi-tgl-y/igt@i915_pm_rpm@module-reload.html
   [20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18888/fi-tgl-y/igt@i915_pm_rpm@module-reload.html

  
  {name}: This element is suppressed. This means it is ignored when computing
          the status of the difference (SUCCESS, WARNING, or FAILURE).

  [i915#1161]: https://gitlab.freedesktop.org/drm/intel/issues/1161
  [i915#165]: https://gitlab.freedesktop.org/drm/intel/issues/165
  [i915#1982]: https://gitlab.freedesktop.org/drm/intel/issues/1982
  [i915#2411]: https://gitlab.freedesktop.org/drm/intel/issues/2411
  [i915#262]: https://gitlab.freedesktop.org/drm/intel/issues/262
  [i915#402]: https://gitlab.freedesktop.org/drm/intel/issues/402


Participating hosts (46 -> 40)
------------------------------

  Missing    (6): fi-ilk-m540 fi-hsw-4200u fi-bsw-cyan fi-icl-u2 fi-blb-e6850 fi-bdw-samus 


Build changes
-------------

  * Linux: CI_DRM_9309 -> Patchwork_18888

  CI-20190529: 20190529
  CI_DRM_9309: 45764661277bc25b815dfe5d2e5536e98de61c2a @ git://anongit.freedesktop.org/gfx-ci/linux
  IGT_5847: 8cffaebec5228a5042cc6928ac582a0589e2de3e @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
  Patchwork_18888: 4eebf3db83aa666a6f812fcd95bef0244167b563 @ git://anongit.freedesktop.org/gfx-ci/linux


== Linux commits ==

4eebf3db83aa drm/i915/display: Make get_allowed_dc_mask().max_dc set a chain of if and elses
26983741188c drm/i915/display: Group DC9 mask set

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18888/index.html

[-- Attachment #1.2: Type: text/html, Size: 7135 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [Intel-gfx] [PATCH 1/2] drm/i915/display: Group DC9 mask set

[Lucas De Marchi]

On Wed, Nov 11, 2020 at 08:24:07AM -0800, Jose Souza wrote:
>DC9 has a separate HW flow from the rest of the DC states and it is
>available in GEN9 LP platforms and on GEN11 and newer, so here
>moving the assignment of the mask to a single conditional block to
>simplifly code.
>
>Cc: Lucas De Marchi <lucas.demarchi@intel.com>
>Cc: Anusha Srivatsa <anusha.srivatsa@intel.com>
>Signed-off-by: José Roberto de Souza <jose.souza@intel.com>
>---
> .../gpu/drm/i915/display/intel_display_power.c | 18 ++++++++----------
> 1 file changed, 8 insertions(+), 10 deletions(-)
>
>diff --git a/drivers/gpu/drm/i915/display/intel_display_power.c b/drivers/gpu/drm/i915/display/intel_display_power.c
>index 689922480661..48d41a43fbb2 100644
>--- a/drivers/gpu/drm/i915/display/intel_display_power.c
>+++ b/drivers/gpu/drm/i915/display/intel_display_power.c
>@@ -4497,26 +4497,24 @@ static u32 get_allowed_dc_mask(const struct drm_i915_private *dev_priv,
> 			max_dc = 3;
> 		else
> 			max_dc = 4;
>-		/*
>-		 * DC9 has a separate HW flow from the rest of the DC states,
>-		 * not depending on the DMC firmware. It's needed by system
>-		 * suspend/resume, so allow it unconditionally.
>-		 */
>-		mask = DC_STATE_EN_DC9;
> 	} else if (IS_GEN(dev_priv, 11)) {
> 		max_dc = 2;
>-		mask = DC_STATE_EN_DC9;
> 	} else if (IS_GEN(dev_priv, 10) || IS_GEN9_BC(dev_priv)) {
> 		max_dc = 2;
>-		mask = 0;
> 	} else if (IS_GEN9_LP(dev_priv)) {
> 		max_dc = 1;
>-		mask = DC_STATE_EN_DC9;
> 	} else {
> 		max_dc = 0;
>-		mask = 0;
> 	}
>
>+	/*
>+	 * DC9 has a separate HW flow from the rest of the DC states,
>+	 * not depending on the DMC firmware. It's needed by system
>+	 * suspend/resume, so allow it unconditionally.
>+	 */
>+	mask = IS_GEN9_LP(dev_priv) || INTEL_GEN(dev_priv) >= 11 ?
>+	       DC_STATE_EN_DC9 : 0;

humn... these 2 conditions here in a ternary operator is something that
will probably get even harder to read if we have to add more conditions.
Maybe just move the default value to the declaration (mask = 0) and here
you do:

if (IS_GEN9_LP(dev_priv) || INTEL_GEN(dev_priv) >= 11)
	mask = DC_STATE_EN_DC9;

?

Up to you. Change looks correct


Reviewed-by: Lucas De Marchi <lucas.demarchi@intel.com>

Lucas De Marchi

>+
> 	if (!dev_priv->params.disable_power_well)
> 		max_dc = 0;
>
>-- 
>2.29.2
>
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [Intel-gfx] [PATCH 2/2] drm/i915/display: Make get_allowed_dc_mask().max_dc set a chain of if and elses

[Lucas De Marchi]

On Wed, Nov 11, 2020 at 08:24:08AM -0800, Jose Souza wrote:
>Just following what we do in many other places, DG1 is a exception so
>move it to the top instead of add it inside of INTEL_GEN(dev_priv) >= 12.
>
>Cc: Lucas De Marchi <lucas.demarchi@intel.com>
>Cc: Anusha Srivatsa <anusha.srivatsa@intel.com>
>Signed-off-by: José Roberto de Souza <jose.souza@intel.com>


Reviewed-by: Lucas De Marchi <lucas.demarchi@intel.com>

Lucas De Marchi

>---
> .../gpu/drm/i915/display/intel_display_power.c | 18 +++++++-----------
> 1 file changed, 7 insertions(+), 11 deletions(-)
>
>diff --git a/drivers/gpu/drm/i915/display/intel_display_power.c b/drivers/gpu/drm/i915/display/intel_display_power.c
>index 48d41a43fbb2..31cb9ac5c489 100644
>--- a/drivers/gpu/drm/i915/display/intel_display_power.c
>+++ b/drivers/gpu/drm/i915/display/intel_display_power.c
>@@ -4492,20 +4492,16 @@ static u32 get_allowed_dc_mask(const struct drm_i915_private *dev_priv,
> 	int requested_dc;
> 	int max_dc;
>
>-	if (INTEL_GEN(dev_priv) >= 12) {
>-		if (IS_DG1(dev_priv))
>-			max_dc = 3;
>-		else
>-			max_dc = 4;
>-	} else if (IS_GEN(dev_priv, 11)) {
>+	if (IS_DG1(dev_priv))
>+		max_dc = 3;
>+	else if (INTEL_GEN(dev_priv) >= 12)
>+		max_dc = 4;
>+	else if (INTEL_GEN(dev_priv) >= 10 || IS_GEN9_BC(dev_priv))
> 		max_dc = 2;
>-	} else if (IS_GEN(dev_priv, 10) || IS_GEN9_BC(dev_priv)) {
>-		max_dc = 2;
>-	} else if (IS_GEN9_LP(dev_priv)) {
>+	else if (IS_GEN9_LP(dev_priv))
> 		max_dc = 1;
>-	} else {
>+	else
> 		max_dc = 0;
>-	}
>
> 	/*
> 	 * DC9 has a separate HW flow from the rest of the DC states,
>-- 
>2.29.2
>
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

[Intel-gfx] ✓ Fi.CI.IGT: success for series starting with [1/2] drm/i915/display: Group DC9 mask set

[Patchwork]

[-- Attachment #1.1: Type: text/plain, Size: 17852 bytes --]

== Series Details ==

Series: series starting with [1/2] drm/i915/display: Group DC9 mask set
URL   : https://patchwork.freedesktop.org/series/83739/
State : success

== Summary ==

CI Bug Log - changes from CI_DRM_9309_full -> Patchwork_18888_full
====================================================

Summary
-------

  **SUCCESS**

  No regressions found.

  

New tests
---------

  New tests have been introduced between CI_DRM_9309_full and Patchwork_18888_full:

### New CI tests (1) ###

  * boot:
    - Statuses : 175 pass(s)
    - Exec time: [0.0] s

  


### New IGT tests (1) ###

  * igt@sysfs_defaults@readonly:
    - Statuses :
    - Exec time: [None] s

  

Known issues
------------

  Here are the changes found in Patchwork_18888_full that come from known issues:

### IGT changes ###

#### Issues hit ####

  * igt@gem_ctx_isolation@preservation-s3@vcs0:
    - shard-skl:          [PASS][1] -> [INCOMPLETE][2] ([i915#198])
   [1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9309/shard-skl8/igt@gem_ctx_isolation@preservation-s3@vcs0.html
   [2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18888/shard-skl5/igt@gem_ctx_isolation@preservation-s3@vcs0.html

  * igt@gem_exec_create@basic:
    - shard-snb:          [PASS][3] -> [FAIL][4] ([i915#1037])
   [3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9309/shard-snb7/igt@gem_exec_create@basic.html
   [4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18888/shard-snb7/igt@gem_exec_create@basic.html

  * igt@gem_exec_whisper@basic-contexts:
    - shard-glk:          [PASS][5] -> [DMESG-WARN][6] ([i915#118] / [i915#95])
   [5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9309/shard-glk5/igt@gem_exec_whisper@basic-contexts.html
   [6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18888/shard-glk8/igt@gem_exec_whisper@basic-contexts.html

  * igt@kms_cursor_edge_walk@pipe-a-256x256-top-edge:
    - shard-glk:          [PASS][7] -> [DMESG-WARN][8] ([i915#1982]) +2 similar issues
   [7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9309/shard-glk5/igt@kms_cursor_edge_walk@pipe-a-256x256-top-edge.html
   [8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18888/shard-glk1/igt@kms_cursor_edge_walk@pipe-a-256x256-top-edge.html

  * igt@kms_cursor_edge_walk@pipe-d-64x64-top-edge:
    - shard-tglb:         [PASS][9] -> [DMESG-WARN][10] ([i915#1982]) +2 similar issues
   [9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9309/shard-tglb5/igt@kms_cursor_edge_walk@pipe-d-64x64-top-edge.html
   [10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18888/shard-tglb2/igt@kms_cursor_edge_walk@pipe-d-64x64-top-edge.html

  * igt@kms_cursor_legacy@short-flip-before-cursor-toggle:
    - shard-apl:          [PASS][11] -> [DMESG-WARN][12] ([i915#1635] / [i915#1982]) +3 similar issues
   [11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9309/shard-apl1/igt@kms_cursor_legacy@short-flip-before-cursor-toggle.html
   [12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18888/shard-apl8/igt@kms_cursor_legacy@short-flip-before-cursor-toggle.html

  * igt@kms_flip@flip-vs-expired-vblank@a-edp1:
    - shard-tglb:         [PASS][13] -> [FAIL][14] ([i915#2598])
   [13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9309/shard-tglb5/igt@kms_flip@flip-vs-expired-vblank@a-edp1.html
   [14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18888/shard-tglb2/igt@kms_flip@flip-vs-expired-vblank@a-edp1.html

  * igt@kms_flip@flip-vs-suspend@c-dp1:
    - shard-kbl:          [PASS][15] -> [DMESG-WARN][16] ([i915#180])
   [15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9309/shard-kbl6/igt@kms_flip@flip-vs-suspend@c-dp1.html
   [16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18888/shard-kbl2/igt@kms_flip@flip-vs-suspend@c-dp1.html

  * igt@kms_hdr@bpc-switch-dpms:
    - shard-skl:          [PASS][17] -> [FAIL][18] ([i915#1188]) +1 similar issue
   [17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9309/shard-skl8/igt@kms_hdr@bpc-switch-dpms.html
   [18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18888/shard-skl2/igt@kms_hdr@bpc-switch-dpms.html

  * igt@kms_plane_alpha_blend@pipe-b-coverage-7efc:
    - shard-skl:          [PASS][19] -> [FAIL][20] ([fdo#108145] / [i915#265])
   [19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9309/shard-skl3/igt@kms_plane_alpha_blend@pipe-b-coverage-7efc.html
   [20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18888/shard-skl3/igt@kms_plane_alpha_blend@pipe-b-coverage-7efc.html

  * igt@kms_plane_alpha_blend@pipe-c-coverage-7efc:
    - shard-skl:          [PASS][21] -> [DMESG-FAIL][22] ([fdo#108145] / [i915#1982])
   [21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9309/shard-skl2/igt@kms_plane_alpha_blend@pipe-c-coverage-7efc.html
   [22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18888/shard-skl10/igt@kms_plane_alpha_blend@pipe-c-coverage-7efc.html

  * igt@kms_psr@psr2_sprite_plane_move:
    - shard-iclb:         [PASS][23] -> [SKIP][24] ([fdo#109441]) +2 similar issues
   [23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9309/shard-iclb2/igt@kms_psr@psr2_sprite_plane_move.html
   [24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18888/shard-iclb5/igt@kms_psr@psr2_sprite_plane_move.html

  * igt@kms_psr@suspend:
    - shard-skl:          [PASS][25] -> [DMESG-WARN][26] ([i915#1982]) +12 similar issues
   [25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9309/shard-skl10/igt@kms_psr@suspend.html
   [26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18888/shard-skl3/igt@kms_psr@suspend.html

  * igt@kms_vblank@pipe-c-query-forked-busy:
    - shard-kbl:          [PASS][27] -> [DMESG-WARN][28] ([i915#1982]) +3 similar issues
   [27]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9309/shard-kbl4/igt@kms_vblank@pipe-c-query-forked-busy.html
   [28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18888/shard-kbl6/igt@kms_vblank@pipe-c-query-forked-busy.html

  
#### Possible fixes ####

  * igt@gen9_exec_parse@allowed-all:
    - shard-skl:          [DMESG-WARN][29] ([i915#1436] / [i915#716]) -> [PASS][30]
   [29]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9309/shard-skl2/igt@gen9_exec_parse@allowed-all.html
   [30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18888/shard-skl10/igt@gen9_exec_parse@allowed-all.html

  * {igt@kms_async_flips@alternate-sync-async-flip}:
    - shard-tglb:         [FAIL][31] ([i915#2521]) -> [PASS][32]
   [31]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9309/shard-tglb2/igt@kms_async_flips@alternate-sync-async-flip.html
   [32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18888/shard-tglb6/igt@kms_async_flips@alternate-sync-async-flip.html

  * {igt@kms_async_flips@async-flip-with-page-flip-events}:
    - shard-apl:          [FAIL][33] ([i915#1635] / [i915#2521]) -> [PASS][34]
   [33]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9309/shard-apl3/igt@kms_async_flips@async-flip-with-page-flip-events.html
   [34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18888/shard-apl3/igt@kms_async_flips@async-flip-with-page-flip-events.html

  * igt@kms_concurrent@pipe-a:
    - shard-kbl:          [DMESG-WARN][35] ([i915#78]) -> [PASS][36]
   [35]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9309/shard-kbl2/igt@kms_concurrent@pipe-a.html
   [36]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18888/shard-kbl1/igt@kms_concurrent@pipe-a.html

  * igt@kms_cursor_crc@pipe-c-cursor-64x21-random:
    - shard-skl:          [FAIL][37] ([i915#54]) -> [PASS][38]
   [37]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9309/shard-skl5/igt@kms_cursor_crc@pipe-c-cursor-64x21-random.html
   [38]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18888/shard-skl10/igt@kms_cursor_crc@pipe-c-cursor-64x21-random.html

  * igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions:
    - shard-skl:          [FAIL][39] ([i915#2346]) -> [PASS][40] +1 similar issue
   [39]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9309/shard-skl2/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions.html
   [40]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18888/shard-skl4/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions.html

  * igt@kms_cursor_legacy@flip-vs-cursor-legacy:
    - shard-tglb:         [FAIL][41] ([i915#2346]) -> [PASS][42]
   [41]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9309/shard-tglb6/igt@kms_cursor_legacy@flip-vs-cursor-legacy.html
   [42]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18888/shard-tglb5/igt@kms_cursor_legacy@flip-vs-cursor-legacy.html

  * igt@kms_flip@flip-vs-absolute-wf_vblank-interruptible@a-dp1:
    - shard-kbl:          [DMESG-WARN][43] ([i915#1982]) -> [PASS][44]
   [43]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9309/shard-kbl3/igt@kms_flip@flip-vs-absolute-wf_vblank-interruptible@a-dp1.html
   [44]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18888/shard-kbl7/igt@kms_flip@flip-vs-absolute-wf_vblank-interruptible@a-dp1.html

  * igt@kms_flip@plain-flip-fb-recreate-interruptible@c-dp1:
    - shard-apl:          [FAIL][45] ([i915#1635] / [i915#2122]) -> [PASS][46]
   [45]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9309/shard-apl3/igt@kms_flip@plain-flip-fb-recreate-interruptible@c-dp1.html
   [46]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18888/shard-apl4/igt@kms_flip@plain-flip-fb-recreate-interruptible@c-dp1.html

  * igt@kms_flip@plain-flip-ts-check-interruptible@c-hdmi-a2:
    - shard-glk:          [FAIL][47] ([i915#2122]) -> [PASS][48] +2 similar issues
   [47]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9309/shard-glk2/igt@kms_flip@plain-flip-ts-check-interruptible@c-hdmi-a2.html
   [48]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18888/shard-glk5/igt@kms_flip@plain-flip-ts-check-interruptible@c-hdmi-a2.html

  * igt@kms_flip@wf_vblank-ts-check-interruptible@c-edp1:
    - shard-skl:          [FAIL][49] ([i915#2122]) -> [PASS][50] +4 similar issues
   [49]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9309/shard-skl3/igt@kms_flip@wf_vblank-ts-check-interruptible@c-edp1.html
   [50]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18888/shard-skl6/igt@kms_flip@wf_vblank-ts-check-interruptible@c-edp1.html

  * igt@kms_frontbuffer_tracking@fbc-stridechange:
    - shard-tglb:         [DMESG-WARN][51] ([i915#1982]) -> [PASS][52] +3 similar issues
   [51]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9309/shard-tglb2/igt@kms_frontbuffer_tracking@fbc-stridechange.html
   [52]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18888/shard-tglb6/igt@kms_frontbuffer_tracking@fbc-stridechange.html

  * igt@kms_plane_cursor@pipe-b-overlay-size-128:
    - shard-skl:          [DMESG-WARN][53] ([i915#1982]) -> [PASS][54] +5 similar issues
   [53]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9309/shard-skl4/igt@kms_plane_cursor@pipe-b-overlay-size-128.html
   [54]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18888/shard-skl8/igt@kms_plane_cursor@pipe-b-overlay-size-128.html

  * igt@kms_psr@psr2_cursor_plane_move:
    - shard-iclb:         [SKIP][55] ([fdo#109441]) -> [PASS][56] +1 similar issue
   [55]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9309/shard-iclb6/igt@kms_psr@psr2_cursor_plane_move.html
   [56]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18888/shard-iclb2/igt@kms_psr@psr2_cursor_plane_move.html

  * igt@kms_vblank@pipe-c-query-forked-busy:
    - shard-iclb:         [DMESG-WARN][57] ([i915#1982]) -> [PASS][58]
   [57]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9309/shard-iclb8/igt@kms_vblank@pipe-c-query-forked-busy.html
   [58]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18888/shard-iclb6/igt@kms_vblank@pipe-c-query-forked-busy.html

  
#### Warnings ####

  * igt@gem_eio@in-flight-suspend:
    - shard-apl:          [INCOMPLETE][59] ([i915#1635] / [i915#2635]) -> [DMESG-WARN][60] ([i915#1635] / [i915#2635])
   [59]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9309/shard-apl3/igt@gem_eio@in-flight-suspend.html
   [60]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18888/shard-apl4/igt@gem_eio@in-flight-suspend.html
    - shard-glk:          [DMESG-WARN][61] ([i915#2635]) -> [INCOMPLETE][62] ([i915#2635])
   [61]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9309/shard-glk1/igt@gem_eio@in-flight-suspend.html
   [62]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18888/shard-glk9/igt@gem_eio@in-flight-suspend.html
    - shard-iclb:         [DMESG-WARN][63] -> [INCOMPLETE][64] ([i915#1185])
   [63]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9309/shard-iclb1/igt@gem_eio@in-flight-suspend.html
   [64]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18888/shard-iclb2/igt@gem_eio@in-flight-suspend.html

  * igt@kms_dp_dsc@basic-dsc-enable-edp:
    - shard-iclb:         [DMESG-WARN][65] ([i915#1226]) -> [SKIP][66] ([fdo#109349])
   [65]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9309/shard-iclb2/igt@kms_dp_dsc@basic-dsc-enable-edp.html
   [66]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18888/shard-iclb6/igt@kms_dp_dsc@basic-dsc-enable-edp.html

  * igt@kms_flip@plain-flip-ts-check@a-edp1:
    - shard-skl:          [DMESG-FAIL][67] ([i915#1982]) -> [DMESG-WARN][68] ([i915#1982])
   [67]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9309/shard-skl1/igt@kms_flip@plain-flip-ts-check@a-edp1.html
   [68]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18888/shard-skl4/igt@kms_flip@plain-flip-ts-check@a-edp1.html

  * igt@kms_vblank@pipe-c-ts-continuation-dpms-suspend:
    - shard-tglb:         [INCOMPLETE][69] ([i915#1436]) -> [INCOMPLETE][70] ([i915#1436] / [i915#456])
   [69]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9309/shard-tglb2/igt@kms_vblank@pipe-c-ts-continuation-dpms-suspend.html
   [70]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18888/shard-tglb6/igt@kms_vblank@pipe-c-ts-continuation-dpms-suspend.html

  * igt@runner@aborted:
    - shard-iclb:         ([FAIL][71], [FAIL][72], [FAIL][73]) ([i915#1814] / [i915#2439] / [i915#483]) -> ([FAIL][74], [FAIL][75], [FAIL][76]) ([i915#1814] / [i915#2439])
   [71]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9309/shard-iclb1/igt@runner@aborted.html
   [72]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9309/shard-iclb4/igt@runner@aborted.html
   [73]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9309/shard-iclb8/igt@runner@aborted.html
   [74]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18888/shard-iclb2/igt@runner@aborted.html
   [75]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18888/shard-iclb3/igt@runner@aborted.html
   [76]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18888/shard-iclb4/igt@runner@aborted.html
    - shard-skl:          ([FAIL][77], [FAIL][78]) ([i915#1436] / [i915#1611] / [i915#2439]) -> [FAIL][79] ([i915#1611] / [i915#2439])
   [77]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9309/shard-skl2/igt@runner@aborted.html
   [78]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9309/shard-skl1/igt@runner@aborted.html
   [79]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18888/shard-skl4/igt@runner@aborted.html

  
  {name}: This element is suppressed. This means it is ignored when computing
          the status of the difference (SUCCESS, WARNING, or FAILURE).

  [fdo#108145]: https://bugs.freedesktop.org/show_bug.cgi?id=108145
  [fdo#109349]: https://bugs.freedesktop.org/show_bug.cgi?id=109349
  [fdo#109441]: https://bugs.freedesktop.org/show_bug.cgi?id=109441
  [i915#1037]: https://gitlab.freedesktop.org/drm/intel/issues/1037
  [i915#118]: https://gitlab.freedesktop.org/drm/intel/issues/118
  [i915#1185]: https://gitlab.freedesktop.org/drm/intel/issues/1185
  [i915#1188]: https://gitlab.freedesktop.org/drm/intel/issues/1188
  [i915#1226]: https://gitlab.freedesktop.org/drm/intel/issues/1226
  [i915#1436]: https://gitlab.freedesktop.org/drm/intel/issues/1436
  [i915#1611]: https://gitlab.freedesktop.org/drm/intel/issues/1611
  [i915#1635]: https://gitlab.freedesktop.org/drm/intel/issues/1635
  [i915#180]: https://gitlab.freedesktop.org/drm/intel/issues/180
  [i915#1814]: https://gitlab.freedesktop.org/drm/intel/issues/1814
  [i915#198]: https://gitlab.freedesktop.org/drm/intel/issues/198
  [i915#1982]: https://gitlab.freedesktop.org/drm/intel/issues/1982
  [i915#2122]: https://gitlab.freedesktop.org/drm/intel/issues/2122
  [i915#2346]: https://gitlab.freedesktop.org/drm/intel/issues/2346
  [i915#2439]: https://gitlab.freedesktop.org/drm/intel/issues/2439
  [i915#2521]: https://gitlab.freedesktop.org/drm/intel/issues/2521
  [i915#2598]: https://gitlab.freedesktop.org/drm/intel/issues/2598
  [i915#2635]: https://gitlab.freedesktop.org/drm/intel/issues/2635
  [i915#265]: https://gitlab.freedesktop.org/drm/intel/issues/265
  [i915#456]: https://gitlab.freedesktop.org/drm/intel/issues/456
  [i915#483]: https://gitlab.freedesktop.org/drm/intel/issues/483
  [i915#54]: https://gitlab.freedesktop.org/drm/intel/issues/54
  [i915#716]: https://gitlab.freedesktop.org/drm/intel/issues/716
  [i915#78]: https://gitlab.freedesktop.org/drm/intel/issues/78
  [i915#95]: https://gitlab.freedesktop.org/drm/intel/issues/95


Participating hosts (11 -> 11)
------------------------------

  No changes in participating hosts


Build changes
-------------

  * Linux: CI_DRM_9309 -> Patchwork_18888

  CI-20190529: 20190529
  CI_DRM_9309: 45764661277bc25b815dfe5d2e5536e98de61c2a @ git://anongit.freedesktop.org/gfx-ci/linux
  IGT_5847: 8cffaebec5228a5042cc6928ac582a0589e2de3e @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
  Patchwork_18888: 4eebf3db83aa666a6f812fcd95bef0244167b563 @ git://anongit.freedesktop.org/gfx-ci/linux
  piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18888/index.html

[-- Attachment #1.2: Type: text/html, Size: 21807 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [Intel-gfx] [PATCH 1/2] drm/i915/display: Group DC9 mask set

[Souza, Jose]

On Wed, 2020-11-11 at 13:12 -0800, Lucas De Marchi wrote:
> On Wed, Nov 11, 2020 at 08:24:07AM -0800, Jose Souza wrote:
> > DC9 has a separate HW flow from the rest of the DC states and it is
> > available in GEN9 LP platforms and on GEN11 and newer, so here
> > moving the assignment of the mask to a single conditional block to
> > simplifly code.
> > 
> > Cc: Lucas De Marchi <lucas.demarchi@intel.com>
> > Cc: Anusha Srivatsa <anusha.srivatsa@intel.com>
> > Signed-off-by: José Roberto de Souza <jose.souza@intel.com>
> > ---
> > .../gpu/drm/i915/display/intel_display_power.c | 18 ++++++++----------
> > 1 file changed, 8 insertions(+), 10 deletions(-)
> > 
> > diff --git a/drivers/gpu/drm/i915/display/intel_display_power.c b/drivers/gpu/drm/i915/display/intel_display_power.c
> > index 689922480661..48d41a43fbb2 100644
> > --- a/drivers/gpu/drm/i915/display/intel_display_power.c
> > +++ b/drivers/gpu/drm/i915/display/intel_display_power.c
> > @@ -4497,26 +4497,24 @@ static u32 get_allowed_dc_mask(const struct drm_i915_private *dev_priv,
> > 			max_dc = 3;
> > 		else
> > 			max_dc = 4;
> > -		/*
> > -		 * DC9 has a separate HW flow from the rest of the DC states,
> > -		 * not depending on the DMC firmware. It's needed by system
> > -		 * suspend/resume, so allow it unconditionally.
> > -		 */
> > -		mask = DC_STATE_EN_DC9;
> > 	} else if (IS_GEN(dev_priv, 11)) {
> > 		max_dc = 2;
> > -		mask = DC_STATE_EN_DC9;
> > 	} else if (IS_GEN(dev_priv, 10) || IS_GEN9_BC(dev_priv)) {
> > 		max_dc = 2;
> > -		mask = 0;
> > 	} else if (IS_GEN9_LP(dev_priv)) {
> > 		max_dc = 1;
> > -		mask = DC_STATE_EN_DC9;
> > 	} else {
> > 		max_dc = 0;
> > -		mask = 0;
> > 	}
> > 
> > +	/*
> > +	 * DC9 has a separate HW flow from the rest of the DC states,
> > +	 * not depending on the DMC firmware. It's needed by system
> > +	 * suspend/resume, so allow it unconditionally.
> > +	 */
> > +	mask = IS_GEN9_LP(dev_priv) || INTEL_GEN(dev_priv) >= 11 ?
> > +	       DC_STATE_EN_DC9 : 0;
> 
> humn... these 2 conditions here in a ternary operator is something that
> will probably get even harder to read if we have to add more conditions.
> Maybe just move the default value to the declaration (mask = 0) and here
> you do:
> 
> if (IS_GEN9_LP(dev_priv) || INTEL_GEN(dev_priv) >= 11)
> 	mask = DC_STATE_EN_DC9;
> 
> ?
> 
> Up to you. Change looks correct

Will keep the way this patch is as I believe that all new platforms will support DC9 so this block will not change but if it happens we should do like
you suggested.

> 
> 
> Reviewed-by: Lucas De Marchi <lucas.demarchi@intel.com>

thanks

> 
> Lucas De Marchi
> 
> > +
> > 	if (!dev_priv->params.disable_power_well)
> > 		max_dc = 0;
> > 
> > -- 
> > 2.29.2
> > 

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [Intel-gfx] ✓ Fi.CI.IGT: success for series starting with [1/2] drm/i915/display: Group DC9 mask set

[Souza, Jose]

[-- Attachment #1.1: Type: text/plain, Size: 17853 bytes --]

On Wed, 2020-11-11 at 21:57 +0000, Patchwork wrote:
Patch Details
Series: series starting with [1/2] drm/i915/display: Group DC9 mask set
URL:    https://patchwork.freedesktop.org/series/83739/
State:  success
Details:        https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18888/index.html
CI Bug Log - changes from CI_DRM_9309_full -> Patchwork_18888_full
Summary

SUCCESS

No regressions found.

Pushed to dinq, thanks for the reviews Lucas.

New tests

New tests have been introduced between CI_DRM_9309_full and Patchwork_18888_full:

New CI tests (1)

  *   boot:
     *   Statuses : 175 pass(s)
     *   Exec time: [0.0] s

New IGT tests (1)

  *   igt@sysfs_defaults@readonly:
     *   Statuses :
     *   Exec time: [None] s

Known issues

Here are the changes found in Patchwork_18888_full that come from known issues:

IGT changes
Issues hit

  *   igt@gem_ctx_isolation@preservation-s3@vcs0:

     *   shard-skl: PASS<https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9309/shard-skl8/igt@gem_ctx_isolation@preservation-s3@vcs0.html> -> INCOMPLETE<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18888/shard-skl5/igt@gem_ctx_isolation@preservation-s3@vcs0.html> (i915#198<https://gitlab.freedesktop.org/drm/intel/issues/198>)
  *   igt@gem_exec_create@basic:

     *   shard-snb: PASS<https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9309/shard-snb7/igt@gem_exec_create@basic.html> -> FAIL<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18888/shard-snb7/igt@gem_exec_create@basic.html> (i915#1037<https://gitlab.freedesktop.org/drm/intel/issues/1037>)
  *   igt@gem_exec_whisper@basic-contexts:

     *   shard-glk: PASS<https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9309/shard-glk5/igt@gem_exec_whisper@basic-contexts.html> -> DMESG-WARN<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18888/shard-glk8/igt@gem_exec_whisper@basic-contexts.html> (i915#118<https://gitlab.freedesktop.org/drm/intel/issues/118> / i915#95<https://gitlab.freedesktop.org/drm/intel/issues/95>)
  *   igt@kms_cursor_edge_walk@pipe-a-256x256-top-edge:

     *   shard-glk: PASS<https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9309/shard-glk5/igt@kms_cursor_edge_walk@pipe-a-256x256-top-edge.html> -> DMESG-WARN<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18888/shard-glk1/igt@kms_cursor_edge_walk@pipe-a-256x256-top-edge.html> (i915#1982<https://gitlab.freedesktop.org/drm/intel/issues/1982>) +2 similar issues
  *   igt@kms_cursor_edge_walk@pipe-d-64x64-top-edge:

     *   shard-tglb: PASS<https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9309/shard-tglb5/igt@kms_cursor_edge_walk@pipe-d-64x64-top-edge.html> -> DMESG-WARN<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18888/shard-tglb2/igt@kms_cursor_edge_walk@pipe-d-64x64-top-edge.html> (i915#1982<https://gitlab.freedesktop.org/drm/intel/issues/1982>) +2 similar issues
  *   igt@kms_cursor_legacy@short-flip-before-cursor-toggle:

     *   shard-apl: PASS<https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9309/shard-apl1/igt@kms_cursor_legacy@short-flip-before-cursor-toggle.html> -> DMESG-WARN<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18888/shard-apl8/igt@kms_cursor_legacy@short-flip-before-cursor-toggle.html> (i915#1635<https://gitlab.freedesktop.org/drm/intel/issues/1635> / i915#1982<https://gitlab.freedesktop.org/drm/intel/issues/1982>) +3 similar issues
  *   igt@kms_flip@flip-vs-expired-vblank@a-edp1:

     *   shard-tglb: PASS<https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9309/shard-tglb5/igt@kms_flip@flip-vs-expired-vblank@a-edp1.html> -> FAIL<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18888/shard-tglb2/igt@kms_flip@flip-vs-expired-vblank@a-edp1.html> (i915#2598<https://gitlab.freedesktop.org/drm/intel/issues/2598>)
  *   igt@kms_flip@flip-vs-suspend@c-dp1:

     *   shard-kbl: PASS<https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9309/shard-kbl6/igt@kms_flip@flip-vs-suspend@c-dp1.html> -> DMESG-WARN<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18888/shard-kbl2/igt@kms_flip@flip-vs-suspend@c-dp1.html> (i915#180<https://gitlab.freedesktop.org/drm/intel/issues/180>)
  *   igt@kms_hdr@bpc-switch-dpms:

     *   shard-skl: PASS<https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9309/shard-skl8/igt@kms_hdr@bpc-switch-dpms.html> -> FAIL<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18888/shard-skl2/igt@kms_hdr@bpc-switch-dpms.html> (i915#1188<https://gitlab.freedesktop.org/drm/intel/issues/1188>) +1 similar issue
  *   igt@kms_plane_alpha_blend@pipe-b-coverage-7efc:

     *   shard-skl: PASS<https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9309/shard-skl3/igt@kms_plane_alpha_blend@pipe-b-coverage-7efc.html> -> FAIL<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18888/shard-skl3/igt@kms_plane_alpha_blend@pipe-b-coverage-7efc.html> (fdo#108145<https://bugs.freedesktop.org/show_bug.cgi?id=108145> / i915#265<https://gitlab.freedesktop.org/drm/intel/issues/265>)
  *   igt@kms_plane_alpha_blend@pipe-c-coverage-7efc:

     *   shard-skl: PASS<https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9309/shard-skl2/igt@kms_plane_alpha_blend@pipe-c-coverage-7efc.html> -> DMESG-FAIL<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18888/shard-skl10/igt@kms_plane_alpha_blend@pipe-c-coverage-7efc.html> (fdo#108145<https://bugs.freedesktop.org/show_bug.cgi?id=108145> / i915#1982<https://gitlab.freedesktop.org/drm/intel/issues/1982>)
  *   igt@kms_psr@psr2_sprite_plane_move:

     *   shard-iclb: PASS<https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9309/shard-iclb2/igt@kms_psr@psr2_sprite_plane_move.html> -> SKIP<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18888/shard-iclb5/igt@kms_psr@psr2_sprite_plane_move.html> (fdo#109441<https://bugs.freedesktop.org/show_bug.cgi?id=109441>) +2 similar issues
  *   igt@kms_psr@suspend:

     *   shard-skl: PASS<https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9309/shard-skl10/igt@kms_psr@suspend.html> -> DMESG-WARN<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18888/shard-skl3/igt@kms_psr@suspend.html> (i915#1982<https://gitlab.freedesktop.org/drm/intel/issues/1982>) +12 similar issues
  *   igt@kms_vblank@pipe-c-query-forked-busy:

     *   shard-kbl: PASS<https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9309/shard-kbl4/igt@kms_vblank@pipe-c-query-forked-busy.html> -> DMESG-WARN<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18888/shard-kbl6/igt@kms_vblank@pipe-c-query-forked-busy.html> (i915#1982<https://gitlab.freedesktop.org/drm/intel/issues/1982>) +3 similar issues

Possible fixes

  *   igt@gen9_exec_parse@allowed-all:

     *   shard-skl: DMESG-WARN<https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9309/shard-skl2/igt@gen9_exec_parse@allowed-all.html> (i915#1436<https://gitlab.freedesktop.org/drm/intel/issues/1436> / i915#716<https://gitlab.freedesktop.org/drm/intel/issues/716>) -> PASS<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18888/shard-skl10/igt@gen9_exec_parse@allowed-all.html>
  *   {igt@kms_async_flips@alternate-sync-async-flip}:

     *   shard-tglb: FAIL<https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9309/shard-tglb2/igt@kms_async_flips@alternate-sync-async-flip.html> (i915#2521<https://gitlab.freedesktop.org/drm/intel/issues/2521>) -> PASS<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18888/shard-tglb6/igt@kms_async_flips@alternate-sync-async-flip.html>
  *   {igt@kms_async_flips@async-flip-with-page-flip-events}:

     *   shard-apl: FAIL<https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9309/shard-apl3/igt@kms_async_flips@async-flip-with-page-flip-events.html> (i915#1635<https://gitlab.freedesktop.org/drm/intel/issues/1635> / i915#2521<https://gitlab.freedesktop.org/drm/intel/issues/2521>) -> PASS<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18888/shard-apl3/igt@kms_async_flips@async-flip-with-page-flip-events.html>
  *   igt@kms_concurrent@pipe-a:

     *   shard-kbl: DMESG-WARN<https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9309/shard-kbl2/igt@kms_concurrent@pipe-a.html> (i915#78<https://gitlab.freedesktop.org/drm/intel/issues/78>) -> PASS<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18888/shard-kbl1/igt@kms_concurrent@pipe-a.html>
  *   igt@kms_cursor_crc@pipe-c-cursor-64x21-random:

     *   shard-skl: FAIL<https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9309/shard-skl5/igt@kms_cursor_crc@pipe-c-cursor-64x21-random.html> (i915#54<https://gitlab.freedesktop.org/drm/intel/issues/54>) -> PASS<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18888/shard-skl10/igt@kms_cursor_crc@pipe-c-cursor-64x21-random.html>
  *   igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions:

     *   shard-skl: FAIL<https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9309/shard-skl2/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions.html> (i915#2346<https://gitlab.freedesktop.org/drm/intel/issues/2346>) -> PASS<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18888/shard-skl4/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions.html> +1 similar issue
  *   igt@kms_cursor_legacy@flip-vs-cursor-legacy:

     *   shard-tglb: FAIL<https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9309/shard-tglb6/igt@kms_cursor_legacy@flip-vs-cursor-legacy.html> (i915#2346<https://gitlab.freedesktop.org/drm/intel/issues/2346>) -> PASS<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18888/shard-tglb5/igt@kms_cursor_legacy@flip-vs-cursor-legacy.html>
  *   igt@kms_flip@flip-vs-absolute-wf_vblank-interruptible@a-dp1:

     *   shard-kbl: DMESG-WARN<https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9309/shard-kbl3/igt@kms_flip@flip-vs-absolute-wf_vblank-interruptible@a-dp1.html> (i915#1982<https://gitlab.freedesktop.org/drm/intel/issues/1982>) -> PASS<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18888/shard-kbl7/igt@kms_flip@flip-vs-absolute-wf_vblank-interruptible@a-dp1.html>
  *   igt@kms_flip@plain-flip-fb-recreate-interruptible@c-dp1:

     *   shard-apl: FAIL<https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9309/shard-apl3/igt@kms_flip@plain-flip-fb-recreate-interruptible@c-dp1.html> (i915#1635<https://gitlab.freedesktop.org/drm/intel/issues/1635> / i915#2122<https://gitlab.freedesktop.org/drm/intel/issues/2122>) -> PASS<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18888/shard-apl4/igt@kms_flip@plain-flip-fb-recreate-interruptible@c-dp1.html>
  *   igt@kms_flip@plain-flip-ts-check-interruptible@c-hdmi-a2:

     *   shard-glk: FAIL<https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9309/shard-glk2/igt@kms_flip@plain-flip-ts-check-interruptible@c-hdmi-a2.html> (i915#2122<https://gitlab.freedesktop.org/drm/intel/issues/2122>) -> PASS<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18888/shard-glk5/igt@kms_flip@plain-flip-ts-check-interruptible@c-hdmi-a2.html> +2 similar issues
  *   igt@kms_flip@wf_vblank-ts-check-interruptible@c-edp1:

     *   shard-skl: FAIL<https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9309/shard-skl3/igt@kms_flip@wf_vblank-ts-check-interruptible@c-edp1.html> (i915#2122<https://gitlab.freedesktop.org/drm/intel/issues/2122>) -> PASS<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18888/shard-skl6/igt@kms_flip@wf_vblank-ts-check-interruptible@c-edp1.html> +4 similar issues
  *   igt@kms_frontbuffer_tracking@fbc-stridechange:

     *   shard-tglb: DMESG-WARN<https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9309/shard-tglb2/igt@kms_frontbuffer_tracking@fbc-stridechange.html> (i915#1982<https://gitlab.freedesktop.org/drm/intel/issues/1982>) -> PASS<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18888/shard-tglb6/igt@kms_frontbuffer_tracking@fbc-stridechange.html> +3 similar issues
  *   igt@kms_plane_cursor@pipe-b-overlay-size-128:

     *   shard-skl: DMESG-WARN<https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9309/shard-skl4/igt@kms_plane_cursor@pipe-b-overlay-size-128.html> (i915#1982<https://gitlab.freedesktop.org/drm/intel/issues/1982>) -> PASS<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18888/shard-skl8/igt@kms_plane_cursor@pipe-b-overlay-size-128.html> +5 similar issues
  *   igt@kms_psr@psr2_cursor_plane_move:

     *   shard-iclb: SKIP<https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9309/shard-iclb6/igt@kms_psr@psr2_cursor_plane_move.html> (fdo#109441<https://bugs.freedesktop.org/show_bug.cgi?id=109441>) -> PASS<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18888/shard-iclb2/igt@kms_psr@psr2_cursor_plane_move.html> +1 similar issue
  *   igt@kms_vblank@pipe-c-query-forked-busy:

     *   shard-iclb: DMESG-WARN<https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9309/shard-iclb8/igt@kms_vblank@pipe-c-query-forked-busy.html> (i915#1982<https://gitlab.freedesktop.org/drm/intel/issues/1982>) -> PASS<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18888/shard-iclb6/igt@kms_vblank@pipe-c-query-forked-busy.html>

Warnings

  *   igt@gem_eio@in-flight-suspend:

     *   shard-apl: INCOMPLETE<https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9309/shard-apl3/igt@gem_eio@in-flight-suspend.html> (i915#1635<https://gitlab.freedesktop.org/drm/intel/issues/1635> / i915#2635<https://gitlab.freedesktop.org/drm/intel/issues/2635>) -> DMESG-WARN<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18888/shard-apl4/igt@gem_eio@in-flight-suspend.html> (i915#1635<https://gitlab.freedesktop.org/drm/intel/issues/1635> / i915#2635<https://gitlab.freedesktop.org/drm/intel/issues/2635>)

     *   shard-glk: DMESG-WARN<https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9309/shard-glk1/igt@gem_eio@in-flight-suspend.html> (i915#2635<https://gitlab.freedesktop.org/drm/intel/issues/2635>) -> INCOMPLETE<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18888/shard-glk9/igt@gem_eio@in-flight-suspend.html> (i915#2635<https://gitlab.freedesktop.org/drm/intel/issues/2635>)

     *   shard-iclb: DMESG-WARN<https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9309/shard-iclb1/igt@gem_eio@in-flight-suspend.html> -> INCOMPLETE<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18888/shard-iclb2/igt@gem_eio@in-flight-suspend.html> (i915#1185<https://gitlab.freedesktop.org/drm/intel/issues/1185>)

  *   igt@kms_dp_dsc@basic-dsc-enable-edp:

     *   shard-iclb: DMESG-WARN<https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9309/shard-iclb2/igt@kms_dp_dsc@basic-dsc-enable-edp.html> (i915#1226<https://gitlab.freedesktop.org/drm/intel/issues/1226>) -> SKIP<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18888/shard-iclb6/igt@kms_dp_dsc@basic-dsc-enable-edp.html> (fdo#109349<https://bugs.freedesktop.org/show_bug.cgi?id=109349>)
  *   igt@kms_flip@plain-flip-ts-check@a-edp1:

     *   shard-skl: DMESG-FAIL<https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9309/shard-skl1/igt@kms_flip@plain-flip-ts-check@a-edp1.html> (i915#1982<https://gitlab.freedesktop.org/drm/intel/issues/1982>) -> DMESG-WARN<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18888/shard-skl4/igt@kms_flip@plain-flip-ts-check@a-edp1.html> (i915#1982<https://gitlab.freedesktop.org/drm/intel/issues/1982>)
  *   igt@kms_vblank@pipe-c-ts-continuation-dpms-suspend:

     *   shard-tglb: INCOMPLETE<https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9309/shard-tglb2/igt@kms_vblank@pipe-c-ts-continuation-dpms-suspend.html> (i915#1436<https://gitlab.freedesktop.org/drm/intel/issues/1436>) -> INCOMPLETE<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18888/shard-tglb6/igt@kms_vblank@pipe-c-ts-continuation-dpms-suspend.html> (i915#1436<https://gitlab.freedesktop.org/drm/intel/issues/1436> / i915#456<https://gitlab.freedesktop.org/drm/intel/issues/456>)
  *   igt@runner@aborted:

     *   shard-iclb: (FAIL<https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9309/shard-iclb1/igt@runner@aborted.html>, FAIL<https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9309/shard-iclb4/igt@runner@aborted.html>, FAIL<https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9309/shard-iclb8/igt@runner@aborted.html>) (i915#1814<https://gitlab.freedesktop.org/drm/intel/issues/1814> / i915#2439<https://gitlab.freedesktop.org/drm/intel/issues/2439> / i915#483<https://gitlab.freedesktop.org/drm/intel/issues/483>) -> (FAIL<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18888/shard-iclb2/igt@runner@aborted.html>, FAIL<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18888/shard-iclb3/igt@runner@aborted.html>, FAIL<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18888/shard-iclb4/igt@runner@aborted.html>) (i915#1814<https://gitlab.freedesktop.org/drm/intel/issues/1814> / i915#2439<https://gitlab.freedesktop.org/drm/intel/issues/2439>)

     *   shard-skl: (FAIL<https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9309/shard-skl2/igt@runner@aborted.html>, FAIL<https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9309/shard-skl1/igt@runner@aborted.html>) (i915#1436<https://gitlab.freedesktop.org/drm/intel/issues/1436> / i915#1611<https://gitlab.freedesktop.org/drm/intel/issues/1611> / i915#2439<https://gitlab.freedesktop.org/drm/intel/issues/2439>) -> FAIL<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18888/shard-skl4/igt@runner@aborted.html> (i915#1611<https://gitlab.freedesktop.org/drm/intel/issues/1611> / i915#2439<https://gitlab.freedesktop.org/drm/intel/issues/2439>)

{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).

Participating hosts (11 -> 11)

No changes in participating hosts

Build changes

  *   Linux: CI_DRM_9309 -> Patchwork_18888

CI-20190529: 20190529
CI_DRM_9309: 45764661277bc25b815dfe5d2e5536e98de61c2a @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_5847: 8cffaebec5228a5042cc6928ac582a0589e2de3e @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_18888: 4eebf3db83aa666a6f812fcd95bef0244167b563 @ git://anongit.freedesktop.org/gfx-ci/linux
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit


[-- Attachment #1.2: Type: text/html, Size: 22037 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx