* [U-Boot] [PATCH 1/1] armv7m: mpu_config add missing break
@ 2017-07-30 18:34 Heinrich Schuchardt
2017-07-31 18:18 ` Vikas Manocha
2017-08-14 0:07 ` [U-Boot] [U-Boot,1/1] " Tom Rini
0 siblings, 2 replies; 3+ messages in thread
From: Heinrich Schuchardt @ 2017-07-30 18:34 UTC (permalink / raw)
To: u-boot
For DEVICE_NON_SHARED the newly assigned value of attr
is overwritten due to a missing break.
The problem was indicated by cppcheck.
Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
---
arch/arm/cpu/armv7m/mpu.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/arm/cpu/armv7m/mpu.c b/arch/arm/cpu/armv7m/mpu.c
index 31a243b49a..4622aa4826 100644
--- a/arch/arm/cpu/armv7m/mpu.c
+++ b/arch/arm/cpu/armv7m/mpu.c
@@ -68,6 +68,7 @@ void mpu_config(struct mpu_region_config *reg_config)
break;
case DEVICE_NON_SHARED:
attr = (2 << TEX_SHIFT) | BUFFERABLE;
+ break;
default:
attr = 0; /* strongly ordered */
break;
--
2.13.2
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [U-Boot] [PATCH 1/1] armv7m: mpu_config add missing break
2017-07-30 18:34 [U-Boot] [PATCH 1/1] armv7m: mpu_config add missing break Heinrich Schuchardt
@ 2017-07-31 18:18 ` Vikas Manocha
2017-08-14 0:07 ` [U-Boot] [U-Boot,1/1] " Tom Rini
1 sibling, 0 replies; 3+ messages in thread
From: Vikas Manocha @ 2017-07-31 18:18 UTC (permalink / raw)
To: u-boot
Hi,
On 07/30/2017 11:34 AM, Heinrich Schuchardt wrote:
> For DEVICE_NON_SHARED the newly assigned value of attr
> is overwritten due to a missing break.
>
> The problem was indicated by cppcheck.
>
> Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
reviewed-by : Vikas Manocha <vikas.manocha@st.com>
Cheers,
Vikas
> ---
> arch/arm/cpu/armv7m/mpu.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/arch/arm/cpu/armv7m/mpu.c b/arch/arm/cpu/armv7m/mpu.c
> index 31a243b49a..4622aa4826 100644
> --- a/arch/arm/cpu/armv7m/mpu.c
> +++ b/arch/arm/cpu/armv7m/mpu.c
> @@ -68,6 +68,7 @@ void mpu_config(struct mpu_region_config *reg_config)
> break;
> case DEVICE_NON_SHARED:
> attr = (2 << TEX_SHIFT) | BUFFERABLE;
> + break;
> default:
> attr = 0; /* strongly ordered */
> break;
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* [U-Boot] [U-Boot,1/1] armv7m: mpu_config add missing break
2017-07-30 18:34 [U-Boot] [PATCH 1/1] armv7m: mpu_config add missing break Heinrich Schuchardt
2017-07-31 18:18 ` Vikas Manocha
@ 2017-08-14 0:07 ` Tom Rini
1 sibling, 0 replies; 3+ messages in thread
From: Tom Rini @ 2017-08-14 0:07 UTC (permalink / raw)
To: u-boot
On Sun, Jul 30, 2017 at 08:34:20PM +0200, xypron.glpk at gmx.de wrote:
> For DEVICE_NON_SHARED the newly assigned value of attr
> is overwritten due to a missing break.
>
> The problem was indicated by cppcheck.
>
> Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
Applied to u-boot/master, thanks!
--
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20170813/bf29ed7d/attachment.sig>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-08-14 0:07 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-07-30 18:34 [U-Boot] [PATCH 1/1] armv7m: mpu_config add missing break Heinrich Schuchardt
2017-07-31 18:18 ` Vikas Manocha
2017-08-14 0:07 ` [U-Boot] [U-Boot,1/1] " Tom Rini
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.