All of lore.kernel.org
 help / color / mirror / Atom feed
From: Avery Pennarun <apenwarr@gmail.com>
To: Jonathan Nieder <jrnieder@gmail.com>
Cc: Daniel Thomas <drt24@srcf.ucam.org>,
	Git Mailing List <git@vger.kernel.org>
Subject: Re: [GSoC Proposal/RFC] Rolling commit message writing
Date: Tue, 30 Mar 2010 00:32:11 -0400	[thread overview]
Message-ID: <32541b131003292132q10db3c5eh1bb6443d625fcb82@mail.gmail.com> (raw)
In-Reply-To: <20100330030508.GA2887@progeny.tock>

On Mon, Mar 29, 2010 at 11:05 PM, Jonathan Nieder <jrnieder@gmail.com> wrote:
> Avery Pennarun wrote:
>> Given these existing capabilities, is it still worth adding the
>> feature you propose?
>
> I think it might be, in some modified form.
>
> Suppose I am working on a medium-sized change that for reasons of
> bisectability or ontology has to be one commit.  In the middle of
> working, I notice I needed to do something nonobvious.  Currently when
> this happens, I get out a pad of paper and write it down, so I can be
> sure to mention it in the commit message.

When I have this situation, I generally just make a temporary commit
with "git commit", then revise it using "git commit --amend" over
time.

Or else I make a series of commits, then *later* squash them all
together using 'git merge --squash' or 'git rebase -i'.

It seems like the suggested feature would encourage people to do it
the "wrong" way (not creating temporary commits, thus making it easy
to make a mistake and blow things away) just because they aren't aware
of the above options.

Is there a reason that these methods don't work for you?

Thanks,

Avery

  reply	other threads:[~2010-03-30  4:32 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-03-28 19:32 [GSoC Proposal/RFC] Rolling commit message writing Daniel Thomas
2010-03-29 20:31 ` Avery Pennarun
2010-03-30  3:05   ` Jonathan Nieder
2010-03-30  4:32     ` Avery Pennarun [this message]
2010-03-30  5:02       ` the careless committer and fear of commitment (rebase -i vs add -p) Jonathan Nieder
2010-03-30  6:14         ` Ramkumar Ramachandra
2010-03-30 17:27   ` [GSoC Proposal/RFC] Rolling commit message writing Jeff King
2010-03-30 22:34 Daniel Thomas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=32541b131003292132q10db3c5eh1bb6443d625fcb82@mail.gmail.com \
    --to=apenwarr@gmail.com \
    --cc=drt24@srcf.ucam.org \
    --cc=git@vger.kernel.org \
    --cc=jrnieder@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.