* [PATCH] fs/seq_file: Fix a string literal in seq_read()
@ 2020-03-14 13:32 ` Markus Elfring
0 siblings, 0 replies; 2+ messages in thread
From: Markus Elfring @ 2020-03-14 13:32 UTC (permalink / raw)
To: linux-fsdevel, Alexander Viro, Andrew Morton, Stephen Rothwell,
Vasily Averin
Cc: LKML, kernel-janitors, Davidlohr Bueso, Ingo Molnar,
Manfred Spraul, Neil Brown, Peter Oberparleiter, Qian Cai,
Steven Rostedt, Waiman Long
From: Markus Elfring <elfring@users.sourceforge.net>
Date: Sat, 14 Mar 2020 14:14:19 +0100
* Improve a message a bit.
* The script “checkpatch.pl” pointed information out like the following.
WARNING: quoted string split across lines
Thus fix the affected source code place.
Fixes: defeadd3551c5565fbc76c97d6e99378b8acb1bf ("seq_read-info-message-about-buggy-next-functions-fix")
Fixes: c828e17c5312095fc25bbe78b16e97e99af72b9a ("fs/seq_file.c: seq_read(): add info message about buggy .next functions")
Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
---
fs/seq_file.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/fs/seq_file.c b/fs/seq_file.c
index d2a3dc5b9f3d..85cee24d36e8 100644
--- a/fs/seq_file.c
+++ b/fs/seq_file.c
@@ -257,9 +257,8 @@ ssize_t seq_read(struct file *file, char __user *buf, size_t size, loff_t *ppos)
p = m->op->next(m, p, &m->index);
if (pos == m->index) {
- pr_info_ratelimited("buggy seq_file .next function %ps "
- "did not updated position index\n",
- m->op->next);
+ pr_info_ratelimited("buggy seq_file .next function %ps did not update position index\n",
+ m->op->next);
m->index++;
}
if (!p || IS_ERR(p)) {
--
2.25.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* [PATCH] fs/seq_file: Fix a string literal in seq_read()
@ 2020-03-14 13:32 ` Markus Elfring
0 siblings, 0 replies; 2+ messages in thread
From: Markus Elfring @ 2020-03-14 13:32 UTC (permalink / raw)
To: linux-fsdevel, Alexander Viro, Andrew Morton, Stephen Rothwell,
Vasily Averin
Cc: LKML, kernel-janitors, Davidlohr Bueso, Ingo Molnar,
Manfred Spraul, Neil Brown, Peter Oberparleiter, Qian Cai,
Steven Rostedt, Waiman Long
From: Markus Elfring <elfring@users.sourceforge.net>
Date: Sat, 14 Mar 2020 14:14:19 +0100
* Improve a message a bit.
* The script “checkpatch.pl” pointed information out like the following.
WARNING: quoted string split across lines
Thus fix the affected source code place.
Fixes: defeadd3551c5565fbc76c97d6e99378b8acb1bf ("seq_read-info-message-about-buggy-next-functions-fix")
Fixes: c828e17c5312095fc25bbe78b16e97e99af72b9a ("fs/seq_file.c: seq_read(): add info message about buggy .next functions")
Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
---
fs/seq_file.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/fs/seq_file.c b/fs/seq_file.c
index d2a3dc5b9f3d..85cee24d36e8 100644
--- a/fs/seq_file.c
+++ b/fs/seq_file.c
@@ -257,9 +257,8 @@ ssize_t seq_read(struct file *file, char __user *buf, size_t size, loff_t *ppos)
p = m->op->next(m, p, &m->index);
if (pos == m->index) {
- pr_info_ratelimited("buggy seq_file .next function %ps "
- "did not updated position index\n",
- m->op->next);
+ pr_info_ratelimited("buggy seq_file .next function %ps did not update position index\n",
+ m->op->next);
m->index++;
}
if (!p || IS_ERR(p)) {
--
2.25.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-03-15 4:06 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-03-14 13:32 [PATCH] fs/seq_file: Fix a string literal in seq_read() Markus Elfring
2020-03-14 13:32 ` Markus Elfring
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.