Re: btrfs-progs

Re: btrfs-progs

[James Daniel Smith]

On April 19, 2012 04:16:05 PM you wrote:

Here are a couple of cleanup patches. Please apply newline first.

Thanks!

-- 
James Smith

CT.Networks
I.T. Consultant / Networking Systems Analyst
smithjd15@gmail.com

Sorry about the double-send, html mail was supposed to have been rejected.

-- 
James Smith

CT.Networks
I.T. Consultant / Networking Systems Analyst
smithjd15@gmail.com

btrfs-progs

[James Daniel Smith]

[-- Attachment #1: Type: text/plain, Size: 169 bytes --]

Here are a couple of cleanup patches. Please apply newline first.

Thanks!

-- 
James Smith

CT.Networks
I.T. Consultant / Networking Systems Analyst
smithjd15@gmail.com

[-- Attachment #2: btrfscleanup.diff --]
[-- Type: text/x-patch, Size: 1136 bytes --]

--- btrfs-progs/btrfs.c	2012-04-19 15:34:20.188146191 -0600
+++ btrfs.c	2012-04-19 15:37:43.680140829 -0600
@@ -105,7 +105,7 @@
 	{ do_resize, 2,
 	  "filesystem resize", "[+/-]<newsize>[gkm]|max <filesystem>\n"
 		"Resize the file system. If 'max' is passed, the filesystem\n"
-		"will occupe all available space on the device.",
+		"will occupy all available space on the device.",
 	  NULL
 	},
 	{ do_show_filesystem, 999,
@@ -155,7 +155,7 @@
 	},
 	{ do_scan, 999, 
 	  "device scan", "[<device>...]\n"
-		"Scan all device for or the passed device for a btrfs\n"
+		"Scan all devices or the passed device for a btrfs\n"
 		"filesystem.",
 	  NULL
 	},
@@ -171,12 +171,12 @@
 	},
 	{ do_ino_to_path, -2,
 	  "inspect-internal inode-resolve", "[-v] <inode> <path>\n"
-		"get file system paths for the given inode.\n",
+		"Get file system paths for the given inode.\n",
 	  NULL
 	},
 	{ do_logical_to_ino, -2,
 	  "inspect-internal logical-resolve", "[-v] [-P] <logical> <path>\n"
-		"get file system paths for the given logical address.\n",
+		"Get file system paths for the given logical address.\n",
 	  NULL
 	},
 	{ 0, 0, 0, 0 }

[-- Attachment #3: btrfsnewline.diff --]
[-- Type: text/x-patch, Size: 677 bytes --]

--- btrfs-progs/btrfs.c	2012-04-19 15:34:20.188146191 -0600
+++ btrfs.c	2012-04-19 15:40:43.681136087 -0600
@@ -95,7 +95,7 @@
 		"-t size    minimal size of file to be considered for defragmenting\n"
 	},
 	{ do_get_default_subvol, 1, "subvolume get-default", "<path>\n"
-		"get the default subvolume of a filesystem."
+		"get the default subvolume of a filesystem.\n"
 	},
 	{ do_fssync, 1,
 	  "filesystem sync", "<path>\n"
@@ -171,7 +171,7 @@
 	},
 	{ do_ino_to_path, -2,
 	  "inspect-internal inode-resolve", "[-v] <inode> <path>\n"
-		"get file system paths for the given inode.",
+		"get file system paths for the given inode.\n",
 	  NULL
 	},
 	{ do_logical_to_ino, -2,

Re: btrfs-progs

[Leonidas Spyropoulos]

Hi,

On Tue, Nov 1, 2011 at 4:34 PM, Andrew Benton <b3nton@gmail.com> wrote:
> Hello,
>
> I've just pulled btrfs-progs from the new git repo
> git://git.kernel.org/pub/scm/linux/kernel/git/mason/btrfs-progs.git
> However, when I come to make it fails like so:
>
> gcc -Wp,-MMD,./.btrfsctl.o.d,-MT,btrfsctl.o -Wall -D_FILE_OFFSET_BITS=
=3D64 -D_FORTIFY_SOURCE=3D2 -g -Werror -Os -c btrfsctl.c
> gcc -g -Werror -Os -o btrfsctl btrfsctl.o ctree.o disk-io.o radix-tre=
e.o extent-tree.o print-tree.o root-tree.o dir-item.o file-item.o inode=
-item.o inode-map.o crc32c.o rbtree.o extent-cache.o extent_io.o volume=
s.o utils.o btrfs-list.o btrfslabel.o =A0-luuid
> ls mkfs.c
> mkfs.c
> gcc -Wp,-MMD,./.mkfs.o.d,-MT,mkfs.o -Wall -D_FILE_OFFSET_BITS=3D64 -D=
_FORTIFY_SOURCE=3D2 -g -Werror -Os -c mkfs.c
> mkfs.c:39:24: fatal error: attr/xattr.h: No such file or directory
> compilation terminated.
> make: *** [mkfs.o] Error 1
> andy@eccles:~/btrfs-progs$
>
> Is attr a required dependency of btrfs-progs now?
> If I sed -i 's#attr/#sys/#' mkfs.c then it compiles and installs (I'v=
e
> not tried to use any of the tools yet). Is it wise to do this? I don'=
t
> use any extended attributes, I don't have extended attributes enabled
> in my kernel config, I have no wish to install libattr.
>
> Please CC me as I'm not subscribed,

I just cloned the repo and compiled it without problems on an
up-to-date Archlinux x86-64 system

As far as dependencies the only one needed is: libuuid
Quoting the INSTALL file:
=2E..
The Btrfs utility programs require libuuid to build.  This can be
found in the e2fsprogs sources, and is usually available as libuuid or
e2fsprogs-devel from various distros.
=2E..

As for the xattr.h file I searched my system and I am guessing my
compilation it's using the file located in /usr/include/attr/xattr.h
(because I got multiple ones in different locations)
This seems to be coming from attr package.
pkgfile /usr/include/attr/xattr.h
core/attr

But searching for this file outside that path it seems like the
linux-headers contain it as well.
So it could be a solution to use the one from the headers?

Maybe someone else can light a bit more some corners of my procedure. :=
)

Hope I helped.

Leonidas
>
> Andy
> --
> To unsubscribe from this list: send the line "unsubscribe linux-btrfs=
" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at =A0http://vger.kernel.org/majordomo-info.html
>



--=20
Caution: breathing may be hazardous to your health.
--
To unsubscribe from this list: send the line "unsubscribe linux-btrfs" =
in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

btrfs-progs

[Andrew Benton]

Hello,

I've just pulled btrfs-progs from the new git repo
git://git.kernel.org/pub/scm/linux/kernel/git/mason/btrfs-progs.git
However, when I come to make it fails like so:

gcc -Wp,-MMD,./.btrfsctl.o.d,-MT,btrfsctl.o -Wall -D_FILE_OFFSET_BITS=64 -D_FORTIFY_SOURCE=2 -g -Werror -Os -c btrfsctl.c
gcc -g -Werror -Os -o btrfsctl btrfsctl.o ctree.o disk-io.o radix-tree.o extent-tree.o print-tree.o root-tree.o dir-item.o file-item.o inode-item.o inode-map.o crc32c.o rbtree.o extent-cache.o extent_io.o volumes.o utils.o btrfs-list.o btrfslabel.o  -luuid
ls mkfs.c
mkfs.c
gcc -Wp,-MMD,./.mkfs.o.d,-MT,mkfs.o -Wall -D_FILE_OFFSET_BITS=64 -D_FORTIFY_SOURCE=2 -g -Werror -Os -c mkfs.c
mkfs.c:39:24: fatal error: attr/xattr.h: No such file or directory
compilation terminated.
make: *** [mkfs.o] Error 1
andy@eccles:~/btrfs-progs$ 

Is attr a required dependency of btrfs-progs now?
If I sed -i 's#attr/#sys/#' mkfs.c then it compiles and installs (I've
not tried to use any of the tools yet). Is it wise to do this? I don't
use any extended attributes, I don't have extended attributes enabled
in my kernel config, I have no wish to install libattr.

Please CC me as I'm not subscribed,

Andy

Re: btrfs-progs

[Hugo Mills]

[-- Attachment #1: Type: text/plain, Size: 824 bytes --]

On Sun, Aug 28, 2011 at 12:29:18AM +0100, Andrew Benton wrote:
> I've just done a git pull from 
> git://git.kernel.org/pub/scm/linux/kernel/git/mason/btrfs-progs-unstable.git
> and looking at git log, the last commit was on Wed Oct 6 09:53:38 2010,
> nearly a year ago. Is this project still maintained?

   See the section on the wiki about the userspace tools:

https://btrfs.wiki.kernel.org/index.php/Btrfs_source_repositories#btrfs-progs_Git_Repository

(Specifically the next bit, about the integration repo)

   Hugo.

-- 
=== Hugo Mills: hugo@... carfax.org.uk | darksatanic.net | lug.org.uk ===
  PGP key: 515C238D from wwwkeys.eu.pgp.net or http://www.carfax.org.uk
    --- But somewhere along the line, it seems / That pimp became ---    
                       cool,  and punk mainstream.                       

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 190 bytes --]

btrfs-progs

[Andrew Benton]

Hello World!

I've just done a git pull from 
git://git.kernel.org/pub/scm/linux/kernel/git/mason/btrfs-progs-unstable.git
and looking at git log, the last commit was on Wed Oct 6 09:53:38 2010,
nearly a year ago. Is this project still maintained?

Andy