* [bug report after v4.5-rc1]block: When the scsi device has a timeout IO, the scsi device is stuck when it is deleted
@ 2017-11-02 12:16 Zouming (IT)
2017-11-02 12:33 ` chenxiang (M)
0 siblings, 1 reply; 3+ messages in thread
From: Zouming (IT) @ 2017-11-02 12:16 UTC (permalink / raw)
To: linux-block, axboe; +Cc: wangzhoumengjian
MS5SZXBlYXQgc3RlcHM6IA0KKDEpIHNlbmQgSU8gb24gdGhlIGRldmljZSAvZGV2L3NkeC4gDQoo
MikgU2ltdWxhdGUgYW4gSU8gbG9zdA0KKDMpIFVzZSB0aGUgY29tbWFuZCBiZWZvcmUgdG8gwqBk
ZWxldGUgc2NzaSBkZXZpY2XCoCBiZWZvcmUgSU8gdGltZW91dA0KwqAgwqAgwqAgZWhjbyAxID4g
L3N5cy9jbGFzcy9zZHgvZGV2aWNlL2RlbGV0ZSANCg0KMi5UaGUgc3RhY2sgb2YgZGVsZXRlIHRo
ZWFkIGlzIGJlZm9yZTogDQpbPGZmZmZmZmZmODEwOTk5ZWY+XSBtc2xlZXArMHgyZi8weDQwIA0K
WzxmZmZmZmZmZjgxMmY3OGI0Pl0gX19ibGtfZHJhaW5fcXVldWUrMHhhNC8weDE3MCANCls8ZmZm
ZmZmZmY4MTJmN2JmZD5dIGJsa19jbGVhbnVwX3F1ZXVlKzB4MTNkLzB4MTUwIA0KWzxmZmZmZmZm
ZjgxNDczZDJhPl0gX19zY3NpX3JlbW92ZV9kZXZpY2UrMHg0YS8weGQwIA0KWzxmZmZmZmZmZjgx
NDczZGQ2Pl0gc2NzaV9yZW1vdmVfZGV2aWNlKzB4MjYvMHg0MCANCls8ZmZmZmZmZmY4MTQ3M2Uw
NT5dIHNkZXZfc3RvcmVfZGVsZXRlX2NhbGxiYWNrKzB4MTUvMHgyMCANCls8ZmZmZmZmZmY4MTI3
ZmRjND5dIHN5c2ZzX3NjaGVkdWxlX2NhbGxiYWNrX3dvcmsrMHgxNC8weDYwIA0KWzxmZmZmZmZm
ZjgxMGE4ODFhPl0gcHJvY2Vzc19vbmVfd29yaysweDE3YS8weDQ0MCANCls8ZmZmZmZmZmY4MTBh
OTRlNj5dIHdvcmtlcl90aHJlYWQrMHgxMjYvMHgzYzAgDQpbPGZmZmZmZmZmODEwYjA5OGY+XSBr
dGhyZWFkKzB4Y2YvMHhlMCANCls8ZmZmZmZmZmY4MTZiNGYxOD5dIHJldF9mcm9tX2ZvcmsrMHg1
OC8weDkwwqAgDQoNCjMuVGhlIHJlYXNvbiBpcyBiZWZvcmU6IA0KwqAgKDEpIFdoZW4gdGhlIHNj
c2kgZGV2aWNlIGlzIGRlbGV0ZWQsIGludm9rZcKgYmxrX2NsZWFudXBfcXVldWUgZnVudGlvbiB0
byANCsKgIMKgIMKgIMKgIHNldCB0aGUgZmxhZyBvZiByZXF1ZXN0X3F1ZXVlIGR5aW5nLCBhbmQg
d2FpdCBhbGwgSU8gYmFjay4gDQoNCsKgICgyKSB3aGVuIElPIHRpbW91dCx0aGUgdGltZW91dCB3
b3JrcXVldWUgaW52b2tlIGJsa190aW1lb3V0X3dvcmvCoGZ1bmN0aW9uIHRvIGFib3J0IElPLCAN
CsKgIMKgIMKgIMKgYnV0IGl0IHdpbGwgbm90IGFib3J0IHRoZSBJTyBiZWNhdXNlIGl0IGNhbGwg
wqBibGtfcXVldWVfZW50ZXIgZnVudGlvbsKgIA0KwqAgwqAgwqAgwqBqdWRnZSB0aGUgcmVxdWVz
dF9xdWV1ZSBpcyBkeWluZyBhbmQgcmV0dXJuIGRpcmVjdCB3aXRob3V0IGRvaW5nIGFueXRoaW5n
LiANCg0K
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [bug report after v4.5-rc1]block: When the scsi device has a timeout IO, the scsi device is stuck when it is deleted
2017-11-02 12:16 [bug report after v4.5-rc1]block: When the scsi device has a timeout IO, the scsi device is stuck when it is deleted Zouming (IT)
@ 2017-11-02 12:33 ` chenxiang (M)
2017-11-02 12:54 ` 答复: " Zouming (IT)
0 siblings, 1 reply; 3+ messages in thread
From: chenxiang (M) @ 2017-11-02 12:33 UTC (permalink / raw)
To: Zouming (IT), linux-block, axboe; +Cc: wangzhoumengjian
在 2017/11/2 20:16, Zouming (IT) 写道:
> 1.Repeat steps:
> (1) send IO on the device /dev/sdx.
> (2) Simulate an IO lost
> (3) Use the command before to delete scsi device before IO timeout
> ehco 1 > /sys/class/sdx/device/delete
>
> 2.The stack of delete thead is before:
> [<ffffffff810999ef>] msleep+0x2f/0x40
> [<ffffffff812f78b4>] __blk_drain_queue+0xa4/0x170
> [<ffffffff812f7bfd>] blk_cleanup_queue+0x13d/0x150
> [<ffffffff81473d2a>] __scsi_remove_device+0x4a/0xd0
> [<ffffffff81473dd6>] scsi_remove_device+0x26/0x40
> [<ffffffff81473e05>] sdev_store_delete_callback+0x15/0x20
> [<ffffffff8127fdc4>] sysfs_schedule_callback_work+0x14/0x60
> [<ffffffff810a881a>] process_one_work+0x17a/0x440
> [<ffffffff810a94e6>] worker_thread+0x126/0x3c0
> [<ffffffff810b098f>] kthread+0xcf/0xe0
> [<ffffffff816b4f18>] ret_from_fork+0x58/0x90
>
> 3.The reason is before:
> (1) When the scsi device is deleted, invoke blk_cleanup_queue funtion to
> set the flag of request_queue dying, and wait all IO back.
>
> (2) when IO timout,the timeout workqueue invoke blk_timeout_work function to abort IO,
> but it will not abort the IO because it call blk_queue_enter funtion
> judge the request_queue is dying and return direct without doing anything.
Hi Zouming,
You can have a test on Bart's patch "[PATCH] block: Fix a race between
blk_cleanup_queue() and timeout handling" for this issue.
I think this patch can solve your issue.
^ permalink raw reply [flat|nested] 3+ messages in thread
* 答复: [bug report after v4.5-rc1]block: When the scsi device has a timeout IO, the scsi device is stuck when it is deleted
2017-11-02 12:33 ` chenxiang (M)
@ 2017-11-02 12:54 ` Zouming (IT)
0 siblings, 0 replies; 3+ messages in thread
From: Zouming (IT) @ 2017-11-02 12:54 UTC (permalink / raw)
To: chenxiang (M), linux-block, axboe; +Cc: wangzhoumengjian
T0ssM2tzLg0KDQotLS0tLemCruS7tuWOn+S7ti0tLS0tDQrlj5Hku7bkuro6IGNoZW54aWFuZyAo
TSkgDQrlj5HpgIHml7bpl7Q6IDIwMTflubQxMeaciDLml6UgMjA6MzQNCuaUtuS7tuS6ujogWm91
bWluZyAoSVQpIDx6b3VtaW5nLnpvdW1pbmdAaHVhd2VpLmNvbT47IGxpbnV4LWJsb2NrQHZnZXIu
a2VybmVsLm9yZzsgYXhib2VAZmIuY29tDQrmioTpgIE6IHdhbmd6aG91bWVuZ2ppYW4gPHdhbmd6
aG91bWVuZ2ppYW5AaHVhd2VpLmNvbT4NCuS4u+mimDogUmU6IFtidWcgcmVwb3J0IGFmdGVyIHY0
LjUtcmMxXWJsb2NrOiBXaGVuIHRoZSBzY3NpIGRldmljZSBoYXMgYSB0aW1lb3V0IElPLCB0aGUg
c2NzaSBkZXZpY2UgaXMgc3R1Y2sgd2hlbiBpdCBpcyBkZWxldGVkDQoNCuWcqCAyMDE3LzExLzIg
MjA6MTYsIFpvdW1pbmcgKElUKSDlhpnpgZM6DQo+IDEuUmVwZWF0IHN0ZXBzOg0KPiAoMSkgc2Vu
ZCBJTyBvbiB0aGUgZGV2aWNlIC9kZXYvc2R4Lg0KPiAoMikgU2ltdWxhdGUgYW4gSU8gbG9zdA0K
PiAoMykgVXNlIHRoZSBjb21tYW5kIGJlZm9yZSB0byAgZGVsZXRlIHNjc2kgZGV2aWNlICBiZWZv
cmUgSU8gdGltZW91dA0KPiAgICAgICAgZWhjbyAxID4gL3N5cy9jbGFzcy9zZHgvZGV2aWNlL2Rl
bGV0ZQ0KPg0KPiAyLlRoZSBzdGFjayBvZiBkZWxldGUgdGhlYWQgaXMgYmVmb3JlOg0KPiBbPGZm
ZmZmZmZmODEwOTk5ZWY+XSBtc2xlZXArMHgyZi8weDQwDQo+IFs8ZmZmZmZmZmY4MTJmNzhiND5d
IF9fYmxrX2RyYWluX3F1ZXVlKzB4YTQvMHgxNzAgWzxmZmZmZmZmZjgxMmY3YmZkPl0gDQo+IGJs
a19jbGVhbnVwX3F1ZXVlKzB4MTNkLzB4MTUwIFs8ZmZmZmZmZmY4MTQ3M2QyYT5dIA0KPiBfX3Nj
c2lfcmVtb3ZlX2RldmljZSsweDRhLzB4ZDAgWzxmZmZmZmZmZjgxNDczZGQ2Pl0gDQo+IHNjc2lf
cmVtb3ZlX2RldmljZSsweDI2LzB4NDAgWzxmZmZmZmZmZjgxNDczZTA1Pl0gDQo+IHNkZXZfc3Rv
cmVfZGVsZXRlX2NhbGxiYWNrKzB4MTUvMHgyMA0KPiBbPGZmZmZmZmZmODEyN2ZkYzQ+XSBzeXNm
c19zY2hlZHVsZV9jYWxsYmFja193b3JrKzB4MTQvMHg2MA0KPiBbPGZmZmZmZmZmODEwYTg4MWE+
XSBwcm9jZXNzX29uZV93b3JrKzB4MTdhLzB4NDQwIFs8ZmZmZmZmZmY4MTBhOTRlNj5dIA0KPiB3
b3JrZXJfdGhyZWFkKzB4MTI2LzB4M2MwIFs8ZmZmZmZmZmY4MTBiMDk4Zj5dIGt0aHJlYWQrMHhj
Zi8weGUwIA0KPiBbPGZmZmZmZmZmODE2YjRmMTg+XSByZXRfZnJvbV9mb3JrKzB4NTgvMHg5MA0K
Pg0KPiAzLlRoZSByZWFzb24gaXMgYmVmb3JlOg0KPiAgICAoMSkgV2hlbiB0aGUgc2NzaSBkZXZp
Y2UgaXMgZGVsZXRlZCwgaW52b2tlIGJsa19jbGVhbnVwX3F1ZXVlIGZ1bnRpb24gdG8NCj4gICAg
ICAgICAgc2V0IHRoZSBmbGFnIG9mIHJlcXVlc3RfcXVldWUgZHlpbmcsIGFuZCB3YWl0IGFsbCBJ
TyBiYWNrLg0KPg0KPiAgICAoMikgd2hlbiBJTyB0aW1vdXQsdGhlIHRpbWVvdXQgd29ya3F1ZXVl
IGludm9rZSBibGtfdGltZW91dF93b3JrIGZ1bmN0aW9uIHRvIGFib3J0IElPLA0KPiAgICAgICAg
IGJ1dCBpdCB3aWxsIG5vdCBhYm9ydCB0aGUgSU8gYmVjYXVzZSBpdCBjYWxsICBibGtfcXVldWVf
ZW50ZXIgZnVudGlvbg0KPiAgICAgICAgIGp1ZGdlIHRoZSByZXF1ZXN0X3F1ZXVlIGlzIGR5aW5n
IGFuZCByZXR1cm4gZGlyZWN0IHdpdGhvdXQgZG9pbmcgYW55dGhpbmcuDQoNCkhpIFpvdW1pbmcs
DQpZb3UgY2FuIGhhdmUgYSB0ZXN0IG9uIEJhcnQncyBwYXRjaCAiW1BBVENIXSBibG9jazogRml4
IGEgcmFjZSBiZXR3ZWVuDQpibGtfY2xlYW51cF9xdWV1ZSgpIGFuZCB0aW1lb3V0IGhhbmRsaW5n
IiBmb3IgdGhpcyBpc3N1ZS4NCkkgdGhpbmsgdGhpcyBwYXRjaCBjYW4gc29sdmUgeW91ciBpc3N1
ZS4NCg0KDQoNCg==
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-11-02 12:54 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-11-02 12:16 [bug report after v4.5-rc1]block: When the scsi device has a timeout IO, the scsi device is stuck when it is deleted Zouming (IT)
2017-11-02 12:33 ` chenxiang (M)
2017-11-02 12:54 ` 答复: " Zouming (IT)
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.