All of lore.kernel.org
 help / color / mirror / Atom feed
From: Philippe Gerum <rpm@xenomai.org>
To: Jan Kiszka <jan.kiszka@siemens.com>, xenomai@xenomai.org
Subject: Re: [Xenomai] [PATCH] cobalt/kernel: always use explicit preprocessor conditionals
Date: Wed, 5 Sep 2018 10:16:13 +0200	[thread overview]
Message-ID: <32880d1f-2a02-57bd-3465-9ebb0aee9aca@xenomai.org> (raw)
In-Reply-To: <7bf36155-eb1a-30a3-42ce-5256342dc74f@siemens.com>

On 09/04/2018 07:48 PM, Jan Kiszka wrote:
>> diff --git a/kernel/cobalt/synch.c b/kernel/cobalt/synch.c
>> index 7773a08e5..32df635a8 100644
>> --- a/kernel/cobalt/synch.c
>> +++ b/kernel/cobalt/synch.c
>> @@ -902,7 +902,7 @@ void xnsynch_release_all_ownerships(struct
>> xnthread *thread)
>>   }
>>   EXPORT_SYMBOL_GPL(xnsynch_release_all_ownerships);
>>   -#if XENO_DEBUG(MUTEX_RELAXED)
>> +#ifdef CONFIG_XENO_OPT_DEBUG_MUTEX_RELAXED
>>     /*
>>    * Detect when a thread is about to sleep on a synchronization
>>
> 
> Confused: This is not for next, is it?
> 
> E.g. that hunk above does not apply there anymore, for about a year...
> 

Something looks wrong here. The three patches apply on commit #e23d58715
[1] at [2], which is on top of stable/v3.0.x, post-3.0.7 material. Which
tree/branch are you looking at?


[1]
commit e23d587156f138a8f9bff648e310427127a98cfc (origin/stable/v3.0.x)
Author: Sebastian Smolorz <sebastian.smolorz@gmx.de>
Date:   Thu Aug 16 21:10:00 2018 +0200

    net: Split internal rtnet.h and install rtdm/net.h and rtdm/uapi/net.h

    For external projects wanting to use RTnet with its special
    features like RTnet IOCTLs it is necessary to provide the API
    headers in the Xenomai installation directory.

[2] https://gitlab.denx.de/Xenomai/xenomai/commits/stable/v3.0.x

-- 
Philippe.


  parent reply	other threads:[~2018-09-05  8:16 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-09-04 13:31 [Xenomai] [PATCH] cobalt/kernel: always use explicit preprocessor conditionals Philippe Gerum
2018-09-04 17:48 ` Jan Kiszka
2018-09-05  7:44   ` Philippe Gerum
2018-09-05  7:48     ` Philippe Gerum
2018-09-05  7:57       ` Jan Kiszka
2018-09-05  8:16   ` Philippe Gerum [this message]
2018-09-05  8:34     ` Jan Kiszka
2018-09-05  9:33       ` Philippe Gerum
2018-09-05  9:44         ` Jan Kiszka
2018-09-05 10:22           ` Philippe Gerum
2018-09-24 13:52 ` Jan Kiszka
2018-09-24 14:03   ` Philippe Gerum
2018-09-25 11:47     ` Jan Kiszka
2018-09-25 13:10       ` Philippe Gerum

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=32880d1f-2a02-57bd-3465-9ebb0aee9aca@xenomai.org \
    --to=rpm@xenomai.org \
    --cc=jan.kiszka@siemens.com \
    --cc=xenomai@xenomai.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.