From: Philippe Gerum <rpm@xenomai.org>
To: Jan Kiszka <jan.kiszka@siemens.com>, xenomai@xenomai.org
Subject: Re: [Xenomai] [PATCH] cobalt/kernel: always use explicit preprocessor conditionals
Date: Mon, 24 Sep 2018 16:03:17 +0200 [thread overview]
Message-ID: <d2ae4167-c52b-5f3e-ecfb-57f69fc9015a@xenomai.org> (raw)
In-Reply-To: <77d089a2-a261-c90f-ef54-83c107a3f606@siemens.com>
On 09/24/2018 03:52 PM, Jan Kiszka wrote:
> On 04.09.18 15:31, Philippe Gerum wrote:
>> Testing debug switches using '#if XENO_DEBUG(<feat>)' may confuse the
>> build system's dependency tracker, breaking the build, or even
>> producing a non-bootable kernel in extreme cases. Typically, turning
>> on/off the lock debugging code - usually in absence of any other
>> change - may cause the following error to pop up at the link stage:
>>
[snip]
>
> I've picked this one now as stable backport to our 3.0.x branch. I'm not
> that sure we should put the other two ("cobalt/sched: improve watchdog
> accuracy", "cobalt/sched: group high-level init/cleanup code") there as
> well, though.
>
We don't need the second one in stable for sure. Merging the first one
there would be beneficial to people who want timeouts shorter than 4s.
E.g. one just cannot use the watchdog feature with a 1s timeout, false
positives would trigger almost immediately even with mildly busy rt systems.
This said, the only report I got (unfortunately privately) about such
issue was only a few weeks ago, so this problem does not look like
affecting many people.
--
Philippe.
next prev parent reply other threads:[~2018-09-24 14:03 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-04 13:31 [Xenomai] [PATCH] cobalt/kernel: always use explicit preprocessor conditionals Philippe Gerum
2018-09-04 17:48 ` Jan Kiszka
2018-09-05 7:44 ` Philippe Gerum
2018-09-05 7:48 ` Philippe Gerum
2018-09-05 7:57 ` Jan Kiszka
2018-09-05 8:16 ` Philippe Gerum
2018-09-05 8:34 ` Jan Kiszka
2018-09-05 9:33 ` Philippe Gerum
2018-09-05 9:44 ` Jan Kiszka
2018-09-05 10:22 ` Philippe Gerum
2018-09-24 13:52 ` Jan Kiszka
2018-09-24 14:03 ` Philippe Gerum [this message]
2018-09-25 11:47 ` Jan Kiszka
2018-09-25 13:10 ` Philippe Gerum
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d2ae4167-c52b-5f3e-ecfb-57f69fc9015a@xenomai.org \
--to=rpm@xenomai.org \
--cc=jan.kiszka@siemens.com \
--cc=xenomai@xenomai.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.