* [PATCH linux-next] arm:nommu: fix boolreturn.cocci warnings
@ 2021-08-24 4:11 ` CGEL
0 siblings, 0 replies; 4+ messages in thread
From: CGEL @ 2021-08-24 4:11 UTC (permalink / raw)
To: Russell King
Cc: Stephen Rothwell, Andrew Morton, Ira Weiny, linux-arm-kernel,
linux-kernel, Jing Yangyang, Zeal Robot
From: Jing Yangyang <jing.yangyang@zte.com.cn>
./arch/arm/mm/nommu.c:59:8-9:WARNING:return of 0/1 in function
'security_extensions_enabled' with return type bool
Return statements in functions returning bool should use true/false
instead of 1/0.
Generated by: scripts/coccinelle/misc/boolreturn.cocci
Reported-by: Zeal Robot <zealci@zte.com.cn>
Signed-off-by: Jing Yangyang <jing.yangyang@zte.com.cn>
---
arch/arm/mm/nommu.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm/mm/nommu.c b/arch/arm/mm/nommu.c
index 2658f52..7256ac1 100644
--- a/arch/arm/mm/nommu.c
+++ b/arch/arm/mm/nommu.c
@@ -56,7 +56,7 @@ static inline bool security_extensions_enabled(void)
if ((read_cpuid_id() & 0x000f0000) == 0x000f0000)
return cpuid_feature_extract(CPUID_EXT_PFR1, 4) ||
cpuid_feature_extract(CPUID_EXT_PFR1, 20);
- return 0;
+ return false;
}
unsigned long setup_vectors_base(void)
--
1.8.3.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH linux-next] arm:nommu: fix boolreturn.cocci warnings
@ 2021-08-24 4:11 ` CGEL
0 siblings, 0 replies; 4+ messages in thread
From: CGEL @ 2021-08-24 4:11 UTC (permalink / raw)
To: Russell King
Cc: Stephen Rothwell, Andrew Morton, Ira Weiny, linux-arm-kernel,
linux-kernel, Jing Yangyang, Zeal Robot
From: Jing Yangyang <jing.yangyang@zte.com.cn>
./arch/arm/mm/nommu.c:59:8-9:WARNING:return of 0/1 in function
'security_extensions_enabled' with return type bool
Return statements in functions returning bool should use true/false
instead of 1/0.
Generated by: scripts/coccinelle/misc/boolreturn.cocci
Reported-by: Zeal Robot <zealci@zte.com.cn>
Signed-off-by: Jing Yangyang <jing.yangyang@zte.com.cn>
---
arch/arm/mm/nommu.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm/mm/nommu.c b/arch/arm/mm/nommu.c
index 2658f52..7256ac1 100644
--- a/arch/arm/mm/nommu.c
+++ b/arch/arm/mm/nommu.c
@@ -56,7 +56,7 @@ static inline bool security_extensions_enabled(void)
if ((read_cpuid_id() & 0x000f0000) == 0x000f0000)
return cpuid_feature_extract(CPUID_EXT_PFR1, 4) ||
cpuid_feature_extract(CPUID_EXT_PFR1, 20);
- return 0;
+ return false;
}
unsigned long setup_vectors_base(void)
--
1.8.3.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH linux-next] arm:nommu: fix boolreturn.cocci warnings
2021-08-24 4:11 ` CGEL
@ 2021-08-24 8:25 ` Vladimir Murzin
-1 siblings, 0 replies; 4+ messages in thread
From: Vladimir Murzin @ 2021-08-24 8:25 UTC (permalink / raw)
To: CGEL, Russell King
Cc: Stephen Rothwell, Andrew Morton, Ira Weiny, linux-arm-kernel,
linux-kernel, Jing Yangyang, Zeal Robot, denghuilong
On 8/24/21 5:11 AM, CGEL wrote:
> From: Jing Yangyang <jing.yangyang@zte.com.cn>
>
> ./arch/arm/mm/nommu.c:59:8-9:WARNING:return of 0/1 in function
> 'security_extensions_enabled' with return type bool
>
> Return statements in functions returning bool should use true/false
> instead of 1/0.
>
> Generated by: scripts/coccinelle/misc/boolreturn.cocci
>
> Reported-by: Zeal Robot <zealci@zte.com.cn>
> Signed-off-by: Jing Yangyang <jing.yangyang@zte.com.cn>
> ---
> arch/arm/mm/nommu.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm/mm/nommu.c b/arch/arm/mm/nommu.c
> index 2658f52..7256ac1 100644
> --- a/arch/arm/mm/nommu.c
> +++ b/arch/arm/mm/nommu.c
> @@ -56,7 +56,7 @@ static inline bool security_extensions_enabled(void)
> if ((read_cpuid_id() & 0x000f0000) == 0x000f0000)
> return cpuid_feature_extract(CPUID_EXT_PFR1, 4) ||
> cpuid_feature_extract(CPUID_EXT_PFR1, 20);
> - return 0;
> + return false;
> }
>
> unsigned long setup_vectors_base(void)
>
The same patch was sent before [1] by Huilong Deng. It was reviewed
and author was advised to submit it into RMK's Patch system.
[1] https://lore.kernel.org/linux-arm-kernel/1e30b659-a91a-58f6-f9aa-d0f0259eb9e8@arm.com/T/#t
Cheers
Vladimir
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH linux-next] arm:nommu: fix boolreturn.cocci warnings
@ 2021-08-24 8:25 ` Vladimir Murzin
0 siblings, 0 replies; 4+ messages in thread
From: Vladimir Murzin @ 2021-08-24 8:25 UTC (permalink / raw)
To: CGEL, Russell King
Cc: Stephen Rothwell, Andrew Morton, Ira Weiny, linux-arm-kernel,
linux-kernel, Jing Yangyang, Zeal Robot, denghuilong
On 8/24/21 5:11 AM, CGEL wrote:
> From: Jing Yangyang <jing.yangyang@zte.com.cn>
>
> ./arch/arm/mm/nommu.c:59:8-9:WARNING:return of 0/1 in function
> 'security_extensions_enabled' with return type bool
>
> Return statements in functions returning bool should use true/false
> instead of 1/0.
>
> Generated by: scripts/coccinelle/misc/boolreturn.cocci
>
> Reported-by: Zeal Robot <zealci@zte.com.cn>
> Signed-off-by: Jing Yangyang <jing.yangyang@zte.com.cn>
> ---
> arch/arm/mm/nommu.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm/mm/nommu.c b/arch/arm/mm/nommu.c
> index 2658f52..7256ac1 100644
> --- a/arch/arm/mm/nommu.c
> +++ b/arch/arm/mm/nommu.c
> @@ -56,7 +56,7 @@ static inline bool security_extensions_enabled(void)
> if ((read_cpuid_id() & 0x000f0000) == 0x000f0000)
> return cpuid_feature_extract(CPUID_EXT_PFR1, 4) ||
> cpuid_feature_extract(CPUID_EXT_PFR1, 20);
> - return 0;
> + return false;
> }
>
> unsigned long setup_vectors_base(void)
>
The same patch was sent before [1] by Huilong Deng. It was reviewed
and author was advised to submit it into RMK's Patch system.
[1] https://lore.kernel.org/linux-arm-kernel/1e30b659-a91a-58f6-f9aa-d0f0259eb9e8@arm.com/T/#t
Cheers
Vladimir
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2021-08-24 8:28 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-08-24 4:11 [PATCH linux-next] arm:nommu: fix boolreturn.cocci warnings CGEL
2021-08-24 4:11 ` CGEL
2021-08-24 8:25 ` Vladimir Murzin
2021-08-24 8:25 ` Vladimir Murzin
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.