From: "Péter Ujfalusi" <peter.ujfalusi@ti.com>
To: Liam Girdwood <lrg@ti.com>
Cc: Samuel Ortiz <samuel.ortiz@intel.com>,
Dmitry Torokhov <dtor@mail.ru>,
Mark Brown <broonie@opensource.wolfsonmicro.com>,
alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org,
Misael Lopez Cruz <misael.lopez@ti.com>,
linux-input@vger.kernel.org
Subject: Re: Re: [PATCH 4/8] Input: twl6040-vibra: Check the selected path for vibra
Date: Fri, 16 Sep 2011 14:11:26 +0300 [thread overview]
Message-ID: <329048288.4sixMZXl4l@barack> (raw)
In-Reply-To: <1316165201.3229.7.camel@odin>
On Friday 16 September 2011 10:26:41 Liam Girdwood wrote:
> > + /* Do not allow effect, while the routing is set to use audio */
> > + ret = twl6040_get_vibralr_status(info->twl6040);
> > + if (ret & TWL6040_VIBSEL) {
> > + dev_info(&input->dev, "Vibra is configured for audio\n");
> > + return -EPERM;
> > + }
>
> Sorry, missed this earlier.
>
> Probably best to return -EBUSY here otherwise it may look like a device
> permissions problem to some users.
I'll change it.
Thanks,
Péter
WARNING: multiple messages have this Message-ID (diff)
From: "Péter Ujfalusi" <peter.ujfalusi@ti.com>
To: Liam Girdwood <lrg@ti.com>
Cc: Samuel Ortiz <samuel.ortiz@intel.com>,
Dmitry Torokhov <dtor@mail.ru>,
Mark Brown <broonie@opensource.wolfsonmicro.com>,
alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org,
Misael Lopez Cruz <misael.lopez@ti.com>,
linux-input@vger.kernel.org
Subject: Re: Re: [PATCH 4/8] Input: twl6040-vibra: Check the selected path for vibra
Date: Fri, 16 Sep 2011 14:11:26 +0300 [thread overview]
Message-ID: <329048288.4sixMZXl4l@barack> (raw)
In-Reply-To: <1316165201.3229.7.camel@odin>
On Friday 16 September 2011 10:26:41 Liam Girdwood wrote:
> > + /* Do not allow effect, while the routing is set to use audio */
> > + ret = twl6040_get_vibralr_status(info->twl6040);
> > + if (ret & TWL6040_VIBSEL) {
> > + dev_info(&input->dev, "Vibra is configured for audio\n");
> > + return -EPERM;
> > + }
>
> Sorry, missed this earlier.
>
> Probably best to return -EBUSY here otherwise it may look like a device
> permissions problem to some users.
I'll change it.
Thanks,
Péter
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2011-09-16 11:11 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-15 12:59 [PATCH 0/8] ASoC/MFD/Input: twl6040: Support for audio driven vibra Peter Ujfalusi
2011-09-15 12:59 ` [PATCH 1/8] Input: twl6040: Simplify vibra regsiter definitions Peter Ujfalusi
2011-09-15 12:59 ` [PATCH 2/8] MFD: twl6040: Cache the vibra control registers Peter Ujfalusi
2011-09-15 12:59 ` Peter Ujfalusi
2011-09-15 12:59 ` [PATCH 3/8] MFD: twl6040: function to query the vibra status for clients Peter Ujfalusi
2011-09-15 12:59 ` Peter Ujfalusi
2011-09-15 12:59 ` [PATCH 4/8] Input: twl6040-vibra: Check the selected path for vibra Peter Ujfalusi
2011-09-16 6:27 ` Dmitry Torokhov
2011-09-16 6:42 ` Péter Ujfalusi
2011-09-16 6:42 ` Péter Ujfalusi
2011-09-24 6:00 ` Dmitry Torokhov
2011-09-24 6:00 ` Dmitry Torokhov
2011-09-26 6:41 ` Péter Ujfalusi
2011-09-26 6:41 ` Péter Ujfalusi
2011-09-16 9:26 ` Liam Girdwood
2011-09-16 11:11 ` Péter Ujfalusi [this message]
2011-09-16 11:11 ` Péter Ujfalusi
2011-09-15 12:59 ` [PATCH 5/8] ASoC: twl6040: Fix the number of channels " Peter Ujfalusi
2011-09-19 22:17 ` [alsa-devel] " Mark Brown
2011-09-15 12:59 ` [PATCH 6/8] ASoC: twl6040: Correct supported number of playback channels Peter Ujfalusi
2011-09-19 22:17 ` [alsa-devel] " Mark Brown
2011-09-15 12:59 ` [PATCH 7/8] ASoC: omap-mcpdm: Correct the supported number of channels Peter Ujfalusi
2011-09-19 22:17 ` [alsa-devel] " Mark Brown
2011-09-19 22:17 ` Mark Brown
2011-09-20 10:57 ` [alsa-devel] " Mark Brown
2011-09-20 11:10 ` Péter Ujfalusi
2011-09-20 11:10 ` Péter Ujfalusi
2011-09-20 11:19 ` Liam Girdwood
2011-09-20 11:19 ` Liam Girdwood
2011-09-20 11:24 ` Re: Re: [alsa-devel] " Péter Ujfalusi
2011-09-20 11:24 ` Péter Ujfalusi
2011-09-20 11:35 ` Mark Brown
2011-09-20 11:35 ` Mark Brown
2011-09-15 12:59 ` [PATCH 8/8] ASoC: twl6040: Support for vibra output paths Peter Ujfalusi
2011-09-21 13:12 ` Péter Ujfalusi
2011-09-21 13:12 ` Péter Ujfalusi
2011-09-21 13:26 ` Mark Brown
2011-09-21 13:26 ` Mark Brown
2011-09-21 13:10 ` [PATCH 0/8] ASoC/MFD/Input: twl6040: Support for audio driven vibra Péter Ujfalusi
2011-09-21 13:10 ` Péter Ujfalusi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=329048288.4sixMZXl4l@barack \
--to=peter.ujfalusi@ti.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=dtor@mail.ru \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lrg@ti.com \
--cc=misael.lopez@ti.com \
--cc=samuel.ortiz@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.