[PATCH 02/11] ipath: replace open-coded ARRAY_SIZE with macro

[PATCH 02/11] ipath: replace open-coded ARRAY_SIZE with macro

[Jim Cromie]

Signed-off-by: Jim Cromie <jim.cromie-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
---
 drivers/infiniband/hw/ipath/ipath_intr.c |    3 +--
 1 files changed, 1 insertions(+), 2 deletions(-)

diff --git a/drivers/infiniband/hw/ipath/ipath_intr.c b/drivers/infiniband/hw/ipath/ipath_intr.c
index c0a03ac..26dfbc8 100644
--- a/drivers/infiniband/hw/ipath/ipath_intr.c
+++ b/drivers/infiniband/hw/ipath/ipath_intr.c
@@ -209,8 +209,7 @@ void ipath_format_hwerrors(u64 hwerrs,
 {
 	int i;
 	const int glen =
-	    sizeof(ipath_generic_hwerror_msgs) /
-	    sizeof(ipath_generic_hwerror_msgs[0]);
+	    ARRAY_SIZE(ipath_generic_hwerror_msgs);
 
 	for (i=0; i<glen; i++) {
 		if (hwerrs & ipath_generic_hwerror_msgs[i].mask) {
-- 
1.7.8.1

--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

RE: [PATCH 02/11] ipath: replace open-coded ARRAY_SIZE with macro

[Marciniszyn, Mike]

> From: Jim Cromie [mailto:jim.cromie-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org]
> Subject: [PATCH 02/11] ipath: replace open-coded ARRAY_SIZE with macro
> 
> 
> Signed-off-by: Jim Cromie <jim.cromie-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>

I noticed a similar issue in ipath_iba6110.c around line 599.

Do you want me to correct or do you want to catch it with a single patch?

Mike
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH 02/11] ipath: replace open-coded ARRAY_SIZE with macro

[Jim Cromie]

On Wed, Apr 11, 2012 at 11:13 AM, Marciniszyn, Mike
<mike.marciniszyn-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org> wrote:
>> From: Jim Cromie [mailto:jim.cromie-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org]
>> Subject: [PATCH 02/11] ipath: replace open-coded ARRAY_SIZE with macro
>>
>>
>> Signed-off-by: Jim Cromie <jim.cromie-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
>
> I noticed a similar issue in ipath_iba6110.c around line 599.
>
> Do you want me to correct or do you want to catch it with a single patch?
>
> Mike

interesting - spatch didnt do it cuz the array.cocci file
checks for <liinux/kernel.h>, and didnt find it here.

my tree is on another branch now, can you do it ?
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

RE: [PATCH 02/11] ipath: replace open-coded ARRAY_SIZE with macro

[Marciniszyn, Mike]

> From: Jim Cromie [mailto:jim.cromie-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org]
> Subject: [PATCH 02/11] ipath: replace open-coded ARRAY_SIZE with macro
> 
> Signed-off-by: Jim Cromie <jim.cromie-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>

Thanks for the patch!

Acked-by: Mike Marciniszyn <mike.marciniszyn-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html