* [PATCH i-g-t 0/4] revamp big joiner test
@ 2024-03-25 16:51 Kunal Joshi
2024-03-25 16:51 ` [PATCH i-g-t 1/4] lib/igt_kms: move bigjoiner_mode_found to lib Kunal Joshi
` (6 more replies)
0 siblings, 7 replies; 18+ messages in thread
From: Kunal Joshi @ 2024-03-25 16:51 UTC (permalink / raw)
To: igt-dev; +Cc: Pranay Samala
From: Pranay Samala <pranay.samala@intel.com>
modify test to support multiple big joiner outputs
simultaneously, support for ignoring fused pipes and
addition of subtests for testing force joiner support for
which is added by below in kmd.
drm/i915: Add bigjoiner force enable option to debugfs
Kunal Joshi (4):
lib/igt_kms: move bigjoiner_mode_found to lib
tests/intel/kms_big_joiner: revamp bigjoiner
lib/igt_kms: add helper to enable/disable force joiner
tests/intel/kms_big_joiner: add tests for force joiner
lib/igt_kms.c | 79 ++++++
lib/igt_kms.h | 4 +
tests/intel/kms_big_joiner.c | 469 ++++++++++++++++++++---------------
3 files changed, 350 insertions(+), 202 deletions(-)
--
2.34.1
^ permalink raw reply [flat|nested] 18+ messages in thread
* [PATCH i-g-t 1/4] lib/igt_kms: move bigjoiner_mode_found to lib
2024-03-25 16:51 [PATCH i-g-t 0/4] revamp big joiner test Kunal Joshi
@ 2024-03-25 16:51 ` Kunal Joshi
2024-03-25 16:51 ` [PATCH i-g-t 2/4] tests/intel/kms_big_joiner: revamp bigjoiner Kunal Joshi
` (5 subsequent siblings)
6 siblings, 0 replies; 18+ messages in thread
From: Kunal Joshi @ 2024-03-25 16:51 UTC (permalink / raw)
To: igt-dev
Cc: Kunal Joshi, Stanislav Lisovskiy, Ankit Nautiyal, Karthik B S,
Bhanuprakash Modem
move bigjoiner_mode_found to lib
v2: correct documentation (Ankit)
fix usage of mode (Ankit)
v3: state mode is filled in doc (Ankit)
Cc: Stanislav Lisovskiy <stanislav.lisovskiy@intel.com>
Cc: Ankit Nautiyal <ankit.k.nautiyal@intel.com>
Cc: Karthik B S <karthik.b.s@intel.com>
Cc: Bhanuprakash Modem <bhanuprakash.modem@intel.com>
Signed-off-by: Kunal Joshi <kunal1.joshi@intel.com>
Reviewed-by: Ankit Nautiyal <ankit.k.nautiyal@intel.com>
---
lib/igt_kms.c | 28 ++++++++++++++++++++++++++++
lib/igt_kms.h | 2 ++
tests/intel/kms_big_joiner.c | 14 +-------------
3 files changed, 31 insertions(+), 13 deletions(-)
diff --git a/lib/igt_kms.c b/lib/igt_kms.c
index e18f6fe59..548c9d1f3 100644
--- a/lib/igt_kms.c
+++ b/lib/igt_kms.c
@@ -6143,6 +6143,34 @@ bool igt_bigjoiner_possible(drmModeModeInfo *mode, int max_dotclock)
mode->clock > max_dotclock);
}
+/**
+ * bigjoiner_mode_found:
+ * @drm_fd: drm file descriptor
+ * @connector: libdrm connector
+ * @max_dot_clock: max dot clock frequency
+ * @mode: libdrm mode to be filled
+ *
+ * Bigjoiner will come in to the picture when the
+ * resolution > 5K or clock > max-dot-clock.
+ *
+ * Returns: True if big joiner found in connector modes
+ */
+bool bigjoiner_mode_found(int drm_fd, drmModeConnector *connector,
+ int max_dotclock, drmModeModeInfo *mode)
+{
+ bool found = false;
+
+ igt_sort_connector_modes(connector, sort_drm_modes_by_res_dsc);
+ found = igt_bigjoiner_possible(&connector->modes[0], max_dotclock);
+ if (!found) {
+ igt_sort_connector_modes(connector, sort_drm_modes_by_clk_dsc);
+ found = igt_bigjoiner_possible(&connector->modes[0], max_dotclock);
+ }
+ if (found)
+ *mode = connector->modes[0];
+ return found;
+}
+
/**
* igt_check_bigjoiner_support:
* @display: a pointer to an #igt_display_t structure
diff --git a/lib/igt_kms.h b/lib/igt_kms.h
index b3882808b..0fa7a2ea1 100644
--- a/lib/igt_kms.h
+++ b/lib/igt_kms.h
@@ -1212,6 +1212,8 @@ bool igt_max_bpc_constraint(igt_display_t *display, enum pipe pipe,
igt_output_t *output, int bpc);
int igt_get_max_dotclock(int fd);
bool igt_bigjoiner_possible(drmModeModeInfo *mode, int max_dotclock);
+bool bigjoiner_mode_found(int drm_fd, drmModeConnector *connector,
+ int max_dotclock, drmModeModeInfo *mode);
bool igt_check_bigjoiner_support(igt_display_t *display);
bool igt_parse_mode_string(const char *mode_string, drmModeModeInfo *mode);
bool intel_pipe_output_combo_valid(igt_display_t *display);
diff --git a/tests/intel/kms_big_joiner.c b/tests/intel/kms_big_joiner.c
index aba2adfbe..99b1b898d 100644
--- a/tests/intel/kms_big_joiner.c
+++ b/tests/intel/kms_big_joiner.c
@@ -199,16 +199,6 @@ static void test_dual_display(data_t *data)
igt_display_commit2(display, COMMIT_ATOMIC);
}
-static bool bigjoiner_mode_found(drmModeConnector *connector,
- int (*sort_method)(const void *, const void*),
- drmModeModeInfo *mode)
-{
- igt_sort_connector_modes(connector, sort_method);
- *mode = connector->modes[0];
-
- return igt_bigjoiner_possible(mode, max_dotclock);
-}
-
igt_main
{
data_t data;
@@ -235,9 +225,7 @@ igt_main
* Bigjoiner will come in to the picture when the
* resolution > 5K or clock > max-dot-clock.
*/
- found = (bigjoiner_mode_found(connector, sort_drm_modes_by_res_dsc, &mode) ||
- bigjoiner_mode_found(connector, sort_drm_modes_by_clk_dsc, &mode)) ?
- true : false;
+ found = bigjoiner_mode_found(data.drm_fd, connector, max_dotclock, &mode);
if (found) {
data.output[count].output_id = output->id;
--
2.34.1
^ permalink raw reply related [flat|nested] 18+ messages in thread
* [PATCH i-g-t 2/4] tests/intel/kms_big_joiner: revamp bigjoiner
2024-03-25 16:51 [PATCH i-g-t 0/4] revamp big joiner test Kunal Joshi
2024-03-25 16:51 ` [PATCH i-g-t 1/4] lib/igt_kms: move bigjoiner_mode_found to lib Kunal Joshi
@ 2024-03-25 16:51 ` Kunal Joshi
2024-03-28 6:59 ` Nautiyal, Ankit K
2024-03-25 16:51 ` [PATCH i-g-t 3/4] lib/igt_kms: add helper to enable/disable force joiner Kunal Joshi
` (4 subsequent siblings)
6 siblings, 1 reply; 18+ messages in thread
From: Kunal Joshi @ 2024-03-25 16:51 UTC (permalink / raw)
To: igt-dev
Cc: Kunal Joshi, Stanislav Lisovskiy, Ankit Nautiyal, Karthik B S,
Bhanuprakash Modem
v2: Don't change license (Bhanu)
Print the pipe name (Bhanu)
Remove unwanted commit (Bhanu)
Move combine output logic to igt_fixture (Bhanu)
split revamp and force joiner (Bhanu)
v3: Ignored fused pipes (Stan)
v4: Ignore master pipes who doesn't have slave (Ankit)
Retain subtest names (Ankit)
Use commit instead of try_commit (Ankit)
Fix typo (Ankit)
v5: Fix condition and remove last pipe (Ankit)
Remove nested if (Ankit)
Use pointer to output instead of id (Ankit)
Add missing igt_describe (Ankit)
Cc: Stanislav Lisovskiy <stanislav.lisovskiy@intel.com>
Cc: Ankit Nautiyal <ankit.k.nautiyal@intel.com>
Cc: Karthik B S <karthik.b.s@intel.com>
Cc: Bhanuprakash Modem <bhanuprakash.modem@intel.com>
Signed-off-by: Kunal Joshi <kunal1.joshi@intel.com>
Signed-off-by: Stanislav Lisovskiy <stanislav.lisovskiy@intel.com>
---
tests/intel/kms_big_joiner.c | 399 ++++++++++++++++++-----------------
1 file changed, 204 insertions(+), 195 deletions(-)
diff --git a/tests/intel/kms_big_joiner.c b/tests/intel/kms_big_joiner.c
index 99b1b898d..b57996212 100644
--- a/tests/intel/kms_big_joiner.c
+++ b/tests/intel/kms_big_joiner.c
@@ -44,177 +44,236 @@
* SUBTEST: basic
* Description: Verify the basic modeset on big joiner mode on all pipes
*
- * SUBTEST: 2x-modeset
- * Description: Verify simultaneous modeset on 2 big joiner outputs
*/
IGT_TEST_DESCRIPTION("Test big joiner");
-struct bigjoiner_output {
- uint32_t output_id;
- drmModeModeInfo mode;
-};
+#define INVALID_TEST_OUTPUT 2
typedef struct {
int drm_fd;
- igt_display_t display;
- struct igt_fb fb;
+ int big_joiner_output_count;
+ int non_big_joiner_output_count;
+ int combined_output_count;
+ int output_count;
int n_pipes;
- enum pipe pipe1;
- enum pipe pipe2;
- struct bigjoiner_output output[2];
+ int master_pipes;
+ igt_output_t *big_joiner_output[IGT_MAX_PIPES];
+ igt_output_t *non_big_joiner_output[IGT_MAX_PIPES];
+ igt_output_t *combined_output[IGT_MAX_PIPES];
+ enum pipe pipe_seq[IGT_MAX_PIPES];
+ igt_display_t display;
} data_t;
static int max_dotclock;
-static void test_invalid_modeset(data_t *data)
+static void set_all_master_pipes_for_platform(data_t *data)
{
- igt_output_t *output;
- igt_display_t *display = &data->display;
- int ret;
+ enum pipe pipe;
- igt_info("Bigjoiner test on ");
- for_each_connected_output(display, output){
- enum pipe p = output->pending_pipe;
- drmModeModeInfo *mode;
- igt_pipe_t *pipe;
- igt_plane_t *plane;
-
- if (p == PIPE_NONE)
- continue;
+ for (pipe = PIPE_A; pipe < IGT_MAX_PIPES - 1; pipe++) {
+ if (data->display.pipes[pipe].enabled && data->display.pipes[pipe+1].enabled) {
+ data->master_pipes |= BIT(pipe);
+ igt_info("Found master pipe %s\n", kmstest_pipe_name(pipe));
+ }
+ }
+}
- mode = igt_output_get_mode(output);
- igt_info("pipe:%s, output:%s, mode:", kmstest_pipe_name(p), igt_output_name(output));
- kmstest_dump_mode(mode);
+static enum pipe get_next_master_pipe(data_t *data, unsigned int available_pipe_mask)
+{
+ if ((data->master_pipes & available_pipe_mask) == 0)
+ return PIPE_NONE;
- pipe = &display->pipes[p];
- plane = igt_pipe_get_plane_type(pipe, DRM_PLANE_TYPE_PRIMARY);
+ return ffs(data->master_pipes & available_pipe_mask) - 1;
+}
- igt_plane_set_fb(plane, &data->fb);
- igt_fb_set_size(&data->fb, plane, mode->hdisplay, mode->vdisplay);
- igt_plane_set_size(plane, mode->hdisplay, mode->vdisplay);
- }
+static enum pipe setup_pipe(data_t *data, igt_output_t *output, enum pipe pipe, unsigned int available_pipe_mask)
+{
+ enum pipe master_pipe;
+ unsigned int attempt_mask;
- igt_assert(!igt_check_bigjoiner_support(display));
+ attempt_mask = BIT(pipe);
+ master_pipe = get_next_master_pipe(data, available_pipe_mask & attempt_mask);
- /* This commit is expectd to fail as this pipe is being used for big joiner */
- ret = igt_display_try_commit_atomic(display, DRM_MODE_ATOMIC_TEST_ONLY |
- DRM_MODE_ATOMIC_ALLOW_MODESET, NULL);
+ if (master_pipe == PIPE_NONE)
+ return PIPE_NONE;
- igt_display_reset(&data->display);
- igt_display_commit2(display, COMMIT_ATOMIC);
+ igt_info("Using pipe %s as master and %s slave for %s\n", kmstest_pipe_name(pipe),
+ kmstest_pipe_name(pipe + 1), output->name);
+ igt_output_set_pipe(output, pipe);
- igt_assert_lt(ret, 0);
+ return master_pipe;
}
-static void test_basic_modeset(data_t *data)
+static void test_single_joiner(data_t *data, int output_count)
{
+ int i;
+ enum pipe pipe, master_pipe;
+ unsigned int available_pipe_mask = BIT(data->n_pipes) - 1;
+ igt_output_t *output;
+ igt_plane_t *primary;
+ igt_output_t **outputs;
+ igt_fb_t fb;
drmModeModeInfo *mode;
- igt_output_t *output, *bigjoiner_output = NULL;
- igt_display_t *display = &data->display;
- igt_pipe_t *pipe;
- igt_plane_t *plane;
- igt_display_reset(display);
+ outputs = data->big_joiner_output;
- for_each_connected_output(display, output) {
- if (data->output[0].output_id == output->id) {
- bigjoiner_output = output;
- break;
+ for (i = 0; i < output_count; i++) {
+ output = outputs[i];
+ for (pipe = 0; pipe < data->n_pipes-1; pipe++) {
+ igt_display_reset(&data->display);
+ master_pipe = setup_pipe(data, output, pipe, available_pipe_mask);
+ if (master_pipe == PIPE_NONE)
+ continue;
+ mode = igt_output_get_mode(output);
+ primary = igt_output_get_plane_type(output, DRM_PLANE_TYPE_PRIMARY);
+ igt_create_pattern_fb(data->drm_fd, mode->hdisplay, mode->vdisplay, DRM_FORMAT_XRGB8888,
+ DRM_FORMAT_MOD_LINEAR, &fb);
+ igt_plane_set_fb(primary, &fb);
+ igt_display_commit2(&data->display, COMMIT_ATOMIC);
+ igt_plane_set_fb(primary, NULL);
+ igt_remove_fb(data->drm_fd, &fb);
}
}
-
- igt_output_set_pipe(bigjoiner_output, data->pipe1);
-
- mode = &data->output[0].mode;
- igt_output_override_mode(bigjoiner_output, mode);
-
- pipe = &display->pipes[data->pipe1];
- plane = igt_pipe_get_plane_type(pipe, DRM_PLANE_TYPE_PRIMARY);
-
- igt_plane_set_fb(plane, &data->fb);
- igt_fb_set_size(&data->fb, plane, mode->hdisplay, mode->vdisplay);
- igt_plane_set_size(plane, mode->hdisplay, mode->vdisplay);
-
- igt_display_commit2(display, COMMIT_ATOMIC);
-
- igt_output_set_pipe(bigjoiner_output, PIPE_NONE);
- igt_plane_set_fb(plane, NULL);
- igt_display_commit2(display, COMMIT_ATOMIC);
}
-static void test_dual_display(data_t *data)
+static void test_multi_joiner(data_t *data, int output_count)
{
+ int i;
+ unsigned int available_pipe_mask;
+ enum pipe pipe, master_pipe;
+ igt_output_t **outputs;
+ igt_output_t *output;
+ igt_plane_t *primary[output_count];
+ igt_fb_t fb[output_count];
drmModeModeInfo *mode;
- igt_output_t *output, *bigjoiner_output[2];
- igt_display_t *display = &data->display;
- igt_pipe_t *pipe;
- igt_plane_t *plane1, *plane2;
- int count = 0;
-
- igt_display_reset(display);
-
- for_each_connected_output(display, output) {
- if (data->output[count].output_id == output->id) {
- bigjoiner_output[count] = output;
- count++;
- }
- if (count > 1)
+ available_pipe_mask = BIT(data->n_pipes) - 1;
+ outputs = data->big_joiner_output;
+
+ igt_display_reset(&data->display);
+ for (i = 0; i < output_count; i++) {
+ output = outputs[i];
+ for (pipe = 0; pipe < data->n_pipes; pipe++) {
+ master_pipe = setup_pipe(data, output, pipe, available_pipe_mask);
+ if (master_pipe == PIPE_NONE)
+ continue;
+ mode = igt_output_get_mode(output);
+ primary[i] = igt_output_get_plane_type(output, DRM_PLANE_TYPE_PRIMARY);
+ igt_create_pattern_fb(data->drm_fd, mode->hdisplay, mode->vdisplay, DRM_FORMAT_XRGB8888,
+ DRM_FORMAT_MOD_LINEAR, &fb[i]);
+ igt_plane_set_fb(primary[i], &fb[i]);
+
+ available_pipe_mask &= ~BIT(master_pipe);
+ available_pipe_mask &= ~BIT(master_pipe + 1);
break;
+ }
}
+ igt_display_commit2(&data->display, COMMIT_ATOMIC);
+ for (i = 0; i < output_count; i++) {
+ igt_plane_set_fb(primary[i], NULL);
+ igt_remove_fb(data->drm_fd, &fb[i]);
+ }
+}
- igt_output_set_pipe(bigjoiner_output[0], data->pipe1);
- igt_output_set_pipe(bigjoiner_output[1], data->pipe2);
-
- /* Set up first big joiner output on Pipe A*/
- mode = &data->output[0].mode;
- igt_output_override_mode(bigjoiner_output[0], mode);
+static void test_invalid_modeset_two_joiner(data_t *data,
+ bool combined)
+{
+ int i, j, ret;
+ unsigned int available_pipe_mask;
+ unsigned int attempt_mask;
+ enum pipe master_pipe;
+ igt_output_t **outputs;
+ igt_output_t *output;
+ igt_plane_t *primary[INVALID_TEST_OUTPUT];
+ igt_fb_t fb[INVALID_TEST_OUTPUT];
+ drmModeModeInfo *mode;
- pipe = &display->pipes[data->pipe1];
- plane1 = igt_pipe_get_plane_type(pipe, DRM_PLANE_TYPE_PRIMARY);
+ available_pipe_mask = BIT(data->n_pipes) - 1;
+ outputs = combined ? data->combined_output : data->big_joiner_output;
- igt_plane_set_fb(plane1, &data->fb);
- igt_fb_set_size(&data->fb, plane1, mode->hdisplay, mode->vdisplay);
- igt_plane_set_size(plane1, mode->hdisplay, mode->vdisplay);
+ for (i = 0; i < data->n_pipes-1; i++) {
+ igt_display_reset(&data->display);
+ attempt_mask = BIT(data->pipe_seq[i]);
+ master_pipe = get_next_master_pipe(data, available_pipe_mask & attempt_mask);
- /* Set up second big joiner output on Pipe C*/
- mode = &data->output[1].mode;
- igt_output_override_mode(bigjoiner_output[1], mode);
+ if (master_pipe == PIPE_NONE)
+ continue;
- pipe = &display->pipes[data->pipe2];
- plane2 = igt_pipe_get_plane_type(pipe, DRM_PLANE_TYPE_PRIMARY);
+ for (j = 0; j < INVALID_TEST_OUTPUT; j++) {
+ output = outputs[j];
+ igt_output_set_pipe(output, data->pipe_seq[i + j]);
+ mode = igt_output_get_mode(output);
+ igt_info("Assigning pipe %s to %s with mode %dx%d@%d%s",
+ kmstest_pipe_name(data->pipe_seq[i + j]),
+ igt_output_name(output), mode->hdisplay,
+ mode->vdisplay, mode->vrefresh,
+ j == INVALID_TEST_OUTPUT - 1 ? "\n" : ", ");
+ primary[j] = igt_output_get_plane_type(output, DRM_PLANE_TYPE_PRIMARY);
+ igt_create_pattern_fb(data->drm_fd, mode->hdisplay, mode->vdisplay, DRM_FORMAT_XRGB8888,
+ DRM_FORMAT_MOD_LINEAR, &fb[j]);
+ igt_plane_set_fb(primary[j], &fb[j]);
+ }
+ ret = igt_display_try_commit2(&data->display, COMMIT_ATOMIC);
+ for (j = 0; j < INVALID_TEST_OUTPUT; j++) {
+ igt_plane_set_fb(primary[j], NULL);
+ igt_remove_fb(data->drm_fd, &fb[j]);
+ }
+ igt_assert_f(ret != 0, "Commit shouldn't have passed\n");
+ }
+}
- igt_plane_set_fb(plane2, &data->fb);
- igt_fb_set_size(&data->fb, plane2, mode->hdisplay, mode->vdisplay);
- igt_plane_set_size(plane2, mode->hdisplay, mode->vdisplay);
+static void test_big_joiner_on_last_pipe(data_t *data)
+{
+ int i, len, ret;
+ igt_output_t **outputs;
+ igt_output_t *output;
+ igt_plane_t *primary;
+ igt_fb_t fb;
+ drmModeModeInfo *mode;
- igt_display_commit2(display, COMMIT_ATOMIC);
+ len = data->big_joiner_output_count;
+ outputs = data->big_joiner_output;
- /* Clean up */
- igt_output_set_pipe(bigjoiner_output[0], PIPE_NONE);
- igt_output_set_pipe(bigjoiner_output[1], PIPE_NONE);
- igt_plane_set_fb(plane1, NULL);
- igt_plane_set_fb(plane2, NULL);
- igt_display_commit2(display, COMMIT_ATOMIC);
+ for (i = 0; i < len; i++) {
+ igt_display_reset(&data->display);
+ output = outputs[i];
+ igt_output_set_pipe(output, data->pipe_seq[data->n_pipes - 1]);
+ mode = igt_output_get_mode(output);
+ igt_info(" Assigning pipe %s to %s with mode %dx%d@%d\n",
+ kmstest_pipe_name(data->pipe_seq[data->n_pipes - 1]),
+ igt_output_name(output), mode->hdisplay,
+ mode->vdisplay, mode->vrefresh);
+ primary = igt_output_get_plane_type(output, DRM_PLANE_TYPE_PRIMARY);
+ igt_create_pattern_fb(data->drm_fd, mode->hdisplay, mode->vdisplay, DRM_FORMAT_XRGB8888,
+ DRM_FORMAT_MOD_LINEAR, &fb);
+ igt_plane_set_fb(primary, &fb);
+ ret = igt_display_try_commit2(&data->display, COMMIT_ATOMIC);
+ igt_plane_set_fb(primary, NULL);
+ igt_remove_fb(data->drm_fd, &fb);
+ igt_assert_f(ret != 0, "Commit shouldn't have passed\n");
+ }
}
igt_main
{
- data_t data;
+ int i, j;
igt_output_t *output;
drmModeModeInfo mode;
- int valid_output = 0, i, count = 0, j = 0;
- uint16_t width = 0, height = 0;
- enum pipe pipe_seq[IGT_MAX_PIPES];
+ data_t data;
igt_fixture {
+ data.big_joiner_output_count = 0;
+ data.non_big_joiner_output_count = 0;
+ data.combined_output_count = 0;
+ data.output_count = 0;
+ j = 0;
+
data.drm_fd = drm_open_driver_master(DRIVER_INTEL | DRIVER_XE);
kmstest_set_vt_graphics_mode();
-
igt_display_require(&data.display, data.drm_fd);
+ set_all_master_pipes_for_platform(&data);
igt_require(data.display.is_atomic);
-
max_dotclock = igt_get_max_dotclock(data.drm_fd);
for_each_connected_output(&data.display, output) {
@@ -228,105 +287,55 @@ igt_main
found = bigjoiner_mode_found(data.drm_fd, connector, max_dotclock, &mode);
if (found) {
- data.output[count].output_id = output->id;
- memcpy(&data.output[count].mode, &mode, sizeof(drmModeModeInfo));
- count++;
-
- width = max(width, mode.hdisplay);
- height = max(height, mode.vdisplay);
+ data.big_joiner_output[data.big_joiner_output_count++] = output;
+ igt_output_override_mode(output, &mode);
+ } else {
+ data.non_big_joiner_output[data.non_big_joiner_output_count++] = output;
}
- valid_output++;
+ data.output_count++;
+ }
+ if (data.big_joiner_output_count == 1 && data.non_big_joiner_output_count >= 1) {
+ data.combined_output[data.combined_output_count++] = data.big_joiner_output[0];
+ data.combined_output[data.combined_output_count++] = data.non_big_joiner_output[0];
}
-
data.n_pipes = 0;
for_each_pipe(&data.display, i) {
data.n_pipes++;
- pipe_seq[j] = i;
+ data.pipe_seq[j] = i;
j++;
}
-
- igt_require_f(count > 0, "No output with 5k+ mode (or) clock > max-dot-clock found\n");
-
- igt_create_pattern_fb(data.drm_fd, width, height, DRM_FORMAT_XRGB8888,
- DRM_FORMAT_MOD_LINEAR, &data.fb);
}
igt_describe("Verify the basic modeset on big joiner mode on all pipes");
igt_subtest_with_dynamic("basic") {
- for (i = 0; i < data.n_pipes - 1; i++) {
- data.pipe1 = pipe_seq[i];
- igt_dynamic_f("pipe-%s", kmstest_pipe_name(pipe_seq[i]))
- test_basic_modeset(&data);
- }
+ igt_require_f(data.big_joiner_output_count > 0,
+ "No bigjoiner output found\n");
+ igt_require_f(data.n_pipes > 1,
+ "Minimum 2 pipes required\n");
+ igt_dynamic_f("single-joiner")
+ test_single_joiner(&data, data.big_joiner_output_count);
+ if (data.big_joiner_output_count > 1)
+ igt_dynamic_f("multi-joiner")
+ test_multi_joiner(&data, data.big_joiner_output_count);
}
igt_describe("Verify if the modeset on the adjoining pipe is rejected "
"when the pipe is active with a big joiner modeset");
igt_subtest_with_dynamic("invalid-modeset") {
- data.pipe1 = pipe_seq[j - 1];
-
- igt_display_reset(&data.display);
- for_each_connected_output(&data.display, output) {
- if (data.output[0].output_id != output->id)
- continue;
-
- mode = data.output[0].mode;
- igt_output_set_pipe(output, data.pipe1);
- igt_output_override_mode(output, &mode);
-
- igt_dynamic_f("pipe-%s-%s",
- kmstest_pipe_name(data.pipe1),
- igt_output_name(output))
- test_invalid_modeset(&data);
- }
-
- if(valid_output > 1) {
- for (i = 0; i < data.n_pipes - 1; i++) {
- igt_output_t *first_output = NULL, *second_output = NULL;
-
- data.pipe1 = pipe_seq[i];
- data.pipe2 = pipe_seq[i + 1];
-
- igt_display_reset(&data.display);
- for_each_connected_output(&data.display, output) {
- if (data.output[0].output_id == output->id) {
- first_output = output;
- mode = data.output[0].mode;
-
- igt_output_set_pipe(output, data.pipe1);
- igt_output_override_mode(output, &mode);
- } else if (second_output == NULL) {
- second_output = output;
- igt_output_set_pipe(output, data.pipe2);
-
- break;
- }
- }
-
- igt_dynamic_f("pipe-%s-%s-pipe-%s-%s",
- kmstest_pipe_name(data.pipe1),
- igt_output_name(first_output),
- kmstest_pipe_name(data.pipe2),
- igt_output_name(second_output))
- test_invalid_modeset(&data);
- }
- }
- }
-
- igt_describe("Verify simultaneous modeset on 2 big joiner outputs");
- igt_subtest_with_dynamic("2x-modeset") {
- igt_require_f(count > 1, "2 outputs with big joiner modes are required\n");
- igt_require_f(data.n_pipes > 3, "Minumum of 4 pipes are required\n");
- for (i = 0; (i + 2) < data.n_pipes - 1; i++) {
- data.pipe1 = pipe_seq[i];
- data.pipe2 = pipe_seq[i + 2];
- igt_dynamic_f("pipe-%s-%s", kmstest_pipe_name(pipe_seq[i]), kmstest_pipe_name(pipe_seq[i + 2]))
- test_dual_display(&data);
- }
+ igt_require_f(data.big_joiner_output_count > 0, "Non big joiner output not found\n");
+ igt_require_f(data.n_pipes > 1, "Minimum of 2 pipes are required\n");
+ if (data.big_joiner_output_count >= 1)
+ igt_dynamic_f("big_joiner_on_last_pipe")
+ test_big_joiner_on_last_pipe(&data);
+ if (data.big_joiner_output_count > 1)
+ igt_dynamic_f("invalid_combinations")
+ test_invalid_modeset_two_joiner(&data, false);
+ if (data.combined_output_count)
+ igt_dynamic_f("combined_output")
+ test_invalid_modeset_two_joiner(&data, true);
}
igt_fixture {
- igt_remove_fb(data.drm_fd, &data.fb);
igt_display_fini(&data.display);
drm_close_driver(data.drm_fd);
}
--
2.34.1
^ permalink raw reply related [flat|nested] 18+ messages in thread
* [PATCH i-g-t 3/4] lib/igt_kms: add helper to enable/disable force joiner
2024-03-25 16:51 [PATCH i-g-t 0/4] revamp big joiner test Kunal Joshi
2024-03-25 16:51 ` [PATCH i-g-t 1/4] lib/igt_kms: move bigjoiner_mode_found to lib Kunal Joshi
2024-03-25 16:51 ` [PATCH i-g-t 2/4] tests/intel/kms_big_joiner: revamp bigjoiner Kunal Joshi
@ 2024-03-25 16:51 ` Kunal Joshi
2024-03-28 7:11 ` Nautiyal, Ankit K
2024-03-25 16:51 ` [PATCH i-g-t 4/4] tests/intel/kms_big_joiner: add tests for " Kunal Joshi
` (3 subsequent siblings)
6 siblings, 1 reply; 18+ messages in thread
From: Kunal Joshi @ 2024-03-25 16:51 UTC (permalink / raw)
To: igt-dev
Cc: Kunal Joshi, Stanislav Lisovskiy, Ankit Nautiyal, Karthik B S,
Bhanuprakash Modem
v2: Add documentation and rename (Ankit)
Combine enable/disable and status check (Ankit)
Don't assert in igt_has_force_joiner_debugfs (Ankit)
add helpers to check whether force joiner debugfs exists
and to enable/disable force joiner for a specific connector.
Cc: Stanislav Lisovskiy <stanislav.lisovskiy@intel.com>
Cc: Ankit Nautiyal <ankit.k.nautiyal@intel.com>
Cc: Karthik B S <karthik.b.s@intel.com>
Cc: Bhanuprakash Modem <bhanuprakash.modem@intel.com>
Signed-off-by: Kunal Joshi <kunal1.joshi@intel.com>
Reviewed-by: Ankit Nautiyal <ankit.k.nautiyal@intel.com>
---
lib/igt_kms.c | 51 +++++++++++++++++++++++++++++++++++++++++++++++++++
lib/igt_kms.h | 2 ++
2 files changed, 53 insertions(+)
diff --git a/lib/igt_kms.c b/lib/igt_kms.c
index 548c9d1f3..c38021dd7 100644
--- a/lib/igt_kms.c
+++ b/lib/igt_kms.c
@@ -6171,6 +6171,57 @@ bool bigjoiner_mode_found(int drm_fd, drmModeConnector *connector,
return found;
}
+/**
+ * Checks if the force big joiner debugfs is available
+ * for a specific connector.
+ *
+ * @drmfd: file descriptor of the DRM device.
+ * @output: output to check.
+ * Returns:
+ * true if the debugfs is available, false otherwise.
+ */
+bool igt_has_force_joiner_debugfs(int drmfd, igt_output_t *output)
+{
+ char buf[512];
+ int debugfs_fd, ret;
+
+ igt_assert_f(output->name, "Connector name cannot be NULL\n");
+ debugfs_fd = igt_debugfs_connector_dir(drmfd, output->name, O_RDONLY);
+ if (debugfs_fd < 0)
+ return false;
+ ret = igt_debugfs_simple_read(debugfs_fd, "i915_bigjoiner_force_enable", buf, sizeof(buf));
+ close(debugfs_fd);
+ return ret >= 0;
+}
+
+/**
+ * Forces the enable/disable state of big joiner for a specific connector.
+ *
+ * @drmfd The file descriptor of the DRM device.
+ * @connector_name The name of the connector.
+ * @enable The desired state of big joiner (true for enable, false for disable).
+ * Returns:
+ * true if writing the debugfs was successful
+ * and the state was set as requested, false otherwise.
+ */
+bool igt_force_and_check_bigjoiner_status(int drmfd, char *connector_name, bool enable)
+{
+ int debugfs_fd, ret;
+ char buf[512];
+
+ igt_assert_f(connector_name, "Connector name cannot be NULL\n");
+ debugfs_fd = igt_debugfs_connector_dir(drmfd, connector_name, O_DIRECTORY);
+ igt_assert_f(debugfs_fd >= 0, "Could not open debugfs for connector %s\n", connector_name);
+ ret = igt_sysfs_write(debugfs_fd, "i915_bigjoiner_force_enable", enable ? "1" : "0", 1);
+ igt_assert_f(ret > 0, "Could not write i915_bigjoiner_force_enable for connector %s\n", connector_name);
+ ret = igt_debugfs_simple_read(debugfs_fd, "i915_bigjoiner_force_enable", buf, sizeof(buf));
+ close(debugfs_fd);
+ igt_assert_f(ret > 0, "Could not read i915_bigjoiner_force_enable for connector %s\n", connector_name);
+
+ return enable ? strstr(buf, "Bigjoiner enable: 1") :
+ strstr(buf, "Bigjoiner enable: 0");
+}
+
/**
* igt_check_bigjoiner_support:
* @display: a pointer to an #igt_display_t structure
diff --git a/lib/igt_kms.h b/lib/igt_kms.h
index 0fa7a2ea1..6d13e5851 100644
--- a/lib/igt_kms.h
+++ b/lib/igt_kms.h
@@ -1214,6 +1214,8 @@ int igt_get_max_dotclock(int fd);
bool igt_bigjoiner_possible(drmModeModeInfo *mode, int max_dotclock);
bool bigjoiner_mode_found(int drm_fd, drmModeConnector *connector,
int max_dotclock, drmModeModeInfo *mode);
+bool igt_has_force_joiner_debugfs(int drmfd, igt_output_t *output);
+bool igt_force_and_check_bigjoiner_status(int drmfd, char *connector_name, bool enable);
bool igt_check_bigjoiner_support(igt_display_t *display);
bool igt_parse_mode_string(const char *mode_string, drmModeModeInfo *mode);
bool intel_pipe_output_combo_valid(igt_display_t *display);
--
2.34.1
^ permalink raw reply related [flat|nested] 18+ messages in thread
* [PATCH i-g-t 4/4] tests/intel/kms_big_joiner: add tests for force joiner
2024-03-25 16:51 [PATCH i-g-t 0/4] revamp big joiner test Kunal Joshi
` (2 preceding siblings ...)
2024-03-25 16:51 ` [PATCH i-g-t 3/4] lib/igt_kms: add helper to enable/disable force joiner Kunal Joshi
@ 2024-03-25 16:51 ` Kunal Joshi
2024-03-28 7:06 ` Nautiyal, Ankit K
2024-03-25 20:52 ` ✓ CI.xeBAT: success for revamp big joiner test (rev9) Patchwork
` (2 subsequent siblings)
6 siblings, 1 reply; 18+ messages in thread
From: Kunal Joshi @ 2024-03-25 16:51 UTC (permalink / raw)
To: igt-dev
Cc: Kunal Joshi, Stanislav Lisovskiy, Ankit Nautiyal, Karthik B S,
Bhanuprakash Modem
add tests for force joiner
v2: check status after forcing (Ankit)
take out commoon code (Ankit)
fix missing force_joiner (Ankit)
Cc: Stanislav Lisovskiy <stanislav.lisovskiy@intel.com>
Cc: Ankit Nautiyal <ankit.k.nautiyal@intel.com>
Cc: Karthik B S <karthik.b.s@intel.com>
Cc: Bhanuprakash Modem <bhanuprakash.modem@intel.com>
Signed-off-by: Kunal Joshi <kunal1.joshi@intel.com>
---
tests/intel/kms_big_joiner.c | 102 +++++++++++++++++++++++++++++------
1 file changed, 85 insertions(+), 17 deletions(-)
diff --git a/tests/intel/kms_big_joiner.c b/tests/intel/kms_big_joiner.c
index b57996212..fd6baccc3 100644
--- a/tests/intel/kms_big_joiner.c
+++ b/tests/intel/kms_big_joiner.c
@@ -44,9 +44,14 @@
* SUBTEST: basic
* Description: Verify the basic modeset on big joiner mode on all pipes
*
+ * SUBTEST: invalid-modeset-force-joiner
+ * Description: Verify if the modeset on the adjoining pipe is rejected when
+ * the pipe is active with a force joiner modeset
+ *
+ * SUBTEST: basic-force-joiner
+ * Description: Verify the basic modeset on force joiner mode on all pipes
*/
-
-IGT_TEST_DESCRIPTION("Test big joiner");
+IGT_TEST_DESCRIPTION("Test big joiner / force joiner");
#define INVALID_TEST_OUTPUT 2
@@ -79,6 +84,19 @@ static void set_all_master_pipes_for_platform(data_t *data)
}
}
+static void toggle_force_joiner_on_all_non_big_joiner_outputs(data_t *data, bool toggle)
+{
+ bool status;
+ igt_output_t *output;
+ int i;
+
+ for (i = 0; i < data->non_big_joiner_output_count; i++) {
+ output = data->non_big_joiner_output[i];
+ status = igt_force_and_check_bigjoiner_status(data->drm_fd, output->name, toggle);
+ igt_assert_f(status, "Failed to toggle force joiner\n");
+ }
+}
+
static enum pipe get_next_master_pipe(data_t *data, unsigned int available_pipe_mask)
{
if ((data->master_pipes & available_pipe_mask) == 0)
@@ -105,7 +123,7 @@ static enum pipe setup_pipe(data_t *data, igt_output_t *output, enum pipe pipe,
return master_pipe;
}
-static void test_single_joiner(data_t *data, int output_count)
+static void test_single_joiner(data_t *data, int output_count, bool force_joiner)
{
int i;
enum pipe pipe, master_pipe;
@@ -116,7 +134,7 @@ static void test_single_joiner(data_t *data, int output_count)
igt_fb_t fb;
drmModeModeInfo *mode;
- outputs = data->big_joiner_output;
+ outputs = force_joiner ? data->non_big_joiner_output : data->big_joiner_output;
for (i = 0; i < output_count; i++) {
output = outputs[i];
@@ -137,7 +155,7 @@ static void test_single_joiner(data_t *data, int output_count)
}
}
-static void test_multi_joiner(data_t *data, int output_count)
+static void test_multi_joiner(data_t *data, int output_count, bool force_joiner)
{
int i;
unsigned int available_pipe_mask;
@@ -149,7 +167,7 @@ static void test_multi_joiner(data_t *data, int output_count)
drmModeModeInfo *mode;
available_pipe_mask = BIT(data->n_pipes) - 1;
- outputs = data->big_joiner_output;
+ outputs = force_joiner ? data->non_big_joiner_output : data->big_joiner_output;
igt_display_reset(&data->display);
for (i = 0; i < output_count; i++) {
@@ -177,7 +195,7 @@ static void test_multi_joiner(data_t *data, int output_count)
}
static void test_invalid_modeset_two_joiner(data_t *data,
- bool combined)
+ bool combined, bool force_joiner)
{
int i, j, ret;
unsigned int available_pipe_mask;
@@ -190,7 +208,8 @@ static void test_invalid_modeset_two_joiner(data_t *data,
drmModeModeInfo *mode;
available_pipe_mask = BIT(data->n_pipes) - 1;
- outputs = combined ? data->combined_output : data->big_joiner_output;
+ outputs = force_joiner ? data->non_big_joiner_output :
+ combined ? data->combined_output : data->big_joiner_output;
for (i = 0; i < data->n_pipes-1; i++) {
igt_display_reset(&data->display);
@@ -223,7 +242,7 @@ static void test_invalid_modeset_two_joiner(data_t *data,
}
}
-static void test_big_joiner_on_last_pipe(data_t *data)
+static void test_joiner_on_last_pipe(data_t *data, bool force_joiner)
{
int i, len, ret;
igt_output_t **outputs;
@@ -232,8 +251,8 @@ static void test_big_joiner_on_last_pipe(data_t *data)
igt_fb_t fb;
drmModeModeInfo *mode;
- len = data->big_joiner_output_count;
- outputs = data->big_joiner_output;
+ len = force_joiner ? data->non_big_joiner_output_count : data->big_joiner_output_count;
+ outputs = force_joiner ? data->non_big_joiner_output : data->big_joiner_output;
for (i = 0; i < len; i++) {
igt_display_reset(&data->display);
@@ -257,12 +276,14 @@ static void test_big_joiner_on_last_pipe(data_t *data)
igt_main
{
+ bool force_joiner_supported;
int i, j;
igt_output_t *output;
drmModeModeInfo mode;
data_t data;
igt_fixture {
+ force_joiner_supported = false;
data.big_joiner_output_count = 0;
data.non_big_joiner_output_count = 0;
data.combined_output_count = 0;
@@ -290,7 +311,10 @@ igt_main
data.big_joiner_output[data.big_joiner_output_count++] = output;
igt_output_override_mode(output, &mode);
} else {
- data.non_big_joiner_output[data.non_big_joiner_output_count++] = output;
+ if (igt_has_force_joiner_debugfs(data.drm_fd, output)) {
+ force_joiner_supported = true;
+ data.non_big_joiner_output[data.non_big_joiner_output_count++] = output;
+ }
}
data.output_count++;
}
@@ -313,10 +337,10 @@ igt_main
igt_require_f(data.n_pipes > 1,
"Minimum 2 pipes required\n");
igt_dynamic_f("single-joiner")
- test_single_joiner(&data, data.big_joiner_output_count);
+ test_single_joiner(&data, data.big_joiner_output_count, false);
if (data.big_joiner_output_count > 1)
igt_dynamic_f("multi-joiner")
- test_multi_joiner(&data, data.big_joiner_output_count);
+ test_multi_joiner(&data, data.big_joiner_output_count, false);
}
igt_describe("Verify if the modeset on the adjoining pipe is rejected "
@@ -326,13 +350,57 @@ igt_main
igt_require_f(data.n_pipes > 1, "Minimum of 2 pipes are required\n");
if (data.big_joiner_output_count >= 1)
igt_dynamic_f("big_joiner_on_last_pipe")
- test_big_joiner_on_last_pipe(&data);
+ test_joiner_on_last_pipe(&data, false);
if (data.big_joiner_output_count > 1)
igt_dynamic_f("invalid_combinations")
- test_invalid_modeset_two_joiner(&data, false);
+ test_invalid_modeset_two_joiner(&data, false, false);
if (data.combined_output_count)
igt_dynamic_f("combined_output")
- test_invalid_modeset_two_joiner(&data, true);
+ test_invalid_modeset_two_joiner(&data, true, false);
+ }
+
+ igt_describe("Verify the basic modeset on big joiner mode on all pipes");
+ igt_subtest_with_dynamic("basic-force-joiner") {
+ igt_require_f(force_joiner_supported,
+ "force joiner not supported on this platform or none of the connected output supports it\n");
+ igt_require_f(data.non_big_joiner_output_count > 0,
+ "No non big joiner output found\n");
+ igt_require_f(data.n_pipes > 1,
+ "Minimum 2 pipes required\n");
+ igt_dynamic_f("single") {
+ toggle_force_joiner_on_all_non_big_joiner_outputs(&data, true);
+ test_single_joiner(&data, data.non_big_joiner_output_count, true);
+ toggle_force_joiner_on_all_non_big_joiner_outputs(&data, false);
+ }
+ if (data.non_big_joiner_output_count > 1) {
+ igt_dynamic_f("multi") {
+ toggle_force_joiner_on_all_non_big_joiner_outputs(&data, true);
+ test_multi_joiner(&data, data.non_big_joiner_output_count, true);
+ toggle_force_joiner_on_all_non_big_joiner_outputs(&data, false);
+ }
+ }
+ }
+
+ igt_subtest_with_dynamic("invalid-modeset-force-joiner") {
+ igt_require_f(force_joiner_supported,
+ "force joiner not supported on this platform or none of the connected output supports it\n");
+ igt_require_f(data.non_big_joiner_output_count > 0, "Non big joiner output not found\n");
+ igt_require_f(data.n_pipes > 1, "Minimum of 2 pipes are required\n");
+
+ if (data.non_big_joiner_output_count >= 1) {
+ igt_dynamic_f("big_joiner_on_last_pipe") {
+ toggle_force_joiner_on_all_non_big_joiner_outputs(&data, true);
+ test_joiner_on_last_pipe(&data, true);
+ toggle_force_joiner_on_all_non_big_joiner_outputs(&data, false);
+ }
+ }
+ if (data.non_big_joiner_output_count > 1) {
+ igt_dynamic_f("invalid_combinations") {
+ toggle_force_joiner_on_all_non_big_joiner_outputs(&data, true);
+ test_invalid_modeset_two_joiner(&data, false, true);
+ toggle_force_joiner_on_all_non_big_joiner_outputs(&data, false);
+ }
+ }
}
igt_fixture {
--
2.34.1
^ permalink raw reply related [flat|nested] 18+ messages in thread
* ✓ CI.xeBAT: success for revamp big joiner test (rev9)
2024-03-25 16:51 [PATCH i-g-t 0/4] revamp big joiner test Kunal Joshi
` (3 preceding siblings ...)
2024-03-25 16:51 ` [PATCH i-g-t 4/4] tests/intel/kms_big_joiner: add tests for " Kunal Joshi
@ 2024-03-25 20:52 ` Patchwork
2024-03-25 20:54 ` ✓ Fi.CI.BAT: " Patchwork
2024-03-26 4:17 ` ✗ Fi.CI.IGT: failure " Patchwork
6 siblings, 0 replies; 18+ messages in thread
From: Patchwork @ 2024-03-25 20:52 UTC (permalink / raw)
To: Kunal Joshi; +Cc: igt-dev
[-- Attachment #1: Type: text/plain, Size: 1744 bytes --]
== Series Details ==
Series: revamp big joiner test (rev9)
URL : https://patchwork.freedesktop.org/series/130572/
State : success
== Summary ==
CI Bug Log - changes from XEIGT_7782_BAT -> XEIGTPW_10904_BAT
====================================================
Summary
-------
**SUCCESS**
No regressions found.
Participating hosts (4 -> 3)
------------------------------
Missing (1): bat-dg2-oem2
Known issues
------------
Here are the changes found in XEIGTPW_10904_BAT that come from known issues:
### IGT changes ###
#### Warnings ####
* igt@xe_exec_threads@threads-mixed-userptr-invalidate:
- bat-adlp-7: [INCOMPLETE][1] ([Intel XE#1044] / [Intel XE#1376]) -> [INCOMPLETE][2] ([Intel XE#1044])
[1]: https://intel-gfx-ci.01.org/tree/intel-xe/IGT_7782/bat-adlp-7/igt@xe_exec_threads@threads-mixed-userptr-invalidate.html
[2]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_10904/bat-adlp-7/igt@xe_exec_threads@threads-mixed-userptr-invalidate.html
[Intel XE#1044]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/1044
[Intel XE#1376]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/1376
Build changes
-------------
* IGT: IGT_7782 -> IGTPW_10904
* Linux: xe-988-d1ecfbbbb194e8f7941bd84f77f7c938b461ce14 -> xe-989-17ec6923f2c5bb23280b274d6359a44a6982982e
IGTPW_10904: 10904
IGT_7782: a404f73182948e843640d00cc279883391cf6ef4 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
xe-988-d1ecfbbbb194e8f7941bd84f77f7c938b461ce14: d1ecfbbbb194e8f7941bd84f77f7c938b461ce14
xe-989-17ec6923f2c5bb23280b274d6359a44a6982982e: 17ec6923f2c5bb23280b274d6359a44a6982982e
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_10904/index.html
[-- Attachment #2: Type: text/html, Size: 2382 bytes --]
^ permalink raw reply [flat|nested] 18+ messages in thread
* ✓ Fi.CI.BAT: success for revamp big joiner test (rev9)
2024-03-25 16:51 [PATCH i-g-t 0/4] revamp big joiner test Kunal Joshi
` (4 preceding siblings ...)
2024-03-25 20:52 ` ✓ CI.xeBAT: success for revamp big joiner test (rev9) Patchwork
@ 2024-03-25 20:54 ` Patchwork
2024-03-26 4:17 ` ✗ Fi.CI.IGT: failure " Patchwork
6 siblings, 0 replies; 18+ messages in thread
From: Patchwork @ 2024-03-25 20:54 UTC (permalink / raw)
To: Kunal Joshi; +Cc: igt-dev
[-- Attachment #1: Type: text/plain, Size: 10407 bytes --]
== Series Details ==
Series: revamp big joiner test (rev9)
URL : https://patchwork.freedesktop.org/series/130572/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_14480 -> IGTPW_10904
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10904/index.html
Participating hosts (35 -> 34)
------------------------------
Additional (2): fi-glk-j4005 bat-mtlp-8
Missing (3): fi-kbl-8809g fi-snb-2520m bat-arls-3
Known issues
------------
Here are the changes found in IGTPW_10904 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@debugfs_test@basic-hwmon:
- bat-mtlp-8: NOTRUN -> [SKIP][1] ([i915#9318])
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10904/bat-mtlp-8/igt@debugfs_test@basic-hwmon.html
* igt@gem_huc_copy@huc-copy:
- fi-glk-j4005: NOTRUN -> [SKIP][2] ([i915#2190])
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10904/fi-glk-j4005/igt@gem_huc_copy@huc-copy.html
* igt@gem_lmem_swapping@basic:
- fi-glk-j4005: NOTRUN -> [SKIP][3] ([i915#4613]) +3 other tests skip
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10904/fi-glk-j4005/igt@gem_lmem_swapping@basic.html
* igt@gem_lmem_swapping@verify-random:
- bat-mtlp-8: NOTRUN -> [SKIP][4] ([i915#4613]) +3 other tests skip
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10904/bat-mtlp-8/igt@gem_lmem_swapping@verify-random.html
* igt@gem_mmap@basic:
- bat-mtlp-8: NOTRUN -> [SKIP][5] ([i915#4083])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10904/bat-mtlp-8/igt@gem_mmap@basic.html
* igt@gem_mmap_gtt@basic:
- bat-mtlp-8: NOTRUN -> [SKIP][6] ([i915#4077]) +2 other tests skip
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10904/bat-mtlp-8/igt@gem_mmap_gtt@basic.html
* igt@gem_render_tiled_blits@basic:
- bat-mtlp-8: NOTRUN -> [SKIP][7] ([i915#4079]) +1 other test skip
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10904/bat-mtlp-8/igt@gem_render_tiled_blits@basic.html
* igt@i915_pm_rps@basic-api:
- bat-mtlp-8: NOTRUN -> [SKIP][8] ([i915#6621])
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10904/bat-mtlp-8/igt@i915_pm_rps@basic-api.html
* igt@i915_selftest@live@hangcheck:
- bat-rpls-3: [PASS][9] -> [DMESG-WARN][10] ([i915#5591])
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_14480/bat-rpls-3/igt@i915_selftest@live@hangcheck.html
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10904/bat-rpls-3/igt@i915_selftest@live@hangcheck.html
* igt@i915_selftest@live@sanitycheck:
- fi-kbl-7567u: [PASS][11] -> [DMESG-WARN][12] ([i915#9730]) +4 other tests dmesg-warn
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_14480/fi-kbl-7567u/igt@i915_selftest@live@sanitycheck.html
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10904/fi-kbl-7567u/igt@i915_selftest@live@sanitycheck.html
* igt@kms_addfb_basic@addfb25-y-tiled-small-legacy:
- bat-mtlp-8: NOTRUN -> [SKIP][13] ([i915#5190])
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10904/bat-mtlp-8/igt@kms_addfb_basic@addfb25-y-tiled-small-legacy.html
* igt@kms_addfb_basic@basic-y-tiled-legacy:
- bat-mtlp-8: NOTRUN -> [SKIP][14] ([i915#4212]) +8 other tests skip
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10904/bat-mtlp-8/igt@kms_addfb_basic@basic-y-tiled-legacy.html
* igt@kms_busy@basic@flip:
- fi-kbl-7567u: [PASS][15] -> [DMESG-WARN][16] ([i915#180] / [i915#8585]) +3 other tests dmesg-warn
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_14480/fi-kbl-7567u/igt@kms_busy@basic@flip.html
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10904/fi-kbl-7567u/igt@kms_busy@basic@flip.html
* igt@kms_cursor_legacy@basic-busy-flip-before-cursor-atomic:
- fi-glk-j4005: NOTRUN -> [SKIP][17] +10 other tests skip
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10904/fi-glk-j4005/igt@kms_cursor_legacy@basic-busy-flip-before-cursor-atomic.html
* igt@kms_cursor_legacy@basic-busy-flip-before-cursor-legacy:
- bat-mtlp-8: NOTRUN -> [SKIP][18] ([i915#4213]) +1 other test skip
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10904/bat-mtlp-8/igt@kms_cursor_legacy@basic-busy-flip-before-cursor-legacy.html
* igt@kms_dsc@dsc-basic:
- bat-mtlp-8: NOTRUN -> [SKIP][19] ([i915#3555] / [i915#3840] / [i915#9159])
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10904/bat-mtlp-8/igt@kms_dsc@dsc-basic.html
* igt@kms_force_connector_basic@force-load-detect:
- bat-mtlp-8: NOTRUN -> [SKIP][20]
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10904/bat-mtlp-8/igt@kms_force_connector_basic@force-load-detect.html
* igt@kms_force_connector_basic@prune-stale-modes:
- bat-mtlp-8: NOTRUN -> [SKIP][21] ([i915#5274])
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10904/bat-mtlp-8/igt@kms_force_connector_basic@prune-stale-modes.html
* igt@kms_psr@psr-primary-mmap-gtt@edp-1:
- bat-mtlp-8: NOTRUN -> [SKIP][22] ([i915#4077] / [i915#9688])
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10904/bat-mtlp-8/igt@kms_psr@psr-primary-mmap-gtt@edp-1.html
* igt@kms_setmode@basic-clone-single-crtc:
- bat-mtlp-8: NOTRUN -> [SKIP][23] ([i915#3555] / [i915#8809])
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10904/bat-mtlp-8/igt@kms_setmode@basic-clone-single-crtc.html
* igt@prime_vgem@basic-fence-mmap:
- bat-mtlp-8: NOTRUN -> [SKIP][24] ([i915#3708] / [i915#4077]) +1 other test skip
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10904/bat-mtlp-8/igt@prime_vgem@basic-fence-mmap.html
* igt@prime_vgem@basic-fence-read:
- bat-mtlp-8: NOTRUN -> [SKIP][25] ([i915#3708]) +1 other test skip
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10904/bat-mtlp-8/igt@prime_vgem@basic-fence-read.html
* igt@prime_vgem@basic-write:
- bat-mtlp-8: NOTRUN -> [SKIP][26] ([i915#10216] / [i915#3708])
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10904/bat-mtlp-8/igt@prime_vgem@basic-write.html
#### Possible fixes ####
* igt@core_auth@basic-auth:
- fi-kbl-7567u: [DMESG-WARN][27] -> [PASS][28]
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_14480/fi-kbl-7567u/igt@core_auth@basic-auth.html
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10904/fi-kbl-7567u/igt@core_auth@basic-auth.html
* igt@vgem_basic@unload:
- fi-kbl-7567u: [DMESG-WARN][29] ([i915#8585]) -> [PASS][30]
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_14480/fi-kbl-7567u/igt@vgem_basic@unload.html
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10904/fi-kbl-7567u/igt@vgem_basic@unload.html
#### Warnings ####
* igt@debugfs_test@sysfs:
- fi-kbl-7567u: [DMESG-WARN][31] -> [DMESG-WARN][32] ([i915#9730])
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_14480/fi-kbl-7567u/igt@debugfs_test@sysfs.html
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10904/fi-kbl-7567u/igt@debugfs_test@sysfs.html
* igt@kms_addfb_basic@invalid-set-prop:
- fi-kbl-7567u: [DMESG-WARN][33] ([i915#8585]) -> [DMESG-WARN][34] ([i915#8585] / [i915#9730]) +40 other tests dmesg-warn
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_14480/fi-kbl-7567u/igt@kms_addfb_basic@invalid-set-prop.html
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10904/fi-kbl-7567u/igt@kms_addfb_basic@invalid-set-prop.html
* igt@kms_pm_rpm@basic-pci-d3-state:
- fi-kbl-7567u: [DMESG-WARN][35] ([i915#8585]) -> [DMESG-WARN][36] ([i915#180] / [i915#8585]) +37 other tests dmesg-warn
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_14480/fi-kbl-7567u/igt@kms_pm_rpm@basic-pci-d3-state.html
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10904/fi-kbl-7567u/igt@kms_pm_rpm@basic-pci-d3-state.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[i915#10216]: https://gitlab.freedesktop.org/drm/intel/issues/10216
[i915#10436]: https://gitlab.freedesktop.org/drm/intel/issues/10436
[i915#180]: https://gitlab.freedesktop.org/drm/intel/issues/180
[i915#2190]: https://gitlab.freedesktop.org/drm/intel/issues/2190
[i915#3555]: https://gitlab.freedesktop.org/drm/intel/issues/3555
[i915#3708]: https://gitlab.freedesktop.org/drm/intel/issues/3708
[i915#3840]: https://gitlab.freedesktop.org/drm/intel/issues/3840
[i915#4077]: https://gitlab.freedesktop.org/drm/intel/issues/4077
[i915#4079]: https://gitlab.freedesktop.org/drm/intel/issues/4079
[i915#4083]: https://gitlab.freedesktop.org/drm/intel/issues/4083
[i915#4212]: https://gitlab.freedesktop.org/drm/intel/issues/4212
[i915#4213]: https://gitlab.freedesktop.org/drm/intel/issues/4213
[i915#4613]: https://gitlab.freedesktop.org/drm/intel/issues/4613
[i915#5190]: https://gitlab.freedesktop.org/drm/intel/issues/5190
[i915#5274]: https://gitlab.freedesktop.org/drm/intel/issues/5274
[i915#5591]: https://gitlab.freedesktop.org/drm/intel/issues/5591
[i915#6621]: https://gitlab.freedesktop.org/drm/intel/issues/6621
[i915#8585]: https://gitlab.freedesktop.org/drm/intel/issues/8585
[i915#8809]: https://gitlab.freedesktop.org/drm/intel/issues/8809
[i915#9159]: https://gitlab.freedesktop.org/drm/intel/issues/9159
[i915#9318]: https://gitlab.freedesktop.org/drm/intel/issues/9318
[i915#9688]: https://gitlab.freedesktop.org/drm/intel/issues/9688
[i915#9730]: https://gitlab.freedesktop.org/drm/intel/issues/9730
Build changes
-------------
* CI: CI-20190529 -> None
* IGT: IGT_7782 -> IGTPW_10904
CI-20190529: 20190529
CI_DRM_14480: 17ec6923f2c5bb23280b274d6359a44a6982982e @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_10904: 10904
IGT_7782: a404f73182948e843640d00cc279883391cf6ef4 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
Testlist changes
----------------
+igt@kms_big_joiner@basic-force-joiner
+igt@kms_big_joiner@invalid-modeset-force-joiner
-igt@kms_big_joiner@2x-modeset
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10904/index.html
[-- Attachment #2: Type: text/html, Size: 12605 bytes --]
^ permalink raw reply [flat|nested] 18+ messages in thread
* ✗ Fi.CI.IGT: failure for revamp big joiner test (rev9)
2024-03-25 16:51 [PATCH i-g-t 0/4] revamp big joiner test Kunal Joshi
` (5 preceding siblings ...)
2024-03-25 20:54 ` ✓ Fi.CI.BAT: " Patchwork
@ 2024-03-26 4:17 ` Patchwork
6 siblings, 0 replies; 18+ messages in thread
From: Patchwork @ 2024-03-26 4:17 UTC (permalink / raw)
To: Kunal Joshi; +Cc: igt-dev
[-- Attachment #1: Type: text/plain, Size: 90672 bytes --]
== Series Details ==
Series: revamp big joiner test (rev9)
URL : https://patchwork.freedesktop.org/series/130572/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_14480_full -> IGTPW_10904_full
====================================================
Summary
-------
**FAILURE**
Serious unknown changes coming with IGTPW_10904_full absolutely need to be
verified manually.
If you think the reported changes have nothing to do with the changes
introduced in IGTPW_10904_full, please notify your bug team (I915-ci-infra@lists.freedesktop.org) to allow them
to document this new failure mode, which will reduce false positives in CI.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10904/index.html
Participating hosts (10 -> 9)
------------------------------
Missing (1): shard-snb-0
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in IGTPW_10904_full:
### IGT changes ###
#### Possible regressions ####
* igt@kms_big_joiner@basic:
- shard-dg1: NOTRUN -> [SKIP][1] +2 other tests skip
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10904/shard-dg1-15/igt@kms_big_joiner@basic.html
* {igt@kms_big_joiner@basic-force-joiner} (NEW):
- shard-tglu: NOTRUN -> [SKIP][2] +1 other test skip
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10904/shard-tglu-5/igt@kms_big_joiner@basic-force-joiner.html
* {igt@kms_big_joiner@invalid-modeset-force-joiner} (NEW):
- shard-dg2: NOTRUN -> [SKIP][3]
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10904/shard-dg2-5/igt@kms_big_joiner@invalid-modeset-force-joiner.html
- shard-rkl: NOTRUN -> [SKIP][4] +1 other test skip
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10904/shard-rkl-2/igt@kms_big_joiner@invalid-modeset-force-joiner.html
* igt@kms_content_protection@lic-type-0@pipe-a-dp-4:
- shard-dg2: NOTRUN -> [TIMEOUT][5]
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10904/shard-dg2-11/igt@kms_content_protection@lic-type-0@pipe-a-dp-4.html
#### Warnings ####
* igt@kms_big_joiner@basic:
- shard-rkl: [SKIP][6] ([i915#2705]) -> [SKIP][7]
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_14480/shard-rkl-5/igt@kms_big_joiner@basic.html
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10904/shard-rkl-2/igt@kms_big_joiner@basic.html
- shard-mtlp: [SKIP][8] ([i915#2705]) -> [SKIP][9]
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_14480/shard-mtlp-6/igt@kms_big_joiner@basic.html
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10904/shard-mtlp-7/igt@kms_big_joiner@basic.html
* igt@kms_big_joiner@invalid-modeset:
- shard-tglu: [SKIP][10] ([i915#2705]) -> [SKIP][11] +1 other test skip
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_14480/shard-tglu-7/igt@kms_big_joiner@invalid-modeset.html
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10904/shard-tglu-2/igt@kms_big_joiner@invalid-modeset.html
New tests
---------
New tests have been introduced between CI_DRM_14480_full and IGTPW_10904_full:
### New IGT tests (4) ###
* igt@kms_big_joiner@basic-force-joiner:
- Statuses : 5 skip(s)
- Exec time: [0.0] s
* igt@kms_big_joiner@basic-force-joiner@single:
- Statuses : 1 pass(s)
- Exec time: [2.47] s
* igt@kms_big_joiner@invalid-modeset-force-joiner:
- Statuses : 5 skip(s)
- Exec time: [0.0] s
* igt@kms_big_joiner@invalid-modeset-force-joiner@big_joiner_on_last_pipe:
- Statuses : 1 pass(s)
- Exec time: [0.04] s
Known issues
------------
Here are the changes found in IGTPW_10904_full that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@api_intel_bb@blit-reloc-keep-cache:
- shard-dg1: NOTRUN -> [SKIP][12] ([i915#8411])
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10904/shard-dg1-16/igt@api_intel_bb@blit-reloc-keep-cache.html
* igt@api_intel_bb@object-reloc-purge-cache:
- shard-dg2: NOTRUN -> [SKIP][13] ([i915#8411])
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10904/shard-dg2-11/igt@api_intel_bb@object-reloc-purge-cache.html
* igt@device_reset@unbind-cold-reset-rebind:
- shard-dg2: NOTRUN -> [SKIP][14] ([i915#7701])
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10904/shard-dg2-11/igt@device_reset@unbind-cold-reset-rebind.html
* igt@drm_fdinfo@busy-check-all@ccs0:
- shard-mtlp: NOTRUN -> [SKIP][15] ([i915#8414]) +6 other tests skip
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10904/shard-mtlp-3/igt@drm_fdinfo@busy-check-all@ccs0.html
* igt@drm_fdinfo@busy-idle@vcs1:
- shard-dg1: NOTRUN -> [SKIP][16] ([i915#8414]) +9 other tests skip
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10904/shard-dg1-14/igt@drm_fdinfo@busy-idle@vcs1.html
* igt@drm_fdinfo@idle@rcs0:
- shard-rkl: NOTRUN -> [FAIL][17] ([i915#7742])
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10904/shard-rkl-2/igt@drm_fdinfo@idle@rcs0.html
* igt@drm_fdinfo@isolation@vcs1:
- shard-dg2: NOTRUN -> [SKIP][18] ([i915#8414]) +12 other tests skip
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10904/shard-dg2-8/igt@drm_fdinfo@isolation@vcs1.html
* igt@drm_fdinfo@most-busy-idle-check-all@rcs0:
- shard-rkl: [PASS][19] -> [FAIL][20] ([i915#7742])
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_14480/shard-rkl-2/igt@drm_fdinfo@most-busy-idle-check-all@rcs0.html
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10904/shard-rkl-5/igt@drm_fdinfo@most-busy-idle-check-all@rcs0.html
* igt@gem_basic@multigpu-create-close:
- shard-rkl: NOTRUN -> [SKIP][21] ([i915#7697])
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10904/shard-rkl-5/igt@gem_basic@multigpu-create-close.html
- shard-dg2: NOTRUN -> [SKIP][22] ([i915#7697])
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10904/shard-dg2-11/igt@gem_basic@multigpu-create-close.html
* igt@gem_busy@semaphore:
- shard-dg1: NOTRUN -> [SKIP][23] ([i915#3936])
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10904/shard-dg1-15/igt@gem_busy@semaphore.html
* igt@gem_ccs@block-copy-compressed:
- shard-tglu: NOTRUN -> [SKIP][24] ([i915#3555] / [i915#9323])
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10904/shard-tglu-10/igt@gem_ccs@block-copy-compressed.html
- shard-mtlp: NOTRUN -> [SKIP][25] ([i915#3555] / [i915#9323])
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10904/shard-mtlp-2/igt@gem_ccs@block-copy-compressed.html
- shard-rkl: NOTRUN -> [SKIP][26] ([i915#3555] / [i915#9323])
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10904/shard-rkl-5/igt@gem_ccs@block-copy-compressed.html
* igt@gem_ccs@suspend-resume:
- shard-dg1: NOTRUN -> [SKIP][27] ([i915#9323])
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10904/shard-dg1-14/igt@gem_ccs@suspend-resume.html
- shard-mtlp: NOTRUN -> [SKIP][28] ([i915#9323])
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10904/shard-mtlp-5/igt@gem_ccs@suspend-resume.html
* igt@gem_create@create-ext-set-pat:
- shard-dg2: NOTRUN -> [SKIP][29] ([i915#8562])
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10904/shard-dg2-8/igt@gem_create@create-ext-set-pat.html
* igt@gem_ctx_persistence@hang:
- shard-dg2: NOTRUN -> [SKIP][30] ([i915#8555])
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10904/shard-dg2-3/igt@gem_ctx_persistence@hang.html
* igt@gem_ctx_persistence@heartbeat-hostile:
- shard-mtlp: NOTRUN -> [SKIP][31] ([i915#8555])
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10904/shard-mtlp-6/igt@gem_ctx_persistence@heartbeat-hostile.html
* igt@gem_ctx_persistence@heartbeat-many:
- shard-dg1: NOTRUN -> [SKIP][32] ([i915#8555]) +1 other test skip
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10904/shard-dg1-16/igt@gem_ctx_persistence@heartbeat-many.html
* igt@gem_ctx_persistence@legacy-engines-queued:
- shard-snb: NOTRUN -> [SKIP][33] ([i915#1099]) +1 other test skip
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10904/shard-snb4/igt@gem_ctx_persistence@legacy-engines-queued.html
* igt@gem_ctx_persistence@saturated-hostile-nopreempt@ccs0:
- shard-dg2: NOTRUN -> [SKIP][34] ([i915#5882]) +9 other tests skip
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10904/shard-dg2-6/igt@gem_ctx_persistence@saturated-hostile-nopreempt@ccs0.html
* igt@gem_ctx_sseu@invalid-args:
- shard-rkl: NOTRUN -> [SKIP][35] ([i915#280])
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10904/shard-rkl-2/igt@gem_ctx_sseu@invalid-args.html
* igt@gem_ctx_sseu@invalid-sseu:
- shard-dg1: NOTRUN -> [SKIP][36] ([i915#280]) +1 other test skip
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10904/shard-dg1-15/igt@gem_ctx_sseu@invalid-sseu.html
* igt@gem_eio@reset-stress:
- shard-dg2: [PASS][37] -> [FAIL][38] ([i915#5784])
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_14480/shard-dg2-10/igt@gem_eio@reset-stress.html
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10904/shard-dg2-5/igt@gem_eio@reset-stress.html
* igt@gem_eio@unwedge-stress:
- shard-dg1: [PASS][39] -> [FAIL][40] ([i915#5784])
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_14480/shard-dg1-17/igt@gem_eio@unwedge-stress.html
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10904/shard-dg1-15/igt@gem_eio@unwedge-stress.html
* igt@gem_exec_balancer@bonded-true-hang:
- shard-mtlp: NOTRUN -> [SKIP][41] ([i915#4812]) +1 other test skip
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10904/shard-mtlp-2/igt@gem_exec_balancer@bonded-true-hang.html
* igt@gem_exec_balancer@parallel-out-fence:
- shard-rkl: NOTRUN -> [SKIP][42] ([i915#4525])
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10904/shard-rkl-3/igt@gem_exec_balancer@parallel-out-fence.html
* igt@gem_exec_capture@capture-recoverable:
- shard-tglu: NOTRUN -> [SKIP][43] ([i915#6344])
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10904/shard-tglu-3/igt@gem_exec_capture@capture-recoverable.html
* igt@gem_exec_capture@many-4k-zero:
- shard-dg2: NOTRUN -> [FAIL][44] ([i915#9606])
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10904/shard-dg2-2/igt@gem_exec_capture@many-4k-zero.html
* igt@gem_exec_fair@basic-none-solo@rcs0:
- shard-glk: NOTRUN -> [FAIL][45] ([i915#2842])
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10904/shard-glk5/igt@gem_exec_fair@basic-none-solo@rcs0.html
- shard-rkl: [PASS][46] -> [FAIL][47] ([i915#2842])
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_14480/shard-rkl-4/igt@gem_exec_fair@basic-none-solo@rcs0.html
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10904/shard-rkl-5/igt@gem_exec_fair@basic-none-solo@rcs0.html
* igt@gem_exec_fair@basic-none-vip:
- shard-mtlp: NOTRUN -> [SKIP][48] ([i915#4473] / [i915#4771])
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10904/shard-mtlp-4/igt@gem_exec_fair@basic-none-vip.html
* igt@gem_exec_fair@basic-pace-solo:
- shard-dg1: NOTRUN -> [SKIP][49] ([i915#3539])
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10904/shard-dg1-16/igt@gem_exec_fair@basic-pace-solo.html
* igt@gem_exec_fair@basic-pace@rcs0:
- shard-tglu: [PASS][50] -> [FAIL][51] ([i915#2876])
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_14480/shard-tglu-2/igt@gem_exec_fair@basic-pace@rcs0.html
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10904/shard-tglu-4/igt@gem_exec_fair@basic-pace@rcs0.html
* igt@gem_exec_fair@basic-pace@vcs0:
- shard-rkl: NOTRUN -> [FAIL][52] ([i915#2842])
[52]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10904/shard-rkl-2/igt@gem_exec_fair@basic-pace@vcs0.html
* igt@gem_exec_fair@basic-throttle:
- shard-dg2: NOTRUN -> [SKIP][53] ([i915#3539]) +1 other test skip
[53]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10904/shard-dg2-5/igt@gem_exec_fair@basic-throttle.html
* igt@gem_exec_fence@concurrent:
- shard-dg2: NOTRUN -> [SKIP][54] ([i915#4812]) +1 other test skip
[54]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10904/shard-dg2-2/igt@gem_exec_fence@concurrent.html
* igt@gem_exec_flush@basic-batch-kernel-default-cmd:
- shard-mtlp: NOTRUN -> [SKIP][55] ([i915#3711])
[55]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10904/shard-mtlp-4/igt@gem_exec_flush@basic-batch-kernel-default-cmd.html
* igt@gem_exec_flush@basic-uc-pro-default:
- shard-dg1: NOTRUN -> [SKIP][56] ([i915#3539] / [i915#4852]) +2 other tests skip
[56]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10904/shard-dg1-15/igt@gem_exec_flush@basic-uc-pro-default.html
* igt@gem_exec_flush@basic-uc-ro-default:
- shard-dg2: NOTRUN -> [SKIP][57] ([i915#3539] / [i915#4852])
[57]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10904/shard-dg2-8/igt@gem_exec_flush@basic-uc-ro-default.html
* igt@gem_exec_params@rsvd2-dirt:
- shard-dg2: NOTRUN -> [SKIP][58] ([i915#5107])
[58]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10904/shard-dg2-3/igt@gem_exec_params@rsvd2-dirt.html
* igt@gem_exec_reloc@basic-gtt:
- shard-dg2: NOTRUN -> [SKIP][59] ([i915#3281]) +10 other tests skip
[59]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10904/shard-dg2-6/igt@gem_exec_reloc@basic-gtt.html
* igt@gem_exec_reloc@basic-wc-read-noreloc:
- shard-rkl: NOTRUN -> [SKIP][60] ([i915#3281]) +6 other tests skip
[60]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10904/shard-rkl-4/igt@gem_exec_reloc@basic-wc-read-noreloc.html
- shard-dg1: NOTRUN -> [SKIP][61] ([i915#3281]) +6 other tests skip
[61]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10904/shard-dg1-17/igt@gem_exec_reloc@basic-wc-read-noreloc.html
* igt@gem_exec_schedule@preempt-queue-chain:
- shard-mtlp: NOTRUN -> [SKIP][62] ([i915#4537] / [i915#4812])
[62]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10904/shard-mtlp-7/igt@gem_exec_schedule@preempt-queue-chain.html
* igt@gem_exec_schedule@semaphore-power:
- shard-dg1: NOTRUN -> [SKIP][63] ([i915#4812]) +2 other tests skip
[63]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10904/shard-dg1-14/igt@gem_exec_schedule@semaphore-power.html
* igt@gem_fence_thrash@bo-copy:
- shard-dg1: NOTRUN -> [SKIP][64] ([i915#4860]) +2 other tests skip
[64]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10904/shard-dg1-16/igt@gem_fence_thrash@bo-copy.html
- shard-mtlp: NOTRUN -> [SKIP][65] ([i915#4860])
[65]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10904/shard-mtlp-1/igt@gem_fence_thrash@bo-copy.html
* igt@gem_fenced_exec_thrash@2-spare-fences:
- shard-dg2: NOTRUN -> [SKIP][66] ([i915#4860]) +2 other tests skip
[66]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10904/shard-dg2-3/igt@gem_fenced_exec_thrash@2-spare-fences.html
* igt@gem_lmem_swapping@heavy-multi:
- shard-rkl: NOTRUN -> [SKIP][67] ([i915#4613]) +1 other test skip
[67]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10904/shard-rkl-6/igt@gem_lmem_swapping@heavy-multi.html
* igt@gem_lmem_swapping@heavy-multi@lmem0:
- shard-dg2: NOTRUN -> [FAIL][68] ([i915#10378])
[68]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10904/shard-dg2-3/igt@gem_lmem_swapping@heavy-multi@lmem0.html
* igt@gem_lmem_swapping@heavy-verify-random@lmem0:
- shard-dg1: [PASS][69] -> [FAIL][70] ([i915#10378])
[69]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_14480/shard-dg1-13/igt@gem_lmem_swapping@heavy-verify-random@lmem0.html
[70]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10904/shard-dg1-18/igt@gem_lmem_swapping@heavy-verify-random@lmem0.html
* igt@gem_lmem_swapping@massive-random:
- shard-glk: NOTRUN -> [SKIP][71] ([i915#4613]) +1 other test skip
[71]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10904/shard-glk3/igt@gem_lmem_swapping@massive-random.html
* igt@gem_lmem_swapping@parallel-multi:
- shard-tglu: NOTRUN -> [SKIP][72] ([i915#4613]) +1 other test skip
[72]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10904/shard-tglu-10/igt@gem_lmem_swapping@parallel-multi.html
- shard-mtlp: NOTRUN -> [SKIP][73] ([i915#4613]) +1 other test skip
[73]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10904/shard-mtlp-2/igt@gem_lmem_swapping@parallel-multi.html
* igt@gem_lmem_swapping@verify-ccs@lmem0:
- shard-dg1: NOTRUN -> [SKIP][74] ([i915#4565])
[74]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10904/shard-dg1-17/igt@gem_lmem_swapping@verify-ccs@lmem0.html
* igt@gem_mmap_gtt@big-bo:
- shard-dg1: NOTRUN -> [SKIP][75] ([i915#4077]) +6 other tests skip
[75]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10904/shard-dg1-16/igt@gem_mmap_gtt@big-bo.html
* igt@gem_mmap_gtt@cpuset-big-copy-xy:
- shard-mtlp: NOTRUN -> [SKIP][76] ([i915#4077]) +4 other tests skip
[76]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10904/shard-mtlp-4/igt@gem_mmap_gtt@cpuset-big-copy-xy.html
* igt@gem_mmap_wc@bad-object:
- shard-dg2: NOTRUN -> [SKIP][77] ([i915#4083]) +6 other tests skip
[77]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10904/shard-dg2-10/igt@gem_mmap_wc@bad-object.html
* igt@gem_mmap_wc@read-write:
- shard-mtlp: NOTRUN -> [SKIP][78] ([i915#4083]) +4 other tests skip
[78]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10904/shard-mtlp-4/igt@gem_mmap_wc@read-write.html
* igt@gem_mmap_wc@write-cpu-read-wc-unflushed:
- shard-dg1: NOTRUN -> [SKIP][79] ([i915#4083]) +4 other tests skip
[79]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10904/shard-dg1-14/igt@gem_mmap_wc@write-cpu-read-wc-unflushed.html
* igt@gem_partial_pwrite_pread@write-uncached:
- shard-dg2: NOTRUN -> [SKIP][80] ([i915#3282]) +5 other tests skip
[80]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10904/shard-dg2-8/igt@gem_partial_pwrite_pread@write-uncached.html
* igt@gem_pxp@create-valid-protected-context:
- shard-mtlp: NOTRUN -> [SKIP][81] ([i915#4270]) +1 other test skip
[81]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10904/shard-mtlp-7/igt@gem_pxp@create-valid-protected-context.html
* igt@gem_pxp@dmabuf-shared-protected-dst-is-context-refcounted:
- shard-rkl: NOTRUN -> [SKIP][82] ([i915#4270]) +3 other tests skip
[82]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10904/shard-rkl-2/igt@gem_pxp@dmabuf-shared-protected-dst-is-context-refcounted.html
* igt@gem_pxp@reject-modify-context-protection-off-2:
- shard-dg2: NOTRUN -> [SKIP][83] ([i915#4270]) +1 other test skip
[83]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10904/shard-dg2-8/igt@gem_pxp@reject-modify-context-protection-off-2.html
* igt@gem_pxp@reject-modify-context-protection-on:
- shard-dg1: NOTRUN -> [SKIP][84] ([i915#4270]) +4 other tests skip
[84]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10904/shard-dg1-17/igt@gem_pxp@reject-modify-context-protection-on.html
* igt@gem_readwrite@beyond-eob:
- shard-dg1: NOTRUN -> [SKIP][85] ([i915#3282]) +2 other tests skip
[85]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10904/shard-dg1-17/igt@gem_readwrite@beyond-eob.html
* igt@gem_render_copy@y-tiled-mc-ccs-to-yf-tiled-ccs:
- shard-dg2: NOTRUN -> [SKIP][86] ([i915#5190] / [i915#8428]) +8 other tests skip
[86]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10904/shard-dg2-2/igt@gem_render_copy@y-tiled-mc-ccs-to-yf-tiled-ccs.html
* igt@gem_render_copy@y-tiled-to-vebox-y-tiled:
- shard-mtlp: NOTRUN -> [SKIP][87] ([i915#8428]) +4 other tests skip
[87]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10904/shard-mtlp-7/igt@gem_render_copy@y-tiled-to-vebox-y-tiled.html
* igt@gem_set_tiling_vs_blt@tiled-to-tiled:
- shard-dg2: NOTRUN -> [SKIP][88] ([i915#4079]) +1 other test skip
[88]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10904/shard-dg2-8/igt@gem_set_tiling_vs_blt@tiled-to-tiled.html
- shard-rkl: NOTRUN -> [SKIP][89] ([i915#8411])
[89]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10904/shard-rkl-4/igt@gem_set_tiling_vs_blt@tiled-to-tiled.html
* igt@gem_softpin@evict-snoop-interruptible:
- shard-dg2: NOTRUN -> [SKIP][90] ([i915#4885])
[90]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10904/shard-dg2-3/igt@gem_softpin@evict-snoop-interruptible.html
* igt@gem_tiled_partial_pwrite_pread@writes:
- shard-dg2: NOTRUN -> [SKIP][91] ([i915#4077]) +10 other tests skip
[91]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10904/shard-dg2-6/igt@gem_tiled_partial_pwrite_pread@writes.html
- shard-rkl: NOTRUN -> [SKIP][92] ([i915#3282]) +7 other tests skip
[92]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10904/shard-rkl-1/igt@gem_tiled_partial_pwrite_pread@writes.html
* igt@gem_userptr_blits@coherency-unsync:
- shard-dg2: NOTRUN -> [SKIP][93] ([i915#3297]) +1 other test skip
[93]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10904/shard-dg2-8/igt@gem_userptr_blits@coherency-unsync.html
* igt@gem_userptr_blits@dmabuf-sync:
- shard-dg1: NOTRUN -> [SKIP][94] ([i915#3297])
[94]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10904/shard-dg1-14/igt@gem_userptr_blits@dmabuf-sync.html
* igt@gem_userptr_blits@dmabuf-unsync:
- shard-rkl: NOTRUN -> [SKIP][95] ([i915#3297]) +2 other tests skip
[95]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10904/shard-rkl-2/igt@gem_userptr_blits@dmabuf-unsync.html
* igt@gem_userptr_blits@relocations:
- shard-mtlp: NOTRUN -> [SKIP][96] ([i915#3281]) +3 other tests skip
[96]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10904/shard-mtlp-7/igt@gem_userptr_blits@relocations.html
* igt@gem_userptr_blits@unsync-unmap:
- shard-mtlp: NOTRUN -> [SKIP][97] ([i915#3297]) +1 other test skip
[97]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10904/shard-mtlp-8/igt@gem_userptr_blits@unsync-unmap.html
* igt@gen9_exec_parse@basic-rejected-ctx-param:
- shard-tglu: NOTRUN -> [SKIP][98] ([i915#2527] / [i915#2856])
[98]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10904/shard-tglu-8/igt@gen9_exec_parse@basic-rejected-ctx-param.html
- shard-mtlp: NOTRUN -> [SKIP][99] ([i915#2856]) +1 other test skip
[99]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10904/shard-mtlp-8/igt@gen9_exec_parse@basic-rejected-ctx-param.html
* igt@gen9_exec_parse@bb-start-cmd:
- shard-dg1: NOTRUN -> [SKIP][100] ([i915#2527]) +3 other tests skip
[100]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10904/shard-dg1-14/igt@gen9_exec_parse@bb-start-cmd.html
* igt@gen9_exec_parse@bb-start-out:
- shard-rkl: NOTRUN -> [SKIP][101] ([i915#2527]) +2 other tests skip
[101]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10904/shard-rkl-2/igt@gen9_exec_parse@bb-start-out.html
* igt@gen9_exec_parse@shadow-peek:
- shard-dg2: NOTRUN -> [SKIP][102] ([i915#2856]) +2 other tests skip
[102]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10904/shard-dg2-2/igt@gen9_exec_parse@shadow-peek.html
* igt@i915_fb_tiling:
- shard-mtlp: NOTRUN -> [SKIP][103] ([i915#4881])
[103]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10904/shard-mtlp-2/igt@i915_fb_tiling.html
* igt@i915_module_load@reload-with-fault-injection:
- shard-rkl: [PASS][104] -> [ABORT][105] ([i915#9820])
[104]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_14480/shard-rkl-5/igt@i915_module_load@reload-with-fault-injection.html
[105]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10904/shard-rkl-3/igt@i915_module_load@reload-with-fault-injection.html
- shard-dg1: NOTRUN -> [INCOMPLETE][106] ([i915#9820] / [i915#9849])
[106]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10904/shard-dg1-18/igt@i915_module_load@reload-with-fault-injection.html
- shard-glk: [PASS][107] -> [ABORT][108] ([i915#9849])
[107]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_14480/shard-glk2/igt@i915_module_load@reload-with-fault-injection.html
[108]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10904/shard-glk5/igt@i915_module_load@reload-with-fault-injection.html
- shard-mtlp: NOTRUN -> [ABORT][109] ([i915#10131] / [i915#9820])
[109]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10904/shard-mtlp-7/igt@i915_module_load@reload-with-fault-injection.html
* igt@i915_pm_freq_api@freq-suspend@gt0:
- shard-dg2: NOTRUN -> [INCOMPLETE][110] ([i915#9407])
[110]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10904/shard-dg2-6/igt@i915_pm_freq_api@freq-suspend@gt0.html
* igt@i915_pm_rc6_residency@rc6-idle@gt0-bcs0:
- shard-tglu: NOTRUN -> [WARN][111] ([i915#2681]) +3 other tests warn
[111]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10904/shard-tglu-3/igt@i915_pm_rc6_residency@rc6-idle@gt0-bcs0.html
* igt@i915_pm_rc6_residency@rc6-idle@gt0-vecs0:
- shard-dg1: [PASS][112] -> [FAIL][113] ([i915#3591])
[112]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_14480/shard-dg1-14/igt@i915_pm_rc6_residency@rc6-idle@gt0-vecs0.html
[113]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10904/shard-dg1-15/igt@i915_pm_rc6_residency@rc6-idle@gt0-vecs0.html
* igt@i915_pm_rps@min-max-config-loaded:
- shard-mtlp: NOTRUN -> [SKIP][114] ([i915#6621])
[114]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10904/shard-mtlp-8/igt@i915_pm_rps@min-max-config-loaded.html
* igt@i915_pm_rps@thresholds@gt0:
- shard-dg2: NOTRUN -> [SKIP][115] ([i915#8925]) +1 other test skip
[115]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10904/shard-dg2-8/igt@i915_pm_rps@thresholds@gt0.html
* igt@i915_query@hwconfig_table:
- shard-dg1: NOTRUN -> [SKIP][116] ([i915#6245])
[116]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10904/shard-dg1-15/igt@i915_query@hwconfig_table.html
* igt@i915_selftest@mock@memory_region:
- shard-rkl: NOTRUN -> [DMESG-WARN][117] ([i915#9311])
[117]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10904/shard-rkl-1/igt@i915_selftest@mock@memory_region.html
* igt@i915_suspend@basic-s3-without-i915:
- shard-tglu: NOTRUN -> [INCOMPLETE][118] ([i915#7443])
[118]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10904/shard-tglu-4/igt@i915_suspend@basic-s3-without-i915.html
- shard-mtlp: NOTRUN -> [SKIP][119] ([i915#6645])
[119]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10904/shard-mtlp-2/igt@i915_suspend@basic-s3-without-i915.html
* igt@kms_addfb_basic@addfb25-x-tiled-mismatch-legacy:
- shard-dg2: NOTRUN -> [SKIP][120] ([i915#4212]) +1 other test skip
[120]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10904/shard-dg2-5/igt@kms_addfb_basic@addfb25-x-tiled-mismatch-legacy.html
* igt@kms_addfb_basic@basic-x-tiled-legacy:
- shard-dg1: NOTRUN -> [SKIP][121] ([i915#4212])
[121]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10904/shard-dg1-15/igt@kms_addfb_basic@basic-x-tiled-legacy.html
* igt@kms_addfb_basic@invalid-smem-bo-on-discrete:
- shard-tglu: NOTRUN -> [SKIP][122] ([i915#3826])
[122]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10904/shard-tglu-9/igt@kms_addfb_basic@invalid-smem-bo-on-discrete.html
- shard-rkl: NOTRUN -> [SKIP][123] ([i915#3826])
[123]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10904/shard-rkl-4/igt@kms_addfb_basic@invalid-smem-bo-on-discrete.html
* igt@kms_async_flips@async-flip-with-page-flip-events@pipe-b-hdmi-a-2-y-rc-ccs-cc:
- shard-rkl: NOTRUN -> [SKIP][124] ([i915#8709]) +3 other tests skip
[124]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10904/shard-rkl-3/igt@kms_async_flips@async-flip-with-page-flip-events@pipe-b-hdmi-a-2-y-rc-ccs-cc.html
* igt@kms_async_flips@async-flip-with-page-flip-events@pipe-d-hdmi-a-3-4-mc-ccs:
- shard-dg2: NOTRUN -> [SKIP][125] ([i915#8709]) +11 other tests skip
[125]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10904/shard-dg2-6/igt@kms_async_flips@async-flip-with-page-flip-events@pipe-d-hdmi-a-3-4-mc-ccs.html
* igt@kms_atomic_transition@plane-all-modeset-transition-fencing-internal-panels:
- shard-rkl: NOTRUN -> [SKIP][126] ([i915#1769] / [i915#3555])
[126]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10904/shard-rkl-6/igt@kms_atomic_transition@plane-all-modeset-transition-fencing-internal-panels.html
* igt@kms_big_fb@4-tiled-16bpp-rotate-0:
- shard-rkl: NOTRUN -> [SKIP][127] ([i915#5286]) +6 other tests skip
[127]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10904/shard-rkl-4/igt@kms_big_fb@4-tiled-16bpp-rotate-0.html
* igt@kms_big_fb@4-tiled-8bpp-rotate-90:
- shard-dg1: NOTRUN -> [SKIP][128] ([i915#4538] / [i915#5286]) +4 other tests skip
[128]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10904/shard-dg1-14/igt@kms_big_fb@4-tiled-8bpp-rotate-90.html
* igt@kms_big_fb@4-tiled-max-hw-stride-32bpp-rotate-0-hflip-async-flip:
- shard-tglu: NOTRUN -> [SKIP][129] ([i915#5286])
[129]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10904/shard-tglu-6/igt@kms_big_fb@4-tiled-max-hw-stride-32bpp-rotate-0-hflip-async-flip.html
* igt@kms_big_fb@linear-64bpp-rotate-90:
- shard-rkl: NOTRUN -> [SKIP][130] ([i915#3638]) +1 other test skip
[130]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10904/shard-rkl-3/igt@kms_big_fb@linear-64bpp-rotate-90.html
- shard-dg1: NOTRUN -> [SKIP][131] ([i915#3638]) +2 other tests skip
[131]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10904/shard-dg1-18/igt@kms_big_fb@linear-64bpp-rotate-90.html
* igt@kms_big_fb@y-tiled-max-hw-stride-64bpp-rotate-0-hflip-async-flip:
- shard-dg2: NOTRUN -> [SKIP][132] ([i915#4538] / [i915#5190]) +17 other tests skip
[132]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10904/shard-dg2-8/igt@kms_big_fb@y-tiled-max-hw-stride-64bpp-rotate-0-hflip-async-flip.html
* igt@kms_big_fb@yf-tiled-16bpp-rotate-270:
- shard-rkl: NOTRUN -> [SKIP][133] +28 other tests skip
[133]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10904/shard-rkl-3/igt@kms_big_fb@yf-tiled-16bpp-rotate-270.html
* igt@kms_big_fb@yf-tiled-max-hw-stride-64bpp-rotate-180:
- shard-dg1: NOTRUN -> [SKIP][134] ([i915#4538]) +4 other tests skip
[134]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10904/shard-dg1-16/igt@kms_big_fb@yf-tiled-max-hw-stride-64bpp-rotate-180.html
* igt@kms_ccs@bad-pixel-format-4-tiled-dg2-rc-ccs-cc@pipe-c-edp-1:
- shard-mtlp: NOTRUN -> [SKIP][135] ([i915#6095]) +27 other tests skip
[135]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10904/shard-mtlp-8/igt@kms_ccs@bad-pixel-format-4-tiled-dg2-rc-ccs-cc@pipe-c-edp-1.html
* igt@kms_ccs@crc-primary-basic-y-tiled-gen12-rc-ccs-cc@pipe-d-dp-4:
- shard-dg2: NOTRUN -> [SKIP][136] ([i915#10307] / [i915#6095]) +136 other tests skip
[136]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10904/shard-dg2-11/igt@kms_ccs@crc-primary-basic-y-tiled-gen12-rc-ccs-cc@pipe-d-dp-4.html
* igt@kms_ccs@crc-primary-rotation-180-4-tiled-dg2-mc-ccs@pipe-b-hdmi-a-1:
- shard-rkl: NOTRUN -> [SKIP][137] ([i915#6095]) +69 other tests skip
[137]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10904/shard-rkl-5/igt@kms_ccs@crc-primary-rotation-180-4-tiled-dg2-mc-ccs@pipe-b-hdmi-a-1.html
* igt@kms_ccs@crc-primary-rotation-180-4-tiled-xe2-ccs:
- shard-rkl: NOTRUN -> [SKIP][138] ([i915#10278]) +1 other test skip
[138]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10904/shard-rkl-5/igt@kms_ccs@crc-primary-rotation-180-4-tiled-xe2-ccs.html
- shard-dg1: NOTRUN -> [SKIP][139] ([i915#10278])
[139]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10904/shard-dg1-15/igt@kms_ccs@crc-primary-rotation-180-4-tiled-xe2-ccs.html
* igt@kms_ccs@crc-primary-rotation-180-y-tiled-gen12-mc-ccs@pipe-b-hdmi-a-1:
- shard-glk: NOTRUN -> [SKIP][140] +136 other tests skip
[140]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10904/shard-glk8/igt@kms_ccs@crc-primary-rotation-180-y-tiled-gen12-mc-ccs@pipe-b-hdmi-a-1.html
* igt@kms_ccs@crc-primary-rotation-180-yf-tiled-ccs@pipe-d-hdmi-a-1:
- shard-dg2: NOTRUN -> [SKIP][141] ([i915#10307] / [i915#10434] / [i915#6095]) +2 other tests skip
[141]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10904/shard-dg2-8/igt@kms_ccs@crc-primary-rotation-180-yf-tiled-ccs@pipe-d-hdmi-a-1.html
* igt@kms_ccs@crc-sprite-planes-basic-4-tiled-mtl-rc-ccs-cc@pipe-a-hdmi-a-4:
- shard-dg1: NOTRUN -> [SKIP][142] ([i915#6095]) +67 other tests skip
[142]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10904/shard-dg1-15/igt@kms_ccs@crc-sprite-planes-basic-4-tiled-mtl-rc-ccs-cc@pipe-a-hdmi-a-4.html
* igt@kms_ccs@missing-ccs-buffer-4-tiled-mtl-mc-ccs@pipe-d-hdmi-a-1:
- shard-tglu: NOTRUN -> [SKIP][143] ([i915#6095]) +19 other tests skip
[143]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10904/shard-tglu-5/igt@kms_ccs@missing-ccs-buffer-4-tiled-mtl-mc-ccs@pipe-d-hdmi-a-1.html
* igt@kms_cdclk@plane-scaling@pipe-b-hdmi-a-3:
- shard-dg2: NOTRUN -> [SKIP][144] ([i915#4087]) +3 other tests skip
[144]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10904/shard-dg2-5/igt@kms_cdclk@plane-scaling@pipe-b-hdmi-a-3.html
* igt@kms_chamelium_color@ctm-max:
- shard-mtlp: NOTRUN -> [SKIP][145] +13 other tests skip
[145]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10904/shard-mtlp-5/igt@kms_chamelium_color@ctm-max.html
* igt@kms_chamelium_color@gamma:
- shard-tglu: NOTRUN -> [SKIP][146] +34 other tests skip
[146]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10904/shard-tglu-3/igt@kms_chamelium_color@gamma.html
* igt@kms_chamelium_frames@dp-crc-fast:
- shard-tglu: NOTRUN -> [SKIP][147] ([i915#7828]) +1 other test skip
[147]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10904/shard-tglu-3/igt@kms_chamelium_frames@dp-crc-fast.html
* igt@kms_chamelium_frames@dp-crc-single:
- shard-dg1: NOTRUN -> [SKIP][148] ([i915#7828]) +6 other tests skip
[148]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10904/shard-dg1-17/igt@kms_chamelium_frames@dp-crc-single.html
* igt@kms_chamelium_frames@hdmi-crc-fast:
- shard-dg2: NOTRUN -> [SKIP][149] ([i915#7828]) +12 other tests skip
[149]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10904/shard-dg2-8/igt@kms_chamelium_frames@hdmi-crc-fast.html
* igt@kms_chamelium_hpd@dp-hpd:
- shard-rkl: NOTRUN -> [SKIP][150] ([i915#7828]) +10 other tests skip
[150]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10904/shard-rkl-1/igt@kms_chamelium_hpd@dp-hpd.html
* igt@kms_chamelium_hpd@hdmi-hpd:
- shard-mtlp: NOTRUN -> [SKIP][151] ([i915#7828]) +5 other tests skip
[151]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10904/shard-mtlp-8/igt@kms_chamelium_hpd@hdmi-hpd.html
* igt@kms_content_protection@atomic:
- shard-dg2: NOTRUN -> [SKIP][152] ([i915#7118] / [i915#9424])
[152]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10904/shard-dg2-10/igt@kms_content_protection@atomic.html
* igt@kms_content_protection@dp-mst-lic-type-1:
- shard-dg2: NOTRUN -> [SKIP][153] ([i915#3299])
[153]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10904/shard-dg2-8/igt@kms_content_protection@dp-mst-lic-type-1.html
* igt@kms_content_protection@dp-mst-type-0:
- shard-dg1: NOTRUN -> [SKIP][154] ([i915#3299])
[154]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10904/shard-dg1-18/igt@kms_content_protection@dp-mst-type-0.html
* igt@kms_content_protection@dp-mst-type-1:
- shard-tglu: NOTRUN -> [SKIP][155] ([i915#3116] / [i915#3299])
[155]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10904/shard-tglu-7/igt@kms_content_protection@dp-mst-type-1.html
- shard-mtlp: NOTRUN -> [SKIP][156] ([i915#3299])
[156]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10904/shard-mtlp-4/igt@kms_content_protection@dp-mst-type-1.html
* igt@kms_content_protection@lic-type-0:
- shard-dg1: NOTRUN -> [SKIP][157] ([i915#9424])
[157]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10904/shard-dg1-17/igt@kms_content_protection@lic-type-0.html
* igt@kms_content_protection@srm:
- shard-rkl: NOTRUN -> [SKIP][158] ([i915#7118])
[158]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10904/shard-rkl-4/igt@kms_content_protection@srm.html
- shard-tglu: NOTRUN -> [SKIP][159] ([i915#6944] / [i915#7116] / [i915#7118])
[159]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10904/shard-tglu-7/igt@kms_content_protection@srm.html
- shard-mtlp: NOTRUN -> [SKIP][160] ([i915#6944])
[160]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10904/shard-mtlp-8/igt@kms_content_protection@srm.html
* igt@kms_cursor_crc@cursor-offscreen-32x32:
- shard-dg1: NOTRUN -> [SKIP][161] ([i915#3555]) +2 other tests skip
[161]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10904/shard-dg1-17/igt@kms_cursor_crc@cursor-offscreen-32x32.html
* igt@kms_cursor_crc@cursor-onscreen-512x170:
- shard-dg2: NOTRUN -> [SKIP][162] ([i915#3359]) +1 other test skip
[162]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10904/shard-dg2-8/igt@kms_cursor_crc@cursor-onscreen-512x170.html
* igt@kms_cursor_crc@cursor-random-512x512:
- shard-rkl: NOTRUN -> [SKIP][163] ([i915#3359]) +1 other test skip
[163]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10904/shard-rkl-1/igt@kms_cursor_crc@cursor-random-512x512.html
- shard-dg1: NOTRUN -> [SKIP][164] ([i915#3359]) +1 other test skip
[164]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10904/shard-dg1-18/igt@kms_cursor_crc@cursor-random-512x512.html
* igt@kms_cursor_crc@cursor-rapid-movement-max-size:
- shard-dg2: NOTRUN -> [SKIP][165] ([i915#3555]) +8 other tests skip
[165]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10904/shard-dg2-11/igt@kms_cursor_crc@cursor-rapid-movement-max-size.html
- shard-rkl: NOTRUN -> [SKIP][166] ([i915#3555]) +6 other tests skip
[166]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10904/shard-rkl-5/igt@kms_cursor_crc@cursor-rapid-movement-max-size.html
* igt@kms_cursor_crc@cursor-sliding-128x42:
- shard-mtlp: NOTRUN -> [SKIP][167] ([i915#8814]) +2 other tests skip
[167]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10904/shard-mtlp-4/igt@kms_cursor_crc@cursor-sliding-128x42.html
* igt@kms_cursor_crc@cursor-sliding-512x512:
- shard-mtlp: NOTRUN -> [SKIP][168] ([i915#3359])
[168]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10904/shard-mtlp-7/igt@kms_cursor_crc@cursor-sliding-512x512.html
* igt@kms_cursor_legacy@basic-busy-flip-before-cursor-atomic:
- shard-dg2: NOTRUN -> [SKIP][169] ([i915#4103] / [i915#4213]) +1 other test skip
[169]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10904/shard-dg2-6/igt@kms_cursor_legacy@basic-busy-flip-before-cursor-atomic.html
* igt@kms_cursor_legacy@cursorb-vs-flipa-toggle:
- shard-mtlp: NOTRUN -> [SKIP][170] ([i915#9809]) +4 other tests skip
[170]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10904/shard-mtlp-8/igt@kms_cursor_legacy@cursorb-vs-flipa-toggle.html
* igt@kms_cursor_legacy@modeset-atomic-cursor-hotspot:
- shard-dg1: NOTRUN -> [SKIP][171] ([i915#9067])
[171]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10904/shard-dg1-16/igt@kms_cursor_legacy@modeset-atomic-cursor-hotspot.html
* igt@kms_cursor_legacy@short-busy-flip-before-cursor-atomic-transitions-varying-size:
- shard-mtlp: NOTRUN -> [SKIP][172] ([i915#4213])
[172]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10904/shard-mtlp-4/igt@kms_cursor_legacy@short-busy-flip-before-cursor-atomic-transitions-varying-size.html
- shard-rkl: NOTRUN -> [SKIP][173] ([i915#4103])
[173]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10904/shard-rkl-3/igt@kms_cursor_legacy@short-busy-flip-before-cursor-atomic-transitions-varying-size.html
- shard-tglu: NOTRUN -> [SKIP][174] ([i915#4103])
[174]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10904/shard-tglu-10/igt@kms_cursor_legacy@short-busy-flip-before-cursor-atomic-transitions-varying-size.html
* igt@kms_cursor_legacy@torture-move@pipe-a:
- shard-tglu: [PASS][175] -> [DMESG-WARN][176] ([i915#10166] / [i915#1982])
[175]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_14480/shard-tglu-9/igt@kms_cursor_legacy@torture-move@pipe-a.html
[176]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10904/shard-tglu-3/igt@kms_cursor_legacy@torture-move@pipe-a.html
* igt@kms_dirtyfb@psr-dirtyfb-ioctl:
- shard-rkl: NOTRUN -> [SKIP][177] ([i915#9723])
[177]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10904/shard-rkl-4/igt@kms_dirtyfb@psr-dirtyfb-ioctl.html
* igt@kms_dither@fb-8bpc-vs-panel-6bpc@pipe-a-hdmi-a-1:
- shard-rkl: NOTRUN -> [SKIP][178] ([i915#3804])
[178]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10904/shard-rkl-2/igt@kms_dither@fb-8bpc-vs-panel-6bpc@pipe-a-hdmi-a-1.html
* igt@kms_dp_aux_dev:
- shard-dg2: NOTRUN -> [SKIP][179] ([i915#1257])
[179]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10904/shard-dg2-3/igt@kms_dp_aux_dev.html
* igt@kms_draw_crc@draw-method-mmap-wc:
- shard-dg2: NOTRUN -> [SKIP][180] ([i915#8812])
[180]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10904/shard-dg2-10/igt@kms_draw_crc@draw-method-mmap-wc.html
* igt@kms_dsc@dsc-basic:
- shard-dg2: NOTRUN -> [SKIP][181] ([i915#3555] / [i915#3840])
[181]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10904/shard-dg2-10/igt@kms_dsc@dsc-basic.html
* igt@kms_dsc@dsc-with-bpc:
- shard-rkl: NOTRUN -> [SKIP][182] ([i915#3555] / [i915#3840])
[182]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10904/shard-rkl-5/igt@kms_dsc@dsc-with-bpc.html
* igt@kms_dsc@dsc-with-output-formats-with-bpc:
- shard-mtlp: NOTRUN -> [SKIP][183] ([i915#3555] / [i915#3840] / [i915#9053])
[183]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10904/shard-mtlp-8/igt@kms_dsc@dsc-with-output-formats-with-bpc.html
* igt@kms_fbcon_fbt@psr-suspend:
- shard-dg1: NOTRUN -> [SKIP][184] ([i915#3469]) +1 other test skip
[184]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10904/shard-dg1-14/igt@kms_fbcon_fbt@psr-suspend.html
* igt@kms_feature_discovery@chamelium:
- shard-tglu: NOTRUN -> [SKIP][185] ([i915#2065] / [i915#4854])
[185]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10904/shard-tglu-7/igt@kms_feature_discovery@chamelium.html
- shard-mtlp: NOTRUN -> [SKIP][186] ([i915#4854])
[186]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10904/shard-mtlp-4/igt@kms_feature_discovery@chamelium.html
* igt@kms_feature_discovery@psr2:
- shard-dg1: NOTRUN -> [SKIP][187] ([i915#658])
[187]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10904/shard-dg1-16/igt@kms_feature_discovery@psr2.html
- shard-tglu: NOTRUN -> [SKIP][188] ([i915#658])
[188]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10904/shard-tglu-6/igt@kms_feature_discovery@psr2.html
- shard-dg2: NOTRUN -> [SKIP][189] ([i915#658])
[189]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10904/shard-dg2-8/igt@kms_feature_discovery@psr2.html
* igt@kms_flip@2x-nonexisting-fb-interruptible:
- shard-tglu: NOTRUN -> [SKIP][190] ([i915#3637]) +2 other tests skip
[190]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10904/shard-tglu-8/igt@kms_flip@2x-nonexisting-fb-interruptible.html
- shard-mtlp: NOTRUN -> [SKIP][191] ([i915#3637]) +3 other tests skip
[191]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10904/shard-mtlp-8/igt@kms_flip@2x-nonexisting-fb-interruptible.html
* igt@kms_flip@2x-wf_vblank-ts-check:
- shard-dg1: NOTRUN -> [SKIP][192] ([i915#9934]) +5 other tests skip
[192]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10904/shard-dg1-16/igt@kms_flip@2x-wf_vblank-ts-check.html
* igt@kms_flip@flip-vs-expired-vblank-interruptible@a-hdmi-a1:
- shard-glk: NOTRUN -> [FAIL][193] ([i915#79])
[193]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10904/shard-glk9/igt@kms_flip@flip-vs-expired-vblank-interruptible@a-hdmi-a1.html
* igt@kms_flip@flip-vs-fences:
- shard-dg2: NOTRUN -> [SKIP][194] ([i915#8381])
[194]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10904/shard-dg2-2/igt@kms_flip@flip-vs-fences.html
* igt@kms_flip_scaled_crc@flip-32bpp-yftile-to-32bpp-yftileccs-downscaling@pipe-a-valid-mode:
- shard-dg1: NOTRUN -> [SKIP][195] ([i915#2587] / [i915#2672]) +1 other test skip
[195]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10904/shard-dg1-17/igt@kms_flip_scaled_crc@flip-32bpp-yftile-to-32bpp-yftileccs-downscaling@pipe-a-valid-mode.html
* igt@kms_flip_scaled_crc@flip-32bpp-yftile-to-32bpp-yftileccs-upscaling@pipe-a-valid-mode:
- shard-tglu: NOTRUN -> [SKIP][196] ([i915#2587] / [i915#2672])
[196]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10904/shard-tglu-10/igt@kms_flip_scaled_crc@flip-32bpp-yftile-to-32bpp-yftileccs-upscaling@pipe-a-valid-mode.html
* igt@kms_flip_scaled_crc@flip-32bpp-ytile-to-32bpp-ytilegen12rcccs-downscaling@pipe-a-valid-mode:
- shard-dg2: NOTRUN -> [SKIP][197] ([i915#2672]) +7 other tests skip
[197]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10904/shard-dg2-2/igt@kms_flip_scaled_crc@flip-32bpp-ytile-to-32bpp-ytilegen12rcccs-downscaling@pipe-a-valid-mode.html
* igt@kms_flip_scaled_crc@flip-64bpp-4tile-to-16bpp-4tile-downscaling@pipe-a-valid-mode:
- shard-rkl: NOTRUN -> [SKIP][198] ([i915#2672]) +2 other tests skip
[198]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10904/shard-rkl-5/igt@kms_flip_scaled_crc@flip-64bpp-4tile-to-16bpp-4tile-downscaling@pipe-a-valid-mode.html
* igt@kms_flip_scaled_crc@flip-64bpp-xtile-to-16bpp-xtile-downscaling@pipe-a-default-mode:
- shard-mtlp: NOTRUN -> [SKIP][199] ([i915#3555] / [i915#8810])
[199]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10904/shard-mtlp-8/igt@kms_flip_scaled_crc@flip-64bpp-xtile-to-16bpp-xtile-downscaling@pipe-a-default-mode.html
* igt@kms_flip_scaled_crc@flip-64bpp-yftile-to-32bpp-yftile-downscaling@pipe-a-default-mode:
- shard-mtlp: NOTRUN -> [SKIP][200] ([i915#2672]) +2 other tests skip
[200]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10904/shard-mtlp-6/igt@kms_flip_scaled_crc@flip-64bpp-yftile-to-32bpp-yftile-downscaling@pipe-a-default-mode.html
* igt@kms_frontbuffer_tracking@fbc-1p-primscrn-cur-indfb-move:
- shard-dg2: NOTRUN -> [FAIL][201] ([i915#6880])
[201]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10904/shard-dg2-1/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-cur-indfb-move.html
* igt@kms_frontbuffer_tracking@fbc-1p-primscrn-pri-shrfb-draw-mmap-cpu:
- shard-dg2: [PASS][202] -> [FAIL][203] ([i915#6880]) +1 other test fail
[202]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_14480/shard-dg2-2/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-pri-shrfb-draw-mmap-cpu.html
[203]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10904/shard-dg2-3/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-pri-shrfb-draw-mmap-cpu.html
* igt@kms_frontbuffer_tracking@fbc-2p-primscrn-pri-shrfb-draw-mmap-gtt:
- shard-dg2: NOTRUN -> [SKIP][204] ([i915#8708]) +15 other tests skip
[204]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10904/shard-dg2-3/igt@kms_frontbuffer_tracking@fbc-2p-primscrn-pri-shrfb-draw-mmap-gtt.html
* igt@kms_frontbuffer_tracking@fbc-2p-rte:
- shard-dg2: NOTRUN -> [SKIP][205] ([i915#5354]) +44 other tests skip
[205]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10904/shard-dg2-6/igt@kms_frontbuffer_tracking@fbc-2p-rte.html
* igt@kms_frontbuffer_tracking@fbc-tiling-y:
- shard-dg2: NOTRUN -> [SKIP][206] ([i915#10055])
[206]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10904/shard-dg2-11/igt@kms_frontbuffer_tracking@fbc-tiling-y.html
* igt@kms_frontbuffer_tracking@fbcpsr-1p-offscren-pri-shrfb-draw-render:
- shard-dg1: NOTRUN -> [SKIP][207] ([i915#3458]) +19 other tests skip
[207]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10904/shard-dg1-17/igt@kms_frontbuffer_tracking@fbcpsr-1p-offscren-pri-shrfb-draw-render.html
* igt@kms_frontbuffer_tracking@fbcpsr-2p-primscrn-cur-indfb-draw-mmap-gtt:
- shard-rkl: NOTRUN -> [SKIP][208] ([i915#1825]) +29 other tests skip
[208]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10904/shard-rkl-5/igt@kms_frontbuffer_tracking@fbcpsr-2p-primscrn-cur-indfb-draw-mmap-gtt.html
* igt@kms_frontbuffer_tracking@fbcpsr-2p-scndscrn-spr-indfb-draw-pwrite:
- shard-dg1: NOTRUN -> [SKIP][209] +29 other tests skip
[209]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10904/shard-dg1-18/igt@kms_frontbuffer_tracking@fbcpsr-2p-scndscrn-spr-indfb-draw-pwrite.html
* igt@kms_frontbuffer_tracking@fbcpsr-tiling-4:
- shard-rkl: NOTRUN -> [SKIP][210] ([i915#5439])
[210]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10904/shard-rkl-3/igt@kms_frontbuffer_tracking@fbcpsr-tiling-4.html
- shard-dg1: NOTRUN -> [SKIP][211] ([i915#5439])
[211]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10904/shard-dg1-18/igt@kms_frontbuffer_tracking@fbcpsr-tiling-4.html
* igt@kms_frontbuffer_tracking@psr-1p-offscren-pri-shrfb-draw-mmap-gtt:
- shard-dg1: NOTRUN -> [SKIP][212] ([i915#8708]) +15 other tests skip
[212]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10904/shard-dg1-17/igt@kms_frontbuffer_tracking@psr-1p-offscren-pri-shrfb-draw-mmap-gtt.html
* igt@kms_frontbuffer_tracking@psr-1p-primscrn-spr-indfb-draw-pwrite:
- shard-rkl: NOTRUN -> [SKIP][213] ([i915#3023]) +25 other tests skip
[213]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10904/shard-rkl-2/igt@kms_frontbuffer_tracking@psr-1p-primscrn-spr-indfb-draw-pwrite.html
* igt@kms_frontbuffer_tracking@psr-1p-primscrn-spr-indfb-onoff:
- shard-dg2: NOTRUN -> [SKIP][214] ([i915#3458]) +21 other tests skip
[214]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10904/shard-dg2-1/igt@kms_frontbuffer_tracking@psr-1p-primscrn-spr-indfb-onoff.html
* igt@kms_frontbuffer_tracking@psr-2p-primscrn-indfb-pgflip-blt:
- shard-mtlp: NOTRUN -> [SKIP][215] ([i915#1825]) +19 other tests skip
[215]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10904/shard-mtlp-6/igt@kms_frontbuffer_tracking@psr-2p-primscrn-indfb-pgflip-blt.html
* igt@kms_frontbuffer_tracking@psr-2p-scndscrn-pri-indfb-draw-mmap-gtt:
- shard-mtlp: NOTRUN -> [SKIP][216] ([i915#8708]) +3 other tests skip
[216]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10904/shard-mtlp-8/igt@kms_frontbuffer_tracking@psr-2p-scndscrn-pri-indfb-draw-mmap-gtt.html
* igt@kms_frontbuffer_tracking@psr-2p-scndscrn-pri-indfb-draw-mmap-wc:
- shard-snb: NOTRUN -> [SKIP][217] +108 other tests skip
[217]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10904/shard-snb2/igt@kms_frontbuffer_tracking@psr-2p-scndscrn-pri-indfb-draw-mmap-wc.html
* igt@kms_hdr@static-swap:
- shard-dg1: NOTRUN -> [SKIP][218] ([i915#3555] / [i915#8228]) +2 other tests skip
[218]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10904/shard-dg1-16/igt@kms_hdr@static-swap.html
* igt@kms_hdr@static-toggle-suspend:
- shard-dg2: NOTRUN -> [SKIP][219] ([i915#3555] / [i915#8228])
[219]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10904/shard-dg2-6/igt@kms_hdr@static-toggle-suspend.html
- shard-tglu: NOTRUN -> [SKIP][220] ([i915#3555] / [i915#8228])
[220]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10904/shard-tglu-8/igt@kms_hdr@static-toggle-suspend.html
* igt@kms_multipipe_modeset@basic-max-pipe-crc-check:
- shard-mtlp: NOTRUN -> [SKIP][221] ([i915#4816])
[221]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10904/shard-mtlp-1/igt@kms_multipipe_modeset@basic-max-pipe-crc-check.html
- shard-dg2: NOTRUN -> [SKIP][222] ([i915#4816])
[222]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10904/shard-dg2-11/igt@kms_multipipe_modeset@basic-max-pipe-crc-check.html
- shard-dg1: NOTRUN -> [SKIP][223] ([i915#1839])
[223]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10904/shard-dg1-16/igt@kms_multipipe_modeset@basic-max-pipe-crc-check.html
- shard-tglu: NOTRUN -> [SKIP][224] ([i915#1839])
[224]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10904/shard-tglu-2/igt@kms_multipipe_modeset@basic-max-pipe-crc-check.html
* igt@kms_panel_fitting@legacy:
- shard-dg2: NOTRUN -> [SKIP][225] ([i915#6301])
[225]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10904/shard-dg2-6/igt@kms_panel_fitting@legacy.html
* igt@kms_pipe_b_c_ivb@from-pipe-c-to-b-with-3-lanes:
- shard-dg2: NOTRUN -> [SKIP][226] +22 other tests skip
[226]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10904/shard-dg2-11/igt@kms_pipe_b_c_ivb@from-pipe-c-to-b-with-3-lanes.html
* igt@kms_plane_lowres@tiling-y:
- shard-dg2: NOTRUN -> [SKIP][227] ([i915#8821])
[227]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10904/shard-dg2-8/igt@kms_plane_lowres@tiling-y.html
* igt@kms_plane_lowres@tiling-yf:
- shard-mtlp: NOTRUN -> [SKIP][228] ([i915#3555] / [i915#8821])
[228]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10904/shard-mtlp-5/igt@kms_plane_lowres@tiling-yf.html
* igt@kms_plane_multiple@tiling-yf:
- shard-mtlp: NOTRUN -> [SKIP][229] ([i915#3555] / [i915#8806])
[229]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10904/shard-mtlp-4/igt@kms_plane_multiple@tiling-yf.html
* igt@kms_plane_scaling@plane-downscale-factor-0-25-with-pixel-format@pipe-b-hdmi-a-3:
- shard-dg2: NOTRUN -> [SKIP][230] ([i915#9423]) +7 other tests skip
[230]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10904/shard-dg2-1/igt@kms_plane_scaling@plane-downscale-factor-0-25-with-pixel-format@pipe-b-hdmi-a-3.html
* igt@kms_plane_scaling@plane-downscale-factor-0-25-with-rotation@pipe-a-hdmi-a-4:
- shard-dg1: NOTRUN -> [SKIP][231] ([i915#9423]) +15 other tests skip
[231]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10904/shard-dg1-18/igt@kms_plane_scaling@plane-downscale-factor-0-25-with-rotation@pipe-a-hdmi-a-4.html
* igt@kms_plane_scaling@plane-downscale-factor-0-5-with-pixel-format@pipe-c-edp-1:
- shard-mtlp: NOTRUN -> [SKIP][232] ([i915#5176]) +3 other tests skip
[232]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10904/shard-mtlp-8/igt@kms_plane_scaling@plane-downscale-factor-0-5-with-pixel-format@pipe-c-edp-1.html
* igt@kms_plane_scaling@plane-downscale-factor-0-5-with-rotation@pipe-a-hdmi-a-1:
- shard-rkl: NOTRUN -> [SKIP][233] ([i915#9423]) +7 other tests skip
[233]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10904/shard-rkl-5/igt@kms_plane_scaling@plane-downscale-factor-0-5-with-rotation@pipe-a-hdmi-a-1.html
* igt@kms_plane_scaling@plane-scaler-unity-scaling-with-rotation@pipe-a-hdmi-a-1:
- shard-tglu: NOTRUN -> [SKIP][234] ([i915#9423]) +3 other tests skip
[234]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10904/shard-tglu-5/igt@kms_plane_scaling@plane-scaler-unity-scaling-with-rotation@pipe-a-hdmi-a-1.html
* igt@kms_plane_scaling@planes-downscale-factor-0-25-upscale-factor-0-25@pipe-b-hdmi-a-3:
- shard-dg1: NOTRUN -> [SKIP][235] ([i915#5235]) +7 other tests skip
[235]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10904/shard-dg1-13/igt@kms_plane_scaling@planes-downscale-factor-0-25-upscale-factor-0-25@pipe-b-hdmi-a-3.html
* igt@kms_plane_scaling@planes-unity-scaling-downscale-factor-0-25@pipe-a-edp-1:
- shard-mtlp: NOTRUN -> [SKIP][236] ([i915#5235]) +2 other tests skip
[236]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10904/shard-mtlp-1/igt@kms_plane_scaling@planes-unity-scaling-downscale-factor-0-25@pipe-a-edp-1.html
* igt@kms_plane_scaling@planes-unity-scaling-downscale-factor-0-25@pipe-a-hdmi-a-1:
- shard-tglu: NOTRUN -> [SKIP][237] ([i915#5235]) +3 other tests skip
[237]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10904/shard-tglu-2/igt@kms_plane_scaling@planes-unity-scaling-downscale-factor-0-25@pipe-a-hdmi-a-1.html
* igt@kms_plane_scaling@planes-unity-scaling-downscale-factor-0-25@pipe-a-hdmi-a-2:
- shard-rkl: NOTRUN -> [SKIP][238] ([i915#5235]) +5 other tests skip
[238]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10904/shard-rkl-1/igt@kms_plane_scaling@planes-unity-scaling-downscale-factor-0-25@pipe-a-hdmi-a-2.html
* igt@kms_plane_scaling@planes-unity-scaling-downscale-factor-0-25@pipe-b-dp-4:
- shard-dg2: NOTRUN -> [SKIP][239] ([i915#5235] / [i915#9423]) +15 other tests skip
[239]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10904/shard-dg2-11/igt@kms_plane_scaling@planes-unity-scaling-downscale-factor-0-25@pipe-b-dp-4.html
* igt@kms_plane_scaling@planes-unity-scaling-downscale-factor-0-25@pipe-d-edp-1:
- shard-mtlp: NOTRUN -> [SKIP][240] ([i915#3555] / [i915#5235])
[240]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10904/shard-mtlp-1/igt@kms_plane_scaling@planes-unity-scaling-downscale-factor-0-25@pipe-d-edp-1.html
* igt@kms_pm_backlight@bad-brightness:
- shard-rkl: NOTRUN -> [SKIP][241] ([i915#5354])
[241]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10904/shard-rkl-1/igt@kms_pm_backlight@bad-brightness.html
* igt@kms_pm_dc@dc6-dpms:
- shard-tglu: [PASS][242] -> [FAIL][243] ([i915#9295])
[242]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_14480/shard-tglu-10/igt@kms_pm_dc@dc6-dpms.html
[243]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10904/shard-tglu-8/igt@kms_pm_dc@dc6-dpms.html
* igt@kms_pm_rpm@dpms-mode-unset-non-lpsp:
- shard-rkl: [PASS][244] -> [SKIP][245] ([i915#9519]) +1 other test skip
[244]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_14480/shard-rkl-6/igt@kms_pm_rpm@dpms-mode-unset-non-lpsp.html
[245]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10904/shard-rkl-5/igt@kms_pm_rpm@dpms-mode-unset-non-lpsp.html
* igt@kms_pm_rpm@modeset-lpsp:
- shard-dg1: NOTRUN -> [SKIP][246] ([i915#9519]) +1 other test skip
[246]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10904/shard-dg1-16/igt@kms_pm_rpm@modeset-lpsp.html
* igt@kms_pm_rpm@modeset-lpsp-stress:
- shard-rkl: NOTRUN -> [SKIP][247] ([i915#9519])
[247]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10904/shard-rkl-3/igt@kms_pm_rpm@modeset-lpsp-stress.html
* igt@kms_prime@basic-crc-hybrid:
- shard-dg2: NOTRUN -> [SKIP][248] ([i915#6524] / [i915#6805]) +1 other test skip
[248]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10904/shard-dg2-11/igt@kms_prime@basic-crc-hybrid.html
* igt@kms_prime@basic-modeset-hybrid:
- shard-rkl: NOTRUN -> [SKIP][249] ([i915#6524])
[249]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10904/shard-rkl-4/igt@kms_prime@basic-modeset-hybrid.html
* igt@kms_psr2_sf@fbc-overlay-plane-move-continuous-exceed-fully-sf@psr2-pipe-a-edp-1:
- shard-mtlp: NOTRUN -> [SKIP][250] ([i915#9808]) +1 other test skip
[250]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10904/shard-mtlp-2/igt@kms_psr2_sf@fbc-overlay-plane-move-continuous-exceed-fully-sf@psr2-pipe-a-edp-1.html
* igt@kms_psr2_su@frontbuffer-xrgb8888:
- shard-dg2: NOTRUN -> [SKIP][251] ([i915#9683]) +1 other test skip
[251]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10904/shard-dg2-2/igt@kms_psr2_su@frontbuffer-xrgb8888.html
* igt@kms_psr2_su@page_flip-p010:
- shard-rkl: NOTRUN -> [SKIP][252] ([i915#9683])
[252]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10904/shard-rkl-6/igt@kms_psr2_su@page_flip-p010.html
* igt@kms_psr2_su@page_flip-xrgb8888:
- shard-dg1: NOTRUN -> [SKIP][253] ([i915#9683])
[253]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10904/shard-dg1-18/igt@kms_psr2_su@page_flip-xrgb8888.html
* igt@kms_psr@fbc-pr-cursor-plane-move:
- shard-mtlp: NOTRUN -> [SKIP][254] ([i915#9688]) +7 other tests skip
[254]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10904/shard-mtlp-2/igt@kms_psr@fbc-pr-cursor-plane-move.html
* igt@kms_psr@fbc-pr-no-drrs:
- shard-rkl: NOTRUN -> [SKIP][255] ([i915#1072] / [i915#9732]) +18 other tests skip
[255]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10904/shard-rkl-1/igt@kms_psr@fbc-pr-no-drrs.html
* igt@kms_psr@psr-cursor-mmap-cpu:
- shard-tglu: NOTRUN -> [SKIP][256] ([i915#9732]) +5 other tests skip
[256]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10904/shard-tglu-3/igt@kms_psr@psr-cursor-mmap-cpu.html
* igt@kms_psr@psr-cursor-render:
- shard-dg2: NOTRUN -> [SKIP][257] ([i915#1072] / [i915#9673] / [i915#9732]) +5 other tests skip
[257]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10904/shard-dg2-11/igt@kms_psr@psr-cursor-render.html
* igt@kms_psr@psr-primary-mmap-cpu:
- shard-dg2: NOTRUN -> [SKIP][258] ([i915#1072] / [i915#9732]) +17 other tests skip
[258]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10904/shard-dg2-8/igt@kms_psr@psr-primary-mmap-cpu.html
* igt@kms_psr@psr-sprite-plane-onoff:
- shard-dg1: NOTRUN -> [SKIP][259] ([i915#1072] / [i915#9732]) +16 other tests skip
[259]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10904/shard-dg1-17/igt@kms_psr@psr-sprite-plane-onoff.html
* igt@kms_rotation_crc@primary-rotation-270:
- shard-mtlp: NOTRUN -> [SKIP][260] ([i915#4235])
[260]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10904/shard-mtlp-7/igt@kms_rotation_crc@primary-rotation-270.html
* igt@kms_rotation_crc@primary-y-tiled-reflect-x-0:
- shard-dg2: NOTRUN -> [SKIP][261] ([i915#5190]) +2 other tests skip
[261]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10904/shard-dg2-10/igt@kms_rotation_crc@primary-y-tiled-reflect-x-0.html
* igt@kms_rotation_crc@primary-yf-tiled-reflect-x-180:
- shard-rkl: NOTRUN -> [SKIP][262] ([i915#5289]) +1 other test skip
[262]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10904/shard-rkl-3/igt@kms_rotation_crc@primary-yf-tiled-reflect-x-180.html
* igt@kms_rotation_crc@primary-yf-tiled-reflect-x-270:
- shard-dg2: NOTRUN -> [SKIP][263] ([i915#4235] / [i915#5190])
[263]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10904/shard-dg2-1/igt@kms_rotation_crc@primary-yf-tiled-reflect-x-270.html
* igt@kms_rotation_crc@primary-yf-tiled-reflect-x-90:
- shard-dg1: NOTRUN -> [SKIP][264] ([i915#5289]) +1 other test skip
[264]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10904/shard-dg1-18/igt@kms_rotation_crc@primary-yf-tiled-reflect-x-90.html
* igt@kms_rotation_crc@sprite-rotation-90-pos-100-0:
- shard-dg2: NOTRUN -> [SKIP][265] ([i915#4235])
[265]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10904/shard-dg2-5/igt@kms_rotation_crc@sprite-rotation-90-pos-100-0.html
* igt@kms_scaling_modes@scaling-mode-full:
- shard-tglu: NOTRUN -> [SKIP][266] ([i915#3555]) +1 other test skip
[266]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10904/shard-tglu-8/igt@kms_scaling_modes@scaling-mode-full.html
* igt@kms_sysfs_edid_timing:
- shard-dg2: NOTRUN -> [FAIL][267] ([IGT#2])
[267]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10904/shard-dg2-8/igt@kms_sysfs_edid_timing.html
* igt@kms_tiled_display@basic-test-pattern:
- shard-tglu: NOTRUN -> [SKIP][268] ([i915#8623])
[268]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10904/shard-tglu-8/igt@kms_tiled_display@basic-test-pattern.html
- shard-mtlp: NOTRUN -> [SKIP][269] ([i915#8623])
[269]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10904/shard-mtlp-8/igt@kms_tiled_display@basic-test-pattern.html
- shard-rkl: NOTRUN -> [SKIP][270] ([i915#8623])
[270]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10904/shard-rkl-5/igt@kms_tiled_display@basic-test-pattern.html
* igt@kms_universal_plane@cursor-fb-leak@pipe-c-edp-1:
- shard-mtlp: [PASS][271] -> [FAIL][272] ([i915#9196]) +1 other test fail
[271]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_14480/shard-mtlp-2/igt@kms_universal_plane@cursor-fb-leak@pipe-c-edp-1.html
[272]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10904/shard-mtlp-2/igt@kms_universal_plane@cursor-fb-leak@pipe-c-edp-1.html
* igt@kms_universal_plane@cursor-fb-leak@pipe-c-hdmi-a-4:
- shard-dg1: NOTRUN -> [FAIL][273] ([i915#9196])
[273]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10904/shard-dg1-15/igt@kms_universal_plane@cursor-fb-leak@pipe-c-hdmi-a-4.html
* igt@kms_universal_plane@cursor-fb-leak@pipe-d-hdmi-a-1:
- shard-tglu: [PASS][274] -> [FAIL][275] ([i915#9196]) +1 other test fail
[274]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_14480/shard-tglu-6/igt@kms_universal_plane@cursor-fb-leak@pipe-d-hdmi-a-1.html
[275]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10904/shard-tglu-3/igt@kms_universal_plane@cursor-fb-leak@pipe-d-hdmi-a-1.html
- shard-dg2: NOTRUN -> [FAIL][276] ([i915#9196])
[276]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10904/shard-dg2-8/igt@kms_universal_plane@cursor-fb-leak@pipe-d-hdmi-a-1.html
* igt@kms_vblank@ts-continuation-suspend@pipe-a-hdmi-a-3:
- shard-dg2: NOTRUN -> [INCOMPLETE][277] ([i915#9569])
[277]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10904/shard-dg2-6/igt@kms_vblank@ts-continuation-suspend@pipe-a-hdmi-a-3.html
* igt@kms_vrr@max-min:
- shard-dg2: NOTRUN -> [SKIP][278] ([i915#9906])
[278]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10904/shard-dg2-3/igt@kms_vrr@max-min.html
* igt@kms_vrr@seamless-rr-switch-vrr:
- shard-rkl: NOTRUN -> [SKIP][279] ([i915#9906])
[279]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10904/shard-rkl-2/igt@kms_vrr@seamless-rr-switch-vrr.html
* igt@kms_writeback@writeback-fb-id:
- shard-dg1: NOTRUN -> [SKIP][280] ([i915#2437])
[280]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10904/shard-dg1-14/igt@kms_writeback@writeback-fb-id.html
* igt@kms_writeback@writeback-fb-id-xrgb2101010:
- shard-dg2: NOTRUN -> [SKIP][281] ([i915#2437] / [i915#9412]) +1 other test skip
[281]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10904/shard-dg2-3/igt@kms_writeback@writeback-fb-id-xrgb2101010.html
* igt@prime_vgem@basic-fence-mmap:
- shard-dg1: NOTRUN -> [SKIP][282] ([i915#3708] / [i915#4077])
[282]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10904/shard-dg1-17/igt@prime_vgem@basic-fence-mmap.html
* igt@prime_vgem@basic-read:
- shard-dg2: NOTRUN -> [SKIP][283] ([i915#3291] / [i915#3708])
[283]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10904/shard-dg2-8/igt@prime_vgem@basic-read.html
* igt@prime_vgem@basic-write:
- shard-rkl: NOTRUN -> [SKIP][284] ([i915#3291] / [i915#3708])
[284]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10904/shard-rkl-2/igt@prime_vgem@basic-write.html
* igt@prime_vgem@fence-flip-hang:
- shard-dg2: NOTRUN -> [SKIP][285] ([i915#3708])
[285]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10904/shard-dg2-5/igt@prime_vgem@fence-flip-hang.html
* igt@runner@aborted:
- shard-glk: NOTRUN -> ([FAIL][286], [FAIL][287]) ([i915#10291])
[286]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10904/shard-glk9/igt@runner@aborted.html
[287]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10904/shard-glk2/igt@runner@aborted.html
* igt@sriov_basic@bind-unbind-vf:
- shard-dg2: NOTRUN -> [SKIP][288] ([i915#9917]) +1 other test skip
[288]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10904/shard-dg2-8/igt@sriov_basic@bind-unbind-vf.html
* igt@sriov_basic@enable-vfs-bind-unbind-each:
- shard-rkl: NOTRUN -> [SKIP][289] ([i915#9917])
[289]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10904/shard-rkl-4/igt@sriov_basic@enable-vfs-bind-unbind-each.html
* igt@syncobj_timeline@invalid-wait-zero-handles:
- shard-snb: NOTRUN -> [FAIL][290] ([i915#9781])
[290]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10904/shard-snb2/igt@syncobj_timeline@invalid-wait-zero-handles.html
* igt@syncobj_wait@invalid-wait-zero-handles:
- shard-glk: NOTRUN -> [FAIL][291] ([i915#9779])
[291]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10904/shard-glk9/igt@syncobj_wait@invalid-wait-zero-handles.html
* igt@v3d/v3d_job_submission@multiple-singlesync-to-multisync:
- shard-mtlp: NOTRUN -> [SKIP][292] ([i915#2575]) +6 other tests skip
[292]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10904/shard-mtlp-7/igt@v3d/v3d_job_submission@multiple-singlesync-to-multisync.html
* igt@v3d/v3d_perfmon@get-values-invalid-pad:
- shard-dg1: NOTRUN -> [SKIP][293] ([i915#2575]) +8 other tests skip
[293]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10904/shard-dg1-16/igt@v3d/v3d_perfmon@get-values-invalid-pad.html
* igt@v3d/v3d_submit_cl@multisync-out-syncs:
- shard-dg2: NOTRUN -> [SKIP][294] ([i915#2575]) +17 other tests skip
[294]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10904/shard-dg2-8/igt@v3d/v3d_submit_cl@multisync-out-syncs.html
* igt@v3d/v3d_submit_csd@multiple-job-submission:
- shard-tglu: NOTRUN -> [SKIP][295] ([i915#2575]) +7 other tests skip
[295]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10904/shard-tglu-10/igt@v3d/v3d_submit_csd@multiple-job-submission.html
* igt@vc4/vc4_perfmon@create-two-perfmon:
- shard-rkl: NOTRUN -> [SKIP][296] ([i915#7711]) +9 other tests skip
[296]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10904/shard-rkl-6/igt@vc4/vc4_perfmon@create-two-perfmon.html
* igt@vc4/vc4_purgeable_bo@access-purged-bo-mem:
- shard-mtlp: NOTRUN -> [SKIP][297] ([i915#7711]) +3 other tests skip
[297]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10904/shard-mtlp-8/igt@vc4/vc4_purgeable_bo@access-purged-bo-mem.html
* igt@vc4/vc4_purgeable_bo@mark-purgeable:
- shard-dg1: NOTRUN -> [SKIP][298] ([i915#7711]) +6 other tests skip
[298]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10904/shard-dg1-17/igt@vc4/vc4_purgeable_bo@mark-purgeable.html
* igt@vc4/vc4_purgeable_bo@mark-unpurgeable-check-retained:
- shard-dg2: NOTRUN -> [SKIP][299] ([i915#7711]) +7 other tests skip
[299]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10904/shard-dg2-2/igt@vc4/vc4_purgeable_bo@mark-unpurgeable-check-retained.html
#### Possible fixes ####
* igt@gem_exec_fair@basic-pace-solo@rcs0:
- shard-tglu: [FAIL][300] ([i915#2842]) -> [PASS][301]
[300]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_14480/shard-tglu-3/igt@gem_exec_fair@basic-pace-solo@rcs0.html
[301]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10904/shard-tglu-2/igt@gem_exec_fair@basic-pace-solo@rcs0.html
* igt@gem_lmem_swapping@heavy-verify-random@lmem0:
- shard-dg2: [FAIL][302] ([i915#10378]) -> [PASS][303]
[302]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_14480/shard-dg2-1/igt@gem_lmem_swapping@heavy-verify-random@lmem0.html
[303]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10904/shard-dg2-3/igt@gem_lmem_swapping@heavy-verify-random@lmem0.html
* igt@i915_hangman@gt-error-state-capture@vcs0:
- shard-dg2: [INCOMPLETE][304] -> [PASS][305]
[304]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_14480/shard-dg2-10/igt@i915_hangman@gt-error-state-capture@vcs0.html
[305]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10904/shard-dg2-5/igt@i915_hangman@gt-error-state-capture@vcs0.html
* igt@i915_module_load@reload-with-fault-injection:
- shard-snb: [INCOMPLETE][306] ([i915#9849]) -> [PASS][307]
[306]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_14480/shard-snb5/igt@i915_module_load@reload-with-fault-injection.html
[307]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10904/shard-snb6/igt@i915_module_load@reload-with-fault-injection.html
* igt@i915_pm_rc6_residency@rc6-idle@gt0-bcs0:
- shard-dg1: [FAIL][308] ([i915#3591]) -> [PASS][309]
[308]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_14480/shard-dg1-14/igt@i915_pm_rc6_residency@rc6-idle@gt0-bcs0.html
[309]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10904/shard-dg1-15/igt@i915_pm_rc6_residency@rc6-idle@gt0-bcs0.html
* igt@kms_big_fb@4-tiled-max-hw-stride-64bpp-rotate-180-hflip:
- shard-mtlp: [FAIL][310] ([i915#5138]) -> [PASS][311]
[310]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_14480/shard-mtlp-8/igt@kms_big_fb@4-tiled-max-hw-stride-64bpp-rotate-180-hflip.html
[311]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10904/shard-mtlp-4/igt@kms_big_fb@4-tiled-max-hw-stride-64bpp-rotate-180-hflip.html
* igt@kms_big_fb@x-tiled-max-hw-stride-32bpp-rotate-0-async-flip:
- shard-tglu: [FAIL][312] ([i915#3743]) -> [PASS][313] +2 other tests pass
[312]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_14480/shard-tglu-6/igt@kms_big_fb@x-tiled-max-hw-stride-32bpp-rotate-0-async-flip.html
[313]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10904/shard-tglu-5/igt@kms_big_fb@x-tiled-max-hw-stride-32bpp-rotate-0-async-flip.html
* igt@kms_flip@2x-plain-flip-ts-check-interruptible@ab-vga1-hdmi-a1:
- shard-snb: [FAIL][314] ([i915#2122]) -> [PASS][315]
[314]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_14480/shard-snb7/igt@kms_flip@2x-plain-flip-ts-check-interruptible@ab-vga1-hdmi-a1.html
[315]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10904/shard-snb5/igt@kms_flip@2x-plain-flip-ts-check-interruptible@ab-vga1-hdmi-a1.html
* igt@kms_plane_scaling@intel-max-src-size@pipe-a-hdmi-a-4:
- shard-dg1: [FAIL][316] ([i915#8292]) -> [PASS][317]
[316]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_14480/shard-dg1-15/igt@kms_plane_scaling@intel-max-src-size@pipe-a-hdmi-a-4.html
[317]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10904/shard-dg1-15/igt@kms_plane_scaling@intel-max-src-size@pipe-a-hdmi-a-4.html
* igt@kms_pm_rpm@modeset-lpsp-stress-no-wait:
- shard-dg2: [SKIP][318] ([i915#9519]) -> [PASS][319] +1 other test pass
[318]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_14480/shard-dg2-3/igt@kms_pm_rpm@modeset-lpsp-stress-no-wait.html
[319]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10904/shard-dg2-8/igt@kms_pm_rpm@modeset-lpsp-stress-no-wait.html
* igt@kms_pm_rpm@modeset-non-lpsp-stress-no-wait:
- shard-rkl: [SKIP][320] ([i915#9519]) -> [PASS][321] +1 other test pass
[320]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_14480/shard-rkl-5/igt@kms_pm_rpm@modeset-non-lpsp-stress-no-wait.html
[321]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10904/shard-rkl-6/igt@kms_pm_rpm@modeset-non-lpsp-stress-no-wait.html
* igt@kms_universal_plane@cursor-fb-leak@pipe-d-edp-1:
- shard-mtlp: [FAIL][322] ([i915#9196]) -> [PASS][323]
[322]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_14480/shard-mtlp-2/igt@kms_universal_plane@cursor-fb-leak@pipe-d-edp-1.html
[323]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10904/shard-mtlp-2/igt@kms_universal_plane@cursor-fb-leak@pipe-d-edp-1.html
* igt@kms_vblank@ts-continuation-suspend@pipe-a-hdmi-a-1:
- shard-snb: [DMESG-WARN][324] -> [PASS][325]
[324]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_14480/shard-snb1/igt@kms_vblank@ts-continuation-suspend@pipe-a-hdmi-a-1.html
[325]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10904/shard-snb1/igt@kms_vblank@ts-continuation-suspend@pipe-a-hdmi-a-1.html
#### Warnings ####
* igt@device_reset@unbind-reset-rebind:
- shard-dg1: [ABORT][326] ([i915#9618]) -> [INCOMPLETE][327] ([i915#9408] / [i915#9618])
[326]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_14480/shard-dg1-13/igt@device_reset@unbind-reset-rebind.html
[327]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10904/shard-dg1-18/igt@device_reset@unbind-reset-rebind.html
* igt@i915_module_load@reload-with-fault-injection:
- shard-dg2: [INCOMPLETE][328] ([i915#9820] / [i915#9849]) -> [ABORT][329] ([i915#9820])
[328]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_14480/shard-dg2-11/igt@i915_module_load@reload-with-fault-injection.html
[329]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10904/shard-dg2-8/igt@i915_module_load@reload-with-fault-injection.html
* igt@kms_content_protection@mei-interface:
- shard-rkl: [SKIP][330] ([i915#9424]) -> [SKIP][331] ([i915#8063])
[330]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_14480/shard-rkl-2/igt@kms_content_protection@mei-interface.html
[331]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10904/shard-rkl-3/igt@kms_content_protection@mei-interface.html
- shard-tglu: [SKIP][332] ([i915#6944] / [i915#9424]) -> [SKIP][333] ([i915#8063])
[332]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_14480/shard-tglu-9/igt@kms_content_protection@mei-interface.html
[333]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10904/shard-tglu-9/igt@kms_content_protection@mei-interface.html
* igt@kms_psr@fbc-psr-basic:
- shard-dg2: [SKIP][334] ([i915#1072] / [i915#9732]) -> [SKIP][335] ([i915#1072] / [i915#9673] / [i915#9732]) +2 other tests skip
[334]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_14480/shard-dg2-1/igt@kms_psr@fbc-psr-basic.html
[335]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10904/shard-dg2-11/igt@kms_psr@fbc-psr-basic.html
* igt@kms_psr@fbc-psr-cursor-plane-move:
- shard-dg2: [SKIP][336] ([i915#1072] / [i915#9673] / [i915#9732]) -> [SKIP][337] ([i915#1072] / [i915#9732]) +5 other tests skip
[336]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_14480/shard-dg2-11/igt@kms_psr@fbc-psr-cursor-plane-move.html
[337]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10904/shard-dg2-2/igt@kms_psr@fbc-psr-cursor-plane-move.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[IGT#2]: https://gitlab.freedesktop.org/drm/igt-gpu-tools/issues/2
[i915#10055]: https://gitlab.freedesktop.org/drm/intel/issues/10055
[i915#10131]: https://gitlab.freedesktop.org/drm/intel/issues/10131
[i915#10166]: https://gitlab.freedesktop.org/drm/intel/issues/10166
[i915#10278]: https://gitlab.freedesktop.org/drm/intel/issues/10278
[i915#10291]: https://gitlab.freedesktop.org/drm/intel/issues/10291
[i915#10307]: https://gitlab.freedesktop.org/drm/intel/issues/10307
[i915#10378]: https://gitlab.freedesktop.org/drm/intel/issues/10378
[i915#10434]: https://gitlab.freedesktop.org/drm/intel/issues/10434
[i915#1072]: https://gitlab.freedesktop.org/drm/intel/issues/1072
[i915#1099]: https://gitlab.freedesktop.org/drm/intel/issues/1099
[i915#1257]: https://gitlab.freedesktop.org/drm/intel/issues/1257
[i915#1769]: https://gitlab.freedesktop.org/drm/intel/issues/1769
[i915#1825]: https://gitlab.freedesktop.org/drm/intel/issues/1825
[i915#1839]: https://gitlab.freedesktop.org/drm/intel/issues/1839
[i915#1982]: https://gitlab.freedesktop.org/drm/intel/issues/1982
[i915#2065]: https://gitlab.freedesktop.org/drm/intel/issues/2065
[i915#2122]: https://gitlab.freedesktop.org/drm/intel/issues/2122
[i915#2437]: https://gitlab.freedesktop.org/drm/intel/issues/2437
[i915#2527]: https://gitlab.freedesktop.org/drm/intel/issues/2527
[i915#2575]: https://gitlab.freedesktop.org/drm/intel/issues/2575
[i915#2587]: https://gitlab.freedesktop.org/drm/intel/issues/2587
[i915#2672]: https://gitlab.freedesktop.org/drm/intel/issues/2672
[i915#2681]: https://gitlab.freedesktop.org/drm/intel/issues/2681
[i915#2705]: https://gitlab.freedesktop.org/drm/intel/issues/2705
[i915#280]: https://gitlab.freedesktop.org/drm/intel/issues/280
[i915#2842]: https://gitlab.freedesktop.org/drm/intel/issues/2842
[i915#2856]: https://gitlab.freedesktop.org/drm/intel/issues/2856
[i915#2876]: https://gitlab.freedesktop.org/drm/intel/issues/2876
[i915#3023]: https://gitlab.freedesktop.org/drm/intel/issues/3023
[i915#3116]: https://gitlab.freedesktop.org/drm/intel/issues/3116
[i915#3281]: https://gitlab.freedesktop.org/drm/intel/issues/3281
[i915#3282]: https://gitlab.freedesktop.org/drm/intel/issues/3282
[i915#3291]: https://gitlab.freedesktop.org/drm/intel/issues/3291
[i915#3297]: https://gitlab.freedesktop.org/drm/intel/issues/3297
[i915#3299]: https://gitlab.freedesktop.org/drm/intel/issues/3299
[i915#3359]: https://gitlab.freedesktop.org/drm/intel/issues/3359
[i915#3458]: https://gitlab.freedesktop.org/drm/intel/issues/3458
[i915#3469]: https://gitlab.freedesktop.org/drm/intel/issues/3469
[i915#3539]: https://gitlab.freedesktop.org/drm/intel/issues/3539
[i915#3555]: https://gitlab.freedesktop.org/drm/intel/issues/3555
[i915#3591]: https://gitlab.freedesktop.org/drm/intel/issues/3591
[i915#3637]: https://gitlab.freedesktop.org/drm/intel/issues/3637
[i915#3638]: https://gitlab.freedesktop.org/drm/intel/issues/3638
[i915#3708]: https://gitlab.freedesktop.org/drm/intel/issues/3708
[i915#3711]: https://gitlab.freedesktop.org/drm/intel/issues/3711
[i915#3743]: https://gitlab.freedesktop.org/drm/intel/issues/3743
[i915#3804]: https://gitlab.freedesktop.org/drm/intel/issues/3804
[i915#3826]: https://gitlab.freedesktop.org/drm/intel/issues/3826
[i915#3840]: https://gitlab.freedesktop.org/drm/intel/issues/3840
[i915#3936]: https://gitlab.freedesktop.org/drm/intel/issues/3936
[i915#4077]: https://gitlab.freedesktop.org/drm/intel/issues/4077
[i915#4079]: https://gitlab.freedesktop.org/drm/intel/issues/4079
[i915#4083]: https://gitlab.freedesktop.org/drm/intel/issues/4083
[i915#4087]: https://gitlab.freedesktop.org/drm/intel/issues/4087
[i915#4103]: https://gitlab.freedesktop.org/drm/intel/issues/4103
[i915#4212]: https://gitlab.freedesktop.org/drm/intel/issues/4212
[i915#4213]: https://gitlab.freedesktop.org/drm/intel/issues/4213
[i915#4235]: https://gitlab.freedesktop.org/drm/intel/issues/4235
[i915#4270]: https://gitlab.freedesktop.org/drm/intel/issues/4270
[i915#4473]: https://gitlab.freedesktop.org/drm/intel/issues/4473
[i915#4525]: https://gitlab.freedesktop.org/drm/intel/issues/4525
[i915#4537]: https://gitlab.freedesktop.org/drm/intel/issues/4537
[i915#4538]: https://gitlab.freedesktop.org/drm/intel/issues/4538
[i915#4565]: https://gitlab.freedesktop.org/drm/intel/issues/4565
[i915#4613]: https://gitlab.freedesktop.org/drm/intel/issues/4613
[i915#4771]: https://gitlab.freedesktop.org/drm/intel/issues/4771
[i915#4812]: https://gitlab.freedesktop.org/drm/intel/issues/4812
[i915#4816]: https://gitlab.freedesktop.org/drm/intel/issues/4816
[i915#4852]: https://gitlab.freedesktop.org/drm/intel/issues/4852
[i915#4854]: https://gitlab.freedesktop.org/drm/intel/issues/4854
[i915#4860]: https://gitlab.freedesktop.org/drm/intel/issues/4860
[i915#4881]: https://gitlab.freedesktop.org/drm/intel/issues/4881
[i915#4885]: https://gitlab.freedesktop.org/drm/intel/issues/4885
[i915#5107]: https://gitlab.freedesktop.org/drm/intel/issues/5107
[i915#5138]: https://gitlab.freedesktop.org/drm/intel/issues/5138
[i915#5176]: https://gitlab.freedesktop.org/drm/intel/issues/5176
[i915#5190]: https://gitlab.freedesktop.org/drm/intel/issues/5190
[i915#5235]: https://gitlab.freedesktop.org/drm/intel/issues/5235
[i915#5286]: https://gitlab.freedesktop.org/drm/intel/issues/5286
[i915#5289]: https://gitlab.freedesktop.org/drm/intel/issues/5289
[i915#5354]: https://gitlab.freedesktop.org/drm/intel/issues/5354
[i915#5439]: https://gitlab.freedesktop.org/drm/intel/issues/5439
[i915#5784]: https://gitlab.freedesktop.org/drm/intel/issues/5784
[i915#5882]: https://gitlab.freedesktop.org/drm/intel/issues/5882
[i915#6095]: https://gitlab.freedesktop.org/drm/intel/issues/6095
[i915#6245]: https://gitlab.freedesktop.org/drm/intel/issues/6245
[i915#6301]: https://gitlab.freedesktop.org/drm/intel/issues/6301
[i915#6344]: https://gitlab.freedesktop.org/drm/intel/issues/6344
[i915#6524]: https://gitlab.freedesktop.org/drm/intel/issues/6524
[i915#658]: https://gitlab.freedesktop.org/drm/intel/issues/658
[i915#6621]: https://gitlab.freedesktop.org/drm/intel/issues/6621
[i915#6645]: https://gitlab.freedesktop.org/drm/intel/issues/6645
[i915#6805]: https://gitlab.freedesktop.org/drm/intel/issues/6805
[i915#6880]: https://gitlab.freedesktop.org/drm/intel/issues/6880
[i915#6944]: https://gitlab.freedesktop.org/drm/intel/issues/6944
[i915#7116]: https://gitlab.freedesktop.org/drm/intel/issues/7116
[i915#7118]: https://gitlab.freedesktop.org/drm/intel/issues/7118
[i915#7443]: https://gitlab.freedesktop.org/drm/intel/issues/7443
[i915#7697]: https://gitlab.freedesktop.org/drm/intel/issues/7697
[i915#7701]: https://gitlab.freedesktop.org/drm/intel/issues/7701
[i915#7711]: https://gitlab.freedesktop.org/drm/intel/issues/7711
[i915#7742]: https://gitlab.freedesktop.org/drm/intel/issues/7742
[i915#7828]: https://gitlab.freedesktop.org/drm/intel/issues/7828
[i915#79]: https://gitlab.freedesktop.org/drm/intel/issues/79
[i915#8063]: https://gitlab.freedesktop.org/drm/intel/issues/8063
[i915#8228]: https://gitlab.freedesktop.org/drm/intel/issues/8228
[i915#8292]: https://gitlab.freedesktop.org/drm/intel/issues/8292
[i915#8381]: https://gitlab.freedesktop.org/drm/intel/issues/8381
[i915#8411]: https://gitlab.freedesktop.org/drm/intel/issues/8411
[i915#8414]: https://gitlab.freedesktop.org/drm/intel/issues/8414
[i915#8428]: https://gitlab.freedesktop.org/drm/intel/issues/8428
[i915#8555]: https://gitlab.freedesktop.org/drm/intel/issues/8555
[i915#8562]: https://gitlab.freedesktop.org/drm/intel/issues/8562
[i915#8623]: https://gitlab.freedesktop.org/drm/intel/issues/8623
[i915#8708]: https://gitlab.freedesktop.org/drm/intel/issues/8708
[i915#8709]: https://gitlab.freedesktop.org/drm/intel/issues/8709
[i915#8806]: https://gitlab.freedesktop.org/drm/intel/issues/8806
[i915#8810]: https://gitlab.freedesktop.org/drm/intel/issues/8810
[i915#8812]: https://gitlab.freedesktop.org/drm/intel/issues/8812
[i915#8814]: https://gitlab.freedesktop.org/drm/intel/issues/8814
[i915#8821]: https://gitlab.freedesktop.org/drm/intel/issues/8821
[i915#8925]: https://gitlab.freedesktop.org/drm/intel/issues/8925
[i915#9053]: https://gitlab.freedesktop.org/drm/intel/issues/9053
[i915#9067]: https://gitlab.freedesktop.org/drm/intel/issues/9067
[i915#9196]: https://gitlab.freedesktop.org/drm/intel/issues/9196
[i915#9295]: https://gitlab.freedesktop.org/drm/intel/issues/9295
[i915#9311]: https://gitlab.freedesktop.org/drm/intel/issues/9311
[i915#9323]: https://gitlab.freedesktop.org/drm/intel/issues/9323
[i915#9407]: https://gitlab.freedesktop.org/drm/intel/issues/9407
[i915#9408]: https://gitlab.freedesktop.org/drm/intel/issues/9408
[i915#9412]: https://gitlab.freedesktop.org/drm/intel/issues/9412
[i915#9423]: https://gitlab.freedesktop.org/drm/intel/issues/9423
[i915#9424]: https://gitlab.freedesktop.org/drm/intel/issues/9424
[i915#9519]: https://gitlab.freedesktop.org/drm/intel/issues/9519
[i915#9569]: https://gitlab.freedesktop.org/drm/intel/issues/9569
[i915#9606]: https://gitlab.freedesktop.org/drm/intel/issues/9606
[i915#9618]: https://gitlab.freedesktop.org/drm/intel/issues/9618
[i915#9673]: https://gitlab.freedesktop.org/drm/intel/issues/9673
[i915#9683]: https://gitlab.freedesktop.org/drm/intel/issues/9683
[i915#9688]: https://gitlab.freedesktop.org/drm/intel/issues/9688
[i915#9723]: https://gitlab.freedesktop.org/drm/intel/issues/9723
[i915#9732]: https://gitlab.freedesktop.org/drm/intel/issues/9732
[i915#9779]: https://gitlab.freedesktop.org/drm/intel/issues/9779
[i915#9781]: https://gitlab.freedesktop.org/drm/intel/issues/9781
[i915#9808]: https://gitlab.freedesktop.org/drm/intel/issues/9808
[i915#9809]: https://gitlab.freedesktop.org/drm/intel/issues/9809
[i915#9820]: https://gitlab.freedesktop.org/drm/intel/issues/9820
[i915#9849]: https://gitlab.freedesktop.org/drm/intel/issues/9849
[i915#9906]: https://gitlab.freedesktop.org/drm/intel/issues/9906
[i915#9917]: https://gitlab.freedesktop.org/drm/intel/issues/9917
[i915#9934]: https://gitlab.freedesktop.org/drm/intel/issues/9934
Build changes
-------------
* CI: CI-20190529 -> None
* IGT: IGT_7782 -> IGTPW_10904
* Piglit: piglit_4509 -> None
CI-20190529: 20190529
CI_DRM_14480: 17ec6923f2c5bb23280b274d6359a44a6982982e @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_10904: 10904
IGT_7782: a404f73182948e843640d00cc279883391cf6ef4 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10904/index.html
[-- Attachment #2: Type: text/html, Size: 110993 bytes --]
^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: [PATCH i-g-t 2/4] tests/intel/kms_big_joiner: revamp bigjoiner
2024-03-25 16:51 ` [PATCH i-g-t 2/4] tests/intel/kms_big_joiner: revamp bigjoiner Kunal Joshi
@ 2024-03-28 6:59 ` Nautiyal, Ankit K
0 siblings, 0 replies; 18+ messages in thread
From: Nautiyal, Ankit K @ 2024-03-28 6:59 UTC (permalink / raw)
To: Kunal Joshi, igt-dev; +Cc: Stanislav Lisovskiy, Karthik B S, Bhanuprakash Modem
Seems like commit message got missed in this revision.
On 3/25/2024 10:21 PM, Kunal Joshi wrote:
> v2: Don't change license (Bhanu)
> Print the pipe name (Bhanu)
> Remove unwanted commit (Bhanu)
> Move combine output logic to igt_fixture (Bhanu)
> split revamp and force joiner (Bhanu)
>
> v3: Ignored fused pipes (Stan)
>
> v4: Ignore master pipes who doesn't have slave (Ankit)
> Retain subtest names (Ankit)
> Use commit instead of try_commit (Ankit)
> Fix typo (Ankit)
>
> v5: Fix condition and remove last pipe (Ankit)
> Remove nested if (Ankit)
> Use pointer to output instead of id (Ankit)
> Add missing igt_describe (Ankit)
>
> Cc: Stanislav Lisovskiy <stanislav.lisovskiy@intel.com>
> Cc: Ankit Nautiyal <ankit.k.nautiyal@intel.com>
> Cc: Karthik B S <karthik.b.s@intel.com>
> Cc: Bhanuprakash Modem <bhanuprakash.modem@intel.com>
> Signed-off-by: Kunal Joshi <kunal1.joshi@intel.com>
> Signed-off-by: Stanislav Lisovskiy <stanislav.lisovskiy@intel.com>
> ---
> tests/intel/kms_big_joiner.c | 399 ++++++++++++++++++-----------------
> 1 file changed, 204 insertions(+), 195 deletions(-)
>
> diff --git a/tests/intel/kms_big_joiner.c b/tests/intel/kms_big_joiner.c
> index 99b1b898d..b57996212 100644
> --- a/tests/intel/kms_big_joiner.c
> +++ b/tests/intel/kms_big_joiner.c
> @@ -44,177 +44,236 @@
> * SUBTEST: basic
> * Description: Verify the basic modeset on big joiner mode on all pipes
> *
> - * SUBTEST: 2x-modeset
> - * Description: Verify simultaneous modeset on 2 big joiner outputs
> */
>
> IGT_TEST_DESCRIPTION("Test big joiner");
>
> -struct bigjoiner_output {
> - uint32_t output_id;
> - drmModeModeInfo mode;
> -};
> +#define INVALID_TEST_OUTPUT 2
>
> typedef struct {
> int drm_fd;
> - igt_display_t display;
> - struct igt_fb fb;
> + int big_joiner_output_count;
> + int non_big_joiner_output_count;
> + int combined_output_count;
> + int output_count;
> int n_pipes;
> - enum pipe pipe1;
> - enum pipe pipe2;
> - struct bigjoiner_output output[2];
> + int master_pipes;
I think uint32_t will be more appropriate for master_pipe
> + igt_output_t *big_joiner_output[IGT_MAX_PIPES];
> + igt_output_t *non_big_joiner_output[IGT_MAX_PIPES];
> + igt_output_t *combined_output[IGT_MAX_PIPES];
> + enum pipe pipe_seq[IGT_MAX_PIPES];
> + igt_display_t display;
> } data_t;
>
> static int max_dotclock;
>
> -static void test_invalid_modeset(data_t *data)
> +static void set_all_master_pipes_for_platform(data_t *data)
> {
> - igt_output_t *output;
> - igt_display_t *display = &data->display;
> - int ret;
> + enum pipe pipe;
>
> - igt_info("Bigjoiner test on ");
> - for_each_connected_output(display, output){
> - enum pipe p = output->pending_pipe;
> - drmModeModeInfo *mode;
> - igt_pipe_t *pipe;
> - igt_plane_t *plane;
> -
> - if (p == PIPE_NONE)
> - continue;
> + for (pipe = PIPE_A; pipe < IGT_MAX_PIPES - 1; pipe++) {
> + if (data->display.pipes[pipe].enabled && data->display.pipes[pipe+1].enabled) {
Nit pick: Space around '+' I think need to fix in couple of places.
> + data->master_pipes |= BIT(pipe);
> + igt_info("Found master pipe %s\n", kmstest_pipe_name(pipe));
> + }
> + }
> +}
>
> - mode = igt_output_get_mode(output);
> - igt_info("pipe:%s, output:%s, mode:", kmstest_pipe_name(p), igt_output_name(output));
> - kmstest_dump_mode(mode);
> +static enum pipe get_next_master_pipe(data_t *data, unsigned int available_pipe_mask)
let's use uint32_t for the available pipe masks.
> +{
> + if ((data->master_pipes & available_pipe_mask) == 0)
> + return PIPE_NONE;
>
> - pipe = &display->pipes[p];
> - plane = igt_pipe_get_plane_type(pipe, DRM_PLANE_TYPE_PRIMARY);
> + return ffs(data->master_pipes & available_pipe_mask) - 1;
> +}
>
> - igt_plane_set_fb(plane, &data->fb);
> - igt_fb_set_size(&data->fb, plane, mode->hdisplay, mode->vdisplay);
> - igt_plane_set_size(plane, mode->hdisplay, mode->vdisplay);
> - }
> +static enum pipe setup_pipe(data_t *data, igt_output_t *output, enum pipe pipe, unsigned int available_pipe_mask)
> +{
> + enum pipe master_pipe;
> + unsigned int attempt_mask;
>
> - igt_assert(!igt_check_bigjoiner_support(display));
> + attempt_mask = BIT(pipe);
> + master_pipe = get_next_master_pipe(data, available_pipe_mask & attempt_mask);
>
> - /* This commit is expectd to fail as this pipe is being used for big joiner */
> - ret = igt_display_try_commit_atomic(display, DRM_MODE_ATOMIC_TEST_ONLY |
> - DRM_MODE_ATOMIC_ALLOW_MODESET, NULL);
> + if (master_pipe == PIPE_NONE)
> + return PIPE_NONE;
>
> - igt_display_reset(&data->display);
> - igt_display_commit2(display, COMMIT_ATOMIC);
> + igt_info("Using pipe %s as master and %s slave for %s\n", kmstest_pipe_name(pipe),
> + kmstest_pipe_name(pipe + 1), output->name);
> + igt_output_set_pipe(output, pipe);
>
> - igt_assert_lt(ret, 0);
> + return master_pipe;
> }
>
> -static void test_basic_modeset(data_t *data)
> +static void test_single_joiner(data_t *data, int output_count)
> {
> + int i;
> + enum pipe pipe, master_pipe;
> + unsigned int available_pipe_mask = BIT(data->n_pipes) - 1;
> + igt_output_t *output;
> + igt_plane_t *primary;
> + igt_output_t **outputs;
> + igt_fb_t fb;
> drmModeModeInfo *mode;
> - igt_output_t *output, *bigjoiner_output = NULL;
> - igt_display_t *display = &data->display;
> - igt_pipe_t *pipe;
> - igt_plane_t *plane;
>
> - igt_display_reset(display);
> + outputs = data->big_joiner_output;
This can be moved to initialization.
>
> - for_each_connected_output(display, output) {
> - if (data->output[0].output_id == output->id) {
> - bigjoiner_output = output;
> - break;
> + for (i = 0; i < output_count; i++) {
> + output = outputs[i];
> + for (pipe = 0; pipe < data->n_pipes-1; pipe++) {
Nit pick : Space around '-'
> + igt_display_reset(&data->display);
> + master_pipe = setup_pipe(data, output, pipe, available_pipe_mask);
> + if (master_pipe == PIPE_NONE)
> + continue;
> + mode = igt_output_get_mode(output);
> + primary = igt_output_get_plane_type(output, DRM_PLANE_TYPE_PRIMARY);
> + igt_create_pattern_fb(data->drm_fd, mode->hdisplay, mode->vdisplay, DRM_FORMAT_XRGB8888,
> + DRM_FORMAT_MOD_LINEAR, &fb);
Formatting looks a bit off. line up argument list with tab.
> + igt_plane_set_fb(primary, &fb);
> + igt_display_commit2(&data->display, COMMIT_ATOMIC);
> + igt_plane_set_fb(primary, NULL);
> + igt_remove_fb(data->drm_fd, &fb);
> }
> }
> -
> - igt_output_set_pipe(bigjoiner_output, data->pipe1);
> -
> - mode = &data->output[0].mode;
> - igt_output_override_mode(bigjoiner_output, mode);
> -
> - pipe = &display->pipes[data->pipe1];
> - plane = igt_pipe_get_plane_type(pipe, DRM_PLANE_TYPE_PRIMARY);
> -
> - igt_plane_set_fb(plane, &data->fb);
> - igt_fb_set_size(&data->fb, plane, mode->hdisplay, mode->vdisplay);
> - igt_plane_set_size(plane, mode->hdisplay, mode->vdisplay);
> -
> - igt_display_commit2(display, COMMIT_ATOMIC);
> -
> - igt_output_set_pipe(bigjoiner_output, PIPE_NONE);
> - igt_plane_set_fb(plane, NULL);
> - igt_display_commit2(display, COMMIT_ATOMIC);
> }
>
> -static void test_dual_display(data_t *data)
> +static void test_multi_joiner(data_t *data, int output_count)
> {
> + int i;
> + unsigned int available_pipe_mask;
> + enum pipe pipe, master_pipe;
> + igt_output_t **outputs;
> + igt_output_t *output;
> + igt_plane_t *primary[output_count];
> + igt_fb_t fb[output_count];
> drmModeModeInfo *mode;
> - igt_output_t *output, *bigjoiner_output[2];
> - igt_display_t *display = &data->display;
> - igt_pipe_t *pipe;
> - igt_plane_t *plane1, *plane2;
> - int count = 0;
> -
> - igt_display_reset(display);
> -
> - for_each_connected_output(display, output) {
> - if (data->output[count].output_id == output->id) {
> - bigjoiner_output[count] = output;
> - count++;
> - }
>
> - if (count > 1)
> + available_pipe_mask = BIT(data->n_pipes) - 1;
> + outputs = data->big_joiner_output;
> +
> + igt_display_reset(&data->display);
> + for (i = 0; i < output_count; i++) {
> + output = outputs[i];
> + for (pipe = 0; pipe < data->n_pipes; pipe++) {
> + master_pipe = setup_pipe(data, output, pipe, available_pipe_mask);
> + if (master_pipe == PIPE_NONE)
> + continue;
> + mode = igt_output_get_mode(output);
> + primary[i] = igt_output_get_plane_type(output, DRM_PLANE_TYPE_PRIMARY);
> + igt_create_pattern_fb(data->drm_fd, mode->hdisplay, mode->vdisplay, DRM_FORMAT_XRGB8888,
> + DRM_FORMAT_MOD_LINEAR, &fb[i]);
Formatting: Line up argument with tab.
> + igt_plane_set_fb(primary[i], &fb[i]);
> +
> + available_pipe_mask &= ~BIT(master_pipe);
> + available_pipe_mask &= ~BIT(master_pipe + 1);
> break;
> + }
> }
> + igt_display_commit2(&data->display, COMMIT_ATOMIC);
> + for (i = 0; i < output_count; i++) {
> + igt_plane_set_fb(primary[i], NULL);
> + igt_remove_fb(data->drm_fd, &fb[i]);
> + }
> +}
>
> - igt_output_set_pipe(bigjoiner_output[0], data->pipe1);
> - igt_output_set_pipe(bigjoiner_output[1], data->pipe2);
> -
> - /* Set up first big joiner output on Pipe A*/
> - mode = &data->output[0].mode;
> - igt_output_override_mode(bigjoiner_output[0], mode);
> +static void test_invalid_modeset_two_joiner(data_t *data,
> + bool combined)
> +{
> + int i, j, ret;
> + unsigned int available_pipe_mask;
> + unsigned int attempt_mask;
> + enum pipe master_pipe;
> + igt_output_t **outputs;
> + igt_output_t *output;
> + igt_plane_t *primary[INVALID_TEST_OUTPUT];
> + igt_fb_t fb[INVALID_TEST_OUTPUT];
> + drmModeModeInfo *mode;
>
> - pipe = &display->pipes[data->pipe1];
> - plane1 = igt_pipe_get_plane_type(pipe, DRM_PLANE_TYPE_PRIMARY);
> + available_pipe_mask = BIT(data->n_pipes) - 1;
> + outputs = combined ? data->combined_output : data->big_joiner_output;
>
> - igt_plane_set_fb(plane1, &data->fb);
> - igt_fb_set_size(&data->fb, plane1, mode->hdisplay, mode->vdisplay);
> - igt_plane_set_size(plane1, mode->hdisplay, mode->vdisplay);
> + for (i = 0; i < data->n_pipes-1; i++) {
> + igt_display_reset(&data->display);
> + attempt_mask = BIT(data->pipe_seq[i]);
> + master_pipe = get_next_master_pipe(data, available_pipe_mask & attempt_mask);
>
> - /* Set up second big joiner output on Pipe C*/
> - mode = &data->output[1].mode;
> - igt_output_override_mode(bigjoiner_output[1], mode);
> + if (master_pipe == PIPE_NONE)
> + continue;
>
> - pipe = &display->pipes[data->pipe2];
> - plane2 = igt_pipe_get_plane_type(pipe, DRM_PLANE_TYPE_PRIMARY);
> + for (j = 0; j < INVALID_TEST_OUTPUT; j++) {
> + output = outputs[j];
> + igt_output_set_pipe(output, data->pipe_seq[i + j]);
> + mode = igt_output_get_mode(output);
> + igt_info("Assigning pipe %s to %s with mode %dx%d@%d%s",
> + kmstest_pipe_name(data->pipe_seq[i + j]),
> + igt_output_name(output), mode->hdisplay,
> + mode->vdisplay, mode->vrefresh,
> + j == INVALID_TEST_OUTPUT - 1 ? "\n" : ", ");
> + primary[j] = igt_output_get_plane_type(output, DRM_PLANE_TYPE_PRIMARY);
> + igt_create_pattern_fb(data->drm_fd, mode->hdisplay, mode->vdisplay, DRM_FORMAT_XRGB8888,
> + DRM_FORMAT_MOD_LINEAR, &fb[j]);
> + igt_plane_set_fb(primary[j], &fb[j]);
> + }
> + ret = igt_display_try_commit2(&data->display, COMMIT_ATOMIC);
> + for (j = 0; j < INVALID_TEST_OUTPUT; j++) {
> + igt_plane_set_fb(primary[j], NULL);
> + igt_remove_fb(data->drm_fd, &fb[j]);
> + }
> + igt_assert_f(ret != 0, "Commit shouldn't have passed\n");
> + }
> +}
>
> - igt_plane_set_fb(plane2, &data->fb);
> - igt_fb_set_size(&data->fb, plane2, mode->hdisplay, mode->vdisplay);
> - igt_plane_set_size(plane2, mode->hdisplay, mode->vdisplay);
> +static void test_big_joiner_on_last_pipe(data_t *data)
> +{
> + int i, len, ret;
> + igt_output_t **outputs;
> + igt_output_t *output;
> + igt_plane_t *primary;
> + igt_fb_t fb;
> + drmModeModeInfo *mode;
>
> - igt_display_commit2(display, COMMIT_ATOMIC);
> + len = data->big_joiner_output_count;
> + outputs = data->big_joiner_output;
>
> - /* Clean up */
> - igt_output_set_pipe(bigjoiner_output[0], PIPE_NONE);
> - igt_output_set_pipe(bigjoiner_output[1], PIPE_NONE);
> - igt_plane_set_fb(plane1, NULL);
> - igt_plane_set_fb(plane2, NULL);
> - igt_display_commit2(display, COMMIT_ATOMIC);
> + for (i = 0; i < len; i++) {
> + igt_display_reset(&data->display);
> + output = outputs[i];
> + igt_output_set_pipe(output, data->pipe_seq[data->n_pipes - 1]);
> + mode = igt_output_get_mode(output);
> + igt_info(" Assigning pipe %s to %s with mode %dx%d@%d\n",
> + kmstest_pipe_name(data->pipe_seq[data->n_pipes - 1]),
> + igt_output_name(output), mode->hdisplay,
> + mode->vdisplay, mode->vrefresh);
> + primary = igt_output_get_plane_type(output, DRM_PLANE_TYPE_PRIMARY);
> + igt_create_pattern_fb(data->drm_fd, mode->hdisplay, mode->vdisplay, DRM_FORMAT_XRGB8888,
> + DRM_FORMAT_MOD_LINEAR, &fb);
> + igt_plane_set_fb(primary, &fb);
> + ret = igt_display_try_commit2(&data->display, COMMIT_ATOMIC);
> + igt_plane_set_fb(primary, NULL);
> + igt_remove_fb(data->drm_fd, &fb);
> + igt_assert_f(ret != 0, "Commit shouldn't have passed\n");
> + }
> }
>
> igt_main
> {
> - data_t data;
> + int i, j;
> igt_output_t *output;
> drmModeModeInfo mode;
> - int valid_output = 0, i, count = 0, j = 0;
> - uint16_t width = 0, height = 0;
> - enum pipe pipe_seq[IGT_MAX_PIPES];
> + data_t data;
>
> igt_fixture {
> + data.big_joiner_output_count = 0;
> + data.non_big_joiner_output_count = 0;
> + data.combined_output_count = 0;
> + data.output_count = 0;
> + j = 0;
> +
> data.drm_fd = drm_open_driver_master(DRIVER_INTEL | DRIVER_XE);
> kmstest_set_vt_graphics_mode();
> -
> igt_display_require(&data.display, data.drm_fd);
> + set_all_master_pipes_for_platform(&data);
> igt_require(data.display.is_atomic);
> -
> max_dotclock = igt_get_max_dotclock(data.drm_fd);
>
> for_each_connected_output(&data.display, output) {
> @@ -228,105 +287,55 @@ igt_main
> found = bigjoiner_mode_found(data.drm_fd, connector, max_dotclock, &mode);
>
> if (found) {
> - data.output[count].output_id = output->id;
> - memcpy(&data.output[count].mode, &mode, sizeof(drmModeModeInfo));
> - count++;
> -
> - width = max(width, mode.hdisplay);
> - height = max(height, mode.vdisplay);
> + data.big_joiner_output[data.big_joiner_output_count++] = output;
> + igt_output_override_mode(output, &mode);
> + } else {
> + data.non_big_joiner_output[data.non_big_joiner_output_count++] = output;
> }
> - valid_output++;
> + data.output_count++;
> + }
> + if (data.big_joiner_output_count == 1 && data.non_big_joiner_output_count >= 1) {
> + data.combined_output[data.combined_output_count++] = data.big_joiner_output[0];
> + data.combined_output[data.combined_output_count++] = data.non_big_joiner_output[0];
> }
> -
> data.n_pipes = 0;
> for_each_pipe(&data.display, i) {
> data.n_pipes++;
> - pipe_seq[j] = i;
> + data.pipe_seq[j] = i;
> j++;
> }
> -
> - igt_require_f(count > 0, "No output with 5k+ mode (or) clock > max-dot-clock found\n");
> -
> - igt_create_pattern_fb(data.drm_fd, width, height, DRM_FORMAT_XRGB8888,
> - DRM_FORMAT_MOD_LINEAR, &data.fb);
> }
>
> igt_describe("Verify the basic modeset on big joiner mode on all pipes");
> igt_subtest_with_dynamic("basic") {
> - for (i = 0; i < data.n_pipes - 1; i++) {
> - data.pipe1 = pipe_seq[i];
> - igt_dynamic_f("pipe-%s", kmstest_pipe_name(pipe_seq[i]))
> - test_basic_modeset(&data);
> - }
> + igt_require_f(data.big_joiner_output_count > 0,
> + "No bigjoiner output found\n");
> + igt_require_f(data.n_pipes > 1,
> + "Minimum 2 pipes required\n");
> + igt_dynamic_f("single-joiner")
> + test_single_joiner(&data, data.big_joiner_output_count);
> + if (data.big_joiner_output_count > 1)
> + igt_dynamic_f("multi-joiner")
> + test_multi_joiner(&data, data.big_joiner_output_count);
> }
>
> igt_describe("Verify if the modeset on the adjoining pipe is rejected "
> "when the pipe is active with a big joiner modeset");
> igt_subtest_with_dynamic("invalid-modeset") {
> - data.pipe1 = pipe_seq[j - 1];
> -
> - igt_display_reset(&data.display);
> - for_each_connected_output(&data.display, output) {
> - if (data.output[0].output_id != output->id)
> - continue;
> -
> - mode = data.output[0].mode;
> - igt_output_set_pipe(output, data.pipe1);
> - igt_output_override_mode(output, &mode);
> -
> - igt_dynamic_f("pipe-%s-%s",
> - kmstest_pipe_name(data.pipe1),
> - igt_output_name(output))
> - test_invalid_modeset(&data);
> - }
> -
> - if(valid_output > 1) {
> - for (i = 0; i < data.n_pipes - 1; i++) {
> - igt_output_t *first_output = NULL, *second_output = NULL;
> -
> - data.pipe1 = pipe_seq[i];
> - data.pipe2 = pipe_seq[i + 1];
> -
> - igt_display_reset(&data.display);
> - for_each_connected_output(&data.display, output) {
> - if (data.output[0].output_id == output->id) {
> - first_output = output;
> - mode = data.output[0].mode;
> -
> - igt_output_set_pipe(output, data.pipe1);
> - igt_output_override_mode(output, &mode);
> - } else if (second_output == NULL) {
> - second_output = output;
> - igt_output_set_pipe(output, data.pipe2);
> -
> - break;
> - }
> - }
> -
> - igt_dynamic_f("pipe-%s-%s-pipe-%s-%s",
> - kmstest_pipe_name(data.pipe1),
> - igt_output_name(first_output),
> - kmstest_pipe_name(data.pipe2),
> - igt_output_name(second_output))
> - test_invalid_modeset(&data);
> - }
> - }
> - }
> -
> - igt_describe("Verify simultaneous modeset on 2 big joiner outputs");
> - igt_subtest_with_dynamic("2x-modeset") {
> - igt_require_f(count > 1, "2 outputs with big joiner modes are required\n");
> - igt_require_f(data.n_pipes > 3, "Minumum of 4 pipes are required\n");
> - for (i = 0; (i + 2) < data.n_pipes - 1; i++) {
> - data.pipe1 = pipe_seq[i];
> - data.pipe2 = pipe_seq[i + 2];
> - igt_dynamic_f("pipe-%s-%s", kmstest_pipe_name(pipe_seq[i]), kmstest_pipe_name(pipe_seq[i + 2]))
> - test_dual_display(&data);
> - }
> + igt_require_f(data.big_joiner_output_count > 0, "Non big joiner output not found\n");
> + igt_require_f(data.n_pipes > 1, "Minimum of 2 pipes are required\n");
> + if (data.big_joiner_output_count >= 1)
> + igt_dynamic_f("big_joiner_on_last_pipe")
> + test_big_joiner_on_last_pipe(&data);
> + if (data.big_joiner_output_count > 1)
> + igt_dynamic_f("invalid_combinations")
> + test_invalid_modeset_two_joiner(&data, false);
> + if (data.combined_output_count)
> + igt_dynamic_f("combined_output")
I think we need to mention here that with combined output, we are
actually mixing bigjoiner + non bigjoiner.
Apart from the small cosmetic changes, the patch looks good to me.
Regards,
Ankit
> + test_invalid_modeset_two_joiner(&data, true);
> }
>
> igt_fixture {
> - igt_remove_fb(data.drm_fd, &data.fb);
> igt_display_fini(&data.display);
> drm_close_driver(data.drm_fd);
> }
^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: [PATCH i-g-t 4/4] tests/intel/kms_big_joiner: add tests for force joiner
2024-03-25 16:51 ` [PATCH i-g-t 4/4] tests/intel/kms_big_joiner: add tests for " Kunal Joshi
@ 2024-03-28 7:06 ` Nautiyal, Ankit K
0 siblings, 0 replies; 18+ messages in thread
From: Nautiyal, Ankit K @ 2024-03-28 7:06 UTC (permalink / raw)
To: Kunal Joshi, igt-dev; +Cc: Stanislav Lisovskiy, Karthik B S, Bhanuprakash Modem
On 3/25/2024 10:21 PM, Kunal Joshi wrote:
> add tests for force joiner
Need to addwhy we need to use force joiner, and the subtests added.
>
> v2: check status after forcing (Ankit)
> take out commoon code (Ankit)
> fix missing force_joiner (Ankit)
>
> Cc: Stanislav Lisovskiy <stanislav.lisovskiy@intel.com>
> Cc: Ankit Nautiyal <ankit.k.nautiyal@intel.com>
> Cc: Karthik B S <karthik.b.s@intel.com>
> Cc: Bhanuprakash Modem <bhanuprakash.modem@intel.com>
> Signed-off-by: Kunal Joshi <kunal1.joshi@intel.com>
> ---
> tests/intel/kms_big_joiner.c | 102 +++++++++++++++++++++++++++++------
> 1 file changed, 85 insertions(+), 17 deletions(-)
>
> diff --git a/tests/intel/kms_big_joiner.c b/tests/intel/kms_big_joiner.c
> index b57996212..fd6baccc3 100644
> --- a/tests/intel/kms_big_joiner.c
> +++ b/tests/intel/kms_big_joiner.c
> @@ -44,9 +44,14 @@
> * SUBTEST: basic
> * Description: Verify the basic modeset on big joiner mode on all pipes
> *
> + * SUBTEST: invalid-modeset-force-joiner
> + * Description: Verify if the modeset on the adjoining pipe is rejected when
> + * the pipe is active with a force joiner modeset
> + *
> + * SUBTEST: basic-force-joiner
> + * Description: Verify the basic modeset on force joiner mode on all pipes
I think we need to document that force bigjoiner will be used to test
bigjoiner funtionality with a non bigjoiner panel.
Where the config is already having, bigjoiner, force bigjoiner wouldnt
be used.
With the above documentation changes, this is:
Reviewed-by: Ankit Nautiyal <ankit.k.nautiyal@intel.com>
> */
> -
> -IGT_TEST_DESCRIPTION("Test big joiner");
> +IGT_TEST_DESCRIPTION("Test big joiner / force joiner");
>
> #define INVALID_TEST_OUTPUT 2
>
> @@ -79,6 +84,19 @@ static void set_all_master_pipes_for_platform(data_t *data)
> }
> }
>
> +static void toggle_force_joiner_on_all_non_big_joiner_outputs(data_t *data, bool toggle)
> +{
> + bool status;
> + igt_output_t *output;
> + int i;
> +
> + for (i = 0; i < data->non_big_joiner_output_count; i++) {
> + output = data->non_big_joiner_output[i];
> + status = igt_force_and_check_bigjoiner_status(data->drm_fd, output->name, toggle);
> + igt_assert_f(status, "Failed to toggle force joiner\n");
> + }
> +}
> +
> static enum pipe get_next_master_pipe(data_t *data, unsigned int available_pipe_mask)
> {
> if ((data->master_pipes & available_pipe_mask) == 0)
> @@ -105,7 +123,7 @@ static enum pipe setup_pipe(data_t *data, igt_output_t *output, enum pipe pipe,
> return master_pipe;
> }
>
> -static void test_single_joiner(data_t *data, int output_count)
> +static void test_single_joiner(data_t *data, int output_count, bool force_joiner)
> {
> int i;
> enum pipe pipe, master_pipe;
> @@ -116,7 +134,7 @@ static void test_single_joiner(data_t *data, int output_count)
> igt_fb_t fb;
> drmModeModeInfo *mode;
>
> - outputs = data->big_joiner_output;
> + outputs = force_joiner ? data->non_big_joiner_output : data->big_joiner_output;
>
> for (i = 0; i < output_count; i++) {
> output = outputs[i];
> @@ -137,7 +155,7 @@ static void test_single_joiner(data_t *data, int output_count)
> }
> }
>
> -static void test_multi_joiner(data_t *data, int output_count)
> +static void test_multi_joiner(data_t *data, int output_count, bool force_joiner)
> {
> int i;
> unsigned int available_pipe_mask;
> @@ -149,7 +167,7 @@ static void test_multi_joiner(data_t *data, int output_count)
> drmModeModeInfo *mode;
>
> available_pipe_mask = BIT(data->n_pipes) - 1;
> - outputs = data->big_joiner_output;
> + outputs = force_joiner ? data->non_big_joiner_output : data->big_joiner_output;
>
> igt_display_reset(&data->display);
> for (i = 0; i < output_count; i++) {
> @@ -177,7 +195,7 @@ static void test_multi_joiner(data_t *data, int output_count)
> }
>
> static void test_invalid_modeset_two_joiner(data_t *data,
> - bool combined)
> + bool combined, bool force_joiner)
> {
> int i, j, ret;
> unsigned int available_pipe_mask;
> @@ -190,7 +208,8 @@ static void test_invalid_modeset_two_joiner(data_t *data,
> drmModeModeInfo *mode;
>
> available_pipe_mask = BIT(data->n_pipes) - 1;
> - outputs = combined ? data->combined_output : data->big_joiner_output;
> + outputs = force_joiner ? data->non_big_joiner_output :
> + combined ? data->combined_output : data->big_joiner_output;
>
> for (i = 0; i < data->n_pipes-1; i++) {
> igt_display_reset(&data->display);
> @@ -223,7 +242,7 @@ static void test_invalid_modeset_two_joiner(data_t *data,
> }
> }
>
> -static void test_big_joiner_on_last_pipe(data_t *data)
> +static void test_joiner_on_last_pipe(data_t *data, bool force_joiner)
> {
> int i, len, ret;
> igt_output_t **outputs;
> @@ -232,8 +251,8 @@ static void test_big_joiner_on_last_pipe(data_t *data)
> igt_fb_t fb;
> drmModeModeInfo *mode;
>
> - len = data->big_joiner_output_count;
> - outputs = data->big_joiner_output;
> + len = force_joiner ? data->non_big_joiner_output_count : data->big_joiner_output_count;
> + outputs = force_joiner ? data->non_big_joiner_output : data->big_joiner_output;
>
> for (i = 0; i < len; i++) {
> igt_display_reset(&data->display);
> @@ -257,12 +276,14 @@ static void test_big_joiner_on_last_pipe(data_t *data)
>
> igt_main
> {
> + bool force_joiner_supported;
> int i, j;
> igt_output_t *output;
> drmModeModeInfo mode;
> data_t data;
>
> igt_fixture {
> + force_joiner_supported = false;
> data.big_joiner_output_count = 0;
> data.non_big_joiner_output_count = 0;
> data.combined_output_count = 0;
> @@ -290,7 +311,10 @@ igt_main
> data.big_joiner_output[data.big_joiner_output_count++] = output;
> igt_output_override_mode(output, &mode);
> } else {
> - data.non_big_joiner_output[data.non_big_joiner_output_count++] = output;
> + if (igt_has_force_joiner_debugfs(data.drm_fd, output)) {
> + force_joiner_supported = true;
> + data.non_big_joiner_output[data.non_big_joiner_output_count++] = output;
> + }
> }
> data.output_count++;
> }
> @@ -313,10 +337,10 @@ igt_main
> igt_require_f(data.n_pipes > 1,
> "Minimum 2 pipes required\n");
> igt_dynamic_f("single-joiner")
> - test_single_joiner(&data, data.big_joiner_output_count);
> + test_single_joiner(&data, data.big_joiner_output_count, false);
> if (data.big_joiner_output_count > 1)
> igt_dynamic_f("multi-joiner")
> - test_multi_joiner(&data, data.big_joiner_output_count);
> + test_multi_joiner(&data, data.big_joiner_output_count, false);
> }
>
> igt_describe("Verify if the modeset on the adjoining pipe is rejected "
> @@ -326,13 +350,57 @@ igt_main
> igt_require_f(data.n_pipes > 1, "Minimum of 2 pipes are required\n");
> if (data.big_joiner_output_count >= 1)
> igt_dynamic_f("big_joiner_on_last_pipe")
> - test_big_joiner_on_last_pipe(&data);
> + test_joiner_on_last_pipe(&data, false);
> if (data.big_joiner_output_count > 1)
> igt_dynamic_f("invalid_combinations")
> - test_invalid_modeset_two_joiner(&data, false);
> + test_invalid_modeset_two_joiner(&data, false, false);
> if (data.combined_output_count)
> igt_dynamic_f("combined_output")
> - test_invalid_modeset_two_joiner(&data, true);
> + test_invalid_modeset_two_joiner(&data, true, false);
> + }
> +
> + igt_describe("Verify the basic modeset on big joiner mode on all pipes");
> + igt_subtest_with_dynamic("basic-force-joiner") {
> + igt_require_f(force_joiner_supported,
> + "force joiner not supported on this platform or none of the connected output supports it\n");
> + igt_require_f(data.non_big_joiner_output_count > 0,
> + "No non big joiner output found\n");
> + igt_require_f(data.n_pipes > 1,
> + "Minimum 2 pipes required\n");
> + igt_dynamic_f("single") {
> + toggle_force_joiner_on_all_non_big_joiner_outputs(&data, true);
> + test_single_joiner(&data, data.non_big_joiner_output_count, true);
> + toggle_force_joiner_on_all_non_big_joiner_outputs(&data, false);
> + }
> + if (data.non_big_joiner_output_count > 1) {
> + igt_dynamic_f("multi") {
> + toggle_force_joiner_on_all_non_big_joiner_outputs(&data, true);
> + test_multi_joiner(&data, data.non_big_joiner_output_count, true);
> + toggle_force_joiner_on_all_non_big_joiner_outputs(&data, false);
> + }
> + }
> + }
> +
> + igt_subtest_with_dynamic("invalid-modeset-force-joiner") {
> + igt_require_f(force_joiner_supported,
> + "force joiner not supported on this platform or none of the connected output supports it\n");
> + igt_require_f(data.non_big_joiner_output_count > 0, "Non big joiner output not found\n");
> + igt_require_f(data.n_pipes > 1, "Minimum of 2 pipes are required\n");
> +
> + if (data.non_big_joiner_output_count >= 1) {
> + igt_dynamic_f("big_joiner_on_last_pipe") {
> + toggle_force_joiner_on_all_non_big_joiner_outputs(&data, true);
> + test_joiner_on_last_pipe(&data, true);
> + toggle_force_joiner_on_all_non_big_joiner_outputs(&data, false);
> + }
> + }
> + if (data.non_big_joiner_output_count > 1) {
> + igt_dynamic_f("invalid_combinations") {
> + toggle_force_joiner_on_all_non_big_joiner_outputs(&data, true);
> + test_invalid_modeset_two_joiner(&data, false, true);
> + toggle_force_joiner_on_all_non_big_joiner_outputs(&data, false);
> + }
> + }
> }
>
> igt_fixture {
^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: [PATCH i-g-t 3/4] lib/igt_kms: add helper to enable/disable force joiner
2024-03-25 16:51 ` [PATCH i-g-t 3/4] lib/igt_kms: add helper to enable/disable force joiner Kunal Joshi
@ 2024-03-28 7:11 ` Nautiyal, Ankit K
0 siblings, 0 replies; 18+ messages in thread
From: Nautiyal, Ankit K @ 2024-03-28 7:11 UTC (permalink / raw)
To: Kunal Joshi, igt-dev; +Cc: Stanislav Lisovskiy, Karthik B S, Bhanuprakash Modem
On 3/25/2024 10:21 PM, Kunal Joshi wrote:
> v2: Add documentation and rename (Ankit)
> Combine enable/disable and status check (Ankit)
> Don't assert in igt_has_force_joiner_debugfs (Ankit)
Version history should come after the commit message.
I think this got mix up between series rev 7-8.
Regards,
Ankit
>
> add helpers to check whether force joiner debugfs exists
> and to enable/disable force joiner for a specific connector.
>
> Cc: Stanislav Lisovskiy <stanislav.lisovskiy@intel.com>
> Cc: Ankit Nautiyal <ankit.k.nautiyal@intel.com>
> Cc: Karthik B S <karthik.b.s@intel.com>
> Cc: Bhanuprakash Modem <bhanuprakash.modem@intel.com>
> Signed-off-by: Kunal Joshi <kunal1.joshi@intel.com>
> Reviewed-by: Ankit Nautiyal <ankit.k.nautiyal@intel.com>
> ---
> lib/igt_kms.c | 51 +++++++++++++++++++++++++++++++++++++++++++++++++++
> lib/igt_kms.h | 2 ++
> 2 files changed, 53 insertions(+)
>
> diff --git a/lib/igt_kms.c b/lib/igt_kms.c
> index 548c9d1f3..c38021dd7 100644
> --- a/lib/igt_kms.c
> +++ b/lib/igt_kms.c
> @@ -6171,6 +6171,57 @@ bool bigjoiner_mode_found(int drm_fd, drmModeConnector *connector,
> return found;
> }
>
> +/**
> + * Checks if the force big joiner debugfs is available
> + * for a specific connector.
> + *
> + * @drmfd: file descriptor of the DRM device.
> + * @output: output to check.
> + * Returns:
> + * true if the debugfs is available, false otherwise.
> + */
> +bool igt_has_force_joiner_debugfs(int drmfd, igt_output_t *output)
> +{
> + char buf[512];
> + int debugfs_fd, ret;
> +
> + igt_assert_f(output->name, "Connector name cannot be NULL\n");
> + debugfs_fd = igt_debugfs_connector_dir(drmfd, output->name, O_RDONLY);
> + if (debugfs_fd < 0)
> + return false;
> + ret = igt_debugfs_simple_read(debugfs_fd, "i915_bigjoiner_force_enable", buf, sizeof(buf));
> + close(debugfs_fd);
> + return ret >= 0;
> +}
> +
> +/**
> + * Forces the enable/disable state of big joiner for a specific connector.
> + *
> + * @drmfd The file descriptor of the DRM device.
> + * @connector_name The name of the connector.
> + * @enable The desired state of big joiner (true for enable, false for disable).
> + * Returns:
> + * true if writing the debugfs was successful
> + * and the state was set as requested, false otherwise.
> + */
> +bool igt_force_and_check_bigjoiner_status(int drmfd, char *connector_name, bool enable)
> +{
> + int debugfs_fd, ret;
> + char buf[512];
> +
> + igt_assert_f(connector_name, "Connector name cannot be NULL\n");
> + debugfs_fd = igt_debugfs_connector_dir(drmfd, connector_name, O_DIRECTORY);
> + igt_assert_f(debugfs_fd >= 0, "Could not open debugfs for connector %s\n", connector_name);
> + ret = igt_sysfs_write(debugfs_fd, "i915_bigjoiner_force_enable", enable ? "1" : "0", 1);
> + igt_assert_f(ret > 0, "Could not write i915_bigjoiner_force_enable for connector %s\n", connector_name);
> + ret = igt_debugfs_simple_read(debugfs_fd, "i915_bigjoiner_force_enable", buf, sizeof(buf));
> + close(debugfs_fd);
> + igt_assert_f(ret > 0, "Could not read i915_bigjoiner_force_enable for connector %s\n", connector_name);
> +
> + return enable ? strstr(buf, "Bigjoiner enable: 1") :
> + strstr(buf, "Bigjoiner enable: 0");
> +}
> +
> /**
> * igt_check_bigjoiner_support:
> * @display: a pointer to an #igt_display_t structure
> diff --git a/lib/igt_kms.h b/lib/igt_kms.h
> index 0fa7a2ea1..6d13e5851 100644
> --- a/lib/igt_kms.h
> +++ b/lib/igt_kms.h
> @@ -1214,6 +1214,8 @@ int igt_get_max_dotclock(int fd);
> bool igt_bigjoiner_possible(drmModeModeInfo *mode, int max_dotclock);
> bool bigjoiner_mode_found(int drm_fd, drmModeConnector *connector,
> int max_dotclock, drmModeModeInfo *mode);
> +bool igt_has_force_joiner_debugfs(int drmfd, igt_output_t *output);
> +bool igt_force_and_check_bigjoiner_status(int drmfd, char *connector_name, bool enable);
> bool igt_check_bigjoiner_support(igt_display_t *display);
> bool igt_parse_mode_string(const char *mode_string, drmModeModeInfo *mode);
> bool intel_pipe_output_combo_valid(igt_display_t *display);
^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: [PATCH i-g-t 2/4] tests/intel/kms_big_joiner: revamp bigjoiner
2024-03-28 8:39 ` [PATCH i-g-t 2/4] tests/intel/kms_big_joiner: revamp bigjoiner Kunal Joshi
@ 2024-03-28 9:18 ` Nautiyal, Ankit K
0 siblings, 0 replies; 18+ messages in thread
From: Nautiyal, Ankit K @ 2024-03-28 9:18 UTC (permalink / raw)
To: Kunal Joshi, igt-dev; +Cc: Stanislav Lisovskiy, Karthik B S, Bhanuprakash Modem
On 3/28/2024 2:09 PM, Kunal Joshi wrote:
> modify test to support simultaneously testing multiple bigjoiner
> output and ignoring fused off pipes.
>
> v2: Don't change license (Bhanu)
> Print the pipe name (Bhanu)
> Remove unwanted commit (Bhanu)
> Move combine output logic to igt_fixture (Bhanu)
> split revamp and force joiner (Bhanu)
>
> v3: Ignored fused pipes (Stan)
>
> v4: Ignore master pipes who doesn't have slave (Ankit)
> Retain subtest names (Ankit)
> Use commit instead of try_commit (Ankit)
> Fix typo (Ankit)
>
> v5: Fix condition and remove last pipe (Ankit)
> Remove nested if (Ankit)
> Use pointer to output instead of id (Ankit)
> Add missing igt_describe (Ankit)
>
> v6: Use uint_32 (Ankit)
> Cosmetic changes (Ankit)
>
> Cc: Stanislav Lisovskiy <stanislav.lisovskiy@intel.com>
> Cc: Ankit Nautiyal <ankit.k.nautiyal@intel.com>
> Cc: Karthik B S <karthik.b.s@intel.com>
> Cc: Bhanuprakash Modem <bhanuprakash.modem@intel.com>
> Signed-off-by: Kunal Joshi <kunal1.joshi@intel.com>
> Signed-off-by: Stanislav Lisovskiy <stanislav.lisovskiy@intel.com>
> ---
> tests/intel/kms_big_joiner.c | 402 ++++++++++++++++++-----------------
> 1 file changed, 207 insertions(+), 195 deletions(-)
>
> diff --git a/tests/intel/kms_big_joiner.c b/tests/intel/kms_big_joiner.c
> index 99b1b898d..bc4facead 100644
> --- a/tests/intel/kms_big_joiner.c
> +++ b/tests/intel/kms_big_joiner.c
> @@ -44,177 +44,236 @@
> * SUBTEST: basic
> * Description: Verify the basic modeset on big joiner mode on all pipes
> *
> - * SUBTEST: 2x-modeset
> - * Description: Verify simultaneous modeset on 2 big joiner outputs
> */
>
> IGT_TEST_DESCRIPTION("Test big joiner");
>
> -struct bigjoiner_output {
> - uint32_t output_id;
> - drmModeModeInfo mode;
> -};
> +#define INVALID_TEST_OUTPUT 2
>
> typedef struct {
> int drm_fd;
> - igt_display_t display;
> - struct igt_fb fb;
> + int big_joiner_output_count;
> + int non_big_joiner_output_count;
> + int mixed_output_count;
> + int output_count;
> int n_pipes;
> - enum pipe pipe1;
> - enum pipe pipe2;
> - struct bigjoiner_output output[2];
> + uint32_t master_pipes;
> + igt_output_t *big_joiner_output[IGT_MAX_PIPES];
> + igt_output_t *non_big_joiner_output[IGT_MAX_PIPES];
> + igt_output_t *mixed_output[IGT_MAX_PIPES];
> + enum pipe pipe_seq[IGT_MAX_PIPES];
> + igt_display_t display;
> } data_t;
>
> static int max_dotclock;
>
> -static void test_invalid_modeset(data_t *data)
> +static void set_all_master_pipes_for_platform(data_t *data)
> {
> - igt_output_t *output;
> - igt_display_t *display = &data->display;
> - int ret;
> + enum pipe pipe;
>
> - igt_info("Bigjoiner test on ");
> - for_each_connected_output(display, output){
> - enum pipe p = output->pending_pipe;
> - drmModeModeInfo *mode;
> - igt_pipe_t *pipe;
> - igt_plane_t *plane;
> -
> - if (p == PIPE_NONE)
> - continue;
> + for (pipe = PIPE_A; pipe < IGT_MAX_PIPES - 1; pipe++) {
> + if (data->display.pipes[pipe].enabled && data->display.pipes[pipe + 1].enabled) {
> + data->master_pipes |= BIT(pipe);
> + igt_info("Found master pipe %s\n", kmstest_pipe_name(pipe));
> + }
> + }
> +}
>
> - mode = igt_output_get_mode(output);
> - igt_info("pipe:%s, output:%s, mode:", kmstest_pipe_name(p), igt_output_name(output));
> - kmstest_dump_mode(mode);
> +static enum pipe get_next_master_pipe(data_t *data, uint32_t available_pipe_mask)
> +{
> + if ((data->master_pipes & available_pipe_mask) == 0)
> + return PIPE_NONE;
>
> - pipe = &display->pipes[p];
> - plane = igt_pipe_get_plane_type(pipe, DRM_PLANE_TYPE_PRIMARY);
> + return ffs(data->master_pipes & available_pipe_mask) - 1;
> +}
>
> - igt_plane_set_fb(plane, &data->fb);
> - igt_fb_set_size(&data->fb, plane, mode->hdisplay, mode->vdisplay);
> - igt_plane_set_size(plane, mode->hdisplay, mode->vdisplay);
> - }
> +static enum pipe setup_pipe(data_t *data, igt_output_t *output, enum pipe pipe, unsigned int available_pipe_mask)
Here too available_pipe_mask needs to be uint32_t.
With this changed, this is:
Reviewed-by: Ankit Nautiyal <ankit.k.nautiyal@intel.com>
> +{
> + enum pipe master_pipe;
> + uint32_t attempt_mask;
>
> - igt_assert(!igt_check_bigjoiner_support(display));
> + attempt_mask = BIT(pipe);
> + master_pipe = get_next_master_pipe(data, available_pipe_mask & attempt_mask);
>
> - /* This commit is expectd to fail as this pipe is being used for big joiner */
> - ret = igt_display_try_commit_atomic(display, DRM_MODE_ATOMIC_TEST_ONLY |
> - DRM_MODE_ATOMIC_ALLOW_MODESET, NULL);
> + if (master_pipe == PIPE_NONE)
> + return PIPE_NONE;
>
> - igt_display_reset(&data->display);
> - igt_display_commit2(display, COMMIT_ATOMIC);
> + igt_info("Using pipe %s as master and %s slave for %s\n", kmstest_pipe_name(pipe),
> + kmstest_pipe_name(pipe + 1), output->name);
> + igt_output_set_pipe(output, pipe);
>
> - igt_assert_lt(ret, 0);
> + return master_pipe;
> }
>
> -static void test_basic_modeset(data_t *data)
> +static void test_single_joiner(data_t *data, int output_count)
> {
> + int i;
> + enum pipe pipe, master_pipe;
> + uint32_t available_pipe_mask = BIT(data->n_pipes) - 1;
> + igt_output_t *output;
> + igt_plane_t *primary;
> + igt_output_t **outputs;
> + igt_fb_t fb;
> drmModeModeInfo *mode;
> - igt_output_t *output, *bigjoiner_output = NULL;
> - igt_display_t *display = &data->display;
> - igt_pipe_t *pipe;
> - igt_plane_t *plane;
>
> - igt_display_reset(display);
> + outputs = data->big_joiner_output;
>
> - for_each_connected_output(display, output) {
> - if (data->output[0].output_id == output->id) {
> - bigjoiner_output = output;
> - break;
> + for (i = 0; i < output_count; i++) {
> + output = outputs[i];
> + for (pipe = 0; pipe < data->n_pipes - 1; pipe++) {
> + igt_display_reset(&data->display);
> + master_pipe = setup_pipe(data, output, pipe, available_pipe_mask);
> + if (master_pipe == PIPE_NONE)
> + continue;
> + mode = igt_output_get_mode(output);
> + primary = igt_output_get_plane_type(output, DRM_PLANE_TYPE_PRIMARY);
> + igt_create_pattern_fb(data->drm_fd, mode->hdisplay, mode->vdisplay, DRM_FORMAT_XRGB8888,
> + DRM_FORMAT_MOD_LINEAR, &fb);
> + igt_plane_set_fb(primary, &fb);
> + igt_display_commit2(&data->display, COMMIT_ATOMIC);
> + igt_plane_set_fb(primary, NULL);
> + igt_remove_fb(data->drm_fd, &fb);
> }
> }
> -
> - igt_output_set_pipe(bigjoiner_output, data->pipe1);
> -
> - mode = &data->output[0].mode;
> - igt_output_override_mode(bigjoiner_output, mode);
> -
> - pipe = &display->pipes[data->pipe1];
> - plane = igt_pipe_get_plane_type(pipe, DRM_PLANE_TYPE_PRIMARY);
> -
> - igt_plane_set_fb(plane, &data->fb);
> - igt_fb_set_size(&data->fb, plane, mode->hdisplay, mode->vdisplay);
> - igt_plane_set_size(plane, mode->hdisplay, mode->vdisplay);
> -
> - igt_display_commit2(display, COMMIT_ATOMIC);
> -
> - igt_output_set_pipe(bigjoiner_output, PIPE_NONE);
> - igt_plane_set_fb(plane, NULL);
> - igt_display_commit2(display, COMMIT_ATOMIC);
> }
>
> -static void test_dual_display(data_t *data)
> +static void test_multi_joiner(data_t *data, int output_count)
> {
> + int i;
> + uint32_t available_pipe_mask;
> + enum pipe pipe, master_pipe;
> + igt_output_t **outputs;
> + igt_output_t *output;
> + igt_plane_t *primary[output_count];
> + igt_fb_t fb[output_count];
> drmModeModeInfo *mode;
> - igt_output_t *output, *bigjoiner_output[2];
> - igt_display_t *display = &data->display;
> - igt_pipe_t *pipe;
> - igt_plane_t *plane1, *plane2;
> - int count = 0;
> -
> - igt_display_reset(display);
> -
> - for_each_connected_output(display, output) {
> - if (data->output[count].output_id == output->id) {
> - bigjoiner_output[count] = output;
> - count++;
> - }
>
> - if (count > 1)
> + available_pipe_mask = BIT(data->n_pipes) - 1;
> + outputs = data->big_joiner_output;
> +
> + igt_display_reset(&data->display);
> + for (i = 0; i < output_count; i++) {
> + output = outputs[i];
> + for (pipe = 0; pipe < data->n_pipes; pipe++) {
> + master_pipe = setup_pipe(data, output, pipe, available_pipe_mask);
> + if (master_pipe == PIPE_NONE)
> + continue;
> + mode = igt_output_get_mode(output);
> + primary[i] = igt_output_get_plane_type(output, DRM_PLANE_TYPE_PRIMARY);
> + igt_create_pattern_fb(data->drm_fd, mode->hdisplay, mode->vdisplay, DRM_FORMAT_XRGB8888,
> + DRM_FORMAT_MOD_LINEAR, &fb[i]);
> + igt_plane_set_fb(primary[i], &fb[i]);
> +
> + available_pipe_mask &= ~BIT(master_pipe);
> + available_pipe_mask &= ~BIT(master_pipe + 1);
> break;
> + }
> }
> + igt_display_commit2(&data->display, COMMIT_ATOMIC);
> + for (i = 0; i < output_count; i++) {
> + igt_plane_set_fb(primary[i], NULL);
> + igt_remove_fb(data->drm_fd, &fb[i]);
> + }
> +}
>
> - igt_output_set_pipe(bigjoiner_output[0], data->pipe1);
> - igt_output_set_pipe(bigjoiner_output[1], data->pipe2);
> -
> - /* Set up first big joiner output on Pipe A*/
> - mode = &data->output[0].mode;
> - igt_output_override_mode(bigjoiner_output[0], mode);
> +static void test_invalid_modeset_two_joiner(data_t *data,
> + bool mixed)
> +{
> + int i, j, ret;
> + uint32_t available_pipe_mask;
> + uint32_t attempt_mask;
> + enum pipe master_pipe;
> + igt_output_t **outputs;
> + igt_output_t *output;
> + igt_plane_t *primary[INVALID_TEST_OUTPUT];
> + igt_fb_t fb[INVALID_TEST_OUTPUT];
> + drmModeModeInfo *mode;
>
> - pipe = &display->pipes[data->pipe1];
> - plane1 = igt_pipe_get_plane_type(pipe, DRM_PLANE_TYPE_PRIMARY);
> + available_pipe_mask = BIT(data->n_pipes) - 1;
> + outputs = mixed ? data->mixed_output : data->big_joiner_output;
>
> - igt_plane_set_fb(plane1, &data->fb);
> - igt_fb_set_size(&data->fb, plane1, mode->hdisplay, mode->vdisplay);
> - igt_plane_set_size(plane1, mode->hdisplay, mode->vdisplay);
> + for (i = 0; i < data->n_pipes - 1; i++) {
> + igt_display_reset(&data->display);
> + attempt_mask = BIT(data->pipe_seq[i]);
> + master_pipe = get_next_master_pipe(data, available_pipe_mask & attempt_mask);
>
> - /* Set up second big joiner output on Pipe C*/
> - mode = &data->output[1].mode;
> - igt_output_override_mode(bigjoiner_output[1], mode);
> + if (master_pipe == PIPE_NONE)
> + continue;
>
> - pipe = &display->pipes[data->pipe2];
> - plane2 = igt_pipe_get_plane_type(pipe, DRM_PLANE_TYPE_PRIMARY);
> + for (j = 0; j < INVALID_TEST_OUTPUT; j++) {
> + output = outputs[j];
> + igt_output_set_pipe(output, data->pipe_seq[i + j]);
> + mode = igt_output_get_mode(output);
> + igt_info("Assigning pipe %s to %s with mode %dx%d@%d%s",
> + kmstest_pipe_name(data->pipe_seq[i + j]),
> + igt_output_name(output), mode->hdisplay,
> + mode->vdisplay, mode->vrefresh,
> + j == INVALID_TEST_OUTPUT - 1 ? "\n" : ", ");
> + primary[j] = igt_output_get_plane_type(output, DRM_PLANE_TYPE_PRIMARY);
> + igt_create_pattern_fb(data->drm_fd, mode->hdisplay, mode->vdisplay, DRM_FORMAT_XRGB8888,
> + DRM_FORMAT_MOD_LINEAR, &fb[j]);
> + igt_plane_set_fb(primary[j], &fb[j]);
> + }
> + ret = igt_display_try_commit2(&data->display, COMMIT_ATOMIC);
> + for (j = 0; j < INVALID_TEST_OUTPUT; j++) {
> + igt_plane_set_fb(primary[j], NULL);
> + igt_remove_fb(data->drm_fd, &fb[j]);
> + }
> + igt_assert_f(ret != 0, "Commit shouldn't have passed\n");
> + }
> +}
>
> - igt_plane_set_fb(plane2, &data->fb);
> - igt_fb_set_size(&data->fb, plane2, mode->hdisplay, mode->vdisplay);
> - igt_plane_set_size(plane2, mode->hdisplay, mode->vdisplay);
> +static void test_big_joiner_on_last_pipe(data_t *data)
> +{
> + int i, len, ret;
> + igt_output_t **outputs;
> + igt_output_t *output;
> + igt_plane_t *primary;
> + igt_fb_t fb;
> + drmModeModeInfo *mode;
>
> - igt_display_commit2(display, COMMIT_ATOMIC);
> + len = data->big_joiner_output_count;
> + outputs = data->big_joiner_output;
>
> - /* Clean up */
> - igt_output_set_pipe(bigjoiner_output[0], PIPE_NONE);
> - igt_output_set_pipe(bigjoiner_output[1], PIPE_NONE);
> - igt_plane_set_fb(plane1, NULL);
> - igt_plane_set_fb(plane2, NULL);
> - igt_display_commit2(display, COMMIT_ATOMIC);
> + for (i = 0; i < len; i++) {
> + igt_display_reset(&data->display);
> + output = outputs[i];
> + igt_output_set_pipe(output, data->pipe_seq[data->n_pipes - 1]);
> + mode = igt_output_get_mode(output);
> + igt_info(" Assigning pipe %s to %s with mode %dx%d@%d\n",
> + kmstest_pipe_name(data->pipe_seq[data->n_pipes - 1]),
> + igt_output_name(output), mode->hdisplay,
> + mode->vdisplay, mode->vrefresh);
> + primary = igt_output_get_plane_type(output, DRM_PLANE_TYPE_PRIMARY);
> + igt_create_pattern_fb(data->drm_fd, mode->hdisplay, mode->vdisplay, DRM_FORMAT_XRGB8888,
> + DRM_FORMAT_MOD_LINEAR, &fb);
> + igt_plane_set_fb(primary, &fb);
> + ret = igt_display_try_commit2(&data->display, COMMIT_ATOMIC);
> + igt_plane_set_fb(primary, NULL);
> + igt_remove_fb(data->drm_fd, &fb);
> + igt_assert_f(ret != 0, "Commit shouldn't have passed\n");
> + }
> }
>
> igt_main
> {
> - data_t data;
> + int i, j;
> igt_output_t *output;
> drmModeModeInfo mode;
> - int valid_output = 0, i, count = 0, j = 0;
> - uint16_t width = 0, height = 0;
> - enum pipe pipe_seq[IGT_MAX_PIPES];
> + data_t data;
>
> igt_fixture {
> + data.big_joiner_output_count = 0;
> + data.non_big_joiner_output_count = 0;
> + data.mixed_output_count = 0;
> + data.output_count = 0;
> + j = 0;
> +
> data.drm_fd = drm_open_driver_master(DRIVER_INTEL | DRIVER_XE);
> kmstest_set_vt_graphics_mode();
> -
> igt_display_require(&data.display, data.drm_fd);
> + set_all_master_pipes_for_platform(&data);
> igt_require(data.display.is_atomic);
> -
> max_dotclock = igt_get_max_dotclock(data.drm_fd);
>
> for_each_connected_output(&data.display, output) {
> @@ -228,105 +287,58 @@ igt_main
> found = bigjoiner_mode_found(data.drm_fd, connector, max_dotclock, &mode);
>
> if (found) {
> - data.output[count].output_id = output->id;
> - memcpy(&data.output[count].mode, &mode, sizeof(drmModeModeInfo));
> - count++;
> -
> - width = max(width, mode.hdisplay);
> - height = max(height, mode.vdisplay);
> + data.big_joiner_output[data.big_joiner_output_count++] = output;
> + igt_output_override_mode(output, &mode);
> + } else {
> + data.non_big_joiner_output[data.non_big_joiner_output_count++] = output;
> }
> - valid_output++;
> + data.output_count++;
> + }
> + if (data.big_joiner_output_count == 1 && data.non_big_joiner_output_count >= 1) {
> + /*
> + * Mixed output consists of 1 bigjoiner output and 1 non bigjoiner output
> + */
> + data.mixed_output[data.mixed_output_count++] = data.big_joiner_output[0];
> + data.mixed_output[data.mixed_output_count++] = data.non_big_joiner_output[0];
> }
> -
> data.n_pipes = 0;
> for_each_pipe(&data.display, i) {
> data.n_pipes++;
> - pipe_seq[j] = i;
> + data.pipe_seq[j] = i;
> j++;
> }
> -
> - igt_require_f(count > 0, "No output with 5k+ mode (or) clock > max-dot-clock found\n");
> -
> - igt_create_pattern_fb(data.drm_fd, width, height, DRM_FORMAT_XRGB8888,
> - DRM_FORMAT_MOD_LINEAR, &data.fb);
> }
>
> igt_describe("Verify the basic modeset on big joiner mode on all pipes");
> igt_subtest_with_dynamic("basic") {
> - for (i = 0; i < data.n_pipes - 1; i++) {
> - data.pipe1 = pipe_seq[i];
> - igt_dynamic_f("pipe-%s", kmstest_pipe_name(pipe_seq[i]))
> - test_basic_modeset(&data);
> - }
> + igt_require_f(data.big_joiner_output_count > 0,
> + "No bigjoiner output found\n");
> + igt_require_f(data.n_pipes > 1,
> + "Minimum 2 pipes required\n");
> + igt_dynamic_f("single-joiner")
> + test_single_joiner(&data, data.big_joiner_output_count);
> + if (data.big_joiner_output_count > 1)
> + igt_dynamic_f("multi-joiner")
> + test_multi_joiner(&data, data.big_joiner_output_count);
> }
>
> igt_describe("Verify if the modeset on the adjoining pipe is rejected "
> "when the pipe is active with a big joiner modeset");
> igt_subtest_with_dynamic("invalid-modeset") {
> - data.pipe1 = pipe_seq[j - 1];
> -
> - igt_display_reset(&data.display);
> - for_each_connected_output(&data.display, output) {
> - if (data.output[0].output_id != output->id)
> - continue;
> -
> - mode = data.output[0].mode;
> - igt_output_set_pipe(output, data.pipe1);
> - igt_output_override_mode(output, &mode);
> -
> - igt_dynamic_f("pipe-%s-%s",
> - kmstest_pipe_name(data.pipe1),
> - igt_output_name(output))
> - test_invalid_modeset(&data);
> - }
> -
> - if(valid_output > 1) {
> - for (i = 0; i < data.n_pipes - 1; i++) {
> - igt_output_t *first_output = NULL, *second_output = NULL;
> -
> - data.pipe1 = pipe_seq[i];
> - data.pipe2 = pipe_seq[i + 1];
> -
> - igt_display_reset(&data.display);
> - for_each_connected_output(&data.display, output) {
> - if (data.output[0].output_id == output->id) {
> - first_output = output;
> - mode = data.output[0].mode;
> -
> - igt_output_set_pipe(output, data.pipe1);
> - igt_output_override_mode(output, &mode);
> - } else if (second_output == NULL) {
> - second_output = output;
> - igt_output_set_pipe(output, data.pipe2);
> -
> - break;
> - }
> - }
> -
> - igt_dynamic_f("pipe-%s-%s-pipe-%s-%s",
> - kmstest_pipe_name(data.pipe1),
> - igt_output_name(first_output),
> - kmstest_pipe_name(data.pipe2),
> - igt_output_name(second_output))
> - test_invalid_modeset(&data);
> - }
> - }
> - }
> -
> - igt_describe("Verify simultaneous modeset on 2 big joiner outputs");
> - igt_subtest_with_dynamic("2x-modeset") {
> - igt_require_f(count > 1, "2 outputs with big joiner modes are required\n");
> - igt_require_f(data.n_pipes > 3, "Minumum of 4 pipes are required\n");
> - for (i = 0; (i + 2) < data.n_pipes - 1; i++) {
> - data.pipe1 = pipe_seq[i];
> - data.pipe2 = pipe_seq[i + 2];
> - igt_dynamic_f("pipe-%s-%s", kmstest_pipe_name(pipe_seq[i]), kmstest_pipe_name(pipe_seq[i + 2]))
> - test_dual_display(&data);
> - }
> + igt_require_f(data.big_joiner_output_count > 0, "Non big joiner output not found\n");
> + igt_require_f(data.n_pipes > 1, "Minimum of 2 pipes are required\n");
> + if (data.big_joiner_output_count >= 1)
> + igt_dynamic_f("big_joiner_on_last_pipe")
> + test_big_joiner_on_last_pipe(&data);
> + if (data.big_joiner_output_count > 1)
> + igt_dynamic_f("invalid_combinations")
> + test_invalid_modeset_two_joiner(&data, false);
> + if (data.mixed_output_count)
> + igt_dynamic_f("mixed_output")
> + test_invalid_modeset_two_joiner(&data, true);
> }
>
> igt_fixture {
> - igt_remove_fb(data.drm_fd, &data.fb);
> igt_display_fini(&data.display);
> drm_close_driver(data.drm_fd);
> }
^ permalink raw reply [flat|nested] 18+ messages in thread
* [PATCH i-g-t 2/4] tests/intel/kms_big_joiner: revamp bigjoiner
2024-03-28 8:39 [PATCH i-g-t 0/4] revamp big joiner test Kunal Joshi
@ 2024-03-28 8:39 ` Kunal Joshi
2024-03-28 9:18 ` Nautiyal, Ankit K
0 siblings, 1 reply; 18+ messages in thread
From: Kunal Joshi @ 2024-03-28 8:39 UTC (permalink / raw)
To: igt-dev
Cc: Kunal Joshi, Stanislav Lisovskiy, Ankit Nautiyal, Karthik B S,
Bhanuprakash Modem
modify test to support simultaneously testing multiple bigjoiner
output and ignoring fused off pipes.
v2: Don't change license (Bhanu)
Print the pipe name (Bhanu)
Remove unwanted commit (Bhanu)
Move combine output logic to igt_fixture (Bhanu)
split revamp and force joiner (Bhanu)
v3: Ignored fused pipes (Stan)
v4: Ignore master pipes who doesn't have slave (Ankit)
Retain subtest names (Ankit)
Use commit instead of try_commit (Ankit)
Fix typo (Ankit)
v5: Fix condition and remove last pipe (Ankit)
Remove nested if (Ankit)
Use pointer to output instead of id (Ankit)
Add missing igt_describe (Ankit)
v6: Use uint_32 (Ankit)
Cosmetic changes (Ankit)
Cc: Stanislav Lisovskiy <stanislav.lisovskiy@intel.com>
Cc: Ankit Nautiyal <ankit.k.nautiyal@intel.com>
Cc: Karthik B S <karthik.b.s@intel.com>
Cc: Bhanuprakash Modem <bhanuprakash.modem@intel.com>
Signed-off-by: Kunal Joshi <kunal1.joshi@intel.com>
Signed-off-by: Stanislav Lisovskiy <stanislav.lisovskiy@intel.com>
---
tests/intel/kms_big_joiner.c | 402 ++++++++++++++++++-----------------
1 file changed, 207 insertions(+), 195 deletions(-)
diff --git a/tests/intel/kms_big_joiner.c b/tests/intel/kms_big_joiner.c
index 99b1b898d..bc4facead 100644
--- a/tests/intel/kms_big_joiner.c
+++ b/tests/intel/kms_big_joiner.c
@@ -44,177 +44,236 @@
* SUBTEST: basic
* Description: Verify the basic modeset on big joiner mode on all pipes
*
- * SUBTEST: 2x-modeset
- * Description: Verify simultaneous modeset on 2 big joiner outputs
*/
IGT_TEST_DESCRIPTION("Test big joiner");
-struct bigjoiner_output {
- uint32_t output_id;
- drmModeModeInfo mode;
-};
+#define INVALID_TEST_OUTPUT 2
typedef struct {
int drm_fd;
- igt_display_t display;
- struct igt_fb fb;
+ int big_joiner_output_count;
+ int non_big_joiner_output_count;
+ int mixed_output_count;
+ int output_count;
int n_pipes;
- enum pipe pipe1;
- enum pipe pipe2;
- struct bigjoiner_output output[2];
+ uint32_t master_pipes;
+ igt_output_t *big_joiner_output[IGT_MAX_PIPES];
+ igt_output_t *non_big_joiner_output[IGT_MAX_PIPES];
+ igt_output_t *mixed_output[IGT_MAX_PIPES];
+ enum pipe pipe_seq[IGT_MAX_PIPES];
+ igt_display_t display;
} data_t;
static int max_dotclock;
-static void test_invalid_modeset(data_t *data)
+static void set_all_master_pipes_for_platform(data_t *data)
{
- igt_output_t *output;
- igt_display_t *display = &data->display;
- int ret;
+ enum pipe pipe;
- igt_info("Bigjoiner test on ");
- for_each_connected_output(display, output){
- enum pipe p = output->pending_pipe;
- drmModeModeInfo *mode;
- igt_pipe_t *pipe;
- igt_plane_t *plane;
-
- if (p == PIPE_NONE)
- continue;
+ for (pipe = PIPE_A; pipe < IGT_MAX_PIPES - 1; pipe++) {
+ if (data->display.pipes[pipe].enabled && data->display.pipes[pipe + 1].enabled) {
+ data->master_pipes |= BIT(pipe);
+ igt_info("Found master pipe %s\n", kmstest_pipe_name(pipe));
+ }
+ }
+}
- mode = igt_output_get_mode(output);
- igt_info("pipe:%s, output:%s, mode:", kmstest_pipe_name(p), igt_output_name(output));
- kmstest_dump_mode(mode);
+static enum pipe get_next_master_pipe(data_t *data, uint32_t available_pipe_mask)
+{
+ if ((data->master_pipes & available_pipe_mask) == 0)
+ return PIPE_NONE;
- pipe = &display->pipes[p];
- plane = igt_pipe_get_plane_type(pipe, DRM_PLANE_TYPE_PRIMARY);
+ return ffs(data->master_pipes & available_pipe_mask) - 1;
+}
- igt_plane_set_fb(plane, &data->fb);
- igt_fb_set_size(&data->fb, plane, mode->hdisplay, mode->vdisplay);
- igt_plane_set_size(plane, mode->hdisplay, mode->vdisplay);
- }
+static enum pipe setup_pipe(data_t *data, igt_output_t *output, enum pipe pipe, unsigned int available_pipe_mask)
+{
+ enum pipe master_pipe;
+ uint32_t attempt_mask;
- igt_assert(!igt_check_bigjoiner_support(display));
+ attempt_mask = BIT(pipe);
+ master_pipe = get_next_master_pipe(data, available_pipe_mask & attempt_mask);
- /* This commit is expectd to fail as this pipe is being used for big joiner */
- ret = igt_display_try_commit_atomic(display, DRM_MODE_ATOMIC_TEST_ONLY |
- DRM_MODE_ATOMIC_ALLOW_MODESET, NULL);
+ if (master_pipe == PIPE_NONE)
+ return PIPE_NONE;
- igt_display_reset(&data->display);
- igt_display_commit2(display, COMMIT_ATOMIC);
+ igt_info("Using pipe %s as master and %s slave for %s\n", kmstest_pipe_name(pipe),
+ kmstest_pipe_name(pipe + 1), output->name);
+ igt_output_set_pipe(output, pipe);
- igt_assert_lt(ret, 0);
+ return master_pipe;
}
-static void test_basic_modeset(data_t *data)
+static void test_single_joiner(data_t *data, int output_count)
{
+ int i;
+ enum pipe pipe, master_pipe;
+ uint32_t available_pipe_mask = BIT(data->n_pipes) - 1;
+ igt_output_t *output;
+ igt_plane_t *primary;
+ igt_output_t **outputs;
+ igt_fb_t fb;
drmModeModeInfo *mode;
- igt_output_t *output, *bigjoiner_output = NULL;
- igt_display_t *display = &data->display;
- igt_pipe_t *pipe;
- igt_plane_t *plane;
- igt_display_reset(display);
+ outputs = data->big_joiner_output;
- for_each_connected_output(display, output) {
- if (data->output[0].output_id == output->id) {
- bigjoiner_output = output;
- break;
+ for (i = 0; i < output_count; i++) {
+ output = outputs[i];
+ for (pipe = 0; pipe < data->n_pipes - 1; pipe++) {
+ igt_display_reset(&data->display);
+ master_pipe = setup_pipe(data, output, pipe, available_pipe_mask);
+ if (master_pipe == PIPE_NONE)
+ continue;
+ mode = igt_output_get_mode(output);
+ primary = igt_output_get_plane_type(output, DRM_PLANE_TYPE_PRIMARY);
+ igt_create_pattern_fb(data->drm_fd, mode->hdisplay, mode->vdisplay, DRM_FORMAT_XRGB8888,
+ DRM_FORMAT_MOD_LINEAR, &fb);
+ igt_plane_set_fb(primary, &fb);
+ igt_display_commit2(&data->display, COMMIT_ATOMIC);
+ igt_plane_set_fb(primary, NULL);
+ igt_remove_fb(data->drm_fd, &fb);
}
}
-
- igt_output_set_pipe(bigjoiner_output, data->pipe1);
-
- mode = &data->output[0].mode;
- igt_output_override_mode(bigjoiner_output, mode);
-
- pipe = &display->pipes[data->pipe1];
- plane = igt_pipe_get_plane_type(pipe, DRM_PLANE_TYPE_PRIMARY);
-
- igt_plane_set_fb(plane, &data->fb);
- igt_fb_set_size(&data->fb, plane, mode->hdisplay, mode->vdisplay);
- igt_plane_set_size(plane, mode->hdisplay, mode->vdisplay);
-
- igt_display_commit2(display, COMMIT_ATOMIC);
-
- igt_output_set_pipe(bigjoiner_output, PIPE_NONE);
- igt_plane_set_fb(plane, NULL);
- igt_display_commit2(display, COMMIT_ATOMIC);
}
-static void test_dual_display(data_t *data)
+static void test_multi_joiner(data_t *data, int output_count)
{
+ int i;
+ uint32_t available_pipe_mask;
+ enum pipe pipe, master_pipe;
+ igt_output_t **outputs;
+ igt_output_t *output;
+ igt_plane_t *primary[output_count];
+ igt_fb_t fb[output_count];
drmModeModeInfo *mode;
- igt_output_t *output, *bigjoiner_output[2];
- igt_display_t *display = &data->display;
- igt_pipe_t *pipe;
- igt_plane_t *plane1, *plane2;
- int count = 0;
-
- igt_display_reset(display);
-
- for_each_connected_output(display, output) {
- if (data->output[count].output_id == output->id) {
- bigjoiner_output[count] = output;
- count++;
- }
- if (count > 1)
+ available_pipe_mask = BIT(data->n_pipes) - 1;
+ outputs = data->big_joiner_output;
+
+ igt_display_reset(&data->display);
+ for (i = 0; i < output_count; i++) {
+ output = outputs[i];
+ for (pipe = 0; pipe < data->n_pipes; pipe++) {
+ master_pipe = setup_pipe(data, output, pipe, available_pipe_mask);
+ if (master_pipe == PIPE_NONE)
+ continue;
+ mode = igt_output_get_mode(output);
+ primary[i] = igt_output_get_plane_type(output, DRM_PLANE_TYPE_PRIMARY);
+ igt_create_pattern_fb(data->drm_fd, mode->hdisplay, mode->vdisplay, DRM_FORMAT_XRGB8888,
+ DRM_FORMAT_MOD_LINEAR, &fb[i]);
+ igt_plane_set_fb(primary[i], &fb[i]);
+
+ available_pipe_mask &= ~BIT(master_pipe);
+ available_pipe_mask &= ~BIT(master_pipe + 1);
break;
+ }
}
+ igt_display_commit2(&data->display, COMMIT_ATOMIC);
+ for (i = 0; i < output_count; i++) {
+ igt_plane_set_fb(primary[i], NULL);
+ igt_remove_fb(data->drm_fd, &fb[i]);
+ }
+}
- igt_output_set_pipe(bigjoiner_output[0], data->pipe1);
- igt_output_set_pipe(bigjoiner_output[1], data->pipe2);
-
- /* Set up first big joiner output on Pipe A*/
- mode = &data->output[0].mode;
- igt_output_override_mode(bigjoiner_output[0], mode);
+static void test_invalid_modeset_two_joiner(data_t *data,
+ bool mixed)
+{
+ int i, j, ret;
+ uint32_t available_pipe_mask;
+ uint32_t attempt_mask;
+ enum pipe master_pipe;
+ igt_output_t **outputs;
+ igt_output_t *output;
+ igt_plane_t *primary[INVALID_TEST_OUTPUT];
+ igt_fb_t fb[INVALID_TEST_OUTPUT];
+ drmModeModeInfo *mode;
- pipe = &display->pipes[data->pipe1];
- plane1 = igt_pipe_get_plane_type(pipe, DRM_PLANE_TYPE_PRIMARY);
+ available_pipe_mask = BIT(data->n_pipes) - 1;
+ outputs = mixed ? data->mixed_output : data->big_joiner_output;
- igt_plane_set_fb(plane1, &data->fb);
- igt_fb_set_size(&data->fb, plane1, mode->hdisplay, mode->vdisplay);
- igt_plane_set_size(plane1, mode->hdisplay, mode->vdisplay);
+ for (i = 0; i < data->n_pipes - 1; i++) {
+ igt_display_reset(&data->display);
+ attempt_mask = BIT(data->pipe_seq[i]);
+ master_pipe = get_next_master_pipe(data, available_pipe_mask & attempt_mask);
- /* Set up second big joiner output on Pipe C*/
- mode = &data->output[1].mode;
- igt_output_override_mode(bigjoiner_output[1], mode);
+ if (master_pipe == PIPE_NONE)
+ continue;
- pipe = &display->pipes[data->pipe2];
- plane2 = igt_pipe_get_plane_type(pipe, DRM_PLANE_TYPE_PRIMARY);
+ for (j = 0; j < INVALID_TEST_OUTPUT; j++) {
+ output = outputs[j];
+ igt_output_set_pipe(output, data->pipe_seq[i + j]);
+ mode = igt_output_get_mode(output);
+ igt_info("Assigning pipe %s to %s with mode %dx%d@%d%s",
+ kmstest_pipe_name(data->pipe_seq[i + j]),
+ igt_output_name(output), mode->hdisplay,
+ mode->vdisplay, mode->vrefresh,
+ j == INVALID_TEST_OUTPUT - 1 ? "\n" : ", ");
+ primary[j] = igt_output_get_plane_type(output, DRM_PLANE_TYPE_PRIMARY);
+ igt_create_pattern_fb(data->drm_fd, mode->hdisplay, mode->vdisplay, DRM_FORMAT_XRGB8888,
+ DRM_FORMAT_MOD_LINEAR, &fb[j]);
+ igt_plane_set_fb(primary[j], &fb[j]);
+ }
+ ret = igt_display_try_commit2(&data->display, COMMIT_ATOMIC);
+ for (j = 0; j < INVALID_TEST_OUTPUT; j++) {
+ igt_plane_set_fb(primary[j], NULL);
+ igt_remove_fb(data->drm_fd, &fb[j]);
+ }
+ igt_assert_f(ret != 0, "Commit shouldn't have passed\n");
+ }
+}
- igt_plane_set_fb(plane2, &data->fb);
- igt_fb_set_size(&data->fb, plane2, mode->hdisplay, mode->vdisplay);
- igt_plane_set_size(plane2, mode->hdisplay, mode->vdisplay);
+static void test_big_joiner_on_last_pipe(data_t *data)
+{
+ int i, len, ret;
+ igt_output_t **outputs;
+ igt_output_t *output;
+ igt_plane_t *primary;
+ igt_fb_t fb;
+ drmModeModeInfo *mode;
- igt_display_commit2(display, COMMIT_ATOMIC);
+ len = data->big_joiner_output_count;
+ outputs = data->big_joiner_output;
- /* Clean up */
- igt_output_set_pipe(bigjoiner_output[0], PIPE_NONE);
- igt_output_set_pipe(bigjoiner_output[1], PIPE_NONE);
- igt_plane_set_fb(plane1, NULL);
- igt_plane_set_fb(plane2, NULL);
- igt_display_commit2(display, COMMIT_ATOMIC);
+ for (i = 0; i < len; i++) {
+ igt_display_reset(&data->display);
+ output = outputs[i];
+ igt_output_set_pipe(output, data->pipe_seq[data->n_pipes - 1]);
+ mode = igt_output_get_mode(output);
+ igt_info(" Assigning pipe %s to %s with mode %dx%d@%d\n",
+ kmstest_pipe_name(data->pipe_seq[data->n_pipes - 1]),
+ igt_output_name(output), mode->hdisplay,
+ mode->vdisplay, mode->vrefresh);
+ primary = igt_output_get_plane_type(output, DRM_PLANE_TYPE_PRIMARY);
+ igt_create_pattern_fb(data->drm_fd, mode->hdisplay, mode->vdisplay, DRM_FORMAT_XRGB8888,
+ DRM_FORMAT_MOD_LINEAR, &fb);
+ igt_plane_set_fb(primary, &fb);
+ ret = igt_display_try_commit2(&data->display, COMMIT_ATOMIC);
+ igt_plane_set_fb(primary, NULL);
+ igt_remove_fb(data->drm_fd, &fb);
+ igt_assert_f(ret != 0, "Commit shouldn't have passed\n");
+ }
}
igt_main
{
- data_t data;
+ int i, j;
igt_output_t *output;
drmModeModeInfo mode;
- int valid_output = 0, i, count = 0, j = 0;
- uint16_t width = 0, height = 0;
- enum pipe pipe_seq[IGT_MAX_PIPES];
+ data_t data;
igt_fixture {
+ data.big_joiner_output_count = 0;
+ data.non_big_joiner_output_count = 0;
+ data.mixed_output_count = 0;
+ data.output_count = 0;
+ j = 0;
+
data.drm_fd = drm_open_driver_master(DRIVER_INTEL | DRIVER_XE);
kmstest_set_vt_graphics_mode();
-
igt_display_require(&data.display, data.drm_fd);
+ set_all_master_pipes_for_platform(&data);
igt_require(data.display.is_atomic);
-
max_dotclock = igt_get_max_dotclock(data.drm_fd);
for_each_connected_output(&data.display, output) {
@@ -228,105 +287,58 @@ igt_main
found = bigjoiner_mode_found(data.drm_fd, connector, max_dotclock, &mode);
if (found) {
- data.output[count].output_id = output->id;
- memcpy(&data.output[count].mode, &mode, sizeof(drmModeModeInfo));
- count++;
-
- width = max(width, mode.hdisplay);
- height = max(height, mode.vdisplay);
+ data.big_joiner_output[data.big_joiner_output_count++] = output;
+ igt_output_override_mode(output, &mode);
+ } else {
+ data.non_big_joiner_output[data.non_big_joiner_output_count++] = output;
}
- valid_output++;
+ data.output_count++;
+ }
+ if (data.big_joiner_output_count == 1 && data.non_big_joiner_output_count >= 1) {
+ /*
+ * Mixed output consists of 1 bigjoiner output and 1 non bigjoiner output
+ */
+ data.mixed_output[data.mixed_output_count++] = data.big_joiner_output[0];
+ data.mixed_output[data.mixed_output_count++] = data.non_big_joiner_output[0];
}
-
data.n_pipes = 0;
for_each_pipe(&data.display, i) {
data.n_pipes++;
- pipe_seq[j] = i;
+ data.pipe_seq[j] = i;
j++;
}
-
- igt_require_f(count > 0, "No output with 5k+ mode (or) clock > max-dot-clock found\n");
-
- igt_create_pattern_fb(data.drm_fd, width, height, DRM_FORMAT_XRGB8888,
- DRM_FORMAT_MOD_LINEAR, &data.fb);
}
igt_describe("Verify the basic modeset on big joiner mode on all pipes");
igt_subtest_with_dynamic("basic") {
- for (i = 0; i < data.n_pipes - 1; i++) {
- data.pipe1 = pipe_seq[i];
- igt_dynamic_f("pipe-%s", kmstest_pipe_name(pipe_seq[i]))
- test_basic_modeset(&data);
- }
+ igt_require_f(data.big_joiner_output_count > 0,
+ "No bigjoiner output found\n");
+ igt_require_f(data.n_pipes > 1,
+ "Minimum 2 pipes required\n");
+ igt_dynamic_f("single-joiner")
+ test_single_joiner(&data, data.big_joiner_output_count);
+ if (data.big_joiner_output_count > 1)
+ igt_dynamic_f("multi-joiner")
+ test_multi_joiner(&data, data.big_joiner_output_count);
}
igt_describe("Verify if the modeset on the adjoining pipe is rejected "
"when the pipe is active with a big joiner modeset");
igt_subtest_with_dynamic("invalid-modeset") {
- data.pipe1 = pipe_seq[j - 1];
-
- igt_display_reset(&data.display);
- for_each_connected_output(&data.display, output) {
- if (data.output[0].output_id != output->id)
- continue;
-
- mode = data.output[0].mode;
- igt_output_set_pipe(output, data.pipe1);
- igt_output_override_mode(output, &mode);
-
- igt_dynamic_f("pipe-%s-%s",
- kmstest_pipe_name(data.pipe1),
- igt_output_name(output))
- test_invalid_modeset(&data);
- }
-
- if(valid_output > 1) {
- for (i = 0; i < data.n_pipes - 1; i++) {
- igt_output_t *first_output = NULL, *second_output = NULL;
-
- data.pipe1 = pipe_seq[i];
- data.pipe2 = pipe_seq[i + 1];
-
- igt_display_reset(&data.display);
- for_each_connected_output(&data.display, output) {
- if (data.output[0].output_id == output->id) {
- first_output = output;
- mode = data.output[0].mode;
-
- igt_output_set_pipe(output, data.pipe1);
- igt_output_override_mode(output, &mode);
- } else if (second_output == NULL) {
- second_output = output;
- igt_output_set_pipe(output, data.pipe2);
-
- break;
- }
- }
-
- igt_dynamic_f("pipe-%s-%s-pipe-%s-%s",
- kmstest_pipe_name(data.pipe1),
- igt_output_name(first_output),
- kmstest_pipe_name(data.pipe2),
- igt_output_name(second_output))
- test_invalid_modeset(&data);
- }
- }
- }
-
- igt_describe("Verify simultaneous modeset on 2 big joiner outputs");
- igt_subtest_with_dynamic("2x-modeset") {
- igt_require_f(count > 1, "2 outputs with big joiner modes are required\n");
- igt_require_f(data.n_pipes > 3, "Minumum of 4 pipes are required\n");
- for (i = 0; (i + 2) < data.n_pipes - 1; i++) {
- data.pipe1 = pipe_seq[i];
- data.pipe2 = pipe_seq[i + 2];
- igt_dynamic_f("pipe-%s-%s", kmstest_pipe_name(pipe_seq[i]), kmstest_pipe_name(pipe_seq[i + 2]))
- test_dual_display(&data);
- }
+ igt_require_f(data.big_joiner_output_count > 0, "Non big joiner output not found\n");
+ igt_require_f(data.n_pipes > 1, "Minimum of 2 pipes are required\n");
+ if (data.big_joiner_output_count >= 1)
+ igt_dynamic_f("big_joiner_on_last_pipe")
+ test_big_joiner_on_last_pipe(&data);
+ if (data.big_joiner_output_count > 1)
+ igt_dynamic_f("invalid_combinations")
+ test_invalid_modeset_two_joiner(&data, false);
+ if (data.mixed_output_count)
+ igt_dynamic_f("mixed_output")
+ test_invalid_modeset_two_joiner(&data, true);
}
igt_fixture {
- igt_remove_fb(data.drm_fd, &data.fb);
igt_display_fini(&data.display);
drm_close_driver(data.drm_fd);
}
--
2.25.1
^ permalink raw reply related [flat|nested] 18+ messages in thread
* Re: [PATCH i-g-t 2/4] tests/intel/kms_big_joiner: revamp bigjoiner
2024-03-21 18:28 ` [PATCH i-g-t 2/4] tests/intel/kms_big_joiner: revamp bigjoiner Kunal Joshi
@ 2024-03-25 10:16 ` Nautiyal, Ankit K
0 siblings, 0 replies; 18+ messages in thread
From: Nautiyal, Ankit K @ 2024-03-25 10:16 UTC (permalink / raw)
To: Kunal Joshi, igt-dev; +Cc: Stanislav Lisovskiy, Karthik B S, Bhanuprakash Modem
On 3/21/2024 11:58 PM, Kunal Joshi wrote:
> v2: Don't change license (Bhanu)
> Print the pipe name (Bhanu)
> Remove unwanted commit (Bhanu)
> Move combine output logic to igt_fixture (Bhanu)
> split revamp and force joiner (Bhanu)
>
> v3: Ignored fused pipes (Stan)
>
> v4: Ignore master pipes who doesn't have slave (Ankit)
> Retain subtest names (Ankit)
> Use commit instead of try_commit (Ankit)
> Fix typo (Ankit)
>
> Cc: Stanislav Lisovskiy <stanislav.lisovskiy@intel.com>
> Cc: Ankit Nautiyal <ankit.k.nautiyal@intel.com>
> Cc: Karthik B S <karthik.b.s@intel.com>
> Cc: Bhanuprakash Modem <bhanuprakash.modem@intel.com>
> Signed-off-by: Kunal Joshi <kunal1.joshi@intel.com>
> Signed-off-by: Stanislav Lisovskiy <stanislav.lisovskiy@intel.com>
> ---
> tests/intel/kms_big_joiner.c | 416 ++++++++++++++++++-----------------
> 1 file changed, 220 insertions(+), 196 deletions(-)
>
> diff --git a/tests/intel/kms_big_joiner.c b/tests/intel/kms_big_joiner.c
> index 99b1b898d..eba74cddf 100644
> --- a/tests/intel/kms_big_joiner.c
> +++ b/tests/intel/kms_big_joiner.c
> @@ -44,177 +44,253 @@
> * SUBTEST: basic
> * Description: Verify the basic modeset on big joiner mode on all pipes
> *
> - * SUBTEST: 2x-modeset
> - * Description: Verify simultaneous modeset on 2 big joiner outputs
> */
>
> IGT_TEST_DESCRIPTION("Test big joiner");
>
> -struct bigjoiner_output {
> - uint32_t output_id;
> - drmModeModeInfo mode;
> -};
> +#define INVALID_TEST_OUTPUT 2
>
> typedef struct {
> int drm_fd;
> - igt_display_t display;
> - struct igt_fb fb;
> + int big_joiner_output_count;
> + int non_big_joiner_output_count;
> + int combined_output_count;
> + int output_count;
> int n_pipes;
> - enum pipe pipe1;
> - enum pipe pipe2;
> - struct bigjoiner_output output[2];
> + int master_pipes;
> + uint64_t big_joiner_output[IGT_MAX_PIPES];
These can be uint32_t to match drmModeConnector connector_id
> + uint64_t non_big_joiner_output[IGT_MAX_PIPES];
> + uint64_t combined_output[IGT_MAX_PIPES];
> + enum pipe pipe_seq[IGT_MAX_PIPES];
> + igt_display_t display;
> } data_t;
>
> static int max_dotclock;
>
> -static void test_invalid_modeset(data_t *data)
> +static void set_all_master_pipes_for_platform(data_t *data)
> {
> - igt_output_t *output;
> - igt_display_t *display = &data->display;
> - int ret;
> + enum pipe pipe;
> + enum pipe last_pipe;
> +
> + for (pipe = PIPE_A; pipe < IGT_MAX_PIPES; pipe++) {
We should have pipe < IGT_MAX_PIPES -1 as we are checking pipe+1 in the
loop.
> + if (data->display.pipes[pipe].enabled) {
> + if (data->display.pipes[pipe+1].enabled) {
these can be one if condition instead of nested if:
if (data->display.pipes[pipe].enabled &&
data->display.pipes[pipe+1].enabled)
> + data->master_pipes |= BIT(pipe);
> + igt_info("Found master pipe %s\n", kmstest_pipe_name(pipe));
> + }
> + last_pipe = pipe;
I dont think we need this last_pipe.
> + }
> + }
> + data->master_pipes |= BIT(last_pipe);
> +}
>
> - igt_info("Bigjoiner test on ");
> - for_each_connected_output(display, output){
> - enum pipe p = output->pending_pipe;
> - drmModeModeInfo *mode;
> - igt_pipe_t *pipe;
> - igt_plane_t *plane;
> +static igt_output_t *get_output_by_id_or_assert(data_t *data, uint64_t id)
> +{
> + igt_output_t *output;
>
> - if (p == PIPE_NONE)
> - continue;
> + for_each_connected_output(&data->display, output) {
> + if (output->id == id)
> + return output;
I am wondering if we just store the igt_outputs instead of storing id
and then looping to match the id with connected outputs.
> + }
> + igt_assert_f(false, "Output not found\n");
> + return NULL;
> +}
>
> - mode = igt_output_get_mode(output);
> - igt_info("pipe:%s, output:%s, mode:", kmstest_pipe_name(p), igt_output_name(output));
> - kmstest_dump_mode(mode);
> +static enum pipe get_next_master_pipe(data_t *data, unsigned int available_pipe_mask)
> +{
> + if ((data->master_pipes & available_pipe_mask) == 0)
> + return PIPE_NONE;
>
> - pipe = &display->pipes[p];
> - plane = igt_pipe_get_plane_type(pipe, DRM_PLANE_TYPE_PRIMARY);
> + return ffs(data->master_pipes & available_pipe_mask) - 1;
> +}
>
> - igt_plane_set_fb(plane, &data->fb);
> - igt_fb_set_size(&data->fb, plane, mode->hdisplay, mode->vdisplay);
> - igt_plane_set_size(plane, mode->hdisplay, mode->vdisplay);
> - }
> +static enum pipe setup_pipe(data_t *data, igt_output_t *output, enum pipe pipe, unsigned int available_pipe_mask)
> +{
> + enum pipe master_pipe;
> + unsigned int attempt_mask;
>
> - igt_assert(!igt_check_bigjoiner_support(display));
> + attempt_mask = BIT(pipe);
> + master_pipe = get_next_master_pipe(data, available_pipe_mask & attempt_mask);
>
> - /* This commit is expectd to fail as this pipe is being used for big joiner */
> - ret = igt_display_try_commit_atomic(display, DRM_MODE_ATOMIC_TEST_ONLY |
> - DRM_MODE_ATOMIC_ALLOW_MODESET, NULL);
> + if (master_pipe == PIPE_NONE)
> + return PIPE_NONE;
>
> - igt_display_reset(&data->display);
> - igt_display_commit2(display, COMMIT_ATOMIC);
> + igt_info("Using pipe %s as master and %s slave for %s\n", kmstest_pipe_name(pipe),
> + kmstest_pipe_name(pipe + 1), output->name);
> + igt_output_set_pipe(output, pipe);
>
> - igt_assert_lt(ret, 0);
> + return master_pipe;
> }
>
> -static void test_basic_modeset(data_t *data)
> +static void test_single_joiner(data_t *data, int output_count)
> {
> + int i;
> + enum pipe pipe, master_pipe;
> + unsigned int available_pipe_mask = BIT(data->n_pipes) - 1;
> + igt_output_t *output;
> + igt_plane_t *primary;
> + uint64_t *outputs;
> + igt_fb_t fb;
> drmModeModeInfo *mode;
> - igt_output_t *output, *bigjoiner_output = NULL;
> - igt_display_t *display = &data->display;
> - igt_pipe_t *pipe;
> - igt_plane_t *plane;
>
> - igt_display_reset(display);
> + outputs = data->big_joiner_output;
>
> - for_each_connected_output(display, output) {
> - if (data->output[0].output_id == output->id) {
> - bigjoiner_output = output;
> - break;
> + for (i = 0; i < output_count; i++) {
> + output = get_output_by_id_or_assert(data, outputs[i]);
> + for (pipe = 0; pipe < data->n_pipes-1; pipe++) {
> + igt_display_reset(&data->display);
> + master_pipe = setup_pipe(data, output, pipe, available_pipe_mask);
> + if (master_pipe == PIPE_NONE)
> + continue;
> + mode = igt_output_get_mode(output);
> + primary = igt_output_get_plane_type(output, DRM_PLANE_TYPE_PRIMARY);
> + igt_create_pattern_fb(data->drm_fd, mode->hdisplay, mode->vdisplay, DRM_FORMAT_XRGB8888,
> + DRM_FORMAT_MOD_LINEAR, &fb);
> + igt_plane_set_fb(primary, &fb);
> + igt_display_commit2(&data->display, COMMIT_ATOMIC);
> + igt_plane_set_fb(primary, NULL);
> + igt_remove_fb(data->drm_fd, &fb);
> }
> }
> -
> - igt_output_set_pipe(bigjoiner_output, data->pipe1);
> -
> - mode = &data->output[0].mode;
> - igt_output_override_mode(bigjoiner_output, mode);
> -
> - pipe = &display->pipes[data->pipe1];
> - plane = igt_pipe_get_plane_type(pipe, DRM_PLANE_TYPE_PRIMARY);
> -
> - igt_plane_set_fb(plane, &data->fb);
> - igt_fb_set_size(&data->fb, plane, mode->hdisplay, mode->vdisplay);
> - igt_plane_set_size(plane, mode->hdisplay, mode->vdisplay);
> -
> - igt_display_commit2(display, COMMIT_ATOMIC);
> -
> - igt_output_set_pipe(bigjoiner_output, PIPE_NONE);
> - igt_plane_set_fb(plane, NULL);
> - igt_display_commit2(display, COMMIT_ATOMIC);
> }
>
> -static void test_dual_display(data_t *data)
> +static void test_multi_joiner(data_t *data, int output_count)
> {
> + int i;
> + unsigned int available_pipe_mask;
> + enum pipe pipe, master_pipe;
> + uint64_t *outputs;
> + igt_output_t *output;
> + igt_plane_t *primary[output_count];
> + igt_fb_t fb[output_count];
> drmModeModeInfo *mode;
> - igt_output_t *output, *bigjoiner_output[2];
> - igt_display_t *display = &data->display;
> - igt_pipe_t *pipe;
> - igt_plane_t *plane1, *plane2;
> - int count = 0;
> -
> - igt_display_reset(display);
> -
> - for_each_connected_output(display, output) {
> - if (data->output[count].output_id == output->id) {
> - bigjoiner_output[count] = output;
> - count++;
> - }
>
> - if (count > 1)
> + available_pipe_mask = BIT(data->n_pipes) - 1;
> + outputs = data->big_joiner_output;
> +
> + igt_display_reset(&data->display);
> + for (i = 0; i < output_count; i++) {
> + output = get_output_by_id_or_assert(data, outputs[i]);
> + for (pipe = 0; pipe < data->n_pipes; pipe++) {
> + master_pipe = setup_pipe(data, output, pipe, available_pipe_mask);
> + if (master_pipe == PIPE_NONE)
> + continue;
> + mode = igt_output_get_mode(output);
> + primary[i] = igt_output_get_plane_type(output, DRM_PLANE_TYPE_PRIMARY);
> + igt_create_pattern_fb(data->drm_fd, mode->hdisplay, mode->vdisplay, DRM_FORMAT_XRGB8888,
> + DRM_FORMAT_MOD_LINEAR, &fb[i]);
> + igt_plane_set_fb(primary[i], &fb[i]);
> +
> + available_pipe_mask &= ~BIT(master_pipe);
> + available_pipe_mask &= ~BIT(master_pipe + 1);
> break;
> + }
> }
> + igt_display_commit2(&data->display, COMMIT_ATOMIC);
> + for (i = 0; i < output_count; i++) {
> + igt_plane_set_fb(primary[i], NULL);
> + igt_remove_fb(data->drm_fd, &fb[i]);
> + }
> +}
>
> - igt_output_set_pipe(bigjoiner_output[0], data->pipe1);
> - igt_output_set_pipe(bigjoiner_output[1], data->pipe2);
> -
> - /* Set up first big joiner output on Pipe A*/
> - mode = &data->output[0].mode;
> - igt_output_override_mode(bigjoiner_output[0], mode);
> +static void test_invalid_modeset_two_joiner(data_t *data,
> + bool combined)
> +{
> + int i, j, ret;
> + unsigned int available_pipe_mask;
> + unsigned int attempt_mask;
> + enum pipe master_pipe;
> + uint64_t *outputs;
> + igt_output_t *output;
> + igt_plane_t *primary[INVALID_TEST_OUTPUT];
> + igt_fb_t fb[INVALID_TEST_OUTPUT];
> + drmModeModeInfo *mode;
>
> - pipe = &display->pipes[data->pipe1];
> - plane1 = igt_pipe_get_plane_type(pipe, DRM_PLANE_TYPE_PRIMARY);
> + available_pipe_mask = BIT(data->n_pipes) - 1;
> + outputs = combined ? data->combined_output : data->big_joiner_output;
>
> - igt_plane_set_fb(plane1, &data->fb);
> - igt_fb_set_size(&data->fb, plane1, mode->hdisplay, mode->vdisplay);
> - igt_plane_set_size(plane1, mode->hdisplay, mode->vdisplay);
> + for (i = 0; i < data->n_pipes-1; i++) {
> + igt_display_reset(&data->display);
> + attempt_mask = BIT(data->pipe_seq[i]);
> + master_pipe = get_next_master_pipe(data, available_pipe_mask & attempt_mask);
>
> - /* Set up second big joiner output on Pipe C*/
> - mode = &data->output[1].mode;
> - igt_output_override_mode(bigjoiner_output[1], mode);
> + if (master_pipe == PIPE_NONE)
> + continue;
>
> - pipe = &display->pipes[data->pipe2];
> - plane2 = igt_pipe_get_plane_type(pipe, DRM_PLANE_TYPE_PRIMARY);
> + for (j = 0; j < INVALID_TEST_OUTPUT; j++) {
> + output = get_output_by_id_or_assert(data, outputs[j]);
> + igt_output_set_pipe(output, data->pipe_seq[i + j]);
> + mode = igt_output_get_mode(output);
> + igt_info(" Assigning pipe %s to %s with mode %dx%d@%d%s",
> + kmstest_pipe_name(data->pipe_seq[i + j]),
> + igt_output_name(output), mode->hdisplay,
> + mode->vdisplay, mode->vrefresh,
> + j == INVALID_TEST_OUTPUT - 1 ? "\n" : ", ");
> + primary[j] = igt_output_get_plane_type(output, DRM_PLANE_TYPE_PRIMARY);
> + igt_create_pattern_fb(data->drm_fd, mode->hdisplay, mode->vdisplay, DRM_FORMAT_XRGB8888,
> + DRM_FORMAT_MOD_LINEAR, &fb[j]);
> + igt_plane_set_fb(primary[j], &fb[j]);
> + }
> + ret = igt_display_try_commit2(&data->display, COMMIT_ATOMIC);
> + for (j = 0; j < INVALID_TEST_OUTPUT; j++) {
> + igt_plane_set_fb(primary[j], NULL);
> + igt_remove_fb(data->drm_fd, &fb[j]);
> + }
> + igt_assert_f(ret != 0, "Commit shouldn't have passed\n");
> + }
> +}
>
> - igt_plane_set_fb(plane2, &data->fb);
> - igt_fb_set_size(&data->fb, plane2, mode->hdisplay, mode->vdisplay);
> - igt_plane_set_size(plane2, mode->hdisplay, mode->vdisplay);
> +static void test_big_joiner_on_last_pipe(data_t *data)
> +{
> + int i, len, ret;
> + uint64_t *outputs;
> + igt_output_t *output;
> + igt_plane_t *primary;
> + igt_fb_t fb;
> + drmModeModeInfo *mode;
>
> - igt_display_commit2(display, COMMIT_ATOMIC);
> + len = data->big_joiner_output_count;
> + outputs = data->big_joiner_output;
>
> - /* Clean up */
> - igt_output_set_pipe(bigjoiner_output[0], PIPE_NONE);
> - igt_output_set_pipe(bigjoiner_output[1], PIPE_NONE);
> - igt_plane_set_fb(plane1, NULL);
> - igt_plane_set_fb(plane2, NULL);
> - igt_display_commit2(display, COMMIT_ATOMIC);
> + for (i = 0; i < len; i++) {
> + igt_display_reset(&data->display);
> + output = get_output_by_id_or_assert(data, outputs[i]);
> + igt_output_set_pipe(output, data->pipe_seq[data->n_pipes - 1]);
> + mode = igt_output_get_mode(output);
> + igt_info(" Assigning pipe %s to %s with mode %dx%d@%d\n",
Extra space after before 'Assign'
> + kmstest_pipe_name(data->pipe_seq[data->n_pipes - 1]),
> + igt_output_name(output), mode->hdisplay,
> + mode->vdisplay, mode->vrefresh);
> + primary = igt_output_get_plane_type(output, DRM_PLANE_TYPE_PRIMARY);
> + igt_create_pattern_fb(data->drm_fd, mode->hdisplay, mode->vdisplay, DRM_FORMAT_XRGB8888,
> + DRM_FORMAT_MOD_LINEAR, &fb);
> + igt_plane_set_fb(primary, &fb);
> + ret = igt_display_try_commit2(&data->display, COMMIT_ATOMIC);
> + igt_plane_set_fb(primary, NULL);
> + igt_remove_fb(data->drm_fd, &fb);
> + igt_assert_f(ret != 0, "Commit shouldn't have passed\n");
> + }
> }
>
> igt_main
> {
> - data_t data;
> + int i, j;
> igt_output_t *output;
> drmModeModeInfo mode;
> - int valid_output = 0, i, count = 0, j = 0;
> - uint16_t width = 0, height = 0;
> - enum pipe pipe_seq[IGT_MAX_PIPES];
> + data_t data;
>
> igt_fixture {
> + data.big_joiner_output_count = 0;
> + data.non_big_joiner_output_count = 0;
> + data.combined_output_count = 0;
> + data.output_count = 0;
> + j = 0;
> +
> data.drm_fd = drm_open_driver_master(DRIVER_INTEL | DRIVER_XE);
> kmstest_set_vt_graphics_mode();
> -
> igt_display_require(&data.display, data.drm_fd);
> + set_all_master_pipes_for_platform(&data);
> igt_require(data.display.is_atomic);
> -
> max_dotclock = igt_get_max_dotclock(data.drm_fd);
>
> for_each_connected_output(&data.display, output) {
> @@ -228,105 +304,53 @@ igt_main
> found = bigjoiner_mode_found(data.drm_fd, connector, max_dotclock, &mode);
>
> if (found) {
> - data.output[count].output_id = output->id;
> - memcpy(&data.output[count].mode, &mode, sizeof(drmModeModeInfo));
> - count++;
> -
> - width = max(width, mode.hdisplay);
> - height = max(height, mode.vdisplay);
> + data.big_joiner_output[data.big_joiner_output_count++] = output->config.connector->connector_id;
> + igt_output_override_mode(output, &mode);
> + } else {
> + data.non_big_joiner_output[data.non_big_joiner_output_count++] = output->config.connector->connector_id;
> }
> - valid_output++;
> + data.output_count++;
> + }
> + if (data.big_joiner_output_count == 1 && data.non_big_joiner_output_count >= 1) {
> + data.combined_output[data.combined_output_count++] = data.big_joiner_output[0];
> + data.combined_output[data.combined_output_count++] = data.non_big_joiner_output[0];
> }
> -
> data.n_pipes = 0;
> for_each_pipe(&data.display, i) {
> data.n_pipes++;
> - pipe_seq[j] = i;
> + data.pipe_seq[j] = i;
> j++;
> }
> -
> - igt_require_f(count > 0, "No output with 5k+ mode (or) clock > max-dot-clock found\n");
> -
> - igt_create_pattern_fb(data.drm_fd, width, height, DRM_FORMAT_XRGB8888,
> - DRM_FORMAT_MOD_LINEAR, &data.fb);
> }
>
> igt_describe("Verify the basic modeset on big joiner mode on all pipes");
It would be good to describe about the two subtests.
> igt_subtest_with_dynamic("basic") {
> - for (i = 0; i < data.n_pipes - 1; i++) {
> - data.pipe1 = pipe_seq[i];
> - igt_dynamic_f("pipe-%s", kmstest_pipe_name(pipe_seq[i]))
> - test_basic_modeset(&data);
> - }
> + igt_require_f(data.big_joiner_output_count > 0,
> + "No bigjoiner output found\n");
> + igt_require_f(data.n_pipes > 1,
> + "Minimum 2 pipes required\n");
> + igt_dynamic_f("single-joiner")
> + test_single_joiner(&data, data.big_joiner_output_count);
> + if (data.big_joiner_output_count > 1)
> + igt_dynamic_f("multi-joiner")
> + test_multi_joiner(&data, data.big_joiner_output_count);
> }
>
> - igt_describe("Verify if the modeset on the adjoining pipe is rejected "
> - "when the pipe is active with a big joiner modeset");
I think we need this for invalid case, describing new subtests.
Regards,
Ankit
> igt_subtest_with_dynamic("invalid-modeset") {
> - data.pipe1 = pipe_seq[j - 1];
> -
> - igt_display_reset(&data.display);
> - for_each_connected_output(&data.display, output) {
> - if (data.output[0].output_id != output->id)
> - continue;
> -
> - mode = data.output[0].mode;
> - igt_output_set_pipe(output, data.pipe1);
> - igt_output_override_mode(output, &mode);
> -
> - igt_dynamic_f("pipe-%s-%s",
> - kmstest_pipe_name(data.pipe1),
> - igt_output_name(output))
> - test_invalid_modeset(&data);
> - }
> -
> - if(valid_output > 1) {
> - for (i = 0; i < data.n_pipes - 1; i++) {
> - igt_output_t *first_output = NULL, *second_output = NULL;
> -
> - data.pipe1 = pipe_seq[i];
> - data.pipe2 = pipe_seq[i + 1];
> -
> - igt_display_reset(&data.display);
> - for_each_connected_output(&data.display, output) {
> - if (data.output[0].output_id == output->id) {
> - first_output = output;
> - mode = data.output[0].mode;
> -
> - igt_output_set_pipe(output, data.pipe1);
> - igt_output_override_mode(output, &mode);
> - } else if (second_output == NULL) {
> - second_output = output;
> - igt_output_set_pipe(output, data.pipe2);
> -
> - break;
> - }
> - }
> -
> - igt_dynamic_f("pipe-%s-%s-pipe-%s-%s",
> - kmstest_pipe_name(data.pipe1),
> - igt_output_name(first_output),
> - kmstest_pipe_name(data.pipe2),
> - igt_output_name(second_output))
> - test_invalid_modeset(&data);
> - }
> - }
> - }
> -
> - igt_describe("Verify simultaneous modeset on 2 big joiner outputs");
> - igt_subtest_with_dynamic("2x-modeset") {
> - igt_require_f(count > 1, "2 outputs with big joiner modes are required\n");
> - igt_require_f(data.n_pipes > 3, "Minumum of 4 pipes are required\n");
> - for (i = 0; (i + 2) < data.n_pipes - 1; i++) {
> - data.pipe1 = pipe_seq[i];
> - data.pipe2 = pipe_seq[i + 2];
> - igt_dynamic_f("pipe-%s-%s", kmstest_pipe_name(pipe_seq[i]), kmstest_pipe_name(pipe_seq[i + 2]))
> - test_dual_display(&data);
> - }
> + igt_require_f(data.big_joiner_output_count > 0, "Non big joiner output not found\n");
> + igt_require_f(data.n_pipes > 1, "Minimum of 2 pipes are required\n");
> + if (data.big_joiner_output_count >= 1)
> + igt_dynamic_f("big_joiner_on_last_pipe")
> + test_big_joiner_on_last_pipe(&data);
> + if (data.big_joiner_output_count > 1)
> + igt_dynamic_f("invalid_combinations")
> + test_invalid_modeset_two_joiner(&data, false);
> + if (data.combined_output_count)
> + igt_dynamic_f("combined_output")
> + test_invalid_modeset_two_joiner(&data, true);
> }
>
> igt_fixture {
> - igt_remove_fb(data.drm_fd, &data.fb);
> igt_display_fini(&data.display);
> drm_close_driver(data.drm_fd);
> }
^ permalink raw reply [flat|nested] 18+ messages in thread
* [PATCH i-g-t 2/4] tests/intel/kms_big_joiner: revamp bigjoiner
2024-03-21 18:28 [PATCH i-g-t 0/4] revamp big joiner test Kunal Joshi
@ 2024-03-21 18:28 ` Kunal Joshi
2024-03-25 10:16 ` Nautiyal, Ankit K
0 siblings, 1 reply; 18+ messages in thread
From: Kunal Joshi @ 2024-03-21 18:28 UTC (permalink / raw)
To: igt-dev
Cc: Kunal Joshi, Stanislav Lisovskiy, Ankit Nautiyal, Karthik B S,
Bhanuprakash Modem
v2: Don't change license (Bhanu)
Print the pipe name (Bhanu)
Remove unwanted commit (Bhanu)
Move combine output logic to igt_fixture (Bhanu)
split revamp and force joiner (Bhanu)
v3: Ignored fused pipes (Stan)
v4: Ignore master pipes who doesn't have slave (Ankit)
Retain subtest names (Ankit)
Use commit instead of try_commit (Ankit)
Fix typo (Ankit)
Cc: Stanislav Lisovskiy <stanislav.lisovskiy@intel.com>
Cc: Ankit Nautiyal <ankit.k.nautiyal@intel.com>
Cc: Karthik B S <karthik.b.s@intel.com>
Cc: Bhanuprakash Modem <bhanuprakash.modem@intel.com>
Signed-off-by: Kunal Joshi <kunal1.joshi@intel.com>
Signed-off-by: Stanislav Lisovskiy <stanislav.lisovskiy@intel.com>
---
tests/intel/kms_big_joiner.c | 416 ++++++++++++++++++-----------------
1 file changed, 220 insertions(+), 196 deletions(-)
diff --git a/tests/intel/kms_big_joiner.c b/tests/intel/kms_big_joiner.c
index 99b1b898d..eba74cddf 100644
--- a/tests/intel/kms_big_joiner.c
+++ b/tests/intel/kms_big_joiner.c
@@ -44,177 +44,253 @@
* SUBTEST: basic
* Description: Verify the basic modeset on big joiner mode on all pipes
*
- * SUBTEST: 2x-modeset
- * Description: Verify simultaneous modeset on 2 big joiner outputs
*/
IGT_TEST_DESCRIPTION("Test big joiner");
-struct bigjoiner_output {
- uint32_t output_id;
- drmModeModeInfo mode;
-};
+#define INVALID_TEST_OUTPUT 2
typedef struct {
int drm_fd;
- igt_display_t display;
- struct igt_fb fb;
+ int big_joiner_output_count;
+ int non_big_joiner_output_count;
+ int combined_output_count;
+ int output_count;
int n_pipes;
- enum pipe pipe1;
- enum pipe pipe2;
- struct bigjoiner_output output[2];
+ int master_pipes;
+ uint64_t big_joiner_output[IGT_MAX_PIPES];
+ uint64_t non_big_joiner_output[IGT_MAX_PIPES];
+ uint64_t combined_output[IGT_MAX_PIPES];
+ enum pipe pipe_seq[IGT_MAX_PIPES];
+ igt_display_t display;
} data_t;
static int max_dotclock;
-static void test_invalid_modeset(data_t *data)
+static void set_all_master_pipes_for_platform(data_t *data)
{
- igt_output_t *output;
- igt_display_t *display = &data->display;
- int ret;
+ enum pipe pipe;
+ enum pipe last_pipe;
+
+ for (pipe = PIPE_A; pipe < IGT_MAX_PIPES; pipe++) {
+ if (data->display.pipes[pipe].enabled) {
+ if (data->display.pipes[pipe+1].enabled) {
+ data->master_pipes |= BIT(pipe);
+ igt_info("Found master pipe %s\n", kmstest_pipe_name(pipe));
+ }
+ last_pipe = pipe;
+ }
+ }
+ data->master_pipes |= BIT(last_pipe);
+}
- igt_info("Bigjoiner test on ");
- for_each_connected_output(display, output){
- enum pipe p = output->pending_pipe;
- drmModeModeInfo *mode;
- igt_pipe_t *pipe;
- igt_plane_t *plane;
+static igt_output_t *get_output_by_id_or_assert(data_t *data, uint64_t id)
+{
+ igt_output_t *output;
- if (p == PIPE_NONE)
- continue;
+ for_each_connected_output(&data->display, output) {
+ if (output->id == id)
+ return output;
+ }
+ igt_assert_f(false, "Output not found\n");
+ return NULL;
+}
- mode = igt_output_get_mode(output);
- igt_info("pipe:%s, output:%s, mode:", kmstest_pipe_name(p), igt_output_name(output));
- kmstest_dump_mode(mode);
+static enum pipe get_next_master_pipe(data_t *data, unsigned int available_pipe_mask)
+{
+ if ((data->master_pipes & available_pipe_mask) == 0)
+ return PIPE_NONE;
- pipe = &display->pipes[p];
- plane = igt_pipe_get_plane_type(pipe, DRM_PLANE_TYPE_PRIMARY);
+ return ffs(data->master_pipes & available_pipe_mask) - 1;
+}
- igt_plane_set_fb(plane, &data->fb);
- igt_fb_set_size(&data->fb, plane, mode->hdisplay, mode->vdisplay);
- igt_plane_set_size(plane, mode->hdisplay, mode->vdisplay);
- }
+static enum pipe setup_pipe(data_t *data, igt_output_t *output, enum pipe pipe, unsigned int available_pipe_mask)
+{
+ enum pipe master_pipe;
+ unsigned int attempt_mask;
- igt_assert(!igt_check_bigjoiner_support(display));
+ attempt_mask = BIT(pipe);
+ master_pipe = get_next_master_pipe(data, available_pipe_mask & attempt_mask);
- /* This commit is expectd to fail as this pipe is being used for big joiner */
- ret = igt_display_try_commit_atomic(display, DRM_MODE_ATOMIC_TEST_ONLY |
- DRM_MODE_ATOMIC_ALLOW_MODESET, NULL);
+ if (master_pipe == PIPE_NONE)
+ return PIPE_NONE;
- igt_display_reset(&data->display);
- igt_display_commit2(display, COMMIT_ATOMIC);
+ igt_info("Using pipe %s as master and %s slave for %s\n", kmstest_pipe_name(pipe),
+ kmstest_pipe_name(pipe + 1), output->name);
+ igt_output_set_pipe(output, pipe);
- igt_assert_lt(ret, 0);
+ return master_pipe;
}
-static void test_basic_modeset(data_t *data)
+static void test_single_joiner(data_t *data, int output_count)
{
+ int i;
+ enum pipe pipe, master_pipe;
+ unsigned int available_pipe_mask = BIT(data->n_pipes) - 1;
+ igt_output_t *output;
+ igt_plane_t *primary;
+ uint64_t *outputs;
+ igt_fb_t fb;
drmModeModeInfo *mode;
- igt_output_t *output, *bigjoiner_output = NULL;
- igt_display_t *display = &data->display;
- igt_pipe_t *pipe;
- igt_plane_t *plane;
- igt_display_reset(display);
+ outputs = data->big_joiner_output;
- for_each_connected_output(display, output) {
- if (data->output[0].output_id == output->id) {
- bigjoiner_output = output;
- break;
+ for (i = 0; i < output_count; i++) {
+ output = get_output_by_id_or_assert(data, outputs[i]);
+ for (pipe = 0; pipe < data->n_pipes-1; pipe++) {
+ igt_display_reset(&data->display);
+ master_pipe = setup_pipe(data, output, pipe, available_pipe_mask);
+ if (master_pipe == PIPE_NONE)
+ continue;
+ mode = igt_output_get_mode(output);
+ primary = igt_output_get_plane_type(output, DRM_PLANE_TYPE_PRIMARY);
+ igt_create_pattern_fb(data->drm_fd, mode->hdisplay, mode->vdisplay, DRM_FORMAT_XRGB8888,
+ DRM_FORMAT_MOD_LINEAR, &fb);
+ igt_plane_set_fb(primary, &fb);
+ igt_display_commit2(&data->display, COMMIT_ATOMIC);
+ igt_plane_set_fb(primary, NULL);
+ igt_remove_fb(data->drm_fd, &fb);
}
}
-
- igt_output_set_pipe(bigjoiner_output, data->pipe1);
-
- mode = &data->output[0].mode;
- igt_output_override_mode(bigjoiner_output, mode);
-
- pipe = &display->pipes[data->pipe1];
- plane = igt_pipe_get_plane_type(pipe, DRM_PLANE_TYPE_PRIMARY);
-
- igt_plane_set_fb(plane, &data->fb);
- igt_fb_set_size(&data->fb, plane, mode->hdisplay, mode->vdisplay);
- igt_plane_set_size(plane, mode->hdisplay, mode->vdisplay);
-
- igt_display_commit2(display, COMMIT_ATOMIC);
-
- igt_output_set_pipe(bigjoiner_output, PIPE_NONE);
- igt_plane_set_fb(plane, NULL);
- igt_display_commit2(display, COMMIT_ATOMIC);
}
-static void test_dual_display(data_t *data)
+static void test_multi_joiner(data_t *data, int output_count)
{
+ int i;
+ unsigned int available_pipe_mask;
+ enum pipe pipe, master_pipe;
+ uint64_t *outputs;
+ igt_output_t *output;
+ igt_plane_t *primary[output_count];
+ igt_fb_t fb[output_count];
drmModeModeInfo *mode;
- igt_output_t *output, *bigjoiner_output[2];
- igt_display_t *display = &data->display;
- igt_pipe_t *pipe;
- igt_plane_t *plane1, *plane2;
- int count = 0;
-
- igt_display_reset(display);
-
- for_each_connected_output(display, output) {
- if (data->output[count].output_id == output->id) {
- bigjoiner_output[count] = output;
- count++;
- }
- if (count > 1)
+ available_pipe_mask = BIT(data->n_pipes) - 1;
+ outputs = data->big_joiner_output;
+
+ igt_display_reset(&data->display);
+ for (i = 0; i < output_count; i++) {
+ output = get_output_by_id_or_assert(data, outputs[i]);
+ for (pipe = 0; pipe < data->n_pipes; pipe++) {
+ master_pipe = setup_pipe(data, output, pipe, available_pipe_mask);
+ if (master_pipe == PIPE_NONE)
+ continue;
+ mode = igt_output_get_mode(output);
+ primary[i] = igt_output_get_plane_type(output, DRM_PLANE_TYPE_PRIMARY);
+ igt_create_pattern_fb(data->drm_fd, mode->hdisplay, mode->vdisplay, DRM_FORMAT_XRGB8888,
+ DRM_FORMAT_MOD_LINEAR, &fb[i]);
+ igt_plane_set_fb(primary[i], &fb[i]);
+
+ available_pipe_mask &= ~BIT(master_pipe);
+ available_pipe_mask &= ~BIT(master_pipe + 1);
break;
+ }
}
+ igt_display_commit2(&data->display, COMMIT_ATOMIC);
+ for (i = 0; i < output_count; i++) {
+ igt_plane_set_fb(primary[i], NULL);
+ igt_remove_fb(data->drm_fd, &fb[i]);
+ }
+}
- igt_output_set_pipe(bigjoiner_output[0], data->pipe1);
- igt_output_set_pipe(bigjoiner_output[1], data->pipe2);
-
- /* Set up first big joiner output on Pipe A*/
- mode = &data->output[0].mode;
- igt_output_override_mode(bigjoiner_output[0], mode);
+static void test_invalid_modeset_two_joiner(data_t *data,
+ bool combined)
+{
+ int i, j, ret;
+ unsigned int available_pipe_mask;
+ unsigned int attempt_mask;
+ enum pipe master_pipe;
+ uint64_t *outputs;
+ igt_output_t *output;
+ igt_plane_t *primary[INVALID_TEST_OUTPUT];
+ igt_fb_t fb[INVALID_TEST_OUTPUT];
+ drmModeModeInfo *mode;
- pipe = &display->pipes[data->pipe1];
- plane1 = igt_pipe_get_plane_type(pipe, DRM_PLANE_TYPE_PRIMARY);
+ available_pipe_mask = BIT(data->n_pipes) - 1;
+ outputs = combined ? data->combined_output : data->big_joiner_output;
- igt_plane_set_fb(plane1, &data->fb);
- igt_fb_set_size(&data->fb, plane1, mode->hdisplay, mode->vdisplay);
- igt_plane_set_size(plane1, mode->hdisplay, mode->vdisplay);
+ for (i = 0; i < data->n_pipes-1; i++) {
+ igt_display_reset(&data->display);
+ attempt_mask = BIT(data->pipe_seq[i]);
+ master_pipe = get_next_master_pipe(data, available_pipe_mask & attempt_mask);
- /* Set up second big joiner output on Pipe C*/
- mode = &data->output[1].mode;
- igt_output_override_mode(bigjoiner_output[1], mode);
+ if (master_pipe == PIPE_NONE)
+ continue;
- pipe = &display->pipes[data->pipe2];
- plane2 = igt_pipe_get_plane_type(pipe, DRM_PLANE_TYPE_PRIMARY);
+ for (j = 0; j < INVALID_TEST_OUTPUT; j++) {
+ output = get_output_by_id_or_assert(data, outputs[j]);
+ igt_output_set_pipe(output, data->pipe_seq[i + j]);
+ mode = igt_output_get_mode(output);
+ igt_info(" Assigning pipe %s to %s with mode %dx%d@%d%s",
+ kmstest_pipe_name(data->pipe_seq[i + j]),
+ igt_output_name(output), mode->hdisplay,
+ mode->vdisplay, mode->vrefresh,
+ j == INVALID_TEST_OUTPUT - 1 ? "\n" : ", ");
+ primary[j] = igt_output_get_plane_type(output, DRM_PLANE_TYPE_PRIMARY);
+ igt_create_pattern_fb(data->drm_fd, mode->hdisplay, mode->vdisplay, DRM_FORMAT_XRGB8888,
+ DRM_FORMAT_MOD_LINEAR, &fb[j]);
+ igt_plane_set_fb(primary[j], &fb[j]);
+ }
+ ret = igt_display_try_commit2(&data->display, COMMIT_ATOMIC);
+ for (j = 0; j < INVALID_TEST_OUTPUT; j++) {
+ igt_plane_set_fb(primary[j], NULL);
+ igt_remove_fb(data->drm_fd, &fb[j]);
+ }
+ igt_assert_f(ret != 0, "Commit shouldn't have passed\n");
+ }
+}
- igt_plane_set_fb(plane2, &data->fb);
- igt_fb_set_size(&data->fb, plane2, mode->hdisplay, mode->vdisplay);
- igt_plane_set_size(plane2, mode->hdisplay, mode->vdisplay);
+static void test_big_joiner_on_last_pipe(data_t *data)
+{
+ int i, len, ret;
+ uint64_t *outputs;
+ igt_output_t *output;
+ igt_plane_t *primary;
+ igt_fb_t fb;
+ drmModeModeInfo *mode;
- igt_display_commit2(display, COMMIT_ATOMIC);
+ len = data->big_joiner_output_count;
+ outputs = data->big_joiner_output;
- /* Clean up */
- igt_output_set_pipe(bigjoiner_output[0], PIPE_NONE);
- igt_output_set_pipe(bigjoiner_output[1], PIPE_NONE);
- igt_plane_set_fb(plane1, NULL);
- igt_plane_set_fb(plane2, NULL);
- igt_display_commit2(display, COMMIT_ATOMIC);
+ for (i = 0; i < len; i++) {
+ igt_display_reset(&data->display);
+ output = get_output_by_id_or_assert(data, outputs[i]);
+ igt_output_set_pipe(output, data->pipe_seq[data->n_pipes - 1]);
+ mode = igt_output_get_mode(output);
+ igt_info(" Assigning pipe %s to %s with mode %dx%d@%d\n",
+ kmstest_pipe_name(data->pipe_seq[data->n_pipes - 1]),
+ igt_output_name(output), mode->hdisplay,
+ mode->vdisplay, mode->vrefresh);
+ primary = igt_output_get_plane_type(output, DRM_PLANE_TYPE_PRIMARY);
+ igt_create_pattern_fb(data->drm_fd, mode->hdisplay, mode->vdisplay, DRM_FORMAT_XRGB8888,
+ DRM_FORMAT_MOD_LINEAR, &fb);
+ igt_plane_set_fb(primary, &fb);
+ ret = igt_display_try_commit2(&data->display, COMMIT_ATOMIC);
+ igt_plane_set_fb(primary, NULL);
+ igt_remove_fb(data->drm_fd, &fb);
+ igt_assert_f(ret != 0, "Commit shouldn't have passed\n");
+ }
}
igt_main
{
- data_t data;
+ int i, j;
igt_output_t *output;
drmModeModeInfo mode;
- int valid_output = 0, i, count = 0, j = 0;
- uint16_t width = 0, height = 0;
- enum pipe pipe_seq[IGT_MAX_PIPES];
+ data_t data;
igt_fixture {
+ data.big_joiner_output_count = 0;
+ data.non_big_joiner_output_count = 0;
+ data.combined_output_count = 0;
+ data.output_count = 0;
+ j = 0;
+
data.drm_fd = drm_open_driver_master(DRIVER_INTEL | DRIVER_XE);
kmstest_set_vt_graphics_mode();
-
igt_display_require(&data.display, data.drm_fd);
+ set_all_master_pipes_for_platform(&data);
igt_require(data.display.is_atomic);
-
max_dotclock = igt_get_max_dotclock(data.drm_fd);
for_each_connected_output(&data.display, output) {
@@ -228,105 +304,53 @@ igt_main
found = bigjoiner_mode_found(data.drm_fd, connector, max_dotclock, &mode);
if (found) {
- data.output[count].output_id = output->id;
- memcpy(&data.output[count].mode, &mode, sizeof(drmModeModeInfo));
- count++;
-
- width = max(width, mode.hdisplay);
- height = max(height, mode.vdisplay);
+ data.big_joiner_output[data.big_joiner_output_count++] = output->config.connector->connector_id;
+ igt_output_override_mode(output, &mode);
+ } else {
+ data.non_big_joiner_output[data.non_big_joiner_output_count++] = output->config.connector->connector_id;
}
- valid_output++;
+ data.output_count++;
+ }
+ if (data.big_joiner_output_count == 1 && data.non_big_joiner_output_count >= 1) {
+ data.combined_output[data.combined_output_count++] = data.big_joiner_output[0];
+ data.combined_output[data.combined_output_count++] = data.non_big_joiner_output[0];
}
-
data.n_pipes = 0;
for_each_pipe(&data.display, i) {
data.n_pipes++;
- pipe_seq[j] = i;
+ data.pipe_seq[j] = i;
j++;
}
-
- igt_require_f(count > 0, "No output with 5k+ mode (or) clock > max-dot-clock found\n");
-
- igt_create_pattern_fb(data.drm_fd, width, height, DRM_FORMAT_XRGB8888,
- DRM_FORMAT_MOD_LINEAR, &data.fb);
}
igt_describe("Verify the basic modeset on big joiner mode on all pipes");
igt_subtest_with_dynamic("basic") {
- for (i = 0; i < data.n_pipes - 1; i++) {
- data.pipe1 = pipe_seq[i];
- igt_dynamic_f("pipe-%s", kmstest_pipe_name(pipe_seq[i]))
- test_basic_modeset(&data);
- }
+ igt_require_f(data.big_joiner_output_count > 0,
+ "No bigjoiner output found\n");
+ igt_require_f(data.n_pipes > 1,
+ "Minimum 2 pipes required\n");
+ igt_dynamic_f("single-joiner")
+ test_single_joiner(&data, data.big_joiner_output_count);
+ if (data.big_joiner_output_count > 1)
+ igt_dynamic_f("multi-joiner")
+ test_multi_joiner(&data, data.big_joiner_output_count);
}
- igt_describe("Verify if the modeset on the adjoining pipe is rejected "
- "when the pipe is active with a big joiner modeset");
igt_subtest_with_dynamic("invalid-modeset") {
- data.pipe1 = pipe_seq[j - 1];
-
- igt_display_reset(&data.display);
- for_each_connected_output(&data.display, output) {
- if (data.output[0].output_id != output->id)
- continue;
-
- mode = data.output[0].mode;
- igt_output_set_pipe(output, data.pipe1);
- igt_output_override_mode(output, &mode);
-
- igt_dynamic_f("pipe-%s-%s",
- kmstest_pipe_name(data.pipe1),
- igt_output_name(output))
- test_invalid_modeset(&data);
- }
-
- if(valid_output > 1) {
- for (i = 0; i < data.n_pipes - 1; i++) {
- igt_output_t *first_output = NULL, *second_output = NULL;
-
- data.pipe1 = pipe_seq[i];
- data.pipe2 = pipe_seq[i + 1];
-
- igt_display_reset(&data.display);
- for_each_connected_output(&data.display, output) {
- if (data.output[0].output_id == output->id) {
- first_output = output;
- mode = data.output[0].mode;
-
- igt_output_set_pipe(output, data.pipe1);
- igt_output_override_mode(output, &mode);
- } else if (second_output == NULL) {
- second_output = output;
- igt_output_set_pipe(output, data.pipe2);
-
- break;
- }
- }
-
- igt_dynamic_f("pipe-%s-%s-pipe-%s-%s",
- kmstest_pipe_name(data.pipe1),
- igt_output_name(first_output),
- kmstest_pipe_name(data.pipe2),
- igt_output_name(second_output))
- test_invalid_modeset(&data);
- }
- }
- }
-
- igt_describe("Verify simultaneous modeset on 2 big joiner outputs");
- igt_subtest_with_dynamic("2x-modeset") {
- igt_require_f(count > 1, "2 outputs with big joiner modes are required\n");
- igt_require_f(data.n_pipes > 3, "Minumum of 4 pipes are required\n");
- for (i = 0; (i + 2) < data.n_pipes - 1; i++) {
- data.pipe1 = pipe_seq[i];
- data.pipe2 = pipe_seq[i + 2];
- igt_dynamic_f("pipe-%s-%s", kmstest_pipe_name(pipe_seq[i]), kmstest_pipe_name(pipe_seq[i + 2]))
- test_dual_display(&data);
- }
+ igt_require_f(data.big_joiner_output_count > 0, "Non big joiner output not found\n");
+ igt_require_f(data.n_pipes > 1, "Minimum of 2 pipes are required\n");
+ if (data.big_joiner_output_count >= 1)
+ igt_dynamic_f("big_joiner_on_last_pipe")
+ test_big_joiner_on_last_pipe(&data);
+ if (data.big_joiner_output_count > 1)
+ igt_dynamic_f("invalid_combinations")
+ test_invalid_modeset_two_joiner(&data, false);
+ if (data.combined_output_count)
+ igt_dynamic_f("combined_output")
+ test_invalid_modeset_two_joiner(&data, true);
}
igt_fixture {
- igt_remove_fb(data.drm_fd, &data.fb);
igt_display_fini(&data.display);
drm_close_driver(data.drm_fd);
}
--
2.34.1
^ permalink raw reply related [flat|nested] 18+ messages in thread
* Re: [PATCH i-g-t 2/4] tests/intel/kms_big_joiner: revamp bigjoiner
2024-03-14 8:43 ` Nautiyal, Ankit K
@ 2024-03-18 5:26 ` Joshi, Kunal1
0 siblings, 0 replies; 18+ messages in thread
From: Joshi, Kunal1 @ 2024-03-18 5:26 UTC (permalink / raw)
To: Nautiyal, Ankit K, igt-dev
Cc: Stanislav Lisovskiy, Karthik B S, Bhanuprakash Modem
Hello Ankit,
On 3/14/2024 2:13 PM, Nautiyal, Ankit K wrote:
>
> On 3/10/2024 7:57 PM, Kunal Joshi wrote:
>> modify test to support simultaneously testing multiple bigjoiner
>> output and ignoring fused off pipes.
>
> I think there are a lot of changes in the patch, changing the basic
> test, removing the 2x test, adding multiple bigjoiner tests in one go.
>
> Imho, this should be broken into smaller patches.
I tried thinking of ways in which this can be divided into smaller patches.
But i think its not feasible since whole test is rewritten again.
>
>>
>> v2: Don't change license (Bhanu)
>> Print the pipe name (Bhanu)
>> Remove unwanted commit (Bhanu)
>> Move combine output logic to igt_fixture (Bhanu)
>> split revamp and force joiner (Bhanu)
>>
>> v3: Ignored fused pipes (Stan)
>>
>> Cc: Stanislav Lisovskiy <stanislav.lisovskiy@intel.com>
>> Cc: Ankit Nautiyal <ankit.k.nautiyal@intel.com>
>> Cc: Karthik B S <karthik.b.s@intel.com>
>> Cc: Bhanuprakash Modem <bhanuprakash.modem@intel.com>
>> Signed-off-by: Kunal Joshi <kunal1.joshi@intel.com>
>> Signed-off-by: Stanislav Lisovskiy <stanislav.lisovskiy@intel.com>
>> ---
>> tests/intel/kms_big_joiner.c | 398 +++++++++++++++++------------------
>> 1 file changed, 195 insertions(+), 203 deletions(-)
>>
>> diff --git a/tests/intel/kms_big_joiner.c b/tests/intel/kms_big_joiner.c
>> index 28678b958..d4b0d1100 100644
>> --- a/tests/intel/kms_big_joiner.c
>> +++ b/tests/intel/kms_big_joiner.c
>> @@ -37,184 +37,227 @@
>> #include "igt.h"
>> /**
>> - * SUBTEST: invalid-modeset
>> + * SUBTEST: invalid-modeset-bigjoiner
>
> I think this can be retained, this doesn't seem necessary.
Ok sure ankit.
>
>
>> * Description: Verify if the modeset on the adjoining pipe is
>> rejected when
>> * the pipe is active with a big joiner modeset
>> *
>> - * SUBTEST: basic
>> + * SUBTEST: basic-bigjoiner
>
> Same as above, also it already has subtests with single joiner, multi
> joiner.
>
>
>> * Description: Verify the basic modeset on big joiner mode on all
>> pipes
>> *
>> - * SUBTEST: 2x-modeset
>> - * Description: Verify simultaneous modeset on 2 big joiner outputs
>> */
>> IGT_TEST_DESCRIPTION("Test big joiner");
>> -struct bigjoiner_output {
>> - uint32_t output_id;
>> - drmModeModeInfo mode;
>> -};
>> +#define INVALID_TEST_OUTPUT 2
>> typedef struct {
>> int drm_fd;
>> - igt_display_t display;
>> - struct igt_fb fb;
>> + int big_joiner_output_count;
>> + int non_big_joiner_output_count;
>> + int combined_output_count;
>> + int output_count;
>> int n_pipes;
>> - enum pipe pipe1;
>> - enum pipe pipe2;
>> - struct bigjoiner_output output[2];
>> + int master_pipes;
>> + uint64_t big_joiner_output[IGT_MAX_PIPES];
>> + uint64_t non_big_joiner_output[IGT_MAX_PIPES];
>> + uint64_t combined_output[IGT_MAX_PIPES];
>> + enum pipe pipe_seq[IGT_MAX_PIPES];
>> + igt_display_t display;
>> } data_t;
>> static int max_dotclock;
>> -static void test_invalid_modeset(data_t *data)
>> +static void set_all_master_pipes_for_platform(data_t *data)
>> {
>> - igt_output_t *output;
>> - igt_display_t *display = &data->display;
>> - int ret;
>> -
>> - igt_info("Bigjoiner test on ");
>> - for_each_connected_output(display, output){
>> - enum pipe p = output->pending_pipe;
>> - drmModeModeInfo *mode;
>> - igt_pipe_t *pipe;
>> - igt_plane_t *plane;
>> + enum pipe pipe;
>> - if (p == PIPE_NONE)
>> - continue;
>> -
>> - mode = igt_output_get_mode(output);
>> - igt_info("pipe:%s, output:%s, mode:", kmstest_pipe_name(p),
>> igt_output_name(output));
>> - kmstest_dump_mode(mode);
>> + for (pipe = PIPE_A; pipe < IGT_MAX_PIPES; pipe++)
>> + if (data->display.pipes[pipe].enabled) {
>> + igt_info("Found master pipe %s\n",
>> kmstest_pipe_name(pipe));
>> + data->master_pipes |= BIT(pipe);
>> + }
>> +}
>> - pipe = &display->pipes[p];
>> - plane = igt_pipe_get_plane_type(pipe, DRM_PLANE_TYPE_PRIMARY);
>> +static igt_output_t *get_output_by_id_or_assert(data_t *data,
>> uint64_t id)
>> +{
>> + igt_output_t *output;
>> - igt_plane_set_fb(plane, &data->fb);
>> - igt_fb_set_size(&data->fb, plane, mode->hdisplay,
>> mode->vdisplay);
>> - igt_plane_set_size(plane, mode->hdisplay, mode->vdisplay);
>> + for_each_connected_output(&data->display, output) {
>> + if (output->id == id)
>> + return output;
>> }
>> + igt_assert_f(false, "Output not found\n");
>> + return NULL;
>> +}
>> - igt_assert(!igt_check_bigjoiner_support(display));
>> -
>> - /* This commit is expectd to fail as this pipe is being used for
>> big joiner */
>> - ret = igt_display_try_commit_atomic(display,
>> DRM_MODE_ATOMIC_TEST_ONLY |
>> - DRM_MODE_ATOMIC_ALLOW_MODESET, NULL);
>> -
>> - igt_display_reset(&data->display);
>> - igt_display_commit2(display, COMMIT_ATOMIC);
>> +static enum pipe get_next_master_pipe(data_t *data, unsigned int
>> available_pipe_mask)
>> +{
>> + if ((data->master_pipes & available_pipe_mask) == 0)
>> + return PIPE_NONE;
>> - igt_assert_lt(ret, 0);
>> + return ffs(data->master_pipes & available_pipe_mask) - 1;
>> }
>> -static void test_basic_modeset(data_t *data)
>> +static void test_single_joiner(data_t *data, int output_count)
>> {
>> + int i, ret;
>> + enum pipe pipe, master_pipe;
>> + unsigned int available_pipe_mask = BIT(data->n_pipes) - 1;
>> + unsigned int attempt_mask;
>> + igt_output_t *output;
>> + igt_plane_t *primary;
>> + uint64_t *outputs;
>> + igt_fb_t fb;
>> drmModeModeInfo *mode;
>> - igt_output_t *output, *bigjoiner_output = NULL;
>> - igt_display_t *display = &data->display;
>> - igt_pipe_t *pipe;
>> - igt_plane_t *plane;
>> - igt_display_reset(display);
>> + outputs = data->big_joiner_output;
>> - for_each_connected_output(display, output) {
>> - if (data->output[0].output_id == output->id) {
>> - bigjoiner_output = output;
>> - break;
>> + for (i = 0; i < output_count; i++) {
>> + output = get_output_by_id_or_assert(data, outputs[i]);
>> + for (pipe = 0; pipe < data->n_pipes-1; pipe++) {
>> + igt_display_reset(&data->display);
>> + attempt_mask = BIT(pipe);
>> +
>> + master_pipe = get_next_master_pipe(data,
>> available_pipe_mask & attempt_mask);
>> + if (master_pipe == PIPE_NONE)
>> + continue;
>> + igt_info("Using pipe %s as master and %s slave for
>> %s\n", kmstest_pipe_name(pipe), kmstest_pipe_name(pipe + 1),
>> output->name);
>
> In case a pipe is fused off we are ignoring it for master pipe, but
> since we cannot have it as slave also, we need to ignore pipe-1 also
> as master.
>
> I think similar thing is mentioned by Bhanu too in last version.
>
> So we need to change set_all_master_pipes_for_platform accordingly.
>
Yeah right, will address in next revision.
Thanks :)
>
>> + igt_output_set_pipe(output, pipe);
>> + mode = igt_output_get_mode(output);
>> + primary = igt_output_get_plane_type(output,
>> DRM_PLANE_TYPE_PRIMARY);
>> + igt_create_pattern_fb(data->drm_fd, mode->hdisplay,
>> mode->vdisplay, DRM_FORMAT_XRGB8888,
>> + DRM_FORMAT_MOD_LINEAR, &fb);
>> + igt_plane_set_fb(primary, &fb);
>> + ret = igt_display_try_commit2(&data->display,
>> COMMIT_ATOMIC);
>> + igt_assert_f(ret == 0, "Commit should have passed\n");
>
> Do we need try commit here? We can directly use
> igt_display_commit_atomic.
>
> Same in other places.
I can change to commit from try_commit.
>
>
>> }
>> }
>> +}
>> - igt_output_set_pipe(bigjoiner_output, data->pipe1);
>> +static void test_multi_joiner(data_t *data, int output_count)
>> +{
>> + int i, ret;
>> + unsigned int available_pipe_mask;
>> + enum pipe pipe, master_pipe;
>> + uint64_t *outputs;
>> + igt_output_t *output;
>> + igt_plane_t *primary[output_count];
>> + igt_fb_t fb[output_count];
>> + drmModeModeInfo *mode;
>> - mode = &data->output[0].mode;
>> - igt_output_override_mode(bigjoiner_output, mode);
>> + available_pipe_mask = BIT(data->n_pipes) - 1;
>> + outputs = data->big_joiner_output;
>> - pipe = &display->pipes[data->pipe1];
>> - plane = igt_pipe_get_plane_type(pipe, DRM_PLANE_TYPE_PRIMARY);
>> + igt_display_reset(&data->display);
>> + for (i = 0; i < output_count; i++) {
>> + output = get_output_by_id_or_assert(data, outputs[i]);
>> + for (pipe = 0; pipe < data->n_pipes; pipe++) {
>> + unsigned int attempt_mask = BIT(pipe);
>> - igt_plane_set_fb(plane, &data->fb);
>> - igt_fb_set_size(&data->fb, plane, mode->hdisplay, mode->vdisplay);
>> - igt_plane_set_size(plane, mode->hdisplay, mode->vdisplay);
>> + master_pipe = get_next_master_pipe(data,
>> available_pipe_mask & attempt_mask);
>> + if (master_pipe == PIPE_NONE)
>> + continue;
>> - igt_display_commit2(display, COMMIT_ATOMIC);
>> + igt_info("Using pipe %s as master %s slave for %s\n",
>> kmstest_pipe_name(pipe), kmstest_pipe_name(pipe + 1), output->name);
>> + igt_output_set_pipe(output, pipe);
>> + mode = igt_output_get_mode(output);
>> + primary[i] = igt_output_get_plane_type(output,
>> DRM_PLANE_TYPE_PRIMARY);
>> + igt_create_pattern_fb(data->drm_fd, mode->hdisplay,
>> mode->vdisplay, DRM_FORMAT_XRGB8888,
>> + DRM_FORMAT_MOD_LINEAR, &fb[i]);
>> + igt_plane_set_fb(primary[i], &fb[i]);
>> - igt_output_set_pipe(bigjoiner_output, PIPE_NONE);
>> - igt_plane_set_fb(plane, NULL);
>> - igt_display_commit2(display, COMMIT_ATOMIC);
>> + available_pipe_mask &= ~BIT(master_pipe);
>> + available_pipe_mask &= ~BIT(master_pipe + 1);
>> + break;
>> + }
>> + }
>> + ret = igt_display_try_commit2(&data->display, COMMIT_ATOMIC);
>> + igt_assert_f(ret == 0, "Commit should have passed\n");
>> }
>> -static void test_dual_display(data_t *data)
>> +static void test_invalid_modeset_two_joiner(data_t *data,
>> + bool combined)
>> {
>> + int i, j, ret;
>> + uint64_t *outputs;
>> + igt_output_t *output;
>> + igt_plane_t *primary[INVALID_TEST_OUTPUT];
>> + igt_fb_t fb[INVALID_TEST_OUTPUT];
>> drmModeModeInfo *mode;
>> - igt_output_t *output, *bigjoiner_output[2];
>> - igt_display_t *display = &data->display;
>> - igt_pipe_t *pipe;
>> - igt_plane_t *plane1, *plane2;
>> - int count = 0;
>> -
>> - igt_display_reset(display);
>> -
>> - for_each_connected_output(display, output) {
>> - if (data->output[count].output_id == output->id) {
>> - bigjoiner_output[count] = output;
>> - count++;
>> - }
>> - if (count > 1)
>> - break;
>> + outputs = combined ? data->combined_output :
>> data->big_joiner_output;
>> +
>> + for (i = 0; i < data->n_pipes-1; i++) {
>> + igt_display_reset(&data->display);
>> + for (j = 0; j < INVALID_TEST_OUTPUT; j++) {
>> + output = get_output_by_id_or_assert(data, outputs[j]);
>> + igt_assert(output);
>> + igt_output_set_pipe(output, data->pipe_seq[i + j]);
>> + mode = igt_output_get_mode(output);
>> + igt_info(" Assigning pipe %s to %s with mode %dx%d@%d%s",
>> + kmstest_pipe_name(data->pipe_seq[i + j]),
>> + igt_output_name(output), mode->hdisplay,
>> + mode->vdisplay, mode->vrefresh,
>> + j == INVALID_TEST_OUTPUT - 1 ? "\n" : ", ");
>> + primary[j] = igt_output_get_plane_type(output,
>> DRM_PLANE_TYPE_PRIMARY);
>> + igt_create_pattern_fb(data->drm_fd, mode->hdisplay,
>> mode->vdisplay, DRM_FORMAT_XRGB8888,
>> + DRM_FORMAT_MOD_LINEAR, &fb[j]);
>> + igt_plane_set_fb(primary[j], &fb[j]);
>> + }
>> + ret = igt_display_try_commit2(&data->display, COMMIT_ATOMIC);
>> + igt_assert_f(ret != 0, "Commit shouldn't have passed\n");
>> }
>> +}
>> - igt_output_set_pipe(bigjoiner_output[0], data->pipe1);
>> - igt_output_set_pipe(bigjoiner_output[1], data->pipe2);
>> -
>> - /* Set up first big joiner output on Pipe A*/
>> - mode = &data->output[0].mode;
>> - igt_output_override_mode(bigjoiner_output[0], mode);
>> -
>> - pipe = &display->pipes[data->pipe1];
>> - plane1 = igt_pipe_get_plane_type(pipe, DRM_PLANE_TYPE_PRIMARY);
>> -
>> - igt_plane_set_fb(plane1, &data->fb);
>> - igt_fb_set_size(&data->fb, plane1, mode->hdisplay, mode->vdisplay);
>> - igt_plane_set_size(plane1, mode->hdisplay, mode->vdisplay);
>> -
>> - /* Set up second big joiner output on Pipe C*/
>> - mode = &data->output[1].mode;
>> - igt_output_override_mode(bigjoiner_output[1], mode);
>> -
>> - pipe = &display->pipes[data->pipe2];
>> - plane2 = igt_pipe_get_plane_type(pipe, DRM_PLANE_TYPE_PRIMARY);
>> -
>> - igt_plane_set_fb(plane2, &data->fb);
>> - igt_fb_set_size(&data->fb, plane2, mode->hdisplay, mode->vdisplay);
>> - igt_plane_set_size(plane2, mode->hdisplay, mode->vdisplay);
>> +static void tets_big_joiner_on_last_pipe(data_t *data)
>
> Typo: test
>
>
>> +{
>> + int i, len, ret;
>> + uint64_t *outputs;
>> + igt_output_t *output;
>> + igt_plane_t *primary;
>> + igt_fb_t fb;
>> + drmModeModeInfo *mode;
>> - igt_display_commit2(display, COMMIT_ATOMIC);
>> + len = data->big_joiner_output_count;
>> + outputs = data->big_joiner_output;
>> - /* Clean up */
>> - igt_output_set_pipe(bigjoiner_output[0], PIPE_NONE);
>> - igt_output_set_pipe(bigjoiner_output[1], PIPE_NONE);
>> - igt_plane_set_fb(plane1, NULL);
>> - igt_plane_set_fb(plane2, NULL);
>> - igt_display_commit2(display, COMMIT_ATOMIC);
>> + for (i = 0; i < len; i++) {
>> + igt_display_reset(&data->display);
>> + output = get_output_by_id_or_assert(data, outputs[i]);
>> + igt_output_set_pipe(output, data->pipe_seq[data->n_pipes - 1]);
>> + mode = igt_output_get_mode(output);
>> + igt_info(" Assigning pipe %s to %s with mode %dx%d@%d\n",
>> + kmstest_pipe_name(data->pipe_seq[data->n_pipes - 1]),
>> + igt_output_name(output), mode->hdisplay,
>> + mode->vdisplay, mode->vrefresh);
>> + primary = igt_output_get_plane_type(output,
>> DRM_PLANE_TYPE_PRIMARY);
>> + igt_create_pattern_fb(data->drm_fd, mode->hdisplay,
>> mode->vdisplay, DRM_FORMAT_XRGB8888,
>> + DRM_FORMAT_MOD_LINEAR, &fb);
>> + igt_plane_set_fb(primary, &fb);
>> + ret = igt_display_try_commit2(&data->display, COMMIT_ATOMIC);
>> + igt_assert_f(ret != 0, "Commit shouldn't have passed\n");
>> + }
>> }
>> +
>> igt_main
>> {
>> - data_t data;
>> + int i, j;
>> igt_output_t *output;
>> - drmModeModeInfo mode;
>> - int valid_output = 0, i, count = 0, j = 0;
>> - uint16_t width = 0, height = 0;
>> - enum pipe pipe_seq[IGT_MAX_PIPES];
>> + data_t data;
>> igt_fixture {
>> + data.big_joiner_output_count = 0;
>> + data.non_big_joiner_output_count = 0;
>> + data.combined_output_count = 0;
>> + data.output_count = 0;
>> + j = 0;
>> +
>> data.drm_fd = drm_open_driver_master(DRIVER_INTEL |
>> DRIVER_XE);
>> kmstest_set_vt_graphics_mode();
>> -
>> igt_display_require(&data.display, data.drm_fd);
>> + set_all_master_pipes_for_platform(&data);
>> igt_require(data.display.is_atomic);
>> -
>> max_dotclock = igt_get_max_dotclock(data.drm_fd);
>> for_each_connected_output(&data.display, output) {
>> @@ -228,105 +271,54 @@ igt_main
>> found = bigjoiner_mode_found(data.drm_fd, connector,
>> max_dotclock);
>> if (found) {
>> - data.output[count].output_id = output->id;
>> - memcpy(&data.output[count].mode, &mode,
>> sizeof(drmModeModeInfo));
>> - count++;
>> -
>> - width = max(width, mode.hdisplay);
>> - height = max(height, mode.vdisplay);
>> + data.big_joiner_output[data.big_joiner_output_count++] =
>> output->config.connector->connector_id;
>> + igt_output_override_mode(output, &connector->modes[0]);
>> + } else {
>> + data.non_big_joiner_output[data.non_big_joiner_output_count++] =
>> output->config.connector->connector_id;
>> }
>> - valid_output++;
>> + data.output_count++;
>> + }
>> + if (data.big_joiner_output_count == 1 &&
>> data.non_big_joiner_output_count >= 1) {
>> + data.combined_output[data.combined_output_count++] =
>> data.big_joiner_output[0];
>> + data.combined_output[data.combined_output_count++] =
>> data.non_big_joiner_output[0];
>> }
>> -
>> data.n_pipes = 0;
>> for_each_pipe(&data.display, i) {
>> data.n_pipes++;
>> - pipe_seq[j] = i;
>> + data.pipe_seq[j] = i;
>> j++;
>> }
>> -
>> - igt_require_f(count > 0, "No output with 5k+ mode (or) clock
>> > max-dot-clock found\n");
>> -
>> - igt_create_pattern_fb(data.drm_fd, width, height,
>> DRM_FORMAT_XRGB8888,
>> - DRM_FORMAT_MOD_LINEAR, &data.fb);
>> }
>> igt_describe("Verify the basic modeset on big joiner mode on
>> all pipes");
>> - igt_subtest_with_dynamic("basic") {
>> - for (i = 0; i < data.n_pipes - 1; i++) {
>> - data.pipe1 = pipe_seq[i];
>> - igt_dynamic_f("pipe-%s", kmstest_pipe_name(pipe_seq[i]))
>> - test_basic_modeset(&data);
>> - }
>> - }
>> + igt_subtest_with_dynamic("basic-bigjoiner") {
>> + igt_require_f(data.big_joiner_output_count > 0,
>> + "No bigjoiner output found\n");
>> + igt_require_f(data.n_pipes > 1,
>> + "Minimum 2 pipes required\n");
>> + igt_dynamic_f("single-joiner")
>> + test_single_joiner(&data,
>> data.big_joiner_output_count);
>> + if (data.big_joiner_output_count > 1)
>> + igt_dynamic_f("multi-joiner")
>> + test_multi_joiner(&data,
>> data.big_joiner_output_count);
>> - igt_describe("Verify if the modeset on the adjoining pipe is
>> rejected "
>> - "when the pipe is active with a big joiner modeset");
>> - igt_subtest_with_dynamic("invalid-modeset") {
>> - data.pipe1 = pipe_seq[j - 1];
>> -
>> - igt_display_reset(&data.display);
>> - for_each_connected_output(&data.display, output) {
>> - if (data.output[0].output_id != output->id)
>> - continue;
>> -
>> - mode = data.output[0].mode;
>> - igt_output_set_pipe(output, data.pipe1);
>> - igt_output_override_mode(output, &mode);
>> -
>> - igt_dynamic_f("pipe-%s-%s",
>> - kmstest_pipe_name(data.pipe1),
>> - igt_output_name(output))
>> - test_invalid_modeset(&data);
>> - }
>> -
>> - if(valid_output > 1) {
>> - for (i = 0; i < data.n_pipes - 1; i++) {
>> - igt_output_t *first_output = NULL, *second_output =
>> NULL;
>> -
>> - data.pipe1 = pipe_seq[i];
>> - data.pipe2 = pipe_seq[i + 1];
>> -
>> - igt_display_reset(&data.display);
>> - for_each_connected_output(&data.display, output) {
>> - if (data.output[0].output_id == output->id) {
>> - first_output = output;
>> - mode = data.output[0].mode;
>> -
>> - igt_output_set_pipe(output, data.pipe1);
>> - igt_output_override_mode(output, &mode);
>> - } else if (second_output == NULL) {
>> - second_output = output;
>> - igt_output_set_pipe(output, data.pipe2);
>> -
>> - break;
>> - }
>> - }
>> -
>> - igt_dynamic_f("pipe-%s-%s-pipe-%s-%s",
>> - kmstest_pipe_name(data.pipe1),
>> - igt_output_name(first_output),
>> - kmstest_pipe_name(data.pipe2),
>> - igt_output_name(second_output))
>> - test_invalid_modeset(&data);
>> - }
>> - }
>> }
>> - igt_describe("Verify simultaneous modeset on 2 big joiner
>> outputs");
>> - igt_subtest_with_dynamic("2x-modeset") {
>> - igt_require_f(count > 1, "2 outputs with big joiner modes
>> are required\n");
>> - igt_require_f(data.n_pipes > 3, "Minumum of 4 pipes are
>> required\n");
>> - for (i = 0; (i + 2) < data.n_pipes - 1; i++) {
>> - data.pipe1 = pipe_seq[i];
>> - data.pipe2 = pipe_seq[i + 2];
>> - igt_dynamic_f("pipe-%s-%s",
>> kmstest_pipe_name(pipe_seq[i]), kmstest_pipe_name(pipe_seq[i + 2]))
>> - test_dual_display(&data);
>> - }
>> + igt_subtest_with_dynamic("invalid-modeset-bigjoiner") {
>> + igt_require_f(data.big_joiner_output_count > 0, "Non big
>> joiner output not found\n");
>
> I think we just need to check if there are 2 outputs or not.
Ankit there are two dynamic tests inside invalid-modeset-bigjoiner
last-pipe (Require 1 output)
two-joiner (Require 2 output, (either 2 bigjoiner or 1 bigjoiner and 1
non bigjoiner )
>
>
> Regards,
>
> Ankit
>
>> + igt_require_f(data.n_pipes > 1, "Minimum of 2 pipes are
>> required\n");
>> + if (data.big_joiner_output_count >= 1)
>> + igt_dynamic_f("big_joiner_on_last_pipe")
>> + tets_big_joiner_on_last_pipe(&data);
>> + if (data.big_joiner_output_count > 1)
>> + igt_dynamic_f("invalid_combinations")
>> + test_invalid_modeset_two_joiner(&data, false);
>> + if (data.combined_output_count)
>> + igt_dynamic_f("combined_output")
>> + test_invalid_modeset_two_joiner(&data, true);
>> }
>> igt_fixture {
>> - igt_remove_fb(data.drm_fd, &data.fb);
>> igt_display_fini(&data.display);
>> drm_close_driver(data.drm_fd);
>> }
Thanks and Regards
Kunal Joshi
^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: [PATCH i-g-t 2/4] tests/intel/kms_big_joiner: revamp bigjoiner
2024-03-10 14:27 ` [PATCH i-g-t 2/4] tests/intel/kms_big_joiner: revamp bigjoiner Kunal Joshi
@ 2024-03-14 8:43 ` Nautiyal, Ankit K
2024-03-18 5:26 ` Joshi, Kunal1
0 siblings, 1 reply; 18+ messages in thread
From: Nautiyal, Ankit K @ 2024-03-14 8:43 UTC (permalink / raw)
To: Kunal Joshi, igt-dev; +Cc: Stanislav Lisovskiy, Karthik B S, Bhanuprakash Modem
On 3/10/2024 7:57 PM, Kunal Joshi wrote:
> modify test to support simultaneously testing multiple bigjoiner
> output and ignoring fused off pipes.
I think there are a lot of changes in the patch, changing the basic
test, removing the 2x test, adding multiple bigjoiner tests in one go.
Imho, this should be broken into smaller patches.
>
> v2: Don't change license (Bhanu)
> Print the pipe name (Bhanu)
> Remove unwanted commit (Bhanu)
> Move combine output logic to igt_fixture (Bhanu)
> split revamp and force joiner (Bhanu)
>
> v3: Ignored fused pipes (Stan)
>
> Cc: Stanislav Lisovskiy <stanislav.lisovskiy@intel.com>
> Cc: Ankit Nautiyal <ankit.k.nautiyal@intel.com>
> Cc: Karthik B S <karthik.b.s@intel.com>
> Cc: Bhanuprakash Modem <bhanuprakash.modem@intel.com>
> Signed-off-by: Kunal Joshi <kunal1.joshi@intel.com>
> Signed-off-by: Stanislav Lisovskiy <stanislav.lisovskiy@intel.com>
> ---
> tests/intel/kms_big_joiner.c | 398 +++++++++++++++++------------------
> 1 file changed, 195 insertions(+), 203 deletions(-)
>
> diff --git a/tests/intel/kms_big_joiner.c b/tests/intel/kms_big_joiner.c
> index 28678b958..d4b0d1100 100644
> --- a/tests/intel/kms_big_joiner.c
> +++ b/tests/intel/kms_big_joiner.c
> @@ -37,184 +37,227 @@
> #include "igt.h"
>
> /**
> - * SUBTEST: invalid-modeset
> + * SUBTEST: invalid-modeset-bigjoiner
I think this can be retained, this doesn't seem necessary.
> * Description: Verify if the modeset on the adjoining pipe is rejected when
> * the pipe is active with a big joiner modeset
> *
> - * SUBTEST: basic
> + * SUBTEST: basic-bigjoiner
Same as above, also it already has subtests with single joiner, multi
joiner.
> * Description: Verify the basic modeset on big joiner mode on all pipes
> *
> - * SUBTEST: 2x-modeset
> - * Description: Verify simultaneous modeset on 2 big joiner outputs
> */
>
> IGT_TEST_DESCRIPTION("Test big joiner");
>
> -struct bigjoiner_output {
> - uint32_t output_id;
> - drmModeModeInfo mode;
> -};
> +#define INVALID_TEST_OUTPUT 2
>
> typedef struct {
> int drm_fd;
> - igt_display_t display;
> - struct igt_fb fb;
> + int big_joiner_output_count;
> + int non_big_joiner_output_count;
> + int combined_output_count;
> + int output_count;
> int n_pipes;
> - enum pipe pipe1;
> - enum pipe pipe2;
> - struct bigjoiner_output output[2];
> + int master_pipes;
> + uint64_t big_joiner_output[IGT_MAX_PIPES];
> + uint64_t non_big_joiner_output[IGT_MAX_PIPES];
> + uint64_t combined_output[IGT_MAX_PIPES];
> + enum pipe pipe_seq[IGT_MAX_PIPES];
> + igt_display_t display;
> } data_t;
>
> static int max_dotclock;
>
> -static void test_invalid_modeset(data_t *data)
> +static void set_all_master_pipes_for_platform(data_t *data)
> {
> - igt_output_t *output;
> - igt_display_t *display = &data->display;
> - int ret;
> -
> - igt_info("Bigjoiner test on ");
> - for_each_connected_output(display, output){
> - enum pipe p = output->pending_pipe;
> - drmModeModeInfo *mode;
> - igt_pipe_t *pipe;
> - igt_plane_t *plane;
> + enum pipe pipe;
>
> - if (p == PIPE_NONE)
> - continue;
> -
> - mode = igt_output_get_mode(output);
> - igt_info("pipe:%s, output:%s, mode:", kmstest_pipe_name(p), igt_output_name(output));
> - kmstest_dump_mode(mode);
> + for (pipe = PIPE_A; pipe < IGT_MAX_PIPES; pipe++)
> + if (data->display.pipes[pipe].enabled) {
> + igt_info("Found master pipe %s\n", kmstest_pipe_name(pipe));
> + data->master_pipes |= BIT(pipe);
> + }
> +}
>
> - pipe = &display->pipes[p];
> - plane = igt_pipe_get_plane_type(pipe, DRM_PLANE_TYPE_PRIMARY);
> +static igt_output_t *get_output_by_id_or_assert(data_t *data, uint64_t id)
> +{
> + igt_output_t *output;
>
> - igt_plane_set_fb(plane, &data->fb);
> - igt_fb_set_size(&data->fb, plane, mode->hdisplay, mode->vdisplay);
> - igt_plane_set_size(plane, mode->hdisplay, mode->vdisplay);
> + for_each_connected_output(&data->display, output) {
> + if (output->id == id)
> + return output;
> }
> + igt_assert_f(false, "Output not found\n");
> + return NULL;
> +}
>
> - igt_assert(!igt_check_bigjoiner_support(display));
> -
> - /* This commit is expectd to fail as this pipe is being used for big joiner */
> - ret = igt_display_try_commit_atomic(display, DRM_MODE_ATOMIC_TEST_ONLY |
> - DRM_MODE_ATOMIC_ALLOW_MODESET, NULL);
> -
> - igt_display_reset(&data->display);
> - igt_display_commit2(display, COMMIT_ATOMIC);
> +static enum pipe get_next_master_pipe(data_t *data, unsigned int available_pipe_mask)
> +{
> + if ((data->master_pipes & available_pipe_mask) == 0)
> + return PIPE_NONE;
>
> - igt_assert_lt(ret, 0);
> + return ffs(data->master_pipes & available_pipe_mask) - 1;
> }
>
> -static void test_basic_modeset(data_t *data)
> +static void test_single_joiner(data_t *data, int output_count)
> {
> + int i, ret;
> + enum pipe pipe, master_pipe;
> + unsigned int available_pipe_mask = BIT(data->n_pipes) - 1;
> + unsigned int attempt_mask;
> + igt_output_t *output;
> + igt_plane_t *primary;
> + uint64_t *outputs;
> + igt_fb_t fb;
> drmModeModeInfo *mode;
> - igt_output_t *output, *bigjoiner_output = NULL;
> - igt_display_t *display = &data->display;
> - igt_pipe_t *pipe;
> - igt_plane_t *plane;
>
> - igt_display_reset(display);
> + outputs = data->big_joiner_output;
>
> - for_each_connected_output(display, output) {
> - if (data->output[0].output_id == output->id) {
> - bigjoiner_output = output;
> - break;
> + for (i = 0; i < output_count; i++) {
> + output = get_output_by_id_or_assert(data, outputs[i]);
> + for (pipe = 0; pipe < data->n_pipes-1; pipe++) {
> + igt_display_reset(&data->display);
> + attempt_mask = BIT(pipe);
> +
> + master_pipe = get_next_master_pipe(data, available_pipe_mask & attempt_mask);
> + if (master_pipe == PIPE_NONE)
> + continue;
> + igt_info("Using pipe %s as master and %s slave for %s\n", kmstest_pipe_name(pipe), kmstest_pipe_name(pipe + 1), output->name);
In case a pipe is fused off we are ignoring it for master pipe, but
since we cannot have it as slave also, we need to ignore pipe-1 also as
master.
I think similar thing is mentioned by Bhanu too in last version.
So we need to change set_all_master_pipes_for_platform accordingly.
> + igt_output_set_pipe(output, pipe);
> + mode = igt_output_get_mode(output);
> + primary = igt_output_get_plane_type(output, DRM_PLANE_TYPE_PRIMARY);
> + igt_create_pattern_fb(data->drm_fd, mode->hdisplay, mode->vdisplay, DRM_FORMAT_XRGB8888,
> + DRM_FORMAT_MOD_LINEAR, &fb);
> + igt_plane_set_fb(primary, &fb);
> + ret = igt_display_try_commit2(&data->display, COMMIT_ATOMIC);
> + igt_assert_f(ret == 0, "Commit should have passed\n");
Do we need try commit here? We can directly use igt_display_commit_atomic.
Same in other places.
> }
> }
> +}
>
> - igt_output_set_pipe(bigjoiner_output, data->pipe1);
> +static void test_multi_joiner(data_t *data, int output_count)
> +{
> + int i, ret;
> + unsigned int available_pipe_mask;
> + enum pipe pipe, master_pipe;
> + uint64_t *outputs;
> + igt_output_t *output;
> + igt_plane_t *primary[output_count];
> + igt_fb_t fb[output_count];
> + drmModeModeInfo *mode;
>
> - mode = &data->output[0].mode;
> - igt_output_override_mode(bigjoiner_output, mode);
> + available_pipe_mask = BIT(data->n_pipes) - 1;
> + outputs = data->big_joiner_output;
>
> - pipe = &display->pipes[data->pipe1];
> - plane = igt_pipe_get_plane_type(pipe, DRM_PLANE_TYPE_PRIMARY);
> + igt_display_reset(&data->display);
> + for (i = 0; i < output_count; i++) {
> + output = get_output_by_id_or_assert(data, outputs[i]);
> + for (pipe = 0; pipe < data->n_pipes; pipe++) {
> + unsigned int attempt_mask = BIT(pipe);
>
> - igt_plane_set_fb(plane, &data->fb);
> - igt_fb_set_size(&data->fb, plane, mode->hdisplay, mode->vdisplay);
> - igt_plane_set_size(plane, mode->hdisplay, mode->vdisplay);
> + master_pipe = get_next_master_pipe(data, available_pipe_mask & attempt_mask);
> + if (master_pipe == PIPE_NONE)
> + continue;
>
> - igt_display_commit2(display, COMMIT_ATOMIC);
> + igt_info("Using pipe %s as master %s slave for %s\n", kmstest_pipe_name(pipe), kmstest_pipe_name(pipe + 1), output->name);
> + igt_output_set_pipe(output, pipe);
> + mode = igt_output_get_mode(output);
> + primary[i] = igt_output_get_plane_type(output, DRM_PLANE_TYPE_PRIMARY);
> + igt_create_pattern_fb(data->drm_fd, mode->hdisplay, mode->vdisplay, DRM_FORMAT_XRGB8888,
> + DRM_FORMAT_MOD_LINEAR, &fb[i]);
> + igt_plane_set_fb(primary[i], &fb[i]);
>
> - igt_output_set_pipe(bigjoiner_output, PIPE_NONE);
> - igt_plane_set_fb(plane, NULL);
> - igt_display_commit2(display, COMMIT_ATOMIC);
> + available_pipe_mask &= ~BIT(master_pipe);
> + available_pipe_mask &= ~BIT(master_pipe + 1);
> + break;
> + }
> + }
> + ret = igt_display_try_commit2(&data->display, COMMIT_ATOMIC);
> + igt_assert_f(ret == 0, "Commit should have passed\n");
> }
>
> -static void test_dual_display(data_t *data)
> +static void test_invalid_modeset_two_joiner(data_t *data,
> + bool combined)
> {
> + int i, j, ret;
> + uint64_t *outputs;
> + igt_output_t *output;
> + igt_plane_t *primary[INVALID_TEST_OUTPUT];
> + igt_fb_t fb[INVALID_TEST_OUTPUT];
> drmModeModeInfo *mode;
> - igt_output_t *output, *bigjoiner_output[2];
> - igt_display_t *display = &data->display;
> - igt_pipe_t *pipe;
> - igt_plane_t *plane1, *plane2;
> - int count = 0;
> -
> - igt_display_reset(display);
> -
> - for_each_connected_output(display, output) {
> - if (data->output[count].output_id == output->id) {
> - bigjoiner_output[count] = output;
> - count++;
> - }
>
> - if (count > 1)
> - break;
> + outputs = combined ? data->combined_output : data->big_joiner_output;
> +
> + for (i = 0; i < data->n_pipes-1; i++) {
> + igt_display_reset(&data->display);
> + for (j = 0; j < INVALID_TEST_OUTPUT; j++) {
> + output = get_output_by_id_or_assert(data, outputs[j]);
> + igt_assert(output);
> + igt_output_set_pipe(output, data->pipe_seq[i + j]);
> + mode = igt_output_get_mode(output);
> + igt_info(" Assigning pipe %s to %s with mode %dx%d@%d%s",
> + kmstest_pipe_name(data->pipe_seq[i + j]),
> + igt_output_name(output), mode->hdisplay,
> + mode->vdisplay, mode->vrefresh,
> + j == INVALID_TEST_OUTPUT - 1 ? "\n" : ", ");
> + primary[j] = igt_output_get_plane_type(output, DRM_PLANE_TYPE_PRIMARY);
> + igt_create_pattern_fb(data->drm_fd, mode->hdisplay, mode->vdisplay, DRM_FORMAT_XRGB8888,
> + DRM_FORMAT_MOD_LINEAR, &fb[j]);
> + igt_plane_set_fb(primary[j], &fb[j]);
> + }
> + ret = igt_display_try_commit2(&data->display, COMMIT_ATOMIC);
> + igt_assert_f(ret != 0, "Commit shouldn't have passed\n");
> }
> +}
>
> - igt_output_set_pipe(bigjoiner_output[0], data->pipe1);
> - igt_output_set_pipe(bigjoiner_output[1], data->pipe2);
> -
> - /* Set up first big joiner output on Pipe A*/
> - mode = &data->output[0].mode;
> - igt_output_override_mode(bigjoiner_output[0], mode);
> -
> - pipe = &display->pipes[data->pipe1];
> - plane1 = igt_pipe_get_plane_type(pipe, DRM_PLANE_TYPE_PRIMARY);
> -
> - igt_plane_set_fb(plane1, &data->fb);
> - igt_fb_set_size(&data->fb, plane1, mode->hdisplay, mode->vdisplay);
> - igt_plane_set_size(plane1, mode->hdisplay, mode->vdisplay);
> -
> - /* Set up second big joiner output on Pipe C*/
> - mode = &data->output[1].mode;
> - igt_output_override_mode(bigjoiner_output[1], mode);
> -
> - pipe = &display->pipes[data->pipe2];
> - plane2 = igt_pipe_get_plane_type(pipe, DRM_PLANE_TYPE_PRIMARY);
> -
> - igt_plane_set_fb(plane2, &data->fb);
> - igt_fb_set_size(&data->fb, plane2, mode->hdisplay, mode->vdisplay);
> - igt_plane_set_size(plane2, mode->hdisplay, mode->vdisplay);
> +static void tets_big_joiner_on_last_pipe(data_t *data)
Typo: test
> +{
> + int i, len, ret;
> + uint64_t *outputs;
> + igt_output_t *output;
> + igt_plane_t *primary;
> + igt_fb_t fb;
> + drmModeModeInfo *mode;
>
> - igt_display_commit2(display, COMMIT_ATOMIC);
> + len = data->big_joiner_output_count;
> + outputs = data->big_joiner_output;
>
> - /* Clean up */
> - igt_output_set_pipe(bigjoiner_output[0], PIPE_NONE);
> - igt_output_set_pipe(bigjoiner_output[1], PIPE_NONE);
> - igt_plane_set_fb(plane1, NULL);
> - igt_plane_set_fb(plane2, NULL);
> - igt_display_commit2(display, COMMIT_ATOMIC);
> + for (i = 0; i < len; i++) {
> + igt_display_reset(&data->display);
> + output = get_output_by_id_or_assert(data, outputs[i]);
> + igt_output_set_pipe(output, data->pipe_seq[data->n_pipes - 1]);
> + mode = igt_output_get_mode(output);
> + igt_info(" Assigning pipe %s to %s with mode %dx%d@%d\n",
> + kmstest_pipe_name(data->pipe_seq[data->n_pipes - 1]),
> + igt_output_name(output), mode->hdisplay,
> + mode->vdisplay, mode->vrefresh);
> + primary = igt_output_get_plane_type(output, DRM_PLANE_TYPE_PRIMARY);
> + igt_create_pattern_fb(data->drm_fd, mode->hdisplay, mode->vdisplay, DRM_FORMAT_XRGB8888,
> + DRM_FORMAT_MOD_LINEAR, &fb);
> + igt_plane_set_fb(primary, &fb);
> + ret = igt_display_try_commit2(&data->display, COMMIT_ATOMIC);
> + igt_assert_f(ret != 0, "Commit shouldn't have passed\n");
> + }
> }
>
> +
> igt_main
> {
> - data_t data;
> + int i, j;
> igt_output_t *output;
> - drmModeModeInfo mode;
> - int valid_output = 0, i, count = 0, j = 0;
> - uint16_t width = 0, height = 0;
> - enum pipe pipe_seq[IGT_MAX_PIPES];
> + data_t data;
>
> igt_fixture {
> + data.big_joiner_output_count = 0;
> + data.non_big_joiner_output_count = 0;
> + data.combined_output_count = 0;
> + data.output_count = 0;
> + j = 0;
> +
> data.drm_fd = drm_open_driver_master(DRIVER_INTEL | DRIVER_XE);
> kmstest_set_vt_graphics_mode();
> -
> igt_display_require(&data.display, data.drm_fd);
> + set_all_master_pipes_for_platform(&data);
> igt_require(data.display.is_atomic);
> -
> max_dotclock = igt_get_max_dotclock(data.drm_fd);
>
> for_each_connected_output(&data.display, output) {
> @@ -228,105 +271,54 @@ igt_main
> found = bigjoiner_mode_found(data.drm_fd, connector, max_dotclock);
>
> if (found) {
> - data.output[count].output_id = output->id;
> - memcpy(&data.output[count].mode, &mode, sizeof(drmModeModeInfo));
> - count++;
> -
> - width = max(width, mode.hdisplay);
> - height = max(height, mode.vdisplay);
> + data.big_joiner_output[data.big_joiner_output_count++] = output->config.connector->connector_id;
> + igt_output_override_mode(output, &connector->modes[0]);
> + } else {
> + data.non_big_joiner_output[data.non_big_joiner_output_count++] = output->config.connector->connector_id;
> }
> - valid_output++;
> + data.output_count++;
> + }
> + if (data.big_joiner_output_count == 1 && data.non_big_joiner_output_count >= 1) {
> + data.combined_output[data.combined_output_count++] = data.big_joiner_output[0];
> + data.combined_output[data.combined_output_count++] = data.non_big_joiner_output[0];
> }
> -
> data.n_pipes = 0;
> for_each_pipe(&data.display, i) {
> data.n_pipes++;
> - pipe_seq[j] = i;
> + data.pipe_seq[j] = i;
> j++;
> }
> -
> - igt_require_f(count > 0, "No output with 5k+ mode (or) clock > max-dot-clock found\n");
> -
> - igt_create_pattern_fb(data.drm_fd, width, height, DRM_FORMAT_XRGB8888,
> - DRM_FORMAT_MOD_LINEAR, &data.fb);
> }
>
> igt_describe("Verify the basic modeset on big joiner mode on all pipes");
> - igt_subtest_with_dynamic("basic") {
> - for (i = 0; i < data.n_pipes - 1; i++) {
> - data.pipe1 = pipe_seq[i];
> - igt_dynamic_f("pipe-%s", kmstest_pipe_name(pipe_seq[i]))
> - test_basic_modeset(&data);
> - }
> - }
> + igt_subtest_with_dynamic("basic-bigjoiner") {
> + igt_require_f(data.big_joiner_output_count > 0,
> + "No bigjoiner output found\n");
> + igt_require_f(data.n_pipes > 1,
> + "Minimum 2 pipes required\n");
> + igt_dynamic_f("single-joiner")
> + test_single_joiner(&data, data.big_joiner_output_count);
> + if (data.big_joiner_output_count > 1)
> + igt_dynamic_f("multi-joiner")
> + test_multi_joiner(&data, data.big_joiner_output_count);
>
> - igt_describe("Verify if the modeset on the adjoining pipe is rejected "
> - "when the pipe is active with a big joiner modeset");
> - igt_subtest_with_dynamic("invalid-modeset") {
> - data.pipe1 = pipe_seq[j - 1];
> -
> - igt_display_reset(&data.display);
> - for_each_connected_output(&data.display, output) {
> - if (data.output[0].output_id != output->id)
> - continue;
> -
> - mode = data.output[0].mode;
> - igt_output_set_pipe(output, data.pipe1);
> - igt_output_override_mode(output, &mode);
> -
> - igt_dynamic_f("pipe-%s-%s",
> - kmstest_pipe_name(data.pipe1),
> - igt_output_name(output))
> - test_invalid_modeset(&data);
> - }
> -
> - if(valid_output > 1) {
> - for (i = 0; i < data.n_pipes - 1; i++) {
> - igt_output_t *first_output = NULL, *second_output = NULL;
> -
> - data.pipe1 = pipe_seq[i];
> - data.pipe2 = pipe_seq[i + 1];
> -
> - igt_display_reset(&data.display);
> - for_each_connected_output(&data.display, output) {
> - if (data.output[0].output_id == output->id) {
> - first_output = output;
> - mode = data.output[0].mode;
> -
> - igt_output_set_pipe(output, data.pipe1);
> - igt_output_override_mode(output, &mode);
> - } else if (second_output == NULL) {
> - second_output = output;
> - igt_output_set_pipe(output, data.pipe2);
> -
> - break;
> - }
> - }
> -
> - igt_dynamic_f("pipe-%s-%s-pipe-%s-%s",
> - kmstest_pipe_name(data.pipe1),
> - igt_output_name(first_output),
> - kmstest_pipe_name(data.pipe2),
> - igt_output_name(second_output))
> - test_invalid_modeset(&data);
> - }
> - }
> }
>
> - igt_describe("Verify simultaneous modeset on 2 big joiner outputs");
> - igt_subtest_with_dynamic("2x-modeset") {
> - igt_require_f(count > 1, "2 outputs with big joiner modes are required\n");
> - igt_require_f(data.n_pipes > 3, "Minumum of 4 pipes are required\n");
> - for (i = 0; (i + 2) < data.n_pipes - 1; i++) {
> - data.pipe1 = pipe_seq[i];
> - data.pipe2 = pipe_seq[i + 2];
> - igt_dynamic_f("pipe-%s-%s", kmstest_pipe_name(pipe_seq[i]), kmstest_pipe_name(pipe_seq[i + 2]))
> - test_dual_display(&data);
> - }
> + igt_subtest_with_dynamic("invalid-modeset-bigjoiner") {
> + igt_require_f(data.big_joiner_output_count > 0, "Non big joiner output not found\n");
I think we just need to check if there are 2 outputs or not.
Regards,
Ankit
> + igt_require_f(data.n_pipes > 1, "Minimum of 2 pipes are required\n");
> + if (data.big_joiner_output_count >= 1)
> + igt_dynamic_f("big_joiner_on_last_pipe")
> + tets_big_joiner_on_last_pipe(&data);
> + if (data.big_joiner_output_count > 1)
> + igt_dynamic_f("invalid_combinations")
> + test_invalid_modeset_two_joiner(&data, false);
> + if (data.combined_output_count)
> + igt_dynamic_f("combined_output")
> + test_invalid_modeset_two_joiner(&data, true);
> }
>
> igt_fixture {
> - igt_remove_fb(data.drm_fd, &data.fb);
> igt_display_fini(&data.display);
> drm_close_driver(data.drm_fd);
> }
^ permalink raw reply [flat|nested] 18+ messages in thread
* [PATCH i-g-t 2/4] tests/intel/kms_big_joiner: revamp bigjoiner
2024-03-10 14:27 [PATCH i-g-t 0/4] revamp big joiner test Kunal Joshi
@ 2024-03-10 14:27 ` Kunal Joshi
2024-03-14 8:43 ` Nautiyal, Ankit K
0 siblings, 1 reply; 18+ messages in thread
From: Kunal Joshi @ 2024-03-10 14:27 UTC (permalink / raw)
To: igt-dev
Cc: Kunal Joshi, Stanislav Lisovskiy, Ankit Nautiyal, Karthik B S,
Bhanuprakash Modem
modify test to support simultaneously testing multiple bigjoiner
output and ignoring fused off pipes.
v2: Don't change license (Bhanu)
Print the pipe name (Bhanu)
Remove unwanted commit (Bhanu)
Move combine output logic to igt_fixture (Bhanu)
split revamp and force joiner (Bhanu)
v3: Ignored fused pipes (Stan)
Cc: Stanislav Lisovskiy <stanislav.lisovskiy@intel.com>
Cc: Ankit Nautiyal <ankit.k.nautiyal@intel.com>
Cc: Karthik B S <karthik.b.s@intel.com>
Cc: Bhanuprakash Modem <bhanuprakash.modem@intel.com>
Signed-off-by: Kunal Joshi <kunal1.joshi@intel.com>
Signed-off-by: Stanislav Lisovskiy <stanislav.lisovskiy@intel.com>
---
tests/intel/kms_big_joiner.c | 398 +++++++++++++++++------------------
1 file changed, 195 insertions(+), 203 deletions(-)
diff --git a/tests/intel/kms_big_joiner.c b/tests/intel/kms_big_joiner.c
index 28678b958..d4b0d1100 100644
--- a/tests/intel/kms_big_joiner.c
+++ b/tests/intel/kms_big_joiner.c
@@ -37,184 +37,227 @@
#include "igt.h"
/**
- * SUBTEST: invalid-modeset
+ * SUBTEST: invalid-modeset-bigjoiner
* Description: Verify if the modeset on the adjoining pipe is rejected when
* the pipe is active with a big joiner modeset
*
- * SUBTEST: basic
+ * SUBTEST: basic-bigjoiner
* Description: Verify the basic modeset on big joiner mode on all pipes
*
- * SUBTEST: 2x-modeset
- * Description: Verify simultaneous modeset on 2 big joiner outputs
*/
IGT_TEST_DESCRIPTION("Test big joiner");
-struct bigjoiner_output {
- uint32_t output_id;
- drmModeModeInfo mode;
-};
+#define INVALID_TEST_OUTPUT 2
typedef struct {
int drm_fd;
- igt_display_t display;
- struct igt_fb fb;
+ int big_joiner_output_count;
+ int non_big_joiner_output_count;
+ int combined_output_count;
+ int output_count;
int n_pipes;
- enum pipe pipe1;
- enum pipe pipe2;
- struct bigjoiner_output output[2];
+ int master_pipes;
+ uint64_t big_joiner_output[IGT_MAX_PIPES];
+ uint64_t non_big_joiner_output[IGT_MAX_PIPES];
+ uint64_t combined_output[IGT_MAX_PIPES];
+ enum pipe pipe_seq[IGT_MAX_PIPES];
+ igt_display_t display;
} data_t;
static int max_dotclock;
-static void test_invalid_modeset(data_t *data)
+static void set_all_master_pipes_for_platform(data_t *data)
{
- igt_output_t *output;
- igt_display_t *display = &data->display;
- int ret;
-
- igt_info("Bigjoiner test on ");
- for_each_connected_output(display, output){
- enum pipe p = output->pending_pipe;
- drmModeModeInfo *mode;
- igt_pipe_t *pipe;
- igt_plane_t *plane;
+ enum pipe pipe;
- if (p == PIPE_NONE)
- continue;
-
- mode = igt_output_get_mode(output);
- igt_info("pipe:%s, output:%s, mode:", kmstest_pipe_name(p), igt_output_name(output));
- kmstest_dump_mode(mode);
+ for (pipe = PIPE_A; pipe < IGT_MAX_PIPES; pipe++)
+ if (data->display.pipes[pipe].enabled) {
+ igt_info("Found master pipe %s\n", kmstest_pipe_name(pipe));
+ data->master_pipes |= BIT(pipe);
+ }
+}
- pipe = &display->pipes[p];
- plane = igt_pipe_get_plane_type(pipe, DRM_PLANE_TYPE_PRIMARY);
+static igt_output_t *get_output_by_id_or_assert(data_t *data, uint64_t id)
+{
+ igt_output_t *output;
- igt_plane_set_fb(plane, &data->fb);
- igt_fb_set_size(&data->fb, plane, mode->hdisplay, mode->vdisplay);
- igt_plane_set_size(plane, mode->hdisplay, mode->vdisplay);
+ for_each_connected_output(&data->display, output) {
+ if (output->id == id)
+ return output;
}
+ igt_assert_f(false, "Output not found\n");
+ return NULL;
+}
- igt_assert(!igt_check_bigjoiner_support(display));
-
- /* This commit is expectd to fail as this pipe is being used for big joiner */
- ret = igt_display_try_commit_atomic(display, DRM_MODE_ATOMIC_TEST_ONLY |
- DRM_MODE_ATOMIC_ALLOW_MODESET, NULL);
-
- igt_display_reset(&data->display);
- igt_display_commit2(display, COMMIT_ATOMIC);
+static enum pipe get_next_master_pipe(data_t *data, unsigned int available_pipe_mask)
+{
+ if ((data->master_pipes & available_pipe_mask) == 0)
+ return PIPE_NONE;
- igt_assert_lt(ret, 0);
+ return ffs(data->master_pipes & available_pipe_mask) - 1;
}
-static void test_basic_modeset(data_t *data)
+static void test_single_joiner(data_t *data, int output_count)
{
+ int i, ret;
+ enum pipe pipe, master_pipe;
+ unsigned int available_pipe_mask = BIT(data->n_pipes) - 1;
+ unsigned int attempt_mask;
+ igt_output_t *output;
+ igt_plane_t *primary;
+ uint64_t *outputs;
+ igt_fb_t fb;
drmModeModeInfo *mode;
- igt_output_t *output, *bigjoiner_output = NULL;
- igt_display_t *display = &data->display;
- igt_pipe_t *pipe;
- igt_plane_t *plane;
- igt_display_reset(display);
+ outputs = data->big_joiner_output;
- for_each_connected_output(display, output) {
- if (data->output[0].output_id == output->id) {
- bigjoiner_output = output;
- break;
+ for (i = 0; i < output_count; i++) {
+ output = get_output_by_id_or_assert(data, outputs[i]);
+ for (pipe = 0; pipe < data->n_pipes-1; pipe++) {
+ igt_display_reset(&data->display);
+ attempt_mask = BIT(pipe);
+
+ master_pipe = get_next_master_pipe(data, available_pipe_mask & attempt_mask);
+ if (master_pipe == PIPE_NONE)
+ continue;
+ igt_info("Using pipe %s as master and %s slave for %s\n", kmstest_pipe_name(pipe), kmstest_pipe_name(pipe + 1), output->name);
+ igt_output_set_pipe(output, pipe);
+ mode = igt_output_get_mode(output);
+ primary = igt_output_get_plane_type(output, DRM_PLANE_TYPE_PRIMARY);
+ igt_create_pattern_fb(data->drm_fd, mode->hdisplay, mode->vdisplay, DRM_FORMAT_XRGB8888,
+ DRM_FORMAT_MOD_LINEAR, &fb);
+ igt_plane_set_fb(primary, &fb);
+ ret = igt_display_try_commit2(&data->display, COMMIT_ATOMIC);
+ igt_assert_f(ret == 0, "Commit should have passed\n");
}
}
+}
- igt_output_set_pipe(bigjoiner_output, data->pipe1);
+static void test_multi_joiner(data_t *data, int output_count)
+{
+ int i, ret;
+ unsigned int available_pipe_mask;
+ enum pipe pipe, master_pipe;
+ uint64_t *outputs;
+ igt_output_t *output;
+ igt_plane_t *primary[output_count];
+ igt_fb_t fb[output_count];
+ drmModeModeInfo *mode;
- mode = &data->output[0].mode;
- igt_output_override_mode(bigjoiner_output, mode);
+ available_pipe_mask = BIT(data->n_pipes) - 1;
+ outputs = data->big_joiner_output;
- pipe = &display->pipes[data->pipe1];
- plane = igt_pipe_get_plane_type(pipe, DRM_PLANE_TYPE_PRIMARY);
+ igt_display_reset(&data->display);
+ for (i = 0; i < output_count; i++) {
+ output = get_output_by_id_or_assert(data, outputs[i]);
+ for (pipe = 0; pipe < data->n_pipes; pipe++) {
+ unsigned int attempt_mask = BIT(pipe);
- igt_plane_set_fb(plane, &data->fb);
- igt_fb_set_size(&data->fb, plane, mode->hdisplay, mode->vdisplay);
- igt_plane_set_size(plane, mode->hdisplay, mode->vdisplay);
+ master_pipe = get_next_master_pipe(data, available_pipe_mask & attempt_mask);
+ if (master_pipe == PIPE_NONE)
+ continue;
- igt_display_commit2(display, COMMIT_ATOMIC);
+ igt_info("Using pipe %s as master %s slave for %s\n", kmstest_pipe_name(pipe), kmstest_pipe_name(pipe + 1), output->name);
+ igt_output_set_pipe(output, pipe);
+ mode = igt_output_get_mode(output);
+ primary[i] = igt_output_get_plane_type(output, DRM_PLANE_TYPE_PRIMARY);
+ igt_create_pattern_fb(data->drm_fd, mode->hdisplay, mode->vdisplay, DRM_FORMAT_XRGB8888,
+ DRM_FORMAT_MOD_LINEAR, &fb[i]);
+ igt_plane_set_fb(primary[i], &fb[i]);
- igt_output_set_pipe(bigjoiner_output, PIPE_NONE);
- igt_plane_set_fb(plane, NULL);
- igt_display_commit2(display, COMMIT_ATOMIC);
+ available_pipe_mask &= ~BIT(master_pipe);
+ available_pipe_mask &= ~BIT(master_pipe + 1);
+ break;
+ }
+ }
+ ret = igt_display_try_commit2(&data->display, COMMIT_ATOMIC);
+ igt_assert_f(ret == 0, "Commit should have passed\n");
}
-static void test_dual_display(data_t *data)
+static void test_invalid_modeset_two_joiner(data_t *data,
+ bool combined)
{
+ int i, j, ret;
+ uint64_t *outputs;
+ igt_output_t *output;
+ igt_plane_t *primary[INVALID_TEST_OUTPUT];
+ igt_fb_t fb[INVALID_TEST_OUTPUT];
drmModeModeInfo *mode;
- igt_output_t *output, *bigjoiner_output[2];
- igt_display_t *display = &data->display;
- igt_pipe_t *pipe;
- igt_plane_t *plane1, *plane2;
- int count = 0;
-
- igt_display_reset(display);
-
- for_each_connected_output(display, output) {
- if (data->output[count].output_id == output->id) {
- bigjoiner_output[count] = output;
- count++;
- }
- if (count > 1)
- break;
+ outputs = combined ? data->combined_output : data->big_joiner_output;
+
+ for (i = 0; i < data->n_pipes-1; i++) {
+ igt_display_reset(&data->display);
+ for (j = 0; j < INVALID_TEST_OUTPUT; j++) {
+ output = get_output_by_id_or_assert(data, outputs[j]);
+ igt_assert(output);
+ igt_output_set_pipe(output, data->pipe_seq[i + j]);
+ mode = igt_output_get_mode(output);
+ igt_info(" Assigning pipe %s to %s with mode %dx%d@%d%s",
+ kmstest_pipe_name(data->pipe_seq[i + j]),
+ igt_output_name(output), mode->hdisplay,
+ mode->vdisplay, mode->vrefresh,
+ j == INVALID_TEST_OUTPUT - 1 ? "\n" : ", ");
+ primary[j] = igt_output_get_plane_type(output, DRM_PLANE_TYPE_PRIMARY);
+ igt_create_pattern_fb(data->drm_fd, mode->hdisplay, mode->vdisplay, DRM_FORMAT_XRGB8888,
+ DRM_FORMAT_MOD_LINEAR, &fb[j]);
+ igt_plane_set_fb(primary[j], &fb[j]);
+ }
+ ret = igt_display_try_commit2(&data->display, COMMIT_ATOMIC);
+ igt_assert_f(ret != 0, "Commit shouldn't have passed\n");
}
+}
- igt_output_set_pipe(bigjoiner_output[0], data->pipe1);
- igt_output_set_pipe(bigjoiner_output[1], data->pipe2);
-
- /* Set up first big joiner output on Pipe A*/
- mode = &data->output[0].mode;
- igt_output_override_mode(bigjoiner_output[0], mode);
-
- pipe = &display->pipes[data->pipe1];
- plane1 = igt_pipe_get_plane_type(pipe, DRM_PLANE_TYPE_PRIMARY);
-
- igt_plane_set_fb(plane1, &data->fb);
- igt_fb_set_size(&data->fb, plane1, mode->hdisplay, mode->vdisplay);
- igt_plane_set_size(plane1, mode->hdisplay, mode->vdisplay);
-
- /* Set up second big joiner output on Pipe C*/
- mode = &data->output[1].mode;
- igt_output_override_mode(bigjoiner_output[1], mode);
-
- pipe = &display->pipes[data->pipe2];
- plane2 = igt_pipe_get_plane_type(pipe, DRM_PLANE_TYPE_PRIMARY);
-
- igt_plane_set_fb(plane2, &data->fb);
- igt_fb_set_size(&data->fb, plane2, mode->hdisplay, mode->vdisplay);
- igt_plane_set_size(plane2, mode->hdisplay, mode->vdisplay);
+static void tets_big_joiner_on_last_pipe(data_t *data)
+{
+ int i, len, ret;
+ uint64_t *outputs;
+ igt_output_t *output;
+ igt_plane_t *primary;
+ igt_fb_t fb;
+ drmModeModeInfo *mode;
- igt_display_commit2(display, COMMIT_ATOMIC);
+ len = data->big_joiner_output_count;
+ outputs = data->big_joiner_output;
- /* Clean up */
- igt_output_set_pipe(bigjoiner_output[0], PIPE_NONE);
- igt_output_set_pipe(bigjoiner_output[1], PIPE_NONE);
- igt_plane_set_fb(plane1, NULL);
- igt_plane_set_fb(plane2, NULL);
- igt_display_commit2(display, COMMIT_ATOMIC);
+ for (i = 0; i < len; i++) {
+ igt_display_reset(&data->display);
+ output = get_output_by_id_or_assert(data, outputs[i]);
+ igt_output_set_pipe(output, data->pipe_seq[data->n_pipes - 1]);
+ mode = igt_output_get_mode(output);
+ igt_info(" Assigning pipe %s to %s with mode %dx%d@%d\n",
+ kmstest_pipe_name(data->pipe_seq[data->n_pipes - 1]),
+ igt_output_name(output), mode->hdisplay,
+ mode->vdisplay, mode->vrefresh);
+ primary = igt_output_get_plane_type(output, DRM_PLANE_TYPE_PRIMARY);
+ igt_create_pattern_fb(data->drm_fd, mode->hdisplay, mode->vdisplay, DRM_FORMAT_XRGB8888,
+ DRM_FORMAT_MOD_LINEAR, &fb);
+ igt_plane_set_fb(primary, &fb);
+ ret = igt_display_try_commit2(&data->display, COMMIT_ATOMIC);
+ igt_assert_f(ret != 0, "Commit shouldn't have passed\n");
+ }
}
+
igt_main
{
- data_t data;
+ int i, j;
igt_output_t *output;
- drmModeModeInfo mode;
- int valid_output = 0, i, count = 0, j = 0;
- uint16_t width = 0, height = 0;
- enum pipe pipe_seq[IGT_MAX_PIPES];
+ data_t data;
igt_fixture {
+ data.big_joiner_output_count = 0;
+ data.non_big_joiner_output_count = 0;
+ data.combined_output_count = 0;
+ data.output_count = 0;
+ j = 0;
+
data.drm_fd = drm_open_driver_master(DRIVER_INTEL | DRIVER_XE);
kmstest_set_vt_graphics_mode();
-
igt_display_require(&data.display, data.drm_fd);
+ set_all_master_pipes_for_platform(&data);
igt_require(data.display.is_atomic);
-
max_dotclock = igt_get_max_dotclock(data.drm_fd);
for_each_connected_output(&data.display, output) {
@@ -228,105 +271,54 @@ igt_main
found = bigjoiner_mode_found(data.drm_fd, connector, max_dotclock);
if (found) {
- data.output[count].output_id = output->id;
- memcpy(&data.output[count].mode, &mode, sizeof(drmModeModeInfo));
- count++;
-
- width = max(width, mode.hdisplay);
- height = max(height, mode.vdisplay);
+ data.big_joiner_output[data.big_joiner_output_count++] = output->config.connector->connector_id;
+ igt_output_override_mode(output, &connector->modes[0]);
+ } else {
+ data.non_big_joiner_output[data.non_big_joiner_output_count++] = output->config.connector->connector_id;
}
- valid_output++;
+ data.output_count++;
+ }
+ if (data.big_joiner_output_count == 1 && data.non_big_joiner_output_count >= 1) {
+ data.combined_output[data.combined_output_count++] = data.big_joiner_output[0];
+ data.combined_output[data.combined_output_count++] = data.non_big_joiner_output[0];
}
-
data.n_pipes = 0;
for_each_pipe(&data.display, i) {
data.n_pipes++;
- pipe_seq[j] = i;
+ data.pipe_seq[j] = i;
j++;
}
-
- igt_require_f(count > 0, "No output with 5k+ mode (or) clock > max-dot-clock found\n");
-
- igt_create_pattern_fb(data.drm_fd, width, height, DRM_FORMAT_XRGB8888,
- DRM_FORMAT_MOD_LINEAR, &data.fb);
}
igt_describe("Verify the basic modeset on big joiner mode on all pipes");
- igt_subtest_with_dynamic("basic") {
- for (i = 0; i < data.n_pipes - 1; i++) {
- data.pipe1 = pipe_seq[i];
- igt_dynamic_f("pipe-%s", kmstest_pipe_name(pipe_seq[i]))
- test_basic_modeset(&data);
- }
- }
+ igt_subtest_with_dynamic("basic-bigjoiner") {
+ igt_require_f(data.big_joiner_output_count > 0,
+ "No bigjoiner output found\n");
+ igt_require_f(data.n_pipes > 1,
+ "Minimum 2 pipes required\n");
+ igt_dynamic_f("single-joiner")
+ test_single_joiner(&data, data.big_joiner_output_count);
+ if (data.big_joiner_output_count > 1)
+ igt_dynamic_f("multi-joiner")
+ test_multi_joiner(&data, data.big_joiner_output_count);
- igt_describe("Verify if the modeset on the adjoining pipe is rejected "
- "when the pipe is active with a big joiner modeset");
- igt_subtest_with_dynamic("invalid-modeset") {
- data.pipe1 = pipe_seq[j - 1];
-
- igt_display_reset(&data.display);
- for_each_connected_output(&data.display, output) {
- if (data.output[0].output_id != output->id)
- continue;
-
- mode = data.output[0].mode;
- igt_output_set_pipe(output, data.pipe1);
- igt_output_override_mode(output, &mode);
-
- igt_dynamic_f("pipe-%s-%s",
- kmstest_pipe_name(data.pipe1),
- igt_output_name(output))
- test_invalid_modeset(&data);
- }
-
- if(valid_output > 1) {
- for (i = 0; i < data.n_pipes - 1; i++) {
- igt_output_t *first_output = NULL, *second_output = NULL;
-
- data.pipe1 = pipe_seq[i];
- data.pipe2 = pipe_seq[i + 1];
-
- igt_display_reset(&data.display);
- for_each_connected_output(&data.display, output) {
- if (data.output[0].output_id == output->id) {
- first_output = output;
- mode = data.output[0].mode;
-
- igt_output_set_pipe(output, data.pipe1);
- igt_output_override_mode(output, &mode);
- } else if (second_output == NULL) {
- second_output = output;
- igt_output_set_pipe(output, data.pipe2);
-
- break;
- }
- }
-
- igt_dynamic_f("pipe-%s-%s-pipe-%s-%s",
- kmstest_pipe_name(data.pipe1),
- igt_output_name(first_output),
- kmstest_pipe_name(data.pipe2),
- igt_output_name(second_output))
- test_invalid_modeset(&data);
- }
- }
}
- igt_describe("Verify simultaneous modeset on 2 big joiner outputs");
- igt_subtest_with_dynamic("2x-modeset") {
- igt_require_f(count > 1, "2 outputs with big joiner modes are required\n");
- igt_require_f(data.n_pipes > 3, "Minumum of 4 pipes are required\n");
- for (i = 0; (i + 2) < data.n_pipes - 1; i++) {
- data.pipe1 = pipe_seq[i];
- data.pipe2 = pipe_seq[i + 2];
- igt_dynamic_f("pipe-%s-%s", kmstest_pipe_name(pipe_seq[i]), kmstest_pipe_name(pipe_seq[i + 2]))
- test_dual_display(&data);
- }
+ igt_subtest_with_dynamic("invalid-modeset-bigjoiner") {
+ igt_require_f(data.big_joiner_output_count > 0, "Non big joiner output not found\n");
+ igt_require_f(data.n_pipes > 1, "Minimum of 2 pipes are required\n");
+ if (data.big_joiner_output_count >= 1)
+ igt_dynamic_f("big_joiner_on_last_pipe")
+ tets_big_joiner_on_last_pipe(&data);
+ if (data.big_joiner_output_count > 1)
+ igt_dynamic_f("invalid_combinations")
+ test_invalid_modeset_two_joiner(&data, false);
+ if (data.combined_output_count)
+ igt_dynamic_f("combined_output")
+ test_invalid_modeset_two_joiner(&data, true);
}
igt_fixture {
- igt_remove_fb(data.drm_fd, &data.fb);
igt_display_fini(&data.display);
drm_close_driver(data.drm_fd);
}
--
2.34.1
^ permalink raw reply related [flat|nested] 18+ messages in thread
end of thread, other threads:[~2024-03-28 9:18 UTC | newest]
Thread overview: 18+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-03-25 16:51 [PATCH i-g-t 0/4] revamp big joiner test Kunal Joshi
2024-03-25 16:51 ` [PATCH i-g-t 1/4] lib/igt_kms: move bigjoiner_mode_found to lib Kunal Joshi
2024-03-25 16:51 ` [PATCH i-g-t 2/4] tests/intel/kms_big_joiner: revamp bigjoiner Kunal Joshi
2024-03-28 6:59 ` Nautiyal, Ankit K
2024-03-25 16:51 ` [PATCH i-g-t 3/4] lib/igt_kms: add helper to enable/disable force joiner Kunal Joshi
2024-03-28 7:11 ` Nautiyal, Ankit K
2024-03-25 16:51 ` [PATCH i-g-t 4/4] tests/intel/kms_big_joiner: add tests for " Kunal Joshi
2024-03-28 7:06 ` Nautiyal, Ankit K
2024-03-25 20:52 ` ✓ CI.xeBAT: success for revamp big joiner test (rev9) Patchwork
2024-03-25 20:54 ` ✓ Fi.CI.BAT: " Patchwork
2024-03-26 4:17 ` ✗ Fi.CI.IGT: failure " Patchwork
-- strict thread matches above, loose matches on Subject: below --
2024-03-28 8:39 [PATCH i-g-t 0/4] revamp big joiner test Kunal Joshi
2024-03-28 8:39 ` [PATCH i-g-t 2/4] tests/intel/kms_big_joiner: revamp bigjoiner Kunal Joshi
2024-03-28 9:18 ` Nautiyal, Ankit K
2024-03-21 18:28 [PATCH i-g-t 0/4] revamp big joiner test Kunal Joshi
2024-03-21 18:28 ` [PATCH i-g-t 2/4] tests/intel/kms_big_joiner: revamp bigjoiner Kunal Joshi
2024-03-25 10:16 ` Nautiyal, Ankit K
2024-03-10 14:27 [PATCH i-g-t 0/4] revamp big joiner test Kunal Joshi
2024-03-10 14:27 ` [PATCH i-g-t 2/4] tests/intel/kms_big_joiner: revamp bigjoiner Kunal Joshi
2024-03-14 8:43 ` Nautiyal, Ankit K
2024-03-18 5:26 ` Joshi, Kunal1
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.