From: Michal Simek <michal.simek@xilinx.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] arm64: zynqmp: Fix misspelled choice default
Date: Tue, 30 Jan 2018 14:25:26 +0100 [thread overview]
Message-ID: <32aaac2a-453f-30c8-7382-fb833a6e3224@xilinx.com> (raw)
In-Reply-To: <20180130130201.6291-1-ulfalizer@gmail.com>
On 30.1.2018 14:02, Ulf Magnusson wrote:
> There is no JTAG symbol in the "Boot mode" choice. JTAG_MODE was
> probably intended.
>
> No functional changes. Kconfig choices fall back on using the first
> (visible) symbol in the choice as the default if the default symbol is
> not visible.
>
> Discovered in Kconfiglib (https://github.com/ulfalizer/Kconfiglib),
> which prints the following warning:
>
> warning: the default selection JTAG (undefined) of <choice> (defined at arch/arm/cpu/armv8/zynqmp/Kconfig:107) is not contained in the choice
>
> I've added a corresponding warning to the C tools too, which is
> currently in linux-next: https://patchwork.kernel.org/patch/9983667/
>
> Signed-off-by: Ulf Magnusson <ulfalizer@gmail.com>
> ---
> arch/arm/cpu/armv8/zynqmp/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm/cpu/armv8/zynqmp/Kconfig b/arch/arm/cpu/armv8/zynqmp/Kconfig
> index 3f922b4097..56b7846f63 100644
> --- a/arch/arm/cpu/armv8/zynqmp/Kconfig
> +++ b/arch/arm/cpu/armv8/zynqmp/Kconfig
> @@ -107,7 +107,7 @@ config SPL_ZYNQMP_ALT_BOOTMODE
> choice
> prompt "Boot mode"
> depends on SPL_ZYNQMP_ALT_BOOTMODE_ENABLED
> - default JTAG
> + default JTAG_MODE
>
> config JTAG_MODE
> bool "JTAG_MODE"
>
Applied. How to run this tool inside u-boot?
Thanks,
Michal
next prev parent reply other threads:[~2018-01-30 13:25 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-30 13:02 [U-Boot] [PATCH] arm64: zynqmp: Fix misspelled choice default Ulf Magnusson
2018-01-30 13:25 ` Michal Simek [this message]
2018-01-30 13:38 ` Ulf Magnusson
2018-01-30 13:50 ` Ulf Magnusson
2018-01-30 13:58 ` Michal Simek
2018-01-30 14:05 ` Ulf Magnusson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=32aaac2a-453f-30c8-7382-fb833a6e3224@xilinx.com \
--to=michal.simek@xilinx.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.