* [U-Boot] [PATCH] arm64: zynqmp: Fix misspelled choice default
@ 2018-01-30 13:02 Ulf Magnusson
2018-01-30 13:25 ` Michal Simek
0 siblings, 1 reply; 6+ messages in thread
From: Ulf Magnusson @ 2018-01-30 13:02 UTC (permalink / raw)
To: u-boot
There is no JTAG symbol in the "Boot mode" choice. JTAG_MODE was
probably intended.
No functional changes. Kconfig choices fall back on using the first
(visible) symbol in the choice as the default if the default symbol is
not visible.
Discovered in Kconfiglib (https://github.com/ulfalizer/Kconfiglib),
which prints the following warning:
warning: the default selection JTAG (undefined) of <choice> (defined at arch/arm/cpu/armv8/zynqmp/Kconfig:107) is not contained in the choice
I've added a corresponding warning to the C tools too, which is
currently in linux-next: https://patchwork.kernel.org/patch/9983667/
Signed-off-by: Ulf Magnusson <ulfalizer@gmail.com>
---
arch/arm/cpu/armv8/zynqmp/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm/cpu/armv8/zynqmp/Kconfig b/arch/arm/cpu/armv8/zynqmp/Kconfig
index 3f922b4097..56b7846f63 100644
--- a/arch/arm/cpu/armv8/zynqmp/Kconfig
+++ b/arch/arm/cpu/armv8/zynqmp/Kconfig
@@ -107,7 +107,7 @@ config SPL_ZYNQMP_ALT_BOOTMODE
choice
prompt "Boot mode"
depends on SPL_ZYNQMP_ALT_BOOTMODE_ENABLED
- default JTAG
+ default JTAG_MODE
config JTAG_MODE
bool "JTAG_MODE"
--
2.14.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [U-Boot] [PATCH] arm64: zynqmp: Fix misspelled choice default
2018-01-30 13:02 [U-Boot] [PATCH] arm64: zynqmp: Fix misspelled choice default Ulf Magnusson
@ 2018-01-30 13:25 ` Michal Simek
2018-01-30 13:38 ` Ulf Magnusson
0 siblings, 1 reply; 6+ messages in thread
From: Michal Simek @ 2018-01-30 13:25 UTC (permalink / raw)
To: u-boot
On 30.1.2018 14:02, Ulf Magnusson wrote:
> There is no JTAG symbol in the "Boot mode" choice. JTAG_MODE was
> probably intended.
>
> No functional changes. Kconfig choices fall back on using the first
> (visible) symbol in the choice as the default if the default symbol is
> not visible.
>
> Discovered in Kconfiglib (https://github.com/ulfalizer/Kconfiglib),
> which prints the following warning:
>
> warning: the default selection JTAG (undefined) of <choice> (defined at arch/arm/cpu/armv8/zynqmp/Kconfig:107) is not contained in the choice
>
> I've added a corresponding warning to the C tools too, which is
> currently in linux-next: https://patchwork.kernel.org/patch/9983667/
>
> Signed-off-by: Ulf Magnusson <ulfalizer@gmail.com>
> ---
> arch/arm/cpu/armv8/zynqmp/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm/cpu/armv8/zynqmp/Kconfig b/arch/arm/cpu/armv8/zynqmp/Kconfig
> index 3f922b4097..56b7846f63 100644
> --- a/arch/arm/cpu/armv8/zynqmp/Kconfig
> +++ b/arch/arm/cpu/armv8/zynqmp/Kconfig
> @@ -107,7 +107,7 @@ config SPL_ZYNQMP_ALT_BOOTMODE
> choice
> prompt "Boot mode"
> depends on SPL_ZYNQMP_ALT_BOOTMODE_ENABLED
> - default JTAG
> + default JTAG_MODE
>
> config JTAG_MODE
> bool "JTAG_MODE"
>
Applied. How to run this tool inside u-boot?
Thanks,
Michal
^ permalink raw reply [flat|nested] 6+ messages in thread
* [U-Boot] [PATCH] arm64: zynqmp: Fix misspelled choice default
2018-01-30 13:25 ` Michal Simek
@ 2018-01-30 13:38 ` Ulf Magnusson
2018-01-30 13:50 ` Ulf Magnusson
2018-01-30 13:58 ` Michal Simek
0 siblings, 2 replies; 6+ messages in thread
From: Ulf Magnusson @ 2018-01-30 13:38 UTC (permalink / raw)
To: u-boot
On Tue, Jan 30, 2018 at 2:25 PM, Michal Simek <michal.simek@xilinx.com> wrote:
> On 30.1.2018 14:02, Ulf Magnusson wrote:
>> There is no JTAG symbol in the "Boot mode" choice. JTAG_MODE was
>> probably intended.
>>
>> No functional changes. Kconfig choices fall back on using the first
>> (visible) symbol in the choice as the default if the default symbol is
>> not visible.
>>
>> Discovered in Kconfiglib (https://github.com/ulfalizer/Kconfiglib),
>> which prints the following warning:
>>
>> warning: the default selection JTAG (undefined) of <choice> (defined at arch/arm/cpu/armv8/zynqmp/Kconfig:107) is not contained in the choice
>>
>> I've added a corresponding warning to the C tools too, which is
>> currently in linux-next: https://patchwork.kernel.org/patch/9983667/
>>
>> Signed-off-by: Ulf Magnusson <ulfalizer@gmail.com>
>> ---
>> arch/arm/cpu/armv8/zynqmp/Kconfig | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/arch/arm/cpu/armv8/zynqmp/Kconfig b/arch/arm/cpu/armv8/zynqmp/Kconfig
>> index 3f922b4097..56b7846f63 100644
>> --- a/arch/arm/cpu/armv8/zynqmp/Kconfig
>> +++ b/arch/arm/cpu/armv8/zynqmp/Kconfig
>> @@ -107,7 +107,7 @@ config SPL_ZYNQMP_ALT_BOOTMODE
>> choice
>> prompt "Boot mode"
>> depends on SPL_ZYNQMP_ALT_BOOTMODE_ENABLED
>> - default JTAG
>> + default JTAG_MODE
>>
>> config JTAG_MODE
>> bool "JTAG_MODE"
>>
>
> Applied. How to run this tool inside u-boot?
>
> Thanks,
> Michal
Thanks.
The following should work, in the U-Boot root:
$ pip install kconfiglib
$ UBOOTVERSION=2018.03-rc1 python
>>> import kconfiglib
>>> kconf = kconfiglib.Kconfig()
That will parse the Kconfig files (and generate any parsing-related
errors and warnings). See the documentation for what functionality is
available.
I just set the UBOOTVERSION environment variable to avoid a warning,
since it's referenced inside the Kconfig files (ordinarily it would be
exported from the makefiles). Not sure what actually depends on it.
There's already an old version of Kconfiglib that's used by
tools/genboardscfg.py and some other scripts in U-Boot by the way. If
that one ever starts to feel slow, Kconfiglib 2 should be faster
(though it would require updating genboardscfg.py to the new API).
Cheers,
Ulf
^ permalink raw reply [flat|nested] 6+ messages in thread
* [U-Boot] [PATCH] arm64: zynqmp: Fix misspelled choice default
2018-01-30 13:38 ` Ulf Magnusson
@ 2018-01-30 13:50 ` Ulf Magnusson
2018-01-30 13:58 ` Michal Simek
1 sibling, 0 replies; 6+ messages in thread
From: Ulf Magnusson @ 2018-01-30 13:50 UTC (permalink / raw)
To: u-boot
On Tue, Jan 30, 2018 at 2:38 PM, Ulf Magnusson <ulfalizer@gmail.com> wrote:
> On Tue, Jan 30, 2018 at 2:25 PM, Michal Simek <michal.simek@xilinx.com> wrote:
>> On 30.1.2018 14:02, Ulf Magnusson wrote:
>>> There is no JTAG symbol in the "Boot mode" choice. JTAG_MODE was
>>> probably intended.
>>>
>>> No functional changes. Kconfig choices fall back on using the first
>>> (visible) symbol in the choice as the default if the default symbol is
>>> not visible.
>>>
>>> Discovered in Kconfiglib (https://github.com/ulfalizer/Kconfiglib),
>>> which prints the following warning:
>>>
>>> warning: the default selection JTAG (undefined) of <choice> (defined at arch/arm/cpu/armv8/zynqmp/Kconfig:107) is not contained in the choice
>>>
>>> I've added a corresponding warning to the C tools too, which is
>>> currently in linux-next: https://patchwork.kernel.org/patch/9983667/
>>>
>>> Signed-off-by: Ulf Magnusson <ulfalizer@gmail.com>
>>> ---
>>> arch/arm/cpu/armv8/zynqmp/Kconfig | 2 +-
>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/arch/arm/cpu/armv8/zynqmp/Kconfig b/arch/arm/cpu/armv8/zynqmp/Kconfig
>>> index 3f922b4097..56b7846f63 100644
>>> --- a/arch/arm/cpu/armv8/zynqmp/Kconfig
>>> +++ b/arch/arm/cpu/armv8/zynqmp/Kconfig
>>> @@ -107,7 +107,7 @@ config SPL_ZYNQMP_ALT_BOOTMODE
>>> choice
>>> prompt "Boot mode"
>>> depends on SPL_ZYNQMP_ALT_BOOTMODE_ENABLED
>>> - default JTAG
>>> + default JTAG_MODE
>>>
>>> config JTAG_MODE
>>> bool "JTAG_MODE"
>>>
>>
>> Applied. How to run this tool inside u-boot?
>>
>> Thanks,
>> Michal
>
> Thanks.
>
> The following should work, in the U-Boot root:
>
> $ pip install kconfiglib
> $ UBOOTVERSION=2018.03-rc1 python
> >>> import kconfiglib
> >>> kconf = kconfiglib.Kconfig()
>
> That will parse the Kconfig files (and generate any parsing-related
> errors and warnings). See the documentation for what functionality is
> available.
>
> I just set the UBOOTVERSION environment variable to avoid a warning,
> since it's referenced inside the Kconfig files (ordinarily it would be
> exported from the makefiles). Not sure what actually depends on it.
>
> There's already an old version of Kconfiglib that's used by
> tools/genboardscfg.py and some other scripts in U-Boot by the way. If
> that one ever starts to feel slow, Kconfiglib 2 should be faster
> (though it would require updating genboardscfg.py to the new API).
>
> Cheers,
> Ulf
Looks like this will work as well:
$ UBOOTVERSION=`make ubootversion` python
Cheers,
Ulf
^ permalink raw reply [flat|nested] 6+ messages in thread
* [U-Boot] [PATCH] arm64: zynqmp: Fix misspelled choice default
2018-01-30 13:38 ` Ulf Magnusson
2018-01-30 13:50 ` Ulf Magnusson
@ 2018-01-30 13:58 ` Michal Simek
2018-01-30 14:05 ` Ulf Magnusson
1 sibling, 1 reply; 6+ messages in thread
From: Michal Simek @ 2018-01-30 13:58 UTC (permalink / raw)
To: u-boot
On 30.1.2018 14:38, Ulf Magnusson wrote:
> On Tue, Jan 30, 2018 at 2:25 PM, Michal Simek <michal.simek@xilinx.com> wrote:
>> On 30.1.2018 14:02, Ulf Magnusson wrote:
>>> There is no JTAG symbol in the "Boot mode" choice. JTAG_MODE was
>>> probably intended.
>>>
>>> No functional changes. Kconfig choices fall back on using the first
>>> (visible) symbol in the choice as the default if the default symbol is
>>> not visible.
>>>
>>> Discovered in Kconfiglib (https://github.com/ulfalizer/Kconfiglib),
>>> which prints the following warning:
>>>
>>> warning: the default selection JTAG (undefined) of <choice> (defined at arch/arm/cpu/armv8/zynqmp/Kconfig:107) is not contained in the choice
>>>
>>> I've added a corresponding warning to the C tools too, which is
>>> currently in linux-next: https://patchwork.kernel.org/patch/9983667/
>>>
>>> Signed-off-by: Ulf Magnusson <ulfalizer@gmail.com>
>>> ---
>>> arch/arm/cpu/armv8/zynqmp/Kconfig | 2 +-
>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/arch/arm/cpu/armv8/zynqmp/Kconfig b/arch/arm/cpu/armv8/zynqmp/Kconfig
>>> index 3f922b4097..56b7846f63 100644
>>> --- a/arch/arm/cpu/armv8/zynqmp/Kconfig
>>> +++ b/arch/arm/cpu/armv8/zynqmp/Kconfig
>>> @@ -107,7 +107,7 @@ config SPL_ZYNQMP_ALT_BOOTMODE
>>> choice
>>> prompt "Boot mode"
>>> depends on SPL_ZYNQMP_ALT_BOOTMODE_ENABLED
>>> - default JTAG
>>> + default JTAG_MODE
>>>
>>> config JTAG_MODE
>>> bool "JTAG_MODE"
>>>
>>
>> Applied. How to run this tool inside u-boot?
>>
>> Thanks,
>> Michal
>
> Thanks.
>
> The following should work, in the U-Boot root:
>
> $ pip install kconfiglib
> $ UBOOTVERSION=2018.03-rc1 python
> >>> import kconfiglib
> >>> kconf = kconfiglib.Kconfig()
Nice.
>
> That will parse the Kconfig files (and generate any parsing-related
> errors and warnings). See the documentation for what functionality is
> available.
>
> I just set the UBOOTVERSION environment variable to avoid a warning,
> since it's referenced inside the Kconfig files (ordinarily it would be
> exported from the makefiles). Not sure what actually depends on it.
>
> There's already an old version of Kconfiglib that's used by
> tools/genboardscfg.py and some other scripts in U-Boot by the way. If
> that one ever starts to feel slow, Kconfiglib 2 should be faster
> (though it would require updating genboardscfg.py to the new API).
I see this as the part of buildman and I use this tool quite often but
have never seen this zynqmp error.
I see it as part of genboardscfg and moveconfig but not buildman.
Thanks,
Michal
^ permalink raw reply [flat|nested] 6+ messages in thread
* [U-Boot] [PATCH] arm64: zynqmp: Fix misspelled choice default
2018-01-30 13:58 ` Michal Simek
@ 2018-01-30 14:05 ` Ulf Magnusson
0 siblings, 0 replies; 6+ messages in thread
From: Ulf Magnusson @ 2018-01-30 14:05 UTC (permalink / raw)
To: u-boot
On Tue, Jan 30, 2018 at 2:58 PM, Michal Simek <michal.simek@xilinx.com> wrote:
> On 30.1.2018 14:38, Ulf Magnusson wrote:
>> On Tue, Jan 30, 2018 at 2:25 PM, Michal Simek <michal.simek@xilinx.com> wrote:
>>> On 30.1.2018 14:02, Ulf Magnusson wrote:
>>>> There is no JTAG symbol in the "Boot mode" choice. JTAG_MODE was
>>>> probably intended.
>>>>
>>>> No functional changes. Kconfig choices fall back on using the first
>>>> (visible) symbol in the choice as the default if the default symbol is
>>>> not visible.
>>>>
>>>> Discovered in Kconfiglib (https://github.com/ulfalizer/Kconfiglib),
>>>> which prints the following warning:
>>>>
>>>> warning: the default selection JTAG (undefined) of <choice> (defined at arch/arm/cpu/armv8/zynqmp/Kconfig:107) is not contained in the choice
>>>>
>>>> I've added a corresponding warning to the C tools too, which is
>>>> currently in linux-next: https://patchwork.kernel.org/patch/9983667/
>>>>
>>>> Signed-off-by: Ulf Magnusson <ulfalizer@gmail.com>
>>>> ---
>>>> arch/arm/cpu/armv8/zynqmp/Kconfig | 2 +-
>>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>>>
>>>> diff --git a/arch/arm/cpu/armv8/zynqmp/Kconfig b/arch/arm/cpu/armv8/zynqmp/Kconfig
>>>> index 3f922b4097..56b7846f63 100644
>>>> --- a/arch/arm/cpu/armv8/zynqmp/Kconfig
>>>> +++ b/arch/arm/cpu/armv8/zynqmp/Kconfig
>>>> @@ -107,7 +107,7 @@ config SPL_ZYNQMP_ALT_BOOTMODE
>>>> choice
>>>> prompt "Boot mode"
>>>> depends on SPL_ZYNQMP_ALT_BOOTMODE_ENABLED
>>>> - default JTAG
>>>> + default JTAG_MODE
>>>>
>>>> config JTAG_MODE
>>>> bool "JTAG_MODE"
>>>>
>>>
>>> Applied. How to run this tool inside u-boot?
>>>
>>> Thanks,
>>> Michal
>>
>> Thanks.
>>
>> The following should work, in the U-Boot root:
>>
>> $ pip install kconfiglib
>> $ UBOOTVERSION=2018.03-rc1 python
>> >>> import kconfiglib
>> >>> kconf = kconfiglib.Kconfig()
>
> Nice.
>
>>
>> That will parse the Kconfig files (and generate any parsing-related
>> errors and warnings). See the documentation for what functionality is
>> available.
>>
>> I just set the UBOOTVERSION environment variable to avoid a warning,
>> since it's referenced inside the Kconfig files (ordinarily it would be
>> exported from the makefiles). Not sure what actually depends on it.
>>
>> There's already an old version of Kconfiglib that's used by
>> tools/genboardscfg.py and some other scripts in U-Boot by the way. If
>> that one ever starts to feel slow, Kconfiglib 2 should be faster
>> (though it would require updating genboardscfg.py to the new API).
>
> I see this as the part of buildman and I use this tool quite often but
> have never seen this zynqmp error.
> I see it as part of genboardscfg and moveconfig but not buildman.
>
> Thanks,
> Michal
>
The warning is new in both Kconfiglib and the C tools (only in
linux-next currently), so it won't get generated by anything in U-Boot
at the moment.
Cheers,
Ulf
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2018-01-30 14:05 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-01-30 13:02 [U-Boot] [PATCH] arm64: zynqmp: Fix misspelled choice default Ulf Magnusson
2018-01-30 13:25 ` Michal Simek
2018-01-30 13:38 ` Ulf Magnusson
2018-01-30 13:50 ` Ulf Magnusson
2018-01-30 13:58 ` Michal Simek
2018-01-30 14:05 ` Ulf Magnusson
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.