All of lore.kernel.org
 help / color / mirror / Atom feed
* RE: [RFC]: can-next 2021-04-06: peak_usb cleanups
@ 2021-04-13  7:27 Stéphane Grosjean
  2021-04-13  7:29 ` Marc Kleine-Budde
  0 siblings, 1 reply; 6+ messages in thread
From: Stéphane Grosjean @ 2021-04-13  7:27 UTC (permalink / raw)
  To: Marc Kleine-Budde; +Cc: kernel, linux-can

Hi,

Take the one that best confirms (IMHO I would say "Acked-by").

Regards,

--- Stéphane



            De: Marc Kleine-Budde
Envoyé: Lundi 12 avril 2021 13:03
À: Stéphane Grosjean
Cc: kernel@pengutronix.de; linux-can@vger.kernel.org
Objet: Re: [RFC]: can-next 2021-04-06: peak_usb cleanups




On 12.04.2021 10:45:07, Stéphane Grosjean wrote:

> I've tested that serie of patches with all the CAN-FD USB interfaces

> from PEAK-System GmbH (that is, PCAN-USB FD, PCAN-USB Pro FD, PCAN-USB

> X6 and PCAN-Chip USB) as well as with the CAN 2.0 only USB interfaces

> PCAN-USB and PCAN-USB Pro, and I confirm all of them.



Thanks for testing!



> Do you need my Acked-by and/or Tested-by for each patch?



No need to, I can add them here. What should I add?

Acked-by?

Tested-by?



regards,

Marc



--

Pengutronix e.K.                 | Marc Kleine-Budde           |

Embedded Linux                   | https://www.pengutronix.de  |

Vertretung West/Dortmund         | Phone: +49-231-2826-924     |

Amtsgericht Hildesheim, HRA 2686 | Fax:   +49-5121-206917-5555 |


--
PEAK-System Technik GmbH
Sitz der Gesellschaft Darmstadt - HRB 9183
Geschaeftsfuehrung: Alexander Gach / Uwe Wilhelm
Unsere Datenschutzerklaerung mit wichtigen Hinweisen
zur Behandlung personenbezogener Daten finden Sie unter
www.peak-system.com/Datenschutz.483.0.html

^ permalink raw reply	[flat|nested] 6+ messages in thread
* Re: [RFC]: can-next 2021-04-06: peak_usb cleanups
  2021-04-13  7:27 [RFC]: can-next 2021-04-06: peak_usb cleanups Stéphane Grosjean
@ 2021-04-13  7:29 ` Marc Kleine-Budde
  0 siblings, 0 replies; 6+ messages in thread
From: Marc Kleine-Budde @ 2021-04-13  7:29 UTC (permalink / raw)
  To: Stéphane Grosjean; +Cc: kernel, linux-can


[-- Attachment #1.1: Type: text/plain, Size: 443 bytes --]

On 4/13/21 9:27 AM, Stéphane Grosjean wrote:
> Take the one that best confirms (IMHO I would say "Acked-by").

As you have actually tested, I'll add both :)

Marc

-- 
Pengutronix e.K.                 | Marc Kleine-Budde           |
Embedded Linux                   | https://www.pengutronix.de  |
Vertretung West/Dortmund         | Phone: +49-231-2826-924     |
Amtsgericht Hildesheim, HRA 2686 | Fax:   +49-5121-206917-5555 |


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 6+ messages in thread
* Re: [RFC]: can-next 2021-04-06: peak_usb cleanups
  2021-04-12 10:45 ` Stéphane Grosjean
@ 2021-04-12 11:03   ` Marc Kleine-Budde
  0 siblings, 0 replies; 6+ messages in thread
From: Marc Kleine-Budde @ 2021-04-12 11:03 UTC (permalink / raw)
  To: Stéphane Grosjean; +Cc: kernel, linux-can

[-- Attachment #1: Type: text/plain, Size: 779 bytes --]

On 12.04.2021 10:45:07, Stéphane Grosjean wrote:
> I've tested that serie of patches with all the CAN-FD USB interfaces
> from PEAK-System GmbH (that is, PCAN-USB FD, PCAN-USB Pro FD, PCAN-USB
> X6 and PCAN-Chip USB) as well as with the CAN 2.0 only USB interfaces
> PCAN-USB and PCAN-USB Pro, and I confirm all of them.

Thanks for testing!

> Do you need my Acked-by and/or Tested-by for each patch?

No need to, I can add them here. What should I add?
Acked-by?
Tested-by?

regards,
Marc

-- 
Pengutronix e.K.                 | Marc Kleine-Budde           |
Embedded Linux                   | https://www.pengutronix.de  |
Vertretung West/Dortmund         | Phone: +49-231-2826-924     |
Amtsgericht Hildesheim, HRA 2686 | Fax:   +49-5121-206917-5555 |

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 6+ messages in thread
* RE: [RFC]: can-next 2021-04-06: peak_usb cleanups
  2021-04-06 11:16 Marc Kleine-Budde
  2021-04-12  9:39 ` Marc Kleine-Budde
@ 2021-04-12 10:45 ` Stéphane Grosjean
  2021-04-12 11:03   ` Marc Kleine-Budde
  1 sibling, 1 reply; 6+ messages in thread
From: Stéphane Grosjean @ 2021-04-12 10:45 UTC (permalink / raw)
  To: Marc Kleine-Budde; +Cc: kernel, linux-can

Hello,

Thank you for your time and your work.

I've tested that serie of patches with all the CAN-FD USB interfaces from PEAK-System GmbH (that is, PCAN-USB FD, PCAN-USB Pro FD, PCAN-USB X6 and PCAN-Chip USB) as well as with the CAN 2.0 only USB interfaces PCAN-USB and PCAN-USB Pro, and I confirm all of them.

Do you need my Acked-by and/or Tested-by for each patch?

Regards,

--- Stéphane


De : Marc Kleine-Budde <mkl@pengutronix.de>
Envoyé : mardi 6 avril 2021 13:16
À : linux-can@vger.kernel.org <linux-can@vger.kernel.org>
Cc : kernel@pengutronix.de <kernel@pengutronix.de>; Stéphane Grosjean <s.grosjean@peak-system.com>
Objet : [RFC]: can-next 2021-04-06: peak_usb cleanups

Hello,

this series consist of several cleanups for the peak_usb driver. It
was tested on the peak_usb_fd, but it also does some changes on the
peak_usb, which I don't have access to.

Please test.

regards,
Marc



--
PEAK-System Technik GmbH
Sitz der Gesellschaft Darmstadt - HRB 9183
Geschaeftsfuehrung: Alexander Gach / Uwe Wilhelm
Unsere Datenschutzerklaerung mit wichtigen Hinweisen
zur Behandlung personenbezogener Daten finden Sie unter
www.peak-system.com/Datenschutz.483.0.html

^ permalink raw reply	[flat|nested] 6+ messages in thread
* Re: [RFC]: can-next 2021-04-06: peak_usb cleanups
  2021-04-06 11:16 Marc Kleine-Budde
@ 2021-04-12  9:39 ` Marc Kleine-Budde
  2021-04-12 10:45 ` Stéphane Grosjean
  1 sibling, 0 replies; 6+ messages in thread
From: Marc Kleine-Budde @ 2021-04-12  9:39 UTC (permalink / raw)
  To: linux-can; +Cc: kernel, Stephane Grosjean

[-- Attachment #1: Type: text/plain, Size: 657 bytes --]

On 06.04.2021 13:16:12, Marc Kleine-Budde wrote:
> this series consist of several cleanups for the peak_usb driver. It
> was tested on the peak_usb_fd, but it also does some changes on the
> peak_usb, which I don't have access to.

I'll include the patches 01...06 in my next pull request. I'd like the
others to be tested on real hardware, which I don't have.

regards,
Marc

-- 
Pengutronix e.K.                 | Marc Kleine-Budde           |
Embedded Linux                   | https://www.pengutronix.de  |
Vertretung West/Dortmund         | Phone: +49-231-2826-924     |
Amtsgericht Hildesheim, HRA 2686 | Fax:   +49-5121-206917-5555 |

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 6+ messages in thread
* [RFC]: can-next 2021-04-06: peak_usb cleanups
@ 2021-04-06 11:16 Marc Kleine-Budde
  2021-04-12  9:39 ` Marc Kleine-Budde
  2021-04-12 10:45 ` Stéphane Grosjean
  0 siblings, 2 replies; 6+ messages in thread
From: Marc Kleine-Budde @ 2021-04-06 11:16 UTC (permalink / raw)
  To: linux-can; +Cc: kernel, Stephane Grosjean

Hello,

this series consist of several cleanups for the peak_usb driver. It
was tested on the peak_usb_fd, but it also does some changes on the
peak_usb, which I don't have access to.

Please test.

regards,
Marc




^ permalink raw reply	[flat|nested] 6+ messages in thread
end of thread, other threads:[~2021-04-13  7:29 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-04-13  7:27 [RFC]: can-next 2021-04-06: peak_usb cleanups Stéphane Grosjean
2021-04-13  7:29 ` Marc Kleine-Budde
  -- strict thread matches above, loose matches on Subject: below --
2021-04-06 11:16 Marc Kleine-Budde
2021-04-12  9:39 ` Marc Kleine-Budde
2021-04-12 10:45 ` Stéphane Grosjean
2021-04-12 11:03   ` Marc Kleine-Budde

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.