All of lore.kernel.org
 help / color / mirror / Atom feed
From: Florian Fainelli <f.fainelli-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
To: Jonathan Richardson
	<jonathan.richardson-dY08KVG/lbpWk0Htik3J/w@public.gmane.org>,
	Jassi Brar
	<jassisinghbrar-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Cc: Rob Herring <robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
	Mark Rutland <mark.rutland-5wv7dgnIgG8@public.gmane.org>,
	Ray Jui <rjui-dY08KVG/lbpWk0Htik3J/w@public.gmane.org>,
	Scott Branden <sbranden-dY08KVG/lbpWk0Htik3J/w@public.gmane.org>,
	Jon Mason <jonmason-dY08KVG/lbpWk0Htik3J/w@public.gmane.org>,
	Russell King <linux-I+IVW8TIWO2tmTQ+vhA3Yw@public.gmane.org>,
	Vikram Prakash
	<vikram.prakash-dY08KVG/lbpWk0Htik3J/w@public.gmane.org>,
	devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
	BCM Kernel Feedback
	<bcm-kernel-feedback-list-dY08KVG/lbpWk0Htik3J/w@public.gmane.org>
Subject: Re: [PATCH v3 4/4] ARM: dts: Enable Broadcom iProc mailbox controller
Date: Wed, 25 Jan 2017 16:27:55 -0800	[thread overview]
Message-ID: <32cbeb0b-d27a-58ac-654d-4eadf0cceec7@gmail.com> (raw)
In-Reply-To: <1485390422-3984-5-git-send-email-jonathan.richardson-dY08KVG/lbpWk0Htik3J/w@public.gmane.org>

On 01/25/2017 04:27 PM, Jonathan Richardson wrote:
> Add node for iProc mailbox controller and enable.
> 
> Reviewed-by: Jonathan Richardson <jonathan.richardson-dY08KVG/lbpWk0Htik3J/w@public.gmane.org>
> Reviewed-by: Shreesha Rajashekar <shreesha.rajashekar-dY08KVG/lbpWk0Htik3J/w@public.gmane.org>
> Reviewed-by: Ray Jui <ray.jui-dY08KVG/lbpWk0Htik3J/w@public.gmane.org>
> Tested-by: Jonathan Richardson <jonathan.richardson-dY08KVG/lbpWk0Htik3J/w@public.gmane.org>
> Reviewed-by: Vikram Prakash <vikram.prakash-dY08KVG/lbpWk0Htik3J/w@public.gmane.org>
> Reviewed-by: Scott Branden <scott.branden-dY08KVG/lbpWk0Htik3J/w@public.gmane.org>
> Signed-off-by: Jonathan Richardson <jonathan.richardson-dY08KVG/lbpWk0Htik3J/w@public.gmane.org>
> ---
>  arch/arm/boot/dts/bcm-cygnus.dtsi | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/bcm-cygnus.dtsi b/arch/arm/boot/dts/bcm-cygnus.dtsi
> index cf02271..606e11a 100644
> --- a/arch/arm/boot/dts/bcm-cygnus.dtsi
> +++ b/arch/arm/boot/dts/bcm-cygnus.dtsi
> @@ -121,6 +121,12 @@
>  			      <0x0301d24c 0x2c>;
>  		};
>  
> +		mailbox: mailbox@03024024 {
> +			compatible = "brcm,iproc-mailbox";
> +			reg = <0x03024024 0x8>;
> +			#mbox-cells = <1>;
> +		};

Can you squash this change with the previous one? It seems to me like
you are just removing the interrupt properties, and updating the reg
property to be only 0x8 bytes.

Thank you
-- 
Florian
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

WARNING: multiple messages have this Message-ID (diff)
From: f.fainelli@gmail.com (Florian Fainelli)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v3 4/4] ARM: dts: Enable Broadcom iProc mailbox controller
Date: Wed, 25 Jan 2017 16:27:55 -0800	[thread overview]
Message-ID: <32cbeb0b-d27a-58ac-654d-4eadf0cceec7@gmail.com> (raw)
In-Reply-To: <1485390422-3984-5-git-send-email-jonathan.richardson@broadcom.com>

On 01/25/2017 04:27 PM, Jonathan Richardson wrote:
> Add node for iProc mailbox controller and enable.
> 
> Reviewed-by: Jonathan Richardson <jonathan.richardson@broadcom.com>
> Reviewed-by: Shreesha Rajashekar <shreesha.rajashekar@broadcom.com>
> Reviewed-by: Ray Jui <ray.jui@broadcom.com>
> Tested-by: Jonathan Richardson <jonathan.richardson@broadcom.com>
> Reviewed-by: Vikram Prakash <vikram.prakash@broadcom.com>
> Reviewed-by: Scott Branden <scott.branden@broadcom.com>
> Signed-off-by: Jonathan Richardson <jonathan.richardson@broadcom.com>
> ---
>  arch/arm/boot/dts/bcm-cygnus.dtsi | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/bcm-cygnus.dtsi b/arch/arm/boot/dts/bcm-cygnus.dtsi
> index cf02271..606e11a 100644
> --- a/arch/arm/boot/dts/bcm-cygnus.dtsi
> +++ b/arch/arm/boot/dts/bcm-cygnus.dtsi
> @@ -121,6 +121,12 @@
>  			      <0x0301d24c 0x2c>;
>  		};
>  
> +		mailbox: mailbox at 03024024 {
> +			compatible = "brcm,iproc-mailbox";
> +			reg = <0x03024024 0x8>;
> +			#mbox-cells = <1>;
> +		};

Can you squash this change with the previous one? It seems to me like
you are just removing the interrupt properties, and updating the reg
property to be only 0x8 bytes.

Thank you
-- 
Florian

  parent reply	other threads:[~2017-01-26  0:27 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-01-26  0:26 [PATCH v3 0/4] Add support for Broadcom iProc mailbox controller Jonathan Richardson
2017-01-26  0:26 ` Jonathan Richardson
     [not found] ` <1485390422-3984-1-git-send-email-jonathan.richardson-dY08KVG/lbpWk0Htik3J/w@public.gmane.org>
2017-01-26  0:26   ` [PATCH v3 1/4] dt-bindings: Document Broadcom iProc mailbox controller driver Jonathan Richardson
2017-01-26  0:26     ` Jonathan Richardson
2017-01-26  0:27   ` [PATCH v3 2/4] mailbox: Add " Jonathan Richardson
2017-01-26  0:27     ` Jonathan Richardson
2017-01-26  0:27   ` [PATCH v3 3/4] ARM: dts: Remove Broadcom iProc mailbox controller node Jonathan Richardson
2017-01-26  0:27     ` Jonathan Richardson
2017-01-26  0:27   ` [PATCH v3 4/4] ARM: dts: Enable Broadcom iProc mailbox controller Jonathan Richardson
2017-01-26  0:27     ` Jonathan Richardson
     [not found]     ` <1485390422-3984-5-git-send-email-jonathan.richardson-dY08KVG/lbpWk0Htik3J/w@public.gmane.org>
2017-01-26  0:27       ` Florian Fainelli [this message]
2017-01-26  0:27         ` Florian Fainelli
     [not found]         ` <32cbeb0b-d27a-58ac-654d-4eadf0cceec7-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2017-01-26  2:04           ` Jonathan Richardson
2017-01-26  2:04             ` Jonathan Richardson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=32cbeb0b-d27a-58ac-654d-4eadf0cceec7@gmail.com \
    --to=f.fainelli-re5jqeeqqe8avxtiumwx3w@public.gmane.org \
    --cc=bcm-kernel-feedback-list-dY08KVG/lbpWk0Htik3J/w@public.gmane.org \
    --cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=jassisinghbrar-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
    --cc=jonathan.richardson-dY08KVG/lbpWk0Htik3J/w@public.gmane.org \
    --cc=jonmason-dY08KVG/lbpWk0Htik3J/w@public.gmane.org \
    --cc=linux-I+IVW8TIWO2tmTQ+vhA3Yw@public.gmane.org \
    --cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
    --cc=mark.rutland-5wv7dgnIgG8@public.gmane.org \
    --cc=rjui-dY08KVG/lbpWk0Htik3J/w@public.gmane.org \
    --cc=robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
    --cc=sbranden-dY08KVG/lbpWk0Htik3J/w@public.gmane.org \
    --cc=vikram.prakash-dY08KVG/lbpWk0Htik3J/w@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.