* [meta-mingw] [PATCH] grpc: remove nl2 requirement since it is optional
@ 2021-08-20 20:46 Sinan Kaya
2021-08-21 11:26 ` [yocto] " Richard Purdie
0 siblings, 1 reply; 4+ messages in thread
From: Sinan Kaya @ 2021-08-20 20:46 UTC (permalink / raw)
To: yocto; +Cc: jpewhacker, Sinan Kaya
Signed-off-by: Sinan Kaya <okaya@kernel.org>
---
.../openembedded-layers/recipes-devtools/grpc/grpc_%.bbappend | 3 +++
1 file changed, 3 insertions(+)
diff --git a/dynamic-layers/openembedded-layers/recipes-devtools/grpc/grpc_%.bbappend b/dynamic-layers/openembedded-layers/recipes-devtools/grpc/grpc_%.bbappend
index a72496d..dc0ea42 100644
--- a/dynamic-layers/openembedded-layers/recipes-devtools/grpc/grpc_%.bbappend
+++ b/dynamic-layers/openembedded-layers/recipes-devtools/grpc/grpc_%.bbappend
@@ -1,2 +1,5 @@
+# doesn't build and not required
+DEPENDS:remove:mingw32 = "libnsl2"
+
EXTRA_OECMAKE:remove:mingw32 = "-DBUILD_SHARED_LIBS=ON"
EXTRA_OECMAKE:append:mingw32 = " -DBUILD_SHARED_LIBS=OFF"
--
2.17.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [yocto] [meta-mingw] [PATCH] grpc: remove nl2 requirement since it is optional
2021-08-20 20:46 [meta-mingw] [PATCH] grpc: remove nl2 requirement since it is optional Sinan Kaya
@ 2021-08-21 11:26 ` Richard Purdie
2021-08-21 12:27 ` Joshua Watt
0 siblings, 1 reply; 4+ messages in thread
From: Richard Purdie @ 2021-08-21 11:26 UTC (permalink / raw)
To: Sinan Kaya, yocto; +Cc: jpewhacker
On Fri, 2021-08-20 at 20:46 +0000, Sinan Kaya wrote:
> Signed-off-by: Sinan Kaya <okaya@kernel.org>
> ---
> .../openembedded-layers/recipes-devtools/grpc/grpc_%.bbappend | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/dynamic-layers/openembedded-layers/recipes-devtools/grpc/grpc_%.bbappend b/dynamic-layers/openembedded-layers/recipes-devtools/grpc/grpc_%.bbappend
> index a72496d..dc0ea42 100644
> --- a/dynamic-layers/openembedded-layers/recipes-devtools/grpc/grpc_%.bbappend
> +++ b/dynamic-layers/openembedded-layers/recipes-devtools/grpc/grpc_%.bbappend
> @@ -1,2 +1,5 @@
> +# doesn't build and not required
> +DEPENDS:remove:mingw32 = "libnsl2"
> +
> EXTRA_OECMAKE:remove:mingw32 = "-DBUILD_SHARED_LIBS=ON"
> EXTRA_OECMAKE:append:mingw32 = " -DBUILD_SHARED_LIBS=OFF"
Should we be making that a PACKAGECONFIG which mingw32 could change?
Cheers,
Richard
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [yocto] [meta-mingw] [PATCH] grpc: remove nl2 requirement since it is optional
2021-08-21 11:26 ` [yocto] " Richard Purdie
@ 2021-08-21 12:27 ` Joshua Watt
2021-08-23 3:59 ` Sinan Kaya
0 siblings, 1 reply; 4+ messages in thread
From: Joshua Watt @ 2021-08-21 12:27 UTC (permalink / raw)
To: Richard Purdie; +Cc: Sinan Kaya, yocto
[-- Attachment #1: Type: text/plain, Size: 1184 bytes --]
On Sat, Aug 21, 2021, 6:26 AM Richard Purdie <
richard.purdie@linuxfoundation.org> wrote:
> On Fri, 2021-08-20 at 20:46 +0000, Sinan Kaya wrote:
> > Signed-off-by: Sinan Kaya <okaya@kernel.org>
> > ---
> > .../openembedded-layers/recipes-devtools/grpc/grpc_%.bbappend | 3 +++
> > 1 file changed, 3 insertions(+)
> >
> > diff --git
> a/dynamic-layers/openembedded-layers/recipes-devtools/grpc/grpc_%.bbappend
> b/dynamic-layers/openembedded-layers/recipes-devtools/grpc/grpc_%.bbappend
> > index a72496d..dc0ea42 100644
> > ---
> a/dynamic-layers/openembedded-layers/recipes-devtools/grpc/grpc_%.bbappend
> > +++
> b/dynamic-layers/openembedded-layers/recipes-devtools/grpc/grpc_%.bbappend
> > @@ -1,2 +1,5 @@
> > +# doesn't build and not required
> > +DEPENDS:remove:mingw32 = "libnsl2"
> > +
> > EXTRA_OECMAKE:remove:mingw32 = "-DBUILD_SHARED_LIBS=ON"
> > EXTRA_OECMAKE:append:mingw32 = " -DBUILD_SHARED_LIBS=OFF"
>
> Should we be making that a PACKAGECONFIG which mingw32 could change?
>
Yes, that's a good idea. Sinan, please make that change in meta-oe, then
change this patch to remove it from PACKAGECONFIG
> Cheers,
>
> Richard
>
>
[-- Attachment #2: Type: text/html, Size: 1907 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [yocto] [meta-mingw] [PATCH] grpc: remove nl2 requirement since it is optional
2021-08-21 12:27 ` Joshua Watt
@ 2021-08-23 3:59 ` Sinan Kaya
0 siblings, 0 replies; 4+ messages in thread
From: Sinan Kaya @ 2021-08-23 3:59 UTC (permalink / raw)
To: Joshua Watt, Richard Purdie; +Cc: yocto
On 8/21/2021 3:27 PM, Joshua Watt wrote:
> > EXTRA_OECMAKE:remove:mingw32 = "-DBUILD_SHARED_LIBS=ON"
> > EXTRA_OECMAKE:append:mingw32 = " -DBUILD_SHARED_LIBS=OFF"
>
> Should we be making that a PACKAGECONFIG which mingw32 could change?
>
>
> Yes, that's a good idea. Sinan, please make that change in meta-oe, then
> change this patch to remove it from PACKAGECONFIG
>
Patch sent with subject: [meta-oe][PATCH] grpc: make SHARED library
build optional
I will wait until it gets merged to follow up here.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2021-08-23 3:59 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-08-20 20:46 [meta-mingw] [PATCH] grpc: remove nl2 requirement since it is optional Sinan Kaya
2021-08-21 11:26 ` [yocto] " Richard Purdie
2021-08-21 12:27 ` Joshua Watt
2021-08-23 3:59 ` Sinan Kaya
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.