From: Chao Yu <yuchao0@huawei.com>
To: Damien Le Moal <damien.lemoal@wdc.com>,
Jaegeuk Kim <jaegeuk@kernel.org>,
linux-f2fs-devel@lists.sourceforge.net
Subject: Re: [PATCH 1/5] f2fs-tools: Fix various compilation warnings
Date: Thu, 21 Mar 2019 14:29:26 +0800 [thread overview]
Message-ID: <32fa9697-d57c-6d45-2981-70adfabe9af9@huawei.com> (raw)
In-Reply-To: <20190318063959.21369-2-damien.lemoal@wdc.com>
On 2019/3/18 14:39, Damien Le Moal wrote:
> Avoid various compilation warnings due to strncpy:
>
> libf2fs.c:590:33: warning: ‘snprintf’ output may be truncated before
> the last format character [-Wformat-truncation=]
> snprintf(rootdev, ret, "/dev/%s", buf);
>
> ../include/f2fs_fs.h:1384:2: warning: ‘strncpy’ specified bound
> depends on the length of the source argument [-Wstringop-overflow=]
> strncpy(buf, features, strlen(features) + 1);
>
> f2fstat.c:243:3: warning: ‘strncpy’ output truncated before
> terminating nul copying as many bytes from a string as its length
> [-Wstringop-truncation]
> strncpy(ptr_buf, name[i], strlen(name[i]));
>
> This patch does not change any functionality.
>
> Signed-off-by: Damien Le Moal <damien.lemoal@wdc.com>
Reviewed-by: Chao Yu <yuchao0@huawei.com>
Thanks,
_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
next prev parent reply other threads:[~2019-03-21 6:29 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-18 6:39 [PATCH 0/5] Zoned block device support improvments Damien Le Moal
2019-03-18 6:39 ` [PATCH 1/5] f2fs-tools: Fix various compilation warnings Damien Le Moal
2019-03-21 6:29 ` Chao Yu [this message]
2019-03-18 6:39 ` [PATCH 2/5] f2fs-tools: Add f2fs_io to .gitignore Damien Le Moal
2019-03-21 6:29 ` Chao Yu
2019-03-18 6:39 ` [PATCH 3/5] f2fs-tools: Improve zoned model check Damien Le Moal
2019-03-21 6:32 ` Chao Yu
2019-03-26 18:24 ` Jaegeuk Kim
2019-03-26 22:58 ` Damien Le Moal
2019-03-18 6:39 ` [PATCH 4/5] f2fs-tools: Allow using host-aware devices as regular devices Damien Le Moal
2019-03-21 8:32 ` Chao Yu
2019-03-21 9:29 ` Damien Le Moal
2019-03-21 12:27 ` Chao Yu
2019-03-18 6:39 ` [PATCH 5/5] f2fs-tools: Fix multi-device format with zoned devices Damien Le Moal
2019-03-21 8:41 ` Chao Yu
2019-03-21 9:30 ` Damien Le Moal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=32fa9697-d57c-6d45-2981-70adfabe9af9@huawei.com \
--to=yuchao0@huawei.com \
--cc=damien.lemoal@wdc.com \
--cc=jaegeuk@kernel.org \
--cc=linux-f2fs-devel@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.