* [PATCH] [Outreachy kernel] staging: wfx: alignment should match open parenthesis
@ 2020-03-09 16:45 Payal Kshirsagar
2020-03-09 17:33 ` Jérôme Pouiller
0 siblings, 1 reply; 6+ messages in thread
From: Payal Kshirsagar @ 2020-03-09 16:45 UTC (permalink / raw)
To: jerome.pouiller, gregkh, outreachy-kernel; +Cc: Payal Kshirsagar
Align code to open parenthesis.
Signed-off-by: Payal Kshirsagar <payalskshirsagar1234@gmail.com>
---
drivers/staging/wfx/data_tx.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/wfx/data_tx.c b/drivers/staging/wfx/data_tx.c
index 8b0c52392319..0038dc7666cf 100644
--- a/drivers/staging/wfx/data_tx.c
+++ b/drivers/staging/wfx/data_tx.c
@@ -301,8 +301,8 @@ static void wfx_tx_manage_pm(struct wfx_vif *wvif, struct ieee80211_hdr *hdr,
}
static u8 wfx_tx_get_raw_link_id(struct wfx_vif *wvif,
- struct ieee80211_sta *sta,
- struct ieee80211_hdr *hdr)
+ struct ieee80211_sta *sta,
+ struct ieee80211_hdr *hdr)
{
struct wfx_sta_priv *sta_priv =
sta ? (struct wfx_sta_priv *) &sta->drv_priv : NULL;
@@ -369,7 +369,7 @@ static void wfx_tx_fixup_rates(struct ieee80211_tx_rate *rates)
}
static u8 wfx_tx_get_rate_id(struct wfx_vif *wvif,
- struct ieee80211_tx_info *tx_info)
+ struct ieee80211_tx_info *tx_info)
{
bool tx_policy_renew = false;
u8 rate_id;
--
2.17.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] [Outreachy kernel] staging: wfx: alignment should match open parenthesis
2020-03-09 16:45 [PATCH] [Outreachy kernel] staging: wfx: alignment should match open parenthesis Payal Kshirsagar
@ 2020-03-09 17:33 ` Jérôme Pouiller
0 siblings, 0 replies; 6+ messages in thread
From: Jérôme Pouiller @ 2020-03-09 17:33 UTC (permalink / raw)
To: Payal Kshirsagar; +Cc: gregkh, outreachy-kernel
On Monday 9 March 2020 17:45:15 CET Payal Kshirsagar wrote:
>
> Align code to open parenthesis.
>
> Signed-off-by: Payal Kshirsagar <payalskshirsagar1234@gmail.com>
> ---
> drivers/staging/wfx/data_tx.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/staging/wfx/data_tx.c b/drivers/staging/wfx/data_tx.c
> index 8b0c52392319..0038dc7666cf 100644
> --- a/drivers/staging/wfx/data_tx.c
> +++ b/drivers/staging/wfx/data_tx.c
> @@ -301,8 +301,8 @@ static void wfx_tx_manage_pm(struct wfx_vif *wvif, struct ieee80211_hdr *hdr,
> }
>
> static u8 wfx_tx_get_raw_link_id(struct wfx_vif *wvif,
> - struct ieee80211_sta *sta,
> - struct ieee80211_hdr *hdr)
> + struct ieee80211_sta *sta,
> + struct ieee80211_hdr *hdr)
> {
> struct wfx_sta_priv *sta_priv =
> sta ? (struct wfx_sta_priv *) &sta->drv_priv : NULL;
> @@ -369,7 +369,7 @@ static void wfx_tx_fixup_rates(struct ieee80211_tx_rate *rates)
> }
>
> static u8 wfx_tx_get_rate_id(struct wfx_vif *wvif,
> - struct ieee80211_tx_info *tx_info)
> + struct ieee80211_tx_info *tx_info)
> {
> bool tx_policy_renew = false;
> u8 rate_id;
> --
> 2.17.1
>
Hello Payal,
Thank you for your contribution.
A similar patch has already been submitted a few weeks ago:
https://lkml.org/lkml/2020/2/23/208
Joe Perches has suggested that the patch should address all parenthesis
alignments:
https://lkml.org/lkml/2020/2/24/653
--
Jérôme Pouiller
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] [Outreachy kernel] staging: wfx: alignment should match open parenthesis
2020-03-09 11:53 ` Payal Kshirsagar
@ 2020-03-09 12:58 ` Stefano Brivio
0 siblings, 0 replies; 6+ messages in thread
From: Stefano Brivio @ 2020-03-09 12:58 UTC (permalink / raw)
To: Payal Kshirsagar; +Cc: outreachy-kernel
On Mon, 9 Mar 2020 17:23:42 +0530
Payal Kshirsagar <payalskshirsagar1234@gmail.com> wrote:
> On Mon, Mar 9, 2020, 5:11 PM Stefano Brivio <sbrivio@redhat.com> wrote:
>
> > On Mon, 9 Mar 2020 00:25:18 +0530
> > Payal Kshirsagar <payalskshirsagar1234@gmail.com> wrote:
> >
> > > Align code to open parenthesis.
> > >
> > > Signed-off-by: Payal Kshirsagar <payalskshirsagar1234@gmail.com>
> > > ---
> > > drivers/staging/wfx/data_tx.c | 6 +++---
> > > 1 file changed, 3 insertions(+), 3 deletions(-)
> > >
> > > diff --git a/drivers/staging/wfx/data_tx.c
> > b/drivers/staging/wfx/data_tx.c
> > > index 8b0c52392319..0038dc7666cf 100644
> > > --- a/drivers/staging/wfx/data_tx.c
> > > +++ b/drivers/staging/wfx/data_tx.c
> > > @@ -301,8 +301,8 @@ static void wfx_tx_manage_pm(struct wfx_vif *wvif,
> > struct ieee80211_hdr *hdr,
> > > }
> > >
> > > static u8 wfx_tx_get_raw_link_id(struct wfx_vif *wvif,
> > > - struct ieee80211_sta *sta,
> > > - struct ieee80211_hdr *hdr)
> > > + struct ieee80211_sta *sta,
> > > + struct ieee80211_hdr *hdr)
> > > {
> > > struct wfx_sta_priv *sta_priv =
> > > sta ? (struct wfx_sta_priv *) &sta->drv_priv : NULL;
> > > @@ -369,7 +369,7 @@ static void wfx_tx_fixup_rates(struct
> > ieee80211_tx_rate *rates)
> > > }
> > >
> > > static u8 wfx_tx_get_rate_id(struct wfx_vif *wvif,
> > > - struct ieee80211_tx_info *tx_info)
> > > + struct ieee80211_tx_info *tx_info)
> > > {
> > > bool tx_policy_renew = false;
> > > u8 rate_id;
> >
> > Change looks good, more Cc:'s needed.
> >
>
> Is is needed to resend all these patches to send them to the other
> maintainers?
I think it would be nice, yes.
--
Stefano
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] [Outreachy kernel] staging: wfx: alignment should match open parenthesis
2020-03-09 11:41 ` Stefano Brivio
@ 2020-03-09 11:53 ` Payal Kshirsagar
2020-03-09 12:58 ` Stefano Brivio
0 siblings, 1 reply; 6+ messages in thread
From: Payal Kshirsagar @ 2020-03-09 11:53 UTC (permalink / raw)
To: Stefano Brivio; +Cc: outreachy-kernel
[-- Attachment #1: Type: text/plain, Size: 1664 bytes --]
On Mon, Mar 9, 2020, 5:11 PM Stefano Brivio <sbrivio@redhat.com> wrote:
> On Mon, 9 Mar 2020 00:25:18 +0530
> Payal Kshirsagar <payalskshirsagar1234@gmail.com> wrote:
>
> > Align code to open parenthesis.
> >
> > Signed-off-by: Payal Kshirsagar <payalskshirsagar1234@gmail.com>
> > ---
> > drivers/staging/wfx/data_tx.c | 6 +++---
> > 1 file changed, 3 insertions(+), 3 deletions(-)
> >
> > diff --git a/drivers/staging/wfx/data_tx.c
> b/drivers/staging/wfx/data_tx.c
> > index 8b0c52392319..0038dc7666cf 100644
> > --- a/drivers/staging/wfx/data_tx.c
> > +++ b/drivers/staging/wfx/data_tx.c
> > @@ -301,8 +301,8 @@ static void wfx_tx_manage_pm(struct wfx_vif *wvif,
> struct ieee80211_hdr *hdr,
> > }
> >
> > static u8 wfx_tx_get_raw_link_id(struct wfx_vif *wvif,
> > - struct ieee80211_sta *sta,
> > - struct ieee80211_hdr *hdr)
> > + struct ieee80211_sta *sta,
> > + struct ieee80211_hdr *hdr)
> > {
> > struct wfx_sta_priv *sta_priv =
> > sta ? (struct wfx_sta_priv *) &sta->drv_priv : NULL;
> > @@ -369,7 +369,7 @@ static void wfx_tx_fixup_rates(struct
> ieee80211_tx_rate *rates)
> > }
> >
> > static u8 wfx_tx_get_rate_id(struct wfx_vif *wvif,
> > - struct ieee80211_tx_info *tx_info)
> > + struct ieee80211_tx_info *tx_info)
> > {
> > bool tx_policy_renew = false;
> > u8 rate_id;
>
> Change looks good, more Cc:'s needed.
>
Is is needed to resend all these patches to send them to the other
maintainers?
Payal
--
> Stefano
>
>
[-- Attachment #2: Type: text/html, Size: 2762 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] [Outreachy kernel] staging: wfx: alignment should match open parenthesis
2020-03-08 18:55 Payal Kshirsagar
@ 2020-03-09 11:41 ` Stefano Brivio
2020-03-09 11:53 ` Payal Kshirsagar
0 siblings, 1 reply; 6+ messages in thread
From: Stefano Brivio @ 2020-03-09 11:41 UTC (permalink / raw)
To: Payal Kshirsagar; +Cc: outreachy-kernel
On Mon, 9 Mar 2020 00:25:18 +0530
Payal Kshirsagar <payalskshirsagar1234@gmail.com> wrote:
> Align code to open parenthesis.
>
> Signed-off-by: Payal Kshirsagar <payalskshirsagar1234@gmail.com>
> ---
> drivers/staging/wfx/data_tx.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/staging/wfx/data_tx.c b/drivers/staging/wfx/data_tx.c
> index 8b0c52392319..0038dc7666cf 100644
> --- a/drivers/staging/wfx/data_tx.c
> +++ b/drivers/staging/wfx/data_tx.c
> @@ -301,8 +301,8 @@ static void wfx_tx_manage_pm(struct wfx_vif *wvif, struct ieee80211_hdr *hdr,
> }
>
> static u8 wfx_tx_get_raw_link_id(struct wfx_vif *wvif,
> - struct ieee80211_sta *sta,
> - struct ieee80211_hdr *hdr)
> + struct ieee80211_sta *sta,
> + struct ieee80211_hdr *hdr)
> {
> struct wfx_sta_priv *sta_priv =
> sta ? (struct wfx_sta_priv *) &sta->drv_priv : NULL;
> @@ -369,7 +369,7 @@ static void wfx_tx_fixup_rates(struct ieee80211_tx_rate *rates)
> }
>
> static u8 wfx_tx_get_rate_id(struct wfx_vif *wvif,
> - struct ieee80211_tx_info *tx_info)
> + struct ieee80211_tx_info *tx_info)
> {
> bool tx_policy_renew = false;
> u8 rate_id;
Change looks good, more Cc:'s needed.
--
Stefano
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH] [Outreachy kernel] staging: wfx: alignment should match open parenthesis
@ 2020-03-08 18:55 Payal Kshirsagar
2020-03-09 11:41 ` Stefano Brivio
0 siblings, 1 reply; 6+ messages in thread
From: Payal Kshirsagar @ 2020-03-08 18:55 UTC (permalink / raw)
To: outreachy-kernel; +Cc: Payal Kshirsagar
Align code to open parenthesis.
Signed-off-by: Payal Kshirsagar <payalskshirsagar1234@gmail.com>
---
drivers/staging/wfx/data_tx.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/wfx/data_tx.c b/drivers/staging/wfx/data_tx.c
index 8b0c52392319..0038dc7666cf 100644
--- a/drivers/staging/wfx/data_tx.c
+++ b/drivers/staging/wfx/data_tx.c
@@ -301,8 +301,8 @@ static void wfx_tx_manage_pm(struct wfx_vif *wvif, struct ieee80211_hdr *hdr,
}
static u8 wfx_tx_get_raw_link_id(struct wfx_vif *wvif,
- struct ieee80211_sta *sta,
- struct ieee80211_hdr *hdr)
+ struct ieee80211_sta *sta,
+ struct ieee80211_hdr *hdr)
{
struct wfx_sta_priv *sta_priv =
sta ? (struct wfx_sta_priv *) &sta->drv_priv : NULL;
@@ -369,7 +369,7 @@ static void wfx_tx_fixup_rates(struct ieee80211_tx_rate *rates)
}
static u8 wfx_tx_get_rate_id(struct wfx_vif *wvif,
- struct ieee80211_tx_info *tx_info)
+ struct ieee80211_tx_info *tx_info)
{
bool tx_policy_renew = false;
u8 rate_id;
--
2.17.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
end of thread, other threads:[~2020-03-09 17:35 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-03-09 16:45 [PATCH] [Outreachy kernel] staging: wfx: alignment should match open parenthesis Payal Kshirsagar
2020-03-09 17:33 ` Jérôme Pouiller
-- strict thread matches above, loose matches on Subject: below --
2020-03-08 18:55 Payal Kshirsagar
2020-03-09 11:41 ` Stefano Brivio
2020-03-09 11:53 ` Payal Kshirsagar
2020-03-09 12:58 ` Stefano Brivio
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.