Re: [PATCH v3 00/20] virtio-mem: Paravirtualized memory hot(un)plug

From: David Hildenbrand <david@redhat.com>
To: Eduardo Habkost <ehabkost@redhat.com>,
	"Michael S. Tsirkin" <mst@redhat.com>
Cc: qemu-devel@nongnu.org, kvm@vger.kernel.org,
	qemu-s390x@nongnu.org, Richard Henderson <rth@twiddle.net>,
	Paolo Bonzini <pbonzini@redhat.com>,
	"Dr . David Alan Gilbert" <dgilbert@redhat.com>,
	teawater <teawaterz@linux.alibaba.com>,
	Pankaj Gupta <pankaj.gupta.linux@gmail.com>,
	Alex Williamson <alex.williamson@redhat.com>,
	Christian Borntraeger <borntraeger@de.ibm.com>,
	Cornelia Huck <cohuck@redhat.com>, Eric Blake <eblake@redhat.com>,
	Eric Farman <farman@linux.ibm.com>,
	Hailiang Zhang <zhang.zhanghailiang@huawei.com>,
	Halil Pasic <pasic@linux.ibm.com>,
	Igor Mammedov <imammedo@redhat.com>,
	Janosch Frank <frankja@linux.ibm.com>,
	Juan Quintela <quintela@redhat.com>,
	Keith Busch <kbusch@kernel.org>,
	Marcel Apfelbaum <marcel.apfelbaum@gmail.com>,
	Markus Armbruster <armbru@redhat.com>,
	Peter Maydell <peter.maydell@linaro.org>,
	Pierre Morel <pmorel@linux.ibm.com>,
	Tony Krowiak <akrowiak@linux.ibm.com>
Subject: Re: [PATCH v3 00/20] virtio-mem: Paravirtualized memory hot(un)plug
Date: Tue, 9 Jun 2020 20:38:15 +0200	[thread overview]
Message-ID: <33021b38-cf60-fbfc-1baa-478ee6eed376@redhat.com> (raw)
In-Reply-To: <20200609161814.GJ2366737@habkost.net>

On 09.06.20 18:18, Eduardo Habkost wrote:
> On Tue, Jun 09, 2020 at 11:59:04AM -0400, Michael S. Tsirkin wrote:
>> On Tue, Jun 09, 2020 at 03:26:08PM +0200, David Hildenbrand wrote:
>>> On 09.06.20 15:11, Michael S. Tsirkin wrote:
>>>> On Wed, Jun 03, 2020 at 04:48:54PM +0200, David Hildenbrand wrote:
>>>>> This is the very basic, initial version of virtio-mem. More info on
>>>>> virtio-mem in general can be found in the Linux kernel driver v2 posting
>>>>> [1] and in patch #10. The latest Linux driver v4 can be found at [2].
>>>>>
>>>>> This series is based on [3]:
>>>>>     "[PATCH v1] pc: Support coldplugging of virtio-pmem-pci devices on all
>>>>>      buses"
>>>>>
>>>>> The patches can be found at:
>>>>>     https://github.com/davidhildenbrand/qemu.git virtio-mem-v3
>>>>
>>>> So given we tweaked the config space a bit, this needs a respin.
>>>
>>> Yeah, the virtio-mem-v4 branch already contains a fixed-up version. Will
>>> send during the next days.
>>
>> BTW. People don't normally capitalize the letter after ":".
>> So a better subject is
>>   virtio-mem: paravirtualized memory hot(un)plug
> 
> I'm not sure that's still the rule:
> 
> [qemu/(49ee115552...)]$ git log --oneline v4.0.0.. | egrep ': [A-Z]' | wc -l
> 5261
> [qemu/(49ee115552...)]$ git log --oneline v4.0.0.. | egrep ': [a-z]' | wc -l
> 2921
> 

Yeah, I switched to this scheme some years ago (I even remember that
some QEMU maintainer recommended it). I decided to just always
capitalize. Not that it should really matter ... :)

-- 
Thanks,

David / dhildenb