From: "AnilKumar, Chimata" <anilkumar@ti.com>
To: Mark Brown <broonie@opensource.wolfsonmicro.com>
Cc: "rdunlap@xenotime.net" <rdunlap@xenotime.net>,
"sfr@canb.auug.org.au" <sfr@canb.auug.org.au>,
"sameo@linux.intel.com" <sameo@linux.intel.com>,
"linux-next@vger.kernel.org" <linux-next@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-omap@vger.kernel.org" <linux-omap@vger.kernel.org>
Subject: RE: [PATCH] regulator: tps65217: fix build error if REGULATOR is not enabled
Date: Wed, 18 Jul 2012 09:55:57 +0000 [thread overview]
Message-ID: <331ABD5ECB02734CA317220B2BBEABC13E9F8BD7@DBDE01.ent.ti.com> (raw)
In-Reply-To: <20120718094449.GA22739@opensource.wolfsonmicro.com>
Mark,
On Wed, Jul 18, 2012 at 15:14:49, Mark Brown wrote:
> On Wed, Jul 18, 2012 at 12:11:03PM +0530, AnilKumar Ch wrote:
> > Fixes below build error if CONFIG_REGULATOR is not enabled.
> >
> > drivers/built-in.o: In function `tps65217_probe':
> > tps65217.c:(.devinit.text+0x13e37): undefined reference to `of_regulator_match'
>
> This isn't a patch to the regulator driver, this is a patch to the MFD.
> Normally this would be fixed by making the MFD driver not depend on the
> regulator API - why is the MFD driver using the regulator API?
>
Regulators platform data is added to platform device in MFD driver, which we
need for regulator driver, of_regulator_match() is used to check the regulator
consumers if we pass DT data. If we do not enable CONFIG_REGULATOR then
of_regulator_match() is not exported, so we see this error.
Regards
AnilKumar
next prev parent reply other threads:[~2012-07-18 9:56 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-18 6:41 [PATCH] regulator: tps65217: fix build error if REGULATOR is not enabled AnilKumar Ch
2012-07-18 6:41 ` AnilKumar Ch
2012-07-18 9:44 ` Mark Brown
2012-07-18 9:55 ` AnilKumar, Chimata [this message]
2012-07-18 10:00 ` Mark Brown
2012-07-19 12:35 ` AnilKumar, Chimata
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=331ABD5ECB02734CA317220B2BBEABC13E9F8BD7@DBDE01.ent.ti.com \
--to=anilkumar@ti.com \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=rdunlap@xenotime.net \
--cc=sameo@linux.intel.com \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.