All of lore.kernel.org
 help / color / mirror / Atom feed
From: "AnilKumar, Chimata" <anilkumar@ti.com>
To: Mark Brown <broonie@opensource.wolfsonmicro.com>
Cc: "rdunlap@xenotime.net" <rdunlap@xenotime.net>,
	"sfr@canb.auug.org.au" <sfr@canb.auug.org.au>,
	"sameo@linux.intel.com" <sameo@linux.intel.com>,
	"linux-next@vger.kernel.org" <linux-next@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"linux-omap@vger.kernel.org" <linux-omap@vger.kernel.org>
Subject: RE: [PATCH] regulator: tps65217: fix build error if REGULATOR is not enabled
Date: Thu, 19 Jul 2012 12:35:24 +0000	[thread overview]
Message-ID: <331ABD5ECB02734CA317220B2BBEABC13E9F98DB@DBDE01.ent.ti.com> (raw)
In-Reply-To: <20120718100013.GC22739@opensource.wolfsonmicro.com>

Hi Mark,

On Wed, Jul 18, 2012 at 15:30:13, Mark Brown wrote:
> On Wed, Jul 18, 2012 at 09:55:57AM +0000, AnilKumar, Chimata wrote:
> 
> > Regulators platform data is added to platform device in MFD driver, which we
> > need for regulator driver, of_regulator_match() is used to check the regulator
> > consumers if we pass DT data. If we do not enable CONFIG_REGULATOR then
> > of_regulator_match() is not exported, so we see this error.
> 
> Why are you doing that in the MFD driver?
> 

I got your point, I referred tps6586x driver while developing the initial driver.
Based on tps6586x MFD driver I added REGULATOR flag. I think tps6586x MFD driver
need to be cleaned up.

I will submit a patch to make tps65217 MFD driver independent of REGULATOR
framework.

Thanks
AnilKumar

      reply	other threads:[~2012-07-19 12:35 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-07-18  6:41 [PATCH] regulator: tps65217: fix build error if REGULATOR is not enabled AnilKumar Ch
2012-07-18  6:41 ` AnilKumar Ch
2012-07-18  9:44 ` Mark Brown
2012-07-18  9:55   ` AnilKumar, Chimata
2012-07-18 10:00     ` Mark Brown
2012-07-19 12:35       ` AnilKumar, Chimata [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=331ABD5ECB02734CA317220B2BBEABC13E9F98DB@DBDE01.ent.ti.com \
    --to=anilkumar@ti.com \
    --cc=broonie@opensource.wolfsonmicro.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-next@vger.kernel.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=rdunlap@xenotime.net \
    --cc=sameo@linux.intel.com \
    --cc=sfr@canb.auug.org.au \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.