* [PATCH 0/4] Add AM33XX regulators device tree data @ 2012-07-20 6:46 ` AnilKumar Ch 0 siblings, 0 replies; 34+ messages in thread From: AnilKumar Ch @ 2012-07-20 6:46 UTC (permalink / raw) To: tony; +Cc: linux-arm-kernel, linux-omap, broonie, AnilKumar Ch This patch series add AM33XX regulators (tps65910/tps65217) device tree data to am335x-evm and am335x-bone dts files. These patches are based on Tony L "devel-dt" tree and tested on AM335x EVM and Bone devices. Resending patch 1 & 2 to group all the regulator DT data files. AnilKumar Ch (4): ARM: OMAP2+: AM33XX: Add tps65910 device tree data ARM: OMAP2+: AM33XX: Add tps65217 device tree data arm/dts: Add tps65910 regulator DT data to am335x-evm.dts arm/dts: Add tps65217 regulator DT data to am335x-bone.dts arch/arm/boot/dts/am335x-bone.dts | 10 +++ arch/arm/boot/dts/am335x-evm.dts | 10 +++ arch/arm/boot/dts/tps65217.dtsi | 84 +++++++++++++++++++++++++ arch/arm/boot/dts/tps65910.dtsi | 123 +++++++++++++++++++++++++++++++++++++ 4 files changed, 227 insertions(+), 0 deletions(-) create mode 100644 arch/arm/boot/dts/tps65217.dtsi create mode 100644 arch/arm/boot/dts/tps65910.dtsi ^ permalink raw reply [flat|nested] 34+ messages in thread
* [PATCH 0/4] Add AM33XX regulators device tree data @ 2012-07-20 6:46 ` AnilKumar Ch 0 siblings, 0 replies; 34+ messages in thread From: AnilKumar Ch @ 2012-07-20 6:46 UTC (permalink / raw) To: linux-arm-kernel This patch series add AM33XX regulators (tps65910/tps65217) device tree data to am335x-evm and am335x-bone dts files. These patches are based on Tony L "devel-dt" tree and tested on AM335x EVM and Bone devices. Resending patch 1 & 2 to group all the regulator DT data files. AnilKumar Ch (4): ARM: OMAP2+: AM33XX: Add tps65910 device tree data ARM: OMAP2+: AM33XX: Add tps65217 device tree data arm/dts: Add tps65910 regulator DT data to am335x-evm.dts arm/dts: Add tps65217 regulator DT data to am335x-bone.dts arch/arm/boot/dts/am335x-bone.dts | 10 +++ arch/arm/boot/dts/am335x-evm.dts | 10 +++ arch/arm/boot/dts/tps65217.dtsi | 84 +++++++++++++++++++++++++ arch/arm/boot/dts/tps65910.dtsi | 123 +++++++++++++++++++++++++++++++++++++ 4 files changed, 227 insertions(+), 0 deletions(-) create mode 100644 arch/arm/boot/dts/tps65217.dtsi create mode 100644 arch/arm/boot/dts/tps65910.dtsi ^ permalink raw reply [flat|nested] 34+ messages in thread
* [PATCH RESEND 1/4] ARM: OMAP2+: AM33XX: Add tps65910 device tree data 2012-07-20 6:46 ` AnilKumar Ch @ 2012-07-20 6:46 ` AnilKumar Ch -1 siblings, 0 replies; 34+ messages in thread From: AnilKumar Ch @ 2012-07-20 6:46 UTC (permalink / raw) To: tony; +Cc: linux-arm-kernel, linux-omap, broonie, AnilKumar Ch Add device tree data for tps65910 regulator by adding all the consumers necessary for AM335X-EVM. The data will be map to a regulator constraints which is required for regulator set_voltage and get_voltage calls. All tps65910 PMIC regulator constraints are placed in a seperate device tree include file (tps65910.dtsi). This patch is tested by adding the I2C slave address of TPS65910 pmic to am335x-evm.dts file (Not included in this, I2C slave addition patch will be submitted to linux-omap, where am335x-evm.dts binding file is available). Signed-off-by: AnilKumar Ch <anilkumar@ti.com> --- arch/arm/boot/dts/tps65910.dtsi | 123 +++++++++++++++++++++++++++++++++++++++ 1 files changed, 123 insertions(+), 0 deletions(-) create mode 100644 arch/arm/boot/dts/tps65910.dtsi diff --git a/arch/arm/boot/dts/tps65910.dtsi b/arch/arm/boot/dts/tps65910.dtsi new file mode 100644 index 0000000..b185235 --- /dev/null +++ b/arch/arm/boot/dts/tps65910.dtsi @@ -0,0 +1,123 @@ +/* + * Copyright (C) 2012 Texas Instruments Incorporated - http://www.ti.com/ + * + * This program is free software; you can redistribute it and/or modify + * it under the terms of the GNU General Public License version 2 as + * published by the Free Software Foundation. + */ + +/* + * Integrated Power Management Chip + * http://www.ti.com/lit/ds/symlink/tps65910.pdf + */ + +&tps { + compatible = "ti,tps65910"; + + regulators { + #address-cells = <1>; + #size-cells = <0>; + + vrtc_reg: regulator@0 { + reg = <0>; + regulator-compatible = "vrtc"; + regulator-always-on; + }; + + vio_reg: regulator@1 { + reg = <1>; + regulator-compatible = "vio"; + regulator-min-microvolt = <1500000>; + regulator-max-microvolt = <3300000>; + regulator-always-on; + }; + + vdd1_reg: regulator@2 { + reg = <2>; + regulator-compatible = "vdd1"; + regulator-min-microvolt = <600000>; + regulator-max-microvolt = <1500000>; + regulator-boot-on; + regulator-always-on; + }; + + vdd2_reg: regulator@3 { + reg = <3>; + regulator-compatible = "vdd2"; + regulator-min-microvolt = <600000>; + regulator-max-microvolt = <1500000>; + regulator-boot-on; + regulator-always-on; + }; + + vdd3_reg: regulator@4 { + reg = <4>; + regulator-compatible = "vdd3"; + regulator-always-on; + }; + + vdig1_reg: regulator@5 { + reg = <5>; + regulator-compatible = "vdig1"; + regulator-min-microvolt = <1200000>; + regulator-max-microvolt = <2700000>; + regulator-always-on; + }; + + vdig2_reg: regulator@6 { + reg = <6>; + regulator-compatible = "vdig2"; + regulator-min-microvolt = <1000000>; + regulator-max-microvolt = <1800000>; + regulator-always-on; + }; + + vpll_reg: regulator@7 { + reg = <7>; + regulator-compatible = "vpll"; + regulator-min-microvolt = <1000000>; + regulator-max-microvolt = <2500000>; + regulator-always-on; + }; + + vdac_reg: regulator@8 { + reg = <8>; + regulator-compatible = "vdac"; + regulator-min-microvolt = <1800000>; + regulator-max-microvolt = <2850000>; + regulator-always-on; + }; + + vaux1_reg: regulator@9 { + reg = <9>; + regulator-compatible = "vaux1"; + regulator-min-microvolt = <1800000>; + regulator-max-microvolt = <2850000>; + regulator-always-on; + }; + + vaux2_reg: regulator@10 { + reg = <10>; + regulator-compatible = "vaux2"; + regulator-min-microvolt = <1800000>; + regulator-max-microvolt = <3300000>; + regulator-always-on; + }; + + vaux33_reg: regulator@11 { + reg = <11>; + regulator-compatible = "vaux33"; + regulator-min-microvolt = <1800000>; + regulator-max-microvolt = <3300000>; + regulator-always-on; + }; + + vmmc_reg: regulator@12 { + reg = <12>; + regulator-compatible = "vmmc"; + regulator-min-microvolt = <1800000>; + regulator-max-microvolt = <3300000>; + regulator-always-on; + }; + }; +}; -- 1.7.0.4 ^ permalink raw reply related [flat|nested] 34+ messages in thread
* [PATCH RESEND 1/4] ARM: OMAP2+: AM33XX: Add tps65910 device tree data @ 2012-07-20 6:46 ` AnilKumar Ch 0 siblings, 0 replies; 34+ messages in thread From: AnilKumar Ch @ 2012-07-20 6:46 UTC (permalink / raw) To: linux-arm-kernel Add device tree data for tps65910 regulator by adding all the consumers necessary for AM335X-EVM. The data will be map to a regulator constraints which is required for regulator set_voltage and get_voltage calls. All tps65910 PMIC regulator constraints are placed in a seperate device tree include file (tps65910.dtsi). This patch is tested by adding the I2C slave address of TPS65910 pmic to am335x-evm.dts file (Not included in this, I2C slave addition patch will be submitted to linux-omap, where am335x-evm.dts binding file is available). Signed-off-by: AnilKumar Ch <anilkumar@ti.com> --- arch/arm/boot/dts/tps65910.dtsi | 123 +++++++++++++++++++++++++++++++++++++++ 1 files changed, 123 insertions(+), 0 deletions(-) create mode 100644 arch/arm/boot/dts/tps65910.dtsi diff --git a/arch/arm/boot/dts/tps65910.dtsi b/arch/arm/boot/dts/tps65910.dtsi new file mode 100644 index 0000000..b185235 --- /dev/null +++ b/arch/arm/boot/dts/tps65910.dtsi @@ -0,0 +1,123 @@ +/* + * Copyright (C) 2012 Texas Instruments Incorporated - http://www.ti.com/ + * + * This program is free software; you can redistribute it and/or modify + * it under the terms of the GNU General Public License version 2 as + * published by the Free Software Foundation. + */ + +/* + * Integrated Power Management Chip + * http://www.ti.com/lit/ds/symlink/tps65910.pdf + */ + +&tps { + compatible = "ti,tps65910"; + + regulators { + #address-cells = <1>; + #size-cells = <0>; + + vrtc_reg: regulator at 0 { + reg = <0>; + regulator-compatible = "vrtc"; + regulator-always-on; + }; + + vio_reg: regulator at 1 { + reg = <1>; + regulator-compatible = "vio"; + regulator-min-microvolt = <1500000>; + regulator-max-microvolt = <3300000>; + regulator-always-on; + }; + + vdd1_reg: regulator at 2 { + reg = <2>; + regulator-compatible = "vdd1"; + regulator-min-microvolt = <600000>; + regulator-max-microvolt = <1500000>; + regulator-boot-on; + regulator-always-on; + }; + + vdd2_reg: regulator at 3 { + reg = <3>; + regulator-compatible = "vdd2"; + regulator-min-microvolt = <600000>; + regulator-max-microvolt = <1500000>; + regulator-boot-on; + regulator-always-on; + }; + + vdd3_reg: regulator at 4 { + reg = <4>; + regulator-compatible = "vdd3"; + regulator-always-on; + }; + + vdig1_reg: regulator at 5 { + reg = <5>; + regulator-compatible = "vdig1"; + regulator-min-microvolt = <1200000>; + regulator-max-microvolt = <2700000>; + regulator-always-on; + }; + + vdig2_reg: regulator at 6 { + reg = <6>; + regulator-compatible = "vdig2"; + regulator-min-microvolt = <1000000>; + regulator-max-microvolt = <1800000>; + regulator-always-on; + }; + + vpll_reg: regulator at 7 { + reg = <7>; + regulator-compatible = "vpll"; + regulator-min-microvolt = <1000000>; + regulator-max-microvolt = <2500000>; + regulator-always-on; + }; + + vdac_reg: regulator at 8 { + reg = <8>; + regulator-compatible = "vdac"; + regulator-min-microvolt = <1800000>; + regulator-max-microvolt = <2850000>; + regulator-always-on; + }; + + vaux1_reg: regulator at 9 { + reg = <9>; + regulator-compatible = "vaux1"; + regulator-min-microvolt = <1800000>; + regulator-max-microvolt = <2850000>; + regulator-always-on; + }; + + vaux2_reg: regulator at 10 { + reg = <10>; + regulator-compatible = "vaux2"; + regulator-min-microvolt = <1800000>; + regulator-max-microvolt = <3300000>; + regulator-always-on; + }; + + vaux33_reg: regulator at 11 { + reg = <11>; + regulator-compatible = "vaux33"; + regulator-min-microvolt = <1800000>; + regulator-max-microvolt = <3300000>; + regulator-always-on; + }; + + vmmc_reg: regulator at 12 { + reg = <12>; + regulator-compatible = "vmmc"; + regulator-min-microvolt = <1800000>; + regulator-max-microvolt = <3300000>; + regulator-always-on; + }; + }; +}; -- 1.7.0.4 ^ permalink raw reply related [flat|nested] 34+ messages in thread
* Re: [PATCH RESEND 1/4] ARM: OMAP2+: AM33XX: Add tps65910 device tree data 2012-07-20 6:46 ` AnilKumar Ch @ 2012-07-20 9:59 ` Mark Brown -1 siblings, 0 replies; 34+ messages in thread From: Mark Brown @ 2012-07-20 9:59 UTC (permalink / raw) To: AnilKumar Ch; +Cc: tony, linux-arm-kernel, linux-omap [-- Attachment #1: Type: text/plain, Size: 548 bytes --] On Fri, Jul 20, 2012 at 12:16:26PM +0530, AnilKumar Ch wrote: > + vio_reg: regulator@1 { > + reg = <1>; > + regulator-compatible = "vio"; > + regulator-min-microvolt = <1500000>; > + regulator-max-microvolt = <3300000>; > + regulator-always-on; > + }; Every regulator here has a rather large voltage range specified with no consumers added. Are you sure these voltage ranges make sense in your design and you've not just cut'n'pasted the entire voltage range that your regulator supports without reference to what your board can do? [-- Attachment #2: Digital signature --] [-- Type: application/pgp-signature, Size: 836 bytes --] ^ permalink raw reply [flat|nested] 34+ messages in thread
* [PATCH RESEND 1/4] ARM: OMAP2+: AM33XX: Add tps65910 device tree data @ 2012-07-20 9:59 ` Mark Brown 0 siblings, 0 replies; 34+ messages in thread From: Mark Brown @ 2012-07-20 9:59 UTC (permalink / raw) To: linux-arm-kernel On Fri, Jul 20, 2012 at 12:16:26PM +0530, AnilKumar Ch wrote: > + vio_reg: regulator at 1 { > + reg = <1>; > + regulator-compatible = "vio"; > + regulator-min-microvolt = <1500000>; > + regulator-max-microvolt = <3300000>; > + regulator-always-on; > + }; Every regulator here has a rather large voltage range specified with no consumers added. Are you sure these voltage ranges make sense in your design and you've not just cut'n'pasted the entire voltage range that your regulator supports without reference to what your board can do? -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 836 bytes Desc: Digital signature URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20120720/46545946/attachment.sig> ^ permalink raw reply [flat|nested] 34+ messages in thread
* RE: [PATCH RESEND 1/4] ARM: OMAP2+: AM33XX: Add tps65910 device tree data 2012-07-20 9:59 ` Mark Brown @ 2012-07-20 11:27 ` AnilKumar, Chimata -1 siblings, 0 replies; 34+ messages in thread From: AnilKumar, Chimata @ 2012-07-20 11:27 UTC (permalink / raw) To: Mark Brown; +Cc: tony, linux-arm-kernel, linux-omap Hi Mark, Thanks for the review. On Fri, Jul 20, 2012 at 15:29:36, Mark Brown wrote: > On Fri, Jul 20, 2012 at 12:16:26PM +0530, AnilKumar Ch wrote: > > > + vio_reg: regulator@1 { > > + reg = <1>; > > + regulator-compatible = "vio"; > > + regulator-min-microvolt = <1500000>; > > + regulator-max-microvolt = <3300000>; > > + regulator-always-on; > > + }; > > Every regulator here has a rather large voltage range specified with no > consumers added. Are you sure these voltage ranges make sense in your > design and you've not just cut'n'pasted the entire voltage range that > your regulator supports without reference to what your board can do? > tps65217.dtsi is a generic file to be used by the SoCs so these constraints were taken from the regulator itself. SoC specific limits can be added in SoC specific .dts file to tighten the constraints to require limit. I have tested the driver with this approach. Required consumers will be added while submitting the regulator dependent Consumers. One of the usecase I can specify here is MPU voltage control through DVFS framework. So if require, MPU consumer will be added along with the DVFS support. Thanks AnilKumar ^ permalink raw reply [flat|nested] 34+ messages in thread
* [PATCH RESEND 1/4] ARM: OMAP2+: AM33XX: Add tps65910 device tree data @ 2012-07-20 11:27 ` AnilKumar, Chimata 0 siblings, 0 replies; 34+ messages in thread From: AnilKumar, Chimata @ 2012-07-20 11:27 UTC (permalink / raw) To: linux-arm-kernel Hi Mark, Thanks for the review. On Fri, Jul 20, 2012 at 15:29:36, Mark Brown wrote: > On Fri, Jul 20, 2012 at 12:16:26PM +0530, AnilKumar Ch wrote: > > > + vio_reg: regulator at 1 { > > + reg = <1>; > > + regulator-compatible = "vio"; > > + regulator-min-microvolt = <1500000>; > > + regulator-max-microvolt = <3300000>; > > + regulator-always-on; > > + }; > > Every regulator here has a rather large voltage range specified with no > consumers added. Are you sure these voltage ranges make sense in your > design and you've not just cut'n'pasted the entire voltage range that > your regulator supports without reference to what your board can do? > tps65217.dtsi is a generic file to be used by the SoCs so these constraints were taken from the regulator itself. SoC specific limits can be added in SoC specific .dts file to tighten the constraints to require limit. I have tested the driver with this approach. Required consumers will be added while submitting the regulator dependent Consumers. One of the usecase I can specify here is MPU voltage control through DVFS framework. So if require, MPU consumer will be added along with the DVFS support. Thanks AnilKumar ^ permalink raw reply [flat|nested] 34+ messages in thread
* Re: [PATCH RESEND 1/4] ARM: OMAP2+: AM33XX: Add tps65910 device tree data 2012-07-20 11:27 ` AnilKumar, Chimata @ 2012-07-20 11:38 ` Mark Brown -1 siblings, 0 replies; 34+ messages in thread From: Mark Brown @ 2012-07-20 11:38 UTC (permalink / raw) To: AnilKumar, Chimata; +Cc: tony, linux-arm-kernel, linux-omap [-- Attachment #1: Type: text/plain, Size: 888 bytes --] On Fri, Jul 20, 2012 at 11:27:36AM +0000, AnilKumar, Chimata wrote: > On Fri, Jul 20, 2012 at 15:29:36, Mark Brown wrote: > > Every regulator here has a rather large voltage range specified with no > > consumers added. Are you sure these voltage ranges make sense in your > > design and you've not just cut'n'pasted the entire voltage range that > > your regulator supports without reference to what your board can do? > tps65217.dtsi is a generic file to be used by the SoCs so these constraints > were taken from the regulator itself. SoC specific limits can be added in > SoC specific .dts file to tighten the constraints to require limit. I have > tested the driver with this approach. No, this is not a sane approach. You've no idea if any of these settings are safe or sane for the board. Boards should enable things they know are safe, not remove those they know are broken. [-- Attachment #2: Digital signature --] [-- Type: application/pgp-signature, Size: 836 bytes --] ^ permalink raw reply [flat|nested] 34+ messages in thread
* [PATCH RESEND 1/4] ARM: OMAP2+: AM33XX: Add tps65910 device tree data @ 2012-07-20 11:38 ` Mark Brown 0 siblings, 0 replies; 34+ messages in thread From: Mark Brown @ 2012-07-20 11:38 UTC (permalink / raw) To: linux-arm-kernel On Fri, Jul 20, 2012 at 11:27:36AM +0000, AnilKumar, Chimata wrote: > On Fri, Jul 20, 2012 at 15:29:36, Mark Brown wrote: > > Every regulator here has a rather large voltage range specified with no > > consumers added. Are you sure these voltage ranges make sense in your > > design and you've not just cut'n'pasted the entire voltage range that > > your regulator supports without reference to what your board can do? > tps65217.dtsi is a generic file to be used by the SoCs so these constraints > were taken from the regulator itself. SoC specific limits can be added in > SoC specific .dts file to tighten the constraints to require limit. I have > tested the driver with this approach. No, this is not a sane approach. You've no idea if any of these settings are safe or sane for the board. Boards should enable things they know are safe, not remove those they know are broken. -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 836 bytes Desc: Digital signature URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20120720/91ea542e/attachment.sig> ^ permalink raw reply [flat|nested] 34+ messages in thread
* RE: [PATCH RESEND 1/4] ARM: OMAP2+: AM33XX: Add tps65910 device tree data 2012-07-20 11:38 ` Mark Brown @ 2012-07-23 7:06 ` AnilKumar, Chimata -1 siblings, 0 replies; 34+ messages in thread From: AnilKumar, Chimata @ 2012-07-23 7:06 UTC (permalink / raw) To: Mark Brown; +Cc: tony, linux-arm-kernel, linux-omap On Fri, Jul 20, 2012 at 17:08:06, Mark Brown wrote: > On Fri, Jul 20, 2012 at 11:27:36AM +0000, AnilKumar, Chimata wrote: > > On Fri, Jul 20, 2012 at 15:29:36, Mark Brown wrote: > > > > Every regulator here has a rather large voltage range specified with no > > > consumers added. Are you sure these voltage ranges make sense in your > > > design and you've not just cut'n'pasted the entire voltage range that > > > your regulator supports without reference to what your board can do? > > > tps65217.dtsi is a generic file to be used by the SoCs so these constraints > > were taken from the regulator itself. SoC specific limits can be added in > > SoC specific .dts file to tighten the constraints to require limit. I have > > tested the driver with this approach. > > No, this is not a sane approach. You've no idea if any of these > settings are safe or sane for the board. Boards should enable things > they know are safe, not remove those they know are broken. > Unsterstood, I will send v2 with constraints updated. Regards AnilKumar ^ permalink raw reply [flat|nested] 34+ messages in thread
* [PATCH RESEND 1/4] ARM: OMAP2+: AM33XX: Add tps65910 device tree data @ 2012-07-23 7:06 ` AnilKumar, Chimata 0 siblings, 0 replies; 34+ messages in thread From: AnilKumar, Chimata @ 2012-07-23 7:06 UTC (permalink / raw) To: linux-arm-kernel On Fri, Jul 20, 2012 at 17:08:06, Mark Brown wrote: > On Fri, Jul 20, 2012 at 11:27:36AM +0000, AnilKumar, Chimata wrote: > > On Fri, Jul 20, 2012 at 15:29:36, Mark Brown wrote: > > > > Every regulator here has a rather large voltage range specified with no > > > consumers added. Are you sure these voltage ranges make sense in your > > > design and you've not just cut'n'pasted the entire voltage range that > > > your regulator supports without reference to what your board can do? > > > tps65217.dtsi is a generic file to be used by the SoCs so these constraints > > were taken from the regulator itself. SoC specific limits can be added in > > SoC specific .dts file to tighten the constraints to require limit. I have > > tested the driver with this approach. > > No, this is not a sane approach. You've no idea if any of these > settings are safe or sane for the board. Boards should enable things > they know are safe, not remove those they know are broken. > Unsterstood, I will send v2 with constraints updated. Regards AnilKumar ^ permalink raw reply [flat|nested] 34+ messages in thread
* RE: [PATCH RESEND 1/4] ARM: OMAP2+: AM33XX: Add tps65910 device tree data 2012-07-20 11:38 ` Mark Brown @ 2012-07-23 13:23 ` AnilKumar, Chimata -1 siblings, 0 replies; 34+ messages in thread From: AnilKumar, Chimata @ 2012-07-23 13:23 UTC (permalink / raw) To: AnilKumar, Chimata, Mark Brown; +Cc: tony, linux-arm-kernel, linux-omap On Mon, Jul 23, 2012 at 12:36:48, AnilKumar, Chimata wrote: > On Fri, Jul 20, 2012 at 17:08:06, Mark Brown wrote: > > On Fri, Jul 20, 2012 at 11:27:36AM +0000, AnilKumar, Chimata wrote: > > > On Fri, Jul 20, 2012 at 15:29:36, Mark Brown wrote: > > > > > > Every regulator here has a rather large voltage range specified with no > > > > consumers added. Are you sure these voltage ranges make sense in your > > > > design and you've not just cut'n'pasted the entire voltage range that > > > > your regulator supports without reference to what your board can do? > > > > > tps65217.dtsi is a generic file to be used by the SoCs so these constraints > > > were taken from the regulator itself. SoC specific limits can be added in > > > SoC specific .dts file to tighten the constraints to require limit. I have > > > tested the driver with this approach. > > > > No, this is not a sane approach. You've no idea if any of these > > settings are safe or sane for the board. Boards should enable things > > they know are safe, not remove those they know are broken. > > > > Unsterstood, I will send v2 with constraints updated. > By the way, if we look at all the regulator added (DT supported) till now have the similar problem. arch/arm/boot/dts/imx6q.dtsi arch/arm/boot/dts/twl4030.dtsi arch/arm/boot/dts/twl6030.dtsi arch/arm/boot/dts/db8500.dtsi Regards AnilKumar ^ permalink raw reply [flat|nested] 34+ messages in thread
* [PATCH RESEND 1/4] ARM: OMAP2+: AM33XX: Add tps65910 device tree data @ 2012-07-23 13:23 ` AnilKumar, Chimata 0 siblings, 0 replies; 34+ messages in thread From: AnilKumar, Chimata @ 2012-07-23 13:23 UTC (permalink / raw) To: linux-arm-kernel On Mon, Jul 23, 2012 at 12:36:48, AnilKumar, Chimata wrote: > On Fri, Jul 20, 2012 at 17:08:06, Mark Brown wrote: > > On Fri, Jul 20, 2012 at 11:27:36AM +0000, AnilKumar, Chimata wrote: > > > On Fri, Jul 20, 2012 at 15:29:36, Mark Brown wrote: > > > > > > Every regulator here has a rather large voltage range specified with no > > > > consumers added. Are you sure these voltage ranges make sense in your > > > > design and you've not just cut'n'pasted the entire voltage range that > > > > your regulator supports without reference to what your board can do? > > > > > tps65217.dtsi is a generic file to be used by the SoCs so these constraints > > > were taken from the regulator itself. SoC specific limits can be added in > > > SoC specific .dts file to tighten the constraints to require limit. I have > > > tested the driver with this approach. > > > > No, this is not a sane approach. You've no idea if any of these > > settings are safe or sane for the board. Boards should enable things > > they know are safe, not remove those they know are broken. > > > > Unsterstood, I will send v2 with constraints updated. > By the way, if we look at all the regulator added (DT supported) till now have the similar problem. arch/arm/boot/dts/imx6q.dtsi arch/arm/boot/dts/twl4030.dtsi arch/arm/boot/dts/twl6030.dtsi arch/arm/boot/dts/db8500.dtsi Regards AnilKumar ^ permalink raw reply [flat|nested] 34+ messages in thread
* Re: [PATCH RESEND 1/4] ARM: OMAP2+: AM33XX: Add tps65910 device tree data 2012-07-23 13:23 ` AnilKumar, Chimata @ 2012-07-23 13:34 ` Mark Brown -1 siblings, 0 replies; 34+ messages in thread From: Mark Brown @ 2012-07-23 13:34 UTC (permalink / raw) To: AnilKumar, Chimata; +Cc: tony, linux-arm-kernel, linux-omap, Lee.Jones [-- Attachment #1: Type: text/plain, Size: 775 bytes --] On Mon, Jul 23, 2012 at 01:23:50PM +0000, AnilKumar, Chimata wrote: > By the way, if we look at all the regulator added (DT supported) till now have > the similar problem. > arch/arm/boot/dts/imx6q.dtsi This is fine - the SoC contains integrated regulators which supply other bits of the Soc so we can be confident that the hookup is good just based on the silicon. > arch/arm/boot/dts/twl4030.dtsi > arch/arm/boot/dts/twl6030.dtsi These appear to have similar issues and should be fixed, at least as far as the voltage ranges go. > arch/arm/boot/dts/db8500.dtsi I'm not actually seeing anything terribly problematic here, though the regulator-name properties should really be removed as they're fairly useless and seem to be missing the point of having the property. [-- Attachment #2: Digital signature --] [-- Type: application/pgp-signature, Size: 836 bytes --] ^ permalink raw reply [flat|nested] 34+ messages in thread
* [PATCH RESEND 1/4] ARM: OMAP2+: AM33XX: Add tps65910 device tree data @ 2012-07-23 13:34 ` Mark Brown 0 siblings, 0 replies; 34+ messages in thread From: Mark Brown @ 2012-07-23 13:34 UTC (permalink / raw) To: linux-arm-kernel On Mon, Jul 23, 2012 at 01:23:50PM +0000, AnilKumar, Chimata wrote: > By the way, if we look at all the regulator added (DT supported) till now have > the similar problem. > arch/arm/boot/dts/imx6q.dtsi This is fine - the SoC contains integrated regulators which supply other bits of the Soc so we can be confident that the hookup is good just based on the silicon. > arch/arm/boot/dts/twl4030.dtsi > arch/arm/boot/dts/twl6030.dtsi These appear to have similar issues and should be fixed, at least as far as the voltage ranges go. > arch/arm/boot/dts/db8500.dtsi I'm not actually seeing anything terribly problematic here, though the regulator-name properties should really be removed as they're fairly useless and seem to be missing the point of having the property. -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 836 bytes Desc: Digital signature URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20120723/fa09dbb7/attachment-0001.sig> ^ permalink raw reply [flat|nested] 34+ messages in thread
* Re: [PATCH RESEND 1/4] ARM: OMAP2+: AM33XX: Add tps65910 device tree data 2012-07-23 13:34 ` Mark Brown @ 2012-07-23 13:48 ` Lee Jones -1 siblings, 0 replies; 34+ messages in thread From: Lee Jones @ 2012-07-23 13:48 UTC (permalink / raw) To: Mark Brown; +Cc: tony, linux-omap, linux-arm-kernel, AnilKumar, Chimata On 23/07/12 14:34, Mark Brown wrote: > On Mon, Jul 23, 2012 at 01:23:50PM +0000, AnilKumar, Chimata wrote: > >> By the way, if we look at all the regulator added (DT supported) till now have >> the similar problem. > >> arch/arm/boot/dts/imx6q.dtsi > > This is fine - the SoC contains integrated regulators which supply other > bits of the Soc so we can be confident that the hookup is good just > based on the silicon. > >> arch/arm/boot/dts/twl4030.dtsi >> arch/arm/boot/dts/twl6030.dtsi > > These appear to have similar issues and should be fixed, at least as far > as the voltage ranges go. > >> arch/arm/boot/dts/db8500.dtsi > > I'm not actually seeing anything terribly problematic here, though the > regulator-name properties should really be removed as they're fairly > useless and seem to be missing the point of having the property. I've missed the context of the thread, so can't comment, but I'm happy to remove the regulator-name properties from db8500.dts. Adding to my TODO. -- Lee Jones Linaro ST-Ericsson Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply [flat|nested] 34+ messages in thread
* [PATCH RESEND 1/4] ARM: OMAP2+: AM33XX: Add tps65910 device tree data @ 2012-07-23 13:48 ` Lee Jones 0 siblings, 0 replies; 34+ messages in thread From: Lee Jones @ 2012-07-23 13:48 UTC (permalink / raw) To: linux-arm-kernel On 23/07/12 14:34, Mark Brown wrote: > On Mon, Jul 23, 2012 at 01:23:50PM +0000, AnilKumar, Chimata wrote: > >> By the way, if we look at all the regulator added (DT supported) till now have >> the similar problem. > >> arch/arm/boot/dts/imx6q.dtsi > > This is fine - the SoC contains integrated regulators which supply other > bits of the Soc so we can be confident that the hookup is good just > based on the silicon. > >> arch/arm/boot/dts/twl4030.dtsi >> arch/arm/boot/dts/twl6030.dtsi > > These appear to have similar issues and should be fixed, at least as far > as the voltage ranges go. > >> arch/arm/boot/dts/db8500.dtsi > > I'm not actually seeing anything terribly problematic here, though the > regulator-name properties should really be removed as they're fairly > useless and seem to be missing the point of having the property. I've missed the context of the thread, so can't comment, but I'm happy to remove the regulator-name properties from db8500.dts. Adding to my TODO. -- Lee Jones Linaro ST-Ericsson Landing Team Lead Linaro.org ? Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog ^ permalink raw reply [flat|nested] 34+ messages in thread
* Re: [PATCH RESEND 1/4] ARM: OMAP2+: AM33XX: Add tps65910 device tree data 2012-07-23 13:34 ` Mark Brown @ 2012-08-28 11:26 ` Lee Jones -1 siblings, 0 replies; 34+ messages in thread From: Lee Jones @ 2012-08-28 11:26 UTC (permalink / raw) To: Mark Brown; +Cc: AnilKumar, Chimata, tony, linux-arm-kernel, linux-omap Hi Mark, > > arch/arm/boot/dts/db8500.dtsi > > I'm not actually seeing anything terribly problematic here, though the > regulator-name properties should really be removed as they're fairly > useless and seem to be missing the point of having the property. Just looking at this now. The regulator-name property is used to populate constrains->name. Are you sure you still want them all removed? Kind regards, Lee -- Lee Jones Linaro ST-Ericsson Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply [flat|nested] 34+ messages in thread
* [PATCH RESEND 1/4] ARM: OMAP2+: AM33XX: Add tps65910 device tree data @ 2012-08-28 11:26 ` Lee Jones 0 siblings, 0 replies; 34+ messages in thread From: Lee Jones @ 2012-08-28 11:26 UTC (permalink / raw) To: linux-arm-kernel Hi Mark, > > arch/arm/boot/dts/db8500.dtsi > > I'm not actually seeing anything terribly problematic here, though the > regulator-name properties should really be removed as they're fairly > useless and seem to be missing the point of having the property. Just looking at this now. The regulator-name property is used to populate constrains->name. Are you sure you still want them all removed? Kind regards, Lee -- Lee Jones Linaro ST-Ericsson Landing Team Lead Linaro.org ? Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog ^ permalink raw reply [flat|nested] 34+ messages in thread
* Re: [PATCH RESEND 1/4] ARM: OMAP2+: AM33XX: Add tps65910 device tree data 2012-08-28 11:26 ` Lee Jones @ 2012-08-28 17:21 ` Mark Brown -1 siblings, 0 replies; 34+ messages in thread From: Mark Brown @ 2012-08-28 17:21 UTC (permalink / raw) To: Lee Jones; +Cc: AnilKumar, Chimata, tony, linux-arm-kernel, linux-omap On Tue, Aug 28, 2012 at 12:26:07PM +0100, Lee Jones wrote: > > > arch/arm/boot/dts/db8500.dtsi > > I'm not actually seeing anything terribly problematic here, though the > > regulator-name properties should really be removed as they're fairly > > useless and seem to be missing the point of having the property. > Just looking at this now. > The regulator-name property is used to populate constrains->name. Are > you sure you still want them all removed? Yes, of course. There's no way that a generic .dtsi used for any possible board could come up with a sensible value. ^ permalink raw reply [flat|nested] 34+ messages in thread
* [PATCH RESEND 1/4] ARM: OMAP2+: AM33XX: Add tps65910 device tree data @ 2012-08-28 17:21 ` Mark Brown 0 siblings, 0 replies; 34+ messages in thread From: Mark Brown @ 2012-08-28 17:21 UTC (permalink / raw) To: linux-arm-kernel On Tue, Aug 28, 2012 at 12:26:07PM +0100, Lee Jones wrote: > > > arch/arm/boot/dts/db8500.dtsi > > I'm not actually seeing anything terribly problematic here, though the > > regulator-name properties should really be removed as they're fairly > > useless and seem to be missing the point of having the property. > Just looking at this now. > The regulator-name property is used to populate constrains->name. Are > you sure you still want them all removed? Yes, of course. There's no way that a generic .dtsi used for any possible board could come up with a sensible value. ^ permalink raw reply [flat|nested] 34+ messages in thread
* Re: [PATCH RESEND 1/4] ARM: OMAP2+: AM33XX: Add tps65910 device tree data 2012-08-28 17:21 ` Mark Brown @ 2012-08-29 8:31 ` Lee Jones -1 siblings, 0 replies; 34+ messages in thread From: Lee Jones @ 2012-08-29 8:31 UTC (permalink / raw) To: Mark Brown; +Cc: AnilKumar, Chimata, tony, linux-arm-kernel, linux-omap On Tue, Aug 28, 2012 at 10:21:33AM -0700, Mark Brown wrote: > On Tue, Aug 28, 2012 at 12:26:07PM +0100, Lee Jones wrote: > > > > > arch/arm/boot/dts/db8500.dtsi > > > > I'm not actually seeing anything terribly problematic here, though the > > > regulator-name properties should really be removed as they're fairly > > > useless and seem to be missing the point of having the property. > > > Just looking at this now. > > > The regulator-name property is used to populate constrains->name. Are > > you sure you still want them all removed? > > Yes, of course. There's no way that a generic .dtsi used for any > possible board could come up with a sensible value. So how should constrains->name be populated then? Would you prefer regulator-names moved to the .dts file(s), or something else? -- Lee Jones Linaro ST-Ericsson Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply [flat|nested] 34+ messages in thread
* [PATCH RESEND 1/4] ARM: OMAP2+: AM33XX: Add tps65910 device tree data @ 2012-08-29 8:31 ` Lee Jones 0 siblings, 0 replies; 34+ messages in thread From: Lee Jones @ 2012-08-29 8:31 UTC (permalink / raw) To: linux-arm-kernel On Tue, Aug 28, 2012 at 10:21:33AM -0700, Mark Brown wrote: > On Tue, Aug 28, 2012 at 12:26:07PM +0100, Lee Jones wrote: > > > > > arch/arm/boot/dts/db8500.dtsi > > > > I'm not actually seeing anything terribly problematic here, though the > > > regulator-name properties should really be removed as they're fairly > > > useless and seem to be missing the point of having the property. > > > Just looking at this now. > > > The regulator-name property is used to populate constrains->name. Are > > you sure you still want them all removed? > > Yes, of course. There's no way that a generic .dtsi used for any > possible board could come up with a sensible value. So how should constrains->name be populated then? Would you prefer regulator-names moved to the .dts file(s), or something else? -- Lee Jones Linaro ST-Ericsson Landing Team Lead Linaro.org ? Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog ^ permalink raw reply [flat|nested] 34+ messages in thread
* Re: [PATCH RESEND 1/4] ARM: OMAP2+: AM33XX: Add tps65910 device tree data 2012-08-29 8:31 ` Lee Jones @ 2012-08-30 16:59 ` Mark Brown -1 siblings, 0 replies; 34+ messages in thread From: Mark Brown @ 2012-08-30 16:59 UTC (permalink / raw) To: Lee Jones; +Cc: AnilKumar, Chimata, tony, linux-arm-kernel, linux-omap On Wed, Aug 29, 2012 at 09:31:31AM +0100, Lee Jones wrote: > On Tue, Aug 28, 2012 at 10:21:33AM -0700, Mark Brown wrote: > > > The regulator-name property is used to populate constrains->name. Are > > > you sure you still want them all removed? > > Yes, of course. There's no way that a generic .dtsi used for any > > possible board could come up with a sensible value. > So how should constrains->name be populated then? Would you prefer > regulator-names moved to the .dts file(s), or something else? Of course, yes. The sole purpose of that field is to give a board specific name to the supply. It can't usefully be set by anything except the board. ^ permalink raw reply [flat|nested] 34+ messages in thread
* [PATCH RESEND 1/4] ARM: OMAP2+: AM33XX: Add tps65910 device tree data @ 2012-08-30 16:59 ` Mark Brown 0 siblings, 0 replies; 34+ messages in thread From: Mark Brown @ 2012-08-30 16:59 UTC (permalink / raw) To: linux-arm-kernel On Wed, Aug 29, 2012 at 09:31:31AM +0100, Lee Jones wrote: > On Tue, Aug 28, 2012 at 10:21:33AM -0700, Mark Brown wrote: > > > The regulator-name property is used to populate constrains->name. Are > > > you sure you still want them all removed? > > Yes, of course. There's no way that a generic .dtsi used for any > > possible board could come up with a sensible value. > So how should constrains->name be populated then? Would you prefer > regulator-names moved to the .dts file(s), or something else? Of course, yes. The sole purpose of that field is to give a board specific name to the supply. It can't usefully be set by anything except the board. ^ permalink raw reply [flat|nested] 34+ messages in thread
* [PATCH RESEND 2/4] ARM: OMAP2+: AM33XX: Add tps65217 device tree data 2012-07-20 6:46 ` AnilKumar Ch @ 2012-07-20 6:46 ` AnilKumar Ch -1 siblings, 0 replies; 34+ messages in thread From: AnilKumar Ch @ 2012-07-20 6:46 UTC (permalink / raw) To: tony; +Cc: linux-arm-kernel, linux-omap, broonie, AnilKumar Ch Add device tree data for tps65217 regulator by adding all the consumers necessary for AM335X-BeagleBone. The data will be map to a regulator constraints which is required for regulator set_voltage and get_voltage calls. All tps65217 PMIC regulator constraints are placed in a seperate device tree include file (tps65217.dtsi). This patch is tested by adding the I2C slave address of TPS65217 pmic to am335x-bone.dts file (Not included in this, I2C slave addition patch will be submitted to linux-omap, where am335x-bone.dts binding file is available). Signed-off-by: AnilKumar Ch <anilkumar@ti.com> --- arch/arm/boot/dts/tps65217.dtsi | 84 +++++++++++++++++++++++++++++++++++++++ 1 files changed, 84 insertions(+), 0 deletions(-) create mode 100644 arch/arm/boot/dts/tps65217.dtsi diff --git a/arch/arm/boot/dts/tps65217.dtsi b/arch/arm/boot/dts/tps65217.dtsi new file mode 100644 index 0000000..cbb9e5d --- /dev/null +++ b/arch/arm/boot/dts/tps65217.dtsi @@ -0,0 +1,84 @@ +/* + * Copyright (C) 2012 Texas Instruments Incorporated - http://www.ti.com/ + * + * This program is free software; you can redistribute it and/or modify + * it under the terms of the GNU General Public License version 2 as + * published by the Free Software Foundation. + */ + +/* + * Integrated Power Management Chip + * http://www.ti.com/lit/ds/symlink/tps65217.pdf + */ + +&tps { + compatible = "ti,tps65217"; + + regulators { + #address-cells = <1>; + #size-cells = <0>; + + dcdc1_reg: regulator@0 { + reg = <0>; + regulator-compatible = "dcdc1"; + regulator-min-microvolt = <900000>; + regulator-max-microvolt = <1800000>; + regulator-boot-on; + regulator-always-on; + }; + + dcdc2_reg: regulator@1 { + reg = <1>; + regulator-compatible = "dcdc2"; + regulator-min-microvolt = <900000>; + regulator-max-microvolt = <3300000>; + regulator-boot-on; + regulator-always-on; + }; + + dcdc3_reg: regulator@2 { + reg = <2>; + regulator-compatible = "dcdc3"; + regulator-min-microvolt = <900000>; + regulator-max-microvolt = <1500000>; + regulator-boot-on; + regulator-always-on; + }; + + ldo1_reg: regulator@3 { + reg = <3>; + regulator-compatible = "ldo1"; + regulator-min-microvolt = <1000000>; + regulator-max-microvolt = <3300000>; + regulator-boot-on; + regulator-always-on; + }; + + ldo2_reg: regulator@4 { + reg = <4>; + regulator-compatible = "ldo2"; + regulator-min-microvolt = <900000>; + regulator-max-microvolt = <3300000>; + regulator-boot-on; + regulator-always-on; + }; + + ldo3_reg: regulator@5 { + reg = <5>; + regulator-compatible = "ldo3"; + regulator-min-microvolt = <1800000>; + regulator-max-microvolt = <3300000>; + regulator-boot-on; + regulator-always-on; + }; + + ldo4_reg: regulator@6 { + reg = <6>; + regulator-compatible = "ldo4"; + regulator-min-microvolt = <1800000>; + regulator-max-microvolt = <3300000>; + regulator-boot-on; + regulator-always-on; + }; + }; +}; -- 1.7.0.4 ^ permalink raw reply related [flat|nested] 34+ messages in thread
* [PATCH RESEND 2/4] ARM: OMAP2+: AM33XX: Add tps65217 device tree data @ 2012-07-20 6:46 ` AnilKumar Ch 0 siblings, 0 replies; 34+ messages in thread From: AnilKumar Ch @ 2012-07-20 6:46 UTC (permalink / raw) To: linux-arm-kernel Add device tree data for tps65217 regulator by adding all the consumers necessary for AM335X-BeagleBone. The data will be map to a regulator constraints which is required for regulator set_voltage and get_voltage calls. All tps65217 PMIC regulator constraints are placed in a seperate device tree include file (tps65217.dtsi). This patch is tested by adding the I2C slave address of TPS65217 pmic to am335x-bone.dts file (Not included in this, I2C slave addition patch will be submitted to linux-omap, where am335x-bone.dts binding file is available). Signed-off-by: AnilKumar Ch <anilkumar@ti.com> --- arch/arm/boot/dts/tps65217.dtsi | 84 +++++++++++++++++++++++++++++++++++++++ 1 files changed, 84 insertions(+), 0 deletions(-) create mode 100644 arch/arm/boot/dts/tps65217.dtsi diff --git a/arch/arm/boot/dts/tps65217.dtsi b/arch/arm/boot/dts/tps65217.dtsi new file mode 100644 index 0000000..cbb9e5d --- /dev/null +++ b/arch/arm/boot/dts/tps65217.dtsi @@ -0,0 +1,84 @@ +/* + * Copyright (C) 2012 Texas Instruments Incorporated - http://www.ti.com/ + * + * This program is free software; you can redistribute it and/or modify + * it under the terms of the GNU General Public License version 2 as + * published by the Free Software Foundation. + */ + +/* + * Integrated Power Management Chip + * http://www.ti.com/lit/ds/symlink/tps65217.pdf + */ + +&tps { + compatible = "ti,tps65217"; + + regulators { + #address-cells = <1>; + #size-cells = <0>; + + dcdc1_reg: regulator at 0 { + reg = <0>; + regulator-compatible = "dcdc1"; + regulator-min-microvolt = <900000>; + regulator-max-microvolt = <1800000>; + regulator-boot-on; + regulator-always-on; + }; + + dcdc2_reg: regulator at 1 { + reg = <1>; + regulator-compatible = "dcdc2"; + regulator-min-microvolt = <900000>; + regulator-max-microvolt = <3300000>; + regulator-boot-on; + regulator-always-on; + }; + + dcdc3_reg: regulator at 2 { + reg = <2>; + regulator-compatible = "dcdc3"; + regulator-min-microvolt = <900000>; + regulator-max-microvolt = <1500000>; + regulator-boot-on; + regulator-always-on; + }; + + ldo1_reg: regulator at 3 { + reg = <3>; + regulator-compatible = "ldo1"; + regulator-min-microvolt = <1000000>; + regulator-max-microvolt = <3300000>; + regulator-boot-on; + regulator-always-on; + }; + + ldo2_reg: regulator at 4 { + reg = <4>; + regulator-compatible = "ldo2"; + regulator-min-microvolt = <900000>; + regulator-max-microvolt = <3300000>; + regulator-boot-on; + regulator-always-on; + }; + + ldo3_reg: regulator at 5 { + reg = <5>; + regulator-compatible = "ldo3"; + regulator-min-microvolt = <1800000>; + regulator-max-microvolt = <3300000>; + regulator-boot-on; + regulator-always-on; + }; + + ldo4_reg: regulator at 6 { + reg = <6>; + regulator-compatible = "ldo4"; + regulator-min-microvolt = <1800000>; + regulator-max-microvolt = <3300000>; + regulator-boot-on; + regulator-always-on; + }; + }; +}; -- 1.7.0.4 ^ permalink raw reply related [flat|nested] 34+ messages in thread
* Re: [PATCH RESEND 2/4] ARM: OMAP2+: AM33XX: Add tps65217 device tree data 2012-07-20 6:46 ` AnilKumar Ch @ 2012-07-20 10:01 ` Mark Brown -1 siblings, 0 replies; 34+ messages in thread From: Mark Brown @ 2012-07-20 10:01 UTC (permalink / raw) To: AnilKumar Ch; +Cc: tony, linux-arm-kernel, linux-omap [-- Attachment #1: Type: text/plain, Size: 251 bytes --] On Fri, Jul 20, 2012 at 12:16:27PM +0530, AnilKumar Ch wrote: > + dcdc1_reg: regulator@0 { > + reg = <0>; > + regulator-compatible = "dcdc1"; > + regulator-min-microvolt = <900000>; > + regulator-max-microvolt = <1800000>; Same issue here. [-- Attachment #2: Digital signature --] [-- Type: application/pgp-signature, Size: 836 bytes --] ^ permalink raw reply [flat|nested] 34+ messages in thread
* [PATCH RESEND 2/4] ARM: OMAP2+: AM33XX: Add tps65217 device tree data @ 2012-07-20 10:01 ` Mark Brown 0 siblings, 0 replies; 34+ messages in thread From: Mark Brown @ 2012-07-20 10:01 UTC (permalink / raw) To: linux-arm-kernel On Fri, Jul 20, 2012 at 12:16:27PM +0530, AnilKumar Ch wrote: > + dcdc1_reg: regulator at 0 { > + reg = <0>; > + regulator-compatible = "dcdc1"; > + regulator-min-microvolt = <900000>; > + regulator-max-microvolt = <1800000>; Same issue here. -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 836 bytes Desc: Digital signature URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20120720/fa4d5480/attachment.sig> ^ permalink raw reply [flat|nested] 34+ messages in thread
* [PATCH 3/4] arm/dts: Add tps65910 regulator DT data to am335x-evm.dts 2012-07-20 6:46 ` AnilKumar Ch @ 2012-07-20 6:46 ` AnilKumar Ch -1 siblings, 0 replies; 34+ messages in thread From: AnilKumar Ch @ 2012-07-20 6:46 UTC (permalink / raw) To: tony; +Cc: linux-arm-kernel, linux-omap, broonie, AnilKumar Ch Adds tps65910 regulator device tree data, which adds I2C node with I2C frequency and tps65910 PMIC I2C slave address. Signed-off-by: AnilKumar Ch <anilkumar@ti.com> --- arch/arm/boot/dts/am335x-evm.dts | 10 ++++++++++ 1 files changed, 10 insertions(+), 0 deletions(-) diff --git a/arch/arm/boot/dts/am335x-evm.dts b/arch/arm/boot/dts/am335x-evm.dts index d6a97d9..15d03ba 100644 --- a/arch/arm/boot/dts/am335x-evm.dts +++ b/arch/arm/boot/dts/am335x-evm.dts @@ -18,3 +18,13 @@ reg = <0x80000000 0x10000000>; /* 256 MB */ }; }; + +&i2c1 { + clock-frequency = <400000>; + + tps: tps@2D { + reg = <0x2D>; + }; +}; + +/include/ "tps65910.dtsi" -- 1.7.0.4 ^ permalink raw reply related [flat|nested] 34+ messages in thread
* [PATCH 3/4] arm/dts: Add tps65910 regulator DT data to am335x-evm.dts @ 2012-07-20 6:46 ` AnilKumar Ch 0 siblings, 0 replies; 34+ messages in thread From: AnilKumar Ch @ 2012-07-20 6:46 UTC (permalink / raw) To: linux-arm-kernel Adds tps65910 regulator device tree data, which adds I2C node with I2C frequency and tps65910 PMIC I2C slave address. Signed-off-by: AnilKumar Ch <anilkumar@ti.com> --- arch/arm/boot/dts/am335x-evm.dts | 10 ++++++++++ 1 files changed, 10 insertions(+), 0 deletions(-) diff --git a/arch/arm/boot/dts/am335x-evm.dts b/arch/arm/boot/dts/am335x-evm.dts index d6a97d9..15d03ba 100644 --- a/arch/arm/boot/dts/am335x-evm.dts +++ b/arch/arm/boot/dts/am335x-evm.dts @@ -18,3 +18,13 @@ reg = <0x80000000 0x10000000>; /* 256 MB */ }; }; + +&i2c1 { + clock-frequency = <400000>; + + tps: tps at 2D { + reg = <0x2D>; + }; +}; + +/include/ "tps65910.dtsi" -- 1.7.0.4 ^ permalink raw reply related [flat|nested] 34+ messages in thread
* [PATCH 4/4] arm/dts: Add tps65217 regulator DT data to am335x-bone.dts 2012-07-20 6:46 ` AnilKumar Ch @ 2012-07-20 6:46 ` AnilKumar Ch -1 siblings, 0 replies; 34+ messages in thread From: AnilKumar Ch @ 2012-07-20 6:46 UTC (permalink / raw) To: tony; +Cc: linux-arm-kernel, linux-omap, broonie, AnilKumar Ch Adds tps65217 regulator device tree data, which adds I2C node with I2C frequency and tps65217 PMIC I2C slave address. Signed-off-by: AnilKumar Ch <anilkumar@ti.com> --- arch/arm/boot/dts/am335x-bone.dts | 10 ++++++++++ 1 files changed, 10 insertions(+), 0 deletions(-) diff --git a/arch/arm/boot/dts/am335x-bone.dts b/arch/arm/boot/dts/am335x-bone.dts index a9af4db..a4d4415 100644 --- a/arch/arm/boot/dts/am335x-bone.dts +++ b/arch/arm/boot/dts/am335x-bone.dts @@ -18,3 +18,13 @@ reg = <0x80000000 0x10000000>; /* 256 MB */ }; }; + +&i2c1 { + clock-frequency = <400000>; + + tps: tps@24 { + reg = <0x24>; + }; +}; + +/include/ "tps65217.dtsi" -- 1.7.0.4 ^ permalink raw reply related [flat|nested] 34+ messages in thread
* [PATCH 4/4] arm/dts: Add tps65217 regulator DT data to am335x-bone.dts @ 2012-07-20 6:46 ` AnilKumar Ch 0 siblings, 0 replies; 34+ messages in thread From: AnilKumar Ch @ 2012-07-20 6:46 UTC (permalink / raw) To: linux-arm-kernel Adds tps65217 regulator device tree data, which adds I2C node with I2C frequency and tps65217 PMIC I2C slave address. Signed-off-by: AnilKumar Ch <anilkumar@ti.com> --- arch/arm/boot/dts/am335x-bone.dts | 10 ++++++++++ 1 files changed, 10 insertions(+), 0 deletions(-) diff --git a/arch/arm/boot/dts/am335x-bone.dts b/arch/arm/boot/dts/am335x-bone.dts index a9af4db..a4d4415 100644 --- a/arch/arm/boot/dts/am335x-bone.dts +++ b/arch/arm/boot/dts/am335x-bone.dts @@ -18,3 +18,13 @@ reg = <0x80000000 0x10000000>; /* 256 MB */ }; }; + +&i2c1 { + clock-frequency = <400000>; + + tps: tps at 24 { + reg = <0x24>; + }; +}; + +/include/ "tps65217.dtsi" -- 1.7.0.4 ^ permalink raw reply related [flat|nested] 34+ messages in thread
end of thread, other threads:[~2012-08-30 16:59 UTC | newest] Thread overview: 34+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2012-07-20 6:46 [PATCH 0/4] Add AM33XX regulators device tree data AnilKumar Ch 2012-07-20 6:46 ` AnilKumar Ch 2012-07-20 6:46 ` [PATCH RESEND 1/4] ARM: OMAP2+: AM33XX: Add tps65910 " AnilKumar Ch 2012-07-20 6:46 ` AnilKumar Ch 2012-07-20 9:59 ` Mark Brown 2012-07-20 9:59 ` Mark Brown 2012-07-20 11:27 ` AnilKumar, Chimata 2012-07-20 11:27 ` AnilKumar, Chimata 2012-07-20 11:38 ` Mark Brown 2012-07-20 11:38 ` Mark Brown 2012-07-23 7:06 ` AnilKumar, Chimata 2012-07-23 7:06 ` AnilKumar, Chimata 2012-07-23 13:23 ` AnilKumar, Chimata 2012-07-23 13:23 ` AnilKumar, Chimata 2012-07-23 13:34 ` Mark Brown 2012-07-23 13:34 ` Mark Brown 2012-07-23 13:48 ` Lee Jones 2012-07-23 13:48 ` Lee Jones 2012-08-28 11:26 ` Lee Jones 2012-08-28 11:26 ` Lee Jones 2012-08-28 17:21 ` Mark Brown 2012-08-28 17:21 ` Mark Brown 2012-08-29 8:31 ` Lee Jones 2012-08-29 8:31 ` Lee Jones 2012-08-30 16:59 ` Mark Brown 2012-08-30 16:59 ` Mark Brown 2012-07-20 6:46 ` [PATCH RESEND 2/4] ARM: OMAP2+: AM33XX: Add tps65217 " AnilKumar Ch 2012-07-20 6:46 ` AnilKumar Ch 2012-07-20 10:01 ` Mark Brown 2012-07-20 10:01 ` Mark Brown 2012-07-20 6:46 ` [PATCH 3/4] arm/dts: Add tps65910 regulator DT data to am335x-evm.dts AnilKumar Ch 2012-07-20 6:46 ` AnilKumar Ch 2012-07-20 6:46 ` [PATCH 4/4] arm/dts: Add tps65217 regulator DT data to am335x-bone.dts AnilKumar Ch 2012-07-20 6:46 ` AnilKumar Ch
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.