From: "AnilKumar, Chimata" <anilkumar-l0cyMroinI0@public.gmane.org> To: "Cousson, Benoit" <b-cousson-l0cyMroinI0@public.gmane.org> Cc: "a.zummo-BfzFCNDTiLLj+vYz1yj4TQ@public.gmane.org" <a.zummo-BfzFCNDTiLLj+vYz1yj4TQ@public.gmane.org>, "sameo-VuQAYsv1563Yd54FQh9/CA@public.gmane.org" <sameo-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>, "rtc-linux-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org" <rtc-linux-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org>, "devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org" <devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org>, mark Brown <broonie-yzvPICuk2AATkU/dhu1WVueM+bqZidxxQQ4Iyu8u01E@public.gmane.org>, "rob.herring-bsGFqQB8/DxBDgjK7y7TUQ@public.gmane.org" <rob.herring-bsGFqQB8/DxBDgjK7y7TUQ@public.gmane.org>, Colin Foe-Parker <colin.foeparker-L+YfUVVR8+RBDgjK7y7TUQ@public.gmane.org>, "linux-omap-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" <linux-omap-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>, "linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org" <linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org> Subject: RE: [PATCH 1/4] mfd: tps65217: Set PMIC to shutdowm on PWR_EN toggle Date: Tue, 6 Nov 2012 05:13:23 +0000 [thread overview] Message-ID: <331ABD5ECB02734CA317220B2BBEABC13EA64F94@DBDE01.ent.ti.com> (raw) In-Reply-To: <5097F078.50701-l0cyMroinI0@public.gmane.org> On Mon, Nov 05, 2012 at 22:29:36, Cousson, Benoit wrote: > + Mark > > On 11/05/2012 10:42 AM, AnilKumar Ch wrote: > > From: Colin Foe-Parker <colin.foeparker-L+YfUVVR8+RBDgjK7y7TUQ@public.gmane.org> > > > > Set tps65217 PMIC status to OFF if power enable toggle is > > supported. Also adds platform data flag, which should be > > passed from board init data. > > > > Signed-off-by: Colin Foe-Parker <colin.foeparker-L+YfUVVR8+RBDgjK7y7TUQ@public.gmane.org> > > [anilkumar-l0cyMroinI0@public.gmane.org: move the additions to tps65217 MFD driver] > > Signed-off-by: AnilKumar Ch <anilkumar-l0cyMroinI0@public.gmane.org> > > --- > > .../devicetree/bindings/regulator/tps65217.txt | 4 ++++ > > drivers/mfd/tps65217.c | 12 ++++++++++++ > > 2 files changed, 16 insertions(+) > > > > diff --git a/Documentation/devicetree/bindings/regulator/tps65217.txt b/Documentation/devicetree/bindings/regulator/tps65217.txt > > index d316fb8..4f05d20 100644 > > --- a/Documentation/devicetree/bindings/regulator/tps65217.txt > > +++ b/Documentation/devicetree/bindings/regulator/tps65217.txt > > @@ -11,6 +11,9 @@ Required properties: > > using the standard binding for regulators found at > > Documentation/devicetree/bindings/regulator/regulator.txt. > > > > +Optional properties: > > +- ti,pmic-shutdown-controller: Telling the PMIC to shutdown on PWR_EN toggle. > > That sounds like a generic functionality to me. Don't we have some more > generic way to handle that? But STATUS_OFF should be set only if Board supports it, otherwise this change doesn't make sense. > > If not, that should probably not be a TI only attribute. > > It looks like a GPIO like kind of interface at PMIC level. I agree this should be a generic parameter, but in some regulators this STATUS OFF control might not be available. This is in my mind while name this parameter. Thanks AnilKumar
WARNING: multiple messages have this Message-ID (diff)
From: anilkumar@ti.com (AnilKumar, Chimata) To: linux-arm-kernel@lists.infradead.org Subject: [PATCH 1/4] mfd: tps65217: Set PMIC to shutdowm on PWR_EN toggle Date: Tue, 6 Nov 2012 05:13:23 +0000 [thread overview] Message-ID: <331ABD5ECB02734CA317220B2BBEABC13EA64F94@DBDE01.ent.ti.com> (raw) In-Reply-To: <5097F078.50701@ti.com> On Mon, Nov 05, 2012 at 22:29:36, Cousson, Benoit wrote: > + Mark > > On 11/05/2012 10:42 AM, AnilKumar Ch wrote: > > From: Colin Foe-Parker <colin.foeparker@logicpd.com> > > > > Set tps65217 PMIC status to OFF if power enable toggle is > > supported. Also adds platform data flag, which should be > > passed from board init data. > > > > Signed-off-by: Colin Foe-Parker <colin.foeparker@logicpd.com> > > [anilkumar at ti.com: move the additions to tps65217 MFD driver] > > Signed-off-by: AnilKumar Ch <anilkumar@ti.com> > > --- > > .../devicetree/bindings/regulator/tps65217.txt | 4 ++++ > > drivers/mfd/tps65217.c | 12 ++++++++++++ > > 2 files changed, 16 insertions(+) > > > > diff --git a/Documentation/devicetree/bindings/regulator/tps65217.txt b/Documentation/devicetree/bindings/regulator/tps65217.txt > > index d316fb8..4f05d20 100644 > > --- a/Documentation/devicetree/bindings/regulator/tps65217.txt > > +++ b/Documentation/devicetree/bindings/regulator/tps65217.txt > > @@ -11,6 +11,9 @@ Required properties: > > using the standard binding for regulators found at > > Documentation/devicetree/bindings/regulator/regulator.txt. > > > > +Optional properties: > > +- ti,pmic-shutdown-controller: Telling the PMIC to shutdown on PWR_EN toggle. > > That sounds like a generic functionality to me. Don't we have some more > generic way to handle that? But STATUS_OFF should be set only if Board supports it, otherwise this change doesn't make sense. > > If not, that should probably not be a TI only attribute. > > It looks like a GPIO like kind of interface at PMIC level. I agree this should be a generic parameter, but in some regulators this STATUS OFF control might not be available. This is in my mind while name this parameter. Thanks AnilKumar
next prev parent reply other threads:[~2012-11-06 5:13 UTC|newest] Thread overview: 58+ messages / expand[flat|nested] mbox.gz Atom feed top 2012-11-05 9:42 [PATCH 0/4] pm: Add power off control AnilKumar Ch 2012-11-05 9:42 ` AnilKumar Ch 2012-11-05 9:42 ` [PATCH 1/4] mfd: tps65217: Set PMIC to shutdowm on PWR_EN toggle AnilKumar Ch 2012-11-05 9:42 ` AnilKumar Ch [not found] ` <1352108549-9341-2-git-send-email-anilkumar-l0cyMroinI0@public.gmane.org> 2012-11-05 16:59 ` Benoit Cousson 2012-11-05 16:59 ` Benoit Cousson [not found] ` <5097F078.50701-l0cyMroinI0@public.gmane.org> 2012-11-06 5:13 ` AnilKumar, Chimata [this message] 2012-11-06 5:13 ` AnilKumar, Chimata 2012-11-14 2:23 ` Mark Brown 2012-11-14 2:23 ` Mark Brown [not found] ` <20121114022341.GM4415-yzvPICuk2AATkU/dhu1WVueM+bqZidxxQQ4Iyu8u01E@public.gmane.org> 2012-11-14 5:10 ` AnilKumar, Chimata 2012-11-14 5:10 ` AnilKumar, Chimata 2012-11-14 6:11 ` AnilKumar, Chimata 2012-11-14 6:11 ` AnilKumar, Chimata 2012-11-14 6:21 ` Mark Brown 2012-11-14 6:21 ` Mark Brown [not found] ` <20121114062117.GC7407-yzvPICuk2AATkU/dhu1WVueM+bqZidxxQQ4Iyu8u01E@public.gmane.org> 2012-11-14 6:49 ` AnilKumar, Chimata 2012-11-14 6:49 ` AnilKumar, Chimata 2012-11-14 7:00 ` Mark Brown 2012-11-14 7:00 ` Mark Brown [not found] ` <20121114070046.GE7407-yzvPICuk2AATkU/dhu1WVueM+bqZidxxQQ4Iyu8u01E@public.gmane.org> 2012-11-14 10:08 ` Benoit Cousson 2012-11-14 10:08 ` Benoit Cousson 2012-11-14 10:24 ` Mark Brown 2012-11-14 10:24 ` Mark Brown [not found] ` <20121114102452.GI7407-yzvPICuk2AATkU/dhu1WVueM+bqZidxxQQ4Iyu8u01E@public.gmane.org> 2012-11-16 6:16 ` AnilKumar, Chimata 2012-11-16 6:16 ` AnilKumar, Chimata 2012-11-05 9:42 ` [PATCH 2/4] rtc: OMAP: Add system pm_power_off to rtc driver AnilKumar Ch 2012-11-05 9:42 ` AnilKumar Ch [not found] ` <1352108549-9341-3-git-send-email-anilkumar-l0cyMroinI0@public.gmane.org> 2012-11-05 16:43 ` Benoit Cousson 2012-11-05 16:43 ` Benoit Cousson [not found] ` <5097ECAD.9010101-l0cyMroinI0@public.gmane.org> 2012-11-05 17:39 ` Colin FoeParker 2012-11-05 17:39 ` Colin FoeParker 2012-11-06 5:07 ` AnilKumar, Chimata 2012-11-06 5:07 ` AnilKumar, Chimata 2012-11-06 16:56 ` Benoit Cousson 2012-11-06 16:56 ` Benoit Cousson [not found] ` <50994156.4080305-l0cyMroinI0@public.gmane.org> 2012-11-12 9:47 ` AnilKumar, Chimata 2012-11-12 9:47 ` AnilKumar, Chimata 2012-11-14 5:01 ` AnilKumar, Chimata 2012-11-14 5:01 ` AnilKumar, Chimata 2012-11-14 5:21 ` Mark Brown 2012-11-14 5:21 ` Mark Brown 2012-11-14 5:50 ` AnilKumar, Chimata 2012-11-14 5:50 ` AnilKumar, Chimata 2012-11-14 6:00 ` Mark Brown 2012-11-14 6:00 ` Mark Brown 2012-11-06 5:45 ` Bedia, Vaibhav 2012-11-06 5:45 ` Bedia, Vaibhav [not found] ` <B5906170F1614E41A8A28DE3B8D121433EC04226-Er742YJ7I/eIQmiDNMet8wC/G2K4zDHf@public.gmane.org> 2012-11-12 9:47 ` AnilKumar, Chimata 2012-11-12 9:47 ` AnilKumar, Chimata 2012-11-16 6:13 ` AnilKumar, Chimata 2012-11-16 6:13 ` AnilKumar, Chimata 2012-11-16 10:47 ` AnilKumar, Chimata 2012-11-16 10:47 ` AnilKumar, Chimata 2012-11-05 9:42 ` [PATCH 3/4] ARM: dts: AM33XX: Set pmic-shutdown-controller for BeagleBone AnilKumar Ch 2012-11-05 9:42 ` AnilKumar Ch [not found] ` <1352108549-9341-1-git-send-email-anilkumar-l0cyMroinI0@public.gmane.org> 2012-11-05 9:42 ` [PATCH 4/4] ARM: dts: AM33XX: Enable system power off control in am335x-bone AnilKumar Ch 2012-11-05 9:42 ` AnilKumar Ch
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=331ABD5ECB02734CA317220B2BBEABC13EA64F94@DBDE01.ent.ti.com \ --to=anilkumar-l0cymroini0@public.gmane.org \ --cc=a.zummo-BfzFCNDTiLLj+vYz1yj4TQ@public.gmane.org \ --cc=b-cousson-l0cyMroinI0@public.gmane.org \ --cc=broonie-yzvPICuk2AATkU/dhu1WVueM+bqZidxxQQ4Iyu8u01E@public.gmane.org \ --cc=colin.foeparker-L+YfUVVR8+RBDgjK7y7TUQ@public.gmane.org \ --cc=devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org \ --cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \ --cc=linux-omap-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \ --cc=rob.herring-bsGFqQB8/DxBDgjK7y7TUQ@public.gmane.org \ --cc=rtc-linux-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org \ --cc=sameo-VuQAYsv1563Yd54FQh9/CA@public.gmane.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.