All of lore.kernel.org
 help / color / mirror / Atom feed
From: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
To: Pankaj Dubey <pankaj.dubey@samsung.com>
Cc: linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, linux-samsung-soc@vger.kernel.org,
	linux-pci@vger.kernel.org, jingoohan1@gmail.com,
	Niyas Ahmed S T <niyas.ahmed@samsung.com>,
	krzk@kernel.org, jh80.chung@samsung.com, kgene@kernel.org,
	alim.akhtar@samsung.com, bhelgaas@google.com, sanath@samsung.com
Subject: Re: [PATCH] PCI: exynos: refactor exynos pcie driver
Date: Tue, 27 Dec 2016 14:35:54 +0100	[thread overview]
Message-ID: <3335251.c58Y1Zf7PB@amdc3058> (raw)
In-Reply-To: <1482490587-13611-1-git-send-email-pankaj.dubey@samsung.com>


Hi,

On Friday, December 23, 2016 04:26:27 PM Pankaj Dubey wrote:
> From: Niyas Ahmed S T <niyas.ahmed@samsung.com>
> 
> Currently Exynos PCIe driver is only supported for Exynos5440 SoC.
> This patch does refactoring of Exynos PCIe driver to extend support
> for other Exynos SoC.
> 
> Following are the main changes done via this patch:
> 1) It adds separate structs for memory, clock resources.
> 2) It add exynos_pcie_ops struct which will allow us to support the
> differences in resources in different Exynos SoC.
> 
> No functional change intended.
> 
> Signed-off-by: Niyas Ahmed S T <niyas.ahmed@samsung.com>
> Signed-off-by: Pankaj Dubey <pankaj.dubey@samsung.com>

I would also like to see the explanation for 1) (as already
requested by Jingoo).  Otherwise it all looks fine to me:

Reviewed-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>

Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R&D Institute Poland
Samsung Electronics

WARNING: multiple messages have this Message-ID (diff)
From: b.zolnierkie@samsung.com (Bartlomiej Zolnierkiewicz)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] PCI: exynos: refactor exynos pcie driver
Date: Tue, 27 Dec 2016 14:35:54 +0100	[thread overview]
Message-ID: <3335251.c58Y1Zf7PB@amdc3058> (raw)
In-Reply-To: <1482490587-13611-1-git-send-email-pankaj.dubey@samsung.com>


Hi,

On Friday, December 23, 2016 04:26:27 PM Pankaj Dubey wrote:
> From: Niyas Ahmed S T <niyas.ahmed@samsung.com>
> 
> Currently Exynos PCIe driver is only supported for Exynos5440 SoC.
> This patch does refactoring of Exynos PCIe driver to extend support
> for other Exynos SoC.
> 
> Following are the main changes done via this patch:
> 1) It adds separate structs for memory, clock resources.
> 2) It add exynos_pcie_ops struct which will allow us to support the
> differences in resources in different Exynos SoC.
> 
> No functional change intended.
> 
> Signed-off-by: Niyas Ahmed S T <niyas.ahmed@samsung.com>
> Signed-off-by: Pankaj Dubey <pankaj.dubey@samsung.com>

I would also like to see the explanation for 1) (as already
requested by Jingoo).  Otherwise it all looks fine to me:

Reviewed-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>

Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R&D Institute Poland
Samsung Electronics

  parent reply	other threads:[~2016-12-27 13:36 UTC|newest]

Thread overview: 56+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <CGME20161223105411epcas1p3727f726e757ec6c6d7bff04a9af40077@epcas1p3.samsung.com>
2016-12-23 10:56 ` [PATCH] PCI: exynos: refactor exynos pcie driver Pankaj Dubey
2016-12-23 10:56   ` Pankaj Dubey
2016-12-23 10:56   ` Pankaj Dubey
2016-12-23 18:37   ` Jingoo Han
2016-12-23 18:37     ` Jingoo Han
2016-12-23 18:37     ` Jingoo Han
2016-12-23 18:37     ` Jingoo Han
2016-12-27  3:27     ` Pankaj Dubey
2016-12-27  3:27       ` Pankaj Dubey
2016-12-27  3:27       ` Pankaj Dubey
2016-12-27  3:27       ` Pankaj Dubey
2016-12-24  9:25   ` Krzysztof Kozlowski
2016-12-24  9:25     ` Krzysztof Kozlowski
2016-12-26  9:02   ` Jaehoon Chung
2016-12-26  9:02     ` Jaehoon Chung
2016-12-26  9:06     ` Jaehoon Chung
2016-12-26  9:06       ` Jaehoon Chung
2016-12-26  9:46     ` Alim Akhtar
2016-12-26  9:46       ` Alim Akhtar
2016-12-26  9:46       ` Alim Akhtar
2016-12-27  1:09       ` Jaehoon Chung
2016-12-27  1:09         ` Jaehoon Chung
2016-12-27  1:09         ` Jaehoon Chung
2016-12-27  2:12         ` Alim Akhtar
2016-12-27  2:12           ` Alim Akhtar
2016-12-27  2:12           ` Alim Akhtar
2016-12-27  2:30           ` Jaehoon Chung
2016-12-27  2:30             ` Jaehoon Chung
2016-12-27  2:30             ` Jaehoon Chung
2016-12-27  6:34             ` Alim Akhtar
2016-12-27  6:34               ` Alim Akhtar
2016-12-27 10:18               ` Jaehoon Chung
2016-12-27 10:18                 ` Jaehoon Chung
2016-12-28  3:10                 ` Pankaj Dubey
2016-12-28  3:10                   ` Pankaj Dubey
2016-12-28  3:10                   ` Pankaj Dubey
2016-12-28  5:25                   ` Jaehoon Chung
2016-12-28  5:25                     ` Jaehoon Chung
2016-12-28  5:25                     ` Jaehoon Chung
2016-12-28  5:25                     ` Jaehoon Chung
2016-12-26 14:43     ` Jingoo Han
2016-12-26 14:43       ` Jingoo Han
2016-12-26 14:43       ` Jingoo Han
2016-12-26 14:43       ` Jingoo Han
2016-12-27  1:12       ` Jaehoon Chung
2016-12-27  1:12         ` Jaehoon Chung
2016-12-27  1:12         ` Jaehoon Chung
2016-12-27  4:21     ` Pankaj Dubey
2016-12-27  4:21       ` Pankaj Dubey
2016-12-27  4:21       ` Pankaj Dubey
2016-12-27  4:21       ` Pankaj Dubey
2016-12-27 13:35   ` Bartlomiej Zolnierkiewicz [this message]
2016-12-27 13:35     ` Bartlomiej Zolnierkiewicz
2016-12-28  3:13     ` Pankaj Dubey
2016-12-28  3:13       ` Pankaj Dubey
2016-12-28  3:13       ` Pankaj Dubey

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3335251.c58Y1Zf7PB@amdc3058 \
    --to=b.zolnierkie@samsung.com \
    --cc=alim.akhtar@samsung.com \
    --cc=bhelgaas@google.com \
    --cc=jh80.chung@samsung.com \
    --cc=jingoohan1@gmail.com \
    --cc=kgene@kernel.org \
    --cc=krzk@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=linux-samsung-soc@vger.kernel.org \
    --cc=niyas.ahmed@samsung.com \
    --cc=pankaj.dubey@samsung.com \
    --cc=sanath@samsung.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.