[Buildroot] [PATCH] package/madplay: fix build failure due to old autotools macro

[Buildroot] [PATCH] package/madplay: fix build failure due to old autotools macro

[Giulio Benetti]

MKINSTALLDIRS is not automatically called by autotools when
autoreconfigured.
This leads to have install stage error:
`/bin/sh @MKINSTALLDIRS@
/home/dawncrow/buildroot-test/scripts/instance-0/output/target/usr/share
/bin/sh: 0: Can't open @MKINSTALLDIRS@`
because @MKINSTALLDIRS@ doesn't get substituted during autoreconf.

Add patch that explicitly calls AM_MKINSTALLDIRS macro to substitute
every @MKINSTALLDIRS@ occurence in *.in Makefile.

Fixes:
http://autobuild.buildroot.net/results/744/7447c03426556f787f20f7ab2d36f0cacc4af1bd/

Signed-off-by: Giulio Benetti <giulio.benetti@micronovasrl.com>
---
 ...4-configure-ac-call-AM_MKINSTALLDIRS.patch | 23 +++++++++++++++++++
 1 file changed, 23 insertions(+)
 create mode 100644 package/madplay/0004-configure-ac-call-AM_MKINSTALLDIRS.patch

diff --git a/package/madplay/0004-configure-ac-call-AM_MKINSTALLDIRS.patch b/package/madplay/0004-configure-ac-call-AM_MKINSTALLDIRS.patch
new file mode 100644
index 0000000000..bc6c97efae
--- /dev/null
+++ b/package/madplay/0004-configure-ac-call-AM_MKINSTALLDIRS.patch
@@ -0,0 +1,23 @@
+configure.ac: call AM_MKINSTALLDIRS to substitute @MKINSTALLDIRS@
+
+MKINSTALLDIRS is obsolete and doesn't get automatically called.
+
+Force call AM_MKINSTALLDIRS() macro to substitute every @MKINSTALLDIRS@
+occurence in *.in files.
+
+Signed-off-by: Giulio Benetti <giulio.benetti@micronovasrl.com>
+
+diff -urpN madplay-0.15.2b.orig/configure.ac madplay-0.15.2b/configure.ac
+--- madplay-0.15.2b.orig/configure.ac	2019-04-16 12:06:03.781018755 +0200
++++ madplay-0.15.2b/configure.ac	2019-04-16 12:07:48.399162610 +0200
+@@ -146,6 +146,10 @@ ALL_LINGUAS="en es fr hr no"
+ AM_GNU_GETTEXT([use-libtool])
+ AM_GNU_GETTEXT_VERSION(0.14.1)
+ 
++dnl Make sure AM_MKINSTALLDIRS gets called
++
++AM_MKINSTALLDIRS()
++
+ dnl Checks for header files.
+ 
+ AC_HEADER_STDC
-- 
2.17.1

[Buildroot] [PATCH] package/madplay: fix build failure due to old autotools macro

[Arnout Vandecappelle]

On 16/04/2019 12:21, Giulio Benetti wrote:
> MKINSTALLDIRS is not automatically called by autotools when
> autoreconfigured.
> This leads to have install stage error:
> `/bin/sh @MKINSTALLDIRS@
> /home/dawncrow/buildroot-test/scripts/instance-0/output/target/usr/share
> /bin/sh: 0: Can't open @MKINSTALLDIRS@`
> because @MKINSTALLDIRS@ doesn't get substituted during autoreconf.
> 
> Add patch that explicitly calls AM_MKINSTALLDIRS macro to substitute
> every @MKINSTALLDIRS@ occurence in *.in Makefile.
> 
> Fixes:
> http://autobuild.buildroot.net/results/744/7447c03426556f787f20f7ab2d36f0cacc4af1bd/
> 
> Signed-off-by: Giulio Benetti <giulio.benetti@micronovasrl.com>
> ---
>  ...4-configure-ac-call-AM_MKINSTALLDIRS.patch | 23 +++++++++++++++++++
>  1 file changed, 23 insertions(+)
>  create mode 100644 package/madplay/0004-configure-ac-call-AM_MKINSTALLDIRS.patch
> 
> diff --git a/package/madplay/0004-configure-ac-call-AM_MKINSTALLDIRS.patch b/package/madplay/0004-configure-ac-call-AM_MKINSTALLDIRS.patch
> new file mode 100644
> index 0000000000..bc6c97efae
> --- /dev/null
> +++ b/package/madplay/0004-configure-ac-call-AM_MKINSTALLDIRS.patch
> @@ -0,0 +1,23 @@
> +configure.ac: call AM_MKINSTALLDIRS to substitute @MKINSTALLDIRS@
> +
> +MKINSTALLDIRS is obsolete and doesn't get automatically called.
> +
> +Force call AM_MKINSTALLDIRS() macro to substitute every @MKINSTALLDIRS@
> +occurence in *.in files.
> +
> +Signed-off-by: Giulio Benetti <giulio.benetti@micronovasrl.com>

 What is the upstream status of this patch?

> +
> +diff -urpN madplay-0.15.2b.orig/configure.ac madplay-0.15.2b/configure.ac
> +--- madplay-0.15.2b.orig/configure.ac	2019-04-16 12:06:03.781018755 +0200
> ++++ madplay-0.15.2b/configure.ac	2019-04-16 12:07:48.399162610 +0200
> +@@ -146,6 +146,10 @@ ALL_LINGUAS="en es fr hr no"
> + AM_GNU_GETTEXT([use-libtool])
> + AM_GNU_GETTEXT_VERSION(0.14.1)
> + 
> ++dnl Make sure AM_MKINSTALLDIRS gets called

 That comment just repeats the function call. Better:

dnl Substitute MKINSTALLDIRS

 Regards,
 Arnout

> ++
> ++AM_MKINSTALLDIRS()
> ++
> + dnl Checks for header files.
> + 
> + AC_HEADER_STDC
> 

[Buildroot] [PATCH] package/madplay: fix build failure due to old autotools macro

[Giulio Benetti]

Hello Arnout,

Il 16/04/2019 21:45, Arnout Vandecappelle ha scritto:
> 
> 
> On 16/04/2019 12:21, Giulio Benetti wrote:
>> MKINSTALLDIRS is not automatically called by autotools when
>> autoreconfigured.
>> This leads to have install stage error:
>> `/bin/sh @MKINSTALLDIRS@
>> /home/dawncrow/buildroot-test/scripts/instance-0/output/target/usr/share
>> /bin/sh: 0: Can't open @MKINSTALLDIRS@`
>> because @MKINSTALLDIRS@ doesn't get substituted during autoreconf.
>>
>> Add patch that explicitly calls AM_MKINSTALLDIRS macro to substitute
>> every @MKINSTALLDIRS@ occurence in *.in Makefile.
>>
>> Fixes:
>> http://autobuild.buildroot.net/results/744/7447c03426556f787f20f7ab2d36f0cacc4af1bd/
>>
>> Signed-off-by: Giulio Benetti <giulio.benetti@micronovasrl.com>
>> ---
>>   ...4-configure-ac-call-AM_MKINSTALLDIRS.patch | 23 +++++++++++++++++++
>>   1 file changed, 23 insertions(+)
>>   create mode 100644 package/madplay/0004-configure-ac-call-AM_MKINSTALLDIRS.patch
>>
>> diff --git a/package/madplay/0004-configure-ac-call-AM_MKINSTALLDIRS.patch b/package/madplay/0004-configure-ac-call-AM_MKINSTALLDIRS.patch
>> new file mode 100644
>> index 0000000000..bc6c97efae
>> --- /dev/null
>> +++ b/package/madplay/0004-configure-ac-call-AM_MKINSTALLDIRS.patch
>> @@ -0,0 +1,23 @@
>> +configure.ac: call AM_MKINSTALLDIRS to substitute @MKINSTALLDIRS@
>> +
>> +MKINSTALLDIRS is obsolete and doesn't get automatically called.
>> +
>> +Force call AM_MKINSTALLDIRS() macro to substitute every @MKINSTALLDIRS@
>> +occurence in *.in files.
>> +
>> +Signed-off-by: Giulio Benetti <giulio.benetti@micronovasrl.com>
> 
>   What is the upstream status of this patch?

It seems almost dead the development, latest release is old, 2004:
https://sourceforge.net/projects/mad/files/
there are several patches pending but nothing seems to move on:
https://sourceforge.net/p/mad/patches/

I haven't found any other possible upstream different from sourceforge.
Do you know if there's another one?

Or do I send patch anyway on Sourceforge and leave it there?

>> +
>> +diff -urpN madplay-0.15.2b.orig/configure.ac madplay-0.15.2b/configure.ac
>> +--- madplay-0.15.2b.orig/configure.ac	2019-04-16 12:06:03.781018755 +0200
>> ++++ madplay-0.15.2b/configure.ac	2019-04-16 12:07:48.399162610 +0200
>> +@@ -146,6 +146,10 @@ ALL_LINGUAS="en es fr hr no"
>> + AM_GNU_GETTEXT([use-libtool])
>> + AM_GNU_GETTEXT_VERSION(0.14.1)
>> +
>> ++dnl Make sure AM_MKINSTALLDIRS gets called
> 
>   That comment just repeats the function call. Better:
> 
> dnl Substitute MKINSTALLDIRS

Yes, right.

Thank you
Kind regards
-- 
Giulio Benetti
CTO

MICRONOVA SRL
Sede: Via A. Niedda 3 - 35010 Vigonza (PD)
Tel. 049/8931563 - Fax 049/8931346
Cod.Fiscale - P.IVA 02663420285
Capitale Sociale ? 26.000 i.v.
Iscritta al Reg. Imprese di Padova N. 02663420285
Numero R.E.A. 258642

[Buildroot] [PATCH] package/madplay: fix build failure due to old autotools macro

[Thomas Petazzoni]

On Tue, 16 Apr 2019 12:21:25 +0200
Giulio Benetti <giulio.benetti@micronovasrl.com> wrote:

> MKINSTALLDIRS is not automatically called by autotools when
> autoreconfigured.
> This leads to have install stage error:
> `/bin/sh @MKINSTALLDIRS@
> /home/dawncrow/buildroot-test/scripts/instance-0/output/target/usr/share
> /bin/sh: 0: Can't open @MKINSTALLDIRS@`
> because @MKINSTALLDIRS@ doesn't get substituted during autoreconf.
> 
> Add patch that explicitly calls AM_MKINSTALLDIRS macro to substitute
> every @MKINSTALLDIRS@ occurence in *.in Makefile.
> 
> Fixes:
> http://autobuild.buildroot.net/results/744/7447c03426556f787f20f7ab2d36f0cacc4af1bd/
> 
> Signed-off-by: Giulio Benetti <giulio.benetti@micronovasrl.com>

Why is this package suddenly failing to build ? madplay hasn't been
updated recently, so why do we have build failures and not before ?

Isn't the build failure related to the switch from gettext-gnu to
gettext-tiny ?

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

[Buildroot] [PATCH] package/madplay: fix build failure due to old autotools macro

[Giulio Benetti]

Hello Thomas,

Il 16/04/2019 22:13, Thomas Petazzoni ha scritto:
> On Tue, 16 Apr 2019 12:21:25 +0200
> Giulio Benetti <giulio.benetti@micronovasrl.com> wrote:
> 
>> MKINSTALLDIRS is not automatically called by autotools when
>> autoreconfigured.
>> This leads to have install stage error:
>> `/bin/sh @MKINSTALLDIRS@
>> /home/dawncrow/buildroot-test/scripts/instance-0/output/target/usr/share
>> /bin/sh: 0: Can't open @MKINSTALLDIRS@`
>> because @MKINSTALLDIRS@ doesn't get substituted during autoreconf.
>>
>> Add patch that explicitly calls AM_MKINSTALLDIRS macro to substitute
>> every @MKINSTALLDIRS@ occurence in *.in Makefile.
>>
>> Fixes:
>> http://autobuild.buildroot.net/results/744/7447c03426556f787f20f7ab2d36f0cacc4af1bd/
>>
>> Signed-off-by: Giulio Benetti <giulio.benetti@micronovasrl.com>
> 
> Why is this package suddenly failing to build ? madplay hasn't been
> updated recently, so why do we have build failures and not before ?

MKINSTALLDIRS is very obsolete, but Autoconf and Automake are the same 
version since 2017 and 2018, so they're not the problem even if I 
thought they were.
First failure is dated 14-04-2019.

> Isn't the build failure related to the switch from gettext-gnu to
> gettext-tiny ?

.config has "gettext-gnu" not "gettext-tiny", so that doesn't seem the 
problem.
I try to dig deeper.

Best regards
-- 
Giulio Benetti
CTO

MICRONOVA SRL
Sede: Via A. Niedda 3 - 35010 Vigonza (PD)
Tel. 049/8931563 - Fax 049/8931346
Cod.Fiscale - P.IVA 02663420285
Capitale Sociale ? 26.000 i.v.
Iscritta al Reg. Imprese di Padova N. 02663420285
Numero R.E.A. 258642

> Thomas
> 

[Buildroot] [PATCH] package/madplay: fix build failure due to old autotools macro

[Giulio Benetti]

Hello Thomas,

Il 16/04/2019 23:47, Giulio Benetti ha scritto:
> Hello Thomas,
> 
> Il 16/04/2019 22:13, Thomas Petazzoni ha scritto:
>> On Tue, 16 Apr 2019 12:21:25 +0200
>> Giulio Benetti <giulio.benetti@micronovasrl.com> wrote:
>>
>>> MKINSTALLDIRS is not automatically called by autotools when
>>> autoreconfigured.
>>> This leads to have install stage error:
>>> `/bin/sh @MKINSTALLDIRS@
>>> /home/dawncrow/buildroot-test/scripts/instance-0/output/target/usr/share
>>> /bin/sh: 0: Can't open @MKINSTALLDIRS@`
>>> because @MKINSTALLDIRS@ doesn't get substituted during autoreconf.
>>>
>>> Add patch that explicitly calls AM_MKINSTALLDIRS macro to substitute
>>> every @MKINSTALLDIRS@ occurence in *.in Makefile.
>>>
>>> Fixes:
>>> http://autobuild.buildroot.net/results/744/7447c03426556f787f20f7ab2d36f0cacc4af1bd/
>>>
>>> Signed-off-by: Giulio Benetti <giulio.benetti@micronovasrl.com>
>>
>> Why is this package suddenly failing to build ? madplay hasn't been
>> updated recently, so why do we have build failures and not before ?
> 
> MKINSTALLDIRS is very obsolete, but Autoconf and Automake are the same
> version since 2017 and 2018, so they're not the problem even if I
> thought they were.
> First failure is dated 14-04-2019.

Found, it is due to this patch:
https://git.buildroot.net/buildroot/commit/?id=c05cc5de868cc5af27afdb1451e30fcd1ecb2856

It sets MADPLAY_AUTORECONF = YES in madplay.mk

Then "autoreconf" is called and this is why @MKINSTALLDIRS@ is not 
substituted correctly, due to obsolescence of MKINSTALLDIRS macro.

I hope I've explained it decently.

>> Isn't the build failure related to the switch from gettext-gnu to
>> gettext-tiny ?
> 
> .config has "gettext-gnu" not "gettext-tiny", so that doesn't seem the
> problem.
> I try to dig deeper.
> 
> Best regards
> 

Best regards
-- 
Giulio Benetti
CTO

MICRONOVA SRL
Sede: Via A. Niedda 3 - 35010 Vigonza (PD)
Tel. 049/8931563 - Fax 049/8931346
Cod.Fiscale - P.IVA 02663420285
Capitale Sociale ? 26.000 i.v.
Iscritta al Reg. Imprese di Padova N. 02663420285
Numero R.E.A. 258642

[Buildroot] [PATCH] package/madplay: fix build failure due to old autotools macro

[Arnout Vandecappelle]

On 17/04/2019 14:45, Giulio Benetti wrote:
> Hello Thomas,
> 
> Il 16/04/2019 23:47, Giulio Benetti ha scritto:
>> Hello Thomas,
>>
>> Il 16/04/2019 22:13, Thomas Petazzoni ha scritto:
>>> On Tue, 16 Apr 2019 12:21:25 +0200
>>> Giulio Benetti <giulio.benetti@micronovasrl.com> wrote:
>>>
>>>> MKINSTALLDIRS is not automatically called by autotools when
>>>> autoreconfigured.
>>>> This leads to have install stage error:
>>>> `/bin/sh @MKINSTALLDIRS@
>>>> /home/dawncrow/buildroot-test/scripts/instance-0/output/target/usr/share
>>>> /bin/sh: 0: Can't open @MKINSTALLDIRS@`
>>>> because @MKINSTALLDIRS@ doesn't get substituted during autoreconf.
>>>>
>>>> Add patch that explicitly calls AM_MKINSTALLDIRS macro to substitute
>>>> every @MKINSTALLDIRS@ occurence in *.in Makefile.
>>>>
>>>> Fixes:
>>>> http://autobuild.buildroot.net/results/744/7447c03426556f787f20f7ab2d36f0cacc4af1bd/
>>>>
>>>>
>>>> Signed-off-by: Giulio Benetti <giulio.benetti@micronovasrl.com>
>>>
>>> Why is this package suddenly failing to build ? madplay hasn't been
>>> updated recently, so why do we have build failures and not before ?
>>
>> MKINSTALLDIRS is very obsolete, but Autoconf and Automake are the same
>> version since 2017 and 2018, so they're not the problem even if I
>> thought they were.
>> First failure is dated 14-04-2019.
> 
> Found, it is due to this patch:
> https://git.buildroot.net/buildroot/commit/?id=c05cc5de868cc5af27afdb1451e30fcd1ecb2856

 That commit was applied to master on Feb 15. However, the autobuilder errors
started on April 14. (There were also a number of autobuild errors in February,
but they were different errors and they were fixed.)

 So no, that doesn't explain it.

 What does explain it, however, is that NLS was only enabled in the autobuilders
since commit 472e8808d928af9787abd3303fb0b2b4d5916946 which I applied on April 14.

 The thing is, all the @MKINSTALLDIRS@ things are under a condition like

if test "$(PACKAGE)" = "gettext-tools"; then

except for one, which is unconditional but is part of the rule

install-data-yes: all
        $(mkinstalldirs) $(DESTDIR)$(datadir)

and this rule only gets triggered by

install-data: install-data- at USE_NLS@

and obviously USE_NLS = yes only if NLS is enabled.

 So, that explains why this issue appears only now. Therefore, I've applied to
master (after modifying the comment). I've also reworked the commit log a little.

 Regards,
 Arnout



> It sets MADPLAY_AUTORECONF = YES in madplay.mk
> 
> Then "autoreconf" is called and this is why @MKINSTALLDIRS@ is not substituted
> correctly, due to obsolescence of MKINSTALLDIRS macro.
> 
> I hope I've explained it decently.
> 
>>> Isn't the build failure related to the switch from gettext-gnu to
>>> gettext-tiny ?
>>
>> .config has "gettext-gnu" not "gettext-tiny", so that doesn't seem the
>> problem.
>> I try to dig deeper.
>>
>> Best regards
>>
> 
> Best regards

[Buildroot] [PATCH] package/madplay: fix build failure due to old autotools macro

[Giulio Benetti]

Hello Arnout,

Il 17/04/2019 22:04, Arnout Vandecappelle ha scritto:
> 
> 
> On 17/04/2019 14:45, Giulio Benetti wrote:
>> Hello Thomas,
>>
>> Il 16/04/2019 23:47, Giulio Benetti ha scritto:
>>> Hello Thomas,
>>>
>>> Il 16/04/2019 22:13, Thomas Petazzoni ha scritto:
>>>> On Tue, 16 Apr 2019 12:21:25 +0200
>>>> Giulio Benetti <giulio.benetti@micronovasrl.com> wrote:
>>>>
>>>>> MKINSTALLDIRS is not automatically called by autotools when
>>>>> autoreconfigured.
>>>>> This leads to have install stage error:
>>>>> `/bin/sh @MKINSTALLDIRS@
>>>>> /home/dawncrow/buildroot-test/scripts/instance-0/output/target/usr/share
>>>>> /bin/sh: 0: Can't open @MKINSTALLDIRS@`
>>>>> because @MKINSTALLDIRS@ doesn't get substituted during autoreconf.
>>>>>
>>>>> Add patch that explicitly calls AM_MKINSTALLDIRS macro to substitute
>>>>> every @MKINSTALLDIRS@ occurence in *.in Makefile.
>>>>>
>>>>> Fixes:
>>>>> http://autobuild.buildroot.net/results/744/7447c03426556f787f20f7ab2d36f0cacc4af1bd/
>>>>>
>>>>>
>>>>> Signed-off-by: Giulio Benetti <giulio.benetti@micronovasrl.com>
>>>>
>>>> Why is this package suddenly failing to build ? madplay hasn't been
>>>> updated recently, so why do we have build failures and not before ?
>>>
>>> MKINSTALLDIRS is very obsolete, but Autoconf and Automake are the same
>>> version since 2017 and 2018, so they're not the problem even if I
>>> thought they were.
>>> First failure is dated 14-04-2019.
>>
>> Found, it is due to this patch:
>> https://git.buildroot.net/buildroot/commit/?id=c05cc5de868cc5af27afdb1451e30fcd1ecb2856
> 
>   That commit was applied to master on Feb 15. However, the autobuilder errors
> started on April 14. (There were also a number of autobuild errors in February,
> but they were different errors and they were fixed.)
> 
>   So no, that doesn't explain it.
> 
>   What does explain it, however, is that NLS was only enabled in the autobuilders
> since commit 472e8808d928af9787abd3303fb0b2b4d5916946 which I applied on April 14.
> 
>   The thing is, all the @MKINSTALLDIRS@ things are under a condition like
> 
> if test "$(PACKAGE)" = "gettext-tools"; then
> 
> except for one, which is unconditional but is part of the rule
> 
> install-data-yes: all
>          $(mkinstalldirs) $(DESTDIR)$(datadir)
> 
> and this rule only gets triggered by
> 
> install-data: install-data- at USE_NLS@
> 
> and obviously USE_NLS = yes only if NLS is enabled.
> 
>   So, that explains why this issue appears only now. Therefore, I've applied to
> master (after modifying the comment). I've also reworked the commit log a little.

So as we've discussed in IRC, to summarize:
- AUTORECONF = yes exposed potential build error(install specifically), 
but autobuilders still didn't call Makefile install-data recipe(where 
error was)
then:
- you've applied a patch to autobuilders that enabled NLS support, this 
way Makefile install-data recipe started to get called and then build failed

Thank you for the deep explanation.

Kind regards
-- 
Giulio Benetti
CTO

MICRONOVA SRL
Sede: Via A. Niedda 3 - 35010 Vigonza (PD)
Tel. 049/8931563 - Fax 049/8931346
Cod.Fiscale - P.IVA 02663420285
Capitale Sociale ? 26.000 i.v.
Iscritta al Reg. Imprese di Padova N. 02663420285
Numero R.E.A. 258642

>   Regards,
>   Arnout
> 
> 
> 
>> It sets MADPLAY_AUTORECONF = YES in madplay.mk
>>
>> Then "autoreconf" is called and this is why @MKINSTALLDIRS@ is not substituted
>> correctly, due to obsolescence of MKINSTALLDIRS macro.
>>
>> I hope I've explained it decently.
>>
>>>> Isn't the build failure related to the switch from gettext-gnu to
>>>> gettext-tiny ?
>>>
>>> .config has "gettext-gnu" not "gettext-tiny", so that doesn't seem the
>>> problem.
>>> I try to dig deeper.
>>>
>>> Best regards
>>>
>>
>> Best regards