* [Buildroot] [PATCH] exfat, exfat-utils: fix the installation path of the helper utilities
@ 2019-09-12 7:17 Wolfgang Grandegger
2019-09-20 13:15 ` Carlos Santos
2019-09-21 11:39 ` Arnout Vandecappelle
0 siblings, 2 replies; 7+ messages in thread
From: Wolfgang Grandegger @ 2019-09-12 7:17 UTC (permalink / raw)
To: buildroot
"mount" from the "util-linux" package does expect the helper utilities
in "/sbin" and not "/usr/sbin".
Signed-off-by: Wolfgang Grandegger <wg@grandegger.com>
---
package/exfat-utils/exfat-utils.mk | 2 ++
package/exfat/exfat.mk | 2 ++
2 files changed, 4 insertions(+)
diff --git a/package/exfat-utils/exfat-utils.mk b/package/exfat-utils/exfat-utils.mk
index 62cd471..d22d5c9 100644
--- a/package/exfat-utils/exfat-utils.mk
+++ b/package/exfat-utils/exfat-utils.mk
@@ -9,4 +9,6 @@ EXFAT_UTILS_SITE = https://github.com/relan/exfat/releases/download/v$(EXFAT_UTI
EXFAT_UTILS_LICENSE = GPL-3.0+
EXFAT_UTILS_LICENSE_FILES = COPYING
+EXFAT_UTILS_CONF_OPTS += --bindir=/bin --sbindir=/sbin --libdir=/lib
+
$(eval $(autotools-package))
diff --git a/package/exfat/exfat.mk b/package/exfat/exfat.mk
index b52b197..0d4f1c9 100644
--- a/package/exfat/exfat.mk
+++ b/package/exfat/exfat.mk
@@ -12,4 +12,6 @@ EXFAT_LICENSE = GPL-3.0+
EXFAT_LICENSE_FILES = COPYING
EXFAT_CFLAGS = $(TARGET_CFLAGS) -std=c99
+EXFAT_CONF_OPTS += --bindir=/bin --sbindir=/sbin --libdir=/lib
+
$(eval $(autotools-package))
--
2.7.4
^ permalink raw reply related [flat|nested] 7+ messages in thread
* [Buildroot] [PATCH] exfat, exfat-utils: fix the installation path of the helper utilities
2019-09-12 7:17 [Buildroot] [PATCH] exfat, exfat-utils: fix the installation path of the helper utilities Wolfgang Grandegger
@ 2019-09-20 13:15 ` Carlos Santos
2019-09-21 11:39 ` Arnout Vandecappelle
1 sibling, 0 replies; 7+ messages in thread
From: Carlos Santos @ 2019-09-20 13:15 UTC (permalink / raw)
To: buildroot
On Thu, Sep 12, 2019 at 4:25 AM Wolfgang Grandegger <wg@grandegger.com> wrote:
>
> "mount" from the "util-linux" package does expect the helper utilities
> in "/sbin" and not "/usr/sbin".
>
> Signed-off-by: Wolfgang Grandegger <wg@grandegger.com>
> ---
> package/exfat-utils/exfat-utils.mk | 2 ++
> package/exfat/exfat.mk | 2 ++
> 2 files changed, 4 insertions(+)
>
> diff --git a/package/exfat-utils/exfat-utils.mk b/package/exfat-utils/exfat-utils.mk
> index 62cd471..d22d5c9 100644
> --- a/package/exfat-utils/exfat-utils.mk
> +++ b/package/exfat-utils/exfat-utils.mk
> @@ -9,4 +9,6 @@ EXFAT_UTILS_SITE = https://github.com/relan/exfat/releases/download/v$(EXFAT_UTI
> EXFAT_UTILS_LICENSE = GPL-3.0+
> EXFAT_UTILS_LICENSE_FILES = COPYING
>
> +EXFAT_UTILS_CONF_OPTS += --bindir=/bin --sbindir=/sbin --libdir=/lib
> +
> $(eval $(autotools-package))
> diff --git a/package/exfat/exfat.mk b/package/exfat/exfat.mk
> index b52b197..0d4f1c9 100644
> --- a/package/exfat/exfat.mk
> +++ b/package/exfat/exfat.mk
> @@ -12,4 +12,6 @@ EXFAT_LICENSE = GPL-3.0+
> EXFAT_LICENSE_FILES = COPYING
> EXFAT_CFLAGS = $(TARGET_CFLAGS) -std=c99
>
> +EXFAT_CONF_OPTS += --bindir=/bin --sbindir=/sbin --libdir=/lib
> +
> $(eval $(autotools-package))
> --
> 2.7.4
>
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot
We normally use a patch series instead of changing more than one
package in a single patch. In this case, however, I think it's fine to
do it at once, since it's necessary to fix both mount.exfat (exfat)
and {fsck,mkfs}.exfat (exfat-utils). So,
Reviewed-by: Carlos Santos <unixmania@gmail.com>
^ permalink raw reply [flat|nested] 7+ messages in thread
* [Buildroot] [PATCH] exfat, exfat-utils: fix the installation path of the helper utilities
2019-09-12 7:17 [Buildroot] [PATCH] exfat, exfat-utils: fix the installation path of the helper utilities Wolfgang Grandegger
2019-09-20 13:15 ` Carlos Santos
@ 2019-09-21 11:39 ` Arnout Vandecappelle
2019-09-22 22:34 ` Carlos Santos
1 sibling, 1 reply; 7+ messages in thread
From: Arnout Vandecappelle @ 2019-09-21 11:39 UTC (permalink / raw)
To: buildroot
On 12/09/2019 09:17, Wolfgang Grandegger wrote:
> "mount" from the "util-linux" package does expect the helper utilities
> in "/sbin" and not "/usr/sbin".
>
> Signed-off-by: Wolfgang Grandegger <wg@grandegger.com>
> ---
> package/exfat-utils/exfat-utils.mk | 2 ++
> package/exfat/exfat.mk | 2 ++
> 2 files changed, 4 insertions(+)
>
> diff --git a/package/exfat-utils/exfat-utils.mk b/package/exfat-utils/exfat-utils.mk
> index 62cd471..d22d5c9 100644
> --- a/package/exfat-utils/exfat-utils.mk
> +++ b/package/exfat-utils/exfat-utils.mk
> @@ -9,4 +9,6 @@ EXFAT_UTILS_SITE = https://github.com/relan/exfat/releases/download/v$(EXFAT_UTI
> EXFAT_UTILS_LICENSE = GPL-3.0+
> EXFAT_UTILS_LICENSE_FILES = COPYING
>
> +EXFAT_UTILS_CONF_OPTS += --bindir=/bin --sbindir=/sbin --libdir=/lib
> +
> $(eval $(autotools-package))
> diff --git a/package/exfat/exfat.mk b/package/exfat/exfat.mk
> index b52b197..0d4f1c9 100644
> --- a/package/exfat/exfat.mk
> +++ b/package/exfat/exfat.mk
> @@ -12,4 +12,6 @@ EXFAT_LICENSE = GPL-3.0+
> EXFAT_LICENSE_FILES = COPYING
> EXFAT_CFLAGS = $(TARGET_CFLAGS) -std=c99
>
> +EXFAT_CONF_OPTS += --bindir=/bin --sbindir=/sbin --libdir=/lib
Why not just set --prefix=/ ?
Regards,
Arnout
> +
> $(eval $(autotools-package))
>
^ permalink raw reply [flat|nested] 7+ messages in thread
* [Buildroot] [PATCH] exfat, exfat-utils: fix the installation path of the helper utilities
2019-09-21 11:39 ` Arnout Vandecappelle
@ 2019-09-22 22:34 ` Carlos Santos
2019-09-22 22:37 ` Carlos Santos
2019-09-24 7:38 ` Wolfgang Grandegger
0 siblings, 2 replies; 7+ messages in thread
From: Carlos Santos @ 2019-09-22 22:34 UTC (permalink / raw)
To: buildroot
On Sat, Sep 21, 2019 at 8:40 AM Arnout Vandecappelle <arnout@mind.be> wrote:
>
>
>
> On 12/09/2019 09:17, Wolfgang Grandegger wrote:
> > "mount" from the "util-linux" package does expect the helper utilities
> > in "/sbin" and not "/usr/sbin".
> >
> > Signed-off-by: Wolfgang Grandegger <wg@grandegger.com>
> > ---
> > package/exfat-utils/exfat-utils.mk | 2 ++
> > package/exfat/exfat.mk | 2 ++
> > 2 files changed, 4 insertions(+)
> >
> > diff --git a/package/exfat-utils/exfat-utils.mk b/package/exfat-utils/exfat-utils.mk
> > index 62cd471..d22d5c9 100644
> > --- a/package/exfat-utils/exfat-utils.mk
> > +++ b/package/exfat-utils/exfat-utils.mk
> > @@ -9,4 +9,6 @@ EXFAT_UTILS_SITE = https://github.com/relan/exfat/releases/download/v$(EXFAT_UTI
> > EXFAT_UTILS_LICENSE = GPL-3.0+
> > EXFAT_UTILS_LICENSE_FILES = COPYING
> >
> > +EXFAT_UTILS_CONF_OPTS += --bindir=/bin --sbindir=/sbin --libdir=/lib
> > +
> > $(eval $(autotools-package))
> > diff --git a/package/exfat/exfat.mk b/package/exfat/exfat.mk
> > index b52b197..0d4f1c9 100644
> > --- a/package/exfat/exfat.mk
> > +++ b/package/exfat/exfat.mk
> > @@ -12,4 +12,6 @@ EXFAT_LICENSE = GPL-3.0+
> > EXFAT_LICENSE_FILES = COPYING
> > EXFAT_CFLAGS = $(TARGET_CFLAGS) -std=c99
> >
> > +EXFAT_CONF_OPTS += --bindir=/bin --sbindir=/sbin --libdir=/lib
>
> Why not just set --prefix=/ ?
>
> Regards,
> Arnout
>
> > +
> > $(eval $(autotools-package))
> >
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot
No, because --prefix=/usr is passed by package/pkg-autotools.mk first
and the additional --prefix=/ is discarded.
--
Carlos Santos <unixmania@gmail.com>
^ permalink raw reply [flat|nested] 7+ messages in thread
* [Buildroot] [PATCH] exfat, exfat-utils: fix the installation path of the helper utilities
2019-09-22 22:34 ` Carlos Santos
@ 2019-09-22 22:37 ` Carlos Santos
2019-09-24 20:21 ` Arnout Vandecappelle
2019-09-24 7:38 ` Wolfgang Grandegger
1 sibling, 1 reply; 7+ messages in thread
From: Carlos Santos @ 2019-09-22 22:37 UTC (permalink / raw)
To: buildroot
On Sun, Sep 22, 2019 at 7:34 PM Carlos Santos <unixmania@gmail.com> wrote:
>
> On Sat, Sep 21, 2019 at 8:40 AM Arnout Vandecappelle <arnout@mind.be> wrote:
> >
> >
> >
> > On 12/09/2019 09:17, Wolfgang Grandegger wrote:
> > > "mount" from the "util-linux" package does expect the helper utilities
> > > in "/sbin" and not "/usr/sbin".
> > >
> > > Signed-off-by: Wolfgang Grandegger <wg@grandegger.com>
> > > ---
> > > package/exfat-utils/exfat-utils.mk | 2 ++
> > > package/exfat/exfat.mk | 2 ++
> > > 2 files changed, 4 insertions(+)
> > >
> > > diff --git a/package/exfat-utils/exfat-utils.mk b/package/exfat-utils/exfat-utils.mk
> > > index 62cd471..d22d5c9 100644
> > > --- a/package/exfat-utils/exfat-utils.mk
> > > +++ b/package/exfat-utils/exfat-utils.mk
> > > @@ -9,4 +9,6 @@ EXFAT_UTILS_SITE = https://github.com/relan/exfat/releases/download/v$(EXFAT_UTI
> > > EXFAT_UTILS_LICENSE = GPL-3.0+
> > > EXFAT_UTILS_LICENSE_FILES = COPYING
> > >
> > > +EXFAT_UTILS_CONF_OPTS += --bindir=/bin --sbindir=/sbin --libdir=/lib
> > > +
> > > $(eval $(autotools-package))
> > > diff --git a/package/exfat/exfat.mk b/package/exfat/exfat.mk
> > > index b52b197..0d4f1c9 100644
> > > --- a/package/exfat/exfat.mk
> > > +++ b/package/exfat/exfat.mk
> > > @@ -12,4 +12,6 @@ EXFAT_LICENSE = GPL-3.0+
> > > EXFAT_LICENSE_FILES = COPYING
> > > EXFAT_CFLAGS = $(TARGET_CFLAGS) -std=c99
> > >
> > > +EXFAT_CONF_OPTS += --bindir=/bin --sbindir=/sbin --libdir=/lib
> >
> > Why not just set --prefix=/ ?
> >
> > Regards,
> > Arnout
> >
> > > +
> > > $(eval $(autotools-package))
> > >
> > _______________________________________________
> > buildroot mailing list
> > buildroot at busybox.net
> > http://lists.busybox.net/mailman/listinfo/buildroot
>
> No, because --prefix=/usr is passed by package/pkg-autotools.mk first
> and the additional --prefix=/ is discarded.
Which by the way reminds me that --prefix=/usr is passed by 46 .mk
packages, which seems to be redundant.
--
Carlos Santos <unixmania@gmail.com>
^ permalink raw reply [flat|nested] 7+ messages in thread
* [Buildroot] [PATCH] exfat, exfat-utils: fix the installation path of the helper utilities
2019-09-22 22:34 ` Carlos Santos
2019-09-22 22:37 ` Carlos Santos
@ 2019-09-24 7:38 ` Wolfgang Grandegger
1 sibling, 0 replies; 7+ messages in thread
From: Wolfgang Grandegger @ 2019-09-24 7:38 UTC (permalink / raw)
To: buildroot
Am 23.09.19 um 00:34 schrieb Carlos Santos:
> On Sat, Sep 21, 2019 at 8:40 AM Arnout Vandecappelle <arnout@mind.be> wrote:
>>
>>
>>
>> On 12/09/2019 09:17, Wolfgang Grandegger wrote:
>>> "mount" from the "util-linux" package does expect the helper utilities
>>> in "/sbin" and not "/usr/sbin".
>>>
>>> Signed-off-by: Wolfgang Grandegger <wg@grandegger.com>
>>> ---
>>> package/exfat-utils/exfat-utils.mk | 2 ++
>>> package/exfat/exfat.mk | 2 ++
>>> 2 files changed, 4 insertions(+)
>>>
>>> diff --git a/package/exfat-utils/exfat-utils.mk b/package/exfat-utils/exfat-utils.mk
>>> index 62cd471..d22d5c9 100644
>>> --- a/package/exfat-utils/exfat-utils.mk
>>> +++ b/package/exfat-utils/exfat-utils.mk
>>> @@ -9,4 +9,6 @@ EXFAT_UTILS_SITE = https://github.com/relan/exfat/releases/download/v$(EXFAT_UTI
>>> EXFAT_UTILS_LICENSE = GPL-3.0+
>>> EXFAT_UTILS_LICENSE_FILES = COPYING
>>>
>>> +EXFAT_UTILS_CONF_OPTS += --bindir=/bin --sbindir=/sbin --libdir=/lib
>>> +
>>> $(eval $(autotools-package))
>>> diff --git a/package/exfat/exfat.mk b/package/exfat/exfat.mk
>>> index b52b197..0d4f1c9 100644
>>> --- a/package/exfat/exfat.mk
>>> +++ b/package/exfat/exfat.mk
>>> @@ -12,4 +12,6 @@ EXFAT_LICENSE = GPL-3.0+
>>> EXFAT_LICENSE_FILES = COPYING
>>> EXFAT_CFLAGS = $(TARGET_CFLAGS) -std=c99
>>>
>>> +EXFAT_CONF_OPTS += --bindir=/bin --sbindir=/sbin --libdir=/lib
>>
>> Why not just set --prefix=/ ?
>>
>> Regards,
>> Arnout
>>
>>> +
>>> $(eval $(autotools-package))
>>>
>> _______________________________________________
>> buildroot mailing list
>> buildroot at busybox.net
>> http://lists.busybox.net/mailman/listinfo/buildroot
>
> No, because --prefix=/usr is passed by package/pkg-autotools.mk first
> and the additional --prefix=/ is discarded.
Hm, "--prefix=/" works for me!. I'm going to send v2 then.
Wolfgang
^ permalink raw reply [flat|nested] 7+ messages in thread
* [Buildroot] [PATCH] exfat, exfat-utils: fix the installation path of the helper utilities
2019-09-22 22:37 ` Carlos Santos
@ 2019-09-24 20:21 ` Arnout Vandecappelle
0 siblings, 0 replies; 7+ messages in thread
From: Arnout Vandecappelle @ 2019-09-24 20:21 UTC (permalink / raw)
To: buildroot
On 23/09/2019 00:37, Carlos Santos wrote:
> Which by the way reminds me that --prefix=/usr is passed by 46 .mk
> packages, which seems to be redundant.
Of these, most are not autotools packages so the --prefix is not passed by default.
And the ones which are autotools packages override CONFIGURE_CMDS.
I couldn't find any case where the --prefix is redundant.
But thanks for thinking of this anyway :-)
Regards,
Arnout
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2019-09-24 20:21 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-09-12 7:17 [Buildroot] [PATCH] exfat, exfat-utils: fix the installation path of the helper utilities Wolfgang Grandegger
2019-09-20 13:15 ` Carlos Santos
2019-09-21 11:39 ` Arnout Vandecappelle
2019-09-22 22:34 ` Carlos Santos
2019-09-22 22:37 ` Carlos Santos
2019-09-24 20:21 ` Arnout Vandecappelle
2019-09-24 7:38 ` Wolfgang Grandegger
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.