[GIT PULL] UBIFS fixes for 4.19-rc4

[GIT PULL] UBIFS fixes for 4.19-rc4

[Richard Weinberger]

Greg,

The following changes since commit ae596de1a0c8c2c924dc99d23c026259372ab234:

  Compiler Attributes: naked can be shared (2018-09-20 15:23:58 +0200)

are available in the Git repository at:

  git://git.infradead.org/linux-ubifs.git tags/upstream-4.19-rc4

for you to fetch changes up to f061c1cc404a618858a77aea233fde0aeaad2f2d:

  Revert "ubifs: xattr: Don't operate on deleted inodes" (2018-09-20 21:37:41 +0200)

----------------------------------------------------------------
This pull request contains fixes for UBIFS:

- A wrong UBIFS assertion in mount code
- Fix for a NULL pointer deref in mount code
- Revert of a bad fix for xattrs

----------------------------------------------------------------
Richard Weinberger (2):
      ubifs: Check for name being NULL while mounting
      Revert "ubifs: xattr: Don't operate on deleted inodes"

Sascha Hauer (1):
      ubifs: drop false positive assertion

 fs/ubifs/super.c |  7 ++++++-
 fs/ubifs/xattr.c | 24 ------------------------
 2 files changed, 6 insertions(+), 25 deletions(-)

Re: [GIT PULL] UBIFS fixes for 4.19-rc4

[Greg KH]

On Fri, Sep 21, 2018 at 11:33:15AM +0200, Richard Weinberger wrote:
> Greg,
> 
> The following changes since commit ae596de1a0c8c2c924dc99d23c026259372ab234:
> 
>   Compiler Attributes: naked can be shared (2018-09-20 15:23:58 +0200)

Wow, bold move, new patches with less than 24 hours in your tree.  That
means linux-next didn't see them :(

> are available in the Git repository at:
> 
>   git://git.infradead.org/linux-ubifs.git tags/upstream-4.19-rc4

Now pulled, but really, don't you think that they should at least go
through 0-day first?  Maybe no one runs ubifs on mainline kernels...

thanks,

greg k-h

Re: [GIT PULL] UBIFS fixes for 4.19-rc4

[Richard Weinberger]

Am Freitag, 21. September 2018, 15:53:42 CEST schrieb Greg KH:
> On Fri, Sep 21, 2018 at 11:33:15AM +0200, Richard Weinberger wrote:
> > Greg,
> > 
> > The following changes since commit ae596de1a0c8c2c924dc99d23c026259372ab234:
> > 
> >   Compiler Attributes: naked can be shared (2018-09-20 15:23:58 +0200)
> 
> Wow, bold move, new patches with less than 24 hours in your tree.  That
> means linux-next didn't see them :(
> 
> > are available in the Git repository at:
> > 
> >   git://git.infradead.org/linux-ubifs.git tags/upstream-4.19-rc4
> 
> Now pulled, but really, don't you think that they should at least go
> through 0-day first?  Maybe no one runs ubifs on mainline kernels...

Huh? I checked this morning next-20180921 and saw all patches.

Thanks,
//richard

Re: [GIT PULL] UBIFS fixes for 4.19-rc4

[Greg KH]

On Fri, Sep 21, 2018 at 04:01:33PM +0200, Richard Weinberger wrote:
> Am Freitag, 21. September 2018, 15:53:42 CEST schrieb Greg KH:
> > On Fri, Sep 21, 2018 at 11:33:15AM +0200, Richard Weinberger wrote:
> > > Greg,
> > > 
> > > The following changes since commit ae596de1a0c8c2c924dc99d23c026259372ab234:
> > > 
> > >   Compiler Attributes: naked can be shared (2018-09-20 15:23:58 +0200)
> > 
> > Wow, bold move, new patches with less than 24 hours in your tree.  That
> > means linux-next didn't see them :(
> > 
> > > are available in the Git repository at:
> > > 
> > >   git://git.infradead.org/linux-ubifs.git tags/upstream-4.19-rc4
> > 
> > Now pulled, but really, don't you think that they should at least go
> > through 0-day first?  Maybe no one runs ubifs on mainline kernels...
> 
> Huh? I checked this morning next-20180921 and saw all patches.

Ah, ok, must have snuck in, I assumed that less than 24 hours was pretty
fast...

Re: [GIT PULL] UBIFS fixes for 4.19-rc4

[Greg KH]

On Mon, Sep 24, 2018 at 09:11:55AM +0200, Peter Rosin wrote:
> I fredags, den 21 september 2018, 15:53:42 CEST skrev Greg KH:
> > On Fri, Sep 21, 2018 at 11:33:15AM +0200, Richard Weinberger wrote:
> >> Greg,
> >> 
> >> The following changes since commit ae596de1a0c8c2c924dc99d23c026259372ab234:
> >> 
> >>   Compiler Attributes: naked can be shared (2018-09-20 15:23:58 +0200)
> > 
> > Wow, bold move, new patches with less than 24 hours in your tree.  That
> > means linux-next didn't see them :(
> > 
> >> are available in the Git repository at:
> >> 
> >>   git://git.infradead.org/linux-ubifs.git tags/upstream-4.19-rc4
> > 
> > Now pulled, but really, don't you think that they should at least go
> > through 0-day first?  Maybe no one runs ubifs on mainline kernels...
> 
> FWIW, we do...

That's good to know.  I was just trying to say that patches asked to be
pulled in, less than 24 hours from when they were added to the
developer's tree, is usually a little "suspect" as they normally have
not had the chance to go through our "CI" systems.

That's all, I wasn't trying to disparage the UBIFS codebase at all :)

thanks,

greg k-h

Re: [GIT PULL] UBIFS fixes for 4.19-rc4

[Peter Rosin]

I fredags, den 21 september 2018, 15:53:42 CEST skrev Greg KH:
> On Fri, Sep 21, 2018 at 11:33:15AM +0200, Richard Weinberger wrote:
>> Greg,
>> 
>> The following changes since commit ae596de1a0c8c2c924dc99d23c026259372ab234:
>> 
>>   Compiler Attributes: naked can be shared (2018-09-20 15:23:58 +0200)
> 
> Wow, bold move, new patches with less than 24 hours in your tree.  That
> means linux-next didn't see them :(
> 
>> are available in the Git repository at:
>> 
>>   git://git.infradead.org/linux-ubifs.git tags/upstream-4.19-rc4
> 
> Now pulled, but really, don't you think that they should at least go
> through 0-day first?  Maybe no one runs ubifs on mainline kernels...

FWIW, we do...

Cheers,
Peter