From: Laurent Pinchart <laurent.pinchart@ideasonboard.com> To: Wolfram Sang <wsa@the-dreams.de> Cc: linux-sh@vger.kernel.org, Daniel Vetter <daniel.vetter@ffwll.ch>, Magnus Damm <magnus.damm@gmail.com>, dri-devel@lists.freedesktop.org, Simon Horman <horms@verge.net.au>, Geert Uytterhoeven <geert@linux-m68k.org>, Kuninori Morimoto <kuninori.morimoto.gx@gmail.com> Subject: Re: [PATCH RESEND 3/3] drm: adv7511: it's HPD, not HDP Date: Mon, 04 Jan 2016 14:38:35 +0000 [thread overview] Message-ID: <3387173.Dbm3fEH4di@avalon> (raw) In-Reply-To: <1451874827-2531-3-git-send-email-wsa@the-dreams.de> Hi Wolfram, Thank you for the patch. On Monday 04 January 2016 03:33:47 Wolfram Sang wrote: > From: Wolfram Sang <wsa+renesas@sang-engineering.com> > > Fix this typo, consequently used over both files :) > > Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> > --- > drivers/gpu/drm/i2c/adv7511.c | 22 +++++++++++----------- > drivers/gpu/drm/i2c/adv7511.h | 12 ++++++------ > 2 files changed, 17 insertions(+), 17 deletions(-) > > diff --git a/drivers/gpu/drm/i2c/adv7511.c b/drivers/gpu/drm/i2c/adv7511.c > index 50a861b12346c4..c03c1ea53fd042 100644 > --- a/drivers/gpu/drm/i2c/adv7511.c > +++ b/drivers/gpu/drm/i2c/adv7511.c > @@ -378,16 +378,16 @@ static void adv7511_power_on(struct adv7511 *adv7511) > } > > /* > - * Per spec it is allowed to pulse the HDP signal to indicate that the > + * Per spec it is allowed to pulse the HPD signal to indicate that the > * EDID information has changed. Some monitors do this when they wakeup > - * from standby or are enabled. When the HDP goes low the adv7511 is > + * from standby or are enabled. When the HPD goes low the adv7511 is > * reset and the outputs are disabled which might cause the monitor to > - * go to standby again. To avoid this we ignore the HDP pin for the > + * go to standby again. To avoid this we ignore the HPD pin for the > * first few seconds after enabling the output. > */ > regmap_update_bits(adv7511->regmap, ADV7511_REG_POWER2, > - ADV7511_REG_POWER2_HDP_SRC_MASK, > - ADV7511_REG_POWER2_HDP_SRC_NONE); > + ADV7511_REG_POWER2_HPD_SRC_MASK, > + ADV7511_REG_POWER2_HPD_SRC_NONE); > > /* > * Most of the registers are reset during power down or when HPD is low. > @@ -421,9 +421,9 @@ static bool adv7511_hpd(struct adv7511 *adv7511) > if (ret < 0) > return false; > > - if (irq0 & ADV7511_INT0_HDP) { > + if (irq0 & ADV7511_INT0_HPD) { > regmap_write(adv7511->regmap, ADV7511_REG_INT(0), > - ADV7511_INT0_HDP); > + ADV7511_INT0_HPD); > return true; > } > > @@ -446,7 +446,7 @@ static int adv7511_irq_process(struct adv7511 *adv7511) > regmap_write(adv7511->regmap, ADV7511_REG_INT(0), irq0); > regmap_write(adv7511->regmap, ADV7511_REG_INT(1), irq1); > > - if (irq0 & ADV7511_INT0_HDP && adv7511->encoder) > + if (irq0 & ADV7511_INT0_HPD && adv7511->encoder) > drm_helper_hpd_irq_event(adv7511->encoder->dev); > > if (irq0 & ADV7511_INT0_EDID_READY || irq1 & ADV7511_INT1_DDC_ERROR) { > @@ -648,10 +648,10 @@ adv7511_encoder_detect(struct drm_encoder *encoder, > if (adv7511->status = connector_status_connected) > status = connector_status_disconnected; > } else { > - /* Renable HDP sensing */ > + /* Renable HPD sensing */ > regmap_update_bits(adv7511->regmap, ADV7511_REG_POWER2, > - ADV7511_REG_POWER2_HDP_SRC_MASK, > - ADV7511_REG_POWER2_HDP_SRC_BOTH); > + ADV7511_REG_POWER2_HPD_SRC_MASK, > + ADV7511_REG_POWER2_HPD_SRC_BOTH); > } > > adv7511->status = status; > diff --git a/drivers/gpu/drm/i2c/adv7511.h b/drivers/gpu/drm/i2c/adv7511.h > index 6599ed538426d6..38515b30cedfc8 100644 > --- a/drivers/gpu/drm/i2c/adv7511.h > +++ b/drivers/gpu/drm/i2c/adv7511.h > @@ -90,7 +90,7 @@ > #define ADV7511_CSC_ENABLE BIT(7) > #define ADV7511_CSC_UPDATE_MODE BIT(5) > > -#define ADV7511_INT0_HDP BIT(7) > +#define ADV7511_INT0_HPD BIT(7) > #define ADV7511_INT0_VSYNC BIT(5) > #define ADV7511_INT0_AUDIO_FIFO_FULL BIT(4) > #define ADV7511_INT0_EDID_READY BIT(2) > @@ -157,11 +157,11 @@ > #define ADV7511_PACKET_ENABLE_SPARE2 BIT(1) > #define ADV7511_PACKET_ENABLE_SPARE1 BIT(0) > > -#define ADV7511_REG_POWER2_HDP_SRC_MASK 0xc0 > -#define ADV7511_REG_POWER2_HDP_SRC_BOTH 0x00 > -#define ADV7511_REG_POWER2_HDP_SRC_HDP 0x40 > -#define ADV7511_REG_POWER2_HDP_SRC_CEC 0x80 > -#define ADV7511_REG_POWER2_HDP_SRC_NONE 0xc0 > +#define ADV7511_REG_POWER2_HPD_SRC_MASK 0xc0 > +#define ADV7511_REG_POWER2_HPD_SRC_BOTH 0x00 > +#define ADV7511_REG_POWER2_HPD_SRC_HPD 0x40 > +#define ADV7511_REG_POWER2_HPD_SRC_CEC 0x80 > +#define ADV7511_REG_POWER2_HPD_SRC_NONE 0xc0 > #define ADV7511_REG_POWER2_TDMS_ENABLE BIT(4) > #define ADV7511_REG_POWER2_GATE_INPUT_CLK BIT(0) -- Regards, Laurent Pinchart
WARNING: multiple messages have this Message-ID (diff)
From: Laurent Pinchart <laurent.pinchart@ideasonboard.com> To: Wolfram Sang <wsa@the-dreams.de> Cc: linux-sh@vger.kernel.org, Daniel Vetter <daniel.vetter@ffwll.ch>, Magnus Damm <magnus.damm@gmail.com>, dri-devel@lists.freedesktop.org, Simon Horman <horms@verge.net.au>, Geert Uytterhoeven <geert@linux-m68k.org>, Kuninori Morimoto <kuninori.morimoto.gx@gmail.com> Subject: Re: [PATCH RESEND 3/3] drm: adv7511: it's HPD, not HDP Date: Mon, 04 Jan 2016 16:38:35 +0200 [thread overview] Message-ID: <3387173.Dbm3fEH4di@avalon> (raw) In-Reply-To: <1451874827-2531-3-git-send-email-wsa@the-dreams.de> Hi Wolfram, Thank you for the patch. On Monday 04 January 2016 03:33:47 Wolfram Sang wrote: > From: Wolfram Sang <wsa+renesas@sang-engineering.com> > > Fix this typo, consequently used over both files :) > > Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> > --- > drivers/gpu/drm/i2c/adv7511.c | 22 +++++++++++----------- > drivers/gpu/drm/i2c/adv7511.h | 12 ++++++------ > 2 files changed, 17 insertions(+), 17 deletions(-) > > diff --git a/drivers/gpu/drm/i2c/adv7511.c b/drivers/gpu/drm/i2c/adv7511.c > index 50a861b12346c4..c03c1ea53fd042 100644 > --- a/drivers/gpu/drm/i2c/adv7511.c > +++ b/drivers/gpu/drm/i2c/adv7511.c > @@ -378,16 +378,16 @@ static void adv7511_power_on(struct adv7511 *adv7511) > } > > /* > - * Per spec it is allowed to pulse the HDP signal to indicate that the > + * Per spec it is allowed to pulse the HPD signal to indicate that the > * EDID information has changed. Some monitors do this when they wakeup > - * from standby or are enabled. When the HDP goes low the adv7511 is > + * from standby or are enabled. When the HPD goes low the adv7511 is > * reset and the outputs are disabled which might cause the monitor to > - * go to standby again. To avoid this we ignore the HDP pin for the > + * go to standby again. To avoid this we ignore the HPD pin for the > * first few seconds after enabling the output. > */ > regmap_update_bits(adv7511->regmap, ADV7511_REG_POWER2, > - ADV7511_REG_POWER2_HDP_SRC_MASK, > - ADV7511_REG_POWER2_HDP_SRC_NONE); > + ADV7511_REG_POWER2_HPD_SRC_MASK, > + ADV7511_REG_POWER2_HPD_SRC_NONE); > > /* > * Most of the registers are reset during power down or when HPD is low. > @@ -421,9 +421,9 @@ static bool adv7511_hpd(struct adv7511 *adv7511) > if (ret < 0) > return false; > > - if (irq0 & ADV7511_INT0_HDP) { > + if (irq0 & ADV7511_INT0_HPD) { > regmap_write(adv7511->regmap, ADV7511_REG_INT(0), > - ADV7511_INT0_HDP); > + ADV7511_INT0_HPD); > return true; > } > > @@ -446,7 +446,7 @@ static int adv7511_irq_process(struct adv7511 *adv7511) > regmap_write(adv7511->regmap, ADV7511_REG_INT(0), irq0); > regmap_write(adv7511->regmap, ADV7511_REG_INT(1), irq1); > > - if (irq0 & ADV7511_INT0_HDP && adv7511->encoder) > + if (irq0 & ADV7511_INT0_HPD && adv7511->encoder) > drm_helper_hpd_irq_event(adv7511->encoder->dev); > > if (irq0 & ADV7511_INT0_EDID_READY || irq1 & ADV7511_INT1_DDC_ERROR) { > @@ -648,10 +648,10 @@ adv7511_encoder_detect(struct drm_encoder *encoder, > if (adv7511->status == connector_status_connected) > status = connector_status_disconnected; > } else { > - /* Renable HDP sensing */ > + /* Renable HPD sensing */ > regmap_update_bits(adv7511->regmap, ADV7511_REG_POWER2, > - ADV7511_REG_POWER2_HDP_SRC_MASK, > - ADV7511_REG_POWER2_HDP_SRC_BOTH); > + ADV7511_REG_POWER2_HPD_SRC_MASK, > + ADV7511_REG_POWER2_HPD_SRC_BOTH); > } > > adv7511->status = status; > diff --git a/drivers/gpu/drm/i2c/adv7511.h b/drivers/gpu/drm/i2c/adv7511.h > index 6599ed538426d6..38515b30cedfc8 100644 > --- a/drivers/gpu/drm/i2c/adv7511.h > +++ b/drivers/gpu/drm/i2c/adv7511.h > @@ -90,7 +90,7 @@ > #define ADV7511_CSC_ENABLE BIT(7) > #define ADV7511_CSC_UPDATE_MODE BIT(5) > > -#define ADV7511_INT0_HDP BIT(7) > +#define ADV7511_INT0_HPD BIT(7) > #define ADV7511_INT0_VSYNC BIT(5) > #define ADV7511_INT0_AUDIO_FIFO_FULL BIT(4) > #define ADV7511_INT0_EDID_READY BIT(2) > @@ -157,11 +157,11 @@ > #define ADV7511_PACKET_ENABLE_SPARE2 BIT(1) > #define ADV7511_PACKET_ENABLE_SPARE1 BIT(0) > > -#define ADV7511_REG_POWER2_HDP_SRC_MASK 0xc0 > -#define ADV7511_REG_POWER2_HDP_SRC_BOTH 0x00 > -#define ADV7511_REG_POWER2_HDP_SRC_HDP 0x40 > -#define ADV7511_REG_POWER2_HDP_SRC_CEC 0x80 > -#define ADV7511_REG_POWER2_HDP_SRC_NONE 0xc0 > +#define ADV7511_REG_POWER2_HPD_SRC_MASK 0xc0 > +#define ADV7511_REG_POWER2_HPD_SRC_BOTH 0x00 > +#define ADV7511_REG_POWER2_HPD_SRC_HPD 0x40 > +#define ADV7511_REG_POWER2_HPD_SRC_CEC 0x80 > +#define ADV7511_REG_POWER2_HPD_SRC_NONE 0xc0 > #define ADV7511_REG_POWER2_TDMS_ENABLE BIT(4) > #define ADV7511_REG_POWER2_GATE_INPUT_CLK BIT(0) -- Regards, Laurent Pinchart _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2016-01-04 14:38 UTC|newest] Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top 2016-01-04 2:33 [PATCH RESEND 1/3] drm: adv7511: really enable interrupts for EDID detection Wolfram Sang 2016-01-04 2:33 ` Wolfram Sang 2016-01-04 2:33 ` [PATCH RESEND 2/3] drm: adv7511: mark ADV7511_REG_EDID_READ_CTRL volatile Wolfram Sang 2016-01-04 2:33 ` Wolfram Sang 2016-01-04 14:38 ` Laurent Pinchart 2016-01-04 14:38 ` Laurent Pinchart 2016-01-04 16:10 ` Wolfram Sang 2016-01-04 16:10 ` Wolfram Sang 2016-01-04 2:33 ` [PATCH RESEND 3/3] drm: adv7511: it's HPD, not HDP Wolfram Sang 2016-01-04 2:33 ` Wolfram Sang 2016-01-04 14:28 ` Lars-Peter Clausen 2016-01-04 14:28 ` Lars-Peter Clausen 2016-01-04 14:38 ` Laurent Pinchart [this message] 2016-01-04 14:38 ` Laurent Pinchart 2016-01-04 6:41 ` [PATCH RESEND 1/3] drm: adv7511: really enable interrupts for EDID detection Archit Taneja 2016-01-04 6:53 ` Archit Taneja 2016-01-04 14:37 ` Laurent Pinchart 2016-01-04 14:37 ` Laurent Pinchart 2016-01-04 14:59 ` Geert Uytterhoeven 2016-01-04 14:59 ` Geert Uytterhoeven 2016-01-04 16:11 ` Wolfram Sang 2016-01-04 16:11 ` Wolfram Sang
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=3387173.Dbm3fEH4di@avalon \ --to=laurent.pinchart@ideasonboard.com \ --cc=daniel.vetter@ffwll.ch \ --cc=dri-devel@lists.freedesktop.org \ --cc=geert@linux-m68k.org \ --cc=horms@verge.net.au \ --cc=kuninori.morimoto.gx@gmail.com \ --cc=linux-sh@vger.kernel.org \ --cc=magnus.damm@gmail.com \ --cc=wsa@the-dreams.de \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.