* [PATCH v3] hw/pvrdma: Protect against buggy or malicious guest driver
@ 2022-04-03 9:52 Yuval Shaia
2022-04-05 10:31 ` Marcel Apfelbaum
2022-09-12 17:45 ` Michael Tokarev
0 siblings, 2 replies; 10+ messages in thread
From: Yuval Shaia @ 2022-04-03 9:52 UTC (permalink / raw)
To: qemu-devel, yuval.shaia.ml, marcel.apfelbaum, mcascell, wxhusst
Guest driver might execute HW commands when shared buffers are not yet
allocated.
This could happen on purpose (malicious guest) or because of some other
guest/host address mapping error.
We need to protect againts such case.
Fixes: CVE-2022-1050
Reported-by: Raven <wxhusst@gmail.com>
Signed-off-by: Yuval Shaia <yuval.shaia.ml@gmail.com>
---
v1 -> v2:
* Commit message changes
v2 -> v3:
* Exclude cosmetic changes
---
hw/rdma/vmw/pvrdma_cmd.c | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/hw/rdma/vmw/pvrdma_cmd.c b/hw/rdma/vmw/pvrdma_cmd.c
index da7ddfa548..89db963c46 100644
--- a/hw/rdma/vmw/pvrdma_cmd.c
+++ b/hw/rdma/vmw/pvrdma_cmd.c
@@ -796,6 +796,12 @@ int pvrdma_exec_cmd(PVRDMADev *dev)
dsr_info = &dev->dsr_info;
+ if (!dsr_info->dsr) {
+ /* Buggy or malicious guest driver */
+ rdma_error_report("Exec command without dsr, req or rsp buffers");
+ goto out;
+ }
+
if (dsr_info->req->hdr.cmd >= sizeof(cmd_handlers) /
sizeof(struct cmd_handler)) {
rdma_error_report("Unsupported command");
--
2.20.1
^ permalink raw reply related [flat|nested] 10+ messages in thread
* Re: [PATCH v3] hw/pvrdma: Protect against buggy or malicious guest driver
2022-04-03 9:52 [PATCH v3] hw/pvrdma: Protect against buggy or malicious guest driver Yuval Shaia
@ 2022-04-05 10:31 ` Marcel Apfelbaum
2022-12-07 15:05 ` Claudio Fontana
2022-09-12 17:45 ` Michael Tokarev
1 sibling, 1 reply; 10+ messages in thread
From: Marcel Apfelbaum @ 2022-04-05 10:31 UTC (permalink / raw)
To: Yuval Shaia, Philippe Mathieu-Daudé, Peter Maydell
Cc: wxhusst, Mauro Matteo Cascella, qemu devel list
Hi Yuval,
Thank you for the changes.
On Sun, Apr 3, 2022 at 11:54 AM Yuval Shaia <yuval.shaia.ml@gmail.com> wrote:
>
> Guest driver might execute HW commands when shared buffers are not yet
> allocated.
> This could happen on purpose (malicious guest) or because of some other
> guest/host address mapping error.
> We need to protect againts such case.
>
> Fixes: CVE-2022-1050
>
> Reported-by: Raven <wxhusst@gmail.com>
> Signed-off-by: Yuval Shaia <yuval.shaia.ml@gmail.com>
> ---
> v1 -> v2:
> * Commit message changes
> v2 -> v3:
> * Exclude cosmetic changes
> ---
> hw/rdma/vmw/pvrdma_cmd.c | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/hw/rdma/vmw/pvrdma_cmd.c b/hw/rdma/vmw/pvrdma_cmd.c
> index da7ddfa548..89db963c46 100644
> --- a/hw/rdma/vmw/pvrdma_cmd.c
> +++ b/hw/rdma/vmw/pvrdma_cmd.c
> @@ -796,6 +796,12 @@ int pvrdma_exec_cmd(PVRDMADev *dev)
>
> dsr_info = &dev->dsr_info;
>
> + if (!dsr_info->dsr) {
> + /* Buggy or malicious guest driver */
> + rdma_error_report("Exec command without dsr, req or rsp buffers");
> + goto out;
> + }
> +
> if (dsr_info->req->hdr.cmd >= sizeof(cmd_handlers) /
> sizeof(struct cmd_handler)) {
> rdma_error_report("Unsupported command");
> --
> 2.20.1
>
cc-ing Peter and Philippe for a question:
Do we have a "Security Fixes" or a "Misc" subtree? Otherwise it will
have to wait a week or so.
Reviewed by: Marcel Apfelbaum <marcel.apfelbaum@gmail.com>
Thanks,
Marcel
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH v3] hw/pvrdma: Protect against buggy or malicious guest driver
2022-04-03 9:52 [PATCH v3] hw/pvrdma: Protect against buggy or malicious guest driver Yuval Shaia
2022-04-05 10:31 ` Marcel Apfelbaum
@ 2022-09-12 17:45 ` Michael Tokarev
1 sibling, 0 replies; 10+ messages in thread
From: Michael Tokarev @ 2022-09-12 17:45 UTC (permalink / raw)
To: Yuval Shaia, qemu-devel, marcel.apfelbaum, mcascell, wxhusst
Ping? This is from April this year, half a year ago.
Can this be applied or?
Marcel said it should wait a week or two, I think that's been done already.. ;)
Thanks,
/mjt
03.04.2022 12:52, Yuval Shaia wrote:
> Guest driver might execute HW commands when shared buffers are not yet
> allocated.
> This could happen on purpose (malicious guest) or because of some other
> guest/host address mapping error.
> We need to protect againts such case.
>
> Fixes: CVE-2022-1050
>
> Reported-by: Raven <wxhusst@gmail.com>
> Signed-off-by: Yuval Shaia <yuval.shaia.ml@gmail.com>
> ---
> v1 -> v2:
> * Commit message changes
> v2 -> v3:
> * Exclude cosmetic changes
> ---
> hw/rdma/vmw/pvrdma_cmd.c | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/hw/rdma/vmw/pvrdma_cmd.c b/hw/rdma/vmw/pvrdma_cmd.c
> index da7ddfa548..89db963c46 100644
> --- a/hw/rdma/vmw/pvrdma_cmd.c
> +++ b/hw/rdma/vmw/pvrdma_cmd.c
> @@ -796,6 +796,12 @@ int pvrdma_exec_cmd(PVRDMADev *dev)
>
> dsr_info = &dev->dsr_info;
>
> + if (!dsr_info->dsr) {
> + /* Buggy or malicious guest driver */
> + rdma_error_report("Exec command without dsr, req or rsp buffers");
> + goto out;
> + }
> +
> if (dsr_info->req->hdr.cmd >= sizeof(cmd_handlers) /
> sizeof(struct cmd_handler)) {
> rdma_error_report("Unsupported command");
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH v3] hw/pvrdma: Protect against buggy or malicious guest driver
2022-04-05 10:31 ` Marcel Apfelbaum
@ 2022-12-07 15:05 ` Claudio Fontana
2022-12-19 9:57 ` Yuval Shaia
0 siblings, 1 reply; 10+ messages in thread
From: Claudio Fontana @ 2022-12-07 15:05 UTC (permalink / raw)
To: Marcel Apfelbaum, Yuval Shaia, Philippe Mathieu-Daudé,
Peter Maydell, Peter Maydell
Cc: wxhusst, Mauro Matteo Cascella, qemu devel list
On 4/5/22 12:31, Marcel Apfelbaum wrote:
> Hi Yuval,
> Thank you for the changes.
>
> On Sun, Apr 3, 2022 at 11:54 AM Yuval Shaia <yuval.shaia.ml@gmail.com> wrote:
>>
>> Guest driver might execute HW commands when shared buffers are not yet
>> allocated.
>> This could happen on purpose (malicious guest) or because of some other
>> guest/host address mapping error.
>> We need to protect againts such case.
>>
>> Fixes: CVE-2022-1050
>>
>> Reported-by: Raven <wxhusst@gmail.com>
>> Signed-off-by: Yuval Shaia <yuval.shaia.ml@gmail.com>
>> ---
>> v1 -> v2:
>> * Commit message changes
>> v2 -> v3:
>> * Exclude cosmetic changes
>> ---
>> hw/rdma/vmw/pvrdma_cmd.c | 6 ++++++
>> 1 file changed, 6 insertions(+)
>>
>> diff --git a/hw/rdma/vmw/pvrdma_cmd.c b/hw/rdma/vmw/pvrdma_cmd.c
>> index da7ddfa548..89db963c46 100644
>> --- a/hw/rdma/vmw/pvrdma_cmd.c
>> +++ b/hw/rdma/vmw/pvrdma_cmd.c
>> @@ -796,6 +796,12 @@ int pvrdma_exec_cmd(PVRDMADev *dev)
>>
>> dsr_info = &dev->dsr_info;
>>
>> + if (!dsr_info->dsr) {
>> + /* Buggy or malicious guest driver */
>> + rdma_error_report("Exec command without dsr, req or rsp buffers");
>> + goto out;
>> + }
>> +
>> if (dsr_info->req->hdr.cmd >= sizeof(cmd_handlers) /
>> sizeof(struct cmd_handler)) {
>> rdma_error_report("Unsupported command");
>> --
>> 2.20.1
>>
>
> cc-ing Peter and Philippe for a question:
> Do we have a "Security Fixes" or a "Misc" subtree? Otherwise it will
> have to wait a week or so.
>
> Reviewed by: Marcel Apfelbaum <marcel.apfelbaum@gmail.com>
> Thanks,
> Marcel
>
Hi all,
patch is reviewed, anything holding back the inclusion of this security fix?
Thanks,
Claudio
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH v3] hw/pvrdma: Protect against buggy or malicious guest driver
2022-12-07 15:05 ` Claudio Fontana
@ 2022-12-19 9:57 ` Yuval Shaia
2022-12-19 11:21 ` Marcel Apfelbaum
0 siblings, 1 reply; 10+ messages in thread
From: Yuval Shaia @ 2022-12-19 9:57 UTC (permalink / raw)
To: Claudio Fontana
Cc: Marcel Apfelbaum, Philippe Mathieu-Daudé,
Peter Maydell, wxhusst, Mauro Matteo Cascella, qemu devel list
[-- Attachment #1: Type: text/plain, Size: 1986 bytes --]
Can anyone else pick this one?
Thanks,
Yuval
On Wed, 7 Dec 2022 at 17:05, Claudio Fontana <cfontana@suse.de> wrote:
> On 4/5/22 12:31, Marcel Apfelbaum wrote:
> > Hi Yuval,
> > Thank you for the changes.
> >
> > On Sun, Apr 3, 2022 at 11:54 AM Yuval Shaia <yuval.shaia.ml@gmail.com>
> wrote:
> >>
> >> Guest driver might execute HW commands when shared buffers are not yet
> >> allocated.
> >> This could happen on purpose (malicious guest) or because of some other
> >> guest/host address mapping error.
> >> We need to protect againts such case.
> >>
> >> Fixes: CVE-2022-1050
> >>
> >> Reported-by: Raven <wxhusst@gmail.com>
> >> Signed-off-by: Yuval Shaia <yuval.shaia.ml@gmail.com>
> >> ---
> >> v1 -> v2:
> >> * Commit message changes
> >> v2 -> v3:
> >> * Exclude cosmetic changes
> >> ---
> >> hw/rdma/vmw/pvrdma_cmd.c | 6 ++++++
> >> 1 file changed, 6 insertions(+)
> >>
> >> diff --git a/hw/rdma/vmw/pvrdma_cmd.c b/hw/rdma/vmw/pvrdma_cmd.c
> >> index da7ddfa548..89db963c46 100644
> >> --- a/hw/rdma/vmw/pvrdma_cmd.c
> >> +++ b/hw/rdma/vmw/pvrdma_cmd.c
> >> @@ -796,6 +796,12 @@ int pvrdma_exec_cmd(PVRDMADev *dev)
> >>
> >> dsr_info = &dev->dsr_info;
> >>
> >> + if (!dsr_info->dsr) {
> >> + /* Buggy or malicious guest driver */
> >> + rdma_error_report("Exec command without dsr, req or rsp
> buffers");
> >> + goto out;
> >> + }
> >> +
> >> if (dsr_info->req->hdr.cmd >= sizeof(cmd_handlers) /
> >> sizeof(struct cmd_handler)) {
> >> rdma_error_report("Unsupported command");
> >> --
> >> 2.20.1
> >>
> >
> > cc-ing Peter and Philippe for a question:
> > Do we have a "Security Fixes" or a "Misc" subtree? Otherwise it will
> > have to wait a week or so.
> >
> > Reviewed by: Marcel Apfelbaum <marcel.apfelbaum@gmail.com>
> > Thanks,
> > Marcel
> >
>
> Hi all,
>
> patch is reviewed, anything holding back the inclusion of this security
> fix?
>
> Thanks,
>
> Claudio
>
[-- Attachment #2: Type: text/html, Size: 3150 bytes --]
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH v3] hw/pvrdma: Protect against buggy or malicious guest driver
2022-12-19 9:57 ` Yuval Shaia
@ 2022-12-19 11:21 ` Marcel Apfelbaum
2022-12-28 19:32 ` Thomas Huth
0 siblings, 1 reply; 10+ messages in thread
From: Marcel Apfelbaum @ 2022-12-19 11:21 UTC (permalink / raw)
To: Yuval Shaia, Philippe Mathieu-Daudé, Thomas Huth
Cc: Claudio Fontana, qemu devel list, Peter Maydell, wxhusst
On Mon, Dec 19, 2022 at 10:57 AM Yuval Shaia <yuval.shaia.ml@gmail.com> wrote:
>
> Can anyone else pick this one?
Adding Thomas,
I dropped the ball with this one, I am sorry about that, maybe it
doesn't worth a Pull Request only for it.
Maybe it can go through the Misc tree?
Thank you,
Marcel
>
> Thanks,
> Yuval
>
> On Wed, 7 Dec 2022 at 17:05, Claudio Fontana <cfontana@suse.de> wrote:
>>
>> On 4/5/22 12:31, Marcel Apfelbaum wrote:
>> > Hi Yuval,
>> > Thank you for the changes.
>> >
>> > On Sun, Apr 3, 2022 at 11:54 AM Yuval Shaia <yuval.shaia.ml@gmail.com> wrote:
>> >>
>> >> Guest driver might execute HW commands when shared buffers are not yet
>> >> allocated.
>> >> This could happen on purpose (malicious guest) or because of some other
>> >> guest/host address mapping error.
>> >> We need to protect againts such case.
>> >>
>> >> Fixes: CVE-2022-1050
>> >>
>> >> Reported-by: Raven <wxhusst@gmail.com>
>> >> Signed-off-by: Yuval Shaia <yuval.shaia.ml@gmail.com>
>> >> ---
>> >> v1 -> v2:
>> >> * Commit message changes
>> >> v2 -> v3:
>> >> * Exclude cosmetic changes
>> >> ---
>> >> hw/rdma/vmw/pvrdma_cmd.c | 6 ++++++
>> >> 1 file changed, 6 insertions(+)
>> >>
>> >> diff --git a/hw/rdma/vmw/pvrdma_cmd.c b/hw/rdma/vmw/pvrdma_cmd.c
>> >> index da7ddfa548..89db963c46 100644
>> >> --- a/hw/rdma/vmw/pvrdma_cmd.c
>> >> +++ b/hw/rdma/vmw/pvrdma_cmd.c
>> >> @@ -796,6 +796,12 @@ int pvrdma_exec_cmd(PVRDMADev *dev)
>> >>
>> >> dsr_info = &dev->dsr_info;
>> >>
>> >> + if (!dsr_info->dsr) {
>> >> + /* Buggy or malicious guest driver */
>> >> + rdma_error_report("Exec command without dsr, req or rsp buffers");
>> >> + goto out;
>> >> + }
>> >> +
>> >> if (dsr_info->req->hdr.cmd >= sizeof(cmd_handlers) /
>> >> sizeof(struct cmd_handler)) {
>> >> rdma_error_report("Unsupported command");
>> >> --
>> >> 2.20.1
>> >>
>> >
>> > cc-ing Peter and Philippe for a question:
>> > Do we have a "Security Fixes" or a "Misc" subtree? Otherwise it will
>> > have to wait a week or so.
>> >
>> > Reviewed by: Marcel Apfelbaum <marcel.apfelbaum@gmail.com>
>> > Thanks,
>> > Marcel
>> >
>>
>> Hi all,
>>
>> patch is reviewed, anything holding back the inclusion of this security fix?
>>
>> Thanks,
>>
>> Claudio
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH v3] hw/pvrdma: Protect against buggy or malicious guest driver
2022-12-19 11:21 ` Marcel Apfelbaum
@ 2022-12-28 19:32 ` Thomas Huth
2023-01-16 17:50 ` Laurent Vivier
0 siblings, 1 reply; 10+ messages in thread
From: Thomas Huth @ 2022-12-28 19:32 UTC (permalink / raw)
To: Marcel Apfelbaum, Yuval Shaia, Philippe Mathieu-Daudé, QEMU Trivial
Cc: Claudio Fontana, qemu devel list, Peter Maydell, wxhusst, Paolo Bonzini
On 19/12/2022 12.21, Marcel Apfelbaum wrote:
> On Mon, Dec 19, 2022 at 10:57 AM Yuval Shaia <yuval.shaia.ml@gmail.com> wrote:
>>
>> Can anyone else pick this one?
>
> Adding Thomas,
>
> I dropped the ball with this one, I am sorry about that, maybe it
> doesn't worth a Pull Request only for it.
Why not? Pull request for single patches aren't that uncommon.
> Maybe it can go through the Misc tree?
hw/rdma/ is really not my turf, but since the patch is small, it sounds like
a good candidate for qemu-trivial, I think.
Thomas
>> On Wed, 7 Dec 2022 at 17:05, Claudio Fontana <cfontana@suse.de> wrote:
>>>
>>> On 4/5/22 12:31, Marcel Apfelbaum wrote:
>>>> Hi Yuval,
>>>> Thank you for the changes.
>>>>
>>>> On Sun, Apr 3, 2022 at 11:54 AM Yuval Shaia <yuval.shaia.ml@gmail.com> wrote:
>>>>>
>>>>> Guest driver might execute HW commands when shared buffers are not yet
>>>>> allocated.
>>>>> This could happen on purpose (malicious guest) or because of some other
>>>>> guest/host address mapping error.
>>>>> We need to protect againts such case.
>>>>>
>>>>> Fixes: CVE-2022-1050
>>>>>
>>>>> Reported-by: Raven <wxhusst@gmail.com>
>>>>> Signed-off-by: Yuval Shaia <yuval.shaia.ml@gmail.com>
>>>>> ---
>>>>> v1 -> v2:
>>>>> * Commit message changes
>>>>> v2 -> v3:
>>>>> * Exclude cosmetic changes
>>>>> ---
>>>>> hw/rdma/vmw/pvrdma_cmd.c | 6 ++++++
>>>>> 1 file changed, 6 insertions(+)
>>>>>
>>>>> diff --git a/hw/rdma/vmw/pvrdma_cmd.c b/hw/rdma/vmw/pvrdma_cmd.c
>>>>> index da7ddfa548..89db963c46 100644
>>>>> --- a/hw/rdma/vmw/pvrdma_cmd.c
>>>>> +++ b/hw/rdma/vmw/pvrdma_cmd.c
>>>>> @@ -796,6 +796,12 @@ int pvrdma_exec_cmd(PVRDMADev *dev)
>>>>>
>>>>> dsr_info = &dev->dsr_info;
>>>>>
>>>>> + if (!dsr_info->dsr) {
>>>>> + /* Buggy or malicious guest driver */
>>>>> + rdma_error_report("Exec command without dsr, req or rsp buffers");
>>>>> + goto out;
>>>>> + }
>>>>> +
>>>>> if (dsr_info->req->hdr.cmd >= sizeof(cmd_handlers) /
>>>>> sizeof(struct cmd_handler)) {
>>>>> rdma_error_report("Unsupported command");
>>>>> --
>>>>> 2.20.1
>>>>>
>>>>
>>>> cc-ing Peter and Philippe for a question:
>>>> Do we have a "Security Fixes" or a "Misc" subtree? Otherwise it will
>>>> have to wait a week or so.
>>>>
>>>> Reviewed by: Marcel Apfelbaum <marcel.apfelbaum@gmail.com>
>>>> Thanks,
>>>> Marcel
>>>>
>>>
>>> Hi all,
>>>
>>> patch is reviewed, anything holding back the inclusion of this security fix?
>>>
>>> Thanks,
>>>
>>> Claudio
>
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH v3] hw/pvrdma: Protect against buggy or malicious guest driver
2022-12-28 19:32 ` Thomas Huth
@ 2023-01-16 17:50 ` Laurent Vivier
2023-05-15 16:08 ` Michael Tokarev
[not found] ` <147b4e5e-009a-7ab8-7dfc-ea7735319c97@tls.msk.ru>
0 siblings, 2 replies; 10+ messages in thread
From: Laurent Vivier @ 2023-01-16 17:50 UTC (permalink / raw)
To: Thomas Huth, Marcel Apfelbaum, Yuval Shaia,
Philippe Mathieu-Daudé,
QEMU Trivial
Cc: Claudio Fontana, qemu devel list, Peter Maydell, wxhusst, Paolo Bonzini
Le 28/12/2022 à 20:32, Thomas Huth a écrit :
> On 19/12/2022 12.21, Marcel Apfelbaum wrote:
>> On Mon, Dec 19, 2022 at 10:57 AM Yuval Shaia <yuval.shaia.ml@gmail.com> wrote:
>>>
>>> Can anyone else pick this one?
>>
>> Adding Thomas,
>>
>> I dropped the ball with this one, I am sorry about that, maybe it
>> doesn't worth a Pull Request only for it.
>
> Why not? Pull request for single patches aren't that uncommon.
>
>> Maybe it can go through the Misc tree?
>
> hw/rdma/ is really not my turf, but since the patch is small, it sounds like a good candidate for
> qemu-trivial, I think.
Applied to my trivial-patches branch.
Thanks,
Laurent
>
> Thomas
>
>
>>> On Wed, 7 Dec 2022 at 17:05, Claudio Fontana <cfontana@suse.de> wrote:
>>>>
>>>> On 4/5/22 12:31, Marcel Apfelbaum wrote:
>>>>> Hi Yuval,
>>>>> Thank you for the changes.
>>>>>
>>>>> On Sun, Apr 3, 2022 at 11:54 AM Yuval Shaia <yuval.shaia.ml@gmail.com> wrote:
>>>>>>
>>>>>> Guest driver might execute HW commands when shared buffers are not yet
>>>>>> allocated.
>>>>>> This could happen on purpose (malicious guest) or because of some other
>>>>>> guest/host address mapping error.
>>>>>> We need to protect againts such case.
>>>>>>
>>>>>> Fixes: CVE-2022-1050
>>>>>>
>>>>>> Reported-by: Raven <wxhusst@gmail.com>
>>>>>> Signed-off-by: Yuval Shaia <yuval.shaia.ml@gmail.com>
>>>>>> ---
>>>>>> v1 -> v2:
>>>>>> * Commit message changes
>>>>>> v2 -> v3:
>>>>>> * Exclude cosmetic changes
>>>>>> ---
>>>>>> hw/rdma/vmw/pvrdma_cmd.c | 6 ++++++
>>>>>> 1 file changed, 6 insertions(+)
>>>>>>
>>>>>> diff --git a/hw/rdma/vmw/pvrdma_cmd.c b/hw/rdma/vmw/pvrdma_cmd.c
>>>>>> index da7ddfa548..89db963c46 100644
>>>>>> --- a/hw/rdma/vmw/pvrdma_cmd.c
>>>>>> +++ b/hw/rdma/vmw/pvrdma_cmd.c
>>>>>> @@ -796,6 +796,12 @@ int pvrdma_exec_cmd(PVRDMADev *dev)
>>>>>>
>>>>>> dsr_info = &dev->dsr_info;
>>>>>>
>>>>>> + if (!dsr_info->dsr) {
>>>>>> + /* Buggy or malicious guest driver */
>>>>>> + rdma_error_report("Exec command without dsr, req or rsp buffers");
>>>>>> + goto out;
>>>>>> + }
>>>>>> +
>>>>>> if (dsr_info->req->hdr.cmd >= sizeof(cmd_handlers) /
>>>>>> sizeof(struct cmd_handler)) {
>>>>>> rdma_error_report("Unsupported command");
>>>>>> --
>>>>>> 2.20.1
>>>>>>
>>>>>
>>>>> cc-ing Peter and Philippe for a question:
>>>>> Do we have a "Security Fixes" or a "Misc" subtree? Otherwise it will
>>>>> have to wait a week or so.
>>>>>
>>>>> Reviewed by: Marcel Apfelbaum <marcel.apfelbaum@gmail.com>
>>>>> Thanks,
>>>>> Marcel
>>>>>
>>>>
>>>> Hi all,
>>>>
>>>> patch is reviewed, anything holding back the inclusion of this security fix?
>>>>
>>>> Thanks,
>>>>
>>>> Claudio
>>
>
>
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH v3] hw/pvrdma: Protect against buggy or malicious guest driver
2023-01-16 17:50 ` Laurent Vivier
@ 2023-05-15 16:08 ` Michael Tokarev
[not found] ` <147b4e5e-009a-7ab8-7dfc-ea7735319c97@tls.msk.ru>
1 sibling, 0 replies; 10+ messages in thread
From: Michael Tokarev @ 2023-05-15 16:08 UTC (permalink / raw)
To: Laurent Vivier, Thomas Huth, Marcel Apfelbaum, Yuval Shaia,
Philippe Mathieu-Daudé,
QEMU Trivial
Cc: Claudio Fontana, qemu devel list, Peter Maydell, wxhusst, Paolo Bonzini
16.01.2023 20:50, Laurent Vivier wrote:
> Le 28/12/2022 à 20:32, Thomas Huth a écrit :
>> On 19/12/2022 12.21, Marcel Apfelbaum wrote:
>>> On Mon, Dec 19, 2022 at 10:57 AM Yuval Shaia <yuval.shaia.ml@gmail.com> wrote:
>>>>
>>>> Can anyone else pick this one?
>>>
>>> Adding Thomas,
>>>
>>> I dropped the ball with this one, I am sorry about that, maybe it
>>> doesn't worth a Pull Request only for it.
>>
>> Why not? Pull request for single patches aren't that uncommon.
>>
>>> Maybe it can go through the Misc tree?
>>
>> hw/rdma/ is really not my turf, but since the patch is small, it sounds like a good candidate for qemu-trivial, I think.
>
> Applied to my trivial-patches branch.
Has it been forgotten again? :)
/mjt
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH v3] hw/pvrdma: Protect against buggy or malicious guest driver
[not found] ` <147b4e5e-009a-7ab8-7dfc-ea7735319c97@tls.msk.ru>
@ 2023-05-15 16:09 ` Michael Tokarev
0 siblings, 0 replies; 10+ messages in thread
From: Michael Tokarev @ 2023-05-15 16:09 UTC (permalink / raw)
To: Laurent Vivier, Thomas Huth, Marcel Apfelbaum, Yuval Shaia,
Philippe Mathieu-Daudé,
QEMU Trivial
Cc: Claudio Fontana, qemu devel list, Peter Maydell, wxhusst, Paolo Bonzini
15.05.2023 19:08, Michael Tokarev пишет:
> 16.01.2023 20:50, Laurent Vivier wrote:
>> Le 28/12/2022 à 20:32, Thomas Huth a écrit :
>>> On 19/12/2022 12.21, Marcel Apfelbaum wrote:
>>>> On Mon, Dec 19, 2022 at 10:57 AM Yuval Shaia <yuval.shaia.ml@gmail.com> wrote:
>>>>>
>>>>> Can anyone else pick this one?
>>>>
>>>> Adding Thomas,
>>>>
>>>> I dropped the ball with this one, I am sorry about that, maybe it
>>>> doesn't worth a Pull Request only for it.
>>>
>>> Why not? Pull request for single patches aren't that uncommon.
>>>
>>>> Maybe it can go through the Misc tree?
>>>
>>> hw/rdma/ is really not my turf, but since the patch is small, it sounds like a good candidate for qemu-trivial, I think.
>>
>> Applied to my trivial-patches branch.
>
> Has it been forgotten again? :)
Ah nope. There are 2 patches with the same subject, always confusing.
This one is applied.
/mjt
^ permalink raw reply [flat|nested] 10+ messages in thread
end of thread, other threads:[~2023-05-15 16:10 UTC | newest]
Thread overview: 10+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-04-03 9:52 [PATCH v3] hw/pvrdma: Protect against buggy or malicious guest driver Yuval Shaia
2022-04-05 10:31 ` Marcel Apfelbaum
2022-12-07 15:05 ` Claudio Fontana
2022-12-19 9:57 ` Yuval Shaia
2022-12-19 11:21 ` Marcel Apfelbaum
2022-12-28 19:32 ` Thomas Huth
2023-01-16 17:50 ` Laurent Vivier
2023-05-15 16:08 ` Michael Tokarev
[not found] ` <147b4e5e-009a-7ab8-7dfc-ea7735319c97@tls.msk.ru>
2023-05-15 16:09 ` Michael Tokarev
2022-09-12 17:45 ` Michael Tokarev
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.