[PATCH] Correct kms_fbc_crc case Debugfs i915_fbc_status shows "FBC unsupported on this chipset" not "unsupported by this chipset" if the platform doesn't support FBC feature. That typo will cause case fail on some platforms such as byt , bsw.

[PATCH] Correct kms_fbc_crc case Debugfs i915_fbc_status shows "FBC unsupported on this chipset" not "unsupported by this chipset" if the platform doesn't support FBC feature. That typo will cause case fail on some platforms such as byt , bsw.

[liu,lei]

From: "liu,lei" <lei.a.liu@intel.com>

---
 tests/kms_fbc_crc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tests/kms_fbc_crc.c b/tests/kms_fbc_crc.c
index ccdec33..1320bad 100644
--- a/tests/kms_fbc_crc.c
+++ b/tests/kms_fbc_crc.c
@@ -513,7 +513,7 @@ igt_main
 		igt_assert_lt(0, fread(buf, 1, sizeof(buf), status));
 		fclose(status);
 		buf[sizeof(buf) - 1] = '\0';
-		igt_require_f(!strstr(buf, "unsupported by this chipset") &&
+		igt_require_f(!strstr(buf, "unsupported on this chipset") &&
 			      !strstr(buf, "disabled per module param") &&
 			      !strstr(buf, "disabled per chip default"),
 			      "FBC not supported/enabled\n");
-- 
1.8.3.1

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [PATCH] Correct kms_fbc_crc case Debugfs i915_fbc_status shows "FBC unsupported on this chipset" not "unsupported by this chipset" if the platform doesn't support FBC feature. That typo will cause case fail on some platforms such as byt , bsw.

[Daniel Vetter]

On Thu, Apr 09, 2015 at 01:51:24PM +0800, liu,lei wrote:
> From: "liu,lei" <lei.a.liu@intel.com>

In igt we follow the kernel conventions for patch commit messages:
- First line (subject) summarizes the patch in at most 70 chars
- After an empty line comes the extended commit message (you have that in
  the first line so it ends up in the subject).
- signed-off-by line at the bottom.

Can you please fix that up and resubmit?

Thanks, Daniel
> 
> ---
>  tests/kms_fbc_crc.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tests/kms_fbc_crc.c b/tests/kms_fbc_crc.c
> index ccdec33..1320bad 100644
> --- a/tests/kms_fbc_crc.c
> +++ b/tests/kms_fbc_crc.c
> @@ -513,7 +513,7 @@ igt_main
>  		igt_assert_lt(0, fread(buf, 1, sizeof(buf), status));
>  		fclose(status);
>  		buf[sizeof(buf) - 1] = '\0';
> -		igt_require_f(!strstr(buf, "unsupported by this chipset") &&
> +		igt_require_f(!strstr(buf, "unsupported on this chipset") &&
>  			      !strstr(buf, "disabled per module param") &&
>  			      !strstr(buf, "disabled per chip default"),
>  			      "FBC not supported/enabled\n");
> -- 
> 1.8.3.1
> 
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/intel-gfx

-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [PATCH] Correct kms_fbc_crc case Debugfs i915_fbc_status shows "FBC unsupported on this chipset" not "unsupported by this chipset" if the platform doesn't support FBC feature. That typo will cause case fail on some platforms such as byt...

[Liu, Lei A]

I resend that patch. Forgive me that I forgot to add you in cc list. Pardon my original disordered commit message.
Really appreciate your guidance.

-----Original Message-----
From: Daniel Vetter [mailto:daniel.vetter@ffwll.ch] On Behalf Of Daniel Vetter
Sent: Thursday, April 09, 2015 8:24 PM
To: Liu, Lei A
Cc: intel-gfx@lists.freedesktop.org; Tian, YeX; Jin, Gordon
Subject: Re: [Intel-gfx] [PATCH] Correct kms_fbc_crc case Debugfs i915_fbc_status shows "FBC unsupported on this chipset" not "unsupported by this chipset" if the platform doesn't support FBC feature. That typo will cause case fail on some platforms such as byt...

On Thu, Apr 09, 2015 at 01:51:24PM +0800, liu,lei wrote:
> From: "liu,lei" <lei.a.liu@intel.com>

In igt we follow the kernel conventions for patch commit messages:
- First line (subject) summarizes the patch in at most 70 chars
- After an empty line comes the extended commit message (you have that in
  the first line so it ends up in the subject).
- signed-off-by line at the bottom.

Can you please fix that up and resubmit?

Thanks, Daniel
> 
> ---
>  tests/kms_fbc_crc.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tests/kms_fbc_crc.c b/tests/kms_fbc_crc.c index 
> ccdec33..1320bad 100644
> --- a/tests/kms_fbc_crc.c
> +++ b/tests/kms_fbc_crc.c
> @@ -513,7 +513,7 @@ igt_main
>  		igt_assert_lt(0, fread(buf, 1, sizeof(buf), status));
>  		fclose(status);
>  		buf[sizeof(buf) - 1] = '\0';
> -		igt_require_f(!strstr(buf, "unsupported by this chipset") &&
> +		igt_require_f(!strstr(buf, "unsupported on this chipset") &&
>  			      !strstr(buf, "disabled per module param") &&
>  			      !strstr(buf, "disabled per chip default"),
>  			      "FBC not supported/enabled\n");
> --
> 1.8.3.1
> 
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/intel-gfx

--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx