[PATCH][meta-oe] freerdp: get out of "nonworking", fix build, improve

[PATCH][meta-oe] freerdp: get out of "nonworking", fix build, improve

[Manuel Bachmann]

We make the "freerdp" recipe active again, fix the build
by pulling a more recent version (the "stable" branches are
buggy and useless), and fix ARM runtime with -fPIC.

We can then :
- make X11 non-mandatory ;
- add support for Wayland ("wlfreerdp" client) ;
- add support for DirectFB ("dfreerdp" client) ;
- add support for GStreamer 1.0 ;
- make "heavy" features such as pulseaudio, cups...
non-mandatory.

We really want to install the "winpr-makecert" tool to have
TLS, but CMake does not position its RPATH cleanly, so let
us have a custom patch for that until it gets sorted out.

Signed-off-by: Manuel Bachmann <manuel.bachmann@iot.bzh>
---
 meta-oe/recipes-support/freerdp/freerdp.inc        | 73 ++++++++++++++++++++++
 .../winpr-makecert-Build-with-install-RPATH.patch  | 31 +++++++++
 meta-oe/recipes-support/freerdp/freerdp_git.bb     | 21 +++++++
 .../recipes-support/nonworking/freerdp/freerdp.inc | 51 ---------------
 .../nonworking/freerdp/freerdp_git.bb              | 16 -----
 5 files changed, 125 insertions(+), 67 deletions(-)
 create mode 100644 meta-oe/recipes-support/freerdp/freerdp.inc
 create mode 100644 meta-oe/recipes-support/freerdp/freerdp/winpr-makecert-Build-with-install-RPATH.patch
 create mode 100644 meta-oe/recipes-support/freerdp/freerdp_git.bb
 delete mode 100644 meta-oe/recipes-support/nonworking/freerdp/freerdp.inc
 delete mode 100644 meta-oe/recipes-support/nonworking/freerdp/freerdp_git.bb

diff --git a/meta-oe/recipes-support/freerdp/freerdp.inc b/meta-oe/recipes-support/freerdp/freerdp.inc
new file mode 100644
index 0000000..af93e83
--- /dev/null
+++ b/meta-oe/recipes-support/freerdp/freerdp.inc
@@ -0,0 +1,73 @@
+# Copyright (C) 2010-2012 O.S. Systems Software Ltda. All Rights Reserved
+# Released under the MIT license
+
+DESCRIPTION = "FreeRDP RDP client & server library"
+HOMEPAGE = "http://www.freerdp.com"
+DEPENDS = "openssl alsa-lib pcsc-lite"
+SECTION = "net"
+LICENSE = "Apache-2.0"
+LIC_FILES_CHKSUM = "file://LICENSE;md5=3b83ef96387f14655fc854ddc3c6bd57"
+
+inherit pkgconfig cmake
+
+EXTRA_OECMAKE += "-DWITH_ALSA=ON \
+                  -DWITH_PCSC=ON \
+                  -DWITH_FFMPEG=OFF \
+                  -DWITH_CUNIT=OFF \
+                 "
+
+PACKAGECONFIG ??= "  \
+                ${@bb.utils.contains('DISTRO_FEATURES', 'x11', 'x11', '', d)}\
+                ${@bb.utils.contains('DISTRO_FEATURES', 'wayland', 'wayland', '', d)}\
+                ${@bb.utils.contains('DISTRO_FEATURES', 'directfb', 'directfb', '', d)}\
+                ${@bb.utils.contains('DISTRO_FEATURES', 'pam', 'pam', '', d)}\
+                ${@bb.utils.contains('DISTRO_FEATURES', 'pulseaudio', 'pulseaudio', '', d)}\
+                gstreamer cups \
+                "
+
+X11_DEPS = "virtual/libx11 libxinerama libxext libxcursor libxv libxi libxrender libxfixes libxdamage libxrandr libxkbfile"
+PACKAGECONFIG[x11] = "-DWITH_X11=ON -DWITH_XINERAMA=ON -DWITH_XEXT=ON -DWITH_XCURSOR=ON -DWITH_XV=ON -DWITH_XI=ON -DWITH_XRENDER=ON -DWITH_XFIXES=ON -DWITH_XDAMAGE=ON -DWITH_XRANDR=ON -DWITH_XKBFILE=ON,-DWITH_X11=OFF,${X11_DEPS}"
+PACKAGECONFIG[wayland] = "-DWITH_WAYLAND=ON,-DWITH_WAYLAND=OFF,wayland"
+PACKAGECONFIG[directfb] = "-DWITH_DIRECTFB=ON,-DWITH_DIRECTFB=OFF,directfb"
+PACKAGECONFIG[pam] = "-DWITH_PAM=ON,-DWITH_PAM=OFF,libpam"
+PACKAGECONFIG[pulseaudio] = "-DWITH_PULSEAUDIO=ON,-DWITH_PULSEAUDIO=OFF,pulseaudio"
+PACKAGECONFIG[gstreamer] = "-DWITH_GSTREAMER_1_0=ON,-DWITH_GSTREAMER_1_0=OFF,gstreamer1.0 gstreamer1.0-plugins-base"
+PACKAGECONFIG[cups] = "-DWITH_CUPS=ON,-DWITH_CUPS=OFF,cups"
+
+PACKAGES =+ "libfreerdp"
+
+LEAD_SONAME = "libfreerdp.so"
+FILES_libfreerdp = "${libdir}/lib*${SOLIBS}"
+
+PACKAGES_DYNAMIC += "^libfreerdp-plugin-.*"
+
+# we will need winpr-makecert to generate TLS certificates
+do_install_append () {
+    install -m755 winpr/tools/makecert/cli/winpr-makecert ${D}${bindir}
+    rm -rf ${D}/${libdir}/cmake
+    rm -rf ${D}/${libdir}/freerdp
+}
+
+python populate_packages_prepend () {
+    freerdp_root = d.expand('${libdir}/freerdp')
+
+    do_split_packages(d, freerdp_root, '^(audin_.*)\.so$',
+        output_pattern='libfreerdp-plugin-%s',
+        description='FreeRDP plugin %s',
+        prepend=True, extra_depends='libfreerdp-plugin-audin')
+
+    do_split_packages(d, freerdp_root, '^(rdpsnd_.*)\.so$',
+        output_pattern='libfreerdp-plugin-%s',
+        description='FreeRDP plugin %s',
+        prepend=True, extra_depends='libfreerdp-plugin-rdpsnd')
+
+    do_split_packages(d, freerdp_root, '^(tsmf_.*)\.so$',
+        output_pattern='libfreerdp-plugin-%s',
+        description='FreeRDP plugin %s',
+        prepend=True, extra_depends='libfreerdp-plugin-tsmf')
+
+    do_split_packages(d, freerdp_root, '^([^-]*)\.so$',
+        output_pattern='libfreerdp-plugin-%s',
+        description='FreeRDP plugin %s',
+        prepend=True, extra_depends='')
+}
diff --git a/meta-oe/recipes-support/freerdp/freerdp/winpr-makecert-Build-with-install-RPATH.patch b/meta-oe/recipes-support/freerdp/freerdp/winpr-makecert-Build-with-install-RPATH.patch
new file mode 100644
index 0000000..d279d6d
--- /dev/null
+++ b/meta-oe/recipes-support/freerdp/freerdp/winpr-makecert-Build-with-install-RPATH.patch
@@ -0,0 +1,31 @@
+From 253eafc8c8da83fc2b1a99a9e43824efc6105c7a Mon Sep 17 00:00:00 2001
+From: Manuel Bachmann <manuel.bachmann@iot.bzh>
+Date: Sun, 4 Oct 2015 10:44:49 +0200
+Subject: [PATCH] winpr-makecert: Build with install RPATH
+
+As we are installing "winpr-makecert" manually, we do want
+to refer to the library in DESTDIR, not the one resting in
+the build tree.
+
+Signed-off-by: Manuel Bachmann <manuel.bachmann@iot.bzh>
+---
+ winpr/tools/makecert/cli/CMakeLists.txt | 4 ++++
+ 1 file changed, 4 insertions(+)
+
+diff --git a/winpr/tools/makecert/cli/CMakeLists.txt b/winpr/tools/makecert/cli/CMakeLists.txt
+index 17954c4..90c446b 100644
+--- a/winpr/tools/makecert/cli/CMakeLists.txt
++++ b/winpr/tools/makecert/cli/CMakeLists.txt
+@@ -45,5 +45,9 @@ set(${MODULE_PREFIX}_LIBS winpr-makecert-tool)
+ 
+ target_link_libraries(${MODULE_NAME} ${${MODULE_PREFIX}_LIBS})
+ 
++set_target_properties(${MODULE_NAME} PROPERTIES 
++	BUILD_WITH_INSTALL_RPATH 1)
++
+ set_property(TARGET ${MODULE_NAME} PROPERTY FOLDER "WinPR/Tools")
+ 
++
+-- 
+1.8.3.1
+
diff --git a/meta-oe/recipes-support/freerdp/freerdp_git.bb b/meta-oe/recipes-support/freerdp/freerdp_git.bb
new file mode 100644
index 0000000..f9cb9a6
--- /dev/null
+++ b/meta-oe/recipes-support/freerdp/freerdp_git.bb
@@ -0,0 +1,21 @@
+# Copyright (C) 2010-2012, O.S. Systems Software Ltda.
+# Released under the MIT license
+
+include freerdp.inc
+
+inherit gitpkgv
+
+PV = "1.2.5+gitr${SRCPV}"
+PKGV = "${GITPKGVTAG}"
+
+EXTRA_OECMAKE += "-DBUILD_STATIC_LIBS=OFF \
+                  -DCMAKE_POSITION_INDEPENDANT_CODE=ON \
+                  -DWITH_MANPAGES=OFF \
+                 "
+
+SRCREV = "62da9d28c674814c81c245c1c7882eb0da7be76b"
+SRC_URI = "git://github.com/FreeRDP/FreeRDP.git \
+           file://winpr-makecert-Build-with-install-RPATH.patch \
+          "
+
+S = "${WORKDIR}/git"
diff --git a/meta-oe/recipes-support/nonworking/freerdp/freerdp.inc b/meta-oe/recipes-support/nonworking/freerdp/freerdp.inc
deleted file mode 100644
index 34dac4b..0000000
--- a/meta-oe/recipes-support/nonworking/freerdp/freerdp.inc
+++ /dev/null
@@ -1,51 +0,0 @@
-# Copyright (C) 2010-2012 O.S. Systems Software Ltda. All Rights Reserved
-# Released under the MIT license
-
-DESCRIPTION = "FreeRDP RDP client"
-HOMEPAGE = "http://www.freerdp.com"
-DEPENDS = "virtual/libx11 openssl libxcursor libxv cups alsa-lib pulseaudio pcsc-lite libxkbfile libxinerama"
-SECTION = "x11/network"
-LICENSE = "Apache-2.0"
-LIC_FILES_CHKSUM = "file://LICENSE;md5=3b83ef96387f14655fc854ddc3c6bd57"
-
-inherit pkgconfig cmake
-
-EXTRA_OECMAKE += "-DWITH_PULSEAUDIO=ON \
-                  -DWITH_PCSC=ON \
-                  -DWITH_CUPS=ON \
-                  -DWITH_FFMPEG=OFF \
-                  -DWITH_CUNIT=OFF \
-                  -DWITH_X11=ON \
-                  -DWITH_XKBFILE=ON \
-                  -DWITH_XINERAMA=ON"
-
-PACKAGES =+ "libfreerdp"
-
-LEAD_SONAME = "libfreerdp.so"
-FILES_libfreerdp = "${libdir}/lib*${SOLIBS}"
-
-PACKAGES_DYNAMIC += "^libfreerdp-plugin-.*"
-
-python populate_packages_prepend () {
-    freerdp_root = d.expand('${libdir}/freerdp')
-
-    do_split_packages(d, freerdp_root, '^(audin_.*)\.so$',
-        output_pattern='libfreerdp-plugin-%s',
-        description='FreeRDP plugin %s',
-        prepend=True, extra_depends='libfreerdp-plugin-audin')
-
-    do_split_packages(d, freerdp_root, '^(rdpsnd_.*)\.so$',
-        output_pattern='libfreerdp-plugin-%s',
-        description='FreeRDP plugin %s',
-        prepend=True, extra_depends='libfreerdp-plugin-rdpsnd')
-
-    do_split_packages(d, freerdp_root, '^(tsmf_.*)\.so$',
-        output_pattern='libfreerdp-plugin-%s',
-        description='FreeRDP plugin %s',
-        prepend=True, extra_depends='libfreerdp-plugin-tsmf')
-
-    do_split_packages(d, freerdp_root, '^([^-]*)\.so$',
-        output_pattern='libfreerdp-plugin-%s',
-        description='FreeRDP plugin %s',
-        prepend=True, extra_depends='')
-}
diff --git a/meta-oe/recipes-support/nonworking/freerdp/freerdp_git.bb b/meta-oe/recipes-support/nonworking/freerdp/freerdp_git.bb
deleted file mode 100644
index 0e9bf06..0000000
--- a/meta-oe/recipes-support/nonworking/freerdp/freerdp_git.bb
+++ /dev/null
@@ -1,16 +0,0 @@
-# Copyright (C) 2010-2012, O.S. Systems Software Ltda.
-# Released under the MIT license
-
-include freerdp.inc
-
-inherit gitpkgv
-
-PV = "1.0.2+gitr${SRCPV}"
-PKGV = "${GITPKGVTAG}"
-
-EXTRA_OECMAKE += "-DWITH_MANPAGES=OFF"
-
-SRCREV = "f311acaffb9190567e2b478a98d7cbfaf2709f6b"
-SRC_URI = "git://github.com/FreeRDP/FreeRDP.git;branch=stable-1.0"
-
-S = "${WORKDIR}/git"
-- 
1.8.3.1

Re: [PATCH][meta-oe] freerdp: get out of "nonworking", fix build, improve

[Otavio Salvador]

On Sun, Oct 4, 2015 at 6:13 AM, Manuel Bachmann <manuel.bachmann@iot.bzh> wrote:
> We make the "freerdp" recipe active again, fix the build
> by pulling a more recent version (the "stable" branches are
> buggy and useless), and fix ARM runtime with -fPIC.
>
> We can then :
> - make X11 non-mandatory ;
> - add support for Wayland ("wlfreerdp" client) ;
> - add support for DirectFB ("dfreerdp" client) ;
> - add support for GStreamer 1.0 ;
> - make "heavy" features such as pulseaudio, cups...
> non-mandatory.
>
> We really want to install the "winpr-makecert" tool to have
> TLS, but CMake does not position its RPATH cleanly, so let
> us have a custom patch for that until it gets sorted out.
>
> Signed-off-by: Manuel Bachmann <manuel.bachmann@iot.bzh>

I fully agree with the changes and those are very welcome. However, it
would be good if you could move from nonworking in one patch and do
the changes here in another patch.

Do you mind to rework it?

-- 
Otavio Salvador                             O.S. Systems
http://www.ossystems.com.br        http://code.ossystems.com.br
Mobile: +55 (53) 9981-7854            Mobile: +1 (347) 903-9750

Re: [PATCH][meta-oe] freerdp: get out of "nonworking", fix build, improve

[Martin Jansa]

[-- Attachment #1: Type: text/plain, Size: 1801 bytes --]

On Tue, Oct 06, 2015 at 06:58:25PM -0300, Otavio Salvador wrote:
> On Sun, Oct 4, 2015 at 6:13 AM, Manuel Bachmann <manuel.bachmann@iot.bzh> wrote:
> > We make the "freerdp" recipe active again, fix the build
> > by pulling a more recent version (the "stable" branches are
> > buggy and useless), and fix ARM runtime with -fPIC.
> >
> > We can then :
> > - make X11 non-mandatory ;
> > - add support for Wayland ("wlfreerdp" client) ;
> > - add support for DirectFB ("dfreerdp" client) ;
> > - add support for GStreamer 1.0 ;
> > - make "heavy" features such as pulseaudio, cups...
> > non-mandatory.
> >
> > We really want to install the "winpr-makecert" tool to have
> > TLS, but CMake does not position its RPATH cleanly, so let
> > us have a custom patch for that until it gets sorted out.
> >
> > Signed-off-by: Manuel Bachmann <manuel.bachmann@iot.bzh>
> 
> I fully agree with the changes and those are very welcome. However, it
> would be good if you could move from nonworking in one patch and do
> the changes here in another patch.

I wanted to get rid of all nonworking directories, I'm sending patch
series which reverts the recipe moves and replaces it with PNBLACKLIST.

> Do you mind to rework it?

Please rebase it on top of current master-next which already has such
reverts.

> 
> -- 
> Otavio Salvador                             O.S. Systems
> http://www.ossystems.com.br        http://code.ossystems.com.br
> Mobile: +55 (53) 9981-7854            Mobile: +1 (347) 903-9750
> -- 
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-devel

-- 
Martin 'JaMa' Jansa     jabber: Martin.Jansa@gmail.com

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 188 bytes --]

Re: [PATCH][meta-oe] freerdp: get out of "nonworking", fix build, improve

[Khem Raj]

[-- Attachment #1: Type: text/plain, Size: 2338 bytes --]


> On Oct 6, 2015, at 3:29 PM, Martin Jansa <martin.jansa@gmail.com> wrote:
> 
> On Tue, Oct 06, 2015 at 06:58:25PM -0300, Otavio Salvador wrote:
>> On Sun, Oct 4, 2015 at 6:13 AM, Manuel Bachmann <manuel.bachmann@iot.bzh> wrote:
>>> We make the "freerdp" recipe active again, fix the build
>>> by pulling a more recent version (the "stable" branches are
>>> buggy and useless), and fix ARM runtime with -fPIC.
>>> 
>>> We can then :
>>> - make X11 non-mandatory ;
>>> - add support for Wayland ("wlfreerdp" client) ;
>>> - add support for DirectFB ("dfreerdp" client) ;
>>> - add support for GStreamer 1.0 ;
>>> - make "heavy" features such as pulseaudio, cups...
>>> non-mandatory.
>>> 
>>> We really want to install the "winpr-makecert" tool to have
>>> TLS, but CMake does not position its RPATH cleanly, so let
>>> us have a custom patch for that until it gets sorted out.
>>> 
>>> Signed-off-by: Manuel Bachmann <manuel.bachmann@iot.bzh>
>> 
>> I fully agree with the changes and those are very welcome. However, it
>> would be good if you could move from nonworking in one patch and do
>> the changes here in another patch.
> 
> I wanted to get rid of all nonworking directories, I'm sending patch
> series which reverts the recipe moves and replaces it with PNBLACKLIST.

PNBLACKLIST still causes parsing overhead. I would suggest to move it to a layer under meta-openembedded
like meta-trash or some such, if someone gets it to work move it back to the appropriate layer.

> 
>> Do you mind to rework it?
> 
> Please rebase it on top of current master-next which already has such
> reverts.
> 
>> 
>> --
>> Otavio Salvador                             O.S. Systems
>> http://www.ossystems.com.br        http://code.ossystems.com.br
>> Mobile: +55 (53) 9981-7854            Mobile: +1 (347) 903-9750
>> --
>> _______________________________________________
>> Openembedded-devel mailing list
>> Openembedded-devel@lists.openembedded.org
>> http://lists.openembedded.org/mailman/listinfo/openembedded-devel
> 
> --
> Martin 'JaMa' Jansa     jabber: Martin.Jansa@gmail.com
> --
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-devel


[-- Attachment #2: Message signed with OpenPGP using GPGMail --]
[-- Type: application/pgp-signature, Size: 211 bytes --]

Re: [PATCH][meta-oe] freerdp: get out of "nonworking", fix build, improve

[Manuel Bachmann]

Hi Martin,

Just did that ; I'm sending a new patch based on top of "master-next" right
now. It will be marked "v2", but title changes and mentions "PNBLACKLIST".

Regards,

*Manuel Bachmann, Graphics Engineer www.iot.bzh <http://iot.bzh> *


2015-10-07 0:29 GMT+02:00 Martin Jansa <martin.jansa@gmail.com>:

> On Tue, Oct 06, 2015 at 06:58:25PM -0300, Otavio Salvador wrote:
> > On Sun, Oct 4, 2015 at 6:13 AM, Manuel Bachmann <manuel.bachmann@iot.bzh>
> wrote:
> > > We make the "freerdp" recipe active again, fix the build
> > > by pulling a more recent version (the "stable" branches are
> > > buggy and useless), and fix ARM runtime with -fPIC.
> > >
> > > We can then :
> > > - make X11 non-mandatory ;
> > > - add support for Wayland ("wlfreerdp" client) ;
> > > - add support for DirectFB ("dfreerdp" client) ;
> > > - add support for GStreamer 1.0 ;
> > > - make "heavy" features such as pulseaudio, cups...
> > > non-mandatory.
> > >
> > > We really want to install the "winpr-makecert" tool to have
> > > TLS, but CMake does not position its RPATH cleanly, so let
> > > us have a custom patch for that until it gets sorted out.
> > >
> > > Signed-off-by: Manuel Bachmann <manuel.bachmann@iot.bzh>
> >
> > I fully agree with the changes and those are very welcome. However, it
> > would be good if you could move from nonworking in one patch and do
> > the changes here in another patch.
>
> I wanted to get rid of all nonworking directories, I'm sending patch
> series which reverts the recipe moves and replaces it with PNBLACKLIST.
>
> > Do you mind to rework it?
>
> Please rebase it on top of current master-next which already has such
> reverts.
>
> >
> > --
> > Otavio Salvador                             O.S. Systems
> > http://www.ossystems.com.br        http://code.ossystems.com.br
> > Mobile: +55 (53) 9981-7854            Mobile: +1 (347) 903-9750
> > --
> > _______________________________________________
> > Openembedded-devel mailing list
> > Openembedded-devel@lists.openembedded.org
> > http://lists.openembedded.org/mailman/listinfo/openembedded-devel
>
> --
> Martin 'JaMa' Jansa     jabber: Martin.Jansa@gmail.com
>
> --
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-devel
>
>

Re: [PATCH][meta-oe] freerdp: get out of "nonworking", fix build, improve

[Martin Jansa]

[-- Attachment #1: Type: text/plain, Size: 3257 bytes --]

On Wed, Oct 07, 2015 at 06:36:41PM -0700, Khem Raj wrote:
> 
> > On Oct 6, 2015, at 3:29 PM, Martin Jansa <martin.jansa@gmail.com> wrote:
> > 
> > On Tue, Oct 06, 2015 at 06:58:25PM -0300, Otavio Salvador wrote:
> >> On Sun, Oct 4, 2015 at 6:13 AM, Manuel Bachmann <manuel.bachmann@iot.bzh> wrote:
> >>> We make the "freerdp" recipe active again, fix the build
> >>> by pulling a more recent version (the "stable" branches are
> >>> buggy and useless), and fix ARM runtime with -fPIC.
> >>> 
> >>> We can then :
> >>> - make X11 non-mandatory ;
> >>> - add support for Wayland ("wlfreerdp" client) ;
> >>> - add support for DirectFB ("dfreerdp" client) ;
> >>> - add support for GStreamer 1.0 ;
> >>> - make "heavy" features such as pulseaudio, cups...
> >>> non-mandatory.
> >>> 
> >>> We really want to install the "winpr-makecert" tool to have
> >>> TLS, but CMake does not position its RPATH cleanly, so let
> >>> us have a custom patch for that until it gets sorted out.
> >>> 
> >>> Signed-off-by: Manuel Bachmann <manuel.bachmann@iot.bzh>
> >> 
> >> I fully agree with the changes and those are very welcome. However, it
> >> would be good if you could move from nonworking in one patch and do
> >> the changes here in another patch.
> > 
> > I wanted to get rid of all nonworking directories, I'm sending patch
> > series which reverts the recipe moves and replaces it with PNBLACKLIST.
> 
> PNBLACKLIST still causes parsing overhead. I would suggest to move it to a layer under meta-openembedded
> like meta-trash or some such, if someone gets it to work move it back to the appropriate layer.

Lets move all blacklisted recipes to meta-broken or some such after
jethro is branched.

Big advantage of PNBLACKLIST is that it's easy to unblacklist from
distro/local.conf and that bbappends in upper layer are still parsed
corectly, moving the recipes to separate layer (which wont be included
in any sane buidls) will force bbappends to be removed and then possibly
reintroduced when the original recipe is fixed and moved back to
appropriate layer.

> 
> > 
> >> Do you mind to rework it?
> > 
> > Please rebase it on top of current master-next which already has such
> > reverts.
> > 
> >> 
> >> --
> >> Otavio Salvador                             O.S. Systems
> >> http://www.ossystems.com.br        http://code.ossystems.com.br
> >> Mobile: +55 (53) 9981-7854            Mobile: +1 (347) 903-9750
> >> --
> >> _______________________________________________
> >> Openembedded-devel mailing list
> >> Openembedded-devel@lists.openembedded.org
> >> http://lists.openembedded.org/mailman/listinfo/openembedded-devel
> > 
> > --
> > Martin 'JaMa' Jansa     jabber: Martin.Jansa@gmail.com
> > --
> > _______________________________________________
> > Openembedded-devel mailing list
> > Openembedded-devel@lists.openembedded.org
> > http://lists.openembedded.org/mailman/listinfo/openembedded-devel
> 



> -- 
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-devel


-- 
Martin 'JaMa' Jansa     jabber: Martin.Jansa@gmail.com

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 188 bytes --]

Re: [PATCH][meta-oe] freerdp: get out of "nonworking", fix build, improve

[Otavio Salvador]

On Thu, Oct 8, 2015 at 12:24 PM, Martin Jansa <martin.jansa@gmail.com> wrote:
> On Wed, Oct 07, 2015 at 06:36:41PM -0700, Khem Raj wrote:
>>
>> > On Oct 6, 2015, at 3:29 PM, Martin Jansa <martin.jansa@gmail.com> wrote:
>> >
>> > On Tue, Oct 06, 2015 at 06:58:25PM -0300, Otavio Salvador wrote:
>> >> On Sun, Oct 4, 2015 at 6:13 AM, Manuel Bachmann <manuel.bachmann@iot.bzh> wrote:
>> >>> We make the "freerdp" recipe active again, fix the build
>> >>> by pulling a more recent version (the "stable" branches are
>> >>> buggy and useless), and fix ARM runtime with -fPIC.
>> >>>
>> >>> We can then :
>> >>> - make X11 non-mandatory ;
>> >>> - add support for Wayland ("wlfreerdp" client) ;
>> >>> - add support for DirectFB ("dfreerdp" client) ;
>> >>> - add support for GStreamer 1.0 ;
>> >>> - make "heavy" features such as pulseaudio, cups...
>> >>> non-mandatory.
>> >>>
>> >>> We really want to install the "winpr-makecert" tool to have
>> >>> TLS, but CMake does not position its RPATH cleanly, so let
>> >>> us have a custom patch for that until it gets sorted out.
>> >>>
>> >>> Signed-off-by: Manuel Bachmann <manuel.bachmann@iot.bzh>
>> >>
>> >> I fully agree with the changes and those are very welcome. However, it
>> >> would be good if you could move from nonworking in one patch and do
>> >> the changes here in another patch.
>> >
>> > I wanted to get rid of all nonworking directories, I'm sending patch
>> > series which reverts the recipe moves and replaces it with PNBLACKLIST.
>>
>> PNBLACKLIST still causes parsing overhead. I would suggest to move it to a layer under meta-openembedded
>> like meta-trash or some such, if someone gets it to work move it back to the appropriate layer.
>
> Lets move all blacklisted recipes to meta-broken or some such after
> jethro is branched.
>
> Big advantage of PNBLACKLIST is that it's easy to unblacklist from
> distro/local.conf and that bbappends in upper layer are still parsed
> corectly, moving the recipes to separate layer (which wont be included
> in any sane buidls) will force bbappends to be removed and then possibly
> reintroduced when the original recipe is fixed and moved back to
> appropriate layer.

I like to meta-broken proposal however I think it should still have
the blacklist. It helps highlight a possible cause and allow for easy
development of fixup patch.

-- 
Otavio Salvador                             O.S. Systems
http://www.ossystems.com.br        http://code.ossystems.com.br
Mobile: +55 (53) 9981-7854            Mobile: +1 (347) 903-9750