* [PATCH for-4.11 v3 1/2] Add Designated Reviewer (R:) to MAINTAINERS file and add support for it in get_maintainer.pl
2018-05-01 8:03 [PATCH for-4.11 v3 0/2] Add Designated Reviewer (R:) to MAINTAINERS (plus a test case) Lars Kurth
@ 2018-05-01 8:03 ` Lars Kurth
2018-05-01 8:03 ` [PATCH for-4.11 v3 2/2] Add Brian Woods as Designated reviewer to AMD IOMMU and AMD SVM Lars Kurth
2018-05-01 12:44 ` [PATCH for-4.11 v3 0/2] Add Designated Reviewer (R:) to MAINTAINERS (plus a test case) Ian Jackson
2 siblings, 0 replies; 4+ messages in thread
From: Lars Kurth @ 2018-05-01 8:03 UTC (permalink / raw)
To: xen-devel
Cc: Juergen Gross, Lars Kurth, Stefano Stabellini, Wei Liu,
George Dunlap, Andrew Cooper, Ian Jackson, Tim Deegan,
Julien Grall, Jan Beulich
The syntax has been copied from the Linux Maintainers file. I moved the following Linux
get_maintainer.pl patches to Xen, fixing up some merge issues (and a bug).
The get_maintainer.pl changes were based on the following git commits
* https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/scripts/get_maintainer.pl?id=
* c1c3f2c906e35bcb6e4cdf5b8e077660fead14fe
* 4f07510df2e8c47fd65b8ffaaf6c5d334d59d598
I also removed code related to
P: Person (obsolete)
which is in the Linux MAINTAINER's file, but not ours. I may not have
caught all instances though.
I have tested on a number of files using mock entries in MAINTAINERS
using ./scripts/get_maintainer.pl -f ...
I also tested --nor to disable the support and it worked as expected.
Cc: Lars Kurth <lars.kurth@citrix.com>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>
Cc: George Dunlap <George.Dunlap@eu.citrix.com>
Cc: Ian Jackson <ian.jackson@eu.citrix.com>
Cc: Jan Beulich <jbeulich@suse.com>
Cc: Julien Grall <julien.grall@arm.com>
Cc: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
Cc: Stefano Stabellini <sstabellini@kernel.org>
Cc: Tim Deegan <tim@xen.org>
Cc: Wei Liu <wei.liu2@citrix.com>
Cc: Juergen Gross <jgross@suse.com>
Signed-off-by: Lars Kurth <lars.kurth@citrix.com>
Release-acked-by: Juergen Gross <jgross@suse.com>
Acked-by: Wei Liu <wei.liu2@citrix.com>
---
MAINTAINERS | 4 ++++
scripts/get_maintainer.pl | 24 +++++++++++-------------
2 files changed, 15 insertions(+), 13 deletions(-)
diff --git a/MAINTAINERS b/MAINTAINERS
index 90aa759145..b12048935b 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -60,6 +60,10 @@ appropriate branch.
Descriptions of section entries:
M: Mail patches to: FullName <address@domain>
+ R: Designated reviewer: FullName <address@domain>
+ Reviewers should be CCed on patches. However, they do not
+ have a formal governance role, and are listed here
+ simply because of their own request.
L: Mailing list that is relevant to this area
W: Web-page with status/info
T: SCM tree type and location. Type is one of: git, hg, quilt, stgit.
diff --git a/scripts/get_maintainer.pl b/scripts/get_maintainer.pl
index 3fb1ad4b69..d528da738c 100755
--- a/scripts/get_maintainer.pl
+++ b/scripts/get_maintainer.pl
@@ -21,6 +21,7 @@ my $xen_path = "./";
my $email = 1;
my $email_usename = 1;
my $email_maintainer = 1;
+my $email_reviewer = 1;
my $email_list = 1;
my $email_subscriber_list = 0;
my $email_git_penguin_chiefs = 0;
@@ -199,6 +200,7 @@ if (!GetOptions(
'mailmap!' => \$email_use_mailmap,
'drop_the_rest_supporter!' => \$email_drop_the_rest_supporter_if_supporter_found,
'm!' => \$email_maintainer,
+ 'r!' => \$email_reviewer,
'n!' => \$email_usename,
'l!' => \$email_list,
's!' => \$email_subscriber_list,
@@ -257,7 +259,8 @@ if ($sections) {
}
if ($email &&
- ($email_maintainer + $email_list + $email_subscriber_list +
+ ($email_maintainer + $email_reviewer +
+ $email_list + $email_subscriber_list +
$email_git + $email_git_penguin_chiefs + $email_git_blame) == 0) {
die "$P: Please select at least 1 email option\n";
}
@@ -791,6 +794,7 @@ MAINTAINER field selection options:
--hg-since => hg history to use (default: $email_hg_since)
--interactive => display a menu (mostly useful if used with the --git option)
--m => include maintainer(s) if any
+ --r => include reviewer(s) if any
--n => include name 'Full Name <addr\@domain.tld>'
--l => include list(s) if any
--s => include subscriber only list(s) if any
@@ -817,7 +821,7 @@ Other options:
--help => show this help information
Default options:
- [--email --nogit --git-fallback --m --n --l --multiline -pattern-depth=0
+ [--email --nogit --git-fallback --m --r --n --l --multiline -pattern-depth=0
--remove-duplicates --rolestats]
Notes:
@@ -1080,21 +1084,15 @@ sub add_categories {
}
} elsif ($ptype eq "M") {
my ($name, $address) = parse_email($pvalue);
- if ($name eq "") {
- if ($i > 0) {
- my $tv = $typevalue[$i - 1];
- if ($tv =~ m/^([A-Z]):\s*(.*)/) {
- if ($1 eq "P") {
- $name = $2;
- $pvalue = format_email($name, $address, $email_usename);
- }
- }
- }
- }
if ($email_maintainer) {
my $role = get_maintainer_role($i);
push_email_addresses($pvalue, $role);
}
+ } elsif ($ptype eq "R") {
+ my ($name, $address) = parse_email($pvalue);
+ if ($email_reviewer) {
+ push_email_addresses($pvalue, 'reviewer');
+ }
} elsif ($ptype eq "T") {
push(@scm, $pvalue);
} elsif ($ptype eq "W") {
--
2.13.0
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
^ permalink raw reply related [flat|nested] 4+ messages in thread* [PATCH for-4.11 v3 2/2] Add Brian Woods as Designated reviewer to AMD IOMMU and AMD SVM
2018-05-01 8:03 [PATCH for-4.11 v3 0/2] Add Designated Reviewer (R:) to MAINTAINERS (plus a test case) Lars Kurth
2018-05-01 8:03 ` [PATCH for-4.11 v3 1/2] Add Designated Reviewer (R:) to MAINTAINERS file and add support for it in get_maintainer.pl Lars Kurth
@ 2018-05-01 8:03 ` Lars Kurth
2018-05-01 12:44 ` [PATCH for-4.11 v3 0/2] Add Designated Reviewer (R:) to MAINTAINERS (plus a test case) Ian Jackson
2 siblings, 0 replies; 4+ messages in thread
From: Lars Kurth @ 2018-05-01 8:03 UTC (permalink / raw)
To: xen-devel
Cc: Juergen Gross, Lars Kurth, Stefano Stabellini, Wei Liu,
George Dunlap, Andrew Cooper, Ian Jackson, Tim Deegan,
Julien Grall, Jan Beulich, Brian Woods
This was discussed in an IRC discussion post the April x86 meeting.
On 27/4/18 Juergen gave a RAB via IRC
Cc: Lars Kurth <lars.kurth@citrix.com>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>
Cc: George Dunlap <George.Dunlap@eu.citrix.com>
Cc: Ian Jackson <ian.jackson@eu.citrix.com>
Cc: Jan Beulich <jbeulich@suse.com>
Cc: Julien Grall <julien.grall@arm.com>
Cc: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
Cc: Stefano Stabellini <sstabellini@kernel.org>
Cc: Tim Deegan <tim@xen.org>
Cc: Wei Liu <wei.liu2@citrix.com>
Cc: Brian Woods <brian.woods@amd.com>
Cc: Juergen Gross <jgross@suse.com>
Signed-off-by: Lars Kurth <lars.kurth@citrix.com>
Release-acked-by: Juergen Gross <jgross@suse.com>
Acked-by: Brian Woods <brian.woods@amd.com>
Acked-by: Wei Liu <wei.liu2@citrix.com>
---
MAINTAINERS | 2 ++
1 file changed, 2 insertions(+)
diff --git a/MAINTAINERS b/MAINTAINERS
index b12048935b..b86276dfd7 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -146,12 +146,14 @@ F: tools/libacpi/
AMD IOMMU
M: Suravee Suthikulpanit <suravee.suthikulpanit@amd.com>
+R: Brian Woods <brian.woods@amd.com>
S: Maintained
F: xen/drivers/passthrough/amd/
AMD SVM
M: Boris Ostrovsky <boris.ostrovsky@oracle.com>
M: Suravee Suthikulpanit <suravee.suthikulpanit@amd.com>
+R: Brian Woods <brian.woods@amd.com>
S: Supported
F: xen/arch/x86/hvm/svm/
F: xen/arch/x86/cpu/vpmu_amd.c
--
2.13.0
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
^ permalink raw reply related [flat|nested] 4+ messages in thread