All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jan Kiszka <jan.kiszka@siemens.com>
To: Xenomai <xenomai@xenomai.org>
Subject: [PATCH] cobalt/posix/sem: Pull xnregistry_remove out of nklock
Date: Wed, 25 Aug 2021 14:06:55 +0200	[thread overview]
Message-ID: <33aedba3-088f-db8d-66e4-36515cf644f7@siemens.com> (raw)

From: Jan Kiszka <jan.kiszka@siemens.com>

Neither needed nor correct for named semaphores where xnregistry_remove
will trigger a flush_work when running over the secondary domain.

Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
---
 kernel/cobalt/posix/sem.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/kernel/cobalt/posix/sem.c b/kernel/cobalt/posix/sem.c
index b6709e6927..6fb4dc2c2a 100644
--- a/kernel/cobalt/posix/sem.c
+++ b/kernel/cobalt/posix/sem.c
@@ -94,7 +94,6 @@ int __cobalt_sem_destroy(xnhandle_t handle)
 	}
 
 	cobalt_mark_deleted(sem);
-	xnregistry_remove(sem->resnode.handle);
 	if (!sem->pathname)
 		cobalt_del_resource(&sem->resnode);
 	if (xnsynch_destroy(&sem->synchbase) == XNSYNCH_RESCHED) {
@@ -104,6 +103,7 @@ int __cobalt_sem_destroy(xnhandle_t handle)
 
 	xnlock_put_irqrestore(&nklock, s);
 
+	xnregistry_remove(sem->resnode.handle);
 	if (sem->pathname)
 		putname(sem->pathname);
 
-- 
2.31.1


             reply	other threads:[~2021-08-25 12:06 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-25 12:06 Jan Kiszka [this message]
2021-08-25 12:29 ` [PATCH] cobalt/posix/sem: Pull xnregistry_remove out of nklock Jan Kiszka

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=33aedba3-088f-db8d-66e4-36515cf644f7@siemens.com \
    --to=jan.kiszka@siemens.com \
    --cc=xenomai@xenomai.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.