[PATCH] cobalt/posix/sem: Pull xnregistry_remove out of nklock

[PATCH] cobalt/posix/sem: Pull xnregistry_remove out of nklock

[Jan Kiszka]

From: Jan Kiszka <jan.kiszka@siemens.com>

Neither needed nor correct for named semaphores where xnregistry_remove
will trigger a flush_work when running over the secondary domain.

Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
---
 kernel/cobalt/posix/sem.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/kernel/cobalt/posix/sem.c b/kernel/cobalt/posix/sem.c
index b6709e6927..6fb4dc2c2a 100644
--- a/kernel/cobalt/posix/sem.c
+++ b/kernel/cobalt/posix/sem.c
@@ -94,7 +94,6 @@ int __cobalt_sem_destroy(xnhandle_t handle)
 	}
 
 	cobalt_mark_deleted(sem);
-	xnregistry_remove(sem->resnode.handle);
 	if (!sem->pathname)
 		cobalt_del_resource(&sem->resnode);
 	if (xnsynch_destroy(&sem->synchbase) == XNSYNCH_RESCHED) {
@@ -104,6 +103,7 @@ int __cobalt_sem_destroy(xnhandle_t handle)
 
 	xnlock_put_irqrestore(&nklock, s);
 
+	xnregistry_remove(sem->resnode.handle);
 	if (sem->pathname)
 		putname(sem->pathname);
 
-- 
2.31.1

Re: [PATCH] cobalt/posix/sem: Pull xnregistry_remove out of nklock

[Jan Kiszka]

On 25.08.21 14:06, Jan Kiszka via Xenomai wrote:
> From: Jan Kiszka <jan.kiszka@siemens.com>
> 
> Neither needed nor correct for named semaphores where xnregistry_remove
> will trigger a flush_work when running over the secondary domain.
> 
> Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
> ---
>  kernel/cobalt/posix/sem.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/kernel/cobalt/posix/sem.c b/kernel/cobalt/posix/sem.c
> index b6709e6927..6fb4dc2c2a 100644
> --- a/kernel/cobalt/posix/sem.c
> +++ b/kernel/cobalt/posix/sem.c
> @@ -94,7 +94,6 @@ int __cobalt_sem_destroy(xnhandle_t handle)
>  	}
>  
>  	cobalt_mark_deleted(sem);
> -	xnregistry_remove(sem->resnode.handle);
>  	if (!sem->pathname)
>  		cobalt_del_resource(&sem->resnode);
>  	if (xnsynch_destroy(&sem->synchbase) == XNSYNCH_RESCHED) {
> @@ -104,6 +103,7 @@ int __cobalt_sem_destroy(xnhandle_t handle)
>  
>  	xnlock_put_irqrestore(&nklock, s);
>  
> +	xnregistry_remove(sem->resnode.handle);
>  	if (sem->pathname)
>  		putname(sem->pathname);
>  
> 

Will go in before Florian's registry patches as those surface this
hidden issue. Previously, sems had no entry in proc, thus couldn't
trigger this problem.

Jan

-- 
Siemens AG, T RDA IOT
Corporate Competence Center Embedded Linux