* [Buildroot] [PATCH] package/opensc: add package
@ 2021-10-08 11:03 José Pekkarinen
2021-10-17 16:18 ` Arnout Vandecappelle
0 siblings, 1 reply; 4+ messages in thread
From: José Pekkarinen @ 2021-10-08 11:03 UTC (permalink / raw)
To: buildroot; +Cc: José Pekkarinen
The following patch will add a recipe to
install opensc in final images.
Signed-off-by: José Pekkarinen <jose.pekkarinen@unikie.com>
---
package/opensc/Config.in | 7 +++++++
package/opensc/opensc.mk | 15 +++++++++++++++
2 files changed, 22 insertions(+)
create mode 100644 package/opensc/Config.in
create mode 100644 package/opensc/opensc.mk
diff --git a/package/opensc/Config.in b/package/opensc/Config.in
new file mode 100644
index 0000000000..abd26a9b08
--- /dev/null
+++ b/package/opensc/Config.in
@@ -0,0 +1,7 @@
+config BR2_PACKAGE_OPENSC
+ bool "opensc"
+ depends on BR2_PACKAGE_LIBOPENSSL && BR2_PACKAGE_PCSC_LITE
+ help
+ OpenSC provides a set of libraries and utilities to work with smart cards.
+
+ https://github.com/OpenSC/OpenSC.git
diff --git a/package/opensc/opensc.mk b/package/opensc/opensc.mk
new file mode 100644
index 0000000000..7741dac2a5
--- /dev/null
+++ b/package/opensc/opensc.mk
@@ -0,0 +1,15 @@
+################################################################################
+#
+# opensc
+#
+################################################################################
+
+OPENSC_VERSION = 0.22.0
+OPENSC_SITE = $(call github,OpenSC,OpenSC,$(OPENSC_VERSION))
+OPENSC_LICENSE = GPL-2
+OPENSC_LICENSE_FILES = LICENSE
+OPENSC_DEPENDENCIES = openssl pcsc-lite
+OPENSC_AUTORECONF = YES
+OPENSC_INSTALL_TARGET = YES
+
+$(eval $(autotools-package))
--
2.25.1
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [Buildroot] [PATCH] package/opensc: add package
2021-10-08 11:03 [Buildroot] [PATCH] package/opensc: add package José Pekkarinen
@ 2021-10-17 16:18 ` Arnout Vandecappelle
2021-10-20 12:10 ` José Pekkarinen
0 siblings, 1 reply; 4+ messages in thread
From: Arnout Vandecappelle @ 2021-10-17 16:18 UTC (permalink / raw)
To: José Pekkarinen, buildroot
Hi José,
Same comments on this patch as what Gilles gave on the softhsm2 one.
On 08/10/2021 13:03, José Pekkarinen wrote:
> The following patch will add a recipe to
> install opensc in final images.
>
> Signed-off-by: José Pekkarinen <jose.pekkarinen@unikie.com>
> ---
> package/opensc/Config.in | 7 +++++++
> package/opensc/opensc.mk | 15 +++++++++++++++
You need to add it to package/Config.in, you need to add a hash file, and
preferably also add yourself to DEVELOPERS for this package.
It's also convenient if you put the two packages together in a series, because
the DEVELOPERS and package/Config.in are likely to cause conflicts.
> 2 files changed, 22 insertions(+)
> create mode 100644 package/opensc/Config.in
> create mode 100644 package/opensc/opensc.mk
>
> diff --git a/package/opensc/Config.in b/package/opensc/Config.in
> new file mode 100644
> index 0000000000..abd26a9b08
> --- /dev/null
> +++ b/package/opensc/Config.in
> @@ -0,0 +1,7 @@
> +config BR2_PACKAGE_OPENSC
> + bool "opensc"
> + depends on BR2_PACKAGE_LIBOPENSSL && BR2_PACKAGE_PCSC_LITE
> + help
> + OpenSC provides a set of libraries and utilities to work with smart cards.
Indentation + wrapping. Please use utils/check-package to verify.
> +
> + https://github.com/OpenSC/OpenSC.git
The URL shouldn't have a .git part. That said, a better location is
https://github.com/OpenSC/OpenSC/wiki
> diff --git a/package/opensc/opensc.mk b/package/opensc/opensc.mk
> new file mode 100644
> index 0000000000..7741dac2a5
> --- /dev/null
> +++ b/package/opensc/opensc.mk
> @@ -0,0 +1,15 @@
> +################################################################################
> +#
> +# opensc
> +#
> +################################################################################
> +
> +OPENSC_VERSION = 0.22.0
> +OPENSC_SITE = $(call github,OpenSC,OpenSC,$(OPENSC_VERSION))
There's an uploaded tarball at
https://github.com/OpenSC/OpenSC/releases/download/0.22.0/opensc-0.22.0.tar.gz
> +OPENSC_LICENSE = GPL-2
I haven't checked in detail, but it seems to be LGPL-2.1+
> +OPENSC_LICENSE_FILES = LICENSE
This file doesn't even exist.
> +OPENSC_DEPENDENCIES = openssl pcsc-lite
> +OPENSC_AUTORECONF = YES
You need to add a comment why this is needed. It probably isn't with the
uploaded tarball.
> +OPENSC_INSTALL_TARGET = YES
This is unnecessary (default). _INSTALL_STAGING, on the other hand, *is*
necessary.
> +
> +$(eval $(autotools-package))
>
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Buildroot] [PATCH] package/opensc: add package
2021-10-17 16:18 ` Arnout Vandecappelle
@ 2021-10-20 12:10 ` José Pekkarinen
2021-10-20 12:34 ` Arnout Vandecappelle
0 siblings, 1 reply; 4+ messages in thread
From: José Pekkarinen @ 2021-10-20 12:10 UTC (permalink / raw)
To: Arnout Vandecappelle; +Cc: buildroot
[-- Attachment #1.1: Type: text/plain, Size: 3937 bytes --]
On Sun, Oct 17, 2021 at 7:18 PM Arnout Vandecappelle <arnout@mind.be> wrote:
> Hi José,
>
> Same comments on this patch as what Gilles gave on the softhsm2 one.
>
> On 08/10/2021 13:03, José Pekkarinen wrote:
> > The following patch will add a recipe to
> > install opensc in final images.
> >
> > Signed-off-by: José Pekkarinen <jose.pekkarinen@unikie.com>
> > ---
> > package/opensc/Config.in | 7 +++++++
> > package/opensc/opensc.mk | 15 +++++++++++++++
>
> You need to add it to package/Config.in, you need to add a hash file,
> and
> preferably also add yourself to DEVELOPERS for this package.
>
> It's also convenient if you put the two packages together in a series,
> because
> the DEVELOPERS and package/Config.in are likely to cause conflicts.
>
> > 2 files changed, 22 insertions(+)
> > create mode 100644 package/opensc/Config.in
> > create mode 100644 package/opensc/opensc.mk
> >
> > diff --git a/package/opensc/Config.in b/package/opensc/Config.in
> > new file mode 100644
> > index 0000000000..abd26a9b08
> > --- /dev/null
> > +++ b/package/opensc/Config.in
> > @@ -0,0 +1,7 @@
> > +config BR2_PACKAGE_OPENSC
> > + bool "opensc"
> > + depends on BR2_PACKAGE_LIBOPENSSL && BR2_PACKAGE_PCSC_LITE
> > + help
> > + OpenSC provides a set of libraries and utilities to work
> with smart cards.
>
> Indentation + wrapping. Please use utils/check-package to verify.
>
> > +
> > + https://github.com/OpenSC/OpenSC.git
>
> The URL shouldn't have a .git part. That said, a better location is
> https://github.com/OpenSC/OpenSC/wiki
>
>
> > diff --git a/package/opensc/opensc.mk b/package/opensc/opensc.mk
> > new file mode 100644
> > index 0000000000..7741dac2a5
> > --- /dev/null
> > +++ b/package/opensc/opensc.mk
> > @@ -0,0 +1,15 @@
> >
> +################################################################################
> > +#
> > +# opensc
> > +#
> >
> +################################################################################
> > +
> > +OPENSC_VERSION = 0.22.0
> > +OPENSC_SITE = $(call github,OpenSC,OpenSC,$(OPENSC_VERSION))
>
> There's an uploaded tarball at
>
> https://github.com/OpenSC/OpenSC/releases/download/0.22.0/opensc-0.22.0.tar.gz
>
> > +OPENSC_LICENSE = GPL-2
>
> I haven't checked in detail, but it seems to be LGPL-2.1+
>
> > +OPENSC_LICENSE_FILES = LICENSE
>
> This file doesn't even exist.
>
> > +OPENSC_DEPENDENCIES = openssl pcsc-lite
> > +OPENSC_AUTORECONF = YES
>
> You need to add a comment why this is needed. It probably isn't with the
> uploaded tarball.
>
> > +OPENSC_INSTALL_TARGET = YES
>
> This is unnecessary (default). _INSTALL_STAGING, on the other hand, *is*
> necessary.
>
> > +
> > +$(eval $(autotools-package))
> >
>
Hi,
Thanks for the help and guidance, while reading the
v2 of the patch I find the following warning I don't quite understand,
and I don't find any relevant docs over the net, would you mind to
elaborate what could it mean the following warning from check-package:
$ ./utils/check-package package/opensc/*
package/opensc/opensc.mk:8: remove default value of _SOURCE variable (
http://nightly.buildroot.org/#generic-package-reference)
25 lines processed
1 warnings generated
while the package looks like this:
$ cat package/opensc/opensc.mk
################################################################################
#
# opensc
#
################################################################################
OPENSC_VERSION = 0.22.0
OPENSC_SOURCE = opensc-$(OPENSC_VERSION).tar.gz
OPENSC_SITE =
https://github.com/OpenSC/OpenSC/releases/download/$(OPENSC_VERSION)/
OPENSC_LICENSE = LGPL-2.1+
OPENSC_LICENSE_FILES = COPYING
OPENSC_DEPENDENCIES = openssl pcsc-lite
OPENSC_INSTALL_STAGING = YES
$(eval $(autotools-package))
Thanks!
José.
[-- Attachment #1.2: Type: text/html, Size: 6354 bytes --]
[-- Attachment #2: Type: text/plain, Size: 150 bytes --]
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Buildroot] [PATCH] package/opensc: add package
2021-10-20 12:10 ` José Pekkarinen
@ 2021-10-20 12:34 ` Arnout Vandecappelle
0 siblings, 0 replies; 4+ messages in thread
From: Arnout Vandecappelle @ 2021-10-20 12:34 UTC (permalink / raw)
To: José Pekkarinen; +Cc: buildroot
On 20/10/2021 14:10, José Pekkarinen wrote:
>
>
> On Sun, Oct 17, 2021 at 7:18 PM Arnout Vandecappelle <arnout@mind.be
> <mailto:arnout@mind.be>> wrote:
>
> Hi José,
>
> Same comments on this patch as what Gilles gave on the softhsm2 one.
>
> On 08/10/2021 13:03, José Pekkarinen wrote:
> > The following patch will add a recipe to
> > install opensc in final images.
> >
> > Signed-off-by: José Pekkarinen <jose.pekkarinen@unikie.com
> <mailto:jose.pekkarinen@unikie.com>>
> > ---
> > package/opensc/Config.in | 7 +++++++
> > package/opensc/opensc.mk <http://opensc.mk> | 15 +++++++++++++++
>
> You need to add it to package/Config.in, you need to add a hash file, and
> preferably also add yourself to DEVELOPERS for this package.
>
> It's also convenient if you put the two packages together in a series,
> because
> the DEVELOPERS and package/Config.in are likely to cause conflicts.
>
> > 2 files changed, 22 insertions(+)
> > create mode 100644 package/opensc/Config.in
> > create mode 100644 package/opensc/opensc.mk <http://opensc.mk>
> >
> > diff --git a/package/opensc/Config.in b/package/opensc/Config.in
> > new file mode 100644
> > index 0000000000..abd26a9b08
> > --- /dev/null
> > +++ b/package/opensc/Config.in
> > @@ -0,0 +1,7 @@
> > +config BR2_PACKAGE_OPENSC
> > + bool "opensc"
> > + depends on BR2_PACKAGE_LIBOPENSSL && BR2_PACKAGE_PCSC_LITE
> > + help
> > + OpenSC provides a set of libraries and utilities to work
> with smart cards.
>
> Indentation + wrapping. Please use utils/check-package to verify.
>
> > +
> > + https://github.com/OpenSC/OpenSC.git <https://github.com/OpenSC/OpenSC.git>
>
> The URL shouldn't have a .git part. That said, a better location is
> https://github.com/OpenSC/OpenSC/wiki <https://github.com/OpenSC/OpenSC/wiki>
>
>
> > diff --git a/package/opensc/opensc.mk <http://opensc.mk>
> b/package/opensc/opensc.mk <http://opensc.mk>
> > new file mode 100644
> > index 0000000000..7741dac2a5
> > --- /dev/null
> > +++ b/package/opensc/opensc.mk <http://opensc.mk>
> > @@ -0,0 +1,15 @@
> >
> +################################################################################
> > +#
> > +# opensc
> > +#
> >
> +################################################################################
> > +
> > +OPENSC_VERSION = 0.22.0
> > +OPENSC_SITE = $(call github,OpenSC,OpenSC,$(OPENSC_VERSION))
>
> There's an uploaded tarball at
> https://github.com/OpenSC/OpenSC/releases/download/0.22.0/opensc-0.22.0.tar.gz
> <https://github.com/OpenSC/OpenSC/releases/download/0.22.0/opensc-0.22.0.tar.gz>
>
> > +OPENSC_LICENSE = GPL-2
>
> I haven't checked in detail, but it seems to be LGPL-2.1+
>
> > +OPENSC_LICENSE_FILES = LICENSE
>
> This file doesn't even exist.
>
> > +OPENSC_DEPENDENCIES = openssl pcsc-lite
> > +OPENSC_AUTORECONF = YES
>
> You need to add a comment why this is needed. It probably isn't with the
> uploaded tarball.
>
> > +OPENSC_INSTALL_TARGET = YES
>
> This is unnecessary (default). _INSTALL_STAGING, on the other hand, *is*
> necessary.
>
> > +
> > +$(eval $(autotools-package))
> >
>
>
> Hi,
>
> Thanks for the help and guidance, while reading the
>
> v2 of the patch I find the following warning I don't quite understand,
> and I don't find any relevant docs over the net, would you mind to
> elaborate what could it mean the following warning from check-package:
>
> $ ./utils/check-package package/opensc/*
> package/opensc/opensc.mk:8 <http://opensc.mk:8>: remove default value of _SOURCE
> variable (http://nightly.buildroot.org/#generic-package-reference
> <http://nightly.buildroot.org/#generic-package-reference>)
> 25 lines processed
> 1 warnings generated
>
> while the package looks like this:
>
> $ cat package/opensc/opensc.mk <http://opensc.mk>
> ################################################################################
> #
> # opensc
> #
> ################################################################################
>
> OPENSC_VERSION = 0.22.0
> OPENSC_SOURCE = opensc-$(OPENSC_VERSION).tar.gz
If you don't set OPENSC_SOURCE at all, then it will automatically get this
value. check-package warns that you're doing an unnecessary setting here.
Regards,
Arnout
> OPENSC_SITE =
> https://github.com/OpenSC/OpenSC/releases/download/$(OPENSC_VERSION)/
> <https://github.com/OpenSC/OpenSC/releases/download/$(OPENSC_VERSION)/>
> OPENSC_LICENSE = LGPL-2.1+
> OPENSC_LICENSE_FILES = COPYING
> OPENSC_DEPENDENCIES = openssl pcsc-lite
> OPENSC_INSTALL_STAGING = YES
>
> $(eval $(autotools-package))
>
> Thanks!
>
> José.
>
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2021-10-20 12:34 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-10-08 11:03 [Buildroot] [PATCH] package/opensc: add package José Pekkarinen
2021-10-17 16:18 ` Arnout Vandecappelle
2021-10-20 12:10 ` José Pekkarinen
2021-10-20 12:34 ` Arnout Vandecappelle
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.