Re: dwc2 Resume From Suspend Devices Not Working

Re: dwc2 Resume From Suspend Devices Not Working

[Minas Harutyunyan]

Hi Christopher,

On 2/10/2021 7:55 PM, Christopher Morgan wrote:
> I was hoping to see if I could get some input on a potential bug.  When 
> I resume from suspend devices attached to USB no longer function.  The 
> machine I am testing in question is an Odroid Go Advance running on the 
> Rockchip RK3326 (essentially a Rockchip PX30).
> 

Could you please force setting 'power_down' variable to 0 and test again.
In function dwc2_set_param_power_down() (file: params.c), replace
	hsotg->params.power_down = val;
to
	hsotg->params.power_down = 0;


Thanks,
Minas

Re: dwc2 Resume From Suspend Devices Not Working

[Minas Harutyunyan]

Hi,

On 2/11/2021 7:48 PM, Christopher Morgan wrote:
> Unfortunately that appears to have made no difference in the issue.  Do you need me to send you the kernel logs/registers/etc after this change as well?

Please provide logs/registers/debugfs's

Thanks
Minas

> 
> Thank you.
> 
> -----Original Message-----
> From: Minas Harutyunyan <Minas.Harutyunyan@synopsys.com>
> Sent: Thursday, February 11, 2021 5:15 AM
> To: Christopher Morgan <macromorgan@hotmail.com>; linux-usb@vger.kernel.org
> Subject: Re: dwc2 Resume From Suspend Devices Not Working
> 
> Hi Christopher,
> 
> On 2/10/2021 7:55 PM, Christopher Morgan wrote:
>> I was hoping to see if I could get some input on a potential bug.
>> When I resume from suspend devices attached to USB no longer function.
>> The machine I am testing in question is an Odroid Go Advance running
>> on the Rockchip RK3326 (essentially a Rockchip PX30).
>>
> 
> Could you please force setting 'power_down' variable to 0 and test again.
> In function dwc2_set_param_power_down() (file: params.c), replace
> 	hsotg->params.power_down = val;
> to
> 	hsotg->params.power_down = 0;
> 
> 
> Thanks,
> Minas
> 
> 

Re: dwc2 Resume From Suspend Devices Not Working

[Minas Harutyunyan]

We was able to repoduce issue on our side and prepare fix. Currently it 
passing internal review and testing. Soon Artur will submit it to lkml.

Thanks,
Minas


On 2/18/2021 9:46 PM, Christopher Morgan wrote:
> I found this patch (a hack) and applied it to my local branch.  For 
> whatever reason suspend/resume works now.  I don’t fully understand why 
> though, but it looks like maybe it disconnects the device before 
> suspend/reconnects the device after suspend?
> 
> Original Patch Found: dwc2 suspend fix · valadaa48/linux@8548753 
> (github.com) 
> <https://urldefense.com/v3/__https://github.com/valadaa48/linux/commit/854875353930acbeed806b289e3933d38f436807__;!!A4F2R9G_pg!KPXHhAI2GMs2_WpEWgkxBU-ZtW0qIckCagmXZwKSLxOuaSIar5CQtht4Z7i4F3rvvlKw7iUY$>
> 
> My application against 5.10: Fix suspend issues for USB. · 
> macromorgan/odroid_go_advance_linux_android@f780117 (github.com) 
> <https://urldefense.com/v3/__https://github.com/macromorgan/odroid_go_advance_linux_android/commit/f7801176f76bdb140b24605c9f19419a31c9d348__;!!A4F2R9G_pg!KPXHhAI2GMs2_WpEWgkxBU-ZtW0qIckCagmXZwKSLxOuaSIar5CQtht4Z7i4F3rvvhjCqmi5$>
> 
> *From: *Christopher Morgan <mailto:macromorgan@hotmail.com>
> *Sent: *Thursday, February 11, 2021 3:31 PM
> *To: *Minas Harutyunyan <mailto:Minas.Harutyunyan@synopsys.com>; 
> linux-usb@vger.kernel.org <mailto:linux-usb@vger.kernel.org>
> *Subject: *RE: dwc2 Resume From Suspend Devices Not Working
>