* [virtio-dev] [PATCH] virtio-mmio: Rename remaining QueueAvail/Used references
@ 2019-10-06 16:41 Jan Kiszka
2019-10-14 8:45 ` Stefan Hajnoczi
0 siblings, 1 reply; 4+ messages in thread
From: Jan Kiszka @ 2019-10-06 16:41 UTC (permalink / raw)
To: virtio-dev
From: Jan Kiszka <jan.kiszka@siemens.com>
These have been changed in ae98c6bc21bc. Convert the rest.
Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
---
content.tex | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/content.tex b/content.tex
index 679391e..2325236 100644
--- a/content.tex
+++ b/content.tex
@@ -1645,8 +1645,8 @@ \subsection{MMIO Device Register Layout}\label{sec:Virtio Transport Options / Vi
\mmioreg{QueueSel}{Virtual queue index}{0x030}{W}{%
Writing to this register selects the virtual queue that the
following operations on \field{QueueNumMax}, \field{QueueNum}, \field{QueueReady},
- \field{QueueDescLow}, \field{QueueDescHigh}, \field{QueueAvailLow}, \field{QueueAvailHigh},
- \field{QueueUsedLow} and \field{QueueUsedHigh} apply to. The index
+ \field{QueueDescLow}, \field{QueueDescHigh}, \field{QueueDriverlLow}, \field{QueueDriverHigh},
+ \field{QueueDeviceLow} and \field{QueueDeviceHigh} apply to. The index
number of the first queue is zero (0x0).
}
\hline
@@ -1724,14 +1724,14 @@ \subsection{MMIO Device Register Layout}\label{sec:Virtio Transport Options / Vi
\hline
\mmiodreg{QueueDriverLow}{QueueDriverHigh}{Virtual queue's Driver Area 64 bit long physical address}{0x090}{0x094}{W}{%
Writing to these two registers (lower 32 bits of the address
- to \field{QueueAvailLow}, higher 32 bits to \field{QueueAvailHigh}) notifies
+ to \field{QueueDriverLow}, higher 32 bits to \field{QueueDriverHigh}) notifies
the device about location of the Driver Area of the queue
selected by writing to \field{QueueSel}.
}
\hline
\mmiodreg{QueueDeviceLow}{QueueDeviceHigh}{Virtual queue's Device Area 64 bit long physical address}{0x0a0}{0x0a4}{W}{%
Writing to these two registers (lower 32 bits of the address
- to \field{QueueUsedLow}, higher 32 bits to \field{QueueUsedHigh}) notifies
+ to \field{QueueDeviceLow}, higher 32 bits to \field{QueueDeviceHigh}) notifies
the device about location of the Device Area of the queue
selected by writing to \field{QueueSel}.
}
@@ -1829,7 +1829,7 @@ \subsection{MMIO Device Register Layout}\label{sec:Virtio Transport Options / Vi
When \field{QueueReady} is not zero, the driver MUST NOT access
\field{QueueNum}, \field{QueueDescLow}, \field{QueueDescHigh},
-\field{QueueAvailLow}, \field{QueueAvailHigh}, \field{QueueUsedLow}, \field{QueueUsedHigh}.
+\field{QueueDriverLow}, \field{QueueDriverHigh}, \field{QueueDeviceLow}, \field{QueueDeviceHigh}.
To stop using the queue the driver MUST write zero (0x0) to this
\field{QueueReady} and MUST read the value back to ensure
--
2.16.4
---------------------------------------------------------------------
To unsubscribe, e-mail: virtio-dev-unsubscribe@lists.oasis-open.org
For additional commands, e-mail: virtio-dev-help@lists.oasis-open.org
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [virtio-dev] [PATCH] virtio-mmio: Rename remaining QueueAvail/Used references
2019-10-06 16:41 [virtio-dev] [PATCH] virtio-mmio: Rename remaining QueueAvail/Used references Jan Kiszka
@ 2019-10-14 8:45 ` Stefan Hajnoczi
2019-10-14 8:49 ` Jan Kiszka
0 siblings, 1 reply; 4+ messages in thread
From: Stefan Hajnoczi @ 2019-10-14 8:45 UTC (permalink / raw)
To: Jan Kiszka; +Cc: virtio-dev
[-- Attachment #1: Type: text/plain, Size: 487 bytes --]
On Sun, Oct 06, 2019 at 06:41:32PM +0200, Jan Kiszka wrote:
> From: Jan Kiszka <jan.kiszka@siemens.com>
>
> These have been changed in ae98c6bc21bc. Convert the rest.
>
> Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
> ---
> content.tex | 10 +++++-----
> 1 file changed, 5 insertions(+), 5 deletions(-)
Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
Please create a GitHub Issue so that a vote can be started:
https://github.com/oasis-tcs/virtio-spec/issues
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [virtio-dev] [PATCH] virtio-mmio: Rename remaining QueueAvail/Used references
2019-10-14 8:45 ` Stefan Hajnoczi
@ 2019-10-14 8:49 ` Jan Kiszka
2019-10-27 11:44 ` Michael S. Tsirkin
0 siblings, 1 reply; 4+ messages in thread
From: Jan Kiszka @ 2019-10-14 8:49 UTC (permalink / raw)
To: Stefan Hajnoczi; +Cc: virtio-dev
On 14.10.19 10:45, Stefan Hajnoczi wrote:
> On Sun, Oct 06, 2019 at 06:41:32PM +0200, Jan Kiszka wrote:
>> From: Jan Kiszka <jan.kiszka@siemens.com>
>>
>> These have been changed in ae98c6bc21bc. Convert the rest.
>>
>> Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
>> ---
>> content.tex | 10 +++++-----
>> 1 file changed, 5 insertions(+), 5 deletions(-)
>
> Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
>
> Please create a GitHub Issue so that a vote can be started:
> https://github.com/oasis-tcs/virtio-spec/issues
>
Done: https://github.com/oasis-tcs/virtio-spec/issues/52
Jan
--
Siemens AG, Corporate Technology, CT RDA IOT SES-DE
Corporate Competence Center Embedded Linux
---------------------------------------------------------------------
To unsubscribe, e-mail: virtio-dev-unsubscribe@lists.oasis-open.org
For additional commands, e-mail: virtio-dev-help@lists.oasis-open.org
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [virtio-dev] [PATCH] virtio-mmio: Rename remaining QueueAvail/Used references
2019-10-14 8:49 ` Jan Kiszka
@ 2019-10-27 11:44 ` Michael S. Tsirkin
0 siblings, 0 replies; 4+ messages in thread
From: Michael S. Tsirkin @ 2019-10-27 11:44 UTC (permalink / raw)
To: Jan Kiszka; +Cc: Stefan Hajnoczi, virtio-dev
On Mon, Oct 14, 2019 at 10:49:53AM +0200, Jan Kiszka wrote:
> On 14.10.19 10:45, Stefan Hajnoczi wrote:
> > On Sun, Oct 06, 2019 at 06:41:32PM +0200, Jan Kiszka wrote:
> >> From: Jan Kiszka <jan.kiszka@siemens.com>
> >>
> >> These have been changed in ae98c6bc21bc. Convert the rest.
> >>
> >> Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
> >> ---
> >> content.tex | 10 +++++-----
> >> 1 file changed, 5 insertions(+), 5 deletions(-)
> >
> > Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
> >
> > Please create a GitHub Issue so that a vote can be started:
> > https://github.com/oasis-tcs/virtio-spec/issues
> >
>
> Done: https://github.com/oasis-tcs/virtio-spec/issues/52
>
> Jan
Ballot started. For the future, pls take a look at "Use of github
issues" in
https://github.com/oasis-tcs/virtio-spec/README.md
Thanks!
> --
> Siemens AG, Corporate Technology, CT RDA IOT SES-DE
> Corporate Competence Center Embedded Linux
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: virtio-dev-unsubscribe@lists.oasis-open.org
> For additional commands, e-mail: virtio-dev-help@lists.oasis-open.org
---------------------------------------------------------------------
To unsubscribe, e-mail: virtio-dev-unsubscribe@lists.oasis-open.org
For additional commands, e-mail: virtio-dev-help@lists.oasis-open.org
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2019-10-27 11:44 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-10-06 16:41 [virtio-dev] [PATCH] virtio-mmio: Rename remaining QueueAvail/Used references Jan Kiszka
2019-10-14 8:45 ` Stefan Hajnoczi
2019-10-14 8:49 ` Jan Kiszka
2019-10-27 11:44 ` Michael S. Tsirkin
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.