* [Buildroot] [PATCH 1/1] package/busybox: add systemd service for telnetd @ 2021-08-26 21:02 Sam Voss via buildroot 2021-08-26 22:01 ` Arnout Vandecappelle 2021-08-27 21:28 ` [Buildroot] " Yann E. MORIN 0 siblings, 2 replies; 5+ messages in thread From: Sam Voss via buildroot @ 2021-08-26 21:02 UTC (permalink / raw) To: buildroot; +Cc: Sam Voss Signed-off-by: Sam Voss <sam.voss@collins.com> --- package/busybox/busybox.mk | 7 +++++++ package/busybox/telnetd.service | 11 +++++++++++ 2 files changed, 18 insertions(+) create mode 100644 package/busybox/telnetd.service diff --git a/package/busybox/busybox.mk b/package/busybox/busybox.mk index cfc06b0d78..fb427faf1c 100644 --- a/package/busybox/busybox.mk +++ b/package/busybox/busybox.mk @@ -378,6 +378,13 @@ define BUSYBOX_INSTALL_TARGET_CMDS $(BUSYBOX_INSTALL_MDEV_CONF) endef +define BUSYBOX_INSTALL_INIT_SYSTEMD + if grep -q CONFIG_FEATURE_TELNETD_STANDALONE=y $(@D)/.config; then \ + $(INSTALL) -D -m 0644 package/busybox/telnetd.service \ + $(TARGET_DIR)/usr/lib/systemd/system/telnetd.service ; \ + fi +endef + # Install the sysvinit scripts, for the moment, but not those that already # have a corresponding one in openrc. define BUSYBOX_INSTALL_INIT_OPENRC diff --git a/package/busybox/telnetd.service b/package/busybox/telnetd.service new file mode 100644 index 0000000000..3c1fa457b1 --- /dev/null +++ b/package/busybox/telnetd.service @@ -0,0 +1,11 @@ +[Unit] +Description=Telnetd Service +After=network.target + +[Service] +# busybox telnet doesn't support pidfile, so run in foreground +Type=simple +ExecStart=/usr/sbin/telnetd -F + +[Install] +WantedBy=multi-user.target -- 2.17.1 _______________________________________________ buildroot mailing list buildroot@busybox.net http://lists.busybox.net/mailman/listinfo/buildroot ^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [Buildroot] [PATCH 1/1] package/busybox: add systemd service for telnetd 2021-08-26 21:02 [Buildroot] [PATCH 1/1] package/busybox: add systemd service for telnetd Sam Voss via buildroot @ 2021-08-26 22:01 ` Arnout Vandecappelle 2021-08-27 15:50 ` [Buildroot] [External] " Voss, Samuel M Collins via buildroot 2021-08-27 21:28 ` [Buildroot] " Yann E. MORIN 1 sibling, 1 reply; 5+ messages in thread From: Arnout Vandecappelle @ 2021-08-26 22:01 UTC (permalink / raw) To: Sam Voss, buildroot On 26/08/2021 23:02, Sam Voss via buildroot wrote: > Signed-off-by: Sam Voss <sam.voss@collins.com> > --- > package/busybox/busybox.mk | 7 +++++++ > package/busybox/telnetd.service | 11 +++++++++++ > 2 files changed, 18 insertions(+) > create mode 100644 package/busybox/telnetd.service > > diff --git a/package/busybox/busybox.mk b/package/busybox/busybox.mk > index cfc06b0d78..fb427faf1c 100644 > --- a/package/busybox/busybox.mk > +++ b/package/busybox/busybox.mk > @@ -378,6 +378,13 @@ define BUSYBOX_INSTALL_TARGET_CMDS > $(BUSYBOX_INSTALL_MDEV_CONF) > endef > > +define BUSYBOX_INSTALL_INIT_SYSTEMD > + if grep -q CONFIG_FEATURE_TELNETD_STANDALONE=y $(@D)/.config; then \ > + $(INSTALL) -D -m 0644 package/busybox/telnetd.service \ > + $(TARGET_DIR)/usr/lib/systemd/system/telnetd.service ; \ > + fi > +endef > + > # Install the sysvinit scripts, for the moment, but not those that already > # have a corresponding one in openrc. > define BUSYBOX_INSTALL_INIT_OPENRC > diff --git a/package/busybox/telnetd.service b/package/busybox/telnetd.service > new file mode 100644 > index 0000000000..3c1fa457b1 > --- /dev/null > +++ b/package/busybox/telnetd.service > @@ -0,0 +1,11 @@ > +[Unit] > +Description=Telnetd Service > +After=network.target > + > +[Service] > +# busybox telnet doesn't support pidfile, so run in foreground AFAIU Type=simple is anyway the preferred type for services without specific systemd support, so I don't think this comment is very useful... Regardless: Reviewed-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be> Regards, Arnout > +Type=simple > +ExecStart=/usr/sbin/telnetd -F > + > +[Install] > +WantedBy=multi-user.target > _______________________________________________ buildroot mailing list buildroot@busybox.net http://lists.busybox.net/mailman/listinfo/buildroot ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [Buildroot] [External] Re: [PATCH 1/1] package/busybox: add systemd service for telnetd 2021-08-26 22:01 ` Arnout Vandecappelle @ 2021-08-27 15:50 ` Voss, Samuel M Collins via buildroot 2021-08-27 16:30 ` Arnout Vandecappelle 0 siblings, 1 reply; 5+ messages in thread From: Voss, Samuel M Collins via buildroot @ 2021-08-27 15:50 UTC (permalink / raw) To: Arnout Vandecappelle, buildroot Arnout, > -----Original Message----- > From: Arnout Vandecappelle <arnout@mind.be> > Sent: Thursday, August 26, 2021 5:01 PM > To: Voss, Samuel M Collins <sam.voss@collins.com>; > buildroot@buildroot.org > Subject: [External] Re: [Buildroot] [PATCH 1/1] package/busybox: add > systemd service for telnetd > > > > On 26/08/2021 23:02, Sam Voss via buildroot wrote: > > Signed-off-by: Sam Voss <sam.voss@collins.com> > > --- > > package/busybox/busybox.mk | 7 +++++++ > > package/busybox/telnetd.service | 11 +++++++++++ > > 2 files changed, 18 insertions(+) > > create mode 100644 package/busybox/telnetd.service > > > > diff --git a/package/busybox/busybox.mk > b/package/busybox/busybox.mk > > index cfc06b0d78..fb427faf1c 100644 > > --- a/package/busybox/busybox.mk > > +++ b/package/busybox/busybox.mk > > @@ -378,6 +378,13 @@ define BUSYBOX_INSTALL_TARGET_CMDS > > $(BUSYBOX_INSTALL_MDEV_CONF) > > endef > > > > +define BUSYBOX_INSTALL_INIT_SYSTEMD > > + if grep -q CONFIG_FEATURE_TELNETD_STANDALONE=y > $(@D)/.config; then \ > > + $(INSTALL) -D -m 0644 package/busybox/telnetd.service \ > > + > $(TARGET_DIR)/usr/lib/systemd/system/telnetd.service ; \ > > + fi > > +endef > > + > > # Install the sysvinit scripts, for the moment, but not those that > > already # have a corresponding one in openrc. > > define BUSYBOX_INSTALL_INIT_OPENRC > > diff --git a/package/busybox/telnetd.service > > b/package/busybox/telnetd.service new file mode 100644 index > > 0000000000..3c1fa457b1 > > --- /dev/null > > +++ b/package/busybox/telnetd.service > > @@ -0,0 +1,11 @@ > > +[Unit] > > +Description=Telnetd Service > > +After=network.target > > + > > +[Service] > > +# busybox telnet doesn't support pidfile, so run in foreground > > AFAIU Type=simple is anyway the preferred type for services without > specific systemd support, so I don't think this comment is very useful... Fair enough, I didn't know that was the specific guidance, so I'm okay with dropping that comment when applying. Thanks for letting me know, Sam > > Regardless: > > Reviewed-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be> > > Regards, > Arnout > > > +Type=simple > > +ExecStart=/usr/sbin/telnetd -F > > + > > +[Install] > > +WantedBy=multi-user.target > > _______________________________________________ buildroot mailing list buildroot@busybox.net http://lists.busybox.net/mailman/listinfo/buildroot ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [Buildroot] [External] Re: [PATCH 1/1] package/busybox: add systemd service for telnetd 2021-08-27 15:50 ` [Buildroot] [External] " Voss, Samuel M Collins via buildroot @ 2021-08-27 16:30 ` Arnout Vandecappelle 0 siblings, 0 replies; 5+ messages in thread From: Arnout Vandecappelle @ 2021-08-27 16:30 UTC (permalink / raw) To: Voss, Samuel M Collins, buildroot On 27/08/2021 17:50, Voss, Samuel M Collins wrote: > Arnout, > >> -----Original Message----- >> From: Arnout Vandecappelle <arnout@mind.be> >> Sent: Thursday, August 26, 2021 5:01 PM >> To: Voss, Samuel M Collins <sam.voss@collins.com>; >> buildroot@buildroot.org >> Subject: [External] Re: [Buildroot] [PATCH 1/1] package/busybox: add >> systemd service for telnetd >> >> >> >> On 26/08/2021 23:02, Sam Voss via buildroot wrote: >>> Signed-off-by: Sam Voss <sam.voss@collins.com> >>> --- >>> package/busybox/busybox.mk | 7 +++++++ >>> package/busybox/telnetd.service | 11 +++++++++++ >>> 2 files changed, 18 insertions(+) >>> create mode 100644 package/busybox/telnetd.service >>> >>> diff --git a/package/busybox/busybox.mk >> b/package/busybox/busybox.mk >>> index cfc06b0d78..fb427faf1c 100644 >>> --- a/package/busybox/busybox.mk >>> +++ b/package/busybox/busybox.mk >>> @@ -378,6 +378,13 @@ define BUSYBOX_INSTALL_TARGET_CMDS >>> $(BUSYBOX_INSTALL_MDEV_CONF) >>> endef >>> >>> +define BUSYBOX_INSTALL_INIT_SYSTEMD >>> + if grep -q CONFIG_FEATURE_TELNETD_STANDALONE=y >> $(@D)/.config; then \ >>> + $(INSTALL) -D -m 0644 package/busybox/telnetd.service \ >>> + >> $(TARGET_DIR)/usr/lib/systemd/system/telnetd.service ; \ >>> + fi >>> +endef >>> + >>> # Install the sysvinit scripts, for the moment, but not those that >>> already # have a corresponding one in openrc. >>> define BUSYBOX_INSTALL_INIT_OPENRC >>> diff --git a/package/busybox/telnetd.service >>> b/package/busybox/telnetd.service new file mode 100644 index >>> 0000000000..3c1fa457b1 >>> --- /dev/null >>> +++ b/package/busybox/telnetd.service >>> @@ -0,0 +1,11 @@ >>> +[Unit] >>> +Description=Telnetd Service >>> +After=network.target >>> + >>> +[Service] >>> +# busybox telnet doesn't support pidfile, so run in foreground >> >> AFAIU Type=simple is anyway the preferred type for services without >> specific systemd support, so I don't think this comment is very useful... > > Fair enough, I didn't know that was the specific guidance, so I'm okay with dropping that comment when applying. From the systemd.service(5) man page: It is generally recommended to use Type=simple for long-running services whenever possible, as it is the simplest and fastest option. Regards, Arnout > > Thanks for letting me know, > > Sam > >> >> Regardless: >> >> Reviewed-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be> >> >> Regards, >> Arnout >> >>> +Type=simple >>> +ExecStart=/usr/sbin/telnetd -F >>> + >>> +[Install] >>> +WantedBy=multi-user.target >>> _______________________________________________ buildroot mailing list buildroot@busybox.net http://lists.busybox.net/mailman/listinfo/buildroot ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [Buildroot] [PATCH 1/1] package/busybox: add systemd service for telnetd 2021-08-26 21:02 [Buildroot] [PATCH 1/1] package/busybox: add systemd service for telnetd Sam Voss via buildroot 2021-08-26 22:01 ` Arnout Vandecappelle @ 2021-08-27 21:28 ` Yann E. MORIN 1 sibling, 0 replies; 5+ messages in thread From: Yann E. MORIN @ 2021-08-27 21:28 UTC (permalink / raw) To: Sam Voss; +Cc: buildroot Sam, All, On 2021-08-26 16:02 -0500, Sam Voss via buildroot spake thusly: > Signed-off-by: Sam Voss <sam.voss@collins.com> > --- > package/busybox/busybox.mk | 7 +++++++ > package/busybox/telnetd.service | 11 +++++++++++ > 2 files changed, 18 insertions(+) > create mode 100644 package/busybox/telnetd.service > > diff --git a/package/busybox/busybox.mk b/package/busybox/busybox.mk > index cfc06b0d78..fb427faf1c 100644 > --- a/package/busybox/busybox.mk > +++ b/package/busybox/busybox.mk > @@ -378,6 +378,13 @@ define BUSYBOX_INSTALL_TARGET_CMDS > $(BUSYBOX_INSTALL_MDEV_CONF) > endef > > +define BUSYBOX_INSTALL_INIT_SYSTEMD > + if grep -q CONFIG_FEATURE_TELNETD_STANDALONE=y $(@D)/.config; then \ > + $(INSTALL) -D -m 0644 package/busybox/telnetd.service \ > + $(TARGET_DIR)/usr/lib/systemd/system/telnetd.service ; \ > + fi > +endef I've changed that to be handled in a fashion similar to the two other init systems: - added a macro right after BUSYBOX_INSTALL_TELNET_SCRIPT, and similarly named BUSYBOX_INSTALL_TELNET_SERVICE - use thatr macro in the newly introduced BUSYBOX_INSTALL_INIT_SYSTEMD - move BUSYBOX_INSTALL_INIT_SYSTEMD alphabetically in-between openrc and sysv. Applied to next, thanks. Regards, Yann E. MORIN. > # Install the sysvinit scripts, for the moment, but not those that already > # have a corresponding one in openrc. > define BUSYBOX_INSTALL_INIT_OPENRC > diff --git a/package/busybox/telnetd.service b/package/busybox/telnetd.service > new file mode 100644 > index 0000000000..3c1fa457b1 > --- /dev/null > +++ b/package/busybox/telnetd.service > @@ -0,0 +1,11 @@ > +[Unit] > +Description=Telnetd Service > +After=network.target > + > +[Service] > +# busybox telnet doesn't support pidfile, so run in foreground > +Type=simple > +ExecStart=/usr/sbin/telnetd -F > + > +[Install] > +WantedBy=multi-user.target > -- > 2.17.1 > > _______________________________________________ > buildroot mailing list > buildroot@busybox.net > http://lists.busybox.net/mailman/listinfo/buildroot -- .-----------------.--------------------.------------------.--------------------. | Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: | | +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ | | +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no | | http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. | '------------------------------^-------^------------------^--------------------' _______________________________________________ buildroot mailing list buildroot@busybox.net http://lists.busybox.net/mailman/listinfo/buildroot ^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2021-08-27 21:28 UTC | newest] Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2021-08-26 21:02 [Buildroot] [PATCH 1/1] package/busybox: add systemd service for telnetd Sam Voss via buildroot 2021-08-26 22:01 ` Arnout Vandecappelle 2021-08-27 15:50 ` [Buildroot] [External] " Voss, Samuel M Collins via buildroot 2021-08-27 16:30 ` Arnout Vandecappelle 2021-08-27 21:28 ` [Buildroot] " Yann E. MORIN
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.