Re: [PATCH v1 7/7] drm/bridge_connector: drop drm_bridge_connector_en/disable_hpd()

From: Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>
To: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>,
	Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
	Maxime Ripard <mripard@kernel.org>,
	Thomas Zimmermann <tzimmermann@suse.de>,
	David Airlie <airlied@linux.ie>, Daniel Vetter <daniel@ffwll.ch>,
	Laurentiu Palcu <laurentiu.palcu@oss.nxp.com>,
	Lucas Stach <l.stach@pengutronix.de>,
	Philipp Zabel <p.zabel@pengutronix.de>,
	Shawn Guo <shawnguo@kernel.org>,
	Sascha Hauer <s.hauer@pengutronix.de>,
	Pengutronix Kernel Team <kernel@pengutronix.de>,
	Fabio Estevam <festevam@gmail.com>,
	NXP Linux Team <linux-imx@nxp.com>,
	Rob Clark <robdclark@gmail.com>, Sean Paul <sean@poorly.run>,
	Abhinav Kumar <quic_abhinavk@quicinc.com>
Cc: dri-devel@lists.freedesktop.org,
	linux-arm-kernel@lists.infradead.org,
	linux-arm-msm@vger.kernel.org, freedreno@lists.freedesktop.org
Subject: Re: [PATCH v1 7/7] drm/bridge_connector: drop drm_bridge_connector_en/disable_hpd()
Date: Mon, 12 Sep 2022 11:52:49 +0300	[thread overview]
Message-ID: <34103b0a-567c-5315-6dab-c0002e23450a@ideasonboard.com> (raw)
In-Reply-To: <20220429185157.3673633-8-dmitry.baryshkov@linaro.org>

On 29/04/2022 21:51, Dmitry Baryshkov wrote:
> Now as all drivers stopped calling drm_bridge_connector_enable_hpd() and
> drm_bridge_connector_disable_hpd() it is safe to remove them complelely.
> 
> Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
> ---
>   drivers/gpu/drm/drm_bridge_connector.c | 25 -------------------------
>   include/drm/drm_bridge_connector.h     |  2 --
>   2 files changed, 27 deletions(-)
> 
> diff --git a/drivers/gpu/drm/drm_bridge_connector.c b/drivers/gpu/drm/drm_bridge_connector.c
> index 1592da3b9403..d9c1f61b6fb6 100644
> --- a/drivers/gpu/drm/drm_bridge_connector.c
> +++ b/drivers/gpu/drm/drm_bridge_connector.c
> @@ -128,18 +128,6 @@ static void drm_bridge_connector_hpd_cb(void *cb_data,
>   	drm_kms_helper_hotplug_event(dev);
>   }
>   
> -/**
> - * drm_bridge_connector_enable_hpd - Enable hot-plug detection for the connector
> - * @connector: The DRM bridge connector
> - *
> - * This function enables hot-plug detection for the given bridge connector.
> - * This is typically used by display drivers in their resume handler.
> - */
> -void drm_bridge_connector_enable_hpd(struct drm_connector *connector)
> -{
> -}
> -EXPORT_SYMBOL_GPL(drm_bridge_connector_enable_hpd);
> -
>   static void _drm_bridge_connector_enable_hpd(struct drm_connector *connector)

Here (and for _drm_bridge_connector_disable_hpd) you could remove the 
prefix underscore.

  Tomi