All of lore.kernel.org
 help / color / mirror / Atom feed
From: Julien Grall <julien.grall@arm.com>
To: Chris Patterson <cjp256@gmail.com>
Cc: Chris Patterson <pattersonc@ainfosec.com>,
	nd@arm.com, "temkink@ainfosec.com" <temkink@ainfosec.com>,
	Stefano Stabellini <sstabellini@kernel.org>,
	xen-devel@lists.xen.org
Subject: Re: [PATCH 4/6] xen/arm: platforms: Add Tegra platform to support basic IRQ routing
Date: Fri, 7 Jul 2017 17:30:42 +0100	[thread overview]
Message-ID: <3431252a-a367-7e14-4ad1-5e1f963c289f@arm.com> (raw)
In-Reply-To: <CABZSBQdgKPuFvaerjJ=7oTkZDMoieomcA=6S0JdMMAxP8_n34A@mail.gmail.com>

Hi Chris,

On 07/07/17 00:12, Chris Patterson wrote:
>>
>> So why do you want the hardware domain to interact with the ictlr? Could not
>> you hide it completely?
>>
>
> snip
>
>> What would happen if you enable the interrupt here for the guest? Should not
>> you do it when the guest is requesting to enable (see vgic_enable_irqs).
>>
>>
>> Also, how about EOI an interrupt?
>
> We could possibly hide the legacy controller, but that has its own
> challenges. Notably, the LIC allows configuration for forwarding FIQ
> vs IRQ, and setting wake-up sources.

FIQ are not supported for domain. So I am not sure why you would want a 
guest to configure that.

Furthermore, could you explain what is wake-up sources and why a guest 
would need it?

>
> If we accept limitations to those configurations, we could possibly
> hide it entirely (or just for non-Dom0 guests with device
> passthrough?), and then I think we would need platform hooks for
> accomplishing the masking/unmasking/eoi alongside the vgic.  If we
> don't want to limit the configuration options - we would need to
> surface the mediated LIC in the device trees for guests with device
> pass-through.
>
>>
>
> Will incorporate rest of review into next version, thanks!
>

Cheers,

-- 
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel

  reply	other threads:[~2017-07-07 16:30 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-04-06 19:47 [PATCH 0/6] Initial Tegra platform support Chris Patterson
2017-04-06 19:47 ` [PATCH 1/6] xen/arm: platforms: Add earlyprintk and serial support for Tegra boards Chris Patterson
2017-04-13 23:09   ` Stefano Stabellini
2017-04-18  7:49   ` Julien Grall
2017-04-19 20:37     ` Chris Patterson
2017-04-06 19:47 ` [PATCH 2/6] xen/arm: domain_build: Inherit GIC's interrupt-parent from host device tree Chris Patterson
2017-04-18  8:01   ` Julien Grall
2017-04-19 20:09     ` Christopher Patterson
2017-04-06 19:47 ` [PATCH 3/6] xen/arm: Allow platforms to hook IRQ routing Chris Patterson
2017-04-13 23:26   ` Stefano Stabellini
2017-04-06 19:47 ` [PATCH 4/6] xen/arm: platforms: Add Tegra platform to support basic " Chris Patterson
2017-04-13 23:46   ` Stefano Stabellini
2017-04-17 15:03     ` Chris Patterson
2017-04-18  7:58       ` Julien Grall
2017-07-06 22:00         ` Chris Patterson
2017-07-07 16:25           ` Julien Grall
2017-07-07 18:08             ` Chris Patterson
2017-07-26 16:49               ` Julien Grall
2017-04-18  8:26   ` Julien Grall
2017-07-06 23:12     ` Chris Patterson
2017-07-07 16:30       ` Julien Grall [this message]
2017-07-07 18:53         ` Chris Patterson
2017-07-24 19:38           ` Chris Patterson
2017-07-26 16:10             ` Julien Grall
2017-04-06 19:47 ` [PATCH 5/6] xen/arm: Add function to query IRQ 'ownership' Chris Patterson
2017-04-18  8:27   ` Julien Grall
2017-04-06 19:47 ` [PATCH 6/6] xen/arm: platforms/tegra: Ensure the hwdom can only affect its own interrupts Chris Patterson
2017-04-13 23:54   ` Stefano Stabellini
2017-04-18  8:39   ` Julien Grall
2017-07-06 23:13     ` Chris Patterson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3431252a-a367-7e14-4ad1-5e1f963c289f@arm.com \
    --to=julien.grall@arm.com \
    --cc=cjp256@gmail.com \
    --cc=nd@arm.com \
    --cc=pattersonc@ainfosec.com \
    --cc=sstabellini@kernel.org \
    --cc=temkink@ainfosec.com \
    --cc=xen-devel@lists.xen.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.