Re: [PATCH 4/6] xen/arm: platforms: Add Tegra platform to support basic IRQ routing

From: Chris Patterson <cjp256@gmail.com>
To: Stefano Stabellini <sstabellini@kernel.org>
Cc: Julien Grall <julien.grall@arm.com>,
	Chris Patterson <pattersonc@ainfosec.com>,
	"temkink@ainfosec.com" <temkink@ainfosec.com>,
	xen-devel@lists.xen.org
Subject: Re: [PATCH 4/6] xen/arm: platforms: Add Tegra platform to support basic IRQ routing
Date: Mon, 17 Apr 2017 11:03:20 -0400	[thread overview]
Message-ID: <CABZSBQeqYykPkAOeBwqcx4bV3yFKGDXuTD6mCZQHvt7Uo5zhUA@mail.gmail.com> (raw)
In-Reply-To: <alpine.DEB.2.10.1704131634150.2759@sstabellini-ThinkPad-X260>

>> +static const char * const tegra_dt_compat[] __initconst =
>> +{
>> +    "nvidia,tegra120",  /* Tegra K1 */
>
> This is still tegra120 (not tegra124), is that intended? If so, it is
> still missing from arch/arm*/boot/dts. Do you have a pointer?

It was not intended; thank you for catching it. I must have lost that
fixup somewhere along the way...

> Also, do we need both tegra_dt_compat and tegra_interrupt_compat? Can we
> keep only one?

The purpose of tegra_interrupt_compat is to maintain a tegra-specific
whitelist of interrupt controllers we know how to route.  Presumably,
there may be custom boards out there that may have additional
interrupt routing capabilities that this patch set would not support
as-is.  I'm not sure of an appropriate way to maintain that logic and
merge them.  However, I am certainly open to suggestion, if you have
any ideas.

Thanks for the review!
-Chris

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel