From: "Saidi, Ali" <alisaidi@amazon.com>
To: Kees Cook <keescook@chromium.org>, Michal Hocko <mhocko@suse.com>,
Matthew Wilcox <willy@infradead.org>,
Jann Horn <jannh@google.com>
Cc: Dave Hansen <dave.hansen@linux.intel.com>,
"Liguori, Anthony" <aliguori@amazon.com>,
Peter Zijlstra <peterz@infradead.org>,
Catalin Marinas <catalin.marinas@arm.com>,
X86 ML <x86@kernel.org>, Will Deacon <will.deacon@arm.com>,
LKML <linux-kernel@vger.kernel.org>,
Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
"Woodhouse, David" <dwmw@amazon.co.uk>,
Andy Lutomirski <luto@kernel.org>,
"H. Peter Anvin" <hpa@zytor.com>,
Andrew Morton <akpm@linux-foundation.org>,
Thomas Gleixner <tglx@linutronix.de>,
linux-arm-kernel <linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH 2/2] x86/mmap: handle worst-case heap randomization in mmap_base
Date: Mon, 15 Apr 2019 16:03:34 +0000 [thread overview]
Message-ID: <34381CFC-A90F-4979-9802-2BA0E6539C68@amazon.com> (raw)
In-Reply-To: <CAGXu5jKcBmj0kwAqjqROXuOi=90=Upy8-J8WviGMjD6FV_Guxg@mail.gmail.com>
On 3/27/19, 2:52 PM, "linux-arm-kernel on behalf of Kees Cook" <linux-arm-kernel-bounces@lists.infradead.org on behalf of keescook@chromium.org> wrote:
Adding some more people to CC... what do people think about this
moving of the brk to ELF_ET_DYN_BASE in this corner-case? Anything
that worked before should still work (i.e. the ultimately-launched
binary already had the brk very far from its text, so this should be
no different from a COMPAT_BRK standpoint). The only risk I see here
is that if someone started to suddenly depend on the entire memory
space above the mmap region being available when launching binaries
via a direct loader execs... which seems highly unlikely, I'd hope:
this would mean a binary would not work when execed normally.
Kees' proposal addresses the issue for me. Anyone have concerns on this proposed solution?
Ali
WARNING: multiple messages have this Message-ID (diff)
From: "Saidi, Ali" <alisaidi@amazon.com>
To: Kees Cook <keescook@chromium.org>, Michal Hocko <mhocko@suse.com>,
Matthew Wilcox <willy@infradead.org>,
Jann Horn <jannh@google.com>
Cc: X86 ML <x86@kernel.org>, Andy Lutomirski <luto@kernel.org>,
Peter Zijlstra <peterz@infradead.org>,
Catalin Marinas <catalin.marinas@arm.com>,
Dave Hansen <dave.hansen@linux.intel.com>,
Will Deacon <will.deacon@arm.com>,
LKML <linux-kernel@vger.kernel.org>,
Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
"Liguori, Anthony" <aliguori@amazon.com>,
"H. Peter Anvin" <hpa@zytor.com>,
Andrew Morton <akpm@linux-foundation.org>,
Thomas Gleixner <tglx@linutronix.de>,
"Woodhouse, David" <dwmw@amazon.co.uk>
Subject: Re: [PATCH 2/2] x86/mmap: handle worst-case heap randomization in mmap_base
Date: Mon, 15 Apr 2019 16:03:34 +0000 [thread overview]
Message-ID: <34381CFC-A90F-4979-9802-2BA0E6539C68@amazon.com> (raw)
In-Reply-To: <CAGXu5jKcBmj0kwAqjqROXuOi=90=Upy8-J8WviGMjD6FV_Guxg@mail.gmail.com>
On 3/27/19, 2:52 PM, "linux-arm-kernel on behalf of Kees Cook" <linux-arm-kernel-bounces@lists.infradead.org on behalf of keescook@chromium.org> wrote:
Adding some more people to CC... what do people think about this
moving of the brk to ELF_ET_DYN_BASE in this corner-case? Anything
that worked before should still work (i.e. the ultimately-launched
binary already had the brk very far from its text, so this should be
no different from a COMPAT_BRK standpoint). The only risk I see here
is that if someone started to suddenly depend on the entire memory
space above the mmap region being available when launching binaries
via a direct loader execs... which seems highly unlikely, I'd hope:
this would mean a binary would not work when execed normally.
Kees' proposal addresses the issue for me. Anyone have concerns on this proposed solution?
Ali
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-04-15 16:10 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-12 17:32 [PATCH 0/2] handle worst-case heap randomization in mmap_base Ali Saidi
2019-03-12 17:32 ` Ali Saidi
2019-03-12 17:32 ` [PATCH 1/2] arm64/mmap: " Ali Saidi
2019-03-12 17:32 ` Ali Saidi
2019-03-12 17:32 ` [PATCH 2/2] x86/mmap: " Ali Saidi
2019-03-12 17:32 ` Ali Saidi
2019-03-13 16:25 ` Dave Hansen
2019-03-13 16:25 ` Dave Hansen
2019-03-17 15:52 ` Saidi, Ali
2019-03-17 15:52 ` Saidi, Ali
2019-03-13 22:58 ` Kees Cook
2019-03-13 22:58 ` Kees Cook
2019-03-27 19:51 ` Kees Cook
2019-03-27 19:51 ` Kees Cook
2019-04-15 16:03 ` Saidi, Ali [this message]
2019-04-15 16:03 ` Saidi, Ali
2019-04-19 8:51 ` Ingo Molnar
2019-04-19 8:51 ` Ingo Molnar
2019-04-19 15:00 ` Kees Cook
2019-04-19 15:00 ` Kees Cook
2019-03-21 14:09 ` Thomas Gleixner
2019-03-21 14:09 ` Thomas Gleixner
2019-03-26 2:13 ` Saidi, Ali
2019-03-26 2:13 ` Saidi, Ali
2019-03-26 8:43 ` Thomas Gleixner
2019-03-26 8:43 ` Thomas Gleixner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=34381CFC-A90F-4979-9802-2BA0E6539C68@amazon.com \
--to=alisaidi@amazon.com \
--cc=akpm@linux-foundation.org \
--cc=aliguori@amazon.com \
--cc=bp@alien8.de \
--cc=catalin.marinas@arm.com \
--cc=dave.hansen@linux.intel.com \
--cc=dwmw@amazon.co.uk \
--cc=hpa@zytor.com \
--cc=jannh@google.com \
--cc=keescook@chromium.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@kernel.org \
--cc=mhocko@suse.com \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=tglx@linutronix.de \
--cc=will.deacon@arm.com \
--cc=willy@infradead.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.