All of lore.kernel.org
 help / color / mirror / Atom feed
From: <Conor.Dooley@microchip.com>
To: <sudeep.holla@arm.com>
Cc: <linux-kernel@vger.kernel.org>, <gregkh@linuxfoundation.org>,
	<vincent.guittot@linaro.org>, <dietmar.eggemann@arm.com>,
	<ionela.voinescu@arm.com>, <pierre.gondois@arm.com>,
	<linux-arm-kernel@lists.infradead.org>,
	<linux-riscv@lists.infradead.org>
Subject: Re: [PATCH -next] arch_topology: Fix cache attributes detection in the CPU hotplug path
Date: Fri, 15 Jul 2022 14:04:41 +0000	[thread overview]
Message-ID: <343b8031-f2d7-0d53-6967-d2e5925703cf@microchip.com> (raw)
In-Reply-To: <8146f6e0-0682-4876-95d0-01e99141330d@microchip.com>

On 15/07/2022 10:16, Conor Dooley wrote:
> On 15/07/2022 10:11, Sudeep Holla wrote:
>> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
>>
>> On Thu, Jul 14, 2022 at 04:10:36PM +0000, Conor.Dooley@microchip.com wrote:
>>> With the GFP_ATOMIC, behaviour is the same as before for me.
>>>
>>
>> So you still get -ENOMEM failure on your platform. It is fine, just that
>> I am bit curious to know why as it succeeds at device_initcall later.
>> I was hoping this might fix your memory allocation failure.
> 
> Correct. 

I take that back. On today's next with patch 2 applied, I don't see a
problem with no memory, so this does appear to have sorted the memory
allocation failure. Sorry for misleading you & thanks!

With my patches for store_cpu_topology on RISC-V I do see it though,
when called on the boot cpu. I must have mixed up which I had tested.
I have a fix for that though & will update my patches later.

Thanks & apologies!
Conor.


WARNING: multiple messages have this Message-ID (diff)
From: <Conor.Dooley@microchip.com>
To: <sudeep.holla@arm.com>
Cc: <linux-kernel@vger.kernel.org>, <gregkh@linuxfoundation.org>,
	<vincent.guittot@linaro.org>, <dietmar.eggemann@arm.com>,
	<ionela.voinescu@arm.com>, <pierre.gondois@arm.com>,
	<linux-arm-kernel@lists.infradead.org>,
	<linux-riscv@lists.infradead.org>
Subject: Re: [PATCH -next] arch_topology: Fix cache attributes detection in the CPU hotplug path
Date: Fri, 15 Jul 2022 14:04:41 +0000	[thread overview]
Message-ID: <343b8031-f2d7-0d53-6967-d2e5925703cf@microchip.com> (raw)
In-Reply-To: <8146f6e0-0682-4876-95d0-01e99141330d@microchip.com>

On 15/07/2022 10:16, Conor Dooley wrote:
> On 15/07/2022 10:11, Sudeep Holla wrote:
>> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
>>
>> On Thu, Jul 14, 2022 at 04:10:36PM +0000, Conor.Dooley@microchip.com wrote:
>>> With the GFP_ATOMIC, behaviour is the same as before for me.
>>>
>>
>> So you still get -ENOMEM failure on your platform. It is fine, just that
>> I am bit curious to know why as it succeeds at device_initcall later.
>> I was hoping this might fix your memory allocation failure.
> 
> Correct. 

I take that back. On today's next with patch 2 applied, I don't see a
problem with no memory, so this does appear to have sorted the memory
allocation failure. Sorry for misleading you & thanks!

With my patches for store_cpu_topology on RISC-V I do see it though,
when called on the boot cpu. I must have mixed up which I had tested.
I have a fix for that though & will update my patches later.

Thanks & apologies!
Conor.

_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv

WARNING: multiple messages have this Message-ID (diff)
From: <Conor.Dooley@microchip.com>
To: <sudeep.holla@arm.com>
Cc: <linux-kernel@vger.kernel.org>, <gregkh@linuxfoundation.org>,
	<vincent.guittot@linaro.org>, <dietmar.eggemann@arm.com>,
	<ionela.voinescu@arm.com>, <pierre.gondois@arm.com>,
	<linux-arm-kernel@lists.infradead.org>,
	<linux-riscv@lists.infradead.org>
Subject: Re: [PATCH -next] arch_topology: Fix cache attributes detection in the CPU hotplug path
Date: Fri, 15 Jul 2022 14:04:41 +0000	[thread overview]
Message-ID: <343b8031-f2d7-0d53-6967-d2e5925703cf@microchip.com> (raw)
In-Reply-To: <8146f6e0-0682-4876-95d0-01e99141330d@microchip.com>

On 15/07/2022 10:16, Conor Dooley wrote:
> On 15/07/2022 10:11, Sudeep Holla wrote:
>> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
>>
>> On Thu, Jul 14, 2022 at 04:10:36PM +0000, Conor.Dooley@microchip.com wrote:
>>> With the GFP_ATOMIC, behaviour is the same as before for me.
>>>
>>
>> So you still get -ENOMEM failure on your platform. It is fine, just that
>> I am bit curious to know why as it succeeds at device_initcall later.
>> I was hoping this might fix your memory allocation failure.
> 
> Correct. 

I take that back. On today's next with patch 2 applied, I don't see a
problem with no memory, so this does appear to have sorted the memory
allocation failure. Sorry for misleading you & thanks!

With my patches for store_cpu_topology on RISC-V I do see it though,
when called on the boot cpu. I must have mixed up which I had tested.
I have a fix for that though & will update my patches later.

Thanks & apologies!
Conor.

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2022-07-15 14:05 UTC|newest]

Thread overview: 51+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-07-13 13:33 [PATCH -next] arch_topology: Fix cache attributes detection in the CPU hotplug path Sudeep Holla
2022-07-13 13:33 ` Sudeep Holla
2022-07-13 13:33 ` Sudeep Holla
2022-07-13 14:03 ` Greg Kroah-Hartman
2022-07-13 14:03   ` Greg Kroah-Hartman
2022-07-13 14:03   ` Greg Kroah-Hartman
2022-07-13 14:18   ` Sudeep Holla
2022-07-13 14:18     ` Sudeep Holla
2022-07-13 14:18     ` Sudeep Holla
2022-07-13 16:04 ` Conor.Dooley
2022-07-13 16:04   ` Conor.Dooley
2022-07-13 16:04   ` Conor.Dooley
2022-07-14 14:17 ` Conor.Dooley
2022-07-14 14:17   ` Conor.Dooley
2022-07-14 14:17   ` Conor.Dooley
2022-07-14 15:01   ` Sudeep Holla
2022-07-14 15:01     ` Sudeep Holla
2022-07-14 15:01     ` Sudeep Holla
2022-07-14 15:27     ` Conor.Dooley
2022-07-14 15:27       ` Conor.Dooley
2022-07-14 15:27       ` Conor.Dooley
2022-07-14 16:00       ` Sudeep Holla
2022-07-14 16:00         ` Sudeep Holla
2022-07-14 16:00         ` Sudeep Holla
2022-07-14 16:10         ` Conor.Dooley
2022-07-14 16:10           ` Conor.Dooley
2022-07-14 16:10           ` Conor.Dooley
2022-07-15  9:11           ` Sudeep Holla
2022-07-15  9:11             ` Sudeep Holla
2022-07-15  9:11             ` Sudeep Holla
2022-07-15  9:16             ` Conor.Dooley
2022-07-15  9:16               ` Conor.Dooley
2022-07-15  9:16               ` Conor.Dooley
2022-07-15 14:04               ` Conor.Dooley [this message]
2022-07-15 14:04                 ` Conor.Dooley
2022-07-15 14:04                 ` Conor.Dooley
2022-07-15 15:41                 ` Sudeep Holla
2022-07-15 15:41                   ` Sudeep Holla
2022-07-15 15:41                   ` Sudeep Holla
2022-07-14 17:52 ` Ionela Voinescu
2022-07-14 17:52   ` Ionela Voinescu
2022-07-14 17:52   ` Ionela Voinescu
2022-07-18 17:41 ` Guenter Roeck
2022-07-18 17:41   ` Guenter Roeck
2022-07-18 17:41   ` Guenter Roeck
2022-07-18 17:57   ` Conor.Dooley
2022-07-18 17:57     ` Conor.Dooley
2022-07-18 17:57     ` Conor.Dooley
2022-07-19 10:29     ` Sudeep Holla
2022-07-19 10:29       ` Sudeep Holla
2022-07-19 10:29       ` Sudeep Holla

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=343b8031-f2d7-0d53-6967-d2e5925703cf@microchip.com \
    --to=conor.dooley@microchip.com \
    --cc=dietmar.eggemann@arm.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=ionela.voinescu@arm.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-riscv@lists.infradead.org \
    --cc=pierre.gondois@arm.com \
    --cc=sudeep.holla@arm.com \
    --cc=vincent.guittot@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.