All of lore.kernel.org
 help / color / mirror / Atom feed
From: Eric Blake <eblake@redhat.com>
To: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>,
	qemu-devel@nongnu.org, qemu-block@nongnu.org
Cc: mreitz@redhat.com, kwolf@redhat.com, pbonzini@redhat.com, den@openvz.org
Subject: Re: [Qemu-devel] [PATCH 0/5] NBD reconnect: preliminary refactoring
Date: Thu, 17 May 2018 08:48:55 -0500	[thread overview]
Message-ID: <343bf957-869d-67b8-0e84-4eb30ca6c53e@redhat.com> (raw)
In-Reply-To: <0fac4939-20d0-b158-7279-fac31ff7baae@virtuozzo.com>

On 05/17/2018 04:54 AM, Vladimir Sementsov-Ogievskiy wrote:
> What about patches 1-4?

Still on my list to review (I'm first trying to post an updated proposal 
on the libvirt list for managing incremental backups); but on first 
glance, the idea of being able to reconnect instead of permanently 
switching to EIO failures on first error seems reasonable.

> 
> 07.05.2018 18:44, Vladimir Sementsov-Ogievskiy wrote:
>> Hi all!
>>
>> Here are some preliminary refactoring patches, before NBD reconnect
>> series.
>>
>> Vladimir Sementsov-Ogievskiy (5):
>>    block/nbd-client: split channel errors from export errors
>>    block/nbd: move connection code from block/nbd to block/nbd-client
>>    block/nbd-client: split connection from initialization
>>    block/nbd-client: fix nbd_reply_chunk_iter_receive
>>    block/nbd-client: don't check ioc
>>
>>   block/nbd-client.h |   2 +-
>>   block/nbd-client.c | 163 
>> ++++++++++++++++++++++++++++++++++-------------------
>>   block/nbd.c        |  41 +-------------
>>   3 files changed, 107 insertions(+), 99 deletions(-)
>>
> 
> 

-- 
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3266
Virtualization:  qemu.org | libvirt.org

  reply	other threads:[~2018-05-17 13:49 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-05-07 15:44 [Qemu-devel] [PATCH 0/5] NBD reconnect: preliminary refactoring Vladimir Sementsov-Ogievskiy
2018-05-07 15:44 ` [Qemu-devel] [PATCH 1/5] block/nbd-client: split channel errors from export errors Vladimir Sementsov-Ogievskiy
2018-05-07 15:44 ` [Qemu-devel] [PATCH 2/5] block/nbd: move connection code from block/nbd to block/nbd-client Vladimir Sementsov-Ogievskiy
2018-05-07 15:44 ` [Qemu-devel] [PATCH 3/5] block/nbd-client: split connection from initialization Vladimir Sementsov-Ogievskiy
2018-05-07 15:44 ` [Qemu-devel] [PATCH 4/5] block/nbd-client: fix nbd_reply_chunk_iter_receive Vladimir Sementsov-Ogievskiy
2018-05-07 15:44 ` [Qemu-devel] [PATCH 5/5] block/nbd-client: don't check ioc Vladimir Sementsov-Ogievskiy
2018-05-07 18:08   ` Eric Blake
2018-05-08  6:36     ` Vladimir Sementsov-Ogievskiy
2018-05-17  9:54 ` [Qemu-devel] [PATCH 0/5] NBD reconnect: preliminary refactoring Vladimir Sementsov-Ogievskiy
2018-05-17 13:48   ` Eric Blake [this message]
2018-05-18 11:32     ` Vladimir Sementsov-Ogievskiy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=343bf957-869d-67b8-0e84-4eb30ca6c53e@redhat.com \
    --to=eblake@redhat.com \
    --cc=den@openvz.org \
    --cc=kwolf@redhat.com \
    --cc=mreitz@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-block@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    --cc=vsementsov@virtuozzo.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.