From: Eric Blake <eblake@redhat.com>
To: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>,
qemu-devel@nongnu.org, qemu-block@nongnu.org
Cc: mreitz@redhat.com, kwolf@redhat.com, pbonzini@redhat.com, den@openvz.org
Subject: Re: [Qemu-devel] [PATCH 5/5] block/nbd-client: don't check ioc
Date: Mon, 7 May 2018 13:08:24 -0500 [thread overview]
Message-ID: <d061f619-d1f7-57be-d8f0-0792ca64504a@redhat.com> (raw)
In-Reply-To: <20180507154458.73945-6-vsementsov@virtuozzo.com>
On 05/07/2018 10:44 AM, Vladimir Sementsov-Ogievskiy wrote:
> We have several paranoiac checks for ioc != NULL. But ioc may become
> NULL only on close, which should not happen during requests handling.
> Also, we check ioc only sometimes, not after each yield, which is
> inconsistent. Let's drop these checks.
Can (or even should) any of these be replaced by asserts that ioc is not
NULL?
>
> Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
> ---
> block/nbd-client.c | 14 +-------------
> 1 file changed, 1 insertion(+), 13 deletions(-)
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3266
Virtualization: qemu.org | libvirt.org
next prev parent reply other threads:[~2018-05-07 18:08 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-07 15:44 [Qemu-devel] [PATCH 0/5] NBD reconnect: preliminary refactoring Vladimir Sementsov-Ogievskiy
2018-05-07 15:44 ` [Qemu-devel] [PATCH 1/5] block/nbd-client: split channel errors from export errors Vladimir Sementsov-Ogievskiy
2018-05-07 15:44 ` [Qemu-devel] [PATCH 2/5] block/nbd: move connection code from block/nbd to block/nbd-client Vladimir Sementsov-Ogievskiy
2018-05-07 15:44 ` [Qemu-devel] [PATCH 3/5] block/nbd-client: split connection from initialization Vladimir Sementsov-Ogievskiy
2018-05-07 15:44 ` [Qemu-devel] [PATCH 4/5] block/nbd-client: fix nbd_reply_chunk_iter_receive Vladimir Sementsov-Ogievskiy
2018-05-07 15:44 ` [Qemu-devel] [PATCH 5/5] block/nbd-client: don't check ioc Vladimir Sementsov-Ogievskiy
2018-05-07 18:08 ` Eric Blake [this message]
2018-05-08 6:36 ` Vladimir Sementsov-Ogievskiy
2018-05-17 9:54 ` [Qemu-devel] [PATCH 0/5] NBD reconnect: preliminary refactoring Vladimir Sementsov-Ogievskiy
2018-05-17 13:48 ` Eric Blake
2018-05-18 11:32 ` Vladimir Sementsov-Ogievskiy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d061f619-d1f7-57be-d8f0-0792ca64504a@redhat.com \
--to=eblake@redhat.com \
--cc=den@openvz.org \
--cc=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=vsementsov@virtuozzo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.