All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jerome Pouiller <Jerome.Pouiller@silabs.com>
To: Jules Irenge <jbi.octave@gmail.com>
Cc: "gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
	"devel@driverdev.osuosl.org" <devel@driverdev.osuosl.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2 3/3] staging: wfx: replace u32 by __le32
Date: Mon, 11 Nov 2019 16:58:20 +0000	[thread overview]
Message-ID: <3445403.d56fhTCmfW@pc-42> (raw)
In-Reply-To: <20191111133055.214410-3-jbi.octave@gmail.com>

On Monday 11 November 2019 14:30:55 CET Jules Irenge wrote:
[...]
> -       u32   count_rts_failures;
> -       u32   count_ack_failures;
> -       u32   count_rx_multicast_frames;
> -       u32   count_rx_frames_success;
> -       u32   count_rx_cmacicv_errors;
> -       u32   count_rx_cmac_replays;
> -       u32   count_rx_mgmt_ccmp_replays;
[...]
> +       __le32   count_rts_failures;
> +       __le32   count_rx_multicast_frames;
> +       __le32   count_rx_cmacicv_errors;
> +       __le32   count_rx_cmac_replays;
> +       __le32   count_rx_mgmt_ccmp_replays;
> +       __le32   count_rx_beacon;
> +       __le32   count_miss_beacon;
> +       __le32   count_ack_failures;
> +       __le32   count_rx_frames_success;
>         u32   count_rx_bipmic_errors;
> -       u32   count_rx_beacon;
> -       u32   count_miss_beacon;

Hello Jules,

Your patch reorders members of the structure. It will break API with the 
chip.

-- 
Jérôme Pouiller


WARNING: multiple messages have this Message-ID (diff)
From: Jerome Pouiller <Jerome.Pouiller@silabs.com>
To: Jules Irenge <jbi.octave@gmail.com>
Cc: "devel@driverdev.osuosl.org" <devel@driverdev.osuosl.org>,
	"gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2 3/3] staging: wfx: replace u32 by __le32
Date: Mon, 11 Nov 2019 16:58:20 +0000	[thread overview]
Message-ID: <3445403.d56fhTCmfW@pc-42> (raw)
In-Reply-To: <20191111133055.214410-3-jbi.octave@gmail.com>

On Monday 11 November 2019 14:30:55 CET Jules Irenge wrote:
[...]
> -       u32   count_rts_failures;
> -       u32   count_ack_failures;
> -       u32   count_rx_multicast_frames;
> -       u32   count_rx_frames_success;
> -       u32   count_rx_cmacicv_errors;
> -       u32   count_rx_cmac_replays;
> -       u32   count_rx_mgmt_ccmp_replays;
[...]
> +       __le32   count_rts_failures;
> +       __le32   count_rx_multicast_frames;
> +       __le32   count_rx_cmacicv_errors;
> +       __le32   count_rx_cmac_replays;
> +       __le32   count_rx_mgmt_ccmp_replays;
> +       __le32   count_rx_beacon;
> +       __le32   count_miss_beacon;
> +       __le32   count_ack_failures;
> +       __le32   count_rx_frames_success;
>         u32   count_rx_bipmic_errors;
> -       u32   count_rx_beacon;
> -       u32   count_miss_beacon;

Hello Jules,

Your patch reorders members of the structure. It will break API with the 
chip.

-- 
Jérôme Pouiller

_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

  parent reply	other threads:[~2019-11-11 16:58 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-11-11 13:30 [PATCH v2 1/3] staging: wfx: replace uintXX_t to uXX and intXX_t to sXX Jules Irenge
2019-11-11 13:30 ` Jules Irenge
2019-11-11 13:30 ` [PATCH v2 2/3] staging: wfx: wrap characters Jules Irenge
2019-11-11 13:30   ` Jules Irenge
2019-11-11 15:34   ` Greg KH
2019-11-11 15:34     ` Greg KH
2019-11-11 13:30 ` [PATCH v2 3/3] staging: wfx: replace u32 by __le32 Jules Irenge
2019-11-11 13:30   ` Jules Irenge
2019-11-11 14:12   ` Greg KH
2019-11-11 14:12     ` Greg KH
2019-11-11 16:58   ` Jerome Pouiller [this message]
2019-11-11 16:58     ` Jerome Pouiller
2019-11-11 23:15     ` Joe Perches
2019-11-11 23:15       ` Joe Perches
2019-11-11 17:04 ` [PATCH v2 1/3] staging: wfx: replace uintXX_t to uXX and intXX_t to sXX Jerome Pouiller
2019-11-11 17:04   ` Jerome Pouiller
2019-11-11 17:48   ` gregkh
2019-11-11 17:48     ` gregkh

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3445403.d56fhTCmfW@pc-42 \
    --to=jerome.pouiller@silabs.com \
    --cc=devel@driverdev.osuosl.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=jbi.octave@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.